[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83108745 --- Diff: twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java --- @@ -41,7 +43,8 @@ private static final String

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83083471 --- Diff: twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java --- @@ -30,17 +34,33 @@ private final int memoryMB;

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83089162 --- Diff: twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java --- @@ -149,6 +161,51 @@ public void setServices(List services) {

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83112064 --- Diff: twill-core/src/main/java/org/apache/twill/internal/utils/LogLevelUtil.java --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83116829 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -951,4 +958,34 @@ public void run() { }

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83116780 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -200,7 +201,9 @@ private RunningContainers

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83118218 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -132,16 +149,22 @@ void start(String runnableName,

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83117233 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -951,4 +958,34 @@ public void run() { }

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83108717 --- Diff: twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java --- @@ -41,7 +43,8 @@ private static final String

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-10-12 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r83083453 --- Diff: twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java --- @@ -30,17 +34,33 @@ private final int memoryMB;

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570005#comment-15570005 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570002#comment-15570002 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570055#comment-15570055 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570257#comment-15570257 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570260#comment-15570260 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570256#comment-15570256 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570254#comment-15570254 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570162#comment-15570162 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull