[MariaDB developers] Re: f3aa4d0a215: MDEV-29447 MDEV-26285 MDEV-31338 Refactor spider_db_mbase_util::open_item_func

Hi, Yuchen, On Jun 20, Yuchen Pei wrote: > revision-id: f3aa4d0a215 (mariadb-10.4.30-4-gf3aa4d0a215) > parent(s): f5dceafd0ba > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-06-14 15:02:38 +1000 > message: > > MDEV-29447 MDEV-26285 MDEV-31338 Refactor > spider_db_mbase_util::o

[MariaDB developers] Re: f3aa4d0a215: MDEV-29447 MDEV-26285 MDEV-31338 Refactor spider_db_mbase_util::open_item_func

Hi, Yuchen, On Jun 21, Yuchen Pei wrote: > > > >> Signed-off-by: Yuchen Pei > > > > also, it looks strange to sign-off your own commits > > I thought I needed this for gpg sign, but just learned they are two > different things. So I have removed the sign-off. By the way why is it > strang

[MariaDB developers] Re: 8d51c6d234b: MDEV-30164 System variable for default collations

Hi, Alexander, Please, see comments below. Sorry, it took a while. On Jun 23, Alexander Barkov wrote: > revision-id: 8d51c6d234b (mariadb-10.11.2-13-g8d51c6d234b) > parent(s): ceb0e7f944b > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2023-03-21 10:07:57 +0400 > message: >

[MariaDB developers] Re: d23555b1920: MDEV-30984 Online ALTER table is denied with non-informative error messages

Hi, Nikita, On Jun 24, Nikita Malyavin wrote: > revision-id: d23555b1920 (mariadb-11.0.1-138-gd23555b1920) > parent(s): df90bf34644 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-06-20 16:10:48 +0300 > message: > > MDEV-30984 Online ALTER table is denied with non-informa

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Daniel, On Jun 28, Lenski, Daniel via developers wrote: > Hi! > > I would like to propose a new feature in the MariaDB client-server > protocol: > application-layer redirection of client connections. > > We want the MariaDB server to be able to

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Daniel, On Jun 29, Lenski, Daniel wrote: > Hi Sergei, > > > > I'm afraid MDEV-15935 is a bit confusing. There are lots of > > discussions and ideas in the comments, like, using a specially > > modified OK packet, using the error message, etc. > > Right! I got the sense from the Jira discussi

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Lenski,, On Jun 30, Lenski, Daniel wrote: > On Fri, 2023-06-30 at 13:29 +0200, Sergei Golubchik wrote: > > There was an original pull request from ~5 years ago, but then the > > contributor disappeared and I didn't want to do anything until they'd at > > least confirm that the new suggested ap

[MariaDB developers] Re: a2e71bc8e89: MDEV-22979 MDEV-31400 Fixing spider init bugs

Hi, Yuchen, On Jun 13, Yuchen Pei wrote: > Hi Sergei, > > Thanks for the comments. I have addressed them and the url of the new > patch can be found in the new request for review comment in the > ticket. Thanks. I'll send a separate email with comments on the new patch. Here I'll just reply to y

[MariaDB developers] Re: 8b5de389ab1: MDEV-31400 Simple plugin dependency resolution

Hi, Yuchen, On Jul 01, Yuchen Pei wrote: > revision-id: 8b5de389ab1 (mariadb-10.9.5-17-g8b5de389ab1) > parent(s): d8997f875e2 > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-06-13 20:08:28 +1000 > message: > > MDEV-31400 Simple plugin dependency resolution > > We introduce simple p

[MariaDB developers] Re: d23555b1920: MDEV-30984 Online ALTER table is denied with non-informative error messages

Hi, Nikita, On Jul 05, Nikita Malyavin wrote: > On Sat, 24 Jun 2023 at 18:51, Sergei Golubchik wrote: > > > > @@ -1228,6 +1228,15 @@ class Query_arena > > >{ return strdup_root(mem_root,str); } > > >inline char *strmake(const char *str, size_t size) const > > >{ return strmake_root(m

[MariaDB developers] Re: d23555b1920: MDEV-30984 Online ALTER table is denied with non-informative error messages

Hi, Nikita, On Jul 06, Nikita Malyavin wrote: > > > > @@ -9869,26 +9869,21 @@ bool online_alter_check_autoinc > > > > >*/ > > > > >for (uint k= 0; k < table->s->keys; k++) > > > > >{ > > > > > -const KEY &key= table->s->key_info[k]; > > > > > +const KEY &key= table->key_info[k]

[MariaDB developers] Re: d8e04ef367b: MDEV-25237 Assertion `global_system_variables.session_track_system_variables' failed in Session_sysvars_tracker::init | SIGSEGV's in __strlen_avx2 | UBSAN: runtim

Hi, Oleksandr, On Jul 07, Oleksandr Byelkin wrote: > revision-id: d8e04ef367b (mariadb-10.4.30-9-gd8e04ef367b) > parent(s): 423c28f0aa4 > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2023-07-03 17:50:49 +0200 > message: > > MDEV-25237 Assertion `global_system_variables.se

[MariaDB developers] Re: 8d51c6d234b: MDEV-30164 System variable for default collations

Hi, Alexander, On Jul 07, Alexander Barkov wrote: > On 6/24/23 12:20 AM, Sergei Golubchik wrote: > > > > > diff --git a/sql/lex_charset.cc b/sql/lex_charset.cc > > > --- a/sql/lex_charset.cc > > > +++ b/sql/lex_charset.cc > > > @@ -447,6 +451,17 @@ > > > Lex_exact_charset_opt_extended_collate::fi

[MariaDB developers] Re: 8e9c68b49dd: MDEV-25237 Assertion `global_system_variables.session_track_system_variables' failed in Session_sysvars_tracker::init | SIGSEGV's in __strlen_avx2 | UBSAN: runtim

Hi, Sanja, ok to push. but see comments below: On Jul 15, Oleksandr Byelkin wrote: > revision-id: 8e9c68b49dd (mariadb-10.4.30-9-g8e9c68b49dd) > parent(s): 423c28f0aa4 > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2023-07-10 13:40:46 +0200 > message: > > MDEV-25237 Asse

[MariaDB developers] Re: 5102d86beae: MDEV-30164 System variable for default collations

Hi, Alexander, Looks good, thanks. ok to push. a couple of comments below - but really, on remnants of the previous version of the commit. On Jul 17, Alexander Barkov wrote: > revision-id: 5102d86beae (mariadb-10.11.2-47-g5102d86beae) > parent(s): 3430767e006 > author: Alexander Barkov > committ

[MariaDB developers] Re: 845fbe9ce01: MDEV-30820 slow log Rows_examined out of range

Hi, Sanja, The patch is ok, but the test case is rather weird. What does it do? How long does it run? On Jul 17, Oleksandr Byelkin wrote: > revision-id: 845fbe9ce01 (mariadb-10.4.30-30-g845fbe9ce01) > parent(s): 02cd3675c4d > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2

[MariaDB developers] Re: 845fbe9ce01: MDEV-30820 slow log Rows_examined out of range

Hi, Oleksandr, But is it all necessary to show the bug? may be a test case could be much simpler? On Jul 17, Oleksandr Byelkin wrote: > Hi! > > Sergei Golubchik schrieb am Mo., 17. Juli 2023, 13:11: > > > Hi, Sanja, > > > > The patch is ok, but the test case is rather weird. > > What does it d

[MariaDB developers] Re: 845fbe9ce01: MDEV-30820 slow log Rows_examined out of range

Hi, Oleksandr, On Jul 18, Oleksandr Byelkin wrote: > On Tue, Jul 18, 2023 at 11:23 AM Sergei Golubchik wrote: > > > But is it all necessary to show the bug? may be a test case could be > > much simpler? > > > I just rely on Elena, but if you think it is worth it I can spend more > time studying t

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Andrey, On Jul 19, andrey.sidorov--- via developers wrote: > Hi Daniel, > > Have you considered using AUTH_SWITCH_REQUEST for that purpose? That > would allow redirect to happen after switch to TLS and client/server > certificate validation. One of the main use cases at the moment is to redi

[MariaDB developers] Re: 534031b77e0: MDEV-31400 Simple plugin dependency resolution

Hi, Yuchen, Thanks. Conceptually all good, the approach is correct. See comments below - about the state and about user visible warnings, nothing major. On Jul 18, Yuchen Pei wrote: > revision-id: 534031b77e0 (mariadb-10.9.5-17-g534031b77e0) > parent(s): d8997f875e2 > author: Yuchen Pei > committ

[MariaDB developers] Re: ca64ddcc709: MDEV-31646 Online alter applies binlog cache limit to cache writes

Hi, Nikita, This is a review of all the three commits On Jul 20, Nikita Malyavin wrote: > revision-id: ca64ddcc709 (mariadb-11.0.1-144-gca64ddcc709) > parent(s): f34c7419cb8 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-07-19 02:31:32 +0400 > message: > > MDEV-31646 On

[MariaDB developers] Re: 08403d85b00: MDEV-31677 Assertion failed upon online ALTER with binlog_row_image=NOBLOB

Hi, Nikita, ok to push after making few small changes, see inline: On Jul 20, Nikita Malyavin wrote: > revision-id: 08403d85b00 (mariadb-11.0.1-147-g08403d85b00) > parent(s): a31b2a52119 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-07-19 19:08:51 +0400 > message: > >

[MariaDB developers] Re: 64ac6ed3e35: MDEV-31742 incorrect examined rows in case of stored function usage

Hi, Oleksandr, On Jul 21, Oleksandr Byelkin wrote: > revision-id: 64ac6ed3e35 (mariadb-10.4.30-31-g64ac6ed3e35) > parent(s): 55a27bac80c > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2023-07-19 16:14:39 +0200 > message: > > MDEV-31742 incorrect examined rows in case of s

[MariaDB developers] Re: 64ac6ed3e35: MDEV-31742 incorrect examined rows in case of stored function usage

Hi, Sanja, Hmm, what author do you have in mind, Timour? I suggest to remove this now and not leave dead code around. On Jul 21, Oleksandr Byelkin wrote: > I also thought about removing it, but then decided to let the author to fix > it, here is an urgent fix because as the previous bug showed, o

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Otto, Automatically performing the upgrade in the server would pretty much mean that downgrade is officially impossible. Historically the server mostly worked fine without mysql_upgrade, with few exceptions (like, when a bug in collations required indexes to be rebuilt). Nowadays it seems we

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Vicențiu, On Jul 27, Vicențiu Ciorbaru wrote: > > Rather than offer a half-truth, I would us just take a clear stance. > We either fully support downgrading between minor versions officially > (which has implications on how we approach bug fixes, especially on > the storage side), or we don't

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Otto, On Jul 27, Otto Kekäläinen wrote: > Hi! > > > Automatically performing the upgrade in the server would pretty much > > mean that downgrade is officially impossible. > > > > Historically the server mostly worked fine without mysql_upgrade, > > with few exceptions (like, when a bug in col

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Vicențiu, There's a compromise approach - mariadb-upgrade is required (and thus downgrade does not work) between major versions, but mariadb-upgrade is not needed (and downgrade works) between minor versions. So, again, to summarize: Premise: if mariadb-upgrade is required between versions X

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Otto, On Jul 23, Otto Kekäläinen wrote: > > > Have you considered using AUTH_SWITCH_REQUEST for that purpose? > > > That would allow redirect to happen after switch to TLS and > > > client/server certificate validation. > > > > One of the main use cases at the moment is to redirect clients to

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Otto, On Jul 29, Otto Kekäläinen wrote: > > The switchover is initiated and decided by the DBA controlling the > server. You cannot possibly expect it to be controlled by the client - > and in particular to be decided by the *slowest* client. The server > can allow some time for the draining

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Vicențiu, Monty voiced his opinion too, by editing the knowledge base page here: https://mariadb.com/kb/en/downgrading-between-major-versions-of-mariadb/ It seems that he prefers the "compromise approach", downgrade is supported between versions that only differ in the third version component

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Jean, How granular it should be? Currently every frm stores the server version that created it. So if all tables in the mysql schema were created before the current server version - the downgrade is safe (with one exception). Except for mysql.global_priv - this one stores the version in ever

[MariaDB developers] Re: Proposal: mariadbd should automatically upgrade system tables and data directory on startup

Hi, Jean, On Aug 02, Jean Weisbuch via developers wrote: > If i'm not mistaken, mariadb-upgrade only modifies the structure of > the "mysql" database so storing and comparing only one "structure > version" for this database would be enough. Mostly, but not always. Sometimes it modifies other tabl

[MariaDB developers] Re: 44b4a3e64fa: MDEV-31777 ER_GET_ERRNO upon online alter on CONNECT table

Hi, Nikita, Generally, please, prefer table flags over new virtual function. E.g. *online= new_table->file->ha_table_flags() & HA_CAN_ONLINE_ALTER; But in this particular case there's no reason for a engine to not support online alter, it's just CONNECT being very weird. Like you wrote, it do

[MariaDB developers] Re: Running msqld with thread sanitizer

Hi, Thejaka, On Aug 03, Thejaka Amila J Kanewala via developers wrote: > Hello, > > I am trying to build and run a thread sanitized mysqld binary. In the > CMake configuration, I see the WITH_ASAN option, however, I do not see > an option to build mysqld with the thread sanitizer. What MariaDB v

[MariaDB developers] Re: Running msqld with thread sanitizer

Hi, Thejaka, 10.2 is two years out of support. Any bugs you possibly find in 10.2 will never be fixed - there will be no new 10.2 releases. Better use an active release, 10.4 or later. The latest is 11.2 at the moment, the latest LTS is 10.11. Regards, Sergei VP of MariaDB Server Engineering and

[MariaDB developers] Re: b508107c7a3: MDEV-31631 Adding auto-increment to table with history online misbehaves

Hi, Nikita, Looks good. One comment below: On Aug 04, Nikita Malyavin wrote: > revision-id: b508107c7a3 (mariadb-11.0.1-189-gb508107c7a3) > parent(s): e9a75c98781 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-07-29 00:13:48 +0400 > message: > > MDEV-31631 Adding auto-i

[MariaDB developers] Re: 63c93f89af9: MDEV-31804 Assertion `thd->m_transaction_psi == __null' fails

Hi, Nikita, On Aug 07, Nikita Malyavin wrote: > revision-id: 63c93f89af9 (mariadb-11.0.1-192-g63c93f89af9) > parent(s): a75ba4caa51 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-08-05 20:17:41 +0400 > message: > > MDEV-31804 Assertion `thd->m_transaction_psi == __null'

[MariaDB developers] Re: 88a77860a8b: MDEV-31804 Assertion `thd->m_transaction_psi == __null' fails

Hi, Nikita, On Aug 08, Nikita Malyavin wrote: > revision-id: 88a77860a8b (mariadb-11.0.1-194-g88a77860a8b) > parent(s): 73a677f0306 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-08-07 22:45:11 +0400 > message: > > MDEV-31804 Assertion `thd->m_transaction_psi == __null'

[MariaDB developers] Re: 88a77860a8b: MDEV-31804 Assertion `thd->m_transaction_psi == __null' fails

Hi, Nikita, On Aug 08, Nikita Malyavin wrote: > yes, extra safety can be worth it. I'd also add an assertion on top of > that: > > --- a/sql/sql_table.cc > +++ b/sql/sql_table.cc > @@ -12181,6 +12181,7 @@ copy_data_between_tables(THD *thd, TABLE *from, > TABLE *> > if (error) >from->

[MariaDB developers] Re: ca64ddcc709: MDEV-31646 Online alter applies binlog cache limit to cache writes

Hi, Nikita, On Jul 25, Nikita Malyavin wrote: > > Regarding MDEV-31646 preserve DMLs in case of online binlog fault: > It's changes are shown there as a part of ca64ddcc709, but it's > important to point out that it's a separate thing: It is the commit > that introduces error reporting to the ALT

[MariaDB developers] Re: 88a77860a8b: MDEV-31804 Assertion `thd->m_transaction_psi == __null' fails

Hi, Nikita, On Aug 08, Nikita Malyavin wrote: > > It doesn't just avoid sql_command reset: look through the > slave_exec_mode usage -- it does a few things that can have > side-effects. Better to avoid it altogether and keep our execution > flow away from interactions with replication switches.

[MariaDB developers] Re: ca64ddcc709: MDEV-31646 Online alter applies binlog cache limit to cache writes

Hi, Nikita, On Aug 09, Nikita Malyavin wrote: > > > diff --git a/sql/log_event.cc b/sql/log_event.cc > > > index 10180a95d99..0c4c284a40f 100644 > > > --- a/sql/log_event.cc > > > +++ b/sql/log_event.cc > > > @@ -761,16 +761,21 @@ Log_event::Log_event(const uchar *buf, > > > > > > int Log_event::

[MariaDB developers] Re: 9c52eede2c8: MDEV-31646 Online alter applies binlog cache limit to cache writes

Hi, Nikita, On Aug 14, Nikita Malyavin wrote: > revision-id: 9c52eede2c8 (mariadb-11.0.1-175-g9c52eede2c8) > parent(s): 209c894b431 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-08-11 16:29:37 +0400 > message: > > MDEV-31646 Online alter applies binlog cache limit to ca

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Otto, On Aug 16, Otto Kekäläinen wrote: > Hello Sergei and Yuchen! > > I was looking at the code Yuchen wrote this week [1]. Thinking back > about practical scenarios on how the redirect would be used to > gracefully decommission server A and have all existing and new > connections user serve

[MariaDB developers] Re: Client-server protocol improvement proposal: Connection redirection

Hi, Otto, On Aug 18, Otto Kekäläinen wrote: > > Yes, if the client doesn't support redirects, it'll work as before - > > that is, the client will be kicked out when the server is shut down > > and then the client will connect to a new server because, of course, > > if there's failover, there must

[MariaDB developers] Re: 23b15d24eb3: cleanup: add Field::store_yesno

Hi, Nikita, On Aug 31, Nikita Malyavin wrote: > revision-id: 23b15d24eb3 (mariadb-11.0.1-227-g23b15d24eb3) > parent(s): cb37c99dd87 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-08-30 13:18:52 +0400 > message: > > cleanup: add Field::store_yesno I agree, it's a good id

[MariaDB developers] Re: 82a49812507: MDEV-22597 Add views for periods in information_schema

Hi, Nikita, On Aug 31, Nikita Malyavin wrote: > revision-id: 82a49812507 (mariadb-11.0.1-228-g82a49812507) > parent(s): 23b15d24eb3 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-08-30 22:49:36 +0400 > message: > > MDEV-22597 Add views for periods in information_schema >

[MariaDB developers] Re: 04b99a30a3f: MDEV-15935 Adding global/session var redirect_url

Hi, Yuchen, On Sep 01, Yuchen Pei wrote: > revision-id: 04b99a30a3f (mariadb-11.0.1-103-g04b99a30a3f) > parent(s): 4f39ae75606 > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-08-16 11:31:16 +1000 > message: > > MDEV-15935 Adding global/session var redirect_url > > Adding a global/

[MariaDB developers] Re: 82a49812507: MDEV-22597 Add views for periods in information_schema

Hi, Nikita, On Sep 03, Nikita Malyavin wrote: > > > + if(!err) err= schema_table->field[1]->store(db_name, cs); > > > + if(!err) err= schema_table->field[2]->store(table_name, cs); > > > + if(!err) err= schema_table->field[3]->store(period.name, cs); > > > > well, ok. but as you've seen elsewh

[MariaDB developers] Re: 82a49812507: MDEV-22597 Add views for periods in information_schema

Hi, Nikita, On Sep 03, Nikita Malyavin wrote: > One more stack of questions: > > > > +show columns from t1; > > > +FieldTypeNullKey Default Extra > > > +id int(11) NO PRI NULL > > > +stimestamp(6)NO NULL > > > +etimestamp(6)NO

[MariaDB developers] Re: 8114fb63bbb: MDEV-31684: Add timezone information to DATE_FORMAT

Hi, Rucha, Few comments, after I saw the commit in the branch: On Sep 04, Rucha Deodhar wrote: > revision-id: 8114fb63bbb (mariadb-11.0.1-229-g8114fb63bbb) > parent(s): 7ba9c7fb84b > author: Rucha Deodhar > committer: Rucha Deodhar > timestamp: 2023-09-01 11:01:09 +0530 > message: > > MDEV-31684:

[MariaDB developers] Re: 44e692d0dbc: MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Hi, Oleksandr, On Sep 04, Oleksandr Byelkin wrote: > revision-id: 44e692d0dbc (mariadb-11.0.1-228-g44e692d0dbc) > parent(s): 9cb75f333fa > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2023-09-04 14:12:29 +0200 > message: > > MDEV-29167 new db-level SHOW CREATE ROUTINE pri

[MariaDB developers] Re: 44e692d0dbc: MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Hi, Oleksandr, On Sep 06, Oleksandr Byelkin wrote: > > > > > > +ALTER TABLE db ADDShow_create_routine_priv enum('N','Y') COLLATE > > > utf8mb3_general_ci NOT NULL DEFAULT 'N' AFTER Delete_history_priv; > > > +ALTER TABLE db modify Show_create_routine_priv enum('N','Y') COLLATE > > > utf8mb3_

[MariaDB developers] Re: 365faf7229f: MDEV-15935 Clean up string sys_var types.

Hi, Yuchen, On Sep 08, Yuchen Pei wrote: > revision-id: 365faf7229f (mariadb-11.0.1-103-g365faf7229f) > parent(s): 4f39ae75606 > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-09-08 13:12:22 +1000 > message: > > MDEV-15935 Clean up string sys_var types. > > Merge sys_var_charptr wi

[MariaDB developers] Re: 8ac17273b14: MDEV-15935 Adding global/session system var redirect_url

Hi, Yuchen, Right. This is pretty much the whole feature. Mostly ok, few minor comments below. On Sep 08, Yuchen Pei wrote: > revision-id: 8ac17273b14 (mariadb-11.0.1-104-g8ac17273b14) > parent(s): 365faf7229f > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-09-08 14:46:50 +1000 > m

[MariaDB developers] Re: [PATCH] MDEV-31872 Deprecate ENCODE()/DECODE()

Hi, Kristian, On Sep 11, Kristian Nielsen wrote: > Kristian Nielsen writes: > > > From: Sergei Golubchik > > > @@ -2724,6 +2725,10 @@ bool Item_func_encode::seed() > >hash_password(rand_nr, key->ptr(), key->length()); > >sql_crypt.init(rand_nr); > > > > + push_warning_printf(thd, Sq

[MariaDB developers] Re: [PATCH] MDEV-31872 Deprecate ENCODE()/DECODE()

Hi, Kristian, On Sep 11, Kristian Nielsen wrote: > Kristian Nielsen via developers writes: > > > If you want to give a warning for these functions, then you need to > > create an SQL mode or some other handle for the DBA to disable the > > warning and keep their application running. And the warn

[MariaDB developers] Re: Avoiding regressions in upgrades (Was: Re: [PATCH] MDEV-31872 Deprecate ENCODE()/DECODE())

Hi, Kristian, On Sep 11, Kristian Nielsen wrote: > Sergei Golubchik via developers writes: > > > And yes, we expect her to rewrite the application before we read on > > I think this is the core of the problem: > > "we expect her to rewrite the applicatio

[MariaDB developers] Re: 75ea482c4fc: MDEV-30973 GTID in deadlock output

Hi, Aleksey, On Sep 11, Aleksey Midenkov wrote: > revision-id: 75ea482c4fc (mariadb-11.0.1-230-g75ea482c4fc) > parent(s): fe62f70fb4b > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: 2023-09-01 20:30:24 +0300 > message: > > MDEV-30973 GTID in deadlock output > > Example: >

[MariaDB developers] Re: 365faf7229f: MDEV-15935 Clean up string sys_var types.

Hi, Yuchen, On Sep 12, Yuchen Pei wrote: > > Hi, Yuchen, > > > [... 19 lines elided] > > >> diff --git a/sql/sql_class.cc b/sql/sql_class.cc > >> index 18e796655bd..52fa6c27112 100644 > >> --- a/sql/sql_class.cc > >> +++ b/sql/sql_class.cc > >> @@ -1233,10 +1233,12 @@ void THD::init() > >>

[MariaDB developers] Re: [MariaDB commits] [PATCH] MDEV-31872: Add --old_mode=COMPAT_DISCOURAGED

Hi, Kristian, On Sep 12, Kristian Nielsen wrote: > > diff --git a/sql/sys_vars.cc b/sql/sys_vars.cc > index e25d293bbb7..18d08996aa8 100644 > --- a/sql/sys_vars.cc > +++ b/sql/sys_vars.cc > @@ -3863,12 +3863,13 @@ static const char *old_mode_names[]= >"IGNORE_INDEX_ONLY_FOR_JOIN", //

[MariaDB developers] Re: 14a12f98eb8: MDEV-15935 Clean up string sys_var types.

Hi, Yuchen, ok to push, after making one change (const) below. On Sep 13, Yuchen Pei wrote: > revision-id: 14a12f98eb8 (mariadb-11.0.1-232-g14a12f98eb8) > parent(s): e987b9350cb > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-09-13 11:50:41 +1000 > message: > > MDEV-15935 Clean up

[MariaDB developers] Re: 9db04b3dc73: MDEV-15935 Adding global/session system var redirect_url

Hi, Yuchen, Thanks. Ok to push both commits into preview-11.3-preview branch On Sep 13, Yuchen Pei wrote: > revision-id: 9db04b3dc73 (mariadb-11.0.1-233-g9db04b3dc73) > parent(s): 14a12f98eb8 > author: Yuchen Pei > committer: Yuchen Pei > timestamp: 2023-09-13 11:50:42 +1000 > message: > > MDEV-

[MariaDB developers] Re: 025ca90e5df: MDEV-32101 CREATE PACKAGE [BODY] for sql_mode=DEFAULT

Hi, Alexander, On Sep 15, Alexander Barkov wrote: > revision-id: 025ca90e5df (mariadb-11.0.1-231-g025ca90e5df) > parent(s): 8ad1e26b1ba > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2023-09-05 17:33:27 +0400 > message: > > MDEV-32101 CREATE PACKAGE [BODY] for sql_mode=DEFA

[MariaDB developers] Re: Avoiding regressions in upgrades

Hi, Kristian, This was done to improve coexistence with MySQL. As MariaDB drifts farther from MySQL, there might be more and more users who could want to install them side by side, so it's important to reduce conflicts on file names. On Sep 26, Kristian Nielsen via developers wrote: > Here is a c

[MariaDB developers] Re: Avoiding regressions in upgrades

Hi, Marko, On Sep 26, Marko Mäkelä wrote: > On Tue, Sep 26, 2023 at 3:24 PM Sergei Golubchik via developers wrote: > > > > This was done to improve coexistence with MySQL. As MariaDB drifts > > farther from MySQL, there might be more and more users who could > > want t

[MariaDB developers] Re: f9c1546bd7d: MDEV-32123: require_secure_transport doesn't allow TCP connections

Hi, Dmitry, On Sep 28, Dmitry Shulga wrote: > revision-id: f9c1546bd7d (mariadb-11.2.1-6-gf9c1546bd7d) > parent(s): c4cbafe0c4c > author: Dmitry Shulga > committer: Dmitry Shulga > timestamp: 2023-09-28 16:20:36 +0700 > message: > > MDEV-32123: require_secure_transport doesn't allow TCP connectio

[MariaDB developers] Re: a71b13433f9: MDEV-32126 Assertion fails upon online ALTER and binary log enabled

Hi, Nikita, On Sep 29, Nikita Malyavin wrote: > revision-id: a71b13433f9 (mariadb-11.2.1-7-ga71b13433f9) > parent(s): 883e7e5f7e7 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-09-22 17:55:14 +0400 > message: > > MDEV-32126 Assertion fails upon online ALTER and binary lo

[MariaDB developers] Re: 132c56f1325: online alter: extract the source to a separate file

Hi, Nikita, On Sep 29, Nikita Malyavin wrote: > revision-id: 132c56f1325 (mariadb-11.2.1-8-g132c56f1325) > parent(s): a71b13433f9 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-09-23 11:46:36 +0400 > message: > > online alter: extract the source to a separate file > > M

[MariaDB developers] Re: ad6a305d84d: online alter: use thd->ha_data to store cache_list

Hi, Nikita, On Sep 29, Nikita Malyavin wrote: > revision-id: ad6a305d84d (mariadb-11.2.1-9-gad6a305d84d) > parent(s): 132c56f1325 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-09-23 11:46:36 +0400 > message: > > online alter: use thd->ha_data to store cache_list nice

[MariaDB developers] Re: 217a7a7ceff: online alter: rework savepoints

Hi, Nikita, On Sep 29, Nikita Malyavin wrote: > revision-id: 217a7a7ceff (mariadb-11.2.1-10-g217a7a7ceff) > parent(s): ad6a305d84d > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-09-23 11:46:36 +0400 > message: > > online alter: rework savepoints > > Use standard handler

[MariaDB developers] Re: ad6a305d84d: online alter: use thd->ha_data to store cache_list

Hi, Nikita, On Oct 09, Nikita Malyavin wrote: > Hi! > > On Fri, 29 Sept 2023 at 21:41, Sergei Golubchik wrote: > > > > +using Online_alter_cache_list= ilist; > > > > please, use typedef for that > > Fine, but can you explain what's your reasoning behind this? I've never seen this pattern befor

[MariaDB developers] Re: 217a7a7ceff: online alter: rework savepoints

Hi, Nikita, On Oct 09, Nikita Malyavin wrote: > > Overall I don't like the savepoint_offset design. Even Innodb only > uses it to store a local counter, which I also had in an early > implementation (but then found that a pointer itself can identify it). > Only binlog is lucky to use it on purpos

[MariaDB developers] Re: 6cb526bd363: MDEV-32123: require_secure_transport doesn't allow TCP connections

Hi, Dmitry, Looks pretty good! Basically no comments, some minor nitpicking below, feel free to ignore. On Oct 10, Dmitry Shulga wrote: > revision-id: 6cb526bd363 (mariadb-11.2.1-9-g6cb526bd363) > parent(s): 872ed5342d8 > author: Dmitry Shulga > committer: Dmitry Shulga > timestamp: 2023-10-03 1

[MariaDB developers] Re: Question about lacking git commit message in dc9498b

Hi, Otto, Yes, sorry. It was a result of the discussion in https://jira.mariadb.org/browse/MDEV-31230 but it would've been better to have something in the git commit too. Anyway, here's the explanation: this broke compilation on kvm-bintar-freebsd123-amd64, kvm-bintar-freebsd130-amd64, kvm-b

[MariaDB developers] Re: About Release Model

Hi, Kristian, On Oct 16, Kristian Nielsen wrote: > > > You've said that it's unclear how the release model works, when we > > release what and where a feature can go. > > > > I've documented the current release model in the knowledge base, > > https://mariadb.com/kb/en/mariadb-release-model/ > >

[MariaDB developers] Re: About Release Model

Hi, Kristian, Right, thanks. Done. On Oct 16, Kristian Nielsen wrote: > Sergei Golubchik writes: > > >> > https://mariadb.com/kb/en/mariadb-release-model/ > >> > would you like to take a look and see if it answers your questions? > > One detail I noticed in this page (documenting the release m

[MariaDB developers] Re: 837b777bfd7: MDEV-27595 Backport SQL service, introduced by MDEV-19275.

Hi, Alexey, On Oct 16, Alexey Botchkov wrote: > revision-id: 837b777bfd7 (mariadb-10.4.30-116-g837b777bfd7) > parent(s): a49b9314c16 > author: Alexey Botchkov > committer: Alexey Botchkov > timestamp: 2023-09-05 13:18:12 +0400 > message: > > MDEV-27595 Backport SQL service, introduced by MDEV-192

[MariaDB developers] Re: d4c173ae6df: MDEV-27595 Backport SQL service, introduced by MDEV-19275.

Hi, Alexey, On Oct 16, Alexey Botchkov wrote: > revision-id: d4c173ae6df (mariadb-10.4.30-117-gd4c173ae6df) > parent(s): 837b777bfd7 > author: Alexey Botchkov > committer: Alexey Botchkov > timestamp: 2023-09-05 13:18:12 +0400 > message: > > MDEV-27595 Backport SQL service, introduced by MDEV-192

[MariaDB developers] Re: 56fa1da9c67: MDEV-30048 Prefix keys for CHAR work differently for MyISAM vs InnoDB

Hi, Alexander, The actual code change (replacing strnncollsp with strnncollsp_nchars) is ok. But I didn't like the functions you've created. The *_ft_* family is quite confusing, I would not expect to see fulltext-specific functions my_compare.h. I would expect to see there functions which are ge

[MariaDB developers] Re: 0f0ef93c4d4: MDEV-32444 Data from orphaned XA transaction is lost after online alter

Hi, Nikita, See below. A small suggestion for the test. And a rather larger comment about extending xid_t, as you, likely, expected :) On Oct 19, Nikita Malyavin wrote: > revision-id: 0f0ef93c4d4 (mariadb-11.2.1-15-g0f0ef93c4d4) > parent(s): 7f00853f2f1 > author: Nikita Malyavin > committer: Niki

[MariaDB developers] Re: Locking thd->LOCK_thd_data during group commit

Hi, Kristian, On Oct 20, Kristian Nielsen wrote: > Hi Serg, > > I came upon this commit by you: > > > commit 6b685ea7b0776430d45b095cb4be3ef0739a3c04 > > Author: Sergei Golubchik > > Date: Wed Sep 28 18:55:15 2022 +0200 > > > > correctness assert > > > > thd_get_ha_data() can be

[MariaDB developers] Re: Locking thd->LOCK_thd_data during group commit

Hi, Kristian, On Oct 20, Kristian Nielsen wrote: > Sergei Golubchik writes: > > >> If there is some reason, then the correct fix could be to set > >> current_thd for the duration of run_commit_ordered, which will > >> satisfy the assertion and presumably the actual bug? > > > > Setting current_t

[MariaDB developers] Re: Locking thd->LOCK_thd_data during group commit

Hi, Nikita, On Oct 21, Nikita Malyavin wrote: > > > > > Did you think it's expensive or did you benchmark that? > > > I did, actually! (in the past). Taking a mutex needs to reserve > > > the associated cache line, which is not free. "Expensive" is > > > relative, of course. > > > > I'm sure it's

[MariaDB developers] Re: 0f0ef93c4d4: MDEV-32444 Data from orphaned XA transaction is lost after online alter

Hi, Nikita, On Oct 20, Nikita Malyavin wrote: > > > okay, now I've seen how you used it and I'd say it's _such a rare > > use case_ that you can store your online_alter_cache in the > > XID_cache_element and look it up there. Or even in a separate data > > structure, that will be empty most of th

[MariaDB developers] Re: 56fa1da9c67: MDEV-30048 Prefix keys for CHAR work differently for MyISAM vs InnoDB

Hi, Alexander, On Oct 17, Sergei Golubchik wrote: > Hi, Alexander, > > The actual code change (replacing strnncollsp with strnncollsp_nchars) > is ok. > > But I didn't like the functions you've created. > The *_ft_* family is quite confusing, I would not expect to see > fulltext-specific functio

[MariaDB developers] Re: ce9ce585e72: MDEV-31184 Remove parser tokens DECODE_MARIADB_SYM and DECODE_ORACLE_SYM

Hi, Alexander, On Oct 21, Alexander Barkov wrote: > revision-id: ce9ce585e72 (mariadb-10.4.30-103-gce9ce585e72) > parent(s): 1fde785315e > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2023-08-31 13:49:19 +0400 > message: > > MDEV-31184 Remove parser tokens DECODE_MARIADB_SY

[MariaDB developers] Re: 3aea3bd7422: MDEV-23294 Segfault or assertion upon MyISAM repair

Hi, Aleksey, On Oct 23, Aleksey Midenkov wrote: > revision-id: 3aea3bd7422 (mariadb-10.4.30-176-g3aea3bd7422) > parent(s): 4fa6383c937 > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: 2023-09-26 20:20:46 +0300 > message: > > MDEV-23294 Segfault or assertion upon MyISAM repair

[MariaDB developers] Re: 2d937b62c33: MDEV-27744 InnoDB: Failing assertion: !cursor->index->is_committed() in row0ins.cc (from row_ins_sec_index_entry_by_modify) | Assertion `0' failed in row_upd_sec_

Hi, Alexander, Few questions and suggestions below. Nothing major. On Oct 27, Alexander Barkov wrote: > commit 2d937b62c33 > Author: Alexander Barkov > Date: Mon Apr 4 14:50:21 2022 +0400 > > MDEV-27744 InnoDB: Failing assertion: !cursor->index->is_committed() in > row0ins.cc (from row_i

[MariaDB developers] Re: 0f0ef93c4d4: MDEV-32444 Data from orphaned XA transaction is lost after online alter

Hi, Nikita, On Oct 24, Nikita Malyavin wrote: > I have made a separate struct XA_data to store online_alter_cache: > https://github.com/MariaDB/server/commit/a72605ce002897c65d184b476eeec51a1d146a5f Please, try not to forget to change the issue status in Jira to IN-REVIEW. I would've reviewed it

[MariaDB developers] Re: 2d937b62c33: MDEV-27744 InnoDB: Failing assertion: !cursor->index->is_committed() in row0ins.cc (from row_ins_sec_index_entry_by_modify) | Assertion `0' failed in row_upd_sec_

Hi, Alexander, On Oct 31, Alexander Barkov wrote: > >> +++ b/mysql-test/suite/compat/oracle/r/vcol_innodb.result > >> @@ -0,0 +1,51 @@ > >> +SET @table_open_cache=@@GLOBAL.table_open_cache; > > > > why do you need to manipulate table_open_cache? > > to trigger a reopen? Just do flush tables, it's

[MariaDB developers] Re: 3aea3bd7422: MDEV-23294 Segfault or assertion upon MyISAM repair

Hi, Aleksey, On Oct 24, Aleksey Midenkov wrote: > > > diff --git a/storage/myisam/ha_myisam.cc b/storage/myisam/ha_myisam.cc > > > index ddab8bcf741..27151548704 100644 > > > --- a/storage/myisam/ha_myisam.cc > > > +++ b/storage/myisam/ha_myisam.cc > > > @@ -714,6 +714,8 @@ static int compute_vcol

[MariaDB developers] Re: 2342aaf46eb: MDEV-30973 Implement debug logging for slave_transaction_retries

Hi, Aleksey, On Nov 07, Aleksey Midenkov wrote: > revision-id: 2342aaf46eb (mariadb-11.0.1-256-g2342aaf46eb) > parent(s): 80bc5df1c80 > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: 2023-10-10 13:11:19 +0300 > message: > > MDEV-30973 Implement debug logging for slave_transac

[MariaDB developers] Re: 28deba0a611: MDEV-32101 CREATE PACKAGE [BODY] for sql_mode=DEFAULT

Hi, Alexander, Looks great! Just a couple of questions below On Nov 07, Alexander Barkov wrote: > revision-id: 28deba0a611 (mariadb-11.0.1-239-g28deba0a611) > parent(s): e9573c05965 > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2023-09-22 14:38:52 +0400 > message: > > MDE

[MariaDB developers] Re: 28deba0a611: MDEV-32101 CREATE PACKAGE [BODY] for sql_mode=DEFAULT

Hi, Alexander, Thanks, this is ok to push. But I still want to understand (question below) On Nov 10, Alexander Barkov wrote: > On 11/7/23 10:39 PM, Sergei Golubchik wrote: > > Hi, Alexander, > > > > Looks great! Just a couple of questions below > > > > On Nov 07, Alexander Barkov wrote: > >>

[MariaDB developers] Re: 73097e18b77: MDEV-32771 Server crash upon online alter with concurrent XA

Hi, Nikita, ok to push. spelling and renaming suggestions below On Nov 13, Nikita Malyavin wrote: > revision-id: 73097e18b77 (mariadb-11.2.1-20-g73097e18b77) > parent(s): f7646d890b9 > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-11-13 15:28:19 +0100 > message: > > MDEV

[MariaDB developers] Re: dadcf5ed7b1: MDEV-24486 Add `table_privileges` view to the `sys` schema

Hi, Oleg, ok to push. Just one comment below. On Nov 20, Oleg Smirnov wrote: > revision-id: dadcf5ed7b1 (mariadb-11.0.1-259-gdadcf5ed7b1) > parent(s): b8f9f796ff8 > author: Oleg Smirnov > committer: Oleg Smirnov > timestamp: 2023-11-20 19:35:36 +0700 > message: > > MDEV-24486 Add `table_privileg

[MariaDB developers] Re: d25ab9fdfa1: MDEV-31608 - Connector/NET fails to connect since 10.10

Hi, Vladislav, On Nov 29, Vladislav Vaintroub wrote: > revision-id: d25ab9fdfa1 (mariadb-10.11.2-62-gd25ab9fdfa1) > parent(s): 034848c6c27 > author: Vladislav Vaintroub > committer: Vladislav Vaintroub > timestamp: 2023-10-08 19:37:20 +0200 > message: > > MDEV-31608 - Connector/NET fails to conne

[MariaDB developers] Re: 02b85f1cf9b: MDEV-31340 Remove MY_COLLATION_HANDLER::strcasecmp()

Hi, Alexander, Phew. It was a big patch. Mostly mechanical changes, admittedly, but still a lot to read. Generally I quite liked it, great work! Shorter way to write an identifier comparison, type safety that enforces namespaces and correct collations. Nice. But there are, of course, comments an

  1   2   3   >