Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

2019-02-21 Thread Stephen Boyd
Quoting mtk14994 (2019-02-20 18:34:11) > Dear Stephen, > > + unsigned char mux_flags; > > > > Why isn't it an unsigned long? Isn't this supposed to match the > > frameworks version of the clk flags? > > > it is unsigned char mux_flags ,becasuse struct clk_mux { > > > > u8

Re: [PATCH] drm: Fix writeback_job leak when state is check only or check failed

2019-02-21 Thread james qian wang (Arm Technology China)
On Thu, Feb 21, 2019 at 02:56:56PM +0100, Maarten Lankhorst wrote: > Hey > > Op 21-02-2019 om 12:14 schreef james qian wang (Arm Technology China): > > The writeback job will not be added to writeback queue if the state is > > check only or check failed, to avoid leak, need to cleanup writeback

Re: [EARLY RFC][PATCH 0/4] dmabuf pools infrastructure (destaging ION)

2019-02-21 Thread John Stultz
On Wed, Feb 20, 2019 at 11:40 PM John Stultz wrote: > > Here is a very early peek at my dmabuf pools patchset, which > tries to destage a fair chunk of ION functionality. > > This build and boots, but I've not gotten to testing the actual > pool devices yet (need to write some kselftests)! I just

[PATCH v4 0/2] drm & vgaarb: handle vgacon removal in vgaarb.

2019-02-21 Thread Gerd Hoffmann
Gerd Hoffmann (2): drm: move i915_kick_out_vgacon to vgaarb drm/qxl: remove conflicting framebuffers earlier include/drm/drm_fb_helper.h | 14 +++--- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 43 -

[PATCH v4 2/2] drm/qxl: remove conflicting framebuffers earlier

2019-02-21 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5 100644 ---

[PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

2019-02-21 Thread Gerd Hoffmann
Also rename it and call it automatically from drm_fb_helper_remove_conflicting_pci_framebuffers() Signed-off-by: Gerd Hoffmann --- include/drm/drm_fb_helper.h | 14 +++--- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 43

Re: [PATCH v2 2/2] drm/qxl: kick out vgacon

2019-02-21 Thread Gerd Hoffmann
Hi, > PCI_COMMAND_MEM and PCI_COMMAND_IO. There doesn't seem to be any > separate bits really. That's at least what I've gleaned from vgaarb.c. > The magic legacy vga decode bits only seem to exist on bridges, maybe > we can extract that logic from vgaarb.c (yes this is all a bit > spiralling

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-21 Thread Koenig, Christian
Am 21.02.19 um 22:02 schrieb Thomas Hellstrom: > Hi, > > On Thu, 2019-02-21 at 20:24 +, Kuehling, Felix wrote: >> On 2019-02-21 12:34 p.m., Thomas Hellstrom wrote: >>> On Thu, 2019-02-21 at 16:57 +, Kuehling, Felix wrote: On 2019-02-21 2:59 a.m., Koenig, Christian wrote: > On x86

[PATCH] drm/nouveau/dmem: Fix a NULL vs IS_ERR() check

2019-02-21 Thread Dan Carpenter
The hmm_devmem_add() function doesn't return NULL, it returns error pointers. Fixes: 5be73b690875 ("drm/nouveau/dmem: device memory helpers for SVM") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amd/display: Fix reference counting for struct dc_sink.

2019-02-21 Thread Mathias Fröhlich
Good Morning, On Thursday, 21 February 2019 22:00:40 CET Li, Sun peng (Leo) wrote: > > On 2019-02-20 12:24 a.m., Mathias Fröhlich wrote: > > Hi, > > > > ping? > > ... to the dc folks? > > > > best > > Mathias > > Hi Mathias, > > Sorry for the wait, change looks good to me. > > Reviewed-by:

Re: [PATCH] drm/bochs: Fix the ID mismatch error

2019-02-21 Thread kra...@redhat.com
On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote: > On Thu, Feb 21, 2019 at 3:52 AM kra...@redhat.com wrote: > > > > On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote: > > > When running RISC-V QEMU with the Bochs device attached via PCIe the > > > probe of the

RE: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-21 Thread Deng, Emily
Hi Alex, Please help, thanks. Best wishes Emily Deng >-Original Message- >From: Alex Deucher >Sent: Friday, February 22, 2019 12:13 AM >To: Deng, Emily ; Maling list - DRI developers de...@lists.freedesktop.org> >Cc: amd-gfx list >Subject: Re: [PATCH libdrm] libdrm: Fix issue

Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread kbuild test robot
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[git pull] drm fixes for 5.0-rc8 (or final)

2019-02-21 Thread Dave Airlie
Hi Linus, This contains a single i915 tiled display fix, and a set of amdgpu/radeon fixes. amdgpu/radeon: runtime PM fix bulk moves disable (fix is too large for 5.0) and a set of display fixes that are all cc'ed stable so we didn't want to leave them until -next. Dave. drm-fixes-2019-02-22:

Re: [PATCH] drm/qxl: unbind vgacon

2019-02-21 Thread kbuild test robot
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH -next] drm/bridge: cdns: Remove set but not used variable 'bpp'

2019-02-21 Thread Laurent Pinchart
Hi YueHaibing, Thank you for the patch. On Sat, Feb 16, 2019 at 07:34:59AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_enable': > drivers/gpu/drm/bridge/cdns-dsi.c:986:6: warning: > variable 'bpp'

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Laurent Pinchart
Hi Brian, On Thu, Feb 21, 2019 at 01:44:56PM +, Brian Starkey wrote: > On Thu, Feb 21, 2019 at 02:23:10PM +0200, Laurent Pinchart wrote: > > On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote: > > [snip] > > >> I used a pre-existing internal tool which does exactly that. > > > >

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-21 Thread Ira Weiny
On Thu, Feb 21, 2019 at 08:48:41AM +0530, Souptick Joarder wrote: > Hi Ira, > > On Wed, Feb 20, 2019 at 11:01 AM wrote: > > > > From: Ira Weiny > > > > To facilitate additional options to get_user_pages_fast() change the > > singular write parameter to be gup_flags. > > > > This patch does not

[Bug 202511] amdgpu fails to load saying "Could not allocate 8192 bytes percpu data"

2019-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202511 --- Comment #21 from Bjorn Helgaas (bhelg...@google.com) --- Thanks! Unless somebody has a better idea, I would try building 4.17.19 with the print options. Config differences that might conceivably be related: --- config-4.17.txt

Re: [Nouveau] [PATCH -next] drm/nouveau/dmem: remove set but not used variable 'drm'

2019-02-21 Thread Ben Skeggs
On Thu, 21 Feb 2019 at 13:41, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free': > drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning: > variable 'drm' set but not used [-Wunused-but-set-variable]

Re: [PATCH v5 14/19] drm: writeback: Add job prepare and cleanup operations

2019-02-21 Thread Laurent Pinchart
Hi Brian, On Thu, Feb 21, 2019 at 06:12:03PM +, Brian Starkey wrote: > On Thu, Feb 21, 2019 at 12:32:07PM +0200, Laurent Pinchart wrote: > > As writeback jobs contain a framebuffer, drivers may need to prepare and > > cleanup them the same way they can prepare and cleanup framebuffers for > >

[Bug 109534] Crash in Minecraft due to a swp[chan] assertion fail in src/gallium/drivers/r600/sb/sb_ir.cpp alu_packed_node::update_packed_items

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109534 --- Comment #2 from vanyasm...@gmail.com --- I've faced with same problem on following configuration: > $ glxinfo | grep Device > Device: AMD JUNIPER (DRM 2.50.0 / 4.18.0-15-generic, LLVM 7.0.0) (0x68ba) > $ glxinfo | grep 'OpenGL version

[Bug 202511] amdgpu fails to load saying "Could not allocate 8192 bytes percpu data"

2019-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202511 Michael A. Leonetti (mikealeone...@gmail.com) changed: What|Removed |Added Attachment #281261|0 |1

Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling when queuing job

2019-02-21 Thread Laurent Pinchart
Hi Brian, On Thu, Feb 21, 2019 at 04:02:37PM +, Brian Starkey wrote: > On Thu, Feb 21, 2019 at 12:42:25PM +0200, Laurent Pinchart wrote: > > On Thu, Feb 21, 2019 at 12:32:05PM +0200, Laurent Pinchart wrote: > >> The drm_writeback_queue_job() function takes ownership of the passed job > >> and

[PATCH] drm/msm: Fix incorrect struct size for memory allocation

2019-02-21 Thread Jordan Crouse
The allocation for the clock bulk data does a classic sizeof(pointer) instead of sizeof(struct) so the array ends up incorrectly sized for the clock data. Cc: sta...@vger.kernel.org Fixes: 8e54eea ("drm/msm: Add a helper function to parse clock names") Signed-off-by: Jordan Crouse ---

[pull] amdgpu, radeon, sched drm-next-5.1

2019-02-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.1: amdgpu: - Fix missing fw declaration after dropping old CI DPM code - Fix debugfs access to registers beyond the MMIO bar size - Fix context priority handling - Add missing license on some new files - Various cleanups and bug fixes radeon: - Fix missing break in

Re: [PATCH RESEND 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-21 Thread kbuild test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Bug 109731] DRM functionality is not working as per the requirements

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109731 Bug ID: 109731 Summary: DRM functionality is not working as per the requirements Product: DRI Version: XOrg git Hardware: Other OS: All

[Bug 109730] On resume: atombios stuck in loop for more than 5secs

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109730 --- Comment #2 from Alex Deucher --- Possibly related to this bug? https://bugzilla.kernel.org/show_bug.cgi?id=201519 if so, does this patch help?

[Bug 109730] On resume: atombios stuck in loop for more than 5secs

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109730 Bug ID: 109730 Summary: On resume: atombios stuck in loop for more than 5secs Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status:

[Bug 109730] On resume: atombios stuck in loop for more than 5secs

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109730 --- Comment #1 from Dominic Tubach --- Created attachment 143434 --> https://bugs.freedesktop.org/attachment.cgi?id=143434=edit lspci -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-21 Thread Thomas Hellstrom
Hi, On Thu, 2019-02-21 at 20:24 +, Kuehling, Felix wrote: > On 2019-02-21 12:34 p.m., Thomas Hellstrom wrote: > > On Thu, 2019-02-21 at 16:57 +, Kuehling, Felix wrote: > > > On 2019-02-21 2:59 a.m., Koenig, Christian wrote: > > > > On x86 with HIGHMEM there is no dma32 zone. Why do we

Re: [PATCH] drm/amd/display: Fix reference counting for struct dc_sink.

2019-02-21 Thread Li, Sun peng (Leo)
On 2019-02-20 12:24 a.m., Mathias Fröhlich wrote: > Hi, > > ping? > ... to the dc folks? > > best > Mathias Hi Mathias, Sorry for the wait, change looks good to me. Reviewed-by: Leo Li ...and merged. Thanks for cleaning this up. Leo > > On Wednesday, 13 February 2019 21:38:03 CET Alex

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-21 Thread Kuehling, Felix
On 2019-02-21 12:34 p.m., Thomas Hellstrom wrote: > On Thu, 2019-02-21 at 16:57 +, Kuehling, Felix wrote: >> On 2019-02-21 2:59 a.m., Koenig, Christian wrote: >>> On x86 with HIGHMEM there is no dma32 zone. Why do we need one on > x86_64? Can we make x86_64 more like HIGHMEM instead?

[PATCH v2 0/3] Make DRM DSC helpers more generally usable

2019-02-21 Thread David Francis
drm_dsc could use some work so that drm drivers other than i915 can make use of it their own DSC implementations Move rc compute, a function that forms part of the DSC spec, into drm. Update it to DSC 1.2. Also split the PPS packing and SDP header init functions, to allow for drivers with their

[PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-21 Thread David Francis
Native 420 and 422 transfer modes are new in DSC1.2 In these modes, each two pixels of a slice are treated as one pixel, so the slice width is half as large (round down) for the purposes of calucating the groups per line and chunk size in bytes In native 422 mode, each pixel has four components,

[PATCH v2 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-21 Thread David Francis
The function intel_compute_rc_parameters is part of the dsc spec and is not driver-specific. Other drm drivers might like to use it. The function is not changed; just moved and renamed. Reviewed-by: Harry Wentland Signed-off-by: David Francis --- drivers/gpu/drm/drm_dsc.c | 135

[PATCH v2 3/3] drm/dsc: Split DSC PPS and SDP header initialisations

2019-02-21 Thread David Francis
The DP 1.4 spec defines the SDP header and SDP contents for a Picture Parameter Set (PPS) that must be sent in advance of DSC transmission to define the encoding characteristics. This was done in one struct, drm_dsc_pps_infoframe, which conatined the SDP header and PPS. Because the PPS is a

[Bug 202511] amdgpu fails to load saying "Could not allocate 8192 bytes percpu data"

2019-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202511 --- Comment #19 from Michael A. Leonetti (mikealeone...@gmail.com) --- Created attachment 281263 --> https://bugzilla.kernel.org/attachment.cgi?id=281263=edit 4.18 config Would you like me to build the 4.17.19 kernel with the print options

[Bug 202511] amdgpu fails to load saying "Could not allocate 8192 bytes percpu data"

2019-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202511 --- Comment #18 from Michael A. Leonetti (mikealeone...@gmail.com) --- Created attachment 281261 --> https://bugzilla.kernel.org/attachment.cgi?id=281261=edit 4.17.19 config Absolutely. Let me post the two configs then. -- You are receiving

[Bug 202511] amdgpu fails to load saying "Could not allocate 8192 bytes percpu data"

2019-02-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202511 --- Comment #17 from Bjorn Helgaas (bhelg...@google.com) --- Created attachment 281259 --> https://bugzilla.kernel.org/attachment.cgi?id=281259=edit per-cpu alloc info (broken) FWIW, I pulled out the per-cpu alloc info and what looks like the

[Bug 108854] [polaris11] - GPU Hang - ring gfx timeout

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108854 --- Comment #14 from Tom Seewald --- (In reply to Tom St Denis from comment #13) > The wave dump seems to be empty... Is that the complete output? Was there > anything printed to stderr (like there are no waves)? Yes it says "no active

[Bug 109727] RX 580 - Login fails, unable to go further than GDM, black screen

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109727 Bug ID: 109727 Summary: RX 580 - Login fails, unable to go further than GDM, black screen Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS:

[PATCH v15 07/16] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-21 Thread Ramalingam C
Provides Pairing info to ME to store. Pairing is a process to fast track the subsequent authentication with the same HDCP sink. On Success, received HDCP pairing info is stored in non-volatile memory of ME. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and

[PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-21 Thread Ramalingam C
This series enables the HDCP2.2 Type 0 for I915. The sequence for HDCP2.2 authentication and encryption is implemented as a generic flow between HDMI and DP. Encoder specific implementations are moved into hdcp_shim. Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces a client

[PATCH v15 06/16] misc/mei/hdcp: Verify H_prime

2019-02-21 Thread Ramalingam C
Requests for the verification of AKE_Send_H_prime. ME will calculate the H and comparing it with received H_Prime. The result will be returned as status. Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and

[PATCH v15 02/16] misc/mei/hdcp: Client driver for HDCP application

2019-02-21 Thread Ramalingam C
ME FW contributes a vital role in HDCP2.2 authentication. HDCP2.2 driver needs to communicate to ME FW for each step of the HDCP2.2 authentication. ME FW prepare and HDCP2.2 authentication parameters and encrypt them as per spec. With such parameter Driver prepares HDCP2.2 auth messages and

[PATCH v15 15/16] misc/mei/hdcp: Component framework for I915 Interface

2019-02-21 Thread Ramalingam C
Mei hdcp driver is designed as component slave for the I915 component master. v2: Rebased. v3: Notifier chain is adopted for cldev state update [Tomas] v4: Made static dummy functions as inline in mei_hdcp.h API for polling client device status IS_ENABLED used in header, for config status

[PATCH v15 11/16] misc/mei/hdcp: Repeater topology verification and ack

2019-02-21 Thread Ramalingam C
Request ME to verify the downstream topology information received. ME FW will validate the Repeaters receiver id list and downstream topology. On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack. v2: Rebased. v3: cldev is passed as first

[PATCH v15 08/16] misc/mei/hdcp: Initiate Locality check

2019-02-21 Thread Ramalingam C
Requests ME to start the second stage of HDCP2.2 authentication, called Locality Check. On Success, ME FW will provide LC_Init message to send to hdcp sink. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd used for ssize_t

[PATCH v15 13/16] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-21 Thread Ramalingam C
Request to ME to configure a port as authenticated. On Success, ME FW will mark the port as authenticated and provides HDCP cipher with the encryption keys. Enabling the Authentication can be requested once all stages of HDCP2.2 authentication is completed by interacting with ME FW. Only after

[PATCH v15 16/16] FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915

2019-02-21 Thread Ramalingam C
FOR TESTING PURPOSE ONLY. By default INTEL_MEI_HDCP is set to y. This patch is created to test the interface between I915 and MEI_HDCP. Signed-off-by: Ramalingam C --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/Kconfig

[PATCH v15 12/16] misc/mei/hdcp: Verify M_prime

2019-02-21 Thread Ramalingam C
Request to ME to verify the M_Prime received from the HDCP sink. ME FW will calculate the M and compare with M_prime received as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. On successful completion of this stage, downstream propagation of the stream management info is

[PATCH v15 09/16] misc/mei/hdcp: Verify L_prime

2019-02-21 Thread Ramalingam C
Request to ME to verify the LPrime received from HDCP sink. On Success, ME FW will verify the received Lprime by calculating and comparing with L. This represents the completion of Locality Check. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are

[PATCH v15 10/16] misc/mei/hdcp: Prepare Session Key

2019-02-21 Thread Ramalingam C
Request to ME to prepare the encrypted session key. On Success, ME provides Encrypted session key. Function populates the HDCP2.2 authentication msg SKE_Send_Eks. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd for ssize_t

[PATCH v15 14/16] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-21 Thread Ramalingam C
Request the ME to terminate the HDCP2.2 session for a port. On Success, ME FW will mark the intel port as Deauthenticated and terminate the wired HDCP2.2 Tx session started due to the cmd WIRED_INITIATE_HDCP2_SESSION. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant

[PATCH v15 05/16] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-21 Thread Ramalingam C
Requests for verification for receiver certification and also the preparation for next AKE auth message with km. On Success ME FW validate the HDCP2.2 receivers certificate and do the revocation check on the receiver ID. AKE_Stored_Km will be prepared if the receiver is already paired, else

[PATCH v15 04/16] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-21 Thread Ramalingam C
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message. v2: Rebased. v3: cldev is add as a

[PATCH v15 03/16] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2019-02-21 Thread Ramalingam C
Defines the HDCP specific ME FW interfaces such as Request CMDs, payload structure for CMDs and their response status codes. This patch defines payload size(Excluding the Header)for each WIRED HDCP2.2 CMDs. v2: Rebased. v3: Extra comments are removed. v4: %s/\/\*\*/\/\* v5: Extra lines are

[PATCH v15 01/16] mei: bus: whitelist hdcp client

2019-02-21 Thread Ramalingam C
From: Tomas Winkler Whitelist HDCP client for in kernel drm use v2: Rebased. Signed-off-by: Tomas Winkler Signed-off-by: Ramalingam C --- drivers/misc/mei/bus-fixup.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c

Re: [PATCH v5 14/19] drm: writeback: Add job prepare and cleanup operations

2019-02-21 Thread Brian Starkey
Hi Laurent, On Thu, Feb 21, 2019 at 12:32:07PM +0200, Laurent Pinchart wrote: > As writeback jobs contain a framebuffer, drivers may need to prepare and > cleanup them the same way they can prepare and cleanup framebuffers for > planes. Add two new optional connector helper operations, >

[Bug 108854] [polaris11] - GPU Hang - ring gfx timeout

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108854 --- Comment #13 from Tom St Denis --- The wave dump seems to be empty... Is that the complete output? Was there anything printed to stderr (like there are no waves)? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v5 13/19] drm: writeback: Fix leak of writeback job

2019-02-21 Thread Brian Starkey
Hi, On Thu, Feb 21, 2019 at 12:32:06PM +0200, Laurent Pinchart wrote: > Writeback jobs are allocated when the WRITEBACK_FB_ID is set, and > deleted when the jobs complete. This results in both a memory leak of > the job and a leak of the framebuffer if the atomic commit returns > before the job

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-21 Thread Thomas Hellstrom
On Thu, 2019-02-21 at 16:57 +, Kuehling, Felix wrote: > On 2019-02-21 2:59 a.m., Koenig, Christian wrote: > > On x86 with HIGHMEM there is no dma32 zone. Why do we need one on > > > > x86_64? Can we make x86_64 more like HIGHMEM instead? > > > > > > > > Regards, > > > > Felix > > > > >

[Bug 109692] deadlock occurs during GPU reset

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109692 Andrey Grodzovsky changed: What|Removed |Added CC||christian.koe...@amd.com ---

[Bug 109695] qemu using spice gl and sandbox resourcecontrol=deny crashes with SIGSYS on radeonsi

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109695 --- Comment #2 from a...@tutanota.com --- To check for the availability of the syscall, one can try it in a child process and see if the child is terminated by a signal, e.g. like this: #include #include #include #include #include static

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-21 Thread Kuehling, Felix
On 2019-02-21 2:59 a.m., Koenig, Christian wrote: > On x86 with HIGHMEM there is no dma32 zone. Why do we need one on >>> x86_64? Can we make x86_64 more like HIGHMEM instead? >>> >>> Regards, >>> Felix >>> >> IIRC with x86, the kernel zone is always smaller than any dma32 zone, >> so we'd

Re: [PATCH] staging/vboxvideo: Another FIXME item

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 05:40:05PM +0100, Hans de Goede wrote: > Hi, > > On 21-02-19 16:59, Daniel Vetter wrote: > > Found while grepping around. > > > > Signed-off-by: Daniel Vetter > > Cc: Hans de Goede > > Cc: Greg Kroah-Hartman > > Cc: Sam Ravnborg > > Cc: Daniel Vetter > > Cc: Liviu

Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling when queuing job

2019-02-21 Thread Eric Anholt
Laurent Pinchart writes: > The drm_writeback_queue_job() function takes ownership of the passed job > and requires the caller to manually set the connector state > writeback_job pointer to NULL. To simplify drivers and avoid errors > (such as the missing NULL set in the vc4 driver), pass the

Re: [PATCH] staging/vboxvideo: Another FIXME item

2019-02-21 Thread Hans de Goede
Hi, On 21-02-19 16:59, Daniel Vetter wrote: Found while grepping around. Signed-off-by: Daniel Vetter Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Liviu Dudau --- drivers/staging/vboxvideo/vbox_irq.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-21 Thread Alex Deucher
On Thu, Feb 14, 2019 at 2:53 AM Emily Deng wrote: > > For multiple GPUs which has the same BDF, but has different domain ID, > the drmOpenByBusid will return the wrong fd when startx. > > The reproduce sequence as below: > 1. Call drmOpenByBusid to open Card0, then will return the right fd0, and

Re: [PATCH] staging/vboxvideo: Another FIXME item

2019-02-21 Thread Greg Kroah-Hartman
On Thu, Feb 21, 2019 at 04:59:51PM +0100, Daniel Vetter wrote: > Found while grepping around. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Liviu Dudau > --- > drivers/staging/vboxvideo/vbox_irq.c | 5 + > 1

Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling when queuing job

2019-02-21 Thread Brian Starkey
On Thu, Feb 21, 2019 at 12:42:25PM +0200, Laurent Pinchart wrote: > Forgot to CC Eric, sorry about that. > > On Thu, Feb 21, 2019 at 12:32:05PM +0200, Laurent Pinchart wrote: > > The drm_writeback_queue_job() function takes ownership of the passed job > > and requires the caller to manually set

Re: [PATCH] drm/i915: remove redundant likely/unlikely annotation

2019-02-21 Thread Chris Wilson
Quoting Chris Wilson (2019-02-21 12:03:18) > Quoting Chengguang Xu (2019-02-21 02:08:19) > > unlikely has already included in IS_ERR(), so just > > remove redundant likely/unlikely annotation. > > > > Signed-off-by: Chengguang Xu > Reviewed-by: Chris Wilson And pushed, thanks for the patch.

[PATCH] staging/vboxvideo: Another FIXME item

2019-02-21 Thread Daniel Vetter
Found while grepping around. Signed-off-by: Daniel Vetter Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Liviu Dudau --- drivers/staging/vboxvideo/vbox_irq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vboxvideo/vbox_irq.c

[PATCH 2/2] drm/bochs: Drop best_encoder

2019-02-21 Thread Daniel Vetter
This is the default for atomic drivers. Signed-off-by: Daniel Vetter Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org --- drivers/gpu/drm/bochs/bochs_kms.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c

[PATCH 1/2] drm/hibmc: Drop best_encoder

2019-02-21 Thread Daniel Vetter
This is the default for atomic drivers. Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Neil Armstrong Cc: Luc Van Oostenryck Cc: Rodrigo Vivi --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 04:09:12PM +0100, Gerd Hoffmann wrote: > > > +int drm_fb_helper_kick_out_vgacon(void); > > > + > > > > Don't you need a dummy version as well for this one, like how it's done > > for the other functions, to cover the case when DRM_FBDEV_EMULATION is > > not selected? > >

[PATCH v3] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Gerd Hoffmann
Also rename it and call it automatically from drm_fb_helper_remove_conflicting_pci_framebuffers() Signed-off-by: Gerd Hoffmann --- include/drm/drm_fb_helper.h | 18 ++--- drivers/gpu/drm/drm_fb_helper.c | 35 + drivers/gpu/drm/i915/i915_drv.c | 43

[Bug 109714] Unable to Compile R200 driver: "Options 'r200' are not allowed..."

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109714 Adam Jackson changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [PATCH v2 2/2] drm/qxl: kick out vgacon

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 4:11 PM Gerd Hoffmann wrote: > > Hi, > > > I was thinking of checking whether pdev is a VGA class device and whether > > it decodes vga access, and in that case automatically calling > > How can I figure that? Ok, class is easy, but decode? pci.h offers > functions to

Re: [PATCH v2 2/2] drm/qxl: kick out vgacon

2019-02-21 Thread Gerd Hoffmann
Hi, > I was thinking of checking whether pdev is a VGA class device and whether > it decodes vga access, and in that case automatically calling How can I figure that? Ok, class is easy, but decode? pci.h offers functions to set vga decode but not to get that info ... thanks, Gerd

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Gerd Hoffmann
> > +int drm_fb_helper_kick_out_vgacon(void); > > + > > Don't you need a dummy version as well for this one, like how it's done > for the other functions, to cover the case when DRM_FBDEV_EMULATION is > not selected? Good question. I guess it makes sense to kick out vgacon even with

Re: [PATCH v2 2/2] drm/qxl: kick out vgacon

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 02:06:23PM +0100, Gerd Hoffmann wrote: > On Thu, Feb 21, 2019 at 01:20:11PM +0100, Daniel Vetter wrote: > > On Thu, Feb 21, 2019 at 12:35:34PM +0100, Gerd Hoffmann wrote: > > > Problem: qxl switches from native mode back into vga compatibility mode > > > when it notices

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Jani Nikula
On Thu, 21 Feb 2019, Gerd Hoffmann wrote: > On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote: >> On Thu, 21 Feb 2019, Gerd Hoffmann wrote: >> > It'll be useful for other drivers too, so move it to drm_fb_helper.c >> > (and rename it of course). Also add docs. >> > >> > Signed-off-by:

RE: [PATCH v14 27/33] misc/mei/hdcp: Prepare Session Key

2019-02-21 Thread Winkler, Tomas
> > Request to ME to prepare the encrypted session key. > > On Success, ME provides Encrypted session key. Function populates the > HDCP2.2 authentication msg SKE_Send_Eks. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas]

RE: [PATCH v14 31/33] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-21 Thread Winkler, Tomas
> Request the ME to terminate the HDCP2.2 session for a port. > > On Success, ME FW will mark the intel port as Deauthenticated and terminate > the wired HDCP2.2 Tx session started due to the cmd > WIRED_INITIATE_HDCP2_SESSION. > > v2: Rebased. > v3: > cldev is passed as first parameter

RE: [PATCH v14 30/33] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-21 Thread Winkler, Tomas
> > Request to ME to configure a port as authenticated. > > On Success, ME FW will mark the port as authenticated and provides HDCP > cipher with the encryption keys. > > Enabling the Authentication can be requested once all stages of > HDCP2.2 authentication is completed by interacting with ME

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 01:39:33PM +0100, Gerd Hoffmann wrote: > > > +/** > > > + * drm_fb_helper_kick_out_vgacon - deactivate vgacon driver. > > > + * > > > + * Deactivate vgacon driver so it stops accessing vga io ports. > > > + * Should be called after > > > + *

[Bug 109692] deadlock occurs during GPU reset

2019-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109692 --- Comment #8 from Tom St Denis --- Just a follow up. If you "chmod +s" umr as a non-root user then even if you sudo it it won't have permissions to read the debugfs files. Make sure you "sudo chmod +s" the binary or simply just "sudo umr".

RE: [PATCH v14 28/33] misc/mei/hdcp: Repeater topology verification and ack

2019-02-21 Thread Winkler, Tomas
> ack > > Request ME to verify the downstream topology information received. > > ME FW will validate the Repeaters receiver id list and downstream topology. > > On Success ME FW will provide the Least Significant 128bits of VPrime, which > forms the repeater ack. > > v2: Rebased. > v3: >

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote: > Hi Laurent, > > On Thu, Feb 21, 2019 at 12:02:57PM +0200, Laurent Pinchart wrote: > > Hi Brian, > > > > On Thu, Feb 21, 2019 at 09:50:19AM +, Brian Starkey wrote: > > > On Thu, Feb 21, 2019 at 10:23:17AM +0200, Laurent Pinchart

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Noralf Trønnes
Den 21.02.2019 12.35, skrev Gerd Hoffmann: > It'll be useful for other drivers too, so move it to drm_fb_helper.c > (and rename it of course). Also add docs. > > Signed-off-by: Gerd Hoffmann > --- > include/drm/drm_fb_helper.h | 2 ++ > drivers/gpu/drm/drm_fb_helper.c | 39

RE: [PATCH v14 19/33] misc/mei/hdcp: Client driver for HDCP application

2019-02-21 Thread Winkler, Tomas
> > ME FW contributes a vital role in HDCP2.2 authentication. > HDCP2.2 driver needs to communicate to ME FW for each step of the > HDCP2.2 authentication. > > ME FW prepare and HDCP2.2 authentication parameters and encrypt them as > per spec. With such parameter Driver prepares HDCP2.2 auth

Re: [PATCH] drm: Fix writeback_job leak when state is check only or check failed

2019-02-21 Thread Maarten Lankhorst
Hey Op 21-02-2019 om 12:14 schreef james qian wang (Arm Technology China): > The writeback job will not be added to writeback queue if the state is > check only or check failed, to avoid leak, need to cleanup writeback job > in connector_destroy_state if the job existed. > > Signed-off-by: James

RE: [PATCH v14 24/33] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-21 Thread Winkler, Tomas
> > Provides Pairing info to ME to store. > > Pairing is a process to fast track the subsequent authentication with the same > HDCP sink. > > On Success, received HDCP pairing info is stored in non-volatile memory of ME. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

Re: [PATCH v4 0/7] VSP1: Display writeback support

2019-02-21 Thread Brian Starkey
On Thu, Feb 21, 2019 at 02:23:10PM +0200, Laurent Pinchart wrote: > On Thu, Feb 21, 2019 at 12:19:13PM +, Brian Starkey wrote: [snip] > > > > I used a pre-existing internal tool which does exactly that. > > Any hope of sharing the sources ? > Not in a timescale or form which would be

RE: [PATCH v14 29/33] misc/mei/hdcp: Verify M_prime

2019-02-21 Thread Winkler, Tomas
> > Request to ME to verify the M_Prime received from the HDCP sink. > > ME FW will calculate the M and compare with M_prime received as part of > RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. > > On successful completion of this stage, downstream propagation of the stream >

RE: [PATCH v14 25/33] misc/mei/hdcp: Initiate Locality check

2019-02-21 Thread Winkler, Tomas
> Requests ME to start the second stage of HDCP2.2 authentication, called > Locality Check. > > On Success, ME FW will provide LC_Init message to send to hdcp sink. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas] > v4: >

RE: [PATCH v14 26/33] misc/mei/hdcp: Verify L_prime

2019-02-21 Thread Winkler, Tomas
> Request to ME to verify the LPrime received from HDCP sink. > > On Success, ME FW will verify the received Lprime by calculating and > comparing with L. > > This represents the completion of Locality Check. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant

  1   2   >