RE: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Felix, amdgpu_gem_prime_export has different define in the old driver. I added some comment in the below codes. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Tuesday, July 14,

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 14:09, Felix Kuehling wrote: > > Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > >> This allows exporting and importing buffers. The API generates handles > >> that can be used with the HIP IPC API, i.e. big

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Felix Kuehling
Am 2020-07-13 um 11:28 p.m. schrieb Dave Airlie: > On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: >> This allows exporting and importing buffers. The API generates handles >> that can be used with the HIP IPC API, i.e. big numbers rather than >> file descriptors. > First up why? I get the

Re: [PATCH v4 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-13 Thread kernel test robot
Hi Karthik, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.8-rc5 next-20200713] [cannot apply to drm/drm-next] [If your patch

Re: [PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 13:14, Felix Kuehling wrote: > > This allows exporting and importing buffers. The API generates handles > that can be used with the HIP IPC API, i.e. big numbers rather than > file descriptors. First up why? I get the how. > + * @share_handle is a 128 bit random number

[PATCH 0/1] Upstreaming the KFD IPC API

2020-07-13 Thread Felix Kuehling
This API is used by MPI/UCX for efficiently sharing VRAM between MPI ranks on the same node. It has been part of the ROCm DKMS branch for a long time. This code is refactored to be less invasive for upstreaming. As a result struct kfd_bo and the associated interval tree is not needed upstream.

[PATCH 1/1] drm/amdkfd: Add IPC API

2020-07-13 Thread Felix Kuehling
This allows exporting and importing buffers. The API generates handles that can be used with the HIP IPC API, i.e. big numbers rather than file descriptors. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 5 + .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |

linux-next: manual merge of the drm-intel tree with the drm tree

2020-07-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/drm_probe_helper.c between commit: 12c683e12cd8 ("drm: bridge: Pass drm_display_info to drm_bridge_funcs .mode_valid()") from the drm tree and commit: 1c26b8e09004 ("drm/probe_helper: Add

Re: [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML

2020-07-13 Thread Rob Herring
On Wed, 01 Jul 2020 09:05:25 +0300, Laurent Pinchart wrote: > Convert the Renesas R-Car FCP text binding to YAML. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Niklas Söderlund > --- > Changes since v2: > > - Refer to the correct device in the comment

Re: [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml

2020-07-13 Thread Rob Herring
On Tue, 30 Jun 2020 01:52:02 +0200, Paul Cercueil wrote: > Add documentation of the Device Tree bindings for the Image Processing > Unit (IPU) found in most Ingenic SoCs. > > Signed-off-by: Paul Cercueil > --- > > Notes: > v2: Add missing 'const' in items list > >

[PATCH] drm/vmwgfx: fix update of display surface when resolution changes

2020-07-13 Thread Roland Scheidegger (VMware)
From: Roland Scheidegger The assignment of metadata overwrote the new display resolution values, hence we'd miss the size actually changed and wouldn't redefine the surface. This would then lead to command buffer error when trying to update the screen target (due to the size mismatch), and

[PATCH v4 3/5] drm/i915: Add checks specific to async flips

2020-07-13 Thread Karthik B S
Support added only for async flips on primary plane. If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject async flip. v2: -Replace DRM_ERROR (Paulo) -Add

[PATCH v4 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-07-13 Thread Karthik B S
Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called before writing the surface address register as the write to this register triggers the flip done interrupt

[PATCH v4 5/5] drm/i915: Enable async flips in i915

2020-07-13 Thread Karthik B S
Enable asynchronous flips in i915 for gen9+ platforms. v2: -Async flip enablement should be a stand alone patch (Paulo) v3: -Move the patch to the end of the serires (Paulo) v4: -Rebased. Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni ---

[PATCH v4 2/5] drm/i915: Add support for async flips in I915

2020-07-13 Thread Karthik B S
Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) Signed-off-by: Karthik B S Signed-off-by: Vandita Kulkarni ---

[PATCH v4 4/5] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-07-13 Thread Karthik B S
Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get as it was causing issues for PSR. v3: -No need to wait for vblank to pass, as this wait was causing a 16ms delay

Re: [PATCH v2] drm/exynos: gem: Fix sparse warning

2020-07-13 Thread Inki Dae
20. 7. 14. 오전 1:03에 Sam Ravnborg 이(가) 쓴 글: > On Mon, Jul 13, 2020 at 09:07:08AM +0200, Marek Szyprowski wrote: >> kvaddr element of the exynos_gem object points to a memory buffer, thus >> it should not have a __iomem annotation. Then, to avoid a warning or >> casting on assignment to fbi

[PATCH v4 0/5] Asynchronous flip implementation for i915

2020-07-13 Thread Karthik B S
Without async flip support in the kernel, fullscreen apps where game resolution is equal to the screen resolution, must perform an extra blit per frame prior to flipping. Asynchronous page flips will also boost the FPS of Mesa benchmarks. v2: -Few patches have been squashed and patches have been

Re: [PATCH] drm/vmwgfx: Fix two list_for_each loop exit tests

2020-07-13 Thread Roland Scheidegger
Am 26.06.20 um 12:39 schrieb Dan Carpenter: > These if statements are supposed to be true if we ended the > list_for_each_entry() loops without hitting a break statement but they > don't work. > > In the first loop, we increment "i" after the "if (i == unit)" condition > so we don't necessarily

Re: [PATCH] drm/vmwgfx: Use correct vmw_legacy_display_unit pointer

2020-07-13 Thread Roland Scheidegger
Sorry for the delay, finally got time to look at this, seems all correct to me, thanks. Applied to our vmvgfx-next tree. (I do wonder how this somehow was supposed to work for all this time...) Roland Am 26.06.20 um 12:34 schrieb Dan Carpenter: > The "entry" pointer is an offset from the list

Re: [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 07:38:41PM +0530, Kalyan Thota wrote: > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. > > Changes in v1: > - Address

Re: [PATCH v7 07/36] drm: exynos: use common helper for a scatterlist contiguity check

2020-07-13 Thread Inki Dae
20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글: > Use common helper for checking the contiguity of the imported dma-buf. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 +++ > 1 file changed,

Re: [PATCH v7 08/36] drm: exynos: fix common struct sg_table related issues

2020-07-13 Thread Inki Dae
20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글: > The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function > returns the number of the created entries in the DMA address space. > However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and > dma_unmap_sg must be called

Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:33 +0300, Laurent Pinchart wrote: > Convert the Renesas R-Car VSP1 text binding to YAML. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Simplify comments on compatible strings > - Update MAINTAINERS > --- >

Re: [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:34 +0300, Laurent Pinchart wrote: > The power-domains and resets properties are used in all DT sources in > the kernel but are absent from the bindings. Document them and make them > mandatory. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > ---

Re: [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:32 +0300, Laurent Pinchart wrote: > The resets property is used in DT sources in the kernel tree. Document > it and make it mandatory. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Fix typo in commit message >

Re: [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:31 +0300, Laurent Pinchart wrote: > All DT source files in the kernel tree specify the power-domains > property. Make it mandatory. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Fix typo in comment message > ---

Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:30 +0300, Laurent Pinchart wrote: > Convert the Renesas R-Car FDP1 text binding to YAML. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Update MAINTAINERS > --- > .../bindings/media/renesas,fdp1.txt |

Re: [PATCH v2 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:28 +0300, Laurent Pinchart wrote: > All DT source files in the kernel tree specify the power-domains > property. Make it mandatory. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Geert Uytterhoeven > --- > Changes since v1: > > - Fix typo in commit message > --- >

Re: [PATCH v2 3/8] dt-bindings: media: renesas, fcp: Add resets and iommus properties

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:29 +0300, Laurent Pinchart wrote: > The resets and iommus properties are used in DT sources in the kernel > tree. Document them, and make resets mandatory. The iommus property is > optional as not all platforms wire the FCP to a functional IOMMU. > > Signed-off-by:

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > > wrote: > > > > > > > > I found that if I

Re: [PATCH v4 3/3] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:42PM -0400, Jonathan Marek wrote: > Check for errors instead of silently not using icc if the msm driver > probes before the interconnect driver. > > Allow ENODATA for ocmem path, as it is optional and this error > is returned when "gfx-mem" path is provided but not

Re: [Freedreno] [PATCH v4 2/3] drm/msm: reset devfreq freq_table/max_state before devfreq_add_device

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:41PM -0400, Jonathan Marek wrote: > These never get set back to 0 when probing fails, so an attempt to probe > again results in broken behavior. Fix the problem by setting thse to zero > before they are used. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan

Re: [PATCH v4 1/3] drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init,cleanup}

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:40PM -0400, Jonathan Marek wrote: > adreno_gpu_init calls pm_runtime_enable, so adreno_gpu_cleanup needs to > call pm_runtime_disable. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++ > 1 file

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > > wrote: > > > > > > > > I found that if I ever

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-13 Thread Dave Airlie
On Tue, 14 Jul 2020 at 02:39, Christian König wrote: > > Am 13.07.20 um 18:26 schrieb Daniel Vetter: > > Hi Christian, > > > > On Wed, Jul 08, 2020 at 04:57:21PM +0200, Christian König wrote: > >> Could we merge this controlled by a separate config option? > >> > >> This way we could have the

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Herring
On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > wrote: > > > > > > I found that if I ever had a little mistake in my kernel config, > > > or device tree, or graphics

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-13 Thread Daniel Vetter
On Mon, Jul 13, 2020 at 8:39 PM Sam Ravnborg wrote: > > On Mon, Jul 13, 2020 at 06:21:59PM +0200, Daniel Vetter wrote: > > On Fri, Jul 10, 2020 at 08:28:16AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 09.07.20 um 21:30 schrieb Sam Ravnborg: > > > > Mark reported that sparc64 would

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-13 Thread Sam Ravnborg
On Mon, Jul 13, 2020 at 06:21:59PM +0200, Daniel Vetter wrote: > On Fri, Jul 10, 2020 at 08:28:16AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 09.07.20 um 21:30 schrieb Sam Ravnborg: > > > Mark reported that sparc64 would panic while booting using qemu. > > > Mark bisected this to a patch

Re: [RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:24:26PM +0300, Georgi Djakov wrote: > On 7/1/20 07:25, Jonathan Marek wrote: > > The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able > > to query the interconnect driver for bcm addresses and commands. > > It's not very clear to me how the GMU

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 8:59 AM wrote: > > On 2020-07-10 22:38, Rob Clark wrote: > > On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota > > wrote: > >> > >> This change adds support to scale src clk and bandwidth as > >> per composition requirements. > >> > >> Interconnect registration for bw has been

[PATCH v4 2/2] drm/i915/mst: filter out the display mode exceed sink's capability

2020-07-13 Thread Lyude Paul
From: Lee Shawn C So far, max dot clock rate for MST mode rely on physcial bandwidth limitation. It would caused compatibility issue if source display resolution exceed MST hub output ability. For example, source DUT had DP 1.2 output capability. And MST docking just support HDMI 1.4 spec. When

[PATCH v4 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-13 Thread Lyude Paul
This is just an atomic version of mode_valid, which is intended to be used for situations where a driver might need to check the atomic state of objects other than the connector itself. One such example is with MST, where the maximum possible bandwidth on a connector can change dynamically

[PATCH v4 0/2] drm/probe_helper, i915: Validate MST modes against PBN limits

2020-07-13 Thread Lyude Paul
Something we've been missing for a while with drivers that support MST is being able to prune modes that can't be set due to bandwidth limitations. So, let's go ahead and add that. This also adds a new hook that was needed, mode_valid_ctx, so that we can grab additional locks as needed when

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-13 Thread Christian König
Am 13.07.20 um 18:26 schrieb Daniel Vetter: Hi Christian, On Wed, Jul 08, 2020 at 04:57:21PM +0200, Christian König wrote: Could we merge this controlled by a separate config option? This way we could have the checks upstream without having to fix all the stuff before we do this? Discussions

Re: [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-07-13 Thread Rob Herring
On Fri, Jul 10, 2020 at 07:27:49PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: >

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-13 Thread Daniel Vetter
Hi Christian, On Wed, Jul 08, 2020 at 04:57:21PM +0200, Christian König wrote: > Could we merge this controlled by a separate config option? > > This way we could have the checks upstream without having to fix all the > stuff before we do this? Discussions died out a bit, do you consider this a

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-13 Thread Daniel Vetter
On Fri, Jul 10, 2020 at 08:28:16AM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.07.20 um 21:30 schrieb Sam Ravnborg: > > Mark reported that sparc64 would panic while booting using qemu. > > Mark bisected this to a patch that introduced generic fbdev emulation to > > the bochs DRM driver. > >

Re: KASAN: use-after-free Read in drm_gem_object_release

2020-07-13 Thread Daniel Vetter
Adding Thomas, who's the main author for vram helpers. -Daniel On Fri, Jul 10, 2020 at 1:53 PM Dan Carpenter wrote: > > On Fri, Jul 10, 2020 at 04:24:03PM +0800, butt3rflyh4ck wrote: > > I report a bug (in linux-5.8.0-rc4) found by syzkaller. > > > > kernel config: > >

Re: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail

2020-07-13 Thread Daniel Vetter
On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote: > On 07/02, Daniel Vetter wrote: > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote: > > > there is an error when igt test is run continuously. > > > vkms_atomic_commit_tail() > > > need to call

Re: [PATCH v2] drm/exynos: gem: Fix sparse warning

2020-07-13 Thread Sam Ravnborg
On Mon, Jul 13, 2020 at 09:07:08AM +0200, Marek Szyprowski wrote: > kvaddr element of the exynos_gem object points to a memory buffer, thus > it should not have a __iomem annotation. Then, to avoid a warning or > casting on assignment to fbi structure, the screen_buffer element of the > union

Re: [PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-13 Thread Sam Ravnborg
Hi Tom. On Sun, Jul 12, 2020 at 08:24:53AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > sil-sii8620.c:184:2: warning: Undefined or garbage value > returned to caller [core.uninitialized.UndefReturn] > return ret; > ^~ >

Re: [PATCH 00/20] Documentation: eliminate duplicated words

2020-07-13 Thread Jonathan Corbet
On Tue, 7 Jul 2020 11:03:54 -0700 Randy Dunlap wrote: > Documentation/admin-guide/mm/numaperf.rst |2 +- > Documentation/block/pr.rst|2 +- > Documentation/core-api/printk-basics.rst |2 +- > Documentation/dev-tools/kgdb.rst

Re: [PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-13 Thread Andrzej Hajda
On 12.07.2020 17:24, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > sil-sii8620.c:184:2: warning: Undefined or garbage value >returned to caller [core.uninitialized.UndefReturn] > return ret; > ^~ > > sii8620_readb calls

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and

Re: [PATCH v9 1/4] driver core: add device probe log helper

2020-07-13 Thread Andy Shevchenko
On Mon, Jul 13, 2020 at 5:43 PM Andrzej Hajda wrote: > > During probe every time driver gets resource it should usually check for > error printk some message if it is not -EPROBE_DEFER and return the error. > This pattern is simple but requires adding few lines after any resource > acquisition

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-07-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #24 from Maurice Gale (mauricega...@gmail.com) --- Created attachment 290253 --> https://bugzilla.kernel.org/attachment.cgi?id=290253=edit New log with drm 116 -- You are receiving this mail because: You are watching the assignee

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-07-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #23 from Maurice Gale (mauricega...@gmail.com) --- Hi! Here's my environment: Monitor: - dell p4317q (Quad display Monitor) - Aside from the above, I have also tested on 4 separate monitors. Connectors: - Display -> HDMI (Brand:

Re: [PATCH][next] drm/i915/selftest: fix an error return path where err is not being set

2020-07-13 Thread Chris Wilson
Quoting Colin King (2020-07-13 15:25:51) > From: Colin Ian King > > There is an error condition where err is not being set and an uninitialized > garbage value in err is being returned. Fix this by assigning err to an > appropriate error return value before taking the error exit path. > >

Re: [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-07-13 Thread Rob Herring
On Fri, 10 Jul 2020 19:27:49 +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > -

[PATCH v9 0/4] driver core: add probe error check helper

2020-07-13 Thread Andrzej Hajda
Hi All, Thanks for comments. Changes since v8: - fixed typo in function name, - removed cocci script (added by mistake) Changes since v7: - improved commit message - added R-Bs Changes since v6: - removed leftovers from old naming scheme in commit descritions, - added R-Bs. Changes since v5:

[PATCH v9 3/4] drm/bridge/sii8620: fix resource acquisition error handling

2020-07-13 Thread Andrzej Hajda
In case of error during resource acquisition driver should print error message only in case it is not deferred probe, using dev_err_probe helper solves the issue. Moreover it records defer probe reason for debugging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong ---

[PATCH v9 1/4] driver core: add device probe log helper

2020-07-13 Thread Andrzej Hajda
During probe every time driver gets resource it should usually check for error printk some message if it is not -EPROBE_DEFER and return the error. This pattern is simple but requires adding few lines after any resource acquisition code, as a result it is often omitted or implemented only

[PATCH v9 4/4] drm/bridge: lvds-codec: simplify error handling

2020-07-13 Thread Andrzej Hajda
Using dev_err_probe code has following advantages: - shorter code, - recorded defer probe reason for debugging, - uniform error code logging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/lvds-codec.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH v9 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-13 Thread Andrzej Hajda
/sys/kernel/debug/devices_deferred property contains list of deferred devices. This list does not contain reason why the driver deferred probe, the patch improves it. The natural place to set the reason is dev_err_probe function introduced recently, ie. if dev_err_probe will be called with

[PATCH][next] drm/i915/selftest: fix an error return path where err is not being set

2020-07-13 Thread Colin King
From: Colin Ian King There is an error condition where err is not being set and an uninitialized garbage value in err is being returned. Fix this by assigning err to an appropriate error return value before taking the error exit path. Addresses-Coverity: ("Uninitialized scalar value") Fixes:

Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 3:18 AM wrote: > > On 2020-07-10 22:19, Rob Clark wrote: > > On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota > > wrote: > >> > >> Setup an RGB HW pipe as cursor which can be used on > >> secondary interface. > >> > >> For SC7180 2 HW pipes are enumerated as cursors > >> 1 -

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Herring
On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson wrote: > > I found that if I ever had a little mistake in my kernel config, > or device tree, or graphics driver that my system would sit in a loop > at bootup trying again and again and again. An example log was: Why do we care about optimizing

Re: [PATCH] drm/vboxvideo: Replace HTTP links with HTTPS ones

2020-07-13 Thread Hans de Goede
Hi, On 7/13/20 2:49 PM, Alexander A. Klimov wrote: Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`:

[PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-13 Thread Akhil P Oommen
This series adds support for GPU DDR bandwidth scaling and is based on the bindings from Georgi [1]. This is mostly a rebase of Sharat's patches [2] on the tip of msm-next branch. Changes from v4: - Squashed a patch to another one to fix Jonathan's comment - Add back the

[PATCH v5 5/6] arm64: dts: qcom: sc7180: Add interconnects property for GPU

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch adds the interconnects property to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v5 4/6] arm64: dts: qcom: SDM845: Enable GPU DDR bw scaling

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch adds the interconnects property for the gpu node and the opp-peak-kBps property to the opps of the gpu opp table. This should help enable DDR bandwidth scaling dynamically and proportionally to the GPU frequency. Signed-off-by: Sharat Masetty Signed-off-by:

[PATCH v5 6/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty Add opp-peak-kBps bindings to the GPU opp table, listing the peak GPU -> DDR bandwidth requirement for each opp level. This will be used to scale the DDR bandwidth along with the GPU frequency dynamically. Signed-off-by: Sharat Masetty Reviewed-by: Matthias Kaehlcke

[PATCH v5 3/6] drm: msm: a6xx: use dev_pm_opp_set_bw to scale DDR

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling GPU frequency. Also since the icc path voting is handled completely in the opp driver, remove the icc_path handle and its usage in the drm

[PATCH v5 1/6] dt-bindings: drm/msm/gpu: Document gpu opp table

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty Update documentation to list the gpu opp table bindings including the newly added "opp-peak-kBps" needed for GPU-DDR bandwidth scaling. Signed-off-by: Sharat Masetty Acked-by: Rob Herring Signed-off-by: Akhil P Oommen --- .../devicetree/bindings/display/msm/gpu.txt

[PATCH v5 2/6] drm: msm: a6xx: send opp instead of a frequency

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch changes the plumbing to send the devfreq recommended opp rather than the frequency. Also consolidate and rearrange the code in a6xx to set the GPU frequency and the icc vote in preparation for the upcoming changes for GPU->DDR scaling votes. Signed-off-by: Sharat

Re: [PATCH] drm: omapdrm: Replace HTTP links with HTTPS ones

2020-07-13 Thread Laurent Pinchart
Hi Alexander, Thank you for the patch. On Mon, Jul 13, 2020 at 02:28:59PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not

[PATCH v2 07/24] scsi: aacraid: commsup: Fix a bunch of function header issues

2020-07-13 Thread Lee Jones
Some parameters not documented. Others misspelled. Also, functions must follow directly after the header that documents them. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/commsup.c:223: warning: Function parameter or member 'scmd' not described in 'aac_fib_alloc_tag'

[PATCH v2] drm/exynos: gem: Fix sparse warning

2020-07-13 Thread Marek Szyprowski
kvaddr element of the exynos_gem object points to a memory buffer, thus it should not have a __iomem annotation. Then, to avoid a warning or casting on assignment to fbi structure, the screen_buffer element of the union should be used instead of the screen_base. Reported-by: kernel test robot

Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-07-13 Thread Qiang Yu
Applied to drm-misc-next: https://cgit.freedesktop.org/drm/drm-misc/ Sorry for the late response. Regards, Qiang On Tue, Jul 7, 2020 at 12:17 AM Andrey Lebedev wrote: > > Hello guys, > > What is the status of this patch? Was this committed to any branch? Is > it pending for merge to the

Re: [PATCH] drm/exynos: gem: Fix sparse warning

2020-07-13 Thread Marek Szyprowski
Hi Sam, On 10.07.2020 20:30, Sam Ravnborg wrote: > Hi Marek. > > On Tue, Jul 07, 2020 at 01:08:59PM +0200, Marek Szyprowski wrote: >> Add a proper cast on the exynos_gem->kvaddr assignment to avoid a sparse >> warning. >> >> Reported-by: kernel test robot >> Fixes: 9940d9d93406 ("drm/exynos: