Re: [PATCH v6 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2021-02-12 Thread kernel test robot
Hi Aurabindo, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210211] [also build test ERROR on v5.11-rc7] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip tegra-drm/drm/tegra/for-next linus/master drm-exynos/exynos-drm-next drm/drm-next v5.11-rc7

Re: [PATCH 2/3] drm/ttm: remove swap LRU

2021-02-12 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm-exynos/exynos-drm-next drm/drm-next v5.11-rc7 next-20210125] [If your patch is applied to the

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-12 Thread Lyude Paul
(adding danvet to here, as I'd imagine they might be interested in seeing some of this) Thank you for the descriptive write up. I think we can solve some of the problems you described here, however the patches that you submitted definitely won't work as-is. In patch 2, by reverting Intel back to

[Bug 210849] Black screen after resume from long suspend. Open/Close lid. AMDGPU

2021-02-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210849 --- Comment #17 from JerryD (jvdeli...@charter.net) --- Possible fixed in this commit: https://github.com/torvalds/linux/commit/a81bfdf8bf5396824d7d139560180854cb599b06 -- You may reply to this email to add a comment. You are receiving this

[PATCH v6 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2021-02-12 Thread Aurabindo Pillai
[Why] While possible for userspace to create and add custom mode based off the optimized mode for the connected display which differs only in front porch timing, this patch set adds a list of common video modes in advance. The list of common video refresh rates is small, well known and the

[PATCH v6 1/3] drm/amd/display: Add module parameter for freesync video mode

2021-02-12 Thread Aurabindo Pillai
[Why] This option shall be opt-in by default since it is a temporary solution until long term solution is agreed upon which may require userspace interface changes. This feature give the user a seamless experience when freesync aware programs (media players for instance) switches to a compatible

[PATCH v6 3/3] drm/amd/display: Skip modeset for front porch change

2021-02-12 Thread Aurabindo Pillai
[Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on a display with a variable vtotal min/max. Smooth video playback usecases can be enabled with this seamless transition by switching to a new mode which has a

[PATCH v6 0/3] Freesync video mode optimization

2021-02-12 Thread Aurabindo Pillai
Changes in V6 = 1) Skip modeset for front porch change * Minor optimizations 2) Add freesync video modes based on preferred modes: * Remove edid parsing and use the already parsed valuescached in dm for the monitor's freesync range 3) Add module parameter for freesync video

Re: [PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Alaa-Emad/Fix-space-prohibited-issue-in-fbtft-bus-c/20210212-230034 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c config

[PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all != DCE-11.0.

2021-02-12 Thread Mario Kleiner
Spatial dithering to 10 bpc depth was disabled for all DCE's. Restrict this to DCE-11.0, but allow it on other DCE's. Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill effects, but a measureable precision improvement (via colorimeter) when displaying a fp16 framebuffer to a 10 bpc DP

Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-12 Thread Lyude Paul
On Wed, 2021-02-10 at 23:15 -0500, Rodrigo Vivi wrote: > On Mon, Feb 08, 2021 at 06:39:00PM -0500, Lyude Paul wrote: > > Since we're about to implement eDP backlight support in nouveau using the > > standard protocol from VESA, we might as well just take the code that's > > already written for

[PATCH] drm: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
Convert S_ permissions to the more readable octal. Link: https://lore.kernel.org/lkml/ca+55afw5v23t-zvdzp-mmd_eyxf8wbafwwb59934fv7g21u...@mail.gmail.com/ Done using: $ git ls-files -- drivers/gpu/drm/*.[ch] | xargs ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS No difference

Re: [git pull] drm fixes for 5.11 final

2021-02-12 Thread pr-tracker-bot
The pull request you sent on Fri, 12 Feb 2021 15:20:52 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-02-12 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a81bfdf8bf5396824d7d139560180854cb599b06 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

2021-02-12 Thread Aurabindo Pillai
On 2021-02-08 10:06 a.m., Kazlauskas, Nicholas wrote: On 2021-01-24 11:00 p.m., Aurabindo Pillai wrote: On 2021-01-21 2:05 p.m., Kazlauskas, Nicholas wrote: On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming

[PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-12 Thread Florian Fainelli
As Dave reported: This seems to have unintended side effects. GIC interrupt 117 is shared between the standard I2C controllers (i2c-bcm2835) and the l2-intc block handling the HDMI I2C interrupts. There is not a great way to share an interrupt between an interrupt controller using the chained

[PATCH v2] drm/i915/gen9bc: Handle TGP PCH during suspend/resume

2021-02-12 Thread Lyude Paul
From: Tejas Upadhyay For Legacy S3 suspend/resume GEN9 BC needs to enable and setup TGP PCH. v2: * Move Wa_14010685332 into it's own function - vsyrjala * Add TODO comment about figuring out if we can move this workaround - imre Cc: Matt Roper Signed-off-by: Tejas Upadhyay Signed-off-by:

[PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Alaa Emad
This change fixes a checkpatch error for "space prohibited before that close parenthesis ')'" Signed-off-by: Alaa Emad --- certs/x509_revocation_list| 0 drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644

Re: [v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Rob Clark
On Fri, Feb 12, 2021 at 3:45 AM Kalyan Thota wrote: > > Set the flag vblank_disable_immediate = true to turn off vblank irqs > immediately as soon as drm_vblank_put is requested so that there are > no irqs triggered during idle state. This will reduce cpu wakeups > and help in power saving. > >

Re: [Freedreno] [v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-12 Thread Rob Clark
On Thu, Feb 11, 2021 at 7:31 AM wrote: > > On 2021-02-11 01:56, Rob Clark wrote: > > On Wed, Feb 10, 2021 at 3:41 AM wrote: > >> > >> On 2021-02-01 00:46, Rob Clark wrote: > >> > On Fri, Dec 18, 2020 at 2:27 AM Kalyan Thota > >> > wrote: > >> >> > >> >> Set the flag vblank_disable_immediate =

[PATCH v5 1/3] drm/uapi: Add USB connector type

2021-02-12 Thread Noralf Trønnes
Add a connector type for USB connected display panels. Some examples of what current userspace will name the connector: - Weston: "UNNAMED-%d" - Mutter: "Unknown20-%d" - X: "Unknown20-%d" v2: - Update drm_connector_enum_list - Add examples to commit message Acked-by: Daniel Vetter

[PATCH v5 3/3] drm: Add Generic USB Display driver

2021-02-12 Thread Noralf Trønnes
This adds a generic USB display driver with the intention that it can be used with future USB interfaced low end displays/adapters. The Linux gadget device driver will serve as the canonical device implementation. The following DRM properties are supported: - Plane rotation - Connector TV

[PATCH v5 0/3] GUD USB Display driver

2021-02-12 Thread Noralf Trønnes
Hi, A while back I had the idea to turn a Raspberry Pi Zero into a $5 USB to HDMI/SDTV/DPI display adapter. The protocol is open so people are free to make displays implementing it and use this driver, all that's needed is to add a USB vid:pid to the driver for the display. See the wiki[1] for

[PATCH v5 2/3] drm/probe-helper: Check epoch counter in output_poll_execute()

2021-02-12 Thread Noralf Trønnes
drm_helper_hpd_irq_event() checks the epoch counter to determine connector status change. This was introduced in commit 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector"). Do the same for output_poll_execute() so it can detect other changes beside connection status value changes. v2:

Re: [PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-12 Thread Sebastian Reichel
Hi, On Fri, Feb 12, 2021 at 05:32:29PM +0100, Krzysztof Kozlowski wrote: > Milo Kim's email in TI bounces with permanent error (550: Invalid > recipient). Last email from him on LKML was in 2017. Move Milo Kim to > credits and remove the separate driver entries for: > - TI LP855x backlight

Re: Proposed Changes to Elida-KD35T133 Panel Driver

2021-02-12 Thread Daniel Vetter
On Fri, Feb 12, 2021 at 08:16:13AM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.02.21 um 18:51 schrieb Christopher Morgan: > > I'd like to make the following changes to this panel driver. The first > > patch is to add rotation support (rotates only the DRM connector at this > > time). The

[PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-12 Thread Krzysztof Kozlowski
Milo Kim's email in TI bounces with permanent error (550: Invalid recipient). Last email from him on LKML was in 2017. Move Milo Kim to credits and remove the separate driver entries for: - TI LP855x backlight driver, - TI LP8727 charger driver, - TI LP8788 MFD (ADC, LEDs, charger and

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-12 Thread Petr Mladek
On Fri 2021-02-12 13:28:56, Sakari Ailus wrote: > On Thu, Feb 11, 2021 at 06:14:28PM +0100, Petr Mladek wrote: > > On Tue 2021-02-09 19:47:55, Sakari Ailus wrote: > > > Hi Andy, > > > > > > On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote: > > > > On Tue, Feb 09, 2021 at 11:20:32AM

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Chris Wilson
Quoting Emil Velikov (2021-02-12 15:45:04) > On Fri, 12 Feb 2021 at 15:16, Chris Wilson wrote: > > > > Quoting Emil Velikov (2021-02-12 14:57:56) > > > Hi Chris, > > > > > > On Thu, 4 Feb 2021 at 12:11, Chris Wilson > > > wrote: > > > > > > > > Register with /proc/gpu to provide the client

[PATCH 2/2] drm/panel: correct typo in comments for Elida KD35T133 panel driver

2021-02-12 Thread Chris Morgan
Update the comments to state this is a 3.5" display and not a 5.5" display Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c

[PATCH 1/2] drm/panel: add rotation support for Elida KD35T133 panels

2021-02-12 Thread Chris Morgan
Update the panel to allow setting the rotation value in device tree. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Emil Velikov
On Fri, 12 Feb 2021 at 15:16, Chris Wilson wrote: > > Quoting Emil Velikov (2021-02-12 14:57:56) > > Hi Chris, > > > > On Thu, 4 Feb 2021 at 12:11, Chris Wilson wrote: > > > > > > Register with /proc/gpu to provide the client runtimes for generic > > > top-like overview, e.g.

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Chris Wilson
Quoting Emil Velikov (2021-02-12 14:57:56) > Hi Chris, > > On Thu, 4 Feb 2021 at 12:11, Chris Wilson wrote: > > > > Register with /proc/gpu to provide the client runtimes for generic > > top-like overview, e.g. gnome-system-monitor can use this information to > > show the per-process multi-GPU

Re: [PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:58:33PM +0200, Alaa Emad wrote: > This change fixes a checkpatch error for "space prohibited before that close > parenthesis ')'" > > Signed-off-by: Alaa Emad > --- > certs/x509_revocation_list| 0 > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 2 files

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-12 Thread Andrey Grodzovsky
Ping Andrey On 2/10/21 5:01 PM, Andrey Grodzovsky wrote: On 2/9/21 10:40 AM, Christian König wrote: Am 09.02.21 um 15:30 schrieb Andrey Grodzovsky: [SNIP] Question - Why can't we just set those PTEs to point to system memory (another RO dummy page) filled with 1s ? Then writes are not

Re: [RFC 3/3] drm/i915/gt: Export device and per-process runtimes via procfs

2021-02-12 Thread Emil Velikov
Hi Chris, On Thu, 4 Feb 2021 at 12:11, Chris Wilson wrote: > > Register with /proc/gpu to provide the client runtimes for generic > top-like overview, e.g. gnome-system-monitor can use this information to > show the per-process multi-GPU usage. > Exposing this information to userspace sounds

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Emil Velikov
On Fri, 12 Feb 2021 at 14:01, Michel Dänzer wrote: > > On 2021-02-12 1:57 p.m., Emil Velikov wrote: > > On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: > >> > >> Userspace has discovered the functionality offered by SYS_kcmp and has > >> started to depend upon it. In particular, Mesa uses

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Emil Velikov
On Fri, 12 Feb 2021 at 13:14, Simon Ser wrote: > > On Friday, February 12th, 2021 at 1:57 PM, Emil Velikov > wrote: > > > On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: > > > > > > Userspace has discovered the functionality offered by SYS_kcmp and has > > > started to depend upon it. In

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Michel Dänzer
On 2021-02-12 1:57 p.m., Emil Velikov wrote: On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: Userspace has discovered the functionality offered by SYS_kcmp and has started to depend upon it. In particular, Mesa uses SYS_kcmp for os_same_file_description() in order to identify when two fd

[v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. To enable vblank_disable_immediate flag the underlying KMS driver

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Simon Ser
On Friday, February 12th, 2021 at 1:57 PM, Emil Velikov wrote: > On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: > > > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description()

Re: [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Emil Velikov
On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: > > Userspace has discovered the functionality offered by SYS_kcmp and has > started to depend upon it. In particular, Mesa uses SYS_kcmp for > os_same_file_description() in order to identify when two fd (e.g. device > or dmabuf) As you rightfully

[v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
From: Kalyan Thota Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. To enable vblank_disable_immediate flag the

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-12 Thread Maxime Ripard
On Fri, Feb 12, 2021 at 12:20:14PM +0100, Nicolas Saenz Julienne wrote: > On Wed, 2021-02-10 at 10:49 -0800, Florian Fainelli wrote: > > On 2/10/21 7:49 AM, Dave Stevenson wrote: > > > Hi Marc. > > > > > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: > > > > > > > > Hi Maxime, > > > > > >

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-12 Thread Sakari Ailus
Hi Petr, Thanks for the comments. On Thu, Feb 11, 2021 at 06:14:28PM +0100, Petr Mladek wrote: > On Tue 2021-02-09 19:47:55, Sakari Ailus wrote: > > Hi Andy, > > > > On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus

Re: [RFC v4 05/11] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit

2021-02-12 Thread Jani Nikula
On Mon, 08 Feb 2021, Lyude Paul wrote: > Get rid of the extraneous switch case in here, and just open code > edp_backlight_mode as we only ever use it once. > > v4: > * Check that backlight mode is DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD, not > DP_EDP_BACKLIGHT_CONTROL_MODE_MASK - imirkin > >

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-12 Thread Nicolas Saenz Julienne
On Wed, 2021-02-10 at 10:49 -0800, Florian Fainelli wrote: > On 2/10/21 7:49 AM, Dave Stevenson wrote: > > Hi Marc. > > > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: > > > > > > Hi Maxime, > > > > > > On 2021-02-10 14:40, Maxime Ripard wrote: > > > > Hi Dave, > > > > > > > > On Tue,

Re: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-12 Thread Gerd Hoffmann
On Fri, Feb 12, 2021 at 08:15:12AM +, Kasireddy, Vivek wrote: > Hi Gerd, > > > > > You don't have to use the rendering pipeline. You can let the i915 > > > > gpu render into a dma-buf shared with virtio-gpu, then use > > > > virtio-gpu only for buffer sharing with the host. > [Kasireddy,

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 driver

2021-02-12 Thread Marek Vasut
On 2/12/21 9:43 AM, Linus Walleij wrote: On Thu, Feb 4, 2021 at 11:05 PM Marek Vasut wrote: On 2/4/21 10:10 PM, Doug Anderson wrote: + /* +* Reset the chip, pull EN line low for t_reset=10ms, +* then high for t_en=1ms. +*/ +

Re: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-12 Thread Gerd Hoffmann
Hi, > This is because of the fundamental concept of DMA-buf that the exporter > needs to setup mappings (both CPU page tables as well as stuff like IOMMU). > When the guest exports something it would mean that you give the guest > control over the IOMMU and/or host page tables. And that is not

Re: [PATCH] video: use getter/setter functions

2021-02-12 Thread Lee Jones
On Tue, 09 Feb 2021, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > spi_device structure. > > Signed-off-by: Julia Lawall > > --- > drivers/video/backlight/qcom-wled.c |2 > +- > drivers/video/fbdev/amifb.c

Re: [PATCH v6 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-12 Thread Sakari Ailus
Hi Petr, On Thu, Feb 11, 2021 at 05:31:46PM +0100, Petr Mladek wrote: > On Mon 2021-02-08 22:09:02, Sakari Ailus wrote: > > Now that we can print FourCC codes directly using printk, make use of the > > feature in V4L2 core. > > > > Signed-off-by: Sakari Ailus > > --- > >

Re: [PATCH] drm/tiny: add driver for newhaven,1.8-128160EF

2021-02-12 Thread Thomas Zimmermann
Hi Am 12.02.21 um 10:47 schrieb Daniel Mack: Hi, Thanks for the review! On 2/12/21 8:13 AM, Thomas Zimmermann wrote: thanks for the driver. I only have some minor comments Am 11.02.21 um 10:50 schrieb Daniel Mack: +#define ILI9163_MADCTL_BGR    BIT(3) +#define ILI9163_MADCTL_MV    BIT(5)

[PATCH v2 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-02-12 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- v2: * Address comments from Thomas Zimmermann * Split patch in DT and implementation part drivers/gpu/drm/tiny/Kconfig | 13 ++

[PATCH v2 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-02-12 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../bindings/display/ilitek,ili9163.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.txt diff

Re: [PATCH] drm/tiny: add driver for newhaven,1.8-128160EF

2021-02-12 Thread Daniel Mack
Hi, Thanks for the review! On 2/12/21 8:13 AM, Thomas Zimmermann wrote: > thanks for the driver. I only have some minor comments > > Am 11.02.21 um 10:50 schrieb Daniel Mack: >> +#define ILI9163_MADCTL_BGR    BIT(3) >> +#define ILI9163_MADCTL_MV    BIT(5) >> +#define ILI9163_MADCTL_MX    BIT(6)

Re: [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-12 Thread Joe Perches
On Mon, 2021-02-08 at 10:57 -0800, Stephen Boyd wrote: > Quoting Joe Perches (2021-02-06 21:06:54) > > Wow, that's really unfortunate that dp_panel_update_tu_timings > > is also void. > > > > Perhaps this as YA checkpatch warning: > > > > --- > > Acked-by: Stephen Boyd Are you acking the

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-12 Thread Robert Foss
Hey Nicolas, Thanks for submitting this, making these flags more intuitive is really nice. This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Thu, 11 Feb 2021 at 04:34, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects, >

Re: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-12 Thread Christian König
Hi Vivek, Am 12.02.21 um 09:36 schrieb Kasireddy, Vivek: Hi Christian, Hi Vivek, [Kasireddy, Vivek] What if I do mmap() on the fd followed by mlock() or mmap() followed by get_user_pages()? If it still fails, would ioremapping the device memory and poking at the backing storage be an

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 driver

2021-02-12 Thread Linus Walleij
On Thu, Feb 4, 2021 at 11:05 PM Marek Vasut wrote: > On 2/4/21 10:10 PM, Doug Anderson wrote: > + /* > +* Reset the chip, pull EN line low for t_reset=10ms, > +* then high for t_en=1ms. > +*/ > + gpiod_set_value(ctx->enable_gpio, 0); >

RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-12 Thread Kasireddy, Vivek
Hi Christian, > > Hi Vivek, > > > [Kasireddy, Vivek] What if I do mmap() on the fd followed by mlock() > > or mmap() followed by get_user_pages()? If it still fails, would > > ioremapping the device memory and poking at the backing storage be an > > option? Or, if I bind the passthrough'd GPU

Re: Not 100% sure if I correctly fixed drm-tip

2021-02-12 Thread Christian König
Am 12.02.21 um 09:27 schrieb Daniel Vetter: On Fri, Feb 12, 2021 at 08:51:19AM +0100, Christian König wrote: Am 11.02.21 um 18:22 schrieb Daniel Vetter: On Thu, Feb 11, 2021 at 4:27 PM Christian König wrote: Am 11.02.21 um 16:02 schrieb Jani Nikula: On Thu, 11 Feb 2021, Christian König

Re: Not 100% sure if I correctly fixed drm-tip

2021-02-12 Thread Daniel Vetter
On Fri, Feb 12, 2021 at 08:51:19AM +0100, Christian König wrote: > > > Am 11.02.21 um 18:22 schrieb Daniel Vetter: > > On Thu, Feb 11, 2021 at 4:27 PM Christian König > > wrote: > > > > > > > > > Am 11.02.21 um 16:02 schrieb Jani Nikula: > > > > On Thu, 11 Feb 2021, Christian König wrote: >

Re: [PATCH 1/4] drm/vram-helper: cleanup drm_gem_vram_bo_driver_move_notify

2021-02-12 Thread Thomas Zimmermann
Hi Am 11.02.21 um 14:16 schrieb Christian König: Swapping bo->mem was completely unecessary. Cleanup the function which is just a leftover from a TTM cleanup. Signed-off-by: Christian König Appears to work. Reviewed-by: Thomas Zimmermann Tested-by: Thomas Zimmermann ---

RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-12 Thread Kasireddy, Vivek
Hi Gerd, > > > You don't have to use the rendering pipeline. You can let the i915 > > > gpu render into a dma-buf shared with virtio-gpu, then use > > > virtio-gpu only for buffer sharing with the host. [Kasireddy, Vivek] Just to confirm my understanding of what you are suggesting, are you