Re: [PATCH 09/10] drm/ast: Detect ast device type and config mode without ast device

2023-11-13 Thread Thomas Zimmermann
Hi Am 13.11.23 um 16:25 schrieb Jocelyn Falempe: On 13/11/2023 09:50, Thomas Zimmermann wrote: Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. Signed-off-by: Thomas Zimmermann ---  

[PATCH] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v3)

2023-11-13 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with files that belong to

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-13 Thread Alexander Stein
Hi Michael, Am Montag, 13. November 2023, 17:43:44 CET schrieb Michael Walle: > The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 > mode. It seems the bridge internally queues DSI packets and when the > FORCE_STOP_STATE bit is cleared, they are sent in close succession >

[PATCH] drm/amd/display: fix NULL dereference

2023-11-13 Thread José Pekkarinen
The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector

[V3] drm/panel: auo,b101uan08.3: Fine tune the panel power sequence

2023-11-13 Thread Xuxin Xiong
For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 56ad624b4cb5 ("drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel") Signed-off-by: Xuxin Xiong --- Changes in V3: -

[V2] drm/panel: auo,b101uan08.3: Fine tune the panel power sequence

2023-11-13 Thread Xuxin Xiong
For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 56ad624b4cb5("drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel") Signed-off-by: Xuxin Xiong ---

linux-next: build warning after merge of the drm-intel tree

2023-11-13 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation. Documentation/gpu/drm-kms-helpers:296:

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, BTW, cherry picking commits does not avoid conflicts - in fact it can cause conflicts if there are further changes to the files affected by the cherry picked commit in either the tree/branch the commit was cheery picked from or the destination tree/branch (I have to deal with these all

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 21:45, Stephen Rothwell wrote: > Hi Luben, > > On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: >> >> On 2023-11-13 20:08, Luben Tuikov wrote: >>> On 2023-11-13 15:55, Stephen Rothwell wrote: Hi all, Commit 0da611a87021 ("dma-buf: add

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: > > On 2023-11-13 20:08, Luben Tuikov wrote: > > On 2023-11-13 15:55, Stephen Rothwell wrote: > >> Hi all, > >> > >> Commit > >> > >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > >> > >> is missing a Signed-off-by

[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()

2023-11-13 Thread heminhong
Current, the dewake_scanline variable is defined as unsigned int, an unsigned int variable that is always greater than or equal to 0. when _intel_dsb_commit function is called by intel_dsb_commit function, the dewake_scanline variable may have an int value. So the dewake_scanline variable is

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 20:08, Luben Tuikov wrote: > On 2023-11-13 15:55, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") >> >> is missing a Signed-off-by from its committer. >> > > In order to merge the scheduler changes necessary for the Xe

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 15:55, Stephen Rothwell wrote: > Hi all, > > Commit > > 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > > is missing a Signed-off-by from its committer. > In order to merge the scheduler changes necessary for the Xe driver, those changes were based on drm-tip,

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-13 Thread Luben Tuikov
Hi Jani, On 2023-11-10 07:40, Jani Nikula wrote: > On Thu, 09 Nov 2023, Luben Tuikov wrote: >> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially >> when no devices are available. This makes it easier to browse kernel logs. > > Please do not merge patches before people

[PATCH v2 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-13 Thread John . C . Harrison
From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is working. v2: Fix some dumb over-complications and a couple of

[PATCH v2 0/2] Selftest for FAST_REQUEST feature

2023-11-13 Thread John . C . Harrison
From: John Harrison Add a selftest to verify that the FAST_REQUEST mechanism (getting errors back from fire-and-forget H2G commands) is functional. Also fix up a potential false positive in the GuC hang selftest. v2: Fix some dumb over-complications and typos - review feedback from Daniele.

[PATCH v2 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-13 Thread John . C . Harrison
From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose of the test - to verify that the heartbeat will kick in if

Re: [PATCH] Revert "drm/sched: Define pr_fmt() for DRM using pr_*()"

2023-11-13 Thread Luben Tuikov
On 2023-11-11 06:33, Jani Nikula wrote: > On Sat, 11 Nov 2023, Luben Tuikov wrote: >> From Jani: >> The drm_print.[ch] facilities use very few pr_*() calls directly. The >> users of pr_*() calls do not necessarily include at >> all, and really don't have to. >> >> Even the ones that do include

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tests/drm_mm_test.c between commit: 2ba157983974 ("drm/tests: Fix incorrect argument in drm_test_mm_insert_range") from Linus' tree and commit: 078a5b498d6a ("drm/tests: Remove slow tests") from

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_job.c between commit: 6309727ef271 ("kthread: add kthread_stop_put") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc tree. I

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_ipc.c between commit: b0873eead1d1 ("accel/ivpu: Do not use wait event interruptible") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the

[PATCH drm-misc-next 2/2] drm/nouveau: enable dynamic job-flow control

2023-11-13 Thread Danilo Krummrich
Make use of the scheduler's credit limit and scheduler job's credit count to account for the actual size of a job, such that we fill up the ring efficiently. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 ++- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-

[PATCH drm-misc-next 1/2] drm/nouveau: implement 1:1 scheduler - entity relationship

2023-11-13 Thread Danilo Krummrich
Recent patches to the DRM scheduler [1][2] allow for a variable number of run-queues and add support for (shared) workqueues rather than dedicated kthreads per scheduler. This allows us to create a 1:1 relationship between a GPU scheduler and a scheduler entity, in order to properly support

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_drv.c between commit: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc

Re: [Intel-gfx] [PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-11-13 at 14:49 -0800, Zhanjun Dong wrote: > The gt wedged could be triggered by missing guc firmware file, HW not > working, etc. Once triggered, it means all gt usage is dead, therefore we > can't enable pxp under this fatal error condition. > > alan:skip alan: this looks good (as

Re: [PATCH] drm/i915: Initialize residency registers earlier

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-10-30 at 16:45 -0700, Belgaumkar, Vinay wrote: alan:skip > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c > @@ -608,11 +608,13 @@ void intel_rc6_init(struct intel_rc6 *rc6) > /* Disable runtime-pm until we can save the GPU state with rc6 pctx */ > rpm_get(rc6); > > - if

Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

[PATCH v3] drm: omapdrm: Improve check for contiguous buffers

2023-11-13 Thread Andrew Davis
While a scatter-gather table having only 1 entry does imply it is contiguous, it is a logic error to assume the inverse. Tables can have more than 1 entry and still be contiguous. Use a proper check here. Signed-off-by: Andrew Davis --- Changes from v2: - Double check that these multi-segment

Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

[PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Zhanjun Dong
The gt wedged could be triggered by missing guc firmware file, HW not working, etc. Once triggered, it means all gt usage is dead, therefore we can't enable pxp under this fatal error condition. v2: Updated commit message. v3: Updated return code check. Signed-off-by: Zhanjun Dong ---

Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 20:08:10 -0800 Mina Almasry wrote: > 1. For (b), would it be OK to implement a very minimal version of > queue_[stop|start]/queue_mem_[alloc|free], which I use for the sole > purpose of reposting buffers to an individual queue, and then later > whoever picks up your queue API

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 22:05:30 -0800 Mina Almasry wrote: > My issue here is that all these skb helpers call each other so I end > up having to move a lot of the unrelated skb helpers to this new > header (maybe that is acceptable but it feels weird). Splitting pp headers again is not an option, we

[PATCH drm-misc-next] drm/nouveau: use GPUVM common infrastructure

2023-11-13 Thread Danilo Krummrich
GPUVM provides common infrastructure to track external and evicted GEM objects as well as locking and validation helpers. Especially external and evicted object tracking is a huge improvement compared to the current brute force approach of iterating all mappings in order to lock and validate the

Re: [RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 19:28:52 -0800 Mina Almasry wrote: > My issue with this is that if the driver doesn't support dmabuf then > the driver will accidentally use the pp backed by the dmabuf, allocate > a page from it, then call page_address() on it or something, and > crash. > > Currently I avoid

Re: [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device

2023-11-13 Thread Uwe Kleine-König
Hello, On Fri, Jul 28, 2023 at 04:58:21PM +0200, Uwe Kleine-König wrote: > there are only two users of struct pwm_device::pwm in the tree; both use > it for some dev_dbg output. While this number allows to identify the > PWM, it's not trivial, for example the data currently available in >

linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi all, Commit 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpeMaIL1m2Gt.pgp Description: OpenPGP digital signature

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> We're not in a hurry. It's just my experience with patch series' affecting > multiple subsystems that typically the decision was to apply the full > series via one tree. Also to avoid inquires from maintainers like: > Shall I take it or are you going to take it? > Of course there may be

Re: [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiko Stübner
Am Montag, 13. November 2023, 12:23:25 CET schrieb Heiner Kallweit: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in

Re: [PATCH v2 6/8] dt-bindings: reserved-memory: Add secure CMA reserved memory range

2023-11-13 Thread Rob Herring
On Sat, 11 Nov 2023 19:15:57 +0800, Yong Wu wrote: > Add a binding for describing the secure CMA reserved memory range. The > memory range also will be defined in the TEE firmware. It means the TEE > will be configured with the same address/size that is being set in this > DT node. > >

Re: [PATCH] drm/i915: eliminate warnings

2023-11-13 Thread Rodrigo Vivi
On Mon, Nov 13, 2023 at 11:36:13AM +0800, heminhong wrote: > Current, the dewake_scanline variable is defined as unsigned int, > an unsigned int variable that is always greater than or equal to 0. > when _intel_dsb_commit function is called by intel_dsb_commit function, > the dewake_scanline

Re: [PATCH 5/5] accel/ivpu: Use threaded IRQ to handle JOB done messages

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: Remove job_done thread and replace it with generic callback based mechanism. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 4/5] accel/ivpu: Use dedicated work for job timeout detection

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka Change to use work for timeout detection. Needed for thread_irq conversion. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 3/5] accel/ivpu: Do not use cons->aborted for job_done_thread

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka This allow to simplify ivpu_ipc_receive() as now we do not have to process all messages in aborted state - they will be freed in ivpu_ipc_consumer_del(). Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz

[PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread Imre Deak
The current way of calculating the pbn_div value, the link BW per each MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR rates calculating with the correct channel coding efficiency based on the link rate. On UHBR the resulting pbn_div value is not an integer (vs. DP 1.4 where

Re: [PATCH 2/5] accel/ivpu: Do not use irqsave in ivpu_ipc_dispatch

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka ivpu_ipc_dispatch is always called with irqs disabled. Add lockdep assertion and remove unneeded _irqsave/_irqrestore. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/5] accel/ivpu: Rename cons->rx_msg_lock

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka Now the cons->rx_msg_lock protects also 'abort' field so rename the lock. "protects also" -> "also protects" Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-11-13 Thread Jagan Teki
On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson wrote: > > Hi Jagan > > My apologies for dropping the ball on this one, and thanks to Frieder > for the nudge. > > On Wed, 12 Apr 2023 at 07:25, Jagan Teki wrote: > > > > Hi Dave, > > > > Added Maxime, Laurent [which I thought I added before] > > >

Incomplete stable drm/ast backport - screen freeze on boot

2023-11-13 Thread Keno Fischer
Greetings, When connected to a remote machine via the BMC KVM functionality, I am experiencing screen freezes on boot when using 6.5 stable, but not master. The BMC on the machine in question is an ASpeed AST2600. A quick bisect shows the problematic commit to be 2fb9667 ("drm/ast: report

Re: [PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
On 11/14/23 00:43, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer. To get a normal (non

[PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer. To get a normal (non __rcu tagged pointer) from a __rcu tagged

Re: [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
On 11/13/23 19:55, Abhinav Singh wrote: On 11/14/23 00:19, Danilo Krummrich wrote: Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are

Re: [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
On 11/14/23 00:19, Danilo Krummrich wrote: Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly.

Re: [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. Better use imperative here, e.g. "Fix a sparse

[PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer, rather we should be using rcu helper function rcu_dereferece()

[PATCH v2] drivers: gpu: Fixing warning directly dereferencing a rcu pointer v2

2023-11-13 Thread Abhinav Singh
This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer, rather we should be using rcu helper function rcu_dereferece()

Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 18:50, Harry Wentland wrote: > Please just use "drm/amd/display:" as tag in the commit subject. > Thanks, noted. Tags have been automatically created by Coccinelle's splitpatch. > With that fixed, this is > Acked-by: Harry Wentland > > Harry > > On 2023-11-13 06:23, Heiner

RE: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-11-13 Thread Kim, Dongwon
Hi Dmitry, > -Original Message- > From: Dmitry Osipenko > Sent: Monday, November 13, 2023 8:16 AM > To: Kim, Dongwon ; dri- > de...@lists.freedesktop.org > Cc: kra...@redhat.com; Kasireddy, Vivek > Subject: Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update > > On

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 18:49, Wolfram Sang wrote: > >> Preferably this series should be applied via the i2c tree. > > Are we in a hurry here, i.e. does it block further development of the > i801 smbus driver? My gut feeling says the patches should rather go via > drm and fbdev trees, but I may be

Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 18:50, Jani Nikula wrote: > On Mon, 13 Nov 2023, Heiner Kallweit wrote: >> On 13.11.2023 13:17, Jani Nikula wrote: >>> On Mon, 13 Nov 2023, Heiner Kallweit wrote: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-13 Thread Teres Alexis, Alan Previn
On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote: > > > On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote: alan:snip > > > It is not possible to wait for lost G2H in

Re: [PATCH v2] Remove custom dumb_map_offset implementations in i915 driver

2023-11-13 Thread Jani Nikula
On Sat, 11 Nov 2023, Dipam Turkar wrote: > Making i915 use drm_gem_create_mmap_offset() instead of its custom > implementations for associating GEM object with a fake offset. It would probably help a lot if your commit messages explained what you are trying to achieve and, especially, why. This

Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Jani Nikula
On Mon, 13 Nov 2023, Heiner Kallweit wrote: > On 13.11.2023 13:17, Jani Nikula wrote: >> On Mon, 13 Nov 2023, Heiner Kallweit wrote: >>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >>>

Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-13 Thread Harry Wentland
Please just use "drm/amd/display:" as tag in the commit subject. With that fixed, this is Acked-by: Harry Wentland Harry On 2023-11-13 06:23, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> Preferably this series should be applied via the i2c tree. Are we in a hurry here, i.e. does it block further development of the i801 smbus driver? My gut feeling says the patches should rather go via drm and fbdev trees, but I may be convinced otherwise. signature.asc Description: PGP

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Fix LUT rounding

2023-11-13 Thread Jani Nikula
On Fri, 13 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The current LUT rounding is generating weird results. Adjust > it to follow the OpenGL int<->float conversion rules. Reviewed-by: Jani Nikula > > Ville Syrjälä (4): > drm: Fix color LUT rounding > drm/i915: Adjust LUT

[Bug 218141] fb: trapped write at 0000006000 on channel -1 [3fed0000 unknown] engine 06 [BAR] client 04 [PFIFO_WRITE] subclient 00 [FB] reason 00000002 [PAGE_NOT_PRESENT]

2023-11-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218141 --- Comment #1 from sander44 (ionut_n2...@yahoo.com) --- Created attachment 305402 --> https://bugzilla.kernel.org/attachment.cgi?id=305402=edit dmesg nouveau -- You may reply to this email to add a comment. You are receiving this mail

[Bug 218141] fb: trapped write at 0000006000 on channel -1 [3fed0000 unknown] engine 06 [BAR] client 04 [PFIFO_WRITE] subclient 00 [FB] reason 00000002 [PAGE_NOT_PRESENT]

2023-11-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218141 sander44 (ionut_n2...@yahoo.com) changed: What|Removed |Added Kernel Version||6.6.1 -- You may

[Bug 218141] New: fb: trapped write at 0000006000 on channel -1 [3fed0000 unknown] engine 06 [BAR] client 04 [PFIFO_WRITE] subclient 00 [FB] reason 00000002 [PAGE_NOT_PRESENT]

2023-11-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218141 Bug ID: 218141 Summary: fb: trapped write at 006000 on channel -1 [3fed unknown] engine 06 [BAR] client 04 [PFIFO_WRITE] subclient 00 [FB] reason 0002

Re: [PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
On 11/13/23 09:24, Maarten Lankhorst wrote: Hey, Den 2023-11-13 kl. 09:10, skrev Abhinav Singh: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be

Re: [PATCH v3 2/2] drm/uapi: add explicit virtgpu context debug name

2023-11-13 Thread Gurchetan Singh
On Sat, Nov 11, 2023 at 2:37 PM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > On 10/18/23 21:17, Gurchetan Singh wrote: > > + case VIRTGPU_CONTEXT_PARAM_DEBUG_NAME: > > + if (vfpriv->explicit_debug_name) { > > + ret =

[PATCH 4/5] accel/ivpu: Use dedicated work for job timeout detection

2023-11-13 Thread Jacek Lawrynowicz
From: Stanislaw Gruszka Change to use work for timeout detection. Needed for thread_irq conversion. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_job.c | 24 +--- drivers/accel/ivpu/ivpu_pm.c | 31

[PATCH 5/5] accel/ivpu: Use threaded IRQ to handle JOB done messages

2023-11-13 Thread Jacek Lawrynowicz
Remove job_done thread and replace it with generic callback based mechanism. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 30 +++-- drivers/accel/ivpu/ivpu_drv.h | 3 +- drivers/accel/ivpu/ivpu_hw_37xx.c | 29 +++-- drivers/accel/ivpu/ivpu_hw_40xx.c | 30

[PATCH 3/5] accel/ivpu: Do not use cons->aborted for job_done_thread

2023-11-13 Thread Jacek Lawrynowicz
From: Stanislaw Gruszka This allow to simplify ivpu_ipc_receive() as now we do not have to process all messages in aborted state - they will be freed in ivpu_ipc_consumer_del(). Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_ipc.c | 18

[PATCH 2/5] accel/ivpu: Do not use irqsave in ivpu_ipc_dispatch

2023-11-13 Thread Jacek Lawrynowicz
From: Stanislaw Gruszka ivpu_ipc_dispatch is always called with irqs disabled. Add lockdep assertion and remove unneeded _irqsave/_irqrestore. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_ipc.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 1/5] accel/ivpu: Rename cons->rx_msg_lock

2023-11-13 Thread Jacek Lawrynowicz
From: Stanislaw Gruszka Now the cons->rx_msg_lock protects also 'abort' field so rename the lock. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_ipc.c | 27 +-- drivers/accel/ivpu/ivpu_ipc.h | 2 +- 2 files changed, 14

[PATCH v2 0/5] accel/ivpu: Replace IPC kthread with threaded IRQ

2023-11-13 Thread Jacek Lawrynowicz
Use threaded IRQ to handle incoming IPC messages. IPC consumers can now provide optional callback that will be executed once message is received. This allows to handle multiple message types in a generic manner. Removing kthread also simplifies synchronization as disable_irq() will block until

Re: [PATCH v1] drm/virtio: Fix return value for VIRTGPU_CONTEXT_PARAM_DEBUG_NAME

2023-11-13 Thread Gurchetan Singh
On Sat, Nov 11, 2023 at 2:43 PM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > The strncpy_from_user() returns number of copied bytes and not zero on > success. The non-zero return value of ioctl is treated as error. Return > zero on success instead of the number of copied bytes. > >

[PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-13 Thread Michael Walle
The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 mode. It seems the bridge internally queues DSI packets and when the FORCE_STOP_STATE bit is cleared, they are sent in close succession without any useful timing (this also means that the DSI lanes won't go into LP-11 mode).

Re: Incomplete stable drm/ast backport - screen freeze on boot

2023-11-13 Thread Sasha Levin
On Mon, Nov 13, 2023 at 10:49:01AM +0100, Thomas Zimmermann wrote: (cc: gregkh) Hi Jocelyn Am 13.11.23 um 10:36 schrieb Jocelyn Falempe: On 13/11/2023 09:34, Keno Fischer wrote: Greetings, When connected to a remote machine via the BMC KVM functionality, I am experiencing screen freezes on

Re: [Patch v3] drm/ttm: Schedule delayed_delete worker closer

2023-11-13 Thread Christian König
Am 11.11.23 um 14:08 schrieb Rajneesh Bhardwaj: Try to allocate system memory on the NUMA node the device is closest to and try to run delayed_delete workers on a CPU of this node as well. To optimize the memory clearing operation when a TTM BO gets freed by the delayed_delete worker,

Re: [PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Aurabindo Pillai
On 11/13/2023 9:56 AM, Hamza Mahfooz wrote: For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace

Re: [RFC PATCH v2 1/1] drm/virtio: new fence for every plane update

2023-11-13 Thread Dmitry Osipenko
On 10/23/23 20:31, Kim, Dongwon wrote: ... >> Please write a guide how to test it. Are you using spice for the >> multi-display >> viewer? > > [DW] Yeah, let me come up with a simple test case. So we use virtio-gpu as > KMS device. It is used to share the guest frame with QEMU. > SPICE is one

Re: [PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Christian König
Am 13.11.23 um 15:56 schrieb Hamza Mahfooz: For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask

Re: [PATCH v2] drm/loongson: Add platform dependency

2023-11-13 Thread Sui Jingfeng
Hi, thanks for the patch. On 2023/11/13 19:55, Jean Delvare wrote: Only offer the Loongson DRM driver as an option on platforms where it makes sense. Signed-off-by: Jean Delvare Reviewed-by: Sui Jingfeng Cc: Sui Jingfeng Cc: David Airlie Cc: Daniel Vetter --- Changes since v1: *

Re: [PATCH 00/10] drm/ast: Detect device type before init

2023-11-13 Thread Jocelyn Falempe
On 13/11/2023 09:50, Thomas Zimmermann wrote: Detecting the ast device's chipset type and configuration mode involves several registers, DT properties and possibly POSTing parts of the chip. It is preferable to do this before initializing the DRM driver, so that that each chip type can have an

RE: [PATCH v2 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-11-13 Thread Flavio Suligoi
Hi Daniel, > On Wed, Oct 25, 2023 at 05:50:57PM +0200, Flavio Suligoi wrote: > > NOTE: there are no compatibility problems with the previous version, > > since the device driver has not yet been included in any kernel. > > Only this dt-binding yaml file is already included in the > >

Re: [PATCH 09/10] drm/ast: Detect ast device type and config mode without ast device

2023-11-13 Thread Jocelyn Falempe
On 13/11/2023 09:50, Thomas Zimmermann wrote: Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 104 ++--- 1

[PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Hamza Mahfooz
For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask dynamically at runtime and document how to use

Re: [PATCH v2 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-11-13 Thread Daniel Thompson
On Wed, Oct 25, 2023 at 05:50:57PM +0200, Flavio Suligoi wrote: > NOTE: there are no compatibility problems with the previous version, > since the device driver has not yet been included in any kernel. > Only this dt-binding yaml file is already included in the >

Re: [RFC][PATCH v5 0/6] drm/panic: Add a drm panic handler

2023-11-13 Thread nerdopolis
On Friday, November 3, 2023 10:53:24 AM EST Jocelyn Falempe wrote: > This introduces a new drm panic handler, which displays a message when a > panic occurs. > So when fbcon is disabled, you can still see a kernel panic. > > This is one of the missing feature, when disabling VT/fbcon in the

Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: > When number of clock varies between variants, the Devicetree bindings > coding convention expects to have widest constraints in top-level > definition of the properties and narrow them in allOf:if:then block. > > This is more

Re: [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:00PM +0100, Krzysztof Kozlowski wrote: > The Devicetree bindings coding convention, as used in most of the files > and expressed in Documentation/devicetree/bindings/example-schema.yaml, > expects "allOf:" block with if-statements after "required:" block. > >

Re: [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:02PM +0100, Krzysztof Kozlowski wrote: > Provide specific constraints for iommus and power-domains, based on > current DTS. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:03PM +0100, Krzysztof Kozlowski wrote: > Provide specific constraints for iommus and power-domains, based on > current DTS. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Cheers… Conor. > --- > .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 + > 1 file

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-13 Thread Dmitry Baryshkov
On Mon, 13 Nov 2023 at 14:11, Keith Zhao wrote: > > > > On 2023/10/26 6:23, Dmitry Baryshkov wrote: > > On 25/10/2023 13:39, Keith Zhao wrote: > >> add hdmi driver as encoder and connect > >> > >> Signed-off-by: Keith Zhao > >> --- > >> drivers/gpu/drm/verisilicon/Kconfig | 8 +- > >>

Re: [PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-13 Thread Christian König
Am 13.11.23 um 14:14 schrieb Danilo Krummrich: Hi Christian, On 11/13/23 13:38, Christian König wrote: Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Thanks a

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Andrew Worsley
On Mon, 13 Nov 2023 at 23:57, Javier Martinez Canillas wrote: > > Andrew Worsley writes: > > Hello Andrew, > > > On Mon, 13 Nov 2023 at 20:18, Thomas Zimmermann wrote: > >> Am 13.11.23 um 09:51 schrieb Javier Martinez Canillas: > >> > Some DT platforms use EFI to boot and in this case the EFI

Re: [PATCH 2/2] drm/virtio: Modify RESOURCE_GET_LAYOUT ioctl

2023-11-13 Thread Dmitry Osipenko
On 11/10/23 10:16, Julia Zhang wrote: > Modify RESOURCE_GET_LAYOUT ioctl to handle the use case that query > correct stride for guest linear resource before it is created. > > Signed-off-by: Julia Zhang > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 26 -- >

Re: [PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-13 Thread Danilo Krummrich
Hi Christian, On 11/13/23 13:38, Christian König wrote: Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Thanks a lot for submitting this - it's very much

  1   2   >