Re: [PATCH v4 0/4] drm/dp: Introduce wait_hpd_asserted() for the DP AUX bus

2022-06-21 Thread Doug Anderson
Hi, On Tue, Jun 14, 2022 at 2:54 PM Douglas Anderson wrote: > > This is the 2nd four patches from my RFC series ("drm/dp: Improvements > for DP AUX channel") [1]. I've broken the series in two so we can make > progress on the two halves separately. > > v2 of this series changes to add

[PATCH v15 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-06-21 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 43 --- 1 file changed, 33 insertions(+), 10

[PATCH v15 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-06-21 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov

Re: [PATCH] drm/aperture: Run fbdev removal before internal helpers

2022-06-21 Thread Alex Williamson
On Tue, 21 Jun 2022 13:01:08 +0200 Thomas Zimmermann wrote: > Hi > > Am 17.06.22 um 16:12 schrieb Alex Williamson: > > On Fri, 17 Jun 2022 14:41:01 +0200 > > Thomas Zimmermann wrote: > > > >> Hi > >> > >> Am 17.06.22 um 14:29 schrieb Javier Martinez Canillas: > >>> [adding Zack and Alex

Re: [v3 1/5] drm/msm/dp: Add basic PSR support for eDP

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 13:53, Vinod Polimera wrote: Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod

Re: [v3 2/5] drm/bridge: use atomic enable/disable callbacks for panel bridge functions

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 13:53, Vinod Polimera wrote: Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

Re: [RFT][PATCH v1 1/6] vfio/ap: Pass in physical address of ind to ap_aqic()

2022-06-21 Thread Nicolin Chen
On Mon, Jun 20, 2022 at 12:00:53PM +0200, Harald Freudenberger wrote: > External email: Use caution opening links or attachments > > > On 2022-06-17 01:52, Nicolin Chen wrote: > > The ap_aqic() is called by vfio_ap_irq_enable() where it passes in a > > virt value that's casted from a physical

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
Actually I hate to ask but could you resend this and the other patch that you sent and make sure that dri-devel@ is explicitly in the to: list? For some reason these patches don't seem to be coming up on patchwork On Tue, 2022-06-21 at 13:54 -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul >

Re: [v3 2/5] drm/bridge: use atomic enable/disable callbacks for panel bridge functions

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 21:54, Dmitry Baryshkov wrote: On 21/06/2022 13:53, Vinod Polimera wrote: Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Vinod Polimera Reviewed-by: Dmitry

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-21 Thread Andrey Grodzovsky
On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In amdgpu_job_submit_direct - The refcount should drop by 2 but it drops only by 1. amdgpu_ib_sched->emit -> refcount 1 from first fence init dma_fence_get -> refcount 2 dme_fence_put ->

[linux-next:master] BUILD REGRESSION 34d1d36073ea4d4c532e8c8345627a9702be799e

2022-06-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 34d1d36073ea4d4c532e8c8345627a9702be799e Add linux-next specific files for 20220621 Error/Warning reports: https://lore.kernel.org/linux-mm/202206212029.yr5m7cd3-...@intel.com https

Re: [PATCH] drm/msm: Use div64_ul instead of do_div

2022-06-21 Thread Abhinav Kumar
On 4/26/2022 6:21 AM, Wan Jiabing wrote: Fix following coccicheck warning: drivers/gpu/drm/msm/msm_gpu_devfreq.c:72:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. Use div64_ul instead of do_div to avoid a possible truncation. Signed-off-by: Wan

Re: [PATCH v4 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

2022-06-21 Thread José Expósito
Hi David, On Tue, Jun 21, 2022 at 05:38:33PM +0800, David Gow wrote: > On Tue, Jun 21, 2022 at 12:06 AM José Expósito > wrote: > > > > Test the conversion from XRGB to RGB332. > > > > What is tested? > > > > - Different values for the X in XRGB to make sure it is ignored > > -

Re: [v3 5/5] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 13:53, Vinod Polimera wrote: Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera ---

Re: [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

2022-06-21 Thread kernel test robot
Hi Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-21 Thread Jon Hunter
kernel paging request at virtual address c216c810 [2.097060] [c216c810] *pgd=0201141e(bad) [2.097079] Internal error: Oops: 800d [#1] SMP ARM [2.097088] Modules linked in: [2.097097] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.19.0-rc3-next-20220621-g34d1d36073ea #1 [2.097107]

Re: [PATCH] drm/nouveau/Kconfig: Drop duplicate "select ACPI_VIDEO"

2022-06-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Also, you have my permission to push this to drm-misc-next. On Mon, 2022-06-20 at 11:46 +0200, Hans de Goede wrote: > Before this change nouveau's Kconfig section had 2 "select ACPI_VIDEO" > statements: > > select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE &&

Re: [PATCH v2 08/12] drm/i915/uapi: tweak error capture on recoverable contexts

2022-06-21 Thread kernel test robot
Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-21 Thread David Hildenbrand
On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/21/2022 7:25 AM, David Hildenbrand wrote: >> On 21.06.22 13:55, Alistair Popple wrote: >>> David Hildenbrand writes: >>> On 21.06.22 13:25, Felix Kuehling wrote: > Am 6/17/22 um 23:19 schrieb David Hildenbrand: >> On

Re: [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Lionel Landwerlin
On 21/06/2022 13:44, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture.

Re: [v3 0/5] Add PSR support for eDP

2022-06-21 Thread Dmitry Baryshkov
Please fix your mailer. You've got the following headers, which clearly confuse the threading: In-Reply-To: References: Also the y...@qualcomm.com address (present in To:) rejects incoming mail. On 21/06/2022 13:53, Vinod Polimera wrote: Changes in v2: - Use dp bridge to set psr

[PATCH v8 07/10] drm/i915: ttm move/clear logic fix

2022-06-21 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[PATCH v8 06/10] drm/i915: sanitize mem_flags for stolen buffers

2022-06-21 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by:

[PATCH v8 09/10] drm/i915/ttm: add buffer pin on alloc flag

2022-06-21 Thread Robert Beckett
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback

[PATCH v8 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-06-21 Thread Robert Beckett
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour.

[PATCH v8 05/10] drm/i915: instantiate ttm ranger manager for stolen memory

2022-06-21 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31

[PATCH v8 08/10] drm/i915: allow memory region creators to alloc and free the region

2022-06-21 Thread Robert Beckett
add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15

[PATCH v8 00/10] drm/i915: ttm for stolen

2022-06-21 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2

[PATCH v8 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-06-21 Thread Robert Beckett
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-21 Thread Andrey Grodzovsky
On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align refcount behaviour for amdgpu_job embedded HW fence with classic pointer style HW fences by increasing refcount each time emit is called so amdgpu code doesn't need to make workarounds using

[PATCH v8 02/10] drm/i915: limit ttm to dma32 for i965G[M]

2022-06-21 Thread Robert Beckett
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c

[PATCH v8 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

2022-06-21 Thread Robert Beckett
During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-21 Thread Nicolin Chen
On Sun, Jun 19, 2022 at 11:32:07PM -0700, Christoph Hellwig wrote: > On Sun, Jun 19, 2022 at 11:57:26PM -0300, Jason Gunthorpe wrote: > > The remark about io memory is because on s390 memcpy() will crash even > > on ioremapped memory, you have to use the memcpy_to/fromio() which > > uses the

Re: DMA-buf and uncached system memory

2022-06-21 Thread Nicolas Dufresne
Hi Christian and Andy, Le mardi 21 juin 2022 à 12:34 +0200, Christian König a écrit : >  Hi Andy, >   >  Am 21.06.22 um 12:17 schrieb Andy.Hsieh: >   > > On 2/16/21 4:39 AM, Nicolas Dufresne wrote: > > > Le lundi 15 février 2021 à 09:58 +0100, Christian König a écrit : > > > > Hi guys, > > > > >

[PATCH v15 0/3] eDP/DP Phy vdda realted function

2022-06-21 Thread Kuogee Hsieh
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy:

Re: [PATCH v15 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-06-21 Thread Dmitry Baryshkov
On Tue, 21 Jun 2022 at 20:02, Kuogee Hsieh wrote: > > This patch add regulator_set_load() before enable regulator at > DP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov > --- >

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
Yeah I'm not totally sure what's going on here, I wouldn't worry about it too much. I will just push the patches manually On Wed, 2022-06-22 at 03:01 +0800, 蒋健 wrote: > I got the list as follow: >  ~/linux-kernel/linux-next  on master ⇡1  ./scripts/get_maintainer.pl >

Re: [PATCH 3/5] drm/amdgpu: Prevent race between late signaled fences and GPU reset.

2022-06-21 Thread Andrey Grodzovsky
On 2022-06-21 03:25, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Problem: After we start handling timed out jobs we assume there fences won't be signaled but we cannot be sure and sometimes they fire late. We need to prevent concurrent accesses to fence array from

[PATCH v8 10/10] drm/i915: stolen memory use ttm backend

2022-06-21 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

Re: [PATCH] drm/nouveau/mmu: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a moment On Tue, 2022-06-21 at 21:39 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > line: 1051 >  * have the the

Re: [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-21 Thread Dmitry Osipenko
20.06.2022 18:37, Rob Clark пишет: >> +static unsigned long >> +drm_gem_shmem_shrinker_scan_objects(struct shrinker *shrinker, >> + struct shrink_control *sc) >> +{ >> + unsigned long nr_to_scan = sc->nr_to_scan; >> + bool lock_contention = false; >> +

[PATCH v15 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-21 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH v3 1/4] drm/msm/dpu: Move LM CRC code into separate method

2022-06-21 Thread Jessica Zhang
On 6/20/2022 11:42 PM, Dmitry Baryshkov wrote: On Tue, 21 Jun 2022 at 03:50, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods.

Re: [Freedreno] [PATCH v3 4/4] drm/msm/dpu: Add interface support for CRC debugfs

2022-06-21 Thread Jessica Zhang
On 6/20/2022 11:36 PM, Dmitry Baryshkov wrote: On Tue, 21 Jun 2022 at 03:50, Jessica Zhang wrote: Add support for writing CRC values for the interface block to the debugfs by calling the necessary MISR setup/collect methods. Changes since V1: - Set values_cnt to only include phys with

Re: [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Jordan Justen
On 2022-06-21 11:31:39, Lionel Landwerlin wrote: > On 21/06/2022 13:44, Matthew Auld wrote: > > Add an entry for the new uapi needed for small BAR on DG2+. > > > > v2: > >- Some spelling fixes and other small tweaks. (Akeem & Thomas) > >- Rework error capture interactions, including no

Re: [PATCH 3/3] drm/dp_mst: Get rid of old comment in drm_atomic_get_mst_topology_state docs

2022-06-21 Thread Lyude Paul
Thanks! Will push these two patches upstream On Mon, 2022-06-13 at 09:59 +, Lin, Wayne wrote: > [Public] > > Hi Lyude, > > Feel free to add > Reviewed-by: Wayne Lin > > > -Original Message- > > From: Lyude Paul > > Sent: Friday, June 3, 2022 4:18 AM > > To:

[PATCH v2 9/9] drm: selftest: convert drm_mm selftest to KUnit

2022-06-21 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- Documentation/gpu/todo.rst| 11 - drivers/gpu/drm/Kconfig

[PATCH v2 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 -

[PATCH v2 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM plane helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Djakson C. G. Filho Signed-off-by: Djakson C. G. Filho Co-developed-by: Anderson Fraga Signed-off-by: Anderson Fraga Signed-off-by: Maíra

[PATCH v2 6/9] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +-

[PATCH v2 8/9] drm: selftest: convert drm_buddy selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_buddy_selftests.h | 15 -

[PATCH v2 7/9] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu/drm/selftests/drm_modeset_selftests.h | 9 --

Re: [PATCH] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC

2022-06-21 Thread Liu Ying
On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote: > The various Freescale i.MX8MP display bridges are only present on > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > asking the user about these drivers when configuring a kernel without > i.MX SoC support.

Re: [PATCH v7 0/8] Add a panel API to set orientation properly

2022-06-21 Thread Doug Anderson
Hi, On Wed, Jun 15, 2022 at 6:36 AM Doug Anderson wrote: > > Hi, > > On Tue, Jun 14, 2022 at 10:50 PM Hsin-Yi Wang wrote: > > > > On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang wrote: > > > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > > later than drm/kms driver

[PATCH v2 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig | 19 +

[PATCH v2 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile|2 +-

[PATCH v2 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Carlos Veras Signed-off-by: Carlos Veras Co-developed-by: Matheus Vieira Signed-off-by: Matheus Vieira Signed-off-by: Maíra Canal ---

[PATCH v2 0/9] drm: selftest: Convert to KUnit

2022-06-21 Thread Maíra Canal
Hi everyone, Here is the v2 of the conversion of DRM selftests to KUnit. Some style changes were made to align to the drm_format_helper series [1] and the documentation [2], as renaming the kunit_suite and the test cases to use underscores as suggested, changing the filenames and using a generic

Re: [RFT][PATCH v1 6/6] vfio: Replace phys_pfn with phys_page for vfio_pin_pages()

2022-06-21 Thread Nicolin Chen
On Mon, Jun 20, 2022 at 12:36:28PM -0300, Jason Gunthorpe wrote: > On Sun, Jun 19, 2022 at 11:37:47PM -0700, Christoph Hellwig wrote: > > On Sun, Jun 19, 2022 at 10:51:47PM -0700, Christoph Hellwig wrote: > > > On Mon, Jun 20, 2022 at 12:00:46AM -0300, Jason Gunthorpe wrote: > > > > On Fri, Jun

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-21 Thread Sierra Guiza, Alejandro (Alex)
On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple wrote: David Hildenbrand writes: On 21.06.22 13:25, Felix Kuehling wrote: Am 6/17/22 um 23:19 schrieb David Hildenbrand: On 17.06.22 21:27, Sierra Guiza, Alejandro (Alex) wrote: On 6/17/2022 12:33 PM,

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
You can send it by adding email addresses to git send-email with the "--to f...@bar.net" argument. If it doesn't come up on patchwork the second try don't worry about it, I'll look and see if I can workaround it. TBH I'm not entirely sure why it didn't show up in the first place On Wed,

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

2022-06-21 Thread Uwe Kleine-König
[2.097053] Unable to handle kernel paging request at virtual address > c216c810 > [2.097060] [c216c810] *pgd=0201141e(bad) > [2.097079] Internal error: Oops: 800d [#1] SMP ARM > [2.097088] Modules linked in: > [2.097097] CPU: 1 PID: 1 Comm: swapper/0 Not

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a moment On Tue, 2022-06-21 at 21:14 +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/display/drm_dp_helper.c > line: 1600 >   * Doesn't account the the

Re: [PATCH v4 3/3] drm/doc: Add KUnit documentation

2022-06-21 Thread José Expósito
Hi David, On Tue, Jun 21, 2022 at 05:38:38PM +0800, David Gow wrote: > On Tue, Jun 21, 2022 at 12:06 AM José Expósito > wrote: > > > > Explain how to run the KUnit tests present in the DRM subsystem and > > clarify why the UML-only options were not added to the configuration > > file present in

Re: [v3 4/5] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 13:53, Vinod Polimera wrote: Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov ---

Re: [v3 3/5] drm/bridge: add psr support during panel bridge enable & disable sequence

2022-06-21 Thread Dmitry Baryshkov
On 21/06/2022 13:53, Vinod Polimera wrote: This change avoids panel prepare/unprepare based on self-refresh state. Signed-off-by: Sankeerth Billakanti Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 102

Re: [PATCH v4 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-06-21 Thread Prashant Malani
On Thu, Jun 16, 2022 at 12:57 PM Prashant Malani wrote: > > On Thu, Jun 16, 2022 at 12:34 PM Rob Herring wrote: > > > > On Thu, Jun 16, 2022 at 01:54:36AM -0700, Prashant Malani wrote: > > > On Thu, Jun 16, 2022 at 12:42 AM Stephen Boyd wrote: > > > > > > > > Quoting Prashant Malani (2022-06-15

[PATCH] drm/i915/guc: ADL-N should use the same GuC FW as ADL-S

2022-06-21 Thread Daniele Ceraolo Spurio
The only difference between the ADL S and P GuC FWs is the HWConfig support. ADL-N does not support HWConfig, so we should use the same binary as ADL-S, otherwise the GuC might attempt to fetch a config table that does not exist. ADL-N is internally identified as an ADL-P, so we need to

Re: [Intel-gfx] [PATCH] drm/i915/guc: ADL-N should use the same GuC FW as ADL-S

2022-06-21 Thread Ceraolo Spurio, Daniele
On 6/21/2022 5:34 PM, Matt Roper wrote: On Tue, Jun 21, 2022 at 04:30:05PM -0700, Daniele Ceraolo Spurio wrote: The only difference between the ADL S and P GuC FWs is the HWConfig support. ADL-N does not support HWConfig, so we should use the same binary as ADL-S, otherwise the GuC might

Re: [RFT][PATCH v1 3/6] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-06-21 Thread Nicolin Chen
On Fri, Jun 17, 2022 at 01:42:42AM -0700, Christoph Hellwig wrote: > On Thu, Jun 16, 2022 at 04:52:09PM -0700, Nicolin Chen wrote: > > + ret = vfio_unpin_pages(>vfio_device, gfn << PAGE_SHIFT, npage); > > + drm_WARN_ON(>drm, ret != npage); > > The shifting of gfn seems to happen bother here

Re: [kbuild-all] Re: [PATCH v2 1/1] drm/panfrost: Add support for devcoredump

2022-06-21 Thread Chen, Rong A
On 6/21/2022 10:32 PM, Alyssa Rosenzweig wrote: drivers/gpu/drm/panfrost/panfrost_dump.c: In function 'panfrost_core_dump': drivers/gpu/drm/panfrost/panfrost_dump.c:115:20: error: 'struct panfrost_job' has no member named 'file_priv' 115 | as_nr = job->file_priv->mmu->as;

Re: [PATCH 3/5] drm/amdgpu: Prevent race between late signaled fences and GPU reset.

2022-06-21 Thread Andrey Grodzovsky
You have a job in the pending list which is marked as not finished in drm_sched_stop (https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/scheduler/sched_main.c#L420), s_fence signal cb removed and the job is kept in pending list. Later you will try to manually clear the HW fence of

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-21 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 16:07:58) > On 17/06/2022 23:47, Stephen Boyd wrote: > > This struct member is stored to in the function that calls the function > > which uses it. That's possible with a function argument instead of > > storing to a struct member. Pass the pixel_rate as an

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-21 Thread Alistair Popple
David Hildenbrand writes: > On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: >> >> On 6/21/2022 7:25 AM, David Hildenbrand wrote: >>> On 21.06.22 13:55, Alistair Popple wrote: David Hildenbrand writes: > On 21.06.22 13:25, Felix Kuehling wrote: >> Am 6/17/22 um 23:19

Re: [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-21 Thread Dixit, Ashutosh
On Sat, 14 May 2022 23:05:06 -0700, Vinay Belgaumkar wrote: > > SLPC min/max frequency updates require H2G calls. We are seeing > timeouts when GuC channel is backed up and it is unable to respond > in a timely fashion causing warnings and affecting CI. > > This is seen when waitboosting happens

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-21 Thread Guenter Roeck
On Mon, Jun 20, 2022 at 05:51:04PM -0400, Alex Deucher wrote: > On Sat, Jun 18, 2022 at 7:27 PM Guenter Roeck wrote: > > > > ppc:allmodconfig builds fail with the following error. > > > > powerpc64-linux-ld: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o > >

Re: Exynos vblank timeout issue

2022-06-21 Thread Inki Dae
Hi Martin, 2022년 6월 4일 (토) 오후 8:05, Martin Jücker 님이 작성: > > On Sat, Jun 04, 2022 at 01:05:39PM +0900, Inki Dae wrote: > > Hi Martin, > > > > Hi Inki, > > > What kind of panel does Galaxy Note 10.1 use? I guess it uses I80 > > panel which needs CPU-trigger. > > the Note 10.1 uses a Samsung

[PATCH] drm/panel: nt35510: Remove duplicate 'the' in two places.

2022-06-21 Thread Jiang Jian
file: ./drivers/gpu/drm/panel/panel-novatek-nt35510.c line: 193,214,253 * amplification for the the step-up circuit: changed to * amplification for the step-up circuit: Signed-off-by: Jiang Jian --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] GPU: drm: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/drm_ioctl.c line: 86 *means the the unique name for the master node just opening is _not_ filled changed to *means the unique name for the master node just opening is _not_ filled

[PATCH] drm/nouveau/mmu: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c line: 1051 * have the the deepest nesting of page tables. changed to * have the deepest nesting of page tables. Signed-off-by: Jiang Jian ---

[PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/display/drm_dp_helper.c line: 1600 * Doesn't account the the "MOT" bit, and instead assumes each changed to * Doesn't account the "MOT" bit, and instead assumes each Signed-off-by: Jiang Jian ---

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread ????
Okay,I will submit a new patch immediately. --Reply to Message-- On Wed,Jun 22,2022 2:41 AM Lyude Paul

[PATCH] drm/display: Remove duplicate 'the' in two places.

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/display/drm_dp_helper.c line: 1600 * Doesn't account the the "MOT" bit, and instead assumes each changed to * Doesn't account the "MOT" bit, and instead assumes eac Signed-off-by: Jiang Jian ---

[PATCH v2] drm/nouveau/mmu: Fix a typo

2022-06-21 Thread Zhang Jiaming
There is a typo in comments. Change 'neeed' to 'needed'. Signed-off-by: Zhang Jiaming --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c

[PATCH] video: fbdev: omap: Remove duplicate 'the' in two places.

2022-06-21 Thread Jiang Jian
file: drivers/video/fbdev/omap/sossi.c line: 362 * We set explicitly the the bus_pick_count as well, although changed to * We set explicitly the bus_pick_count as well, although Signed-off-by: Jiang Jian --- drivers/video/fbdev/omap/sossi.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/vc4: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/vc4/vc4_regs.h line: 267 /* Set when the the downstream tries to read from the display FIFO changed to /* Set when the downstream tries to read from the display FIFO Signed-off-by: Jiang Jian ---

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread ????
I need resubmit a new patch, how can i make sure dri-devel@ is explicitly??I got to:list by the script name of get_maintainer.pl. Pls help me?? --Reply to Message-- On Wed,Jun 22,2022 2:07 AM Lyude Paul

[PATCH] drm/prime: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/drm_prime.c line: 842 * of the the buffer described by the provided sg_table. changed to * of the buffer described by the provided sg_table. Signed-off-by: Jiang Jian --- drivers/gpu/drm/drm_prime.c

[PATCH] drm/nouveau/mmu: Fix a typo

2022-06-21 Thread Zhang Jiaming
There is a typo in comments. Change 'neeed' to 'need'. Signed-off-by: Zhang Jiaming --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c

[PATCH] drm/i915: i915_irq - drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/i915/i915_irq.c line 68 * interrupt originated from the the GPU so interrupts from a device which changed to * interrupt originated from the GPU so interrupts from a device which Signed-off-by:

[PATCH] drm/amdgpu: vm - drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c line: 57 * the kernel tells the the ring what VMID to use for that command changed to * the kernel tells the ring what VMID to use for that command Signed-off-by: Jiang Jian

[PATCH] drm: panel-orientation-quirks: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/drm_panel_orientation_quirks.c line: 196 * GPD Pocket, note that the the DMI data is less generic then changed to * GPD Pocket, note that the DMI data is less generic then Signed-off-by: Jiang Jian

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-06-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #17 from Harald Judt (h.j...@gmx.at) --- Yes, this patch set seems to work fine. Reporting two successful hibernate/resume cycles with them applied to 5.18.5. -- You may reply to this email to add a comment. You are receiving this

[PATCH v3 1/1] drm/panfrost: Add support for devcoredump

2022-06-21 Thread Adrián Larumbe
In the event of a job timeout, debug dump information will be written into /sys/class/devcoredump. Inspired by etnaviv's similar feature. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/Kconfig | 1 + drivers/gpu/drm/panfrost/Makefile| 3 +-

[PATCH v3 0/1] devcoredump support for Panfrost GPU driver

2022-06-21 Thread Adrián Larumbe
This is v3 for a previous patch series being discussed at: https://lore.kernel.org/dri-devel/20220621023204.94179-1-adrian.laru...@collabora.com/T/#t Mesa MR under review can be found at: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14034 Changes with respect to v2 of the same

Re: [PATCH v2 1/1] drm/panfrost: Add support for devcoredump

2022-06-21 Thread Adri??n Larumbe
Hi Alyssa, thanks for the feedback. If I don't answer directly to any of your concerns in this message, it's because I applied your suggestions in v3 of the patch straight away. On 21.06.2022 09:03, Alyssa Rosenzweig wrote: > Hi Adrian, > > Great work on the devcoredump support! This is really

Re: [PATCH] drm/display: drop unexpected word "the" in the comments

2022-06-21 Thread 蒋健
I got the list as follow:  ~/linux-kernel/linux-next  on master ⇡1  ./scripts/get_maintainer.pl 0001-drm-display-Remove-duplicate-the-in-two-places.patch David Airlie

[PATCH] video: fbdev: omap: Remove duplicate 'the' in two places.

2022-06-21 Thread Jiang Jian
file: drivers/video/fbdev/omap/sossi.c line: 362 * We set explicitly the the bus_pick_count as well, although changed to * We set explicitly the bus_pick_count as well, although Signed-off-by: Jiang Jian --- drivers/video/fbdev/omap/sossi.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/amd/pm: Fix a typo in comments

2022-06-21 Thread Zhang Jiaming
There is a spelling mistake in comments. Replace 'paramater' with 'parameter'. Signed-off-by: Zhang Jiaming --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/arcturus_ppsmc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/arcturus_ppsmc.h

[PATCH] drm/pl111: drop unexpected word "the" in the comments

2022-06-21 Thread Jiang Jian
there is an unexpected word "the" in the comments that need to be dropped file: drivers/gpu/drm/pl111/pl111_display.c line: 251 * Note that the the ARM hardware's format reader takes 'r' from changed to * Note that the the ARM hardware's format reader takes 'r' from Signed-off-by: Jiang Jian

  1   2   3   >