Re: [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Jani Nikula
On Tue, 17 Apr 2018, Souptick Joarder wrote: > On 17-Apr-2018 9:45 PM, "Matthew Wilcox" wrote: >> >> On Tue, Apr 17, 2018 at 09:14:32PM +0530, Souptick Joarder wrote: >> > Not exactly. The plan for these patches is to introduce new vm_fault_t > type >>

[PATCH 0/2] qxl: two fixes.

2018-04-17 Thread Gerd Hoffmann
Gerd Hoffmann (2): qxl: fix qxl_release_{map,unmap} qxl: keep separate release_bo pointer drivers/gpu/drm/qxl/qxl_drv.h | 1 + drivers/gpu/drm/qxl/qxl_cmd.c | 6 ++ drivers/gpu/drm/qxl/qxl_ioctl.c | 4 ++-- drivers/gpu/drm/qxl/qxl_release.c | 18 +- 4 files

[PATCH 1/2] qxl: fix qxl_release_{map,unmap}

2018-04-17 Thread Gerd Hoffmann
s/PAGE_SIZE/PAGE_MASK/ Luckily release_offset is never larger than PAGE_SIZE, so the bug has no bad side effects and managed to stay unnoticed for years that way ... Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_ioctl.c | 4 ++--

[PATCH 2/2] qxl: keep separate release_bo pointer

2018-04-17 Thread Gerd Hoffmann
qxl expects that list_first_entry(release->bos) returns the first element qxl added to the list. ttm_eu_reserve_buffers() may reorder the list though. Add a release_bo field to struct qxl_release and use that instead. Signed-off-by: Gerd Hoffmann ---

Re: RFC for a render API to support adaptive sync and VRR

2018-04-17 Thread Keith Packard
Michel Dänzer writes: > Time-based presentation seems to be the right approach for preventing > micro-stutter in games as well, Croteam developers have been researching > this. Both the Vulkan GOOGLE_display_timing extension and X11 Present extension offer the ability to

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-17 Thread abhinavk
Adding another point. On 2018-04-17 17:04, abhin...@codeaurora.org wrote: Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-17 Thread abhinavk
Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn Andersson wrote: [..] > If the panel isn't actually a piece of backlight

[Bug 106110] vaapi encoding with gstreamer 1.14 doesn't work

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106110 Christoph Haag changed: What|Removed |Added Resolution|FIXED |NOTOURBUG ---

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 taij...@posteo.de changed: What|Removed |Added Attachment #138374|0 |1 is obsolete|

[Bug 106111] [GPU Passthrough]GPU (Polaris) not reinitialized with Linux VM (Reset bug)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106111 --- Comment #2 from Alex Williamson --- The IOMMU looks to be unhappy first: [ 40.201258] vfio_ecap_init: :0a:00.0 hiding ecap 0x19@0x270 [ 40.201271] vfio_ecap_init: :0a:00.0 hiding ecap 0x1b@0x2d0 [

[PATCH 10/10] drm/msm/gpu: Add the buffer objects from the submit to the crash dump

2018-04-17 Thread Jordan Crouse
For hangs, dump copy out the contents of the buffer objects attached to the guilty submission and print them in the crash dump report. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 7 +++ drivers/gpu/drm/msm/adreno/adreno_gpu.c | 54

[PATCH 09/10] drm/msm/adreno: Add a5xx specific registers for the GPU state

2018-04-17 Thread Jordan Crouse
HLSQ, SP and TP registers are only accessible from a special aperture and to make matters worse the aperture is blocked from the CPU on targets that can support secure rendering. Luckily the GPU hardware has its own purpose built register dumper that can access the registers from the aperture.

[PATCH 04/10] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-04-17 Thread Jordan Crouse
Convert the existing GPU show function to use the GPU state to dump the information rather than reading it directly from the hardware. This will require an additional step to capture the state before dumping it for the existing nodes but it will greatly facilitate reusing the same code for dumping

[PATCH 05/10] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-04-17 Thread Jordan Crouse
Do a bit of cleanup to prepare for upcoming changes to pass the hanging task comm and cmdline to the crash dump function. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH 08/10] drm/msm/adreno: Add ringbuffer data to the GPU state

2018-04-17 Thread Jordan Crouse
Add the contents of each ringbuffer to the GPU state and dump the data in the crash file encoded with ascii85. To save space only the used portions of the ringbuffer are dumped. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 5 +++

[PATCH 07/10] drm/msm/adreno: Convert the show/crash file format

2018-04-17 Thread Jordan Crouse
Convert the format of the 'show' debugfs file and the crash dump to a format resembling YAML. This should be easier to parse and be more flexible for future changes and expansions. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 30

[PATCH 03/10] drm/msm/gpu: Capture the state of the GPU

2018-04-17 Thread Jordan Crouse
Add the infrastructure to capture the state current state of the GPU and store it in memory. This is useful for storing the state of a hung GPU so it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously

[PATCH 06/10] drm/msm/gpu: Capture the GPU state on a GPU hang

2018-04-17 Thread Jordan Crouse
Capture the GPU state on a GPU hang and store it for later playback via the devcoredump facility. Only one crash state is stored at a time on the assumption that the first hang is usually the most interesting. The existing crash state can be cleared after capturing it and then a new one will be

[v5 00/10] drm/msm: A

2018-04-17 Thread Jordan Crouse
This is revision 4 implementing a GPU crash state for drm/msm (https://patchwork.freedesktop.org/series/36097/). This version fixes some identified issues and actually compiles on a modern kernel. The goal is to store and provide enough information to debug software and hardware issues on the

[PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-17 Thread Jordan Crouse
The i915 DRM driver very cleverly used ascii85 encoding for their GPU state file. Move the encode functions to a general header file to support other drivers that might be interested in the same functionality. v3: Fix error_puts -> err_puts pointed out by the 01.org bot v2: Update API to be

[PATCH 02/10] drm: drm_printer: Add printer for devcoredump

2018-04-17 Thread Jordan Crouse
Add a drm printer suitable for use with the read callback for devcoredump or any other file operation read() function that isn't otherwise covered by seq_file. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 54 +

[Bug 106111] [GPU Passthrough]GPU (Polaris) not reinitialized with Linux VM (Reset bug)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106111 --- Comment #1 from Max --- Created attachment 13 --> https://bugs.freedesktop.org/attachment.cgi?id=13=edit dmesg output after to launch the VM a second time -- You are receiving this mail because: You are the

[Bug 106111] [GPU Passthrough]GPU (Polaris) not reinitialized with Linux VM (Reset bug)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106111 Bug ID: 106111 Summary: [GPU Passthrough]GPU (Polaris) not reinitialized with Linux VM (Reset bug) Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

[PATCH] drm/amdgpu: cleanup firmware requests v2

2018-04-17 Thread Andres Rodriguez
Add a new function amdgpu_ucode_request_firmware() that encapsulates a lot of the common behaviour we have around firmware requests. This is the first step in my quest to get rid of the following annoying messages when my polaris10 boots up: [0.558537] amdgpu :01:00.0: Direct firmware

Re: [PATCH v7] drm/vc4: update cursors asynchronously through atomic

2018-04-17 Thread Eric Anholt
Eric Anholt writes: > [ Unknown signature status ] > Boris Brezillon writes: > >> From: Gustavo Padovan >> >> Add support for async updates of cursors by using the new atomic >> interface for that. Basically what this

Re: [PATCH v3 4/4] drm/vc4: Add CTM support

2018-04-17 Thread Eric Anholt
Eric Anholt writes: > [ Unknown signature status ] > Stefan Schake writes: > >> The hardware has a single block for applying a CTM prior to gamma lut. >> It can be fed with pixels from one of our CRTC at a time and uses a >> matrix with S0.9 scalars. Use

[PATCH] drm/amdgpu: cleanup firmware requests

2018-04-17 Thread Andres Rodriguez
Add a new function amdgpu_ucode_request_firmware() that encapsulates a lot of the common behaviour we have around firmware requests. This is the first step in my quest to get rid of the following annoying messages when my polaris10 boots up: [0.558537] amdgpu :01:00.0: Direct firmware

Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

2018-04-17 Thread Eric Anholt
Rob Herring writes: > On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt wrote: >> The GPU subsystem node was a workaround to have a central device to >> bind V3D and display to. Following the lead of 246774d17fc0 >> ("drm/etnaviv: remove the need for a

Re: [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-17 Thread Dongwon Kim
On Tue, Apr 17, 2018 at 09:59:28AM +0200, Daniel Vetter wrote: > On Mon, Apr 16, 2018 at 12:29:05PM -0700, Dongwon Kim wrote: > > Yeah, I definitely agree on the idea of expanding the use case to the > > general domain where dmabuf sharing is used. However, what you are > > targetting with

Re: [DPU PATCH 4/6] drm/msm: strip down custom event ioctl's

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 11:22:19AM -0700, Jeykumar Sankaran wrote: > Remove custom ioctl support in SDM845 which allows > user space to register/unregister for hw events. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- >

Re: [DPU PATCH 3/6] drm/msm: remove panel autorefresh support for SDM845

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 11:22:18AM -0700, Jeykumar Sankaran wrote: > Remove autorefresh support for smart panels in SDM845 for now. > It needs more discussion to figure out the user space > communication to set preference for the feature. > > Signed-off-by: Jeykumar Sankaran

Re: [DPU PATCH 2/6] drm/msm: remove support for ping pong split topology

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 11:22:17AM -0700, Jeykumar Sankaran wrote: > Ping pong split topology was meant for low end soc's which > doesn't have enough layer mixers to support split panels. > Considering how uncommon the topology is for current chipset's and > also to simply the driver programming,

[DPU PATCH v4 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

2018-04-17 Thread Abhinav Kumar
Currently the DSI PHY timings are hard-coded for a specific panel for the 10nm PHY. Replace this with the auto PHY timing calculator which can calculate the PHY timings for any panel. Changes in v4: - None Changes in v3: - None Changes in v2: - None Reviewed-by: Sean Paul

[Bug 106110] vaapi encoding with gstreamer 1.14 doesn't work

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106110 --- Comment #3 from Andy Furniss --- FWIW I found the "nothing works" cause = the next commit in gstreamer-vaapi after 1.14 tag = fa77b2bf vaapiencode: h264: find best profile in those available With that reverted the

[DPU PATCH v4 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-17 Thread Abhinav Kumar
Make sure the video mode engine is on before waiting for the video done interrupt. Changes in v4: - Move setting enabled to false earlier Changes in v3: - Move the return value check to another patch Changes in v2: - Replace pr_err with dev_err - Changed error message Signed-off-by: Abhinav

Re: [DPU PATCH 1/6] drm/msm: remove display stream compression(DSC) support for SM845

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 11:22:16AM -0700, Jeykumar Sankaran wrote: > Upstream DSI driver doesn't support DSC panels yet. Remove > the support for compression from DPU for now. > > Signed-off-by: Jeykumar Sankaran > --- > drivers/gpu/drm/msm/Makefile

Re: [DPU PATCH v3 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-17 Thread abhinavk
On 2018-04-17 13:25, Sean Paul wrote: On Mon, Apr 16, 2018 at 06:56:45PM -0700, Abhinav Kumar wrote: Make sure the video mode engine is on before waiting for the video done interrupt. Changes in v2: - Replace pr_err with dev_err - Changed error message Changes in v3: - Move the return value

[Bug 106110] vaapi encoding with gstreamer 1.14 doesn't work

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106110 --- Comment #2 from Andy Furniss --- I was on older gits for gstreamer when I saw this around 1.13 matroska and mp4mux didn't work, but raw 264 and avimux did. I updated to current gits before seeing the workaround and

Re: [DPU PATCH v2 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 05:40:13PM -0700, Chandan Uddaraju wrote: > For dual dsi mode, the horizontal timing needs > to be divided by half since both the dsi controllers > will be driving this panel. Adjust the pixel clock and > DSI timing accordingly. > > Changes in V2: > --Removed Change-Id

Re: [DPU PATCH v3 1/2] drm/msm/dsi: check video mode engine status before waiting

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 06:56:45PM -0700, Abhinav Kumar wrote: > Make sure the video mode engine is on before waiting > for the video done interrupt. > > Changes in v2: > - Replace pr_err with dev_err > - Changed error message > > Changes in v3: > - Move the return value check to another >

[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #34 from MirceaKitsune --- (In reply to iive from comment #33) Ahhh... you've reminded me of a detail that I have in fact noticed but forgot to mention: After the machine freezes and becomes

[Bug 106110] vaapi encoding with gstreamer 1.14 doesn't work

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106110 Christoph Haag changed: What|Removed |Added Resolution|--- |FIXED

Re: [PATCH 1/2 v2] drm/pl111: Support the Versatile Express

2018-04-17 Thread Linus Walleij
On Tue, Apr 17, 2018 at 3:12 PM, Robin Murphy wrote: > On 17/04/18 13:32, Linus Walleij wrote: > [...] >> >> Unfortunately there is just one single vexpress core tile in the >> upstream kernel that define a CLCD controller, the CA9 (4xA9) >> that I am using. All the others

[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #33 from i...@yahoo.com --- This doesn't sound good. The sshd dying indicates that the kernel or the CPU has hang. If there is GPU shader hang this doesn't happen right away, it usually waits 10 seconds before attempting to reset the

Re: [PATCH 2/2 v2] drm/pl111: Enable device-specific assigned memory

2018-04-17 Thread Eric Anholt
Linus Walleij writes: > On Sun, Apr 8, 2018 at 3:08 AM, Eric Anholt wrote: > >>> if (of_property_read_u32(dev->of_node, "max-memory-bandwidth", >>>>memory_bw)) { >>> dev_info(dev, "no max memory

Re: [PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately

2018-04-17 Thread Deucher, Alexander
+ Suravee From: Robin Murphy Sent: Tuesday, April 17, 2018 2:22:46 PM To: Koenig, Christian; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: ok...@codeaurora.org; Deucher, Alexander Subject: Re: [PATCH v2 1/3] drm/prime:

Re: [PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately

2018-04-17 Thread Robin Murphy
On 17/04/18 17:29, Christian König wrote: Am 17.04.2018 um 17:58 schrieb Robin Murphy: For dma_map_sg(), DMA API implementations are free to merge consecutive segments into a single DMA mapping if conditions are suitable, thus the resulting DMA addresses which drm_prime_sg_to_page_addr_arrays()

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

2018-04-17 Thread abhinavk
Hi Bjorn Thanks for the comments. Reply inline. On 2018-04-16 23:13, Bjorn Andersson wrote: On Mon 16 Apr 15:45 PDT 2018, abhin...@codeaurora.org wrote: Hi Bjorn Thanks for the review. Reply inline. On 2018-04-16 09:41, Bjorn Andersson wrote: > On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar

[Bug 106110] vaapi encoding with gstreamer 1.14 doesn't work

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106110 Bug ID: 106110 Summary: vaapi encoding with gstreamer 1.14 doesn't work Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 104412] RX 460 HDMI 4k 60fps not working, DisplayPort is.

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104412 --- Comment #18 from Harry Wentland --- Please keep one issue per ticket. Open a new ticket if needed. That said, a fix for the flickering issue should be in drm-next-4.17 of Alex's git repo at

Re: [PATCH RFC] drm: Add ASPEED GFX driver

2018-04-17 Thread Eric Anholt
Joel Stanley writes: > This driver is for the ASPEED BMC SoC's GFX display hardware. This > driver runs on the ARM based BMC systems, unlike the ast driver which > runs on a host CPU and is is for a PCIe graphics device that happens to > live in the BMC's silicon, but is

[Bug 105177] amdgpu wrong colors with rx460 connected via hdmi

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105177 --- Comment #22 from Harry Wentland --- Please keep one issue per ticket. Open a new ticket if needed. That said, a fix for the flickering issue should be in drm-next-4.17 of Alex's git repo at

[Bug 199319] Flickering screen on AMDGPU and DC with Linux 4.16-2

2018-04-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199319 --- Comment #16 from Harry Wentland (harry.wentl...@amd.com) --- A fix should be in drm-next-4.17 of Alex's git repo at https://cgit.freedesktop.org/~agd5f/linux/?h=drm-next-4.17 and should make it into Linus's tree from there. That fix should

[Bug 105083] Random blinking display

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105083 Harry Wentland changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-17 Thread Ville Syrjälä
On Mon, Apr 16, 2018 at 06:53:09PM +0300, Imre Deak wrote: > LSPCON adapters in low-power state may ignore the first I2C write during > TMDS output buffer enabling, resulting in a blank screen even with an > otherwise enabled pipe. Fix this by reading back and validating the > written value a few

Re: [PATCH hwc v2 17/18] drm_hwcomposer: Flatten scene synchronously

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:28PM +0100, Alexandru Gheorghe wrote: > Flatten scene on the same CRTC as the one driving the display. > The active composition is played back to the display with a buffer > attached to the writeback connector. > Then we build a composition that has only one plane

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-17 Thread Ville Syrjälä
On Tue, Apr 17, 2018 at 10:45:07AM +0530, Nautiyal, Ankit K wrote: > > On 4/6/2018 11:14 PM, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: > >> This patch is causing failure of IGT test kms_3d. The kms_3d test > >> expects the no. of 3d modes to be

Re: [PATCH hwc v2 16/18] drm_hwcomposer: Find writeback connector for scene flattening

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:27PM +0100, Alexandru Gheorghe wrote: > Add logic for finding a suitable writeback connector, there are two > possibilities for finding an usable writeback connector: > > 1) Attached to the same CRTC as the display and can function >concurrently with the display

Re: [PATCH hwc v2 15/18] drm_hwcomposer: Add worker to trigger scene flattenning

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:26PM +0100, Alexandru Gheorghe wrote: > Add a vsync worker that calls back into the DrmDisplayCompositor, > for now at every 60 vsyncs if the scene does not change we trigger > the flattening of the scene using the writeback connector. > Other, more complex and proper

Re: [PATCH hwc v2 14/18] drm_hwcomposer: Fix race in ApplyFrame

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:25PM +0100, Alexandru Gheorghe wrote: > ApplyFrame holds the lock just when it swaps the value of > active_composition_, in a multithread context we could end up in a > situation where something is shown on the screen, but something else > is set in

Re: [PATCH hwc v2 13/18] drm_hwcomposer: Pass buffer sizes to Prepareframebuffer

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:24PM +0100, Alexandru Gheorghe wrote: > Currently Prepareframebuffer uses the mode of the connected connector > to decide how big the buffer should be, however when using the > drmdisplaycompositor just for flattening, the mode had not been set > yet, so we need a way

Re: [PATCH hwc v2 12/18] drm_hwcomposer: Add utility function to create an initialized composition

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:23PM +0100, Alexandru Gheorghe wrote: > There is a lot of boilerplate for creating an initialized > drmdisplaycomposition. This patch gathers that in a separate method. > > Signed-off-by: Alexandru Gheorghe > --- >

Re: [PATCH hwc v2 11/18] drm_hwcomposer: Add utility functions to copy displaycomposition internals

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:22PM +0100, Alexandru Gheorghe wrote: > Add utility functions to copy the DrmHwcLayer and DrmCompositionPlanes > from another DrmDisplayComposition. > > Signed-off-by: Alexandru Gheorghe > --- > drmdisplaycomposition.cpp | 29

Re: [PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately

2018-04-17 Thread Christian König
Am 17.04.2018 um 17:58 schrieb Robin Murphy: For dma_map_sg(), DMA API implementations are free to merge consecutive segments into a single DMA mapping if conditions are suitable, thus the resulting DMA addresses which drm_prime_sg_to_page_addr_arrays() iterates may be packed into fewer entries

Re: [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Daniel Vetter
On Tue, Apr 17, 2018 at 5:29 PM, Jani Nikula wrote: > On Tue, 17 Apr 2018, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather

Re: [PATCH hwc v2 10/18] drm_hwcomposer: hwcutils: Add function for cloning a DrmHwcLayer

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:21PM +0100, Alexandru Gheorghe wrote: > When doing flattening of a composition on a different CRTC we need to be > able to clone a layer in order to import it and then pass it to another CRTC. > > Signed-off-by: Alexandru Gheorghe

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

2018-04-17 Thread Robert Foss
Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible for detecting all kms devices and allocates unique display numbers for every detected display. This is controlled by the value of

[PATCH v2 3/3] drm/radeon: Allow dma_map_sg() coalescing

2018-04-17 Thread Robin Murphy
Much like amdgpu, the radeon driver doesn't appear to directly use the scatterlist mapped by radeon_ttm_tt_pin_userptr(), it merely hands it off to drm_prime_sg_to_page_addr_arrays() to generate the dma_address array which it actually cares about. Now that the latter can cope with dma_map_sg()

[PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing

2018-04-17 Thread Robin Murphy
The amdgpu driver doesn't appear to directly use the scatterlist mapped by amdgpu_ttm_tt_pin_userptr(), it merely hands it off to drm_prime_sg_to_page_addr_arrays() to generate the dma_address array which it actually cares about. Now that the latter can cope with dma_map_sg() coalescing

[PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately

2018-04-17 Thread Robin Murphy
For dma_map_sg(), DMA API implementations are free to merge consecutive segments into a single DMA mapping if conditions are suitable, thus the resulting DMA addresses which drm_prime_sg_to_page_addr_arrays() iterates may be packed into fewer entries than ttm->sg->nents implies. The current

Re: [PATCH hwc v2 09/18] drm_hwcomposer: Handle writeback connectors

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:20PM +0100, Alexandru Gheorghe wrote: > When writeback connectors are available assign them to displays, in > order to be able to use them for flattening of the current displayed > scene. The pipeline for each display will look like this: > > CRTC encoder

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: > Add a resource manager object that is responsible for detecting all > kms devices and allocates unique display numbers for every detected > display. > > This is controlled by the value of hwc.drm.device property, if it ends >

[Bug 97025] flip queue failed: Device or resource busy

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97025 --- Comment #26 from Michel Dänzer --- Does https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=daf8809626c0ee7a152f9c34058fc3b43385dd51 help for this? -- You are receiving this mail because: You

Re: [PATCH] gpu: drm: i915: Change return type to vm_fault_t

2018-04-17 Thread Jani Nikula
On Tue, 17 Apr 2018, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type.

[Bug 176311] Fiji DisplayPort amdgpu_crtc_page_flip *ERROR* failed to get vblank before flip

2018-04-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=176311 --- Comment #7 from Michel Dänzer (mic...@daenzer.net) --- Does https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=daf8809626c0ee7a152f9c34058fc3b43385dd51 help for this, by any chance? BTW, I made a mistake in comment

[Bug 199357] amdgpu: hang a few seconds after logging in, most likely due to regression

2018-04-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199357 --- Comment #11 from Alex Deucher (alexdeuc...@gmail.com) --- Yes, the revert cc'ed stable so it will show up in 4.16 as well. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [Freedreno] [Intel-gfx] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-17 Thread Jordan Crouse
On Mon, Apr 16, 2018 at 10:52:59AM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > Quoting Jordan Crouse (2018-04-05 23:06:53) > >> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: > >> > The i915 DRM driver very cleverly used ascii85 encoding for

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-17 Thread Tomi Valkeinen
Hi Rob, On 09/04/18 21:17, Rob Herring wrote: >>> For HDMI, you can't know in advance what resolution will be. So I >>> think you always need to reserve 2 planes. Now, if you want to reduce >> >> We can decide not to support 2k+ resolutions for HDMI, which, with this >> series, happens by not

Re: [PATCH hwc v2 05/18] drm_hwcomposer: Enable resource manager support

2018-04-17 Thread Sean Paul
On Wed, Apr 11, 2018 at 04:22:16PM +0100, Alexandru Gheorghe wrote: > Use the newly added ResourceManager for creating and detecting all the > drm devices instead of assuming that there is only one device. > > Signed-off-by: Alexandru Gheorghe > --- > index

Re: [PATCH hwc v2 05/18] drm_hwcomposer: Enable resource manager support

2018-04-17 Thread Sean Paul
On Tue, Apr 17, 2018 at 02:43:17PM +0100, Alexandru-Cosmin Gheorghe wrote: > Hi Sean, > > On Mon, Apr 16, 2018 at 03:54:02PM -0400, Sean Paul wrote: > > On Wed, Apr 11, 2018 at 04:22:16PM +0100, Alexandru Gheorghe wrote: > > > Use the newly added ResourceManager for creating and detecting all the

RE: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

2018-04-17 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-04-17 12:02:52) > On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote: > >>-Original Message- > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > >>Sent: Wednesday, April 11, 2018 5:27 AM > >>To: Ian W MORRISON

Re: [PATCH hwc v2 01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

2018-04-17 Thread Alexandru-Cosmin Gheorghe
On Tue, Apr 17, 2018 at 09:45:06AM -0400, Sean Paul wrote: > On Mon, Apr 16, 2018 at 01:18:53PM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Mon, Apr 16, 2018 at 12:30:13PM +0200, Robert Foss wrote: > > > > Hi Rob, > > > > Thanks for the review. > > > > > Hey Alexandru, > > > > > > Feel free

Re: [PATCH hwc v2 08/18] drm_hwcomposer: Parse and store possible_clones information

2018-04-17 Thread Alexandru-Cosmin Gheorghe
Hi Sean, On Mon, Apr 16, 2018 at 04:19:14PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:19PM +0100, Alexandru Gheorghe wrote: > > drmModeEncoder has a field called possible_clones. It's a bit mask > > which tells if the encoder could be simultaneously connected, to the > > same CRTC,

[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #32 from MirceaKitsune --- (In reply to iive from comment #31) Sounds a lot more complicated, but I'm gladly willing to try it as long as there's no risk of anything permanently breaking my

Re: [PATCH hwc v2 07/18] drm_hwcomposer: Add display field to Drmencoder

2018-04-17 Thread Alexandru-Cosmin Gheorghe
Hi Sean, On Mon, Apr 16, 2018 at 04:02:07PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:18PM +0100, Alexandru Gheorghe wrote: > > In the current implementation TryEncoderForDisplay just looks > > at the crtc linked to the display, if that's not assigned to > > a display it means the

Re: [PATCH hwc v2 06/18] drm_hwcomposer: Add writeback connector support

2018-04-17 Thread Alexandru-Cosmin Gheorghe
Hi Sean, On Mon, Apr 16, 2018 at 03:59:07PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:17PM +0100, Alexandru Gheorghe wrote: > > Writeback connector is a special case of connector, which can be > > linked to a CRTC in order to get the result of the composition back to > > a memory

Re: [PATCH hwc v2 01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 01:18:53PM +0100, Alexandru-Cosmin Gheorghe wrote: > On Mon, Apr 16, 2018 at 12:30:13PM +0200, Robert Foss wrote: > > Hi Rob, > > Thanks for the review. > > > Hey Alexandru, > > > > Feel free to add: > > Signed-off-by: Robert Foss > > > >

Re: [PATCH hwc v2 05/18] drm_hwcomposer: Enable resource manager support

2018-04-17 Thread Alexandru-Cosmin Gheorghe
Hi Sean, On Mon, Apr 16, 2018 at 03:54:02PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:16PM +0100, Alexandru Gheorghe wrote: > > Use the newly added ResourceManager for creating and detecting all the > > drm devices instead of assuming that there is only one device. > > > >

Re: [PATCH] CHROMIUM: drm/rockchip: Disable blending for win0

2018-04-17 Thread Sean Paul
On Tue, Apr 17, 2018 at 09:37:44AM -0400, Sean Paul wrote: > On Mon, Apr 16, 2018 at 03:22:15PM -0700, Kristian H. Kristensen wrote: > > Blending win0 with the background color doesn't seem to work > > correctly. We only get the background color, no matter the contents of > > the win0 framebuffer.

Re: [PATCH] CHROMIUM: drm/rockchip: Disable blending for win0

2018-04-17 Thread Sean Paul
On Mon, Apr 16, 2018 at 03:22:15PM -0700, Kristian H. Kristensen wrote: > Blending win0 with the background color doesn't seem to work > correctly. We only get the background color, no matter the contents of > the win0 framebuffer. However, blending pre-multiplied color with the > default opaque

Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

2018-04-17 Thread Alexandru-Cosmin Gheorghe
Hi Sean, On Mon, Apr 16, 2018 at 03:25:42PM -0400, Sean Paul wrote: > On Wed, Apr 11, 2018 at 04:22:13PM +0100, Alexandru Gheorghe wrote: > > vsyncworker::Routine assumes that when -EINTR is returned by > > WaitForSignalOrExitLocked the lock as been released, which is not > > true, so it hangs if

Re: [PATCH 1/2 v2] drm/pl111: Support the Versatile Express

2018-04-17 Thread Robin Murphy
On 17/04/18 13:32, Linus Walleij wrote: [...] Unfortunately there is just one single vexpress core tile in the upstream kernel that define a CLCD controller, the CA9 (4xA9) that I am using. All the others just use the MB CLCD. I am thinking there is some never finished DTS upstreaming here that

Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

2018-04-17 Thread Rob Herring
On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt wrote: > The GPU subsystem node was a workaround to have a central device to > bind V3D and display to. Following the lead of 246774d17fc0 > ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove > the subsystem node

Re: [PATCH 1/2 v2] drm/pl111: Support the Versatile Express

2018-04-17 Thread Linus Walleij
On Tue, Apr 10, 2018 at 11:57 AM, Liviu Dudau wrote: > I need to do a bit of archeology to get my Versatile Express back > to working order in order to test your patches, which might not > happen this week or so, but I have some comments on your approach > which I would like

Re: [PATCH 2/2 v2] drm/pl111: Enable device-specific assigned memory

2018-04-17 Thread Linus Walleij
On Sun, Apr 8, 2018 at 3:08 AM, Eric Anholt wrote: >> if (of_property_read_u32(dev->of_node, "max-memory-bandwidth", >>>memory_bw)) { >> dev_info(dev, "no max memory bandwidth specified, assume >> unlimited\n"); >> @@ -275,7

[PATCH] drm/stm: ltdc: add mode_valid()

2018-04-17 Thread Philippe Cornu
Add mode_valid() function to filter modes according to available pll clock values and "preferred" modes. It is particularly useful for hdmi modes that require precise pixel clocks. Note that "preferred" modes are always accepted: - this is important for panels because panel clock tolerances are

[PATCH] drm/stm: ltdc: fix deferred endpoint management

2018-04-17 Thread Philippe Cornu
When a driver related to one of the endpoints is deferred due to probe dependencies (i2c, spi...) but the other one is ready, ltdc probe continues and the deferred driver will never be probed again. The fix consists in waiting for all deferred endpoints before continuing the ltdc probe.

Re: [PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

2018-04-17 Thread Heiko Stuebner
Hi Sandy, Am Dienstag, 17. April 2018, 12:15:07 CEST schrieb Sandy Huang: > When video width is bigger than 3840 the linebuffer mode > should be LB_YUV_3840X5. Can you explain that a bit better? I.e. when looking at the code, the very first check is width > 2560. So it seems your change

Re: [RFC v4 23/25] drm: Add DRM device registered notifier

2018-04-17 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:16PM +0200, Noralf Trønnes wrote: > Add a notifier that fires when a new DRM device is registered. > This can be used by the bootsplash client to connect to all devices. > > Signed-off-by: Noralf Trønnes So I freaked out temporarily about your

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-04-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #6 from taij...@posteo.de --- If I wanted to try to embed amdgpu in the kernel for testing, how would I even go about doing that? Simply editing my config file from =m to =y does not seem to do anything. -- You are receiving this

  1   2   >