[drm:drm-legacy-cleanup 13/24] drivers/gpu/drm/drm_vm.c:483:10: error: implicit declaration of function 'pte_wrprotect'

2019-04-23 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup head: 7b7678e3949f22d2442179f27d219b4b09ef1730 commit: 739d8489bcb277a1a27e56d0ef529f41c46425b4 [13/24] drm/nouveau: add kconfig option to turn off nouveau legacy contexts. (v2) config: c6x-allyesconfig (attached as

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Vetter
On Sun, Apr 21, 2019 at 01:59:04AM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Thu, Apr 18, 2019 at 12:07:44PM +0200, Daniel Vetter wrote: > > On Thu, Apr 18, 2019 at 11:02 AM Maxime Ripard wrote: > > > On Thu, Apr 18, 2019 at 09:52:10AM +0200, Daniel Vetter wrote: > > > > On Thu, Apr 18,

Re: [PATCHv2 12/22] drm/bridge: tc358767: remove unnecessary msleep

2019-04-23 Thread Andrey Gusakov
Hi On Sun, Apr 21, 2019 at 12:43 AM Laurent Pinchart wrote: > > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:36PM +0200, Tomi Valkeinen wrote: > > For some reason the driver has a msleep(100) after writing to > > DP_PHY_CTRL. Toshiba's documentation doesn't suggest

Re: [PATCH] Revert "drm/virtio: drop prime import/export callbacks"

2019-04-23 Thread Gerd Hoffmann
On Fri, Apr 19, 2019 at 05:57:09PM +0200, Marc-André Lureau wrote: > This patch does more harm than good, as it breaks both Xwayland and > gnome-shell with X11. > > Xwayland requires DRI3 & DRI3 requires PRIME. > > X11 crash for obscure double-free reason which are hard to debug > (starting X11

Re: [PATCH v5 04/12] drm/i915: Attach content type property

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:27:57PM +0530, Ramalingam C wrote: > Attaches the content type property for HDCP2.2 capable connectors. > > Implements the update of content type from property and apply the > restriction on HDCP version selection. > > v2: > s/cp_content_type/content_protection_type

Re: [PATCHv2 03/22] drm/bridge: tc358767: fix ansi 8b10b use

2019-04-23 Thread Andrey Gusakov
Hi Laurent, On Sun, Apr 21, 2019 at 12:14 AM Laurent Pinchart wrote: > > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:27PM +0200, Tomi Valkeinen wrote: > > DP always uses ANSI 8B10B encoding. Some monitors (old?) may not have > > the ANSI 8B10B bit set in DPCD, even if

Re: [PATCH 3/6] dma-buf: add peer2peer flag

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 10:16:50AM +0200, Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 02:09:25PM +0200, Christian König wrote: > > Add a peer2peer flag noting that the importer can deal with device > > resources which are not backed by pages. > > > > Signed-off-by: Christian König > > Should

[Bug 110472] Graphical Fault (Desktop Freeze) on Specific OpenGL Application

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110472 Michel Dänzer changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Bug 110478] AMDGPU error(failed to set mode: cannot allocate memory) when hdmi connected

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110478 Michel Dänzer changed: What|Removed |Added Component|Driver/AMDgpu |DRM/AMDgpu QA

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Stone
Hi, On Tue, 23 Apr 2019 at 08:26, Daniel Vetter wrote: > On Sun, Apr 21, 2019 at 01:59:04AM +0300, Laurent Pinchart wrote: > > > > > - drm fourcc code doesn't actually define the drm_format_info > > > > > uniquely, drivers can override that (that's an explicit design > > > > > intent of

Re: [v3 0/7] Add Multi Segment Gamma Support

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 04:11:58PM +0300, Ville Syrjälä wrote: > On Thu, Apr 18, 2019 at 09:13:04AM +0200, Daniel Vetter wrote: > > On Wed, Apr 17, 2019 at 02:57:31PM +0300, Ville Syrjälä wrote: > > > On Wed, Apr 17, 2019 at 09:28:19AM +0200, Daniel Vetter wrote: > > > > On Fri, Apr 12, 2019 at

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Vetter
On Sun, Apr 21, 2019 at 01:40:45AM +0300, Laurent Pinchart wrote: > Hi Paul, > > On Thu, Apr 18, 2019 at 01:49:54PM +0200, Paul Kocialkowski wrote: > > On Thu, 2019-04-18 at 11:02 +0200, Maxime Ripard wrote: > > > On Thu, Apr 18, 2019 at 09:52:10AM +0200, Daniel Vetter wrote: > > >> And a lot of

Re: [PATCH v5 01/12] drm: move content protection property to mode_config

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:27:54PM +0530, Ramalingam C wrote: > Content protection property is created once and stored in > drm_mode_config. And attached to all HDCP capable connectors. > > Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic_uapi.c | 4

Re: [PATCH] Revert "drm/virtio: drop prime import/export callbacks"

2019-04-23 Thread Gerd Hoffmann
Hi, > > The DRI3 code extensively uses prime_handle_to_fd and > > prime_fd_to_handle for self-import. The callbacks are not used for self-import. > I believe the cap was removed because the driver only supports > self-import. But the driver only runs inside VMs where there is no(?) > other

Re: [Intel-gfx] [PATCH] dma-buf: Remove unused sync_dump()

2019-04-23 Thread Daniel Vetter
On Fri, Apr 19, 2019 at 07:19:04PM +0100, Chris Wilson wrote: > sync_dump() is an unused, unexported, function that adds 64k to the > kernel image and doesn't even provide locking around the global array it > uses. > > add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-65734 (-65734) > Function

Re: [PATCH v5 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-23 Thread Paul Kocialkowski
Hi, On Mon, 2019-04-15 at 13:48 -0700, Eric Anholt wrote: > Paul Kocialkowski writes: > > > Since the OOM interrupt directly deals with the binner bo, it doesn't > > make sense to try and handle it without a binner buffer registered. > > > > Signed-off-by: Paul Kocialkowski > > --- > >

Re: [PATCH v5 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-23 Thread Paul Kocialkowski
On Tue, 2019-04-23 at 10:30 +0200, Paul Kocialkowski wrote: > Hi, > > On Mon, 2019-04-15 at 13:48 -0700, Eric Anholt wrote: > > Paul Kocialkowski writes: > > > > > Since the OOM interrupt directly deals with the binner bo, it doesn't > > > make sense to try and handle it without a binner buffer

[drm:drm-legacy-cleanup 13/24] drivers/gpu//drm/drm_vm.c:482:16: note: in expansion of macro 'pte_val'

2019-04-23 Thread kbuild test robot
tree: git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup head: 7b7678e3949f22d2442179f27d219b4b09ef1730 commit: 739d8489bcb277a1a27e56d0ef529f41c46425b4 [13/24] drm/nouveau: add kconfig option to turn off nouveau legacy contexts. (v2) config: arm-lpc18xx_defconfig (attached as

Re: [PATCH] drm: Fire off KMS hotplug events if probe detect says the connector is connected

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 01:15:17PM +, Mun, Gwan-gyeong wrote: > On Thu, 2019-04-18 at 10:28 +0200, Daniel Vetter wrote: > > On Thu, Apr 18, 2019 at 11:09:29AM +0300, Gwan-gyeong Mun wrote: > > > The hotplug detection routine of drm_helper_hpd_irq_event() can > > > detect > > > changing of

Re: [patch V2 16/29] drm: Simplify stacktrace handling

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 10:41:35AM +0200, Thomas Gleixner wrote: > Replace the indirection through struct stack_trace by using the storage > array based interfaces. > > The original code in all printing functions is really wrong. It allocates a > storage array on stack which is unused because

Re: [PATCH v5 03/12] drm: Add Content protection type property

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:27:56PM +0530, Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-04-23 Thread Jani Nikula
On Tue, 23 Apr 2019, David Santamaría Rogado wrote: > Hi Jani, > > When are the changes in drm-misc-next pushed? > > I'm testing recent kernels that don't work with some models because > the dsi display problem you are aware. Works with 4.15 but not with > more recent kernels. > > The model I

Re: [PATCH 3/6] dma-buf: add peer2peer flag

2019-04-23 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 02:09:25PM +0200, Christian König wrote: > Add a peer2peer flag noting that the importer can deal with device > resources which are not backed by pages. > > Signed-off-by: Christian König Should we add something like "Such importers should also support dynamic dma_buf

Re: [Intel-gfx] [PATCH] dma-buf: Remove unused sync_dump()

2019-04-23 Thread Chris Wilson
Quoting Daniel Vetter (2019-04-23 09:21:16) > On Fri, Apr 19, 2019 at 07:19:04PM +0100, Chris Wilson wrote: > > sync_dump() is an unused, unexported, function that adds 64k to the > > kernel image and doesn't even provide locking around the global array it > > uses. > > > > add/remove: 0/2

Re: [RFC][PATCH 1/5] libdrm: Use mmap64 instead of __mmap2

2019-04-23 Thread Emil Velikov
On Sat, 20 Apr 2019 at 05:25, John Stultz wrote: > > From: Sean Paul > > __mmap2 isn't supported on all platforms, mmap64 is the right way > to do this in android. > > Also folds in a fix from Stéphane Marchesin > to use an offset in bytes not pages, as that's what mmap64 takes. > > Cc: Emil

[Bug 109456] KVM VFIO guest X hang with guest kernel > 4.15

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109456 --- Comment #3 from libgra...@gmail.com --- Created attachment 144077 --> https://bugs.freedesktop.org/attachment.cgi?id=144077=edit Dmesg output from failed Xorg start -- You are receiving this mail because: You are the assignee for the

[Bug 109456] KVM VFIO guest X hang with guest kernel > 4.15

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109456 --- Comment #4 from libgra...@gmail.com --- Created attachment 144078 --> https://bugs.freedesktop.org/attachment.cgi?id=144078=edit Xorg output from failed Xorg start -- You are receiving this mail because: You are the assignee for the

Re: [RFC][PATCH 2/5] libdrm: amdgpu: Initialize unions with memset rather than "= {0}"

2019-04-23 Thread Emil Velikov
On Sat, 20 Apr 2019 at 05:25, John Stultz wrote: > > Clang complains when initializing unions using "= {0}" > so instead use memset. > > Cc: Emil Velikov > Cc: Sean Paul > Cc: Alistair Strachan > Cc: Marissa Wall > Signed-off-by: John Stultz Reviewed-by: Emil Velikov -Emil

[Bug 109456] KVM VFIO guest X hang with guest kernel > 4.15

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109456 --- Comment #5 from libgra...@gmail.com --- Have compiled 5.0.7 with the commit indicated by the bisect reverted and it boots to Xorg fine. Running an OpenGL application subsequently will hang the VM though. -- You are receiving this mail

Re: [PATCH v4 3/9] pinctrl: sunxi: Prepare for alternative bias voltage setting methods

2019-04-23 Thread Linus Walleij
On Sat, Apr 13, 2019 at 6:54 PM wrote: > From: Ondrej Jirman > > H6 has a different I/O voltage bias setting method than A80. Prepare > existing code for using alternative bias voltage setting methods. > > Signed-off-by: Ondrej Jirman > Acked-by: Maxime Ripard This patch applied to the

Re: [PATCH v4 4/9] pinctrl: sunxi: Support I/O bias voltage setting on H6

2019-04-23 Thread Linus Walleij
On Sat, Apr 13, 2019 at 6:54 PM wrote: > From: Ondrej Jirman > > H6 SoC has a "pio group withstand voltage mode" register (datasheet > description), that needs to be used to select either 1.8V or 3.3V I/O mode, > based on what voltage is powering the respective pin banks and is thus used > for

Re: [RFC][PATCH 4/5] libdrm: reduce number of reallocations in drmModeAtomicAddProperty

2019-04-23 Thread Emil Velikov
On Sat, 20 Apr 2019 at 05:25, John Stultz wrote: > > From: Adrian Salido > > When calling drmModeAtomicAddProperty allocation of memory happens as > needed in increments of 16 elements. This can be very slow if there are > multiple properties to be updated in an Atomic Commit call. > > Increase

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Heiko Stuebner
Am Sonntag, 21. April 2019, 10:25:50 CEST schrieb Jonas Karlman: > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual > address 0008 > [ 31.041671] pgd = 4d3c16f6 > [ 31.041673]

Re: [RFC][PATCH 5/5] libdrm: omap: Add DRM_RDWR flag to dmabuf export

2019-04-23 Thread Emil Velikov
On Sat, 20 Apr 2019 at 05:25, John Stultz wrote: > > From: Hemant Hariyani > > Allows mmap on dmabuf fd with MAP_SHARED and PROT_WRITE. > > This fixes boot failures caused due to mmap() returning error > Commit message is quite meh - xf86-video-omap does not use the API, so things should work

[PATCH v3 0/2] Add writeback scaling

2019-04-23 Thread Ben Davis
Add support for scaling on writeback. To do this add writeback_dest_w and writeback_dest_h as writeback connector properties to specify the desired output dimensions. Then implement downscaling on writeback for Malidp-550 and Malidp-650 (upscaling on writeback is not supported on these devices).

[PATCH v3 1/2] drm: Add writeback_dest_w,h properties

2019-04-23 Thread Ben Davis
Add new properties to specify width and height for writeback. Signed-off-by: Ben Davis --- drivers/gpu/drm/drm_atomic_uapi.c | 8 drivers/gpu/drm/drm_writeback.c | 30 ++ include/drm/drm_connector.h | 4 include/drm/drm_mode_config.h | 10

[PATCH v3 2/2] drm/malidp: Enable writeback scaling

2019-04-23 Thread Ben Davis
The phase setting part of malidp_crtc_atomic_check_scaling is refactored to allow use in writeback scaling. Also the enable_memwrite function prototype is simplified by directly passing mw_state. Signed-off-by: Ben Davis --- drivers/gpu/drm/arm/malidp_crtc.c | 49 +++-

Re: [PATCH v2 1/3] dt-bindings: Add vendor prefix for VXT Ltd

2019-04-23 Thread Thierry Reding
On Mon, Feb 18, 2019 at 09:27:04PM -0300, Fabio Estevam wrote: > VXT Ltd is a manufacturer of projected capacitive touch panel > and display solutions: http://www.vxt.com.tw/ > > Reviewed-by: Otavio Salvador > Reviewed-by: Rob Herring > Signed-off-by: Fabio Estevam > --- > Changes since v1: >

Re: [Intel-gfx] [PATCH v3 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-04-23 Thread Martin Peres
On 20/04/2019 20:24, Noralf Trønnes wrote: > > > Den 20.04.2019 12.45, skrev Noralf Trønnes: >> This moves the modesetting code from drm_fb_helper to drm_client so it >> can be shared by all internal clients. >> >> Changes this time: >> - Use full drm_client_init/release for the modesets (Daniel

Re: [PATCH v4 1/2] dt-bindings: drm: panel: Add Samsung s6e63m0 panel documentation

2019-04-23 Thread Thierry Reding
On Fri, Feb 22, 2019 at 06:51:52PM +0100, Paweł Chmiel wrote: > From: Jonathan Bakker > > This commit adds documentation for Samsung s6e63m0 AMOLED LCD panel > driver. > > Signed-off-by: Jonathan Bakker > Signed-off-by: Paweł Chmiel > Reviewed-by: Rob Herring > --- > Changes from v2: > -

Re: [PATCH v5 04/12] drm/i915: Attach content type property

2019-04-23 Thread Ramalingam C
On 2019-04-23 at 10:11:48 +0200, Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 02:27:57PM +0530, Ramalingam C wrote: > > Attaches the content type property for HDCP2.2 capable connectors. > > > > Implements the update of content type from property and apply the > > restriction on HDCP version

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #10 from Kevin Hamacher --- Created attachment 144079 --> https://bugs.freedesktop.org/attachment.cgi?id=144079=edit Nullptr deref after powercycling MST display -- You are receiving this mail because: You are the assignee for

[Bug 104611] [fiji, polaris10] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #11 from Kevin Hamacher --- I'm also affected by this. Setup: GPUs: RX 580 (used), R9 Fury Screens: 3xU2415, connected via DP. 2 of them connected via MST, 1 HDMI to disabled screen, 1 HDMI to Oculus Rift VR Linux x7

Re: [PATCH v4 2/3] dt-bindings: panel: Add YAML schemas for the Ronbo RB070D30 panel

2019-04-23 Thread Thierry Reding
On Wed, Feb 20, 2019 at 09:21:55AM +0100, Maxime Ripard wrote: > The Ronbo RB070D30 panel is a 1024x600 MIPI-DSI panel. > > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml | 52 > > 1

Re: [PATCH 06/20] lib: Add video format information library

2019-04-23 Thread Thomas Zimmermann
Hi Am 17.04.19 um 09:54 schrieb Maxime Ripard: > Move the DRM formats API to turn this into a more generic image formats API > to be able to leverage it into some other places of the kernel, such as > v4l2 drivers. Here's some nitpicking: 'image_format_*' appears slightly vague; it could refer

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Koenig, Christian
Well you at least have to give me time till after the holidays to get going again :) Not sure exactly jet why we need patch number 5. And we should probably commit patch #1 and #2. Christian. Am 22.04.19 um 13:54 schrieb Grodzovsky, Andrey: > Ping for patches 3, new patch 5 and patch 6. > >

[PATCH] drm/vmwgfx: Fix dma API layer violation

2019-04-23 Thread Thomas Hellstrom
Remove the check for IOMMU presence since it was considered a layer violation. This means we have no reliable way to destinguish between coherent hardware IOMMU DMA address translations and incoherent SWIOTLB DMA address translations, which we can't handle. So always presume the former. This means

Re: [PATCH v5 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-04-23 Thread Paul Kocialkowski
Hi, On Mon, 2019-04-15 at 13:50 -0700, Eric Anholt wrote: > Paul Kocialkowski writes: > > > The binner bo is not required until the V3D is in use, so avoid > > allocating it at probe and do it on the first non-dumb BO allocation. > > Keep track of which clients are using the V3D and liberate

Re: [RFC][PATCH 5/5] libdrm: omap: Add DRM_RDWR flag to dmabuf export

2019-04-23 Thread Christian König
Am 23.04.19 um 12:26 schrieb Emil Velikov: On Sat, 20 Apr 2019 at 05:25, John Stultz wrote: From: Hemant Hariyani Allows mmap on dmabuf fd with MAP_SHARED and PROT_WRITE. This fixes boot failures caused due to mmap() returning error Commit message is quite meh - xf86-video-omap does not

Re: [PATCH 6/9] media: vsp1: Add support for missing 16-bit RGB555 formats

2019-04-23 Thread Jacopo Mondi
Hi Laurent, On Thu, Mar 28, 2019 at 09:07:20AM +0200, Laurent Pinchart wrote: > Add support for the V4L2_PIX_FMT_RGBA555, V4L2_PIX_FMT_RGBX555, > V4L2_PIX_FMT_ABGR555, V4L2_PIX_FMT_XBGR555, V4L2_PIX_FMT_BGRA555 and > V4L2_PIX_FMT_BGRX555 formats to the VSP driver. > > Signed-off-by: Laurent

Re: [PATCH 4/9] media: vsp1: Add support for missing 32-bit RGB formats

2019-04-23 Thread Laurent Pinchart
Hi Jacopo, On Tue, Apr 23, 2019 at 03:21:53PM +0200, Jacopo Mondi wrote: > On Thu, Apr 18, 2019 at 09:06:45AM +0300, Laurent Pinchart wrote: > > On Thu, Apr 04, 2019 at 07:39:05PM +0200, Jacopo Mondi wrote: > >> HI Laurent, > >> if you help me out understanding the bit swapping procedure in VSP

Re: [PATCH v5 3/6] drm/scheduler: rework job destruction

2019-04-23 Thread Grodzovsky, Andrey
On 4/22/19 8:48 AM, Chunming Zhou wrote: > Hi Andrey, > > static void drm_sched_process_job(struct dma_fence *f, struct > dma_fence_cb *cb) > { > ... >     spin_lock_irqsave(>job_list_lock, flags); >     /* remove job from ring_mirror_list */ >     list_del_init(_job->node); >

Re:[PATCH v5 3/6] drm/scheduler: rework job destruction

2019-04-23 Thread Zhou, David(ChunMing)
This patch is to fix deadlock between fence->lock and sched->job_list_lock, right? So I suggest to just move list_del_init(_job->node) from drm_sched_process_job to work thread. That will avoid deadlock described in the link. Original Message Subject: Re: [PATCH v5 3/6]

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Grodzovsky, Andrey
On 4/22/19 9:09 AM, Zhou, David(ChunMing) wrote: > +Monk. > > GPU reset is used widely in SRIOV, so need virtulizatino guy take a look. > > But out of curious, why guilty job can signal more if the job is already > set to guilty? set it wrongly? > > > -David It's possible that the job does

Re: [PATCH v5 3/6] drm/scheduler: rework job destruction

2019-04-23 Thread Grodzovsky, Andrey
On 4/23/19 10:44 AM, Zhou, David(ChunMing) wrote: This patch is to fix deadlock between fence->lock and sched->job_list_lock, right? So I suggest to just move list_del_init(_job->node) from drm_sched_process_job to work thread. That will avoid deadlock described in the link. Do you mean

Re: [PATCH] drm/panel: Remove duplicate header

2019-04-23 Thread Thierry Reding
On Sun, Apr 14, 2019 at 12:59:10AM +0530, Souptick Joarder wrote: > Remove duplicate header which is included twice. > > Signed-off-by: Souptick Joarder > --- > drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. Thierry

Re: [PATCH 2/6] PCI/P2PDMA: start with a whitelist for root complexes

2019-04-23 Thread Christian König
Am 19.04.19 um 19:13 schrieb Alex Deucher: On Thu, Apr 18, 2019 at 8:09 AM Christian König wrote: A lot of root complexes can still do P2P even when PCI devices don't share a common upstream bridge. Start adding a whitelist and allow P2P if both participants are attached to known good root

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Laurent Pinchart
On Tue, Apr 23, 2019 at 12:26:02PM +0200, Heiko Stuebner wrote: > Am Sonntag, 21. April 2019, 10:25:50 CEST schrieb Jonas Karlman: > > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual > >

Re: [RFC][PATCH 2/5] libdrm: amdgpu: Initialize unions with memset rather than "= {0}"

2019-04-23 Thread Christian König
Am 22.04.19 um 20:35 schrieb John Stultz: On Mon, Apr 22, 2019 at 7:59 AM Alex Deucher wrote: On Sat, Apr 20, 2019 at 12:25 AM John Stultz wrote: Clang complains when initializing unions using "= {0}" so instead use memset. Cc: Emil Velikov Cc: Sean Paul Cc: Alistair Strachan Cc: Marissa

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Grodzovsky, Andrey
OK, i will merge them into amd-staging drm-next. Andrey On 4/23/19 9:14 AM, Kazlauskas, Nicholas wrote: > Feel free to merge 1+2 since they don't really depend on any other work > in the series and they were previously reviewed. > > Nicholas Kazlauskas > > On 4/23/19 8:32 AM, Koenig, Christian

Re: [PATCH 7/9] drm: rcar-du: Add support for missing 32-bit RGB formats

2019-04-23 Thread Jacopo Mondi
Hi Laurent, On Thu, Mar 28, 2019 at 09:07:21AM +0200, Laurent Pinchart wrote: > Add support for the DRM_FORMAT_RGBA, DRM_FORMAT_RGBX, > DRM_FORMAT_ABGR and DRM_FORMAT_XBGR formats to the DU driver. > Those formats are only available on Gen3. > > Signed-off-by: Laurent Pinchart >

[PATCH] drm/fb-helper: Fix drm_fb_helper_firmware_config() NULL pointer deref

2019-04-23 Thread Noralf Trønnes
Non-atomic drivers like ast doesn't have connector->state set resulting in a NULL pointer deref: [ 29.609593] BUG: unable to handle kernel NULL pointer dereference at 0010 [ 29.609619] Call Trace: [ 29.609630] ? drm_helper_probe_single_connector_modes+0x27f/0x680 [

Re: [PATCH 1/2] dt-bindings: display: Add ETM0430G0DH6 bindings

2019-04-23 Thread Thierry Reding
On Tue, Feb 19, 2019 at 03:04:37PM +0100, Marek Vasut wrote: > Document the Emerging Display Technology Corp. (EDT) ETM0430G0DH6 > display, which is a 480x272 4.3" TFT display. > > Signed-off-by: Marek Vasut > Cc: Rob Herring > Cc: Jan Tuerk > Cc: Thierry Reding > Cc:

Re: [PATCH v7 0/2] drm/panel: simple: Add TFC S9700RTWV43TR-01B 800x480 panel support

2019-04-23 Thread Thierry Reding
On Fri, Mar 22, 2019 at 10:33:34AM +0200, Jyri Sarha wrote: > Changes since v6: > - Make power-supply a mandatory property > - Split binding to a separate patch > - Drop Tomi's reviewed-by, since the patch has changed quite a bit since his > review > > Previous round: >

Re: [PATCH v2 3/3] drm/panel: simple: Add Evervision VGG804821 panel support

2019-04-23 Thread Thierry Reding
On Tue, Apr 16, 2019 at 12:06:45PM +0200, Marco Felsch wrote: > Add support the Evervision VGG804821 800x480 5.0" WVGA TFT panel. > > Signed-off-by: Marco Felsch > --- > v2: > - pixel data should be driven on neg. edge since the panel applies > the data on positiv edge. > >

Re: [PATCH v2 1/3] dt-bindings: add vendor prefix for Evervision Electronics

2019-04-23 Thread Thierry Reding
On Tue, Apr 16, 2019 at 12:06:43PM +0200, Marco Felsch wrote: > Evervision Electronics is a panel manufacturer from Taipei. > http://www.evervisionlcd.com/index.php?lang=en > > Signed-off-by: Marco Felsch > Reviewed-by: Rob Herring > --- > Documentation/devicetree/bindings/vendor-prefixes.txt

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Grodzovsky, Andrey
On 4/23/19 8:32 AM, Koenig, Christian wrote: > Well you at least have to give me time till after the holidays to get > going again :) > > Not sure exactly jet why we need patch number 5. Probably you missed the mail where I pointed out a bug I found during testing - I am  reattaching the mail

Re: [PATCH 6/9] media: vsp1: Add support for missing 16-bit RGB555 formats

2019-04-23 Thread Laurent Pinchart
Hi Jacopo, On Tue, Apr 23, 2019 at 03:55:08PM +0200, Jacopo Mondi wrote: > On Thu, Mar 28, 2019 at 09:07:20AM +0200, Laurent Pinchart wrote: > > Add support for the V4L2_PIX_FMT_RGBA555, V4L2_PIX_FMT_RGBX555, > > V4L2_PIX_FMT_ABGR555, V4L2_PIX_FMT_XBGR555, V4L2_PIX_FMT_BGRA555 and > >

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Christian König
Am 23.04.19 um 16:12 schrieb Grodzovsky, Andrey: On 4/23/19 8:32 AM, Koenig, Christian wrote: Well you at least have to give me time till after the holidays to get going again :) Not sure exactly jet why we need patch number 5. Probably you missed the mail where I pointed out a bug I found

Re:[PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Zhou, David(ChunMing)
>3. If we have a ticket we grab a reference to the first BO on the LRU, drop >the LRU lock and try to grab the reservation lock with the ticket. The BO on LRU is already locked by cs user, can it be dropped here by DC user? and then DC user grab its lock with ticket, how does CS grab it again?

Re: [PATCH v5 4/6] drm/sched: Keep s_fence->parent pointer

2019-04-23 Thread Grodzovsky, Andrey
On 4/22/19 8:59 AM, Zhou, David(ChunMing) wrote: > +Monk to response this patch. > > > 在 2019/4/18 23:00, Andrey Grodzovsky 写道: >> For later driver's reference to see if the fence is signaled. >> >> v2: Move parent fence put to resubmit jobs. >> >> Signed-off-by: Andrey Grodzovsky >>

Re: [PATCH v3 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS

2019-04-23 Thread Thierry Reding
On Tue, Feb 26, 2019 at 09:55:19AM +0200, Peter Ujfalusi wrote: > Hi, > > Changes since v2: > - Added Reviewed-by from Rob to the binding patches > - Added help text to Kconfig (osd101t2587-53ts) > - Print the error values in dev_err/warn > - Added Reviewed-by from Sam to the osd101t2587-53ts

Re: [PATCH] Revert "drm/virtio: drop prime import/export callbacks"

2019-04-23 Thread Emil Velikov
On Tue, 23 Apr 2019 at 09:05, Gerd Hoffmann wrote: > > Hi, > > > > The DRI3 code extensively uses prime_handle_to_fd and > > > prime_fd_to_handle for self-import. > > The callbacks are not used for self-import. > Userspace converts from it's own handles to a dmabuf fd and vice-versa. I assumed

Re: [PATCH v5 04/12] drm/i915: Attach content type property

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 1:15 PM Ramalingam C wrote: > > On 2019-04-23 at 10:11:48 +0200, Daniel Vetter wrote: > > On Thu, Apr 18, 2019 at 02:27:57PM +0530, Ramalingam C wrote: > > > Attaches the content type property for HDCP2.2 capable connectors. > > > > > > Implements the update of content

Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Kazlauskas, Nicholas
Feel free to merge 1+2 since they don't really depend on any other work in the series and they were previously reviewed. Nicholas Kazlauskas On 4/23/19 8:32 AM, Koenig, Christian wrote: > Well you at least have to give me time till after the holidays to get > going again :) > > Not sure

[Bug 110478] AMDGPU error(failed to set mode: cannot allocate memory) when hdmi connected

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110478 --- Comment #3 from cmdr...@gmail.com --- (In reply to Michel Dänzer from comment #2) > Yeah, this is a kernel issue. There's only a small amount of VRAM available, > so the 5760x2160 framebuffer can't fit, and the kernel driver doesn't >

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Christian König
Well that's not so easy of hand. The basic problem here is that when you busy wait at this place you can easily run into situations where application A busy waits for B while B busy waits for A -> deadlock. So what we need here is the deadlock detection logic of the ww_mutex. To use this we

Re: [PATCH 2/3] drm/dp_mst: Expose build_mst_prop_path()

2019-04-23 Thread Ville Syrjälä
On Mon, Apr 22, 2019 at 07:56:27PM -0400, sunpeng...@amd.com wrote: > From: Leo Li > > To give identifiable attributes to MST DP aux devices, we can use the > MST relative address. Expose this function for later use. > > Signed-off-by: Leo Li > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 4

Re: [PATCH v2 03/12] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-04-23 Thread Noralf Trønnes
Den 23.04.2019 16.17, skrev Thomas Zimmermann: > Hi > > Am 07.04.19 um 18:52 schrieb Noralf Trønnes: >> It is generic code and having it in the helper will let other drivers >> benefit from it. >> >> One change was necessary assuming this to be true: >> INTEL_INFO(dev_priv)->num_pipes ==

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Paul Kocialkowski
Hi, On Tue, 2019-04-23 at 09:30 +0200, Daniel Vetter wrote: > On Sun, Apr 21, 2019 at 01:40:45AM +0300, Laurent Pinchart wrote: > > Hi Paul, > > > > On Thu, Apr 18, 2019 at 01:49:54PM +0200, Paul Kocialkowski wrote: > > > On Thu, 2019-04-18 at 11:02 +0200, Maxime Ripard wrote: > > > > On Thu,

[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

2019-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110481 --- Comment #2 from Christian König --- (In reply to baopeng from comment #0) > - if (p->ring->funcs->parse_cs || p->ring->funcs->patch_cs_in_place) { > + if (0) > If we don't delete, vce will be very slow. > > Is this the

Re: [PATCH 4/9] media: vsp1: Add support for missing 32-bit RGB formats

2019-04-23 Thread Jacopo Mondi
Hi Laurent, On Thu, Apr 18, 2019 at 09:06:45AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Thu, Apr 04, 2019 at 07:39:05PM +0200, Jacopo Mondi wrote: > > HI Laurent, > > if you help me out understanding the bit swapping procedure in VSP > > I would be more confident in saying I actually

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 4:28 PM Nicolas Dufresne wrote: > > Le mardi 23 avril 2019 à 14:33 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > On Tue, 2019-04-23 at 09:30 +0200, Daniel Vetter wrote: > > > On Sun, Apr 21, 2019 at 01:40:45AM +0300, Laurent Pinchart wrote: > > > > Hi Paul, > > > > >

Re: [PATCH] drm/panel: simple: Fix panel_simple_dsi_probe

2019-04-23 Thread Thierry Reding
On Tue, Feb 26, 2019 at 10:11:53AM +0200, Peter Ujfalusi wrote: > In case mipi_dsi_attach() fails remove the registered panel to avoid added > panel without corresponding device. > > Signed-off-by: Peter Ujfalusi > --- > drivers/gpu/drm/panel/panel-simple.c | 9 - > 1 file changed, 8

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Neil Armstrong
On 21/04/2019 10:25, Jonas Karlman wrote: > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual > address 0008 > [ 31.041671] pgd = 4d3c16f6 > [ 31.041673] [0008] *pgd= > [

Re: [PATCH v3 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS

2019-04-23 Thread Peter Ujfalusi
Hi Thierry, On 23/04/2019 14.55, Thierry Reding wrote: > On Tue, Feb 26, 2019 at 09:55:19AM +0200, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v2: >> - Added Reviewed-by from Rob to the binding patches >> - Added help text to Kconfig (osd101t2587-53ts) >> - Print the error values in

Re: [PATCH v3 0/2] Add writeback scaling

2019-04-23 Thread Liviu Dudau
On Tue, Apr 23, 2019 at 02:24:11PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2019 at 12:48 PM Ben Davis wrote: > > > > Add support for scaling on writeback. To do this add writeback_dest_w > > and writeback_dest_h as writeback connector properties to specify the > > desired output dimensions.

Re: [PATCH v3 0/2] Add writeback scaling

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 3:00 PM Liviu Dudau wrote: > > On Tue, Apr 23, 2019 at 02:24:11PM +0200, Daniel Vetter wrote: > > On Tue, Apr 23, 2019 at 12:48 PM Ben Davis wrote: > > > > > > Add support for scaling on writeback. To do this add writeback_dest_w > > > and writeback_dest_h as writeback

Re: [PATCH v5 1/6] drm/amd/display: wait for fence without holding reservation lock

2019-04-23 Thread Grodzovsky, Andrey
This series is on top of drm-misc because of panfrost and lima drovers which are missing form amd-staging-drm-next. Once i land it in drm-misc I will merge and p[ush it into drm-next. Andrey On 4/22/19 10:35 PM, Dieter Nützel wrote: > Hello Andrey, > > this series can't apply (brake on #3) on

[PATCH v6 2/4] drm/vc4: Check for V3D before binner bo alloc

2019-04-23 Thread Paul Kocialkowski
Check that we have a V3D device registered before attempting to allocate a binner buffer object. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_v3d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index

[PATCH v6 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-04-23 Thread Paul Kocialkowski
The binner BO is not required until the V3D is in use, so avoid allocating it at probe and do it on the first non-dumb BO allocation. Keep track of which clients are using the V3D and liberate the buffer when there is none left, using a kref. Protect the logic with a mutex to avoid race

[PATCH v6 0/4] drm/vc4: Binner BO management improvements

2019-04-23 Thread Paul Kocialkowski
Changes since v5: * Fix more locking mistakes; * Introduce get/put helpers; * Grabbed a reference when submitting an exec job with a binner slot. * Addressed misc comments. Changes since v4: * Used a kref on the binner bo instead of firstopen/lastclose; * Added a mutex to prevent race conditions;

[PATCH v6 1/4] drm/vc4: Reformat and the binner bo allocation helper

2019-04-23 Thread Paul Kocialkowski
In preparation for wrapping the binner bo allocation helper with put/get helpers, pass the vc4 dev directly and drop the vc4 prefix. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_v3d.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v6 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-23 Thread Paul Kocialkowski
Since the OOM interrupt directly deals with the binner bo, it doesn't make sense to try and handle it without a binner buffer registered. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_irq.c

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-04-23 Thread Paul Kocialkowski
Hi, On Tue, 2019-04-23 at 10:28 -0400, Nicolas Dufresne wrote: > Le mardi 23 avril 2019 à 14:33 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > On Tue, 2019-04-23 at 09:30 +0200, Daniel Vetter wrote: > > > On Sun, Apr 21, 2019 at 01:40:45AM +0300, Laurent Pinchart wrote: > > > > Hi Paul, > >

Re: [PATCH 1/3] drm/dp: Use non-cyclic idr

2019-04-23 Thread Ville Syrjälä
On Mon, Apr 22, 2019 at 07:56:26PM -0400, sunpeng...@amd.com wrote: > From: Leo Li > > In preparation for adding aux devices for DP MST, make the IDR > non-cyclic. That way, hotplug cycling MST devices won't needlessly > increment the minor version index. > > Signed-off-by: Leo Li I don't

Re:[PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Zhou, David(ChunMing)
do you mean fence timer? why not stop it as well when stopping sched for the reason of hw reset? Original Message Subject: Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled. From: "Grodzovsky, Andrey" To: "Zhou, David(ChunMing)"

Re: [PATCH v1.1 3/9] v4l: Add definitions for missing 16-bit RGB555 formats

2019-04-23 Thread Jacopo Mondi
Hi Laurent, On Thu, Apr 18, 2019 at 09:27:11AM +0300, Laurent Pinchart wrote: > The V4L2 API is missing the 16-bit RGB555 formats for the RGBA, RGBX, > ABGR, XBGR, BGRA and BGRX component orders. Add them, using the same > 4CCs as DRM. > > Signed-off-by: Laurent Pinchart > --- > Changes since

Re: [PATCH] [v7, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-04-23 Thread Thierry Reding
On Tue, Mar 26, 2019 at 03:09:33PM +0800, Jerry Han wrote: > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. > > V7: > - Add the information of the reviewer > - Remove unnecessary delays, The udelay_range code gracefully returns > without hitting the scheduler

Re: [PATCH v3 0/2] Add writeback scaling

2019-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2019 at 12:48 PM Ben Davis wrote: > > Add support for scaling on writeback. To do this add writeback_dest_w > and writeback_dest_h as writeback connector properties to specify the > desired output dimensions. > Then implement downscaling on writeback for Malidp-550 and Malidp-650

  1   2   >