[PATCH v7 8/9] drm: mediatek: adjust dsi and mipi_tx probe sequence

2019-09-19 Thread Jitao Shi
mtk_mipi_tx is the phy of mtk_dsi. mtk_dsi get the phy(mtk_mipi_tx) in probe(). So, mtk_mipi_tx init should be ahead of mtk_dsi. Or mtk_dsi will defer to wait mtk_mipi_tx probe done. Signed-off-by: Jitao Shi Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- 1 file changed,

[PATCH v7 9/9] drm/mediatek: add dphy reset after setting lanes number

2019-09-19 Thread Jitao Shi
Add dphy reset after setting lanes number to avoid dphy fifo effor. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index b02373b04848..8c2620ea18

[PATCH v3] drm/v3d: clean caches at the end of render jobs on request from user space

2019-09-19 Thread Iago Toral Quiroga
Extends the user space ioctl for CL submissions so it can include a request to flush the cache once the CL execution has completed. Fixes memory write violation messages reported by the kernel in workloads involving shader memory writes (SSBOs, shader images, scratch, etc) which sometimes also lead

Re: [PATCH] drm: two planes with the same zpos have undefined ordering

2019-09-19 Thread Pekka Paalanen
On Mon, 16 Sep 2019 09:19:09 + Simon Ser wrote: > > On Tue, 10 Sep 2019 11:20:16 + > > Simon Ser wrote: > > > > > On Tuesday, September 10, 2019 1:38 PM, Pekka Paalanen > > > wrote: > > > > > > > On Tue, 10 Sep 2019 10:09:55 + > > > > Simon Ser cont...@emersion.fr wrote: > > >

RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-19 Thread S, Srinivasan
Would the following be appropriate fix? if (connector || connector->base.status == connector_status_connected) { ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { DRM_ERROR("failed to update payload %d\n", ret);

Re: [PATCH v3] drm: two planes with the same zpos have undefined ordering

2019-09-19 Thread Pekka Paalanen
On Wed, 18 Sep 2019 16:33:47 + Simon Ser wrote: > Currently the property docs don't specify whether it's okay for two planes to > have the same zpos value and what user-space should expect in this case. > > The rule mentionned in the past was to disambiguate with object IDs. However > some d

[PATCH 5/9] [v10, 5/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V5: - Add the information of the reviewer (Sam) - Delete unnecessary header files #include (Sam) - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam) - ADD static, set_gpios function is not used ou

[PATCH] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Navid Emamdoost
In acp_hw_init there are some allocations that needs to be released in case of failure: 1- adev->acp.acp_genpd should be released if any allocation attemp for adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. 2- all of those allocations should be released if pm_genpd_add_device fails. Sig

[PATCH] drm/radeon: fix a potential NULL pointer dereference

2019-09-19 Thread Allen Pais
alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais --- drivers/gpu/drm/radeon/radeon_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/rad

[PATCH v6 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-19 Thread Cheng-Yi Chiang
Use two dai_links. One for HDMI and one for max98090. With this setup, audio can play to speaker and HDMI selectively. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/rockchip_max98090.c | 96 -- 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/sound/

[PATCH 1/9] [v10, 1/9] drm/panel:Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Add panel driver for it. Signed-off-by: Jerry Han --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig| 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-himax8279d.c | 593 +++ 4 files

Re: [PATCH] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Navid Emamdoost
Thanks Christian for the feedback, I'll send a v2. On Wed, Sep 18, 2019 at 12:31 PM Koenig, Christian wrote: > Am 18.09.19 um 18:09 schrieb Navid Emamdoost: > > In acp_hw_init there are some allocations that needs to be released in > > case of failure: > > > > 1- adev->acp.acp_genpd should be

[PATCH] drm/amdkfd: fix a potential NULL pointer dereference

2019-09-19 Thread Allen Pais
alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais --- drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd

[PATCH 2/9] [v10, 2/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V2: - Use SPDX identifier (Sam) - Use necessary header files replace drmP.h (Sam) - Delete unnecessary header files #include (Sam) - Specifies a GPIOs array to control the reset timing, instead of reading "dsi-reset-

Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Sven Van Asbroeck
On Wed, Sep 18, 2019 at 3:09 PM Navid Emamdoost wrote: > > i2s_pdata = kcalloc(3, sizeof(struct i2s_platform_data), GFP_KERNEL); > if (i2s_pdata == NULL) { > - kfree(adev->acp.acp_res); > - kfree(adev->acp.acp_cell); > - return -ENOMEM; > +

[PATCH 4/9] [v10, 4/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V4: - Frefix all function maes with boe_ (Sam) - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam) - Sort include lines alphabetically (Sam) - Fixed entries in the makefile must be sorted alphabetically

[PATCH 6/9] [v10, 6/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V6: - Add the information of the reviewer - Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek) - Merge the same data structures, like display_mod

[PATCH v6 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-09-19 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc/r

[PATCH 7/9] [v10, 7/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V7: - Modify communication address V6: - Add the information of the reviewer - Remove unnecessary delays, The udelay_range code gracefully returns without hitting the scheduler on a delay of 0. (Derek) - Merge the sa

[PATCH 3/9] [v10, 3/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V3: - Remove unnecessary delays in sending initialization commands (Jitao Shi) V2: - Use SPDX identifier (Sam) - Use necessary header files replace drmP.h (Sam) - Delete unnecessary header files #include (Sam) - Specifi

[PATCH 9/9] [v10, 9/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V9: - Adjust init code, make the format more concise - kill off default_off_cmds (Emil) - use mipi_dsi_dcs_set_display_{on,off} in their enable/disable callbacks. (Emil) - Adjusting the delay function (Emil) V8: - mo

[PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Navid Emamdoost
In acp_hw_init there are some allocations that needs to be released in case of failure: 1- adev->acp.acp_genpd should be released if any allocation attemp for adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. 2- all of those allocations should be released if pm_genpd_add_device fails. v2:

[PATCH 8/9] [v10, 8/9] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-09-19 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. V8: - modify PARENTHESIS_ALIGNMENT format (Sam) - use gpios are required API replace optional gpio API (Emil) V7: - Modify communication address V6: - Add the information of the reviewer - Remove unnecessary delays, The

[Bug 111667] gem_render_copy failing on CCS subtests

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111667 --- Comment #5 from Mika Kahola --- Created attachment 145430 --> https://bugs.freedesktop.org/attachment.cgi?id=145430&action=edit gem_render_copy --run-subtest y-tiled-ccs-to-linear Unfortunately, the rendercopy patches didn't help in case

[radeon-alex:amd-mainline-dkms-5.0 3698/3724] include/kcl/kcl_fence.h:142:20: error: redefinition of 'dma_fence_set_error'

2019-09-19 Thread kbuild test robot
Hi Flora, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: a5784d79d1577c00e6e81f892cde52593546a5f4 [3698/3724] drm/amdkcl: drop kcl_dma_fence_set_error config: x86_64-allyes

Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Koenig, Christian
Am 18.09.19 um 21:05 schrieb Navid Emamdoost: > In acp_hw_init there are some allocations that needs to be released in > case of failure: > > 1- adev->acp.acp_genpd should be released if any allocation attemp for > adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. > 2- all of those allocati

Re: [PATCH v4 6/9] drm: rcar-du: crtc: Enable and disable CMMs

2019-09-19 Thread Kieran Bingham
Hi Laurent, / Jacopo On 19/09/2019 00:23, Laurent Pinchart wrote: > Hello, > > On Thu, Sep 12, 2019 at 10:19:30AM +0100, Kieran Bingham wrote: >> On 12/09/2019 09:07, Jacopo Mondi wrote: >>> On Wed, Sep 11, 2019 at 07:40:27PM +0100, Kieran Bingham wrote: On 06/09/2019 14:54, Jacopo Mondi wro

Re: [PATCH] drm: two planes with the same zpos have undefined ordering

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 9:18 AM Pekka Paalanen wrote: > > On Mon, 16 Sep 2019 09:19:09 + > Simon Ser wrote: > > > > On Tue, 10 Sep 2019 11:20:16 + > > > Simon Ser wrote: > > > > > > > On Tuesday, September 10, 2019 1:38 PM, Pekka Paalanen > > > > wrote: > > > > > > > > > On Tue, 10 Sep

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #116 from tempel.jul...@gmail.com --- Ahzo's patch is now merged in drm-next-5.5-wip branch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.5-wip&id=f659bb6dae58c113805f92822e4c16ddd3156b79 Big thanks for including! -

Re: [PATCH v4 3/9] drm: rcar-du: Add support for CMM

2019-09-19 Thread Kieran Bingham
Hi Jacopo, Laurent, On 18/09/2019 23:55, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Fri, Sep 06, 2019 at 03:54:30PM +0200, Jacopo Mondi wrote: >> Add a driver for the R-Car Display Unit Color Correction Module. >> >> In most of Gen3 SoCs, each DU output channel is

Re: [PATCH] drm: two planes with the same zpos have undefined ordering

2019-09-19 Thread Pekka Paalanen
On Thu, 19 Sep 2019 10:18:04 +0200 Daniel Vetter wrote: > On Thu, Sep 19, 2019 at 9:18 AM Pekka Paalanen wrote: > > ... > > Right, and we are suffering from that confusion already. Should > > userspace use ID order if zpos property is not there or not? I have no > > idea. > > Nope. I think

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 --- Comment #28 from Pierre-Eric Pelloux-Prayer --- (In reply to Brian Schott from comment #21) > As far as the issue about desktop corruption and lockup on login requiring > the AMD_DEBUG=nodcc workaround: > > b563460b494e9228cf5bb1aa4a70ac24

Re: [PATCH] drm: two planes with the same zpos have undefined ordering

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 11:02 AM Pekka Paalanen wrote: > > On Thu, 19 Sep 2019 10:18:04 +0200 > Daniel Vetter wrote: > > > On Thu, Sep 19, 2019 at 9:18 AM Pekka Paalanen wrote: > > > > > ... > > > > Right, and we are suffering from that confusion already. Should > > > userspace use ID order if z

[PATCH v3 06/11] drm/ttm: factor out ttm_bo_mmap_vma_setup

2019-09-19 Thread Gerd Hoffmann
Factor out ttm vma setup to a new function. Reduces code duplication a bit. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 46 + 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/t

dri-devel@lists.freedesktop.org

2019-09-19 Thread Gerd Hoffmann
Wire up the new drm_gem_ttm_mmap() helper function, use generic drm_gem_mmap for &fops.mmap and delete dead drm_vram_mm_file_operations_mmap(). Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 9 +-- drivers/gpu/drm/drm_gem_vram_helper

[PATCH v3 00/11] drm: rework mmap() workflow

2019-09-19 Thread Gerd Hoffmann
Add mmap callback to struct drm_gem_object_funcs, which is supposed to handle the vma setup. It will be used by both normal fops->mmap (via drm_gem_mmap_obj()) and prime mmap (via drm_gem_prime_mmap()). For starters the shmem and vram helpers are switched over to the new workflow, to show things

[PATCH v3 03/11] drm/shmem: drop VM_DONTDUMP

2019-09-19 Thread Gerd Hoffmann
Not obvious why this is needed. According to Deniel Vetter this is most likely a historic artefact dating back to the days where drm drivers exposed hardware registers as mmap'able gem objects, to avoid dumping touching those registers. shmem gem objects surely don't need that ... Signed-off-by:

[PATCH v3 04/11] drm/shmem: drop VM_IO

2019-09-19 Thread Gerd Hoffmann
VM_IO is wrong here, shmem uses normal ram not io memory. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 6efedab1501

dri-devel@lists.freedesktop.org

2019-09-19 Thread Gerd Hoffmann
Switch gem shmem helper to the new mmap() workflow, from &gem_driver.fops.mmap to &drm_gem_object_funcs.mmap. v2: Fix vm_flags and vm_page_prot handling. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_shmem_helper.h | 6 ++ drivers/gpu/drm/drm_gem_shmem_helper.c | 28 +-

[PATCH v3 01/11] drm: add mmap() to drm_gem_object_funcs

2019-09-19 Thread Gerd Hoffmann
drm_gem_object_funcs->vm_ops alone can't handle everything which needs to be done for mmap(), tweaking vm_flags for example. So add a new mmap() callback to drm_gem_object_funcs where this code can go to. Note that the vm_ops field is not used in case the mmap callback is present, it is expected

[PATCH v3 07/11] drm/ttm: rename ttm_fbdev_mmap

2019-09-19 Thread Gerd Hoffmann
Rename ttm_fbdev_mmap to ttm_bo_mmap_obj. Move the vm_pgoff sanity check to amdgpu_bo_fbdev_mmap (only ttm_fbdev_mmap user in tree). The ttm_bo_mmap_obj function can now be used to map any buffer object. This allows to implement &drm_gem_object_funcs.mmap in gem ttm helpers. Signed-off-by: Gerd

[PATCH v3 10/11] drm/vram: drop verify_access

2019-09-19 Thread Gerd Hoffmann
Not needed any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index bc37c4651766

[PATCH v3 11/11] drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS

2019-09-19 Thread Gerd Hoffmann
Not needed any more because we don't have vram specific fops any more. DEFINE_DRM_GEM_FOPS() can be used instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 18 -- drivers/gpu/drm/ast/ast_drv.c

[PATCH v3 08/11] drm/ttm: add drm_gem_ttm_mmap()

2019-09-19 Thread Gerd Hoffmann
Add helper function to mmap ttm bo's using &drm_gem_object_funcs.mmap(). Note that with this code path access verification is done by drm_gem_mmap() (which calls drm_vma_node_is_allowed(()). The &ttm_bo_driver.verify_access() callback is is not used. Signed-off-by: Gerd Hoffmann --- include/drm

[PATCH v3 05/11] drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS

2019-09-19 Thread Gerd Hoffmann
DEFINE_DRM_GEM_SHMEM_FOPS is identical to DEFINE_DRM_GEM_FOPS now, drop it. Signed-off-by: Gerd Hoffmann Acked-by: Rob Herring --- include/drm/drm_gem_shmem_helper.h | 26 - drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/panfrost/panfrost_drv.c |

[Bug 111747] [CI][DRMTIP] igt@ - incomplete - Jenkins gives up

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111747 Chris Wilson changed: What|Removed |Added Summary|[CI][DRMTIP]|[CI][DRMTIP] igt@ - |i

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-09-19 Thread Xin Ji
On Thu, Sep 19, 2019 at 08:57:12AM +0200, Neil Armstrong wrote: > Hi, > > On 19/09/2019 08:55, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > > > You can add support to your board with bind

Re: [Intel-gfx] [PATCH 10/19] drm/i915: Make .modeset_calc_cdclk() mandatory

2019-09-19 Thread Maarten Lankhorst
Op 08-07-2019 om 14:53 schreef Ville Syrjala: > From: Ville Syrjälä > > While not all platforms allow us to change the cdclk frequency > we should still verify that the fixed cdclk frequency isn't > too low. To that end let's cook up a .modeset_calc_cdclk() > implementation that only does the min_

Re: [Intel-gfx] [PATCH 08/19] drm/i915: Stop using drm_atomic_helper_check_planes()

2019-09-19 Thread Maarten Lankhorst
Op 08-07-2019 om 14:53 schreef Ville Syrjala: > From: Ville Syrjälä > > We need to insert stuff between the plane and crtc .atomic_check() > drm_atomic_helper_check_planes() doesn't allow us to do that so > stop using it and hand roll the loops instead. > > Signed-off-by: Ville Syrjälä > --- > .

Re: [PATCH v3 06/11] drm/ttm: factor out ttm_bo_mmap_vma_setup

2019-09-19 Thread Thomas Zimmermann
Hi Am 19.09.19 um 12:02 schrieb Gerd Hoffmann: > Factor out ttm vma setup to a new function. > Reduces code duplication a bit. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/ttm/ttm_bo_vm.c | 46 + > 1 file changed, 24 insertions(+), 22 deletions(-) >

Re: [PATCH v3 07/11] drm/ttm: rename ttm_fbdev_mmap

2019-09-19 Thread Thomas Zimmermann
Hi Am 19.09.19 um 12:02 schrieb Gerd Hoffmann: > Rename ttm_fbdev_mmap to ttm_bo_mmap_obj. Move the vm_pgoff sanity > check to amdgpu_bo_fbdev_mmap (only ttm_fbdev_mmap user in tree). > > The ttm_bo_mmap_obj function can now be used to map any buffer object. > This allows to implement &drm_gem_o

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-19 Thread Keiichi Watanabe
On Fri, Sep 13, 2019 at 8:05 PM Gerd Hoffmann wrote: > > Hi, > > > > No. DMA master address space in virtual machines is pretty much the > > > same it is on physical machines. So, on x86 without iommu, identical > > > to (guest) physical address space. You can't re-define it like that. > > >

Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-19 Thread Ville Syrjälä
On Thu, Sep 19, 2019 at 07:23:30AM +, S, Srinivasan wrote: > Would the following be appropriate fix? > > if (connector || connector->base.status == > connector_status_connected) { > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { >

Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-19 Thread Jani Nikula
On Wed, 18 Sep 2019, Manasi Navare wrote: > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasa...@intel.com wrote: >> From: Srinivasan S >> >> This patch avoids DP MST payload error message in dmesg, as it is trying >> to read the payload from the disconnected DP MST device. After the unplug >>

[Bug 111750] Navi10 GPU boot bug: Failed to pin framebuffer with error -12

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111750 Bug ID: 111750 Summary: Navi10 GPU boot bug: Failed to pin framebuffer with error -12 Product: DRI Version: DRI git Hardware: All OS: Linux (All)

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-19 Thread Ondřej Jirman
On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > > Hi, > > > > On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Sun, Sep 15, 2019 at 12:03:37AM +0200, meg...@megous.com wrote: > >

Re: [PATCH v2] i915: intel_dp_aux_backlight: Fix max backlight calculations

2019-09-19 Thread Lisovskiy, Stanislav
On Wed, 2019-07-10 at 17:43 -0700, Furquan Shaikh wrote: > Max backlight value for the panel was being calculated using byte > count i.e. 0x if 2 bytes are supported for backlight brightness > and 0xff if 1 byte is supported. However, EDP_PWMGEN_BIT_COUNT > determines the number of active contr

[PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-19 Thread Rohan Garg
DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications. Changes in v2: - Hoist the IOCTL up into the drm_driver framework Signed-off-by: Rohan Garg --- drivers/gpu/drm/drm_gem.c | 64 ++ drivers/gpu/dr

Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

2019-09-19 Thread Ondřej Jirman
On Thu, Sep 19, 2019 at 02:20:58PM +0200, megous hlavni wrote: > On Wed, Sep 18, 2019 at 10:16:17PM +0200, Maxime Ripard wrote: > > On Wed, Sep 18, 2019 at 05:23:09PM +0200, Ondřej Jirman wrote: > > > Hi, > > > > > > On Wed, Sep 18, 2019 at 04:17:34PM +0200, Maxime Ripard wrote: > > > > Hi, > > > >

[PATCH] drm: tweak drm_print_bits()

2019-09-19 Thread Gerd Hoffmann
There is little reason for the from/to logic, printing a subset of the bits can be done by simply shifting/masking value if needed. Also use for_each_set_bit(). Suggested-by: Jani Nikula Signed-off-by: Gerd Hoffmann --- include/drm/drm_print.h | 5 ++--- drivers/gpu/drm/drm_gem_t

[PATCH] video/hdmi: Fix AVI bar unpack

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä The bar values are little endian, not big endian. The pack function did it right but the unpack got it wrong. Fix it. Cc: sta...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: Martin Bugge Cc: Hans Verkuil Cc: Thierry Reding Cc: Mauro Carvalho Chehab Fixes: 2c676f378

[PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable

2019-09-19 Thread Mihail Atanassov
When initially turning a crtc on, drm_reset_vblank_timestamp will set the vblank timestamp to 0 for any driver that doesn't provide a ->get_vblank_timestamp() hook. Unfortunately, the FLIP_COMPLETE event depends on that timestamp, and the only way to regenerate a valid one is to have vblank interr

Re: [PATCH] drm/amd/display: hide an unused variable

2019-09-19 Thread Harry Wentland
On 2019-09-18 3:53 p.m., Arnd Bergmann wrote: > Without CONFIG_DEBUG_FS, we get a warning for an unused > variable: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6020:33: error: > unused variable 'source' [-Werror,-Wunused-variable] > > Hide the variable in an #ifdef like its o

[Bug 99955] [r600g] GPU load always displayed at 100% with GALLIUM_HUD=GPU-load

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99955 --- Comment #8 from Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- Hi. Just a note about the migration process: Bugzilla migration to https://gitlab.freedesktop.org/mesa/mesa/issues/598 is failing to preserve newline characters

[radeon-alex:amd-mainline-dkms-5.0 3697/3724] include/drm/drm_fb_helper.h:641:1: sparse: the previous one is here

2019-09-19 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: f460c248a3f0bca3a875602cf40693de672485c4 [3697/3724] drm/amd/autoconf: refactor dma_fence header check reproduce: # apt-get install sparse # sparse v

RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-19 Thread S, Srinivasan
Then it's better that, could we change it to DRM_DEBUG_KMS("failed to update payload %d\n", ret); instead of DRM_ERROR("failed to update payload %d\n", ret);, without any connector status check, would that be fine? Regards, -Original Message- From: Ville Syrjälä Sent: Thursday, Septemb

[PATCH v7 2/4] ASoC: rockchip-max98090: Add description for rockchip,hdmi-codec

2019-09-19 Thread Cheng-Yi Chiang
Add support for HDMI codec in rockchip-max98090. Let user specify HDMI device node in DTS so machine driver can find hdmi-codec device node for codec DAI. Signed-off-by: Cheng-Yi Chiang --- Documentation/devicetree/bindings/sound/rockchip-max98090.txt | 2 ++ 1 file changed, 2 insertions(+) dif

[PATCH v7 4/4] ASoC: rockchip_max98090: Add HDMI jack support

2019-09-19 Thread Cheng-Yi Chiang
In machine driver, create a jack and let hdmi-codec report jack status. Signed-off-by: Cheng-Yi Chiang --- sound/soc/rockchip/Kconfig | 3 ++- sound/soc/rockchip/rockchip_max98090.c | 20 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/soc/r

Re: [PATCH v5 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-09-19 Thread Andrzej Hajda
On 14.09.2019 18:11, Guido Günther wrote: > Hi Andrzej, > thanks for having a look! > > On Fri, Sep 13, 2019 at 11:31:43AM +0200, Andrzej Hajda wrote: >> On 09.09.2019 04:25, Guido Günther wrote: >>> This adds initial support for the NWL MIPI DSI Host controller found on >>> i.MX8 SoCs. >>> >>> It

Re: [PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-19 Thread Thomas Zimmermann
Hi Am 19.09.19 um 14:53 schrieb Rohan Garg: > DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it > easier to debug issues in userspace applications. > > Changes in v2: > - Hoist the IOCTL up into the drm_driver framework > > Signed-off-by: Rohan Garg > --- > drivers/gpu/drm/drm_gem

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Ayan Halder
On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: Hi All, Thanks for your suggestions. > Hi Liviu, > > On Wed, 18 Sep 2019 at 13:04, Liviu Dudau wrote: > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone wrote: > > > I totally agree. Framebuffers aren't about the underlying m

[PATCH 2/5] backlight: pwm_bl: eliminate a 64/32 division

2019-09-19 Thread Rasmus Villemoes
lightness*1000 is nowhere near overflowing 32 bits, so we can just use an ordinary 32/32 division, which is much cheaper than the 64/32 done via do_div(). Signed-off-by: Rasmus Villemoes --- drivers/video/backlight/pwm_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH 4/5] backlight: pwm_bl: switch to power-of-2 base for fixed-point math

2019-09-19 Thread Rasmus Villemoes
Using a power-of-2 instead of power-of-10 base makes the computations much cheaper. 2^16 is safe; retval never becomes more than 2^48 + 2^16/2. On a 32 bit platform, the very expensive 64/32 division at the end of cie1931() instead becomes essentially free (a shift by 32 is just a register rename).

[PATCH 1/5] backlight: pwm_bl: fix cie1913 comments and constant

2019-09-19 Thread Rasmus Villemoes
The "break-even" point for the two formulas is L==8, which is also what the code actually implements. [Incidentally, at that point one has Y=0.008856, not 0.08856]. Moreover, all the sources I can find say the linear factor is 903.3 rather than 902.3, which makes sense since then the formulas agre

[PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-09-19 Thread Rasmus Villemoes
The scheduler uses a (currently private) fixed_power_int() in its load average computation for computing powers of numbers 0 < x < 1 expressed as fixed-point numbers, which is also what we want here. But that requires the scale to be a power-of-2. We could (and a following patch will) change to us

Re: [PATCH] drm: tweak drm_print_bits()

2019-09-19 Thread Jani Nikula
On Thu, 19 Sep 2019, Gerd Hoffmann wrote: > There is little reason for the from/to logic, printing a subset of > the bits can be done by simply shifting/masking value if needed. > > Also use for_each_set_bit(). Oh, I don't know why I stumbled upon and reviewed a patch that had already been merged

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 4:03 PM Ayan Halder wrote: > > On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: > > Hi All, > Thanks for your suggestions. > > > Hi Liviu, > > > > On Wed, 18 Sep 2019 at 13:04, Liviu Dudau wrote: > > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone wro

Re: [PATCH v2 2/3] drm: Measure Self Refresh Entry/Exit times to avoid thrashing

2019-09-19 Thread Sean Paul
On Wed, Sep 18, 2019 at 04:07:29PM -0400, Sean Paul wrote: > From: Sean Paul > > Currently the self refresh idle timer is a const set by the crtc. This > is fine if the self refresh entry/exit times are well-known for all > panels used on that crtc. However panels and workloads can vary quite a >

[PULL] drm-intel-next-fixes

2019-09-19 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2019-09-19: - Extend old HSW workaround to fix some GPU hangs on Haswell GT2 - Fix return error code on GEM mmap. - White list a chicken bit register for push constants legacy mode on Mesa - Fix resume issue related to GGTT restore - Remove incorr

[PATCH 2/3] drm/atomic: Pimp the debugs for scaling fails

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä When the calculate scaling factors are out of range let's print out the calculated value and the min/max. Should make life a bit less confusing when decoding failure logs. I decided to print them in decimal rather than hex. Not sure which people prefer but maybe this is less

[PATCH 1/3] drm/rect: Return scaling factor and error code separately

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä We may want to dump out the calculated scaling factor(s) when they exceed the limits. To achieve that we need to return the error code and scaling factor separately. Side note: the code in dpu_plane_validate_multirect_v2() looks rather dubious on account of it not using fixed

[PATCH 3/3] drm/atomic-helper: Improve drm_atomic_helper_check_plane_state() debugs

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä Dump out the plane/crtc id/name in the failure debug messages. Makes a bit easier to figure out which plane exactly has failed when you have tons of them. Cc: Sean Paul Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 9 +++-- 1 file changed, 7 in

[RFC PATCH v2 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-09-19 Thread Artur Świgoń
From: Artur Świgoń This patch improves code readability by changing the following construct: >if (cond) >goto passive; >foo(); >goto out; >passive: >bar(); >out: into this: >if (cond) >bar(); >else >foo(); Signed-off-by: Artur Świgoń --- drive

[RFC PATCH v2 07/11] interconnect: Relax condition in apply_constraints()

2019-09-19 Thread Artur Świgoń
From: Artur Świgoń The exynos-bus devfreq driver is extended with interconnect functionality by a subsequent patch. This patch removes a check from the interconnect framework that prevents interconnect from working on exynos-bus, in which every bus is a separate interconnect provider. Signed-off

[RFC PATCH v2 11/11] drm: exynos: mixer: Add interconnect support

2019-09-19 Thread Artur Świgoń
From: Marek Szyprowski This patch adds interconnect support to exynos-mixer. Please note that the mixer works the same as before when CONFIG_INTERCONNECT is 'n'. Co-developed-by: Artur Świgoń Signed-off-by: Marek Szyprowski Signed-off-by: Artur Świgoń --- drivers/gpu/drm/exynos/exynos_mixer.

[RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect

2019-09-19 Thread Artur Świgoń
The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect capabilities started as a response to the issue referenced in [3]. The patches can be subdivided into four logical groups: (a) Refactoring the existing

[PATCH] video: ocfb: Use devm_platform_ioremap_resource() in ocfb_probe()

2019-09-19 Thread Markus Elfring
From: Markus Elfring Date: Thu, 19 Sep 2019 16:26:56 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/ocfb.c | 9 + 1 file changed, 1 insertion

Re: [PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable

2019-09-19 Thread Mihail Atanassov
On Thursday, 19 September 2019 14:30:02 BST Mihail Atanassov wrote: > When initially turning a crtc on, drm_reset_vblank_timestamp will > set the vblank timestamp to 0 for any driver that doesn't provide > a ->get_vblank_timestamp() hook. > > Unfortunately, the FLIP_COMPLETE event depends on that

Re: [PATCH] drm/msm: include linux/sched/task.h

2019-09-19 Thread Jordan Crouse
On Wed, Sep 18, 2019 at 09:57:07PM +0200, Arnd Bergmann wrote: > Without this header file, compile-testing may run into a missing > declaration: > > drivers/gpu/drm/msm/msm_gpu.c:444:4: error: implicit declaration of function > 'put_task_struct' [-Werror,-Wimplicit-function-declaration] > > Fixe

[PATCH] video: pxafb: Use devm_platform_ioremap_resource() in pxafb_probe()

2019-09-19 Thread Markus Elfring
From: Markus Elfring Date: Thu, 19 Sep 2019 16:51:38 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/pxafb.c | 10 +- 1 file changed, 1 insert

Re: [PATCH] drm: damage_helper: Fix race checking plane->state->fb

2019-09-19 Thread Sean Paul
On Thu, Sep 05, 2019 at 12:41:27PM +0200, Daniel Vetter wrote: > On Wed, Sep 4, 2019 at 10:29 PM Sean Paul wrote: > > > > From: Sean Paul > > > > Since the dirtyfb ioctl doesn't give us any hints as to which plane is > > scanning out the fb it's marking as damaged, we need to loop through > > pla

Re: [PATCH v7 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-19 Thread Jernej Škrabec
Hi! Dne četrtek, 19. september 2019 ob 15:54:49 CEST je Cheng-Yi Chiang napisal(a): > Use two dai_links. One for HDMI and one for max98090. > With this setup, audio can play to speaker and HDMI selectively. > > Signed-off-by: Cheng-Yi Chiang > --- > .../boot/dts/rk3288-veyron-analog-audio.dtsi

[PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Chris Wilson
It is expected that processes will pass dma-buf fd between drivers, and only using the fd themselves for mmaping and synchronisation ioctls. However, it may be convenient for an application to read/write into the dma-buf, for instance a test case to check the internal dma_buf->ops->kmap interface.

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Ayan Halder
On Thu, Sep 19, 2019 at 04:10:42PM +0200, Daniel Vetter wrote: > On Thu, Sep 19, 2019 at 4:03 PM Ayan Halder wrote: > > > > On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: > > > > Hi All, > > Thanks for your suggestions. > > > > > Hi Liviu, > > > > > > On Wed, 18 Sep 2019 at 13:04, L

Re: [PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 5:09 PM Chris Wilson wrote: > > It is expected that processes will pass dma-buf fd between drivers, and > only using the fd themselves for mmaping and synchronisation ioctls. > However, it may be convenient for an application to read/write into the > dma-buf, for instance a

[PATCH v3 3/3] drm: Add self_refresh_state debugfs entry

2019-09-19 Thread Sean Paul
From: Sean Paul This patch adds a debugfs entry to surface the entry and exit times as well as the calculated delay. Suggested-by: Daniel Vetter Signed-off-by: Sean Paul Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190918200734.149876-3-s...@poorly.run Changes in v2: - Added t

Re: [PATCH v3 3/3] drm: Add self_refresh_state debugfs entry

2019-09-19 Thread Sean Paul
On Thu, Sep 19, 2019 at 11:33:58AM -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds a debugfs entry to surface the entry and exit times as > well as the calculated delay. > > Suggested-by: Daniel Vetter > Signed-off-by: Sean Paul > Link to v2: > https://patchwork.freedesktop.org/

[pull] amdgpu drm-fixes-5.4

2019-09-19 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.4. The following changes since commit 945b584c94f8c665b2df3834a8a6a8faf256cd5f: Merge branch 'linux-5.4' of git://github.com/skeggsb/linux into drm-next (2019-09-17 16:31:34 +1000) are available in the Git repository at: git://people.freedesktop.org/~agd

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Alex Deucher
On Wed, Sep 18, 2019 at 8:04 AM Liviu Dudau wrote: > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone wrote: > > Hi all, > > Hi, > > > > > On Tue, 17 Sep 2019 at 13:53, Daniel Vetter wrote: > > > On Mon, Sep 09, 2019 at 01:42:53PM +, Ayan Halder wrote: > > > > Let us ignore how the pr

Re: [PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Chris Wilson
Quoting Daniel Vetter (2019-09-19 16:28:41) > On Thu, Sep 19, 2019 at 5:09 PM Chris Wilson wrote: > > > > It is expected that processes will pass dma-buf fd between drivers, and > > only using the fd themselves for mmaping and synchronisation ioctls. > > However, it may be convenient for an applic

  1   2   >