Re: [E1000-devel] AF_XDP zero copy not supported in 2.9.21 driver

On Wed, 2019-09-18 at 11:27 +, Andriy Korud wrote: > Hi, > > we are developing system heavy using eBPF programs and AF_XDP and > noticed something that looks like regression. > > > In my setup I have system with 2 NICs: XXV710 and X722, kernel 5.2.1. > > > Driver version 2.8.20-k (packed

Re: [E1000-devel] e1000e-x.x.x.x driver update

On Thu, 2019-07-11 at 14:24 +0300, Joseph Lifshitz wrote: > Hi, > I'm an programmer working at motorola solutions ltd. > We have been working on ADLINK cPCI-6525 board and used e1000e-1.5.1 > driver > with Ubuntu 12.04 and it worked fine. Wow, super old driver with a very old OS. > We would like

Re: [E1000-devel] Out of tree support

On Thu, 2019-07-04 at 00:53 -0400, Joseph Wiggins wrote: > Is it not possible to just create a folder and insert the file into > the > location it is supposed to be? IT would then be added to the tree > would it > not? Any help would be appriciated. I cant donate until I generate > cash > flow

Re: [E1000-devel] Testing XDP with 82576GB Gigabit Controller

On Fri, 2019-01-11 at 15:40 +, Dejan Rebraca wrote: > Hello, > > I am wondering if it is possible to test XDP with 82576 Gigabit > controller family considering that: > > * There is no XDP support in igb driver. > * There is XDP support in ixgbe driver, but the driver is not >

Re: [E1000-devel] The i40iw driver and flavors of I40E device

On Fri, 2018-10-12 at 10:23 +0300, Kevin Wilson wrote: > My question is about the i40eiw driver: > https://elixir.bootlin.com/linux/latest/source/drivers/infiniband/hw/i40iw > > There are different flavors of I40E devices, like I40E 10GB, I40E > 25GB, I40E100GB, etc. > Does the i40eiw support

Re: [E1000-devel] [PATCH] igb: CPU0 latency and updating statistics

On Wed, 2018-08-01 at 07:29 +, JABLONSKY Jan wrote: > The Watchdog workqueue in igb driver is scheduled every 2s for each > network interface. That includes updating a statistics protected by > spinlock. Function igb_update_stats in this case will be protected > against preemption.

Re: [E1000-devel] e1000 driver compile -- modinfo/lspci basicsf

On Tue, 2018-04-24 at 16:33 +, Dan Zulaica wrote: > Yes, > > I see what you mean. Using lspci -nn -v I see 8086:1502. Don has already explained the difference in the different drivers, thanks Don. I also wanted to mention that the big green download button will always go to the last driver

Re: [E1000-devel] [e1000-devel@lists.sourceforge.net] x540 / 82599 IPsec offload - Linux ixgbe driver

On Wed, 2018-01-03 at 09:21 -0800, Shannon Nelson wrote: > As Don mentioned below, I've forwarded the patches to Intel's git > tree > and they are currently under review and test with the Intel folks. > I > don't know their current progress, but I hope to see the patches > pushed > into

Re: [E1000-devel] Question on i40e PCIe relaxed ordering (RO)

On Wed, 2016-06-29 at 13:18 -0700, Greg wrote: > On Wed, 2016-06-29 at 13:05 -0700, tndave wrote: > > Hi, > >  > > Running iperf tcp test on 2 sparc systems with i40e connected back to > > back, I see huge number of 'port.rx_dropped' (on iperf server). Based > on > > past experience with ixgbe,

Re: [E1000-devel] [Intel-wired-lan] Kernel panic on i40e when connected back to back

On Tue, 2016-05-17 at 10:02 -0700, Alexander Duyck wrote: > The below kernel trace is seen on my system when I have it connected > back to back with another i40e and power on the link partner: > > ahduyck-xeon-server login: [ 1584.339589] BUG: unable to handle kernel > NULL pointer dereference at

Re: [E1000-devel] [Intel-wired-lan] e1000e driver - version 3.3.3

On Tue, 2016-01-26 at 11:48 +0100, Szymon Tokarski wrote: > Hello, > > I'm trying to download e1000e-3.3.3.tar.gz driver, but file is > missing. > > I need I219V support. > Can you fix it? First adding the required mailing list and removing the

Re: [E1000-devel] [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave

On Thu, 2015-12-31 at 13:04 +0800, zyjzyj2...@gmail.com wrote: > Thanks for the suggestions from Rustad, Mark D. > According to his suggestions, the logs and source code are > simplified. I find it funny that this email (no patch) is got the correct subject, yet the updated patch you sent does

Re: [E1000-devel] [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface

here, so that we can follow how you got to this point.  This helpful for the reviewers (and me, the maintainer).  For example: v2: dropped the "else" case of "if" statement, based on feedback from     Jeff Kirsher v3: changed the if statement to simply return when the link speed is     un

Re: [E1000-devel] [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex

On Wed, 2015-12-23 at 14:46 +0800, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > In X540 NIC, there is a time span between reporting "link on" and > getting the speed and duplex. To a bonding driver in 802.3ad mode, > this time span will make it not work well if the

Re: [E1000-devel] [PATCH net-next] ixgbe support for ethtool set_rxfh

On Wed, 2015-06-24 at 15:21 +0200, Tom Barbette wrote: Allows to change the rxfh key and/or indiriection table using ethtool interface Signed-off-by: Tom Barbette tom.barbe...@ulg.ac.be --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 +

Re: [E1000-devel] i40e driver question

On Wed, 2015-06-10 at 18:57 -0400, Alpesh Patel wrote: Hi Jeffrey, I found your name from lwn.net posting. I am trying to use the X710 nic and am using the i40e driver Is that the right driver for that nic? Yes. I have added e1000-devel mailing list (as well as a couple of i40e

Re: [E1000-devel] Porting i40e to Linux 4.0

On Tue, 2015-05-19 at 10:23 +0200, Arthur Gautier wrote: Dear e1000 maintainers, I had trouble compiling i40e for linux 4.0 branch, I couldn't find any official git repository or master branch including fixes for linux 4.0. So I've made my own set of patches and I wanted to share them.

Re: [E1000-devel] [PATCH] ixgbevf: Set rx hash type for ingress packets

On Wed, 2015-04-15 at 00:27 -0700, Du, Fan wrote: This appears to be a fix for your ixgbe patch and does not belong here. The proper way to handle it is to submit version 2. ok, I will send v2 for ixgbe patch, but Jeffrey has to drop previous ixgbe path he has queued. I was going to

Re: [E1000-devel] backporting of i210 driver

On Tue, 2015-04-14 at 20:44 -0700, Tal Lubko wrote: Hi Jeff What does it mean that there is no correlation between out of the tree driver versions and up stream kernel versions? What Jeff Pieper was saying was that the in-kernel version of the igb, does not directly related to a

Re: [E1000-devel] [PATCH] ixgbe: Specify rx hash type wrt rx desc RSS type

On Tue, 2015-04-14 at 14:56 +0800, Fan Du wrote: RSS could be leveraged by taking account L4 src/dst ports as ingredients, thus ingress skb rx hash type should honor such the real configuration. Signed-off-by: Fan Du fan...@intel.com --- Sorry for resending, I forgot to subscribe

Re: [E1000-devel] [PATCH v4 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

On Fri, 2015-04-10 at 01:04 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com The limitation of the number of multicast address for VF is not enough for the large scale server with SR-IOV feature. IPv6 requires the multicast MAC address for each IP address to

Re: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

On Wed, 2015-04-08 at 15:15 -0700, Alexander Duyck wrote: On 04/07/2015 10:38 PM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Implements the new netdev op to allow VF multicast promiscuous mode. The multicast promiscuous mode is not allowed for all VFs by

Re: [E1000-devel] [PATCH v3 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

On Wed, 2015-04-08 at 05:36 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com The limitation of the number of multicast address for VF is not enough for the large scale server with SR-IOV feature. IPv6 requires the multicast MAC address for each IP address to

Re: [E1000-devel] [PATCH v3 2/3] if_link: Add VF multicast promiscuous control

On Wed, 2015-04-08 at 05:37 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. This controls the permission to enter VF multicast promiscuous mode. The administrator will

Re: [E1000-devel] [PATCH v3 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

On Wed, 2015-04-08 at 05:38 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Implements the new netdev op to allow VF multicast promiscuous mode. The multicast promiscuous mode is not allowed for all VFs by default. The administrator can allow to VF

[E1000-devel] [net][resubmit] MAINTAINERS: Update Intel Wired Ethernet Driver info

on to different projects. Made an update to the section header so that it is more manageable going forward as we add new drivers. Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- MAINTAINERS | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git

Re: [E1000-devel] [net] Intel Wired LAN Driver Updates

On Tue, 2015-03-31 at 19:19 -0700, Jeff Kirsher wrote: On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Fri, 27 Mar 2015 16:04:10 -0700 The following are changes since commit dde93dfea53c72b07907d9e44a6e4b1545f6bdc4

Re: [E1000-devel] [net][resubmit] MAINTAINERS: Update Intel Wired Ethernet Driver info

On Tue, 2015-03-31 at 21:42 -0700, Jeff Kirsher wrote: Update the git tree info with a recent change in tree names. Also add our new mailing list created solely for Linux kernel patches and kernel development, as well as the new patchwork project for tracking patches. Lastly update the list

Re: [E1000-devel] [net] Intel Wired LAN Driver Updates

On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Fri, 27 Mar 2015 16:04:10 -0700 The following are changes since commit dde93dfea53c72b07907d9e44a6e4b1545f6bdc4: cxgb4: Fix frame size warning for 32 bit arch and are available

Re: [E1000-devel] [PATCH 56/86] intel/ixgb: use uapi/linux/pci_ids.h directly

On Sun, 2015-03-29 at 22:30 -0700, Stephen Hemminger wrote: Patch was rejected upstream by Greg Thanks for the update Stephen, I will drop the patch. On Sun, Mar 29, 2015 at 4:55 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Sun, 2015-03-29 at 15:41 +0200, Michael S. Tsirkin

Re: [E1000-devel] [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0

On Sun, 2015-03-29 at 18:25 -0700, Joe Perches wrote: Use bool constants as the return values instead of 1 and 0. Signed-off-by: Joe Perches j...@perches.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com For the ixgbe changes... --- To be honest I'd might rather get bunches

Re: [E1000-devel] [PATCH 56/86] intel/ixgb: use uapi/linux/pci_ids.h directly

On Sun, 2015-03-29 at 15:41 +0200, Michael S. Tsirkin wrote: Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, use the new header directly so we can drop the wrapper in include/linux/pci_ids.h. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [E1000-devel] [net-next 8/9] i40e/i40evf: Bump i40e/i40evf version

On Tue, 2015-03-24 at 18:43 +0100, Ronald van der Pol wrote: On Mon, Mar 09, 2015 at 10:55:41 -0700, Jeff Kirsher wrote: From: Catherine Sullivan catherine.sulli...@intel.com Bump PF version to 1.2.37 and VF version to 1.2.25 I am running this driver on CentOS 7.0.1406: [ 1077.043391

[E1000-devel] [net] MAINTAINERS: Update Intel Wired Ethernet Driver info

on to different projects. Made an update to the section header so that it is more manageable going forward as we add new drivers. Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- MAINTAINERS | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git

[E1000-devel] [net] Intel Wired LAN Driver Updates

dde93dfea53c72b07907d9e44a6e4b1545f6bdc4: cxgb4: Fix frame size warning for 32 bit arch and are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue master Jeff Kirsher (1): MAINTAINERS: Update Intel Wired Ethernet Driver info MAINTAINERS | 25

Re: [E1000-devel] [linux-nics] [PATCH net-next 7/7] igb: Enable TSO for stacked vlan

Makita makita.toshi...@lab.ntt.co.jp Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) signature.asc Description: This is a digitally signed message part

Re: [E1000-devel] Detected Hardware Unit Hang

On Wed, 2015-03-25 at 09:55 +0100, Zoltán Halassy wrote: I could test today without xen. No, the problem doesn't appear without xen (kernel is the same). Should I forward this problem to the xen developers then? That sounds like the prudent thing to do, since the issue only happens when

Re: [E1000-devel] Changing RSS on run time

On Wed, 2015-03-25 at 14:08 +0200, Tal Abudi wrote: Hi Thanks the reply. My ethtool version doesn't support this feature (ethtool 6). This feature was introduced in ethtool 3.1 or 3.2 but it's fairly easy to backport and adjust the relevant code. But it looks like that the ixgbe 3.9.15

Re: [E1000-devel] igb: Decrease time until link is up

On Sun, 2015-03-22 at 08:42 +0100, Paul Menzel wrote: please CC me on replies as I am not subscribed. On an Intel S1200RP server board with firmware version S1200RP.86B.01.03.0004.082120131450 and an Intel I210 ethernet controller, $ lspci -s 2:00 -nn 02:00.0 Ethernet

Re: [E1000-devel] [patch] igb: cleanup igb_enable_mas() a bit

On Thu, 2015-03-19 at 16:31 +0300, Dan Carpenter wrote: Static checkers complain about this because we do: if (!(connsw E1000_CONNSW_SERDESD)) { ... } else if (connsw E1000_CONNSW_SERDESD) { ... } else { ...

Re: [E1000-devel] [patch] igb: cleanup igb_enable_mas() a bit

On Thu, 2015-03-19 at 14:36 -0700, Fujinaka, Todd wrote: I'm looking into this and while the code fix is correct, I'm not sure the underlying code is correct. Unfortunately, the person who knows the most about this is out for spring break. Can we hold off on this patch? Understood, I will

Re: [E1000-devel] [PATCH v2] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from hw_features

On Thu, 2015-03-12 at 08:22 -0700, Alexander Duyck wrote: This change makes it so that the HW_VLAN_CTAG_FILTER bit is not falsely advertised as being a feature that can be toggled on ixgbe parts. The driver was setting the bit in features and letting it be inherited by hw_features, however

Re: [E1000-devel] ixgbe: kernel BUG at include/linux/mm.h

On Tue, 2015-03-10 at 21:29 +0800, Bob Liu wrote: Would you mind sending your actual test cases to prove that the page is free when calling _skb_frag_unref I'm afraid not, it's a complex testing program and difficult to run on external environment because of many dependencies. from the

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

On Mon, 2015-03-09 at 18:52 -0700, Jeff Kirsher wrote: On Tue, 2015-03-10 at 01:42 +, Hiroshi Shimamoto wrote: On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

On Tue, 2015-03-10 at 01:42 +, Hiroshi Shimamoto wrote: On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/08/2015 02:15 PM, Or Gerlitz wrote: On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: [...] We discussed this during NetConf last week, and Don is correct that a custom sysfs interface is not the way we

Re: [E1000-devel] [PATCH v2] ixgbe: make VLAN filter conditional

On Fri, 2015-03-06 at 06:04 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Disable hardware VLAN filtering if netdev-features VLAN flag is dropped. In SR-IOV case, there is a use case which needs to disable VLAN filter. For example, we need to

Re: [E1000-devel] [PATCH v2] ixgbe: make VLAN filter conditional

On Fri, 2015-03-06 at 09:46 +, Hiroshi Shimamoto wrote: On Fri, 2015-03-06 at 06:04 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Disable hardware VLAN filtering if netdev-features VLAN flag is dropped. In SR-IOV case, there is a use

Re: [E1000-devel] [net-next PATCH 1/2] igb: Fix warning ‘pin’ may be used uninitialized

On Thu, 2015-03-05 at 11:24 -0800, Alexander Duyck wrote: When building the kernel using the gcc 4.8.3 compiler included in Fedora 20 I was repeatedly seeing the warning: drivers/net/ethernet/intel/igb/igb_ptp.c: In function ‘igb_ptp_feature_enable_i210’:

Re: [E1000-devel] [net-next PATCH 2/2] igb: Make arrays on stack static const to avoid reallocation

On Thu, 2015-03-05 at 11:25 -0800, Alexander Duyck wrote: While addressing the pin problem I noticed that all of the pin register values where having to be pushed onto the stack each time the function was called. To avoid that I am making them static const so that they should only need to

Re: [E1000-devel] randconfig build error with next-20150302, in drivers/net/ethernet/intel/i40e/i40e_configfs.c

On Mon, 2015-03-02 at 09:29 -0700, Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `i40e_cfgfs_group_make_item': i40e_configfs.c:(.text+0x3df4ce): undefined reference to `config_item_init_type_name' drivers/built-in.o: In function

Re: [E1000-devel] [PATCH net-next 02/14] ethernet: Use eth_foo_addr instead of memset

On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: Use the built-in function instead of memset. Signed-off-by: Joe Perches j...@perches.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com for the changes to Intel's ixgbe driver... --- drivers/net/ethernet/amd/pcnet32.c

Re: [E1000-devel] i40e: crash on NMI by continuous module reload

On Fri, 2015-02-27 at 16:25 -0500, Nicholas Krause wrote: Thanks Shannon, For the advice on there being a newer driver and firmware to test that on before reporting the bug against this driver. I am curious as to why this newer code is not up streamed to Linux next yet through. Because I

Re: [E1000-devel] [PATCH 2/2] ixgbe: Add new mbox API for enabling TX loopback

On Fri, 2015-02-27 at 00:45 +0200, Yotam Rubin wrote: Hey Jeff, just making sure this hasn't slipped through the cracks. Any comments on the patches? On 18 Feb 2015 16:11, Yotam Rubin yo...@weka.io wrote: ixgbe hardware supports enabling TX loopback for VF's through the

Re: [E1000-devel] [PATCH 2/2] ixgbe: Add new mbox API for enabling TX loopback

On Wed, 2015-02-18 at 16:11 +0200, Yotam Rubin wrote: ixgbe hardware supports enabling TX loopback for VF's through the PFVMTXSW registers on the PF. Add a new mbox api enabling the VF to set its respective PFVMTXSW bit via the PF. Bump the mbox api to level 12. VF loopback is

Re: [E1000-devel] [PATCH 1/2] ixgbe: Support PFVMTXSW (loopback tx) in MAC ops

On Wed, 2015-02-18 at 16:11 +0200, Yotam Rubin wrote: Add a new MAC operation: set_tx_loopback. On 82599 and x540 MACs, this operation allows enabling/disabling of the per-VF tx loopback configuration. By default, tx loopback is disabled for all VF's. Signed-off-by: Yotam Rubin

Re: [E1000-devel] [PATCH] ixgbe: make VLAN filter conditional in SR-IOV case

On Wed, 2015-02-25 at 00:51 +, Hiroshi Shimamoto wrote: Subject: Re: [E1000-devel] [PATCH] ixgbe: make VLAN filter conditional in SR-IOV case On Thu, 2014-11-13 at 08:28 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Disable hardware VLAN

Re: [E1000-devel] [PATCH net-next] i40e: mark constant as ULL

On Tue, 2015-02-24 at 13:08 +0100, Stefan Assmann wrote: On 23.02.2015 15:56, Stefan Assmann wrote: On 04.02.2015 18:49, Jeff Kirsher wrote: On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote: This avoids a compile error on 32bit. Signed-off-by: Stefan Assmann sassm...@kpanic.de

Re: [E1000-devel] [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

On Wed, 2015-02-25 at 11:05 +0100, Sabrina Dubroca wrote: There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: Changing MTU frees all the rx buffers: e1000_change_mtu - e1000_down - e1000_clean_all_rx_rings -

Re: [E1000-devel] [PATCH v2 net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

On Wed, 2015-02-25 at 12:03 +0100, Sabrina Dubroca wrote: @@ -4481,6 +4489,7 @@ next_desc: return cleaned; } + /** * e1000_alloc_jumbo_rx_buffers - Replace used jumbo receive buffers * @adapter: address of board private structure This added blank line is not needed or

Re: [E1000-devel] [PATCH net v3] e1000: add dummy allocator to fix race condition between mtu change and netpoll

On Wed, 2015-02-25 at 12:26 +0100, Sabrina Dubroca wrote: There is a race condition between e1000_change_mtu's cleanups and netpoll, when we change the MTU across jumbo size: Changing MTU frees all the rx buffers: e1000_change_mtu - e1000_down - e1000_clean_all_rx_rings -

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

On Mon, 2015-02-23 at 06:29 -0800, Skidmore, Donald C wrote: -Original Message- From: Edward Cree [mailto:ec...@solarflare.com] Sent: Monday, February 23, 2015 5:53 AM To: Skidmore, Donald C Cc: Hiroshi Shimamoto; vyase...@redhat.com; Kirsher, Jeffrey T; Alexander Duyck; Bjørn

Re: [E1000-devel] [PATCH] i40e: Fix memory leak at failure path in i40e_dbg_command_write()

On Sat, 2015-02-21 at 01:24 +0300, Alexey Khoroshilov wrote: The patch fixes a leak of 'cmd_buf' when copy_from_user() failed in i40e_dbg_command_write(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru ---

Re: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

On Fri, 2015-02-20 at 01:01 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Implements the new netdev op to allow VF multicast promiscuous mode. The administrator can allow to VF multicast promiscuous mode for only trusted VM. After allowing multicast

Re: [E1000-devel] [PATCH v2 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

On Fri, 2015-02-20 at 00:59 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com The limitation of the number of multicast address for VF is not enough for the large scale server with SR-IOV feature. IPv6 requires the multicast MAC address for each IP address to

Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

On Fri, 2015-02-20 at 01:00 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Add netlink directives and ndo entry to allow VF multicast promiscuous mode. The administrator wants to allow dedicatedly multicast promiscuous per VF. Signed-off-by: Hiroshi

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

On Wed, 2015-02-11 at 12:23 +0100, Thomas Jarosch wrote: Hi Jeff, On Thursday, 15. January 2015 06:59:13 Jeff Kirsher wrote: Sure, you basically reverted my patch. You are not the first to report a problem caused by this patch. This patch is known to have uncovered some driver

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

On Mon, 2015-02-09 at 10:29 +0100, Bjørn Mork wrote: Jeff Kirsher jeffrey.t.kirs...@intel.com writes: If you want to see Nick's patch, feel free to view his patch on my queue tree: https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/ which said: - s32 i = 0, timeout

Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

On Mon, 2015-02-09 at 06:59 +, Hiroshi Shimamoto wrote: Subject: Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode On Fri, 2015-01-30 at 11:37 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

. last one applied to my queue). On 02/08/2015 08:21 PM, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

On Sun, 2015-02-08 at 20:28 -0500, nick wrote: On 2015-02-08 08:26 PM, Jeff Kirsher wrote: On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values for the function

Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: Removes the outdated fix me comment in the function,gb_acquire_swfw_sync_i210 for setting the variables, i and timeout to the intended correct values for the function,gb_acquire_swfw_sync_i210 to function correctly. This comment is

Re: [E1000-devel] [PATCH] i40e: fix sparse warning

On Thu, 2015-02-05 at 15:13 +, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: i40e_lan_hmc.c:911:24: warning: constant 0x is so big it is unsigned long Signed-off-by: Lad, Prabhakar

Re: [E1000-devel] [PATCH] ixgbe: fix sparse warnings

On Thu, 2015-02-05 at 14:27 +, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warnings: ixgbe_x550.c:83:5: warning: symbol 'ixgbe_init_eeprom_params_X550' was not declared. Should it be static? ixgbe_x550.c:113:5: warning: symbol

Re: [E1000-devel] [PATCH net-next] i40e: mark constant as ULL

On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote: This avoids a compile error on 32bit. Signed-off-by: Stefan Assmann sassm...@kpanic.de --- drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Come to find out, I already have a fix

Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode

On Fri, 2015-01-30 at 11:37 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com The limitation of the number of multicast address for VF is not enough for the large scale server with SR-IOV feature. IPv6 requires the multicast MAC address for each IP address to

Re: [E1000-devel] Return Value for the function, u32 i40e_fcoe_ctxt_eof in i40e_fcoe_ctx_eof

On Sat, 2015-01-24 at 18:20 -0500, nick wrote: I am wondering what the correct error return value is for the function stated in my message. What message? In the title you state Return Value for the function, u32 i40e_fcoe_ctxt_eof in i40e_fcoe_ctx_eof, are you referring to your message title?

Re: [E1000-devel] [PATCH 1/2] if_link: Add VF multicast promiscuous mode control

On Thu, 2015-01-22 at 09:50 +, David Laight wrote: From: Skidmore, Donald C From: Hiroshi Shimamoto My concern is what is the real issue that VF multicast promiscuous mode can cause. I think there is the 4k entries to filter multicast address, and the current

Re: [E1000-devel] [PATCH] i40e: don't enable and init FCOE by default when do PF reset

something, I guess next either go with CONFIG_I40E_FCOE disable as I suggested before and now it in upstream kernel or we can have further off list discussion to fix the issue you are trying to fix with the patch. Thanks, Vasu Thanks, Ethan Jeff Kirsher should be getting out

Re: [E1000-devel] [PATCHv2] ixgbe: Re-enable relaxed ordering as part of init/restart sequence for non-DCA config

On Wed, 2015-01-14 at 20:03 -0500, Sowmini Varadhan wrote: Relaxed ordering is disabled by default at driver initialization and re-enabled when DCA is used. The reason it is disabled was due to an issue on some chipsets (see comments in ixgbe_update_tx_dca()). But when DCA is not used, RO

Re: [E1000-devel] [PATCH] e100: Don't enable WoL by default on Toshiba devices

On Thu, 2015-01-15 at 14:40 +0100, Ondrej Zary wrote: On Thursday 13 November 2014, Jeff Kirsher wrote: On Wed, 2014-11-12 at 18:18 -0500, David Miller wrote: From: Ondrej Zary li...@rainbow-software.org Date: Wed, 12 Nov 2014 23:47:25 +0100 Enabling WoL on some Toshiba laptops

Re: [E1000-devel] [PATCH] e100: Don't enable WoL by default on Toshiba devices

On Thu, 2015-01-15 at 16:18 +0100, Ondrej Zary wrote: On Thursday 15 January 2015, Jeff Kirsher wrote: On Thu, 2015-01-15 at 14:40 +0100, Ondrej Zary wrote: On Thursday 13 November 2014, Jeff Kirsher wrote: On Wed, 2014-11-12 at 18:18 -0500, David Miller wrote: From: Ondrej Zary li

Re: [E1000-devel] [bisected regression] e1000e: Detected Hardware Unit Hang

On Thu, 2015-01-15 at 06:43 -0800, Eric Dumazet wrote: On Thu, 2015-01-15 at 11:11 +0100, Thomas Jarosch wrote: On Wednesday, 14. January 2015 09:20:52 Eric Dumazet wrote: I would try to use lower data per txd. I am not sure 24KB is really supported. ( check commit

Re: [E1000-devel] [linux-nics] [PATCH] e1000: fix time comparison

On Wed, 2015-01-07 at 14:41 +0200, Asaf Vertz wrote: To be future-proof and for better readability the time comparisons are modified to use time_after_eq() instead of plain, error-prone math. Signed-off-by: Asaf Vertz asaf.ve...@tandemg.com ---

Re: [E1000-devel] [PATCH] net: ethernet: intel: i40e: i40e_fcoe.c: Remove unused function

On Wed, 2014-12-31 at 17:48 +0100, Rickard Strandqvist wrote: Remove the function i40e_rx_is_fip() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [E1000-devel] [PATCH v3 1/3] igb: Add igb_disable_sriov in error handling

On Tue, 2014-12-23 at 21:22 +0800, Jia-Ju Bai wrote: On 12/23/2014 07:23 PM, Sergei Shtylyov wrote: Hello. On 12/23/2014 10:17 AM, Jia-Ju Bai wrote: For linux-3.18.0 For the future: such words should be placed under --- tear line... The driver lacks igb_disable_sriov in error

Re: [E1000-devel] [linux-nics] [PATCH]e100 in linux-3.18.0: some potential bugs

On Sat, 2014-12-20 at 15:40 +0800, Jia-Ju Bai wrote: I have actually tested e100 driver on the real hardware(Intel 82559 PCI Ethernet Controller), and find some bugs: The target file is drivers/net/ethernet/intel/e100.c, which is used to build e100.ko. (1) The function pci_pool_create is

Re: [E1000-devel] [linux-nics] [PATCH] e1000e in linux-3.18.0: some potential bugs

On Sat, 2014-12-20 at 16:02 +0800, Jia-Ju Bai wrote: I have actually tested e1000e driver on the real hardware(Intel 82572EI PCI-E Gigabit Ethernet Controller), and find some potential bugs: The target file is drivers/net/ethernet/intel/e1000e/netdev.c, which is used to build e1000e.ko.

Re: [E1000-devel] [linux-nics] [PATCH] igb in linux-3.18.0: some potential bugs

On Sat, 2014-12-20 at 16:11 +0800, Jia-Ju Bai wrote: I have actually tested igb driver on the real hardware(Intel 82575EB PCI-E Gigabit Ethernet Controller), and find some potential bugs: The target file is drivers/net/ethernet/intel/igb/igb_main.c (1) In the normal process of igb,

Re: [E1000-devel] [linux-nics] [PATCH] igb: replace delays with sleeping equivalents

On Sun, 2014-12-07 at 23:16 +0100, Heiner Kallweit wrote: The usage of longer busy-wait delays is discouraged in non-atomic context. See also Documentation/timers/timers-howto.txt Therefore replace them with sleeping equivalents. I successfully tested the patch on a device with I211.

Re: [E1000-devel] [linux-nics] [PATCH] igb: replace delays with sleeping equivalents

On Sun, 2014-12-07 at 23:16 +0100, Heiner Kallweit wrote: The usage of longer busy-wait delays is discouraged in non-atomic context. See also Documentation/timers/timers-howto.txt Therefore replace them with sleeping equivalents. I successfully tested the patch on a device with I211.

Re: [E1000-devel] [PATCH] e1000e / igb / PM: Eliminate CONFIG_PM_RUNTIME

blocks depending on CONFIG_PM may be dropped now. Do that in the e1000e and igb network drivers. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Acked-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- Note: This depends on commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME

Re: [E1000-devel] ixgbe - patch to enable indirection table interaction with ethtool

On Wed, 2014-12-03 at 11:06 +0100, Tom Barbette wrote: Hi list, Here is a very small patch to enable the use of ethtool --show-rxfh and ethtool --set-rxfh with ixgbe. I've tested it with my X520 cards, but it should be good with all cards as it's kind of a simple merge from igb and the

Re: [E1000-devel] Intel Ethernet Drivers and Utilities on sourceforge.net

On Fri, 2014-11-21 at 12:51 +0200, Kevin Wilson wrote: Hi, I just wonder - what is the intent of the Intel Ethernet Drivers and Utilities site: http://sourceforge.net/projects/e1000/files/ http://sourceforge.net/projects/e1000/ ? It includes some drivers which are in mainline kernel.

Re: [E1000-devel] [PATCH] ixgbe: make VLAN filter conditional in SR-IOV case

On Thu, 2014-11-13 at 08:28 +, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Disable hardware VLAN filtering if netdev-features VLAN flag is dropped. In SR-IOV case, there is a use case which needs to disable VLAN filter. For example, we need to make a

Re: [E1000-devel] [PATCH] e100: Don't enable WoL by default on Toshiba devices

On Wed, 2014-11-12 at 18:18 -0500, David Miller wrote: From: Ondrej Zary li...@rainbow-software.org Date: Wed, 12 Nov 2014 23:47:25 +0100 Enabling WoL on some Toshiba laptops (such as Portege R100) causes battery drain after shutdown (WoL is active even on battery). These laptops have the

Re: [E1000-devel] [patch] i40e: precedence bug in i40e_get_pfc_delay()

On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote: The operation has higher precedence than the operation. Also the casting is not needed. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- This is static checker work and I haven't tested it on real hardware. As Shannon has

Re: [E1000-devel] [PATCH] igb: don't reuse pages with pfmemalloc flag

On Wed, 2014-10-22 at 17:50 +0400, Roman Gushchin wrote: Incoming packet is dropped silently by sk_filter(), if the skb was allocated from pfmemalloc reserves and the corresponding socket is not marked with the SOCK_MEMALLOC flag. Igb driver allocates pages for DMA with __skb_alloc_page(),

Re: [E1000-devel] [linux-nics] [PATCH 1/1] e1000: unset IFF_UNICAST_FLT on WMware 82545EM

On Mon, 2014-10-20 at 15:11 -0700, Francesco Ruggeri wrote: VMWare's e1000 implementation does not seem to support unicast filtering. This can be observed by configuring a macvlan interface on eth0 in a VM in VMWare Fusion 5.0.5, and trying to use that interface instead of eth0. Tested on

  1   2   3   4   >