Re: [edk2] [Patch] MdeModulePkg PiSmmCore: Update comments in InitializeMemoryServices

HI Liming How about we keep original comment? Your new comment describes *what* the coding is doing, and original comment describes *why*. If you agree, reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Thursday, December 1, 2016 2:47 PM > To:

Re: [edk2] [PATCH 0/3] mReservedVectors is not set

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, November 30, 2016 3:23 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/3] mReservedVectors is not set

[edk2] [patch] MdeModulePkg: Fix assert in iSCSI.

The bug is caused by using already freed memory. If there is already an attempt and execute 'reconnect -r' command, all the ConfigFormEntry structure will be freed in IScsiDriverBindingStop, but the mCallbackInfo->Current is not configured as null and this pointer will be used again in

[edk2] [Patch 2/2] MdeModulePkg PiSmmCore: Retrieve Smram base address from system table

PiSmmIpl records LoadModuleAtFixAddressSmramBase in LMFAConfigurationTable. Update PiSmmCore to directly get the address from this system table. Cc: Star Zeng Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming

[edk2] [Patch 1/2] MdeModulePkg SmmIpl: Fill Smram range for SMM driver when LMFA enable

Allocate the additional Smram range to describe the reserved smram for SMM core and driver when LMFA feature is enabled. Cc: Star Zeng Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

[edk2] [Patch 0/2] MdeModulePkg SmmCore: Fix hang issue when LMFA enable

Liming Gao (2): MdeModulePkg SmmIpl: Fill Smram range for SMM driver when LMFA enable MdeModulePkg PiSmmCore: Retrieve Smram base address from system table MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 1 + MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2 ++

Re: [edk2] [Patch] UefiCpuPkg/Include: Add VMX MSR register structures

Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Wednesday, November 30, 2016 3:29 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Fan, Jeff; Tian, Feng Subject: [Patch] UefiCpuPkg/Include: Add VMX MSR register structures Add

[edk2] [Patch] MdeModulePkg PiSmmCore: Update FreePages to handle zero address and pages

https://bugzilla.tianocore.org/show_bug.cgi?id=278 Zero memory address or zero number pages are invalid to SmmFreePages(). Cc: Star Zeng Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

[edk2] [Patch] MdeModulePkg PiSmmCore: Update comments in InitializeMemoryServices

Add the comments to describe Free and Allocated SMRAM are added separately. Cc: Star Zeng Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Core/PiSmmCore/Pool.c |

[edk2] [PATCH] Vlv2TbltDevicePkg: Fix typo in script file

To prevent output from being shown, output file should be 'nul', not 'null' Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Vlv2TbltDevicePkg/bld_vlv.bat | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Add Fmp->GetImage() support.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Tuesday, November 29, 2016 9:41 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Fan, Jeff Subject: [PATCH] MdeModulePkg/CapsuleApp: Add Fmp->GetImage() support. We add Fmp->GetImage() support in

Re: [edk2] [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Thursday, December 1, 2016 12:58 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Tian, Feng

Re: [edk2] [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

Reviewed-by: Jeff Fan on serials. -Original Message- From: Kinney, Michael D Sent: Wednesday, November 30, 2016 3:07 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Fan, Jeff; Tian, Feng Subject: [Patch 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce use of PSD

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 4:48 PM To: Fan, Jeff ; edk2-de...@ml01.01.org Cc: Kinney, Michael D ; Tian, Feng

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

QuarkSocPkg changes Reviewed-by: Michael Kinney Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, November 30, 2016 9:20 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Wu, Hao A

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On 2016/12/1 1:20, Leif Lindholm wrote: LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Nevertheless, new code should be using the MdeModulePkg versions, so change all references

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

Reviewed-by: Liming Gao -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Thursday, December 01, 2016 1:20 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Tian, Feng

Re: [edk2] VFAT mounting inconsistency in UEFI

> On Nov 24, 2016, at 8:22 PM, GN Keshava wrote: > > Hi, > > I'm connecting my Linux device to UEFI-running PC using USB Mass storage. > Linux is enumerated as Mass storage on host (UEFI). > > Sometimes, the mass storage is not detecting/mounting on UEFI. > Linux has

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On 11/30/16 18:20, Leif Lindholm wrote: > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > kept for compatibility. > > Nevertheless, new code should be using the MdeModulePkg versions, so > change all

[edk2] MdeModulePkg/Universal/Network/IScsiDxe

Hi All, In IScsiDxe driver, IScsiPublishIbft ( ) is called from both IScsiDriverBindingStart and IScsiDriverBindingStop functions. In a system with more than one network interface and no I_NAME variable, it is possible that no iBFT tables are installed in start but during exit boot services, in

[edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Nevertheless, new code should be using the MdeModulePkg versions, so change all references in in-tree platforms. Contributed-under:

Re: [edk2] [PATCH v2 3/4] ArmPkg/ArmDmaLib: clean up abuse of device address

On 15 November 2016 at 18:01, Leif Lindholm wrote: >> >> In case anyone is up to doing that, please find the branch here >> >> https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/log/?h=armdmalib-offset >> > >> > I tested your branch on the usual victims (R0/1/2,

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib: support page tables in cacheable memory only

On Sun, Nov 20, 2016 at 05:12:50PM +, Ard Biesheuvel wrote: > Translation table walks are always cache coherent on ARMv8-A, so cache > maintenance on page tables is never needed. Since there is a risk of > loss of coherency when using mismatched attributes, and given that memory > is mapped

Re: [edk2] [PATCH v4 3/5] MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices

Hi Ray, Ard is on holiday this week, and mostly managing to stay off the email... Anyway, I could really use this support in order to bring the Marvell Armada 70x0 support (worked on by the Semihalf guys) into OpenPlatformPkg, so I will pick this up while he is away - at least parts 1-3. 4/5 is

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

On 11/30/16 01:43, Fan, Jeff wrote: > Laszlo, > > Thanks your comments. I added my comments as below in [Jeff] Thanks for your answers. Acked-by: Laszlo Ersek Tested-by: Laszlo Ersek Cheers Laszlo > -Original Message- > From: Laszlo Ersek

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

On 11/30/16 06:50, Yao, Jiewen wrote: > How about this: > > > > > > UefiCpuPkg/PiSmmCpu: relax superpage protection on page split. > > > > PiSmmCpu driver may split page for page attribute request. > > Current logic not only propagates the super page

[edk2] [Patch] BaseTools: add error check for "#image" for idf file format

Add new error check for "#image" keyword used in the image definition file. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/IdfClassObject.py | 5 - 1 file

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

Reviewed-by: Jeff Fan > with new updating. From: Yao, Jiewen Sent: Wednesday, November 30, 2016 1:50 PM To: Yao, Jiewen; Laszlo Ersek; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: RE: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set

[edk2] [patch] NetworkPkg: Correct one typo error in PXE driver.

Correct the typo from Private->Icmp6Token.Status = EFI_NOT_READY to Private->IcmpToken.Status = EFI_NOT_READY when start the PXE over IPv4. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan

Re: [edk2] [PATCH] UefiCpuPkg/MicrocodeUpdate: Fix GetImage API

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Tuesday, November 29, 2016 9:32 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg/MicrocodeUpdate: Fix GetImage API Current GetImage API forgets to return data to caller. Add

[edk2] [Patch] BaseTools: Fix the bug to parse the new map file format

Current the variable and Pcd format save in the map file is changed, so this patch is to support this new format. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch] BaseTools: Support QuotedString for PREBUILD/POSTBUILD in DSC file

If the prebuild/postbuild script statement start with double quotations, current tool report error, while DSC spec allow this usage. so update tool to support it. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu