Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

On 11 January 2017 at 02:05, Ni, Ruiyu wrote: > One minor comments: put one space after (EFI_PHYSICAL_ADDRESS) and (UINTN) as > below. >> +(EFI_PHYSICAL_ADDRESS) (UINTN) HostAddress + *NumberOfBytes > >> SIZE_4GB > I disagree. The EDK2 coding style does not

Re: [edk2] [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types

Series reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Tuesday, January 10, 2017 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [PATCH 1/8] MdeModulePkg/TerminalDxe:

Re: [edk2] [PATCH] MdeModulePkg/Stall: Refine to compare 2 values with the same type

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, January 6, 2017 4:52 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star ; Kinney, Michael D

[edk2] [ShellPkg] failing to compile due to missing ;

I'm having an issue compiling the ShellPkg.dsc due to a missing ; Does it compile under VC++? https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c#L3102

Re: [edk2] [Patch] ShellPkg/Shell: Add double quotes to args with white space

Mike, I have no other concerns now. Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, January 11, 2017 5:10 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael > D

Re: [edk2] [PATCH 0/8] IoLib class library

Leo: edk2\UefiCpuPkg\CpuIo2Dxe\CpuIo2Dxe.c CpuIoServiceRead() bases on IoReadFifo8() for EfiCpuIoWidthFifoUint8 width. So, IoLibCupIo2 library instance IoReadFifo8() implementation can call mCpuIo->Io.Read (mCpuIo, EfiCpuIoWidthFifoUint8, Port, Count, Buffer); Thanks Liming -Original

Re: [edk2] [PATCH 0/8] IoLib class library

Liming... > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, January 10, 2017 7:42 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Singh, Brijesh ; Justen, Jordan L > ; Kinney,

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

Got it, I will update the codes before check in. Thanks for the feedback. Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, January 11, 2017 10:05 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Ard Biesheuvel > Subject: RE: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

One minor comments: put one space after (EFI_PHYSICAL_ADDRESS) and (UINTN) as below. > +(EFI_PHYSICAL_ADDRESS) (UINTN) HostAddress + *NumberOfBytes > > SIZE_4GB Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel

[edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

Refine the codes to compare the definition 'SIZE_4GB' with type EFI_PHYSICAL_ADDRESS. Cc: Ard Biesheuvel Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

Re: [edk2] [PATCH 0/8] IoLib class library

Jeff: This patch moves source files from UefiCpuPkg to MdePkg. .asm and .nasm are not new added ones. So, I suggest to keep them. Thanks Liming -Original Message- From: Fan, Jeff Sent: Wednesday, January 11, 2017 9:45 AM To: Gao, Liming ; Leo Duran

Re: [edk2] [PATCH 0/8] IoLib class library

Leo, I suggest not to add .asm file again. It's hard to maintain in the future, because VS and GCC compile .nasm file by default now. Liming, any comments? Thanks! Jeff -Original Message- From: Gao, Liming Sent: Wednesday, January 11, 2017 9:42 AM To: Leo Duran;

Re: [edk2] [PATCH 0/8] IoLib class library

Leo: Thanks for your update. Here is my comments. 1) PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2 library instance can base on CPU IO service to do FifoIo operation. They don't implement them again. 2) IntelFrameworkModulePkg CpuIoDxe and UefiCpuPkg CpuIoPei driver can be updated to base on FifoIo

Re: [edk2] [PATCH v2] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Wednesday, January 11, 2017 12:49 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [PATCH v2]

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

You can try 5966dd8ff2ef60095227523794ad07af675a3aeb of git repo or svn https://svn.code.sf.net/p/edk2/code/trunk/edk2@18088 Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent: Tuesday, January 10, 2017 5:52 PM To:

[edk2] [PATCH 8/8] OvmfPkg: Modify QemuFwCfgLib to use new IoLib class library

The Fifo routines from the QuemuFwCfgLib library have been ported in the new BaseIoLibIntrinsic (IoLib class) library. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh

[edk2] [PATCH 5/8] MdePkg/SmmIoLibSmmCpuIo2: Add new Fifo routines in IoLib class

Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Signed-off-by: Leo Duran --- MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 203

[edk2] [PATCH 3/8] MdePkg/DxeIoLibEsal: Add new Fifo routines in IoLib class

Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Signed-off-by: Leo Duran --- MdePkg/Library/DxeIoLibEsal/IoLib.c | 203

[edk2] [PATCH 4/8] MdePkg/PeiIoLibCpuIo: Add new Fifo routines in IoLib class

Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Signed-off-by: Leo Duran --- MdePkg/Library/PeiIoLibCpuIo/IoLib.c | 203

[edk2] [PATCH 1/8] MdePkg: Expand BaseIoLibIntrinsic (IoLib class) library

The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. This patch ports the I/O Fifo routines into the BaseIoLibIntrinsic library and expand the IoLib class to include the ported I/O Fifo routines. Cc: Michael D Kinney

[edk2] [PATCH 2/8] MdePkg/DxeIoLibCpuIo2: Add new Fifo routines in IoLib class

Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Signed-off-by: Leo Duran --- MdePkg/Library/DxeIoLibCpuIo2/IoLib.c | 203

[edk2] [PATCH 0/8] IoLib class library

The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate implementations of I/O Fifo routines. The patch series moves the I/O Fifo routines into the BaseIoLibIntrinsic library and expands the IoLib class to include the ported I/O Fifo routines. The Fifo routines moved from the

Re: [edk2] [PATCH v4] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

On Mon, Jan 09, 2017 at 03:20:51PM -0600, Daniil Egranov wrote: > From: Daniil Egranov > > The patch reads a valid MAC address form the Juno IOFPGA registers > and pushes it into onboard Marvell Yukon NIC. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter

Sounds good. > -Original Message- > From: Ni, Ruiyu > Sent: Monday, January 09, 2017 6:24 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org; > Kinney, Michael D > Cc: Wu, Hao A > Subject: RE: [edk2] [PATCH 0/5]

Re: [edk2] [Patch] ShellPkg/Shell: Add double quotes to args with white space

Ray, This change does not impact the Argc/Argv list from the Shell Parameters Protocol. The double quotes are always stripped for those and the entry point to the shell app still sees the same input as before. This change conforms to the shell specification section you reference. This change

Re: [edk2] [Patch v3] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

Laszlo, Committed with your feedback applied and rb at: https://github.com/tianocore/edk2/commit/f4d575b51bbdb61e9f634dcabb84149ca836cffa Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, January 9, 2017 11:44 AM > To: Kinney, Michael D

Re: [edk2] [Patch 3/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Fix GCC build issues

Reviewed-by: Lee Leahy -Original Message- From: Kinney, Michael D Sent: Tuesday, January 10, 2017 10:17 AM To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Leahy, Leroy P Subject: [Patch 3/3]

Re: [edk2] [Patch 2/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Fix SubmitCommand() out size

Reviewed-by: Lee Leahy -Original Message- From: Kinney, Michael D Sent: Tuesday, January 10, 2017 10:17 AM To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Leahy, Leroy P Subject: [Patch 2/3]

Re: [edk2] [Patch 1/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Remove PP Check

Reviewed-by: Lee Leahy -Original Message- From: Kinney, Michael D Sent: Tuesday, January 10, 2017 10:17 AM To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Leahy, Leroy P Subject: [Patch 1/3]

[edk2] [Patch] SecurityPkg/Tpm12CommandLib: Always check response returnCode

https://bugzilla.tianocore.org/show_bug.cgi?id=338 Update the Tpm12CommandLib to consistently check the returnCode field of a response packet. These checks are missing from the GetCapability and SelfTest commands. The functions Tpm12ContinueSelfTest(), Tpm12GetCapabilityFlagPermanent(), and

[edk2] [Patch 0/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Fix TPM issues

Fix several issues with the Atmel I2C TPM library in the QuarkPlatformPkg. This includes GCC build failures, a corner case for an incorrect output buffer size, and a TPM detection failure due to increased error checking in the Tpm12CommandLib. Cc: Kelly Steele Cc: Lee

[edk2] [Patch 2/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Fix SubmitCommand() out size

https://bugzilla.tianocore.org/show_bug.cgi?id=336 When the Tpm12SubmitCommand() detects a response packet that is the same size as a TPM_RSP_COMMAND_HDR, it returns EFI_SUCCESS without reading any additional response packet information from the TPM. In that case, the return parameter

[edk2] [Patch 3/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Fix GCC build issues

https://bugzilla.tianocore.org/show_bug.cgi?id=335 Fix build issues with GCC49. There are local variables that may be used before initialized in some paths. Cc: Kelly Steele Cc: Lee Leahy Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch 1/3] QuarkPlatformPkg/Tpm12DeviceLibAtmelI2c: Remove PP Check

https://bugzilla.tianocore.org/show_bug.cgi?id=337 The Tpm12CommandLib in the SecurityPkg was updated to check the returnCode in the response packet in the following commit: https://github.com/tianocore/edk2/commit/950a3bc788b5b101729b26aed3ff75fd2a64a570 The Tpm12DeviceLibAtmelI2C uses the

Re: [edk2] TPL of RegisterKeyNotify

> On Jan 10, 2017, at 6:48 AM, Michael Zimmermann > wrote: > > just FYI, mantis links are useless if you don't have access to that ;) > I don't know what this is usually used for but making some parts of > uefi.org public doesn't sound like a bad idea to me. >

Re: [edk2] [PATCH RFC 06/14] OvmfPkg/XenPlatformPei: Add xen PVH specific code

On 01/10/17 17:18, Anthony PERARD wrote: > On Thu, Jan 05, 2017 at 11:30:32AM +0100, Laszlo Ersek wrote: >> On 12/08/16 16:33, Anthony PERARD wrote: >>> - learn about memory size from the E820 >>> - ignore error if host bridge devid is 0x, PVH does not have PCI and >>> reading from

[edk2] [PATCH v2] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

When running Nt32Pkg, SMBIOS Type 2 had the wrong Length. Fixed the code to use the correct structure in sizeof, and properly account for ContainedObjectHandles. Also updated variable names with Assert -> Asset Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Phillips

Re: [edk2] [PATCH] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Yes, I'll make the variable name update. Thanks, Chris -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Tuesday, January 10, 2017 4:09 AM To: Phillips, Chris J (Plano, TX) ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star

Re: [edk2] [PATCH RFC 06/14] OvmfPkg/XenPlatformPei: Add xen PVH specific code

On Thu, Jan 05, 2017 at 11:30:32AM +0100, Laszlo Ersek wrote: > On 12/08/16 16:33, Anthony PERARD wrote: > > - learn about memory size from the E820 > > - ignore error if host bridge devid is 0x, PVH does not have PCI and > > reading from unexisting device return -1. > > > >

Re: [edk2] [PATCH RFC 04/14] OvmfPkg: Introduce XenPlatformPei

On Thu, Jan 05, 2017 at 10:59:24AM +0100, Laszlo Ersek wrote: > On 12/08/16 16:33, Anthony PERARD wrote: > > A copy of OvmfPkg/PlatformPei without some of QEMU specific > > initialization, Xen does not support QemuFwCfg. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > >

Re: [edk2] [PATCH 4/5] ShellPkg/Dh: Fix coding style issues

Oh. Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Monday, January 09, 2017 6:25 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Chen, Chen A > Subject: RE: [PATCH 4/5] ShellPkg/Dh:

Re: [edk2] [PATCH RFC 03/14] OvmfPkg/XenOvmf.dsc: Introduce XenResetVector

On Wed, Jan 04, 2017 at 08:49:15PM +0100, Laszlo Ersek wrote: > > diff --git a/OvmfPkg/XenResetVector/Ia32/PageTables64.asm > > b/OvmfPkg/XenResetVector/Ia32/PageTables64.asm > > new file mode 100644 > > index 000..b5a4cf8 > > --- /dev/null > > +++

Re: [edk2] [PATCH RFC 00/14] Specific platform to run OVMF in Xen PVH and HVM guests

On Wed, Jan 04, 2017 at 08:52:00PM +0100, Laszlo Ersek wrote: > On 12/08/16 16:33, Anthony PERARD wrote: > > Hi, > > > > I've started to create a Xen specifig plaform, in OvmfPkg/XenOvmf.dsc > > with the goal to make it work on both Xen HVM and Xen PVHv2 > > Does this mean we can ultimately move

Re: [edk2] TPL of RegisterKeyNotify

just FYI, mantis links are useless if you don't have access to that ;) I don't know what this is usually used for but making some parts of uefi.org public doesn't sound like a bad idea to me. Thanks Michael On Mon, Dec 12, 2016 at 2:07 AM, Zeng, Star wrote: > Michael, > >

Re: [edk2] [PATCH] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

Chris, Could you also correct the typo "Assert" to "Asset"? With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:55 PM To:

Re: [edk2] [PATCH] ShellPkg: Update smbiosview command to display Type 3 values

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:53 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu

Re: [edk2] [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:49 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] Nt32Pkg: Fixes to correctly set SMBIOS Type 3

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Phillips Sent: Tuesday, January 10, 2017 2:57 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [edk2] [PATCH] Nt32Pkg:

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Hi Feng, What’s the commit number of the old EDKII UFS driver? Best Regards Haojian From: Tian, Feng Sent: 2017年1月10日 15:47 To: haojian.zhu...@linaro.org; leif.lindh...@linaro.org;

[edk2] [PATCH 8/8] MdeModulePkg/TerminalDxe: Fix driver model bug

TerminalDxe driver contains bugs in its DriverBindingStart(): 1. It cannot be started AGAIN using a different terminal type; 2. It doesn't install SimpleTextInput/SimpleTextOut when ConIn/ConOut doesn't contain its device path. The check is duplicated of the same logic in ConPlatform driver

[edk2] [PATCH 5/8] MdeModulePkg/TerminalDxe: Refine SetTerminalDevicePath

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 41 ++ 1 file changed, 3 insertions(+), 38

[edk2] [PATCH 7/8] MdeModulePkg/TerminalDxe: Remove unnecessary NULL pointer check

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

[edk2] [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 50 ++-- .../Universal/Console/TerminalDxe/Terminal.h

[edk2] [PATCH 3/8] MdeModulePkg/TerminalDxe: Separate controller name init logic

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 147 - 1 file changed, 56 insertions(+), 91

[edk2] [PATCH 6/8] MdeModulePkg/TerminalDxe: Separate state machine start/stop logic

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 85 +++--- 1 file changed, 59 insertions(+), 26

[edk2] [PATCH 0/8] Fix TerminalDxe driver model bug

Patches 1~7 cleans up the TerminalDxe driver without functionality impact. Patch 8 fixes the driver model bug. Ruiyu Ni (8): MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types MdeModulePkg/TerminalDxe: Add TerminalTypeFromGuid internal function MdeModulePkg/TerminalDxe:

[edk2] [PATCH 4/8] MdeModulePkg/TerminalDxe: Refine InitializeTerminalConsoleTextMode

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 108 + 1 file changed, 26 insertions(+), 82

[edk2] [PATCH 2/8] MdeModulePkg/TerminalDxe: Add TerminalTypeFromGuid internal function

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 55 -- 1 file changed, 29 insertions(+), 26