On September 13, 2017 2:08:54 AM GMT-03:00, "Zeng, Star"
wrote:
>I do not understand the context of the code.
>The change is good to fix the build failure, but I want to ask a
>question before I gave Rb. :)
>
>Is it possible ReadFileInfo->FilePosition less than
I do not understand the context of the code.
The change is good to fix the build failure, but I want to ask a question
before I gave Rb. :)
Is it possible ReadFileInfo->FilePosition less than FilePosition?
Thanks,
Star
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
This patch gets rid of a negative comparison of an UINT64 type (Offset)
as it'll never evaluate to true.
Cc: Star Zeng
Cc: Eric Dong
Cc: Ruiyu Ni
Cc: Dandan Bi
Contributed-under: TianoCore Contribution
Hi,
On 13/09/2017 00:31, Zeng, Star wrote:
Could you help send the patch quickly? As it breaks some platforms build and
blocks others' development on that platform, for example Nt32.
Yep. Sorry for the delay. I'll send it shortly.
Thanks!
Paulo
Thanks,
Star
-Original Message-
But what if you're running some unknown app that you don't know the
return code format in the ExitData? It seems to just read that the
ExitData will be some text followed by some binary data.
On Mon, Sep 11, 2017 at 12:43 AM, Gao, Liming wrote:
> Per UEFI spec,
Could you help send the patch quickly? As it breaks some platforms build and
blocks others' development on that platform, for example Nt32.
Thanks,
Star
-Original Message-
From: Paulo Alcantara [mailto:pca...@zytor.com]
Sent: Tuesday, September 12, 2017 9:03 PM
To: Zeng, Star
I am going to hold the patch.
Unless some real issue is exposed using current PciBus driver, I will not make
any change to current implementation.
Thanks/Ray
> -Original Message-
> From: Benjamin Herrenschmidt [mailto:b...@au1.ibm.com]
> Sent: Wednesday, September 13, 2017 7:38 AM
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 13, 2017 6:26 AM
> To: edk2-devel-01
> Cc: Ard Biesheuvel ; Dong, Eric
>
Hi,
MvSpiDxe.c:MvSpiTransfer() attempts load data into DataInPtr, which is
a possibly NULL pointer.
https://github.com/tianocore/edk2-platforms/blob/master/Platform/Marvell/Drivers/Spi/MvSpiDxe.c#L228
/ SNIP /
for (Iterator = 0; Iterator < SPI_TIMEOUT;
Repo: https://github.com/lersek/edk2.git
Branch: udf_fixes_cleanups_round2
Once these patches are sufficiently reviewed, please don't wait for me
to commit them.
Further UdfDxe issues should be please reported in the TianoCore
Bugzilla.
Cc: Ard Biesheuvel
Cc: Eric
The ECMA-167 standard (3rd Edition, June 1997) reserves values 4 through 7
in the ICB.Flags[2:0] bit-field for future standardization; see "14.6 ICB
Tag" / "14.6.8 Flags (RBP 18)".
https://www.ecma-international.org/publications/standards/Ecma-167.htm
The
switch (RecordingFlags)
statement in
When building the driver for DEBUG/RELEASE, GCC48/GCC49 warn about
ReadFile() possibly using "BytesLeft" without initializing it first.
This is not the case. The reads of "BytesLeft" are only reachable if
(ReadFileInfo->Flags == READ_FILE_SEEK_AND_READ). But, in that case, we
also set "BytesLeft"
On 09/12/17 17:38, Ard Biesheuvel wrote:
> On 12 September 2017 at 03:14, Laszlo Ersek wrote:
>> On 09/10/17 02:12, Laszlo Ersek wrote:
>>> Repo: https://github.com/lersek/edk2.git
>>> Branch: udf_fixes_cleanups
>>>
>>> Patches #2, #3 and #4 are needed (and enough) for me to
On 09/12/17 17:49, Ard Biesheuvel wrote:
> On 12 September 2017 at 01:40, Laszlo Ersek wrote:
>> On 09/12/17 08:44, Ard Biesheuvel wrote:
>>> On 12 September 2017 at 06:01, Ni, Ruiyu wrote:
Laszlo,
Your understanding is: DeviceAddress =
On 12 September 2017 at 01:40, Laszlo Ersek wrote:
> On 09/12/17 08:44, Ard Biesheuvel wrote:
>> On 12 September 2017 at 06:01, Ni, Ruiyu wrote:
>>> Laszlo,
>>> Your understanding is: DeviceAddress = HostAddress +
>>> AddressTranslationOffset
>>> But my
On 12 September 2017 at 03:14, Laszlo Ersek wrote:
> On 09/10/17 02:12, Laszlo Ersek wrote:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: udf_fixes_cleanups
>>
>> Patches #2, #3 and #4 are needed (and enough) for me to build OVMF for
>> IA32 and X64 with clang-3.8,
Hi,
On 9/12/2017 6:39 AM, Zeng, Star wrote:
There is change(type cast to INT64) below in this patch. After check, we found the " if
(Offset < 0) " should be always false comparison as Offset is UINT64 type.
I have suggested Dandan to remove this change(type case to INT64) at v3 patch
series
On 09/12/17 03:30, Paulo Alcantara wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=704
>
> For root directory, the FID (File Identifier Descriptor) pointer is
> accessible through PRIVATE_UDF_FILE_DATA.Root, whereas non-root
> directory and regular files, their FIDs are accessible
On 09/12/17 08:48, Ard Biesheuvel wrote:
> On 11 September 2017 at 22:08, Laszlo Ersek wrote:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: armvirt_http_usbstor
>>
>> I was... ugh... experimenting with "stuff" over the weekend, and
>> realized these were missing.
>>
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, September 12, 2017 5:39 PM
> To: Methavanitpong, Pipat/メタワニットポン ピパット
>
> Cc: edk2-devel@lists.01.org; masahisa.koj...@linaro.org;
>
Hi,
Is there any reason why are we starting the partition driver again for the same
partition if it's already started.
if (Status == EFI_ALREADY_STARTED) {
return EFI_SUCCESS;
}
Thanks,
Ramesh
___
edk2-devel mailing list
On 09/12/17 11:38, Ni, Ruiyu wrote:
> Star,
> Sizeof is an operator, not a function, like + or -. Not having () is ok.
Ugh, just seeing this now :) So what should I do now?
If Star agrees, I would prefer *not* to add the parens. If Star insists,
I can add them.
Thanks
Laszlo
>> -Original
On 09/12/17 10:55, Zeng, Star wrote:
> Reviewed-by: Star Zeng
>
> BTW: How about to use "sizeof ()" instead of "sizeof"?
"sizeof" is a unary operator. The parentheses are mandatory when sizeof
is used with a type name, but when the operand of sizeof is an
expression, the
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, September 12, 2017 4:56 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Paulo Alcantara ;
> Ni, Ruiyu ; Zeng, Star
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, September 12, 2017 4:56 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Paulo Alcantara ;
> Ni, Ruiyu ; Zeng, Star
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, September 12, 2017 4:56 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric
Star,
Sizeof is an operator, not a function, like + or -. Not having () is ok.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, September 12, 2017 4:55 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@lists.01.org>
> Cc: Ard Biesheuvel
Hi Paulo,
There is change(type cast to INT64) below in this patch. After check, we found
the " if (Offset < 0) " should be always false comparison as Offset is UINT64
type.
I have suggested Dandan to remove this change(type case to INT64) at v3 patch
series
Reviewed-by: Star Zeng and pushed the patches at
https://github.com/tianocore/edk2/compare/1f4807074005...c05cae55ebd8.
I also picked up the Reviewed-by of Paulo at
https://lists.01.org/pipermail/edk2-devel/2017-September/014490.html when
pushing the patches.
I also fixed
Reviewed-by: Star Zeng
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Sunday, September 10, 2017 8:13 AM
To: edk2-devel-01
Cc: Ard Biesheuvel ; Dong, Eric
; Paulo
Initialize the array DescriptorLBAs[] after declaration to fix
non-constant aggregate initializer warning in VS tool chains.
Cc: Eric Dong
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Contributed-under:
Initialize the array DescriptorLBAs[] after declaration to fix
non-constant aggregate initializer warning in VS tool chains.
Cc: Eric Dong
Cc: Paulo Alcantara
Cc: Ruiyu Ni
Cc: Star Zeng
Contributed-under:
V3: Remove one unnecessay type cast in patch 1.
Codes:
if (FilePosition + ExtentLength > ReadFileInfo->FilePosition) {
Offset = ReadFileInfo->FilePosition - FilePosition;
if (Offset < 0) {
Offset = -(Offset)
}
...
}
offset is UINT64 can not < 0, so the code logic may have some issue.
and
V3: Remove one unnecessay type cast in patch 1.
Dandan Bi (3):
MdeModulePkg/UdfDxe: Add type cast to fix build failure in VS tools
MdeModulePkg/UdfDxe: Initialize the array after declaration
MdeModulePkg/PartitionDxe: Initialize the array after declaration
Reviewed-by: Star Zeng
BTW: How about to use "sizeof ()" instead of "sizeof"?
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Sunday, September 10, 2017 8:13 AM
To: edk2-devel-01
Cc: Ard Biesheuvel
Reviewed-by: Star Zeng
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Sunday, September 10, 2017 8:13 AM
To: edk2-devel-01
Cc: Ard Biesheuvel ; Dong, Eric
; Paulo
Hi Ting Ye,
Thank you very much for your info.
Thanks,
karunakar
-Original Message-
From: Ye, Ting [mailto:ting...@intel.com]
Sent: Tuesday, September 12, 2017 1:49 PM
To: Karunakar P; edk2-devel@lists.01.org
Subject: RE: [edk2] Question on Iscsi Behavior
Hi Karunakar,
In "Enabled"
Reviewed-by: Star Zeng
I am not sure whether the other patches in this series has been reviewed or not.
Since this patch is fixing build break, I think we can have this patch pushed
first after reviewed. And really appreciate that. :)
Thanks,
Star
-Original
On 09/12/17 08:44, Ard Biesheuvel wrote:
> On 12 September 2017 at 06:01, Ni, Ruiyu wrote:
>> Laszlo,
>> Your understanding is: DeviceAddress = HostAddress + AddressTranslationOffset
>> But my patch assumes: HostAddress = DeviceAddress + AddressTranslationOffset
>>
>> They are
On Tue, Sep 12, 2017 at 01:41:34AM +, methavanitpong.pi...@socionext.com
wrote:
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: Tuesday, September 12, 2017 4:13 AM
> > To: Ard Biesheuvel
> > Cc:
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, September 12, 2017 3:59 PM
> To: Bi, Dandan ; edk2-devel-01 de...@lists.01.org>
> Cc: Ni, Ruiyu ; Dong,
On 09/12/17 07:41, Bi, Dandan wrote:
> Hi Laszlo,
>
> When do you plan to push this patch? IA32 build is blocked for this issue now.
I was ready to push the series yesterday; I just hoped I'd get review
feedback from MdeModulePkg maintainers as well, and/or from Ray, in one
or two days.
These
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Monday, September 04, 2017 4:44 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [Patch] BaseTools: add support for BIOS build with binary cache
>
>Add three new
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Monday, September 04, 2017 4:43 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
You can load and start the image based on PeCoffLib APIs in BasePeCoffLib
instead of LoadImage() and StartImage() service.
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>David F.
>Sent: Friday, September 08, 2017 11:34 PM
>To: Gary Lin
On 11 September 2017 at 22:08, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: armvirt_http_usbstor
>
> I was... ugh... experimenting with "stuff" over the weekend, and
> realized these were missing.
>
> Cc: Ard Biesheuvel
On 12 September 2017 at 06:01, Ni, Ruiyu wrote:
> Laszlo,
> Your understanding is: DeviceAddress = HostAddress + AddressTranslationOffset
> But my patch assumes: HostAddress = DeviceAddress + AddressTranslationOffset
>
> They are totally different. If I follow your
47 matches
Mail list logo