It looks good to me. I will strip the trailing space when push this patch.
Best Regards,
Zhu Yonghong
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, May 05, 2018 6:43 AM
To: Carsey, Jaben ; edk2-devel@lists.01.org
Cc: Gao,
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 3:02 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 2:53 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 2:49 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Daniil Egranov
Sent: Wednesday, April 18, 2018 2:51 PM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; jiewen@intel.com;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 2:32 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 25, 2018 9:50 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Daniil Egranov
Sent: Wednesday, April 18, 2018 5:09 PM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; jiewen@intel.com;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 10:51 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 30, 2018 9:30 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
Jiewen,
It checks for HOB by GUID gMmCoreDataHobGuid first,
if it's not present, then it checks for HOB by GUID
gEfiMmPeiMmramMemoryReserveGuid. (which is the case for Arm and intel won't be
affected by this)
So it is as generic as possible and hence I think there is no need for ARM
specific
My response inline.
-Original Message-
From: Yao, Jiewen
Sent: Thursday, April 26, 2018 8:04 AM
To: Achin Gupta ; Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; Kinney, Michael D ;
Gao,
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 25, 2018 9:34 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 16, 2018 10:13 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 16, 2018 9:44 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Monday, April 16, 2018 9:04 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
Thanks.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 11, 2018 2:24 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 11, 2018 2:22 PM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 11, 2018 9:38 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 11, 2018 9:00 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Achin Gupta
Sent: Wednesday, April 11, 2018 9:43 AM
To: Supreeth Venkatesh
Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming@intel.com;
jiewen@intel.com; leif.lindh...@linaro.org;
My response inline.
-Original Message-
From: Yao, Jiewen
Sent: Sunday, April 8, 2018 1:02 AM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Gao, Liming
; Achin
> -Original Message-
> From: Achin Gupta
> Sent: Wednesday, April 11, 2018 9:43 AM
> To: Supreeth Venkatesh
> Cc: edk2-devel@lists.01.org; michael.d.kin...@intel.com; liming.gao@i
> ntel.com; jiewen@intel.com; leif.lindh...@linaro.org; ard.biesheu
>
On 05/04/18 23:47, Carsey, Jaben wrote:
> Thanks. I don’t push BaseTools, but will await Liming or Yonghong to review
> and push.
Ah, sure, I didn't mean that you should skip their review; I thought
you'd push the patch after their review (you co-maintain several
packages, so technically you
Thanks. I don’t push BaseTools, but will await Liming or Yonghong to review
and push.
Yonghong/Liming, Can you strip the trailing space before you commit?
-Jaben
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, May 04, 2018 2:44 PM
> To: Carsey,
Hi Jaben.
On 05/04/18 22:25, Jaben Carsey wrote:
> Commit eece4292acc80 changed a variable name, which was tied directly to
> a config file entry. This seperates the internal variable names from
> the config file entries by having the internal dict accessed through a
> translation of key words.
>
Add a library class, and a UEFI_DRIVER lib instance, that are layered on
top of PciCapLib, and allow clients to plug an EFI_PCI_IO_PROTOCOL backend
into PciCapLib, for config space access.
(Side note:
Although the UEFI spec says that EFI_PCI_IO_PROTOCOL_CONFIG() returns
EFI_UNSUPPORTED if "[t]he
Replace the manual capability list parsing in OvmfPkg/Virtio10Dxe with
PciCapLib and PciCapPciIoLib API calls.
The VIRTIO_PCI_CAP_LINK structure type is now superfluous. (Well, it
always has been; we should have used EFI_PCI_CAPABILITY_HDR.)
Also, EFI_PCI_CAPABILITY_VENDOR_HDR is now included at
Resolve the PciCapLib, PciCapPciSegmentLib, and PciCapPciIoLib classes to
their single respective instances under MdePkg. Later patches will use
those lib classes in OvmfPkg drivers, some of which are included in
ArmVirt platforms.
Cc: Ard Biesheuvel
Contributed-under:
Replace the manual capability list parsing in OvmfPkg/PciHotPlugInitDxe
with PciCapLib and PciCapPciSegmentLib API calls.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo
Add a library class, and a BASE lib instance, that are layered on top of
PciCapLib, and allow clients to plug a PciSegmentLib backend into
PciCapLib, for config space access.
(Side note:
The "MaxDomain" parameter is provided because, in practice, platforms
exist where a PCI Express device may
Resolve the PciCapLib, PciCapPciSegmentLib, and PciCapPciIoLib classes to
their single respective instances under MdePkg. Later patches will use
those lib classes in OvmfPkg drivers.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Contributed-under:
Repo: https://github.com/lersek/edk2.git
Branch: pci_cap
In message [1], Jordan suggested a general "capabilities helper lib that
could iterate & read the PCI capability structs". Patch #1 introduces
that library (class and central BASE instance) to MdePkg; the library
class is called
Add a library class, and a BASE lib instance, to work more easily with PCI
capabilities in PCI config space. Functions are provided to parse
capabilities lists, and to locate, describe, read and write capabilities.
PCI config space access is abstracted away.
Cc: Ard Biesheuvel
This patch adds description file and firmware device file to generate
secure world Standalone Management Mode (MM) image on AArch64 FVP. The
secure world Standalone Management Mode (MM) image generated on AArch64
FVP feeds into the fiptool as BL32 image.
These files provide reference for
This patch implements management mode memory allocation services.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
Reviewed-by: Achin Gupta
Reviewed-by: Jiewen Yao
---
The Standalone MM drivers runs in S-EL0 in AArch64 on ARM Standard
Platforms and is deployed during SEC phase. The memory allocated to the
Standalone MM drivers should be marked as RO+X.
During PE/COFF Image section parsing, this patch implements extra action
"UpdatePeCoffPermissions" to request
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard
Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its
architectural context including the initial translation tables for the
S-EL1/EL0 translation regime. The MM environment will still request ARM
TF to change
This patch enables MmCommunicationDxe on AArch64 Fixed Virtual
Platform (FVP) by defining required PCDs and driver inf file.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
---
***
PI Specification v1.5 "Volume 4: Management Mode Core Interface"
introduces the concept of MM Standalone Mode. This patchset enables
Standalone Management Mode Core Interface on AARCH64 FVP.
***
Supreeth Venkatesh (2):
VExpressPkg: Add dsc and fdf files for generating Standalone MM Image.
The Standalone MM environment is initialized during the SEC phase on ARM
Standard Platforms. The MM Core driver implements an entry point module
which is architecture specific and runs prior to the generic core driver
code. The former creates a Hob list that the latter consumes. This
happens in
This patch defines PCDs to describe the base address and size of
communication buffer between normal world (uefi) and standalone MM
environment in the secure world.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Achin Gupta
Signed-off-by: Supreeth
This patch adds a simple CPU driver that exports the
EFI_MM_CONFIGURATION_PROTOCOL to allow registration of the Standalone
MM Foundation entry point. It preserves the existing notification
mechanism for the configuration protocol.
Contributed-under: TianoCore Contribution Agreement 1.1
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard
Platforms and is initialised during the SEC phase. ARM Trusted firmware
in EL3 is responsible for initialising the architectural context for
S-EL0 and loading the Standalone MM image. The memory allocated to this
image is
This patch describes the package declarations and definitions
for creating standalone management mode image with
core/foundation and drivers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
Reviewed-by: Achin Gupta
This patch corrects the Module Type Header file for Management Mode(MM)
as specified in PI v1.6 Specification. Also, it updates parameter for
auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to
EFI_MM_SYSTEM_TABLE.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
This patch adds the definitions, sources, packages and library classes
needed to compile and link MMU Library suitable for use in S-EL0.
Currently, this is used only during the Standalone MM Core
initialization and hence defined as MM_CORE_STANDALONE Module.
Contributed-under: TianoCore
This patch implements a firmware volume library that can be used by the
Standalone management mode core module to parse the firmware volume.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
Reviewed-by: Achin Gupta
MM memory check library library implementation. This library consumes
MM_ACCESS_PROTOCOL to get MMRAM information. In order to use this
library instance, the platform should produce all MMRAM range via
MM_ACCESS_PROTOCOL, including the range for firmware (like MM Core
and MM driver) and/or
This patch deletes "StandaloneMmPkg" which was created as a file
intially. This patch creates "StandaloneMmPkg" as a folder.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh
Reviewed-by: Achin Gupta
***
PI Specification v1.5 "Volume 4: Management Mode Core Interface"
introduces the concept of MM Standalone Mode. Initialization of this mode
can be done during the SEC phase (Section 1.5.2).
On ARMv8-A systems, ARM Trusted Firmware is responsible for launching
the normal world firmware e.g.
This patch adds the Management Mode(MM) - Secure Partition Manager(SPM) SVC
return codes.
Also, It corrects SVC ID for retrieving SPM version information.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Achin Gupta
Signed-off-by: Supreeth Venkatesh
PI v1.5 Specification Volume 4 defines Management Mode Core Interface
and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a
means of communicating between drivers outside of MM and MMI
handlers inside of MM.
This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE runtime
driver
Commit eece4292acc80 changed a variable name, which was tied directly to
a config file entry. This seperates the internal variable names from
the config file entries by having the internal dict accessed through a
translation of key words.
added a test when this is run straight from command line.
Incoming v3. I found that some more entries in the dict were missing due to
config.ini sample file vs class membership. Not everything was in the sample
file. I also decided to add a test function to use to verify class and dict
completeness.
> -Original Message-
> From: Laszlo Ersek
On 05/04/18 18:46, Jaben Carsey wrote:
> Commit eece4292acc80 changed a variable name, which was tied directly to a
> config file entry. this seperates the itnernal variable names from the
> config file entries by having the internal dict accessed through a translation
> of key words.
>
> Cc:
I worked up and sent out a v2.
I think that if we only use the translation when acing the dict, we can leave
the rest of the code as it.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, May 04, 2018 9:20 AM
> To: Carsey, Jaben
Commit eece4292acc80 changed a variable name, which was tied directly to a
config file entry. this seperates the itnernal variable names from the
config file entries by having the internal dict accessed through a translation
of key words.
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Liming Gao
Cc: Yonghong Zhu
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/Ecc/Configuration.py | 8 +++-
1 file
On 05/04/18 16:18, Carsey, Jaben wrote:
> Laszlo,
>
> Wow. I thought I had tested, but clearly I missed that.
>
> Do you think we just revert back the name change short term? I agree
> that mixing internal data structure names and names in the config
> file seems wrong, I don’t know the ROI
Laszlo,
Wow. I thought I had tested, but clearly I missed that.
Do you think we just revert back the name change short term? I agree that
mixing internal data structure names and names in the config file seems wrong,
I don’t know the ROI for separation. Maybe use a dict to translate?
Hi,
On 04/20/18 17:51, Jaben Carsey wrote:
> remove unused ones
> convert lists used for membership testing to sets
> use shared ones not local ones
>
> Cc: Liming Gao
> Cc: Yonghong Zhu
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Fri, May 04, 2018 at 11:29:33AM +0800, Haojian Zhuang wrote:
> On 2 May 2018 at 23:14, Leif Lindholm wrote:
> >> + { 0xe8a0b000, 0, 8 },// GPIO0
> >
> > It would not improve readability to request all of these live-coded
> > values to be replaced by #defines, but
It is about USB short form device path handling? Check
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c#L1368?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fish
Sent: Friday, May 4,
Reviewed-by: Long Qin
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, May 4, 2018 11:53 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Bi, Dandan
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Friday, April 27, 2018 1:20 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen
> Subject: [PATCH V2] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT
66 matches
Mail list logo