Re: [edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-30 Thread chandni cherukuri
On Thu, Aug 30, 2018 at 6:33 PM Ard Biesheuvel wrote: > > On 30 August 2018 at 13:23, Leif Lindholm wrote: > > On Wed, Aug 29, 2018 at 04:14:16PM +0530, Chandni Cherukuri wrote: > >> Switched from using ACPI 6.1 to 6.2 specification for > >> SGI575 since SBBR 1.1 requires ACPI 6.2 tables or

Re: [edk2] [PATCH edk2-platforms v4 11/31] Silicon/Hisilicon/Acpi: Unify HisiAcpiPlatformDxe

2018-08-30 Thread Ming
On 8/31/2018 2:39 AM, Leif Lindholm wrote: > On Fri, Aug 24, 2018 at 12:07:23AM +0800, Ming Huang wrote: >> The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by >> UpdateAcpiTable.c and Srat aslc. The struct may be different >> according to chips, so move some macro to PlatformArch.h.

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Sync the direct route entry setting.

2018-08-30 Thread Jiaxin Wu
This patch is to sync the direct route entry setting in both the default and Instance route table {Subnet, Mask, NextHope}. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wu Jiaxin --- .../Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 7

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per dec file change

2018-08-30 Thread Wang, Jian J
Sure. Make sense. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, August 31, 2018 9:43 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: RE: [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per > dec file change > >

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per dec file change

2018-08-30 Thread Zeng, Star
Please mention 8f2613628acf601a2a17bb64bb49ef73f85cfe2c (which updated the PCDs in dec) in commit log. Reviewed that, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wang, Jian J Sent: Friday, August 31, 2018 9:22 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

[edk2] [PATCH] MdeModulePkg/MdeModulePkg.uni: update PCD string per dec file change

2018-08-30 Thread Jian J Wang
PcdNullPointerDetectionPropertyMask and PcdHeapGuardPropertyMask have been updated in dec file to reflect a new feature (non-stop mode). This patch updates corresponding unicode strings in uni file to match those changes. Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution

[edk2] Missing ‘or’ in CLA

2018-08-30 Thread Henri Yandell
The CLA is missing an ‘or’ in section 3. See https://github.com/tianocore/edk2/pull/133/files for an example of the specific text. Thanks, Hen ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms v4 00/31] Upload for D06 platform

2018-08-30 Thread Leif Lindholm
Allright, we're getting close. Please generate a v5 based on my comments for v4. If that does not require changes to edk2-non-osi, there is no need to generate a v5 of that. _But_, one big overarching issue: Every commit in the series needs to be buildable. For D03, D05 and D06. There are many

[edk2] Regression with PXE boot on OvmfPkg/VirtioNetDxe driver on aarch64 system

2018-08-30 Thread aaron . young
We have encountered what we believe to be a regression in the OvmfPkg/VirtioNetDxe driver. This regression causes PXE boot to fail with the following ASSERT: ASSERT [VirtioNetDxe]/builddir/build/BUILD/ovmf-92d07e48907f/OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c(184): ((BOOLEAN)(0==1))

Re: [edk2] Remove EDK package from edk2 master

2018-08-30 Thread Kinney, Michael D
Hi Jaben, There is a branch for MinnowMax in edk2-platforms that is tied to UDK2017. https://github.com/tianocore/edk2-platforms/tree/devel-MinnowBoardMax-UDK2017 I agree that the Vlv2*Pkg in edk2/master should be migrated to edk2-platforms. These packages build with the rest of the

Re: [edk2] Remove EDK package from edk2 master

2018-08-30 Thread Carsey, Jaben
Should we move that to edk2-platforms and then it can use a UDK release instead of adding dependencies to master? Thanks -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Kinney, Michael D > Sent: Thursday, August 30, 2018 11:50 AM >

Re: [edk2] [PATCH edk2-platforms v4 07/31] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:19AM +0800, Ming Huang wrote: > Add M41T83RealTimeClockLib for RTC. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/D06.dsc

Re: [edk2] [PATCH edk2-platforms v4 08/31] Platform/Hisilicon/D06: Add edk2-non-osi components for D06

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:20AM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/D06.dsc | 7 +++ > Platform/Hisilicon/D06/D06.fdf | 17 + > 2 files

Re: [edk2] [PATCH edk2-platforms v4 14/31] Hisilicon/D06: Add Hi1620OemConfigUiLib

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:26AM +0800, Ming Huang wrote: > From: Yang XinYi > > This library is added for oem setup menu item. > Setup item include: > 1 DDR option item; > 2 BMC option item; > 3 Ras option item; > 4 Misc option item; > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH edk2-platforms v4 29/31] Silicon/Hisilicon/setup: Enable/disable SMMU

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:41AM +0800, Ming Huang wrote: > Select without SMMU iort while SMMU item is disable, > Select with SMMU iort while SMMU item is enable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- >

Re: [edk2] [PATCH edk2-platforms v4 28/31] Silicon/Hisilicon/Setup: Support SPCR table switch

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:40AM +0800, Ming Huang wrote: > If install SPCR table, KVM will not output while install or boot > some OS, like ubuntu, so add SPCR switch setup item and set it > disable by default. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming

Re: [edk2] [PATCH edk2-platforms v4 27/31] Silicon/Hisilicon: Add I2C Bus Exception handle function

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:39AM +0800, Ming Huang wrote: > During the period of I2c accessing, if the board is reset > unexpectedly, and because the I2c client can not reset, > the SDA will be always pull down, then it cause I2C bus > Exception. > > Follow the Hi1620 I2C FS chapter 1.8.2

Re: [edk2] [PATCH edk2-platforms v4 26/31] Silicon/Hisilicon: Modify for close slave core clock.

2018-08-30 Thread Leif Lindholm
Please update also subject and description to use "disable" and "enable" instead of "close" and "open". On Fri, Aug 24, 2018 at 12:07:38AM +0800, Ming Huang wrote: > From: ZhenYao > > When BIOS booting, the power consumption is too high, so need close > some clusters clock that don't work to

Re: [edk2] Remove EDK package from edk2 master

2018-08-30 Thread Kinney, Michael D
Liming, The Vlv2TbltDevicePkg in edk2/master is using EdkCompatibilityPkg. I have entered a new bug to remove this use of the EdkCompatibilityPkg and added it as a dependency. https://bugzilla.tianocore.org/show_bug.cgi?id=1132 Thanks, Mike > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH edk2-platforms v4 25/31] Platform/Hisilicon/D06: Add capsule upgrade support

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:37AM +0800, Ming Huang wrote: > This module support updating the boot CPU firmware only. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Reviewed-by: Leif Lindholm Ard also gave you a Reviewed-by for this patch, please add

Re: [edk2] [PATCH edk2-platforms v4 24/31] Hisilicon/D06: add apei driver

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:36AM +0800, Ming Huang wrote: > From: Luqi Jiang > > This driver provide a means for the platform to > convey error information to OSPM. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang As far as I can see, this addresses

Re: [edk2] [PATCH edk2-platforms v4 19/31] Platform/Hisilicon/D06: Add OemNicLib

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:31AM +0800, Ming Huang wrote: > OemNicLib provide nic related api like GetMac,SetMac. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc | 1 + >

Re: [edk2] [PATCH edk2-platforms v4 16/31] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP"

2018-08-30 Thread Leif Lindholm
Can you add Hi1620 to the subject line, so it's clear that this is a D06-specific library? With that Reviewed-by: Leif Lindholm / Leif On Fri, Aug 24, 2018 at 12:07:28AM +0800, Ming Huang wrote: > From: Yang XinYi > > Add Setup Item "EnableGOP" for D06, This Item only takes > effect on

Re: [edk2] [PATCH edk2-platforms v4 11/31] Silicon/Hisilicon/Acpi: Unify HisiAcpiPlatformDxe

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:23AM +0800, Ming Huang wrote: > The EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE struct is used by > UpdateAcpiTable.c and Srat aslc. The struct may be different > according to chips, so move some macro to PlatformArch.h. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms v4 01/31] Silicon/Hisilicon/Acpi: Move some macro to PlatformArch.h

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:13AM +0800, Ming Huang wrote: > ARM_ACPI_HEADER is used by a unify module in HwPkg, > so move some macro to PlatformArch.h for unify D0x. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm 1,3-5/31

Re: [edk2] [PATCH edk2-platforms v4 02/31] Silicon/Hisilicon/D0x: Move RAS macro to PlatformArch.h

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:14AM +0800, Ming Huang wrote: > From: Sun Yuanchen > > Move some RAS macros definition to PlatformArch.h for > unifying D0x > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sun Yuanchen This still has incorrect sign-off in v4. Please

Re: [edk2] [PATCH edk2-platforms v4 06/31] Hisilicon/D06: Add several base file for D06

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:18AM +0800, Ming Huang wrote: > Add several base head files and add several build > files for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Reviewed-by: Leif Lindholm > --- > Platform/Hisilicon/D06/D06.dec

Re: [edk2] [PATCH edk2-platforms v4 10/31] Silicon/Hisilicon/D06: Wait for all disk ready

2018-08-30 Thread Leif Lindholm
On 23 August 2018 at 17:07, Ming Huang wrote: > > This patch is relative to D06 SasDxe driver. The SasDxe set a > variable to notice this libray. Here Wait for all disk ready > for 15S at most. > > D06: > For using straight-through hard disk backboard, some disk need > 15 seconds to ready.

Re: [edk2] [PATCH edk2-platforms v4 30/31] Hisilicon/D06: Add PciPlatformLib

2018-08-30 Thread Leif Lindholm
On Fri, Aug 24, 2018 at 12:07:42AM +0800, Ming Huang wrote: > Add a Null PciPlatformLib for build D06. The switch generic > PciHostBridge patch set add two api for PciPlatform driver, > so need to implement the two api for D06. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH v1 1/1] BaseTools: minimize assignment processing

2018-08-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, August 29, 2018 6:51 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools: minimize assignment processing Reverse the checking

Re: [edk2] [PATCH v1 1/1] BaseTools: Clarify a DSC parsing error about PCDs

2018-08-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, August 29, 2018 11:16 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming ; Hamel, Lee M Subject: [PATCH v1 1/1] BaseTools: Clarify a DSC parsing error about PCDs

Re: [edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-30 Thread Ard Biesheuvel
On 30 August 2018 at 13:23, Leif Lindholm wrote: > On Wed, Aug 29, 2018 at 04:14:16PM +0530, Chandni Cherukuri wrote: >> Switched from using ACPI 6.1 to 6.2 specification for >> SGI575 since SBBR 1.1 requires ACPI 6.2 tables or later. > > Just to clarify - this has no impact at all on the actual

Re: [edk2] [PATCH v1 1/1] BaseTools: Refactor to remove functionally equivalent functions

2018-08-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, August 29, 2018 10:42 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools: Refactor to remove functionally equivalent functions

Re: [edk2] [Patch] BaseTools: include variable namespace GUIDs of HII PCDs in Guid.xref

2018-08-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, August 29, 2018 11:57 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools:

Re: [edk2] [PATCH edk2-platforms] sgi575/acpi: Use ACPI 6.2 specification

2018-08-30 Thread Leif Lindholm
On Wed, Aug 29, 2018 at 04:14:16PM +0530, Chandni Cherukuri wrote: > Switched from using ACPI 6.1 to 6.2 specification for > SGI575 since SBBR 1.1 requires ACPI 6.2 tables or later. Just to clarify - this has no impact at all on the actual generated tables, right? We really should have a better

Re: [edk2] [PATCH 1/2] MdeModulePkg PeiCore: Handle multiple FV images in one FV file

2018-08-30 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Wednesday, August 29, 2018 5:38 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming ; >Yao, Jiewen >Subject: [PATCH 1/2] MdeModulePkg PeiCore: Handle multiple FV images in >one FV file > >REF:

Re: [edk2] [PATCH 2/2] MdeModulePkg DxeCore: Handle multiple FV images in one FV file

2018-08-30 Thread Zeng, Star
Oh, yes, agree. I should update description. Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, August 30, 2018 5:55 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [PATCH 2/2] MdeModulePkg DxeCore: Handle multiple FV images in one FV file Star:

Re: [edk2] [PATCH 2/2] MdeModulePkg DxeCore: Handle multiple FV images in one FV file

2018-08-30 Thread Gao, Liming
Star: You change the parameter name in the function. Please also update the function description to match the function implementation. Thanks Liming >-Original Message- >From: Zeng, Star >Sent: Wednesday, August 29, 2018 5:38 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao,

[edk2] [Patch] BaseTools: Enable LTO option in XCODE5 tool chain

2018-08-30 Thread Liming Gao
LTO option can achieve the better image size and boot performance. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Andrew Fish --- BaseTools/Conf/tools_def.template | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [edk2] Remove EDK package from edk2 master

2018-08-30 Thread Laszlo Ersek
On 08/30/18 03:36, Gao, Liming wrote: > EDK2 plans to retire EDK style packages. Below BZ requests to remove > FatBinPkg, EdkShellPkg, EdkShellBinPkg and EdkCompatiblityPkg from edk2 > master. They can be replaced by Edk2 FatPkg, ShellBinPkg and ShellPkg. > UnixPkg is an empty package. So, it

Re: [edk2] [PATCH v2] MdeModulePkg/Network: Add 32bit subnet mask support for IP4 PXE boot.

2018-08-30 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, August 29, 2018 4:53 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: [PATCH v2] MdeModulePkg/Network: Add 32bit subnet mask > support for IP4 PXE boot. > > V2 update: > The

Re: [edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask.

2018-08-30 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, August 28, 2018 9:53 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jiaxin > > Subject: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit > subnet mask. > >

Re: [edk2] [Patch] BaseTools: Fixed the PcdValue trailing zero issue.

2018-08-30 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, August 28, 2018 6:23 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fixed the PcdValue trailing zero issue. > >1. Not append trailing zero for PcdValue >2. make

Re: [edk2] reg: Clarification required on ISCSI Initiator Implementation

2018-08-30 Thread Ye, Ting
Hi Siva, The EFI_ISCSI_INITIATOR_NAME_PROTOCOL defined in UEFI specification supports only one iSCSI initiator name in UEFI system. In our implementation UEFI iSCSI is a single iSCSI initiator node but can maintain more than one NIC device/port. Thanks, Ting -Original Message- From:

Re: [edk2] [PATCH] BaseTools: Check pcd DefaultValue and SkuId EBNF.

2018-08-30 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Monday, August 27, 2018 9:30 AM >To: edk2-devel@lists.01.org >Cc: Zhao, ZhiqiangX ; Gao, Liming >; Zhu, Yonghong ; Feng, >Bob C >Subject: [PATCH] BaseTools: Check pcd DefaultValue and SkuId EBNF. > >From: Zhaozh1x >