On 10/17/2018 10:16 AM, Eric Dong wrote:
AcpiCpuData add new fields, keep these fields if old data already existed.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 2 ++
1 file
On 10/17/2018 10:16 AM, Eric Dong wrote:
Because this driver needs to set MSRs saved in normal boot phase, sync semaphore
logic from RegisterCpuFeaturesLib code which used for normal boot phase.
Detail see below change for RegisterCpuFeaturesLib:
UefiCpuPkg/RegisterCpuFeaturesLib: Add logic
On 10/17/2018 10:16 AM, Eric Dong wrote:
V2 changes include:
1. Add more description for the code part which need easy to understand.
2. Refine some code base on feedback for V1 changes.
V1 changes include:
In a system which has multiple cores, current set register value task costs
huge times.
PcdValueInit tool is Arch independent, the Arch specific
build options should be removed from PcdValueInit makefile.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob C Feng
Cc: Liming Gao
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1
V2:
Fixed 3 typo.
Use startswith(('L"',"L'")) to check if a string is Unicode string.
Use a set PcdValueTypeSet instead of a list PcdValueTypeList to save
memory.
V1:
For the same one VOID* pcd, if the default value type of one SKU is
"Unicode string", the other SKUs are "OtherVOID*"(ASCII string
Good unit test result.
Thank you Chasel.
Here is my thought.
1) Can we change FspApiModeEnabled to FspMode?
And we can define mode below:
#define FSP_API_MODE 0
#define FSP_DISPATCH_MODE 1
2) Can we change gFspApiModePpiGuid to gFspApiModeEnablePpiGuid to make it
clear?
Other seems
Thanks Ting, I will update the comments against the function.
> -Original Message-
> From: Ye, Ting
> Sent: Thursday, October 18, 2018 11:26 AM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: RE: [edk2] [Patch] NetworkPkg/IpSecDxe: Fix issue to parse
On 10/17/2018 10:16 AM, Eric Dong wrote:
Add new core/package dependence types which consumed by different MSRs.
Cc: Ruiyu Ni
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
.../Include/Library/RegisterCpuFeaturesLib.h | 25
Hi Jiaxin,
I am confused why we need set values to following local variables when
Ikev2ParseProposalData marks them as 'out' attribute. Please adds more comments
why '0' is required and updates 'out' to 'in out' if '0' is necessary.
+IntegrityAlgorithm = 0;
+EncryptAlgorithm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1241
Add support for both API (original mode) and DISPATCH mode:
1. Add FspApiModeEnabled field from reserved byte of Global
Data Structure to tell which mode is selected by boot
loader. If boot loader invoking FSP-M API this field
will
On 10/17/2018 10:16 AM, Eric Dong wrote:
v2 changes:
1. Add more description about why we do this change.
2. Change structure field type from pointer to EFI_PHYSICAL_ADDRESS because it
will
be share between PEI and DXE.
In order to support semaphore related logic, add new definition for
On 2018/10/16 10:06, Liming Gao wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=686
Liming Gao (3):
MdePkg: Add more checker in UefiDecompressLib to access the valid
buffer only
IntelFrameworkModulePkg: Add more checker in UefiTianoDecompressLib
BaseTools: Add more checker
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, October 16, 2018 1:36 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin
Subject: [Patch] NetworkPkg: Correct the time stamp and fix the integer
overflow issue.
Ref:
Thanks for the detailed comments.
Very minor comments in below.
On 10/17/2018 10:16 AM, Eric Dong wrote:
v2 changes:
1. Add more description about why we do this change.
2. Change structure field type from pointer to EFI_PHYSICAL_ADDRESS because it
will
be share between PEI and DXE.
In
Hi
Would you please share what test has been done?
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Thursday, October 18, 2018 10:35 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2]
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, October 16, 2018 9:55 AM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/TlsDxe: Remove the redundant library class.
Ref:
Hi Laszlo,
On 2018/10/18 2:27, Laszlo Ersek wrote:
+Stephano
On 10/17/18 16:58, Zeng, Star wrote:
On 2018/10/17 21:10, Laszlo Ersek wrote:
I have requested earlier [1], and now I'm doing so again, that CVE fixes
please all mention the CVE number in the *subject line*. When people
look at
Hi Ruiyu,
Below link with my changes:
https://github.com/ydong10/edk2/tree/MSR
Thanks,
Eric
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, October 18, 2018 10:13 AM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Laszlo Ersek
> Subject: RE: [Patch v2 0/6] Fix performance
In order to remove FatBinPkg, relationships depend on
FatBinPkg need to be replaced by FatPkg.
v2:
1.Replace FatBinPkg with FatPkg in CoreUefiBootInclude.fdf.
2.Update the subject.
Change-Id: I8949ad1c7d18abc56deac2d4b4381e00f030dcb2
Contributed-under: TianoCore Contribution Agreement 1.1
In order to remove FatBinPkg, relationships depend on
FatBinPkg needs to be replaced by FatPkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc | 2 +-
1 file changed, 1 insertion(+), 1
Mike,
All those functions are declared in source files in Visual Studio except to
__GSHandlerCheck(). But I can't find there's online link or document to those
files
and APIs. Is it ok to just list the file names?
VC\INCLUDE\vcruntime.h:
__security_check_cookie
__report_gsfailure
On Thu, Oct 18, 2018 at 09:08:04AM +0800, Ard Biesheuvel wrote:
> On 17 October 2018 at 19:18, Laszlo Ersek wrote:
> > On 10/16/18 09:11, shenglei wrote:
> >> Remove FatBinPkg and modify Maintainers.txt.
> >> https://bugzilla.tianocore.org/show_bug.cgi?id=1105
> >>
> >> Cc: Ruiyu Ni
> >>
Eric,
Can you post your changes to github yours mirror repo?
I found #3/6 cannot be applied to my code properly.
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, October 17, 2018 10:16 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [Patch
On 10/18/2018 1:57 AM, Laszlo Ersek wrote:
Hi Jian,
On 10/17/18 10:34, Jian J Wang wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1237
Sometimes the memory will be contaminated by random data left in last
boot (warm reset). The code should not assume the allocated memory is
On 9/30/2018 6:23 AM, Laszlo Ersek wrote:
The "GccInline.c" files have some inconsistent whitespace, and missing (or
incorrect) operand comments. Fix and unify them.
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Michael D Kinney
Ref:
Hi Eugene,
Could you help to file a bugzilla ? thanks.
Refer to https://github.com/tianocore/tianocore.github.io/wiki/Reporting-Issues
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen,
Eugene
Sent: Thursday,
Jian,
Is there a link to the documentation for these new
functions? We should put the link in the file
headers.
The link to docs should also be added to the BZ.
Also, which VS compilers was this tested with? Are
different implementations required for different VS
compilers?
Mike
>
Jian:
The patch is good to me. Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Wang, Jian J
>Sent: Thursday, October 18, 2018 9:19 AM
>To: edk2-devel ; edk2-devel@lists.01.org
>Cc: Kinney, Michael D ; Yao, Jiewen
>; Andrew Fish ; Gao, Liming
>
>Subject: RE: [edk2]
From: Hess Chen
V2: change list to set
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Ecc/Check.py | 60
BaseTools/Source/Python/Ecc/Configuration.py | 3 ++
Ping ... :)
Regards,
Jian
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]
> Sent: Tuesday, October 16, 2018 8:59 AM
> To: edk2-devel ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Yao, Jiewen
> ; Andrew Fish ; Gao, Liming
>
> Subject: Re: [edk2]
> On Oct 17, 2018, at 6:08 PM, Ard Biesheuvel wrote:
>
> On 17 October 2018 at 19:18, Laszlo Ersek wrote:
>> On 10/16/18 09:11, shenglei wrote:
>>> Remove FatBinPkg and modify Maintainers.txt.
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=1105
>>>
>>> Cc: Ruiyu Ni
>>>
On 17 October 2018 at 19:18, Laszlo Ersek wrote:
> On 10/16/18 09:11, shenglei wrote:
>> Remove FatBinPkg and modify Maintainers.txt.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1105
>>
>> Cc: Ruiyu Ni
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Shenglei
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, October 17, 2018 8:36 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix a bug --pcd option enable and use the
>pcd in
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Wednesday, October 17, 2018 8:18 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Fix bug caused by 03c36c36a3
>
>In the expression
Reviewed-by: Eric Dong
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, October 17, 2018 4:35 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Laszlo Ersek ; Ni,
> Ruiyu
> Subject: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: always clear
> descriptor data in advance
>
>
Good suggestion, will update the patch.
Chen, Hess
Intel China Software Center
Tel: +86-21-6116-6740
Email: hesheng.c...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey,
Jaben
Sent: Wednesday, October 17, 2018 11:49 PM
To: Zhu,
Unicode string should be start with 'L"' or "L'", but like as "Less" is not
Unicode string
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Thursday, October 18, 2018 2:49 AM
> To: Laszlo Ersek ; Zhao, ZhiqiangX
>
>
Laszlo,
Thanks for the comments. I'll update the code.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 18, 2018 1:57 AM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Dong, Eric ; Ni, Ruiyu
> Subject: Re: [PATCH]
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, October 17, 2018 11:37 AM
> To: Zhao, ZhiqiangX
> Cc: edk2-devel@lists.01.org; Gao, Liming
> Subject: Re: [edk2] [PATCH] BaseTools: covert "unicode string"
Hi,
On 10/17/18 13:08, Zhaozh1x wrote:
> For the same one VOID* pcd, if the default value type of one sku is
> "unicode string", the other skus are "OtherVOID*"(ascii string or
> byte array),Then covert "unicode string" to "byte array".
>
> Contributed-under: TianoCore Contribution Agreement 1.1
+Stephano
On 10/17/18 16:58, Zeng, Star wrote:
> On 2018/10/17 21:10, Laszlo Ersek wrote:
>> I have requested earlier [1], and now I'm doing so again, that CVE fixes
>> please all mention the CVE number in the *subject line*. When people
>> look at the commit log, or even just patch traffic on
Hi Jian,
On 10/17/18 10:34, Jian J Wang wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1237
>
> Sometimes the memory will be contaminated by random data left in last
> boot (warm reset). The code should not assume the allocated memory is
> always filled with zero. This patch add
Hi Eric,
On 10/17/18 04:16, Eric Dong wrote:
> V2 changes include:
> 1. Include the change for CpuCommonFeaturesLib which used to set MSR base on
> its scope info.
> 2. Include the change for CpuS3DataDxe driver which also handle the
> AcpiCpuData data.
> 3. Update code base on feedback for V1
On 10/16/18 03:32, Gao, Liming wrote:
> Laszlo:
> Sorry for the delay. Your change is good.
>
> Reviewed-by: Liming Gao
>
> Thanks
> Liming
>> -Original Message-
>> From: Kinney, Michael D
>> Sent: Tuesday, October 16, 2018 3:29 AM
>> To: Laszlo Ersek ; Gao, Liming ;
>> Kinney,
The FDF spec appears to be missing definitions for the new PI 1.6 component
types like MM_CORE_STANDALONE and MM_STANDALONE.
Is there a plan to update the spec to reflect these new types?
See
Propose to use a set not a list when the data is unordered and unique names of
functions.
With that: reviewed-by:Jaben.carsey
Sent from my iPad
> On Oct 16, 2018, at 7:25 PM, Yonghong Zhu wrote:
>
> From: Hess Chen
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
Hi Laszlo,
On 2018/10/17 21:10, Laszlo Ersek wrote:
Hi Star,
On 10/16/18 04:41, Star Zeng wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415
When SetVariable() to a time based auth variable with APPEND_WRITE
attribute, and if the EFI_VARIABLE_AUTHENTICATION_2.TimeStamp in
the
Laszlo:
Thanks for your suggestion. I will wait for one more week.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, October 17, 2018 7:18 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
>
Good suggestion. I have updated this wiki. Please review.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> krishnaLee
> Sent: Wednesday, October 10, 2018 12:10 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch]
Ard:
Do you know who can review this patch?
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> Sent: Tuesday, October 16, 2018 11:43 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] Edk2Platforms: Replace
Hi Star,
On 10/16/18 04:41, Star Zeng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415
>
> When SetVariable() to a time based auth variable with APPEND_WRITE
> attribute, and if the EFI_VARIABLE_AUTHENTICATION_2.TimeStamp in
> the input Data is earlier than current value, it will
Yes. I will add those information. Thanks!
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, October 17, 2018 4:45 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [edk2] [Patch] MdeModulePkg BrotliDecompressLib: Add the checker
> to avoid array
In the expression for unicode string and general string compare, it
should check whether it startswith "L'" or 'L"', but not "L".
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/Common/Expression.py | 4 ++--
1 file changed, 2
Hi Leif,
On 10/16/18 04:28, Leif Lindholm wrote:
> Laszlo: a few years ago, you also posted a _really_ useful email about
> the process of being a maintainer, and helpful workflows (like "sort
> emails to review immediately on reception, even if you don't have time
> to review now"). I have
Gentle reminder.
Please let me know if you have any further review comments.
-Sumit
On Wed, 10 Oct 2018 at 10:49, Sumit Garg wrote:
>
> Changes in v4:
> Replaced abbreviations with full name which are not defined in [1]. Also
> used EFI_GUID for Trusted Application UUIDs.
>
> [1]
>
On 10/16/18 03:39, Dong, Eric wrote:
> Hi Laszlo,
>
> [...]
Thanks for your answers, it's all much clearer now.
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 10/16/18 09:11, shenglei wrote:
> Remove FatBinPkg and modify Maintainers.txt.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1105
>
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang
> ---
> FatBinPkg/EnhancedFatDxe/AArch64/Fat.efi |
For the same one VOID* pcd, if the default value type of one sku is
"unicode string", the other skus are "OtherVOID*"(ascii string or
byte array),Then covert "unicode string" to "byte array".
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: ZhiqiangX Zhao
Cc: Liming Gao
Hi Aaron,
On 10/16/18 03:55, Ard Biesheuvel wrote:
> On 15 October 2018 at 22:52, wrote:
>> On 10/04/18 06:06, Laszlo Ersek wrote:
>>> On 10/04/18 11:24, Leif Lindholm wrote:
+Peter
On Wed, Oct 03, 2018 at 04:59:54PM -0700, aaron.yo...@oracle.com wrote:
>
> I am
Liming,
They are reported by some static analysis tool, right?
I think you add some information about it in the commit log. You can do that
when pushing the patch.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, October 17, 2018 4:43 PM
To: Gao, Liming ;
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Tuesday, October 16, 2018 3:27 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdeModulePkg BrotliDecompressLib: Add the checker to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1237
Sometimes the memory will be contaminated by random data left in last
boot (warm reset). The code should not assume the allocated memory is
always filled with zero. This patch add code to clear data structure
used for stack switch to
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Gao, Liming
Sent: Tuesday, October 16, 2018 11:09 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: [Patch] BaseTools: Remove the step to freeze python tool
63 matches
Mail list logo
