Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2019-02-15 Thread Ni, Ray
(Sent third times to make sure Andrew and Laszlo are in the TO list.) I also met this issue. I found three solutions: 1. Forcing PeiMain CC flag to "-O0" works. 2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also works. 3. Implement the temporary migration routine as below in

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2019-02-15 Thread Ni, Ray
I also met this issue. I found three solutions: 1. Forcing PeiMain CC flag to "-O0" works. 2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also works. 3. Implement the temporary migration routine as below in EmulatorPkg/Sec module. EFI_STATUS EFIAPI SecTemporaryRamSupport (

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2019-02-15 Thread Ni, Ray
I also met this issue. I found three solutions: 1. Forcing PeiMain CC flag to "-O0" works. 2. Changing EmulatorPkg/Sec to not produce TemporaryRamSupportPpi also works. 3. Implement the temporary migration routine as below in EmulatorPkg/Sec module. EFI_STATUS EFIAPI SecTemporaryRamSupport (

[edk2] [Patch] BaseTools: Correct the value assignment for StructurePcd

2019-02-15 Thread Feng, Bob C
This patch is to fix the code bug in StructurePcd overall value assignment logic. If a Pcd Array size is fixed but the size of actual value in Dsc or Dec is bigger than the Pcd array size, the tool only copy the data as same as that Pcd Array size. Contributed-under: TianoCore Contribution Agreeme

[edk2] [Patch] BaseTools: Fixed a code bug for Pcd Array.

2019-02-15 Thread Feng, Bob C
For example, PCD gUefiOvmfPkgTokenSpaceGuid.Test001 datatype is Array: TEST1[2] and the filed TEST1UINT64ARRAY in TEST1 is also an array: UINT64 TEST1UINT64ARRAY[2]; Then the following filed assignment in DSC will cause build failure. gUefiOvmfPkgTokenSpaceGuid.Test001[0].TEST1UINT64ARRAY|{'A','B'

Re: [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-15 Thread Laszlo Ersek
Marc-André, On 02/11/19 13:53, Laszlo Ersek wrote: > OVMF can be built with a significant amount of TPM2 code now; add > Marc-André and Stefan as Reviewers for TPM2-related patches. > > Keep the list of "R" entries alphabetically sorted. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Ju

Re: [edk2] [Patch] BaseTools: Remove unused txt files

2019-02-15 Thread Laszlo Ersek
On 02/15/19 15:32, Liming Gao wrote: > externals.txt is to refer to the binary Win32. It is not used any longer. > BuildNotes.txt is to freeze BaseTools python. It is not used any longer. > BinaryFiles.txt is to list the file in Bin directory. But, Bin dir is empty. > building-gcc.txt and gcc is fo

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread Laszlo Ersek
On 02/15/19 20:54, Felix Polyudov wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Friday, February 15, 2019 9:23 AM >> >> Just a short comment below. >> >> (Not changing my stance in any way that I've presented thus far; the >> comment is only meant in addition to / as a clarifi

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-15 Thread Laszlo Ersek
On 02/15/19 15:35, Gao, Liming wrote: > Laszlo: > I have updated wiki page to mention python3-distutils. Thanks! > I suggest to update BaseTools\ReadMe.txt for it. Ah, haha, there's such a file as "BaseTools/ReadMe.txt"? :) I don't think I've ever noticed it. :) But, now I agree that "BaseTo

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread Felix Polyudov
> -Original Message- > From: Laszlo Ersek > Sent: Friday, February 15, 2019 9:23 AM > > Just a short comment below. > > (Not changing my stance in any way that I've presented thus far; the > comment is only meant in addition to / as a clarification for that.) > > On 02/15/19 09:43, Ard B

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread stephano
On 2/14/2019 6:56 PM, Rebecca Cran via edk2-devel wrote: Thanks, I'm cautiously optimistic that groups.io will maintain a nice email interface to the list(s). However I don't see any messages/topics (in https://edk2.groups.io/g/main), and it appears my test posts are being moderated: are there

Re: [edk2] [PATCH] BaseTools:BaseTools supports to the driver combination.

2019-02-15 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan, ZhijuX > Sent: Thursday, February 14, 2019 7:18 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH] BaseTools:BaseTools supports to the

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Pete Batard
On 2019-02-15 14:39, Ard Biesheuvel wrote: On Fri, 15 Feb 2019 at 11:07, Ard Biesheuvel wrote: On Tue, 12 Feb 2019 at 19:14, Leif Lindholm wrote: On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: This is designed to be used on platforms where a a real RTC is not available and re

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Ard Biesheuvel
On Fri, 15 Feb 2019 at 15:57, Pete Batard wrote: > > On 2019-02-15 14:39, Ard Biesheuvel wrote: > > On Fri, 15 Feb 2019 at 11:07, Ard Biesheuvel > > wrote: > >> > >> On Tue, 12 Feb 2019 at 19:14, Leif Lindholm > >> wrote: > >>> > >>> On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote:

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-15 Thread Pete Batard
Awesome! Thanks a lot to all the people on this list who helped with the review process, provided advice, or tested this series. Regards, /Pete On 2019-02-15 12:05, Ard Biesheuvel wrote: On Fri, 15 Feb 2019 at 11:27, Ard Biesheuvel wrote: On Wed, 13 Feb 2019 at 04:50, Jeremy Linton wrot

Re: [edk2] [PATCH edk2-platforms v1 00/16] Fix issues and improve D0x

2019-02-15 Thread Ming Huang
Hi Leif, Please have a look for several outstanding patches. Thanks On 2/1/2019 9:34 PM, Ming Huang wrote: > Main Changes : > 1 Use new flash layout; > 2 Modify for M7 self-Adapte support; > 3 Add PCI_OSC_SUPPORT for ACPI/DSDT; > 4 Change HCCS speed from 30G to 26G; > 5 Rename StartupAp() functi

[edk2] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe Fix eMMC HS400 switch sequence

2019-02-15 Thread Albecki, Mateusz
In eMMC HS400 switch sequence flow eMMC driver attampted to execute SEND_STATUS just after switching bus timing to high speed and before downgrading clock frequency to 52MHz. Since link was at that time in incorrect state SEND_STATUS was failing which made driver think switch to HS400 failed. This

[edk2] [PATCH 0/1] Correcting eMMC HS400 switch sequence

2019-02-15 Thread Albecki, Mateusz
SdMmcPchHcDxe used to execute SEND_STATUS with link running at incorrect clock frequency while downgrading from HS200 to high speed during HS400 switch sequence. Changing clock frequency before executing SEND_STATUS makes sure that SEND_STATUS is executed with link at correct frequency. Since new f

Re: [edk2] [Patch 0/3] BaseTools: Implement splitquoted function

2019-02-15 Thread Gao, Liming
Laszlo: I have updated wiki page to mention python3-distutils. I suggest to update BaseTools\ReadMe.txt for it. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 14, 2019 11:35 PM > To: Gao, Liming ; Feng, Bob C ; > Bi, Danda

[edk2] [Patch] BaseTools: Remove unused txt files

2019-02-15 Thread Liming Gao
externals.txt is to refer to the binary Win32. It is not used any longer. BuildNotes.txt is to freeze BaseTools python. It is not used any longer. BinaryFiles.txt is to list the file in Bin directory. But, Bin dir is empty. building-gcc.txt and gcc is for mingw-gcc. It is not used any longer. Cont

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread Laszlo Ersek
On 02/15/19 03:56, Rebecca Cran wrote: > On 2/14/19 3:13 PM, Kinney, Michael D wrote: >> You can review the groups.io features.  I think what you >> want is available.  Stephano has also setup an edk2 area >> in groups.io for community member to try out. >> >> https://groups.io/static/help#feat

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread Laszlo Ersek
Just a short comment below. (Not changing my stance in any way that I've presented thus far; the comment is only meant in addition to / as a clarification for that.) On 02/15/19 09:43, Ard Biesheuvel wrote: > I would like to see more engagement from these contributors in the > actual project bef

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-15 Thread Gao, Liming
Star: This patch is from MS Project MU. So, the original author is kept. Dandan contributes this patch to edk2. So, Dandan is as Signed-off-by. This is the expected way. Below is author and signed-off-by definition. The author is the person who originally wrote the work, whereas the committer

Re: [edk2] [patch 0/2] Report error status when fail to load/start boot option

2019-02-15 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Friday, February 15, 2019 9:40 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Ni, Ray ; Wu, Hao A ; Gao, Liming > ; Kinney, Michael D > Subject: R

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-15 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, February 14, 2019 10:43 AM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Michael Turner > ; Max Knutsen ; Gao, > Liming > Subject: RE: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avo

Re: [edk2] [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation

2019-02-15 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, February 14, 2019 10:45 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH] MdePkg/BaseLib: Change a variable type in a bitwise operation > > Change the type o

Re: [edk2] [patch 0/2] Report error status when fail to load/start boot option

2019-02-15 Thread Laszlo Ersek
On 02/15/19 09:51, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 > > According to PI1.7, this patch series is to add the support that > report extended data describing an EFI_STATUS return value along > with EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and > EFI_SW_DXE_BS

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Ard Biesheuvel
On Fri, 15 Feb 2019 at 11:07, Ard Biesheuvel wrote: > > On Tue, 12 Feb 2019 at 19:14, Leif Lindholm wrote: > > > > On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > > > This is designed to be used on platforms where a a real RTC is not > > > available and relies on an RtcEpochSeconds

Re: [edk2] [PATCH v5 00/13] Split the S3 PEI phase HW init codes from Opal driver

2019-02-15 Thread Laszlo Ersek
On 02/15/19 07:23, Hao Wu wrote: > The series is also available at: > https://github.com/hwu25/edk2/tree/opal_remodel_v5 > > V5 changes: > For patch 11, as suggested by Star: > * Refine the UpdateLockBox() API description comment to be more precise; > * Ensure the parameter for macro 'EFI_SIZE_TO_

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-15 Thread Ard Biesheuvel
On Fri, 15 Feb 2019 at 11:27, Ard Biesheuvel wrote: > > On Wed, 13 Feb 2019 at 04:50, Jeremy Linton wrote: > > > > the > > Hi, > > > > On 2/5/19 10:25 AM, Pete Batard wrote: > > > Changes for v5: > > > > > > * Raspberry/Pi3 -> RaspberryPi/RPi3 > > > * Remove VirtualRealTimeClockLib as well as BUI

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86

2019-02-15 Thread Ard Biesheuvel
On Mon, 11 Feb 2019 at 20:07, Leif Lindholm wrote: > > On Mon, Feb 11, 2019 at 07:33:22PM +0100, Ard Biesheuvel wrote: > > AArch64 binutils support AArch32 seamlessly when running natively, > > which allowed us to drop the -I objcopy argument specifying that > > the input format is elf64-little, w

Re: [edk2] [PATCH v5 edk2-platforms 00/22] Platform/RaspberryPi: Add Raspberry Pi 3 support

2019-02-15 Thread Ard Biesheuvel
On Wed, 13 Feb 2019 at 04:50, Jeremy Linton wrote: > > the > Hi, > > On 2/5/19 10:25 AM, Pete Batard wrote: > > Changes for v5: > > > > * Raspberry/Pi3 -> RaspberryPi/RPi3 > > * Remove VirtualRealTimeClockLib as well as BUILD_EPOCH macro (use the > > upcoming > >EmbeddedPkg Virtual RTC from E

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 19:14, Leif Lindholm wrote: > > On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > > This is designed to be used on platforms where a a real RTC is not > > available and relies on an RtcEpochSeconds variable having been set or, > > if that is not the case, falls

Re: [edk2] [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib

2019-02-15 Thread Leif Lindholm
On Fri, Feb 15, 2019 at 01:12:11AM +0100, Pete Batard wrote: > Hi Leif, > > On 2019-02-12 19:14, Leif Lindholm wrote: > > On Mon, Feb 04, 2019 at 12:47:36PM +, Pete Batard wrote: > > > This is designed to be used on platforms where a a real RTC is not > > > available and relies on an RtcEpochS

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-15 Thread Zeng, Star
After applying the patch, the author is Max and the Signed-off-by is Dandan, is it expected? And the code below is better to be into the else condition (stack buffer is not enough), right? if (gBS == NULL || gBS->AllocatePool == NULL || gBS->FreePool == NULL) { return EFI_UNSUPPORTED; }

[edk2] [patch 0/2] Report error status when fail to load/start boot option

2019-02-15 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 According to PI1.7, this patch series is to add the support that report extended data describing an EFI_STATUS return value along with EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED status code when fail to

[edk2] [patch 1/2] MdePkg/StatusCodeDataTypeId.h: Add new definition per PI1.7 Spec

2019-02-15 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 According to PI1.7 Spec, add the new definition EFI_RETURN_STATUS_EXTENDED_DATA in StatusCodeDataTypeId.h Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan

[edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-15 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1398 According to PI1.7 Spec, report extended data describing an EFI_STATUS return value along with EFI_SW_DXE_BS_EC_BOOT_OPTION_LOAD_ERROR and EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED status code when fail to load or start boot option image. Cc: J

Re: [edk2] [edk2-announce] Community Meeting Minutes

2019-02-15 Thread Ard Biesheuvel
On Thu, 14 Feb 2019 at 20:07, Jeremiah Cox wrote: > > Hi Ard, > My apologies as no insult was intended. The suggestion is that, similar to > today, folks encountering difficulties with our systems could reach out to > the TianoCore discussion venue (our mailing list or groups.io), and our > fr