[edk2] [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments.

2019-02-28 Thread Eric Dong
Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions.

2019-02-28 Thread Eric Dong
Remove useless APIs, simplify the code logic. BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../Include/Library/RegisterCpuFeaturesLib.h | 34 --- .../RegisterCpuFeaturesLib.c

[edk2] [Patch v2 0/4] Simplify CPU Features solution.

2019-02-28 Thread Eric Dong
V2 Changes include: 1. Add ASSERT to make sure PcdCpuFeaturesSetting and PcdCpuFeaturesCapability have equal size. 2. Correct comment block on IsCpuFeatureSetInCpuPcd() references "PcdCpuFeaturesSupport". It should reference "CpuBitMask". V1 Changes includes: 1. Optimize PCD

[edk2] [Patch v2 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport.

2019-02-28 Thread Eric Dong
PcdCpuFeaturesSupport used to specify the platform policy about what CPU features this platform supports. This PCD will be used in IsCpuFeatureSupported only. Now RegisterCpuFeaturesLib use this PCD as an template to Get the pcd size. Update the code logic to replace it with

[edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

2019-02-28 Thread Eric Dong
Merge PcdCpuFeaturesUserConfiguration into PcdCpuFeaturesSetting. Use PcdCpuFeaturesSetting as input for the user input feature setting Use PcdCpuFeaturesSetting as output for the final CPU feature setting BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375 Contributed-under: TianoCore

Re: [edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

2019-02-28 Thread Wang, Jian J
Thanks. To catch cold freeze, pushed earlier (2a9324cfca12c66f13a41d52fb0a82fb924e) Regards, Jian > -Original Message- > From: Dong, Eric > Sent: Friday, March 01, 2019 9:55 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Ni, Ray ; Laszlo Ersek ; Zeng, Star > > Subject: RE:

Re: [edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-28 Thread Feng, Bob C
Please ignore this mail. Sorry. -Original Message- From: Feng, Bob C Sent: Friday, March 1, 2019 10:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [Patch] Document: Update Dsc spec to all empty value for HIIPcd Would you give the reviewed-by? -Original

Re: [edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-28 Thread Feng, Bob C
Would you give the reviewed-by? -Original Message- From: Feng, Bob C Sent: Thursday, February 28, 2019 10:11 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] Document: Update Dsc spec to all empty value for HIIPcd

[edk2] [PATCH V2] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-02-28 Thread Fan, ZhijuX
The reason for this problem is that the file was opened incorrectly. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- .../plugins/EdkPlugins/edk2/model/doxygengen.py| 7 --- 1 file changed, 4

Re: [edk2] [PATCH] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-02-28 Thread Feng, Bob C
Zhiju, If the file is binary, it's no need to do more process since this function is to get "include" information. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Friday, March 1, 2019 9:33 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH]

Re: [edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Wang, Fan > Sent: Friday, March 1, 2019 9:57 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: RE: [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM > > Thanks, Siyuan, will update commit

[edk2] [Patch] SecurityPkg/OpalPassword: Fix incorrect line ending issue.

2019-02-28 Thread Eric Dong
Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiCallbacks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiCallbacks.c

Re: [edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Wang, Fan
Thanks, Siyuan, will update commit message for this change. Best Regards Fan -Original Message- From: Fu, Siyuan Sent: Thursday, February 28, 2019 6:35 PM To: Wang, Fan ; edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: RE: [Patch] NetworkPkg: Fix Duplicate FreePool Error in

Re: [edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

2019-02-28 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jian J Wang > Sent: Friday, March 1, 2019 8:58 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Laszlo Ersek ; Dong, > Eric ; Zeng, Star > Subject: [edk2] [PATCH 2]

[edk2] [PATCH] BaseTools:Run packagedoc_cli.py to generate doc failed

2019-02-28 Thread Fan, ZhijuX
The reason for this problem is that the file was opened incorrectly. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- .../plugins/EdkPlugins/edk2/model/doxygengen.py| 10 +++--- 1 file changed, 7

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-28 Thread Gao, Liming
OK. To be clear, I take your suggestion. wiki page has been updated. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 28, 2019 7:58 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Wang, Jian J
Laszlo, Sure. It'll be added Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 28, 2019 10:10 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory > beyond

[edk2] [PATCH 2] UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

2019-02-28 Thread Jian J Wang
> v2: Per Laszlo's comments, repack origianl two patches into one with > title changed and relevant commits added REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576 The root cause of this issue is that non-stop mode of Heap Guard and NULL Detection set TF bit (single-step) in EFLAG

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Wang, Jian J
Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 28, 2019 10:07 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory > beyond 4G > > Hi Jian, > > On 02/28/19

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Eugene, Small question. Did the issue appear after the V4 patch went in? Looking at the code before that patch, we were enabling 64b dma in pci based on capability register already despite of driver supporting only 32b dma. Thanks Ashish Get Outlook for iOS

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Cohen, Eugene
Ashish, Agreed - #2 would be better in the long run since this will have better performance by eliminating the bounce buffering. My original intent in submitting the patch was to fix the logic the current implementation with minimal impact. Thanks, Eugene From: Ashish Singhal Sent:

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Eugene, Thanks for pointing that out. This is a use case we are not covering as of now. I see two options to this: 1. Do not enable 64b DMA support in PCI based on V3 as driver does not support V3 64b ADMA. This is a quick fix. 2. Enable V3 64b ADMA support to add the missing feature.

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Cohen, Eugene
Ashish, I think that code will still fail for our use case. We are version 3 with 64-bit support so Private->Capability[Slot].SysBus64V3 == 0 will evaluate to FALSE. Since we are V3 Private->ControllerVersion[Slot] >= SD_MMC_HC_CTRL_VER_400 will also evaluate to FALSE. Therefore

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Eugene, Thanks for the explanation. The problem is valid and is more clear to me now. How about we do this: Instead of: if (Private->Capability[Slot].SysBus64V3 == 0 && Private->Capability[Slot].SysBus64V4 == 0) { Support64BitDma = FALSE; } What do you think about:

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Cohen, Eugene
Ashish, Ø Right now, we disable 64b DMA Support in PCI if the controller cannot support 64b DMA in V3 as well as V4. If either of these support 64b DMA, we do not disable it. In the code, we set Support64BitDma to TRUE by default and change it to FALSE only if any of the controller does not

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Eugene, We do not have support for V4 64b DMA right now but it can be added later if needed. I am trying to understand the reason behind changing the check from AND to OR. Right now, we disable 64b DMA Support in PCI if the controller cannot support 64b DMA in V3 as well as V4. If either of

Re: [edk2] [edk2-announce] March Community Meeting

2019-02-28 Thread stephano
On 2/28/2019 11:48 AM, stephano wrote: We will be holding our February Community Meeting next Thursday. %s/February/March :) ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Cohen, Eugene
Ashish, Ø With my change, if any of the controller did not support 64b DMA in V3 as well as V4 capability, we are not enabling it in PCI layer. The logic is: if (Private->Capability[Slot].SysBus64V3 == 0 && Private->Capability[Slot].SysBus64V4 == 0) { Support64BitDma =

[edk2] [edk2-announce] March Community Meeting

2019-02-28 Thread stephano
We will be holding our February Community Meeting next Thursday. Details are posted here: https://www.tianocore.org/monthly-meeting Please feel free to send any topics you'd like to discuss to the list or directly to me. Cheers, Stephano Stephano Cetola TianoCore Community Manager

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Ashish Singhal
Hello Eugene, My patch enabled support for SDHC 4.0 and above in general including support for 64b ADMA descriptor. The check for V3 capability for 64b DMA was already there and similar check was implemented for V4 capability for 64b DMA. Earlier, if any of the V3 controller did not support

Re: [edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Carsey, Jaben
Is this something that should also get added to edksetup? Force users to get the error without running this test. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Feng, Bob C > Sent: Thursday, February 28, 2019

Re: [edk2] [Patch] Document: Update the INF spec about [Depex] section

2019-02-28 Thread Felix Polyudov
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Wednesday, February 27, 2019 9:12 PM > To: edk2-devel@lists.01.org > Cc: Liming Gao > Subject: [edk2] [Patch] Document: Update the INF spec about [Depex] section > > ::=

Re: [edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Feng, Bob C > Sent: Wednesday, February 27, 2019 6:11 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] Document: Update Dsc spec to all

Re: [edk2] [Patch] Document: Update the INF spec about [Depex] section

2019-02-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Feng, Bob C > Sent: Wednesday, February 27, 2019 6:12 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch] Document: Update the INF spec

Re: [edk2] [PATCH 0/4] Various Packages: add MM_STANDALONE support

2019-02-28 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 15:34, Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 13:49, Gao, Liming wrote: > > > > Ard: > > The patches created by you recently is to support the standalone MM > > authenticated variable stack. This is likely a new feature. > > > > Could you help submit BZ for

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Laszlo Ersek
On 02/28/19 15:07, Laszlo Ersek wrote: > (4) I also suggest adding: > > Fixes: dcc026217fdc363f55c217039fc43d344f69fed6 Additionally append: Fixes: 16b918bbaf51211a32ae04d9d8a5ba6ccca25a6a Thanks, Laszlo > > near the end of the commit message. > > > With (2) through (4) addressed: > >

Re: [edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Laszlo Ersek
Hi Jian, On 02/28/19 11:10, Jian J Wang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576 > Test: > - Pass special test of accessing memory beyond 4G > - Boot to OS with Qemu emulator platform (Fedora27, Ubuntu18.04, > Windows7, Windows10) > > Jian J Wang (2): >

Re: [edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Philippe Mathieu-Daudé
On 2/28/19 2:29 PM, Feng, Bob C wrote: > Hi Phil, > > Your suggested code is good but it still print the call stack. I changed it a > little, it only print the error message now. > > Thanks, > Bob > > -Original Message- > From: Feng, Bob C > Sent: Thursday, February 28, 2019 9:19 PM

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-02-28 Thread Laszlo Ersek
Hello Heyi, On 02/28/19 09:05, Heyi Guo wrote: > Serial port output is useful when debugging UEFI runtime services in OS > runtime. > The patches are trying to provide a handy method to enable runtime serial port > debug for ArmVirtQemu. > > Cc: Jian J Wang > Cc: Hao Wu > Cc: Laszlo Ersek >

Re: [edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Feng, Bob C
Hi Phil, Your suggested code is good but it still print the call stack. I changed it a little, it only print the error message now. Thanks, Bob -Original Message- From: Feng, Bob C Sent: Thursday, February 28, 2019 9:19 PM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming

[edk2] [Patch V3] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Tests/RunTests.py | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-02-28 Thread Ard Biesheuvel
On Thu, 28 Feb 2019 at 09:06, Heyi Guo wrote: > > Serial port output is useful when debugging UEFI runtime services in OS > runtime. > The patches are trying to provide a handy method to enable runtime serial port > debug for ArmVirtQemu. > > Cc: Jian J Wang > Cc: Hao Wu > Cc: Laszlo Ersek >

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-28 Thread Laszlo Ersek
On 02/28/19 03:22, Gao, Liming wrote: > I update wiki page > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > with UTC zone. > I think the nature time of day is the begin time of one day. 00:00:00 should > be common sense. We may not highlight it. I disagree:

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-28 Thread Laszlo Ersek
On 02/28/19 02:32, Gao, Liming wrote: > I update > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > with CVE example. Please check it. "CVE fix needs to append CVE number in Brief-single-line-summary. The format is 'Pkg-Module: Brief-single-line-summary

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-28 Thread Cohen, Eugene
Hao, > I remember the commit b5547b9ce97e80c3127682a2a5d4b9bd14af353e from Ashish > only handles the controllers with version greater or equal to 4.00. Right - that commit added support for SDHC 4.0 and above. The original driver supported SDHC 3.0 albeit only with SDMA and 32-bit ADMA

Re: [edk2] [Patch V2] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-28 Thread Philippe Mathieu-Daudé
On 2/28/19 3:04 AM, Feng, Bob C wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > V2: > Remove OS/Package specific words. Print the error info which > is from python error message. > > Add python3-distutils Ubuntu package checking. > > Contributed-under: TianoCore Contribution

Re: [edk2] Self-replicating image

2019-02-28 Thread Tomas Pilar (tpilar)
Hi Mike, This all looks really good, I didn't envisage this way to design it (swapping contexts on demand) but it's much simpler than what I had in mind. I should be able to integrate this easily with my current FMP driver for our device and I should be able to get you some good testing.

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-02-28 Thread Philippe Mathieu-Daudé
On 2/27/19 10:21 PM, Laszlo Ersek wrote: > The current language for "Package Reviewer" only vaguely hints that > Package Reviewers should be able to provide guidance and directions. > Make this more obvious. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Liming Gao > Cc:

Re: [edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Fu, Siyuan
Hi, Fan The patch also cancel a timer in driver binding stop, please describe this change in commit message, or separate it to another patch. Reviewed-by: Siyuan Fu > -Original Message- > From: Wang, Fan > Sent: Thursday, February 28, 2019 5:10 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

2019-02-28 Thread Leif Lindholm
Hi Tzy Way, On Thu, Feb 28, 2019 at 08:39:32AM +, Ooi, Tzy Way wrote: > Thanks for your comment. I will modify the driver to comply to UEFI > driver model. Excellent, thanks. > I would like to ask why this driver should be submitted to edk2- > platforms instead of edk2? This driver is a

[edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: remove code to set TF bit in EFLAGS

2019-02-28 Thread Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576 The root cause of this issue is that non-stop mode of Heap Guard and NULL Detection set TF bit (single-step) in EFLAG unconditionally in the common handler in CpuExceptionLib. If PcdCpuSmmStaticPageTable is FALSE, the SMM will only create

[edk2] [PATCH 0/2] Fix SMM driver hang at accessing memory beyond 4G

2019-02-28 Thread Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576 Test: - Pass special test of accessing memory beyond 4G - Boot to OS with Qemu emulator platform (Fedora27, Ubuntu18.04, Windows7, Windows10) Jian J Wang (2): UefiCpuPkg/CpuDxe: set TF bit in EFLAGS in C code UefiCpuPkg/CpuDxe: remove

[edk2] [PATCH 1/2] UefiCpuPkg/CpuDxe: set TF bit in EFLAGS in C code

2019-02-28 Thread Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576 The root cause of this issue is that non-stop mode of Heap Guard and NULL Detection set TF bit (single-step) in EFLAG unconditionally in the common handler in CpuExceptionLib. If PcdCpuSmmStaticPageTable is FALSE, the SMM will only create

[edk2] [Patch] NetworkPkg: Fix Duplicate FreePool Error in WCM

2019-02-28 Thread Wang Fan
* REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1577 In WiFi Connection Manager scan process, the result received from WiFi device driver will be freed twice, and will cause unexpected errors, and even system crash. This issue also exists in some other places potentially, this patch is to

[edk2] [PATCH v2] UefiCpuPkg/Microcode: Add verification logic before parsing payload

2019-02-28 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The function MicrocodeDetect may receive untrusted input. Add verification logic to check Microcode Payload Header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Cc: Ray Ni Cc: Eric Dong ---

Re: [edk2] [PATCH] EmbeddedPkg/DwEmacSnpDxe: Add designware emac support This add support for designware emac controller

2019-02-28 Thread Ooi, Tzy Way
Hi Leif, Thanks for your comment. I will modify the driver to comply to UEFI driver model. I would like to ask why this driver should be submitted to edk2- platforms instead of edk2? This driver is a generic driver which is target to work on various platform. Best regards, Tzy Way On Thu,

[edk2] [RFC 2/3] ArmVirtPkg: add runtime instance of FdtPL011SerialPortLib

2019-02-28 Thread Heyi Guo
We add a runtime instance inf into the same directory for code reuse. The different pieces of code are put into *Common.c and *Runtime.c. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Heyi

[edk2] [RFC 3/3] ArmVirtQemu: enable runtime debug by build flag

2019-02-28 Thread Heyi Guo
Introduce a build definition "RT_DEBUG" to enable runtime debug, so that we can have a handy method for UEFI runtime services debug. This build flag only applies to DEBUG build; the reason for not enabling it for DEBUG build by default is the related modules have some dependencies, so "DEBUG(())"

[edk2] [RFC 1/3] MdeModulePkg/StatusCode: Add PCD to enable runtime serial debug

2019-02-28 Thread Heyi Guo
Serial port message is useful when we are debugging UEFI runtime services, so add a feature PCD to enable runtime serial debug. Cc: Jian J Wang Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Heyi Guo --- MdeModulePkg/MdeModulePkg.dec

[edk2] [RFC 0/3] Enable runtime serial debug for ArmVirtQemu

2019-02-28 Thread Heyi Guo
Serial port output is useful when debugging UEFI runtime services in OS runtime. The patches are trying to provide a handy method to enable runtime serial port debug for ArmVirtQemu. Cc: Jian J Wang Cc: Hao Wu Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Julien Grall Heyi Guo (3):