Re: [edk2] [PATCH v6 edk2-platforms 5/6] Platform/HiKey: do basic initialization on hikey

On Thu, May 24, 2018 at 08:46:29AM +0800, Haojian Zhuang wrote: > Do some basic initialization on HiKey platform, such as pin > setting, regulators and making peripherals out of reset mode. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <a

Re: [edk2] [PATCH v6 edk2-platforms 3/6] Platform/HiKey960: enable virtual keyboard

e code. > Can't fix it for lack of documents. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> R

Re: [edk2] [PATCH v6 edk2-platforms 2/6] Platform/HiKey960: do basic initialization

On Thu, May 24, 2018 at 08:46:26AM +0800, Haojian Zhuang wrote: > Do some basic initliazation on peripherals, such as pins and > regulators. > > The hardcoding code is taken from non-open reference code. > Can't fix it for lack of documents. > > Cc: Leif Lindholm <leif.l

Re: [edk2] [PATCH edk2-platforms 2/5] Platform/Socionext/DeveloperBox: add SNP driver

To save me making a triple-take when I see this commit in the log in future, could you change the subject to say SnpDxe instead of SNP? If so, for the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> On Fri, Apr 27, 2018 at 01:37:45PM +0200, Ard Biesheuvel wrote: > Ev

Re: [edk2] [PATCH edk2-platforms 0/5] Seattle spring cleaning

orm/AMD/Overdrive: enable support for NVME PCIe devices For the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > .../AMD/OverdriveBoard/OverdriveBoard.dsc | 20 +-- > .../AMD/OverdriveBoard/OverdriveBoard.fdf | 6 +- > Platform/LeMaker/CelloBoard/Cel

Re: [edk2] [PATCH] Platform/ARM: Fix FVP broken build with "-D ARM_FVP_RUN_NORFLASH"

portStatusCodeLib.inf > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > sections of ArmVExpress.dsc.inc and > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > in [Packages] section of ArmVExpressLibSec.inf > > Contributed-under: TianoCore Contribution A

Re: [edk2] [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

On Mon, May 21, 2018 at 12:54:01PM +0200, Marcin Wojtas wrote: > Hi Leif, > > > 2018-05-09 18:49 GMT+02:00 Leif Lindholm <leif.lindh...@linaro.org>: > > > A couple of minor style comments. > > > > If you don't disagree, I can fix that up before pushing

Re: [edk2] [PATCH edk2-platforms v4 6/6] Platform/HiKey: enable virtual keyboard

On Mon, May 14, 2018 at 12:34:33PM +0800, Haojian Zhuang wrote: > Enable virtual keyboard on HiKey platform. It detects the pattern > in memory and GPIO pin setting, and simulates them into virtual > key. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard

Re: [edk2] [PATCH edk2-platforms v4 5/6] Platform/HiKey: do basic initialization on hikey

On Mon, May 14, 2018 at 12:34:32PM +0800, Haojian Zhuang wrote: > Do some basic initialization on HiKey platform, such as pin > setting, regulators and making peripherals out of reset mode. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <a

Re: [edk2] [PATCH edk2-platforms v4 4/6] Platform/Hisilicon/HiKey: add gpio platform driver

On Mon, May 14, 2018 at 12:34:31PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey platform. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms v4 3/6] Platform/HiKey960: enable virtual keyboard

or 2/6. / Leif > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang <haojian.zhu...@linaro.org> > --- > Platform/Hisi

Re: [edk2] [PATCH edk2-platforms v4 2/6] Platform/HiKey960: do basic initialization

This is a significant improvement over previous versions, but there are still a few things I would like addressed. On Mon, May 14, 2018 at 12:34:29PM +0800, Haojian Zhuang wrote: > Do some basic initliazation on peripherals, such as pins and > regulators. > > Cc: Leif Lindholm

Re: [edk2] [PATCH edk2-platforms v4 1/6] Platform/Hisilicon/HiKey960: add gpio platform driver

On Mon, May 14, 2018 at 12:34:28PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey960 platform. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update

On Fri, May 11, 2018 at 01:29:47PM +, Evan Lloyd wrote: > > > > -Original Message- > > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Leif > > Lindholm > > Sent: 09 May 2018 12:04 > > To: Sami Mujawar <sami.muja...@arm.c

Re: [edk2] [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib

ARCH64_PLATFORM_FLAGS == > -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include > -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include/Platform/RTSM I still prefer the .dec way over ading more explicit platform-specific -I flags. Could you fold that into the patch and update the subject line to s

Re: [edk2] [platforms PATCH v2 4/4] Marvell/Library: ComPhyLib: Fix configuration for PCIE x4 and x2

A couple of minor style comments. If you don't disagree, I can fix that up before pushing and you can have Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> for 1,3-4. On Wed, May 09, 2018 at 03:51:11PM +0200, Marcin Wojtas wrote: > From: Evan Wang <xsw...@marvell.com>

Re: [edk2] [platforms PATCH v2 2/4] Marvell/Armada70x0Db: Use more generic output fd file name

arcin Wojtas <m...@semihalf.com> I have no objections to this patch, but please repost it with the set that adds multiple board support. When you do, you can add Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- >

Re: [edk2] [PATCH edk2-platforms v1] Platform/ARM: Correct GIC naming

rm.com> Like I asked Sami today, please let Evan send his own r-b on the list in future. I'll keep it in here for now. For the patch: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > All the changes can be reviewed at: > https://github.com/AlexeiFedorov/edk2-platfor

Re: [edk2] [staging/dynamictables PATCH v1] Update Readme.md to reflect ACPICA compiler update

On Fri, Apr 27, 2018 at 04:24:59PM +0100, Sami Mujawar wrote: > The ACPICA iASL compiler has been enhanced to support the > generation of an AML hex file which is required by the > Dynamic Tables Framework. The patch for this enhancement > has been integrated in the ACPICA repository. Therefore >

Re: [edk2] [staging/dynamictables PATCH v1 0/2] IORT Generator update

Liming, Mike - any chance of getting that one pushed? > Sami Mujawar (2): > MdePkg: IORT Specification Rev D updates > DynamicTablesPkg: Update IORT generator For the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Pushed as c47bc46170..67fd6a2c5e. Side

Re: [edk2] [PATCH v2 edk-platforms 2/4] Platform/Hisilicon/HiKey960: enable virtual keyboard

On Wed, May 09, 2018 at 06:59:53PM +0800, Haojian Zhuang wrote: > On 3 May 2018 at 06:49, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > On Thu, Mar 08, 2018 at 09:30:04PM +0800, Haojian Zhuang wrote: > >> Enable virtual keyboard on HiKey960 platform. The platform

Re: [edk2] [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno

On Fri, Apr 27, 2018 at 03:58:14PM +0100, Sami Mujawar wrote: > The iASL compiler's -tc option has been updated to generate > output that is suitable for including from a C file. The iASL > compiler uniquely names the C array containing the processed > table data as _aml_code. This update can be

Re: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update

On Fri, Apr 27, 2018 at 03:58:16PM +0100, Sami Mujawar wrote: > The ACPICA iASL compiler has been enhanced to support the > generation of an AML hex file which is required by the > Dynamic Tables Framework. The patch for this enhancement > has been integrated in the ACPICA repository. Therefore >

Re: [edk2] [PATCH v1] Platforms/ARM: Enable acpiview support

Pkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf Unless you object to my moving that line 3 rows up before I push: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf

Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

On Fri, May 04, 2018 at 11:29:33AM +0800, Haojian Zhuang wrote: > On 2 May 2018 at 23:14, Leif Lindholm <leif.lindh...@linaro.org> wrote: > >> + { 0xe8a0b000, 0, 8 },// GPIO0 > > > > It would not improve readability to request all of these live-coded > &g

Re: [edk2] [PATCH v2 edk-platforms 4/4] Platform/Hisilicon/HiKey: enable virtual keyboard

boot options. The addition of HiKeyDxe and the enabling of virtual keyboard support should be separate patches, just like for 2/4. > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.

Re: [edk2] [PATCH v2 edk-platforms 2/4] Platform/Hisilicon/HiKey960: enable virtual keyboard

h looks like it contains an awful lot more than described here. Can it be split up? > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haoji

Re: [edk2] [PATCH v2 edk-platforms 3/4] Platform/Hisilicon/HiKey: add gpio platform driver

(Reviewing near-identical patches out of order.) On Thu, Mar 08, 2018 at 09:30:28PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey platform. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org

Re: [edk2] [PATCH v2 edk-platforms 1/4] Platform/Hisilicon/HiKey960: add gpio platform driver

On Thu, Mar 08, 2018 at 09:29:50PM +0800, Haojian Zhuang wrote: > Add gpio platform driver to enable GPIO in HiKey960 platform. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name

On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote: > Rename the variable holding the Styx PPTT table to mStyxPpttTable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Li

Re: [edk2] [PATCH edk2-platforms] Platform/Socionext/DeveloperBox: reduce default timeout to 5 seconds

nder: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [edk2] [PATCH v2 1/1] EmbeddedPkg/Drivers: add virtual keyboard driver

ding value. > Query(): Read value. If the value matches the expected pattern, > trigger a key pressed event. > Clear(): Clean the value if necessary. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-un

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add PPTT ACPI table to describe cache topology

Ard Biesheuvel <ard.biesheu...@linaro.org> Not my area of expertise, but looks reasonable. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > This produces the following topology after applying Jeremy's patches: > > $ lstopo-no-graphics > Machine (31GB) >

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/DeviceTree: use more specific PMU 'compatible string

ynQuacer/DeviceTree/SynQuacer.dtsi > > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > > @@ -379,7 +379,7 @@ > > }; > > > > pmu { > > -compatible = "arm,armv8-pmuv3"; > > +compatible = &

Re: [edk2] [PATCH v1 0/2] Fix for variable store corrupt issue

dk2-devel@lists.01.org; Arvind Chauhan <arvind.chau...@arm.com>; Daniil > Egranov <daniil.egra...@arm.com>; Thomas Abraham <thomas.abra...@arm.com>; > Leif Lindholm <leif.lindh...@linaro.org>; Matteo Carlini > <matteo.carl...@arm.com>; Stephanie Hughes-Fit

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

t; > <michael.d.kin...@intel.com> wrote: > > > > Welcome Laszlo! > > > > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > > > > Mike > > > >> -Original Message- > >> From: Leif Lindholm [mailto:leif.lindh..

Re: [edk2] [PATCH v3 00/16] Update GOP

for the new SCMI protocol. > > Corresponding edk2-platforms changes will follow shortly. > For the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Pushed as ee4dc24f57..4f2494cf53. Apologies for the delay in getting this through. / Leif > Code is available

Re: [edk2] [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

On Mon, Apr 23, 2018 at 05:07:02PM +, Girish Pathak wrote: > Hi Leif, > > > -Original Message- > > From: Leif Lindholm <leif.lindh...@linaro.org> > > Sent: 23 April 2018 18:03 > > To: Girish Pathak <girish.pat...@arm.com> > > Cc: ed

Re: [edk2] [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > Presence of this PCD in HDLCD is probably due to copy/paste code > from PL111 Lcd platform library. This change removes it from > the HdLcdArmVExpressLib.inf file. > >

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

On Mon, Apr 23, 2018 at 05:00:55PM +0200, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. >From my point of view, for the series: Reviewed-by: Leif Lindholm &l

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

On Mon, Apr 23, 2018 at 04:06:43PM +, Girish Pathak wrote: > > From: Leif Lindholm <leif.lindh...@linaro.org> > > Sent: 23 April 2018 12:32 > > To: Girish Pathak <girish.pat...@arm.com> > > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo

Re: [edk2] [PATCH edk2-platforms v4 00/17] Update GOP

For the series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Not pushed yet due to dependencies on the corresponding edk2 set. Evan: since you already have Signed-off-by on all of the patches, I don't intend to add your Reviewed-by as well (I did see them). On Thu, Apr 05, 2018

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

Hmm, I did find a few minor things below that I need to hear back on before pushing. On Tue, Mar 20, 2018 at 04:12:12PM +, Girish Pathak wrote: > This change introduces a new SCMI protocol driver for > Arm systems. The driver currently supports only clock > and performance management

Re: [edk2] [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation

On Tue, Mar 20, 2018 at 04:12:11PM +, Girish Pathak wrote: > Upcoming new component ArmPkg/Drivers/ArmScmiDxe is dependent on > platform specific ArmMtlLib library implementation, however in order > to be able to build the ArmScmiDxe component outside of the context of a > particular platform,

Re: [edk2] [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver

On Tue, Mar 20, 2018 at 04:12:10PM +, Girish Pathak wrote: > From: Girish Pathak > > This change adds support for the ARM Mali DP500/DP500/DP650 display > processors using the GOP protocol. It has been tested on FVP base > models + DP550 support. This change adds platform independant

Re: [edk2] [PATCH edk2-platforms v1 0/2] Add two patch fot D03

For series: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> Pushed as a30a05ba45..0b5af57f00. On Thu, Feb 22, 2018 at 05:26:58PM +0800, Ming Huang wrote: > These two patchs are missed for 18.02. They are recommended for 18.02. > > > Ming Huang (2): > Hilisic

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On Mon, Apr 23, 2018 at 08:21:22AM +, Meenakshi Aggarwal wrote: > > > +/** > > > + Function to read data using i2c bus > > > + > > > + @param I2cBus I2c Controller number > > > + @param ChipAddress of slave device from where data to be > > > read > > > + @param

Re: [edk2] [PATCH edk2-platforms 00/39] NXP: Add support of LS1043, LS1046 and LS2088 SoCs

Allright, that is all the feedback we have to give on this set. Thank you for this contribution. However, for such a large patch set, it would be very much appreciated if you could put v2 on a publicly accessible git branch and include a link in the cover letter. Best Regards, Leif On Fri, Feb

Re: [edk2] [PATCH edk2-platforms 39/39] Platform/NXP:PCIe enablement for LS2088A RDB

On Fri, Feb 16, 2018 at 02:20:35PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- >

Re: [edk2] [PATCH edk2-platforms 38/39] Platform/NXP:PCIe enablement for LS1046A RDB

On Fri, Feb 16, 2018 at 02:20:34PM +0530, Meenakshi wrote: > From: Vabhav > > Compilation: Update the fdf, dsc and dec files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- >

Re: [edk2] [PATCH edk2-platforms 37/39] LS2088 : Enable support of USB controller

-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.dsc | 1 + > Platform/NXP/LS2088aRdbPkg/LS2088aRdbPkg.fdf | 13 + > Platform/NXP/NxpQoriqLs.dsc

Re: [edk2] [PATCH edk2-platforms 36/39] DWC3 : Add DWC3 USB controller initialization driver.

Minor comments below. On Fri, Feb 16, 2018 at 02:20:32PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add support of DWC3 controller driver which > Performs DWC3 controller initialization and > Register itself as NonDiscoverableMmioDevice > >

Re: [edk2] [PATCH edk2-platforms 35/39] Compilation: Update the fdf, dsc and dec files.

On Fri, Feb 16, 2018 at 02:20:31PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > LS1043A PCIe compilation and update firmware device, > description and declaration files.Defining Embedded Package > PCD which should be at least 20 for 64K PCIe IO size required

Re: [edk2] [PATCH edk2-platforms 34/39] Silicon/NXP: Implement EFI_CPU_IO2_PROTOCOL

On Fri, Feb 16, 2018 at 02:20:30PM +0530, Meenakshi wrote: > From: Vabhav > > NXP SOC has mutiple PCIe RCs,Adding respective implementation of > EFI_CPU_IO2_PROTOCOL to provide Memory Space Read/Write functions > used by generic Host Bridge Driver including correct value

Re: [edk2] [PATCH edk2-platforms 33/39] Silicon/NXP: Implement PciHostBridgeLib support

My only comment in addition to Ard's comments/questions: Use same endianness handling here as for preceding patches? / Leif On Fri, Feb 16, 2018 at 02:20:29PM +0530, Meenakshi wrote: > From: Vabhav > > Implement the library that exposes the PCIe root complexes to the

Re: [edk2] [PATCH edk2-platforms 32/39] Silicon/NXP: Implement PciSegmentLib to support multiple RCs

On Fri, Apr 20, 2018 at 06:40:27AM +, Vabhav Sharma wrote: > > > >-Original Message----- > >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > >Sent: Friday, April 20, 2018 12:57 AM > >To: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > >

Re: [edk2] [PATCH edk2-platforms 32/39] Silicon/NXP: Implement PciSegmentLib to support multiple RCs

On Fri, Feb 16, 2018 at 02:20:28PM +0530, Meenakshi wrote: > From: Vabhav > > Multiple root complex support is not provided by standard library > PciLib/PciExpressLib/PciSegmentLib, Reimplementing it and provide > function for reading/writing into PCIe configuration Space.

Re: [edk2] [PATCH edk2-platforms 31/39] LS2088ARDB: Enable NOR driver and Runtime Services

On Fri, Feb 16, 2018 at 02:20:27PM +0530, Meenakshi wrote: > From: Wasim Khan > > Enable NOR driver and Runtime Services for LS2088ARDB Platform > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wasim Khan Ah, I guess the

Re: [edk2] [PATCH edk2-platforms 30/39] LS2088 : Enable support of FpgaLib

On Fri, Feb 16, 2018 at 02:20:26PM +0530, Meenakshi wrote: > From: Wasim Khan <wasim.k...@nxp.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wasim Khan <wasim.k...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.

Re: [edk2] [PATCH edk2-platforms 29/39] Platform/NXP: LS2088 RDB Board FPGA library

; +(SwitchConf & 0xf) + 'A')); > + > + SwitchConf = FPGA_READ (BrdCfg[0]); > + > + if (SwitchConf & FPGA_CS_MASK) > +DEBUG ((DEBUG_INFO, "NAND\n")); > + else > +DEBUG ((DEBUG_INFO, "vBank: %d\n", (SwitchConf & FPGA_VBANK_MASK)

Re: [edk2] [PATCH edk2-platforms 28/39] Platform/NXP: LS2088A RDB Board Library

Core Contribution Agreement 1.1 > Signed-off-by: Wasim Khan <wasim.k...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > .../NXP/LS2088aRdbPkg/Include/IfcBoardSpecific.h | 114 > + > .../NXP/LS2088aRdbPkg/Library/BoardLi

Re: [edk2] [PATCH edk2-platforms 27/39] Compilation : Add the fdf, dsc and dec files

On Fri, Feb 16, 2018 at 02:20:23PM +0530, Meenakshi wrote: > From: Wasim Khan > > The firmware device, description and declaration files for LS2088 board > Apart from the varstore and include handling change, can you bump the DEC_SPECIFICATION entry to 0x0001001a? Nothing

Re: [edk2] [PATCH edk2-platforms 25/39] Platform/NXP/LS2088aRdbPkg: ArmPlatformLib Support for LS2088ARDB

gt; > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > .../Library/PlatformLib/ArmPlatformLib.c | 106 > .../Library/PlatformLib/ArmPlatformLib.inf | 77 + >

Re: [edk2] [PATCH edk2-platforms] Silicon/Socionext/SynQuacer: update PHY reference clock rate

.koj...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > Kojima-san, > > Please confirm that the modification to ogma_con

Re: [edk2] [PATCH edk2-platforms 24/39] Silicon/NXP:SocLib support for initialization of peripherals

A few style comments in addition to the requested layout changes. On Fri, Feb 16, 2018 at 02:20:20PM +0530, Meenakshi wrote: > From: Wasim Khan > > Added SocInit function that initializes peripherals > and print board and soc information for LS2088ARDB Board. > >

Re: [edk2] [PATCH edk2-platforms 23/39] Platform/NXP: Compilation for LS1046A RDB Board

On Fri, Feb 16, 2018 at 02:20:19PM +0530, Meenakshi wrote: > From: Vabhav > > Adding firmware device,description and declaration files to enable > compilation for NXP LS1046ARDB board. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav

Re: [edk2] [PATCH edk2-platforms 22/39] Platform/NXP: LS1046 RDB Board FPGA library

On Fri, Feb 16, 2018 at 02:20:18PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Library to provide functions for accessing FPGA > on LS1046ARDB board. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav

Re: [edk2] [PATCH edk2-platforms 21/39] Platform/NXP: Add ArmPlatformLib for LS1046A

; > + > +/** > + Return the current Boot Mode > + > + This function returns the boot reason on the platform > + > +**/ > +EFI_BOOT_MODE > +ArmPlatformGetBootMode ( > + VOID > + ) > +{ > + return BOOT_WITH_FULL_CONFIGURATION; > +} > + > +/** &

Re: [edk2] [PATCH edk2-platforms 20/39] Platform/NXP: LS1046A RDB Board Library

der: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav <vabhav.sha...@nxp.com> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > .../NXP/LS1046aRdbPkg/Include/IfcBoardSpecific.h

Re: [edk2] [PATCH edk2-platforms 19/39] Silicon/NXP:Add support for PCF2129 Real Time Clock Library

On Thu, Apr 19, 2018 at 12:33:50PM +, Meenakshi Aggarwal wrote: > > > +EFI_STATUS > > > +EFIAPI > > > +LibSetTime ( > > > + IN EFI_TIME*Time > > > + ) > > > +{ > > > + UINT8 Buffer[8]; > > > + UINT8 Index; > > > + EFI_STATUS Status; > > > +

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: fix buffer allocation bug

n > happens to be DMA aligned. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > > Silicon/Socionext/SynQuacer/Drivers/Net/Nets

Re: [edk2] [PATCH edk2-platforms 18/39] Silicon/NXP:Add LS1046ARDB SoCLib Support

On Thu, Apr 19, 2018 at 10:05:45AM +, Meenakshi Aggarwal wrote: > > CCSR_SCFG_USBDRVVBUS_SELCR_USB1); > > > + UsbPwrFault = (CCSR_SCFG_USBPWRFAULT_DEDICATED << > > > +CCSR_SCFG_USBPWRFAULT_USB3_SHIFT) | > > > +(CCSR_SCFG_USBPWRFAULT_DEDICATED << > > > +

Re: [edk2] [PATCH edk2-platforms 19/39] Silicon/NXP:Add support for PCF2129 Real Time Clock Library

On Fri, Feb 16, 2018 at 02:20:15PM +0530, Meenakshi wrote: > From: Vabhav > > Library to provide functions for NXP pcf2129 real time clock library > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vabhav > --- >

Re: [edk2] [PATCH edk2-platforms 18/39] Silicon/NXP:Add LS1046ARDB SoCLib Support

On Fri, Feb 16, 2018 at 02:20:14PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > On LS1046A NXP SoC,Provide Functions to initialize peripherals > ,print board, soc information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH edk2-platforms 17/39] LS1043 : Enable NOR driver for LS1043aRDB package.

anges to build (and work correctly) against current edk2? If not: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> / Leif > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 16 +++- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 9 - > 2 fi

Re: [edk2] [PATCH edk2-platforms 15/39] Silicon/NXP : Add support of NorFlashLib

On Fri, Feb 16, 2018 at 02:20:11PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > NorFlashLib interacts with the underlying IFC NOR controller. > This will be used by NOR driver for any information > exchange with NOR controller. Some of this looks generic

Re: [edk2] [PATCH edk2-platforms 14/39] LS1043 : Enable support of FpgaLib.

On Fri, Feb 16, 2018 at 02:20:10PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm &

Re: [edk2] [PATCH edk2-platforms 13/39] LS1043/FpgaLib : Add support for FpgaLib.

reement 1.1 > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> If you send a new version, can you fix the indentation in the last few DEBUG statements? If not, I can fix that up before committing. Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > ..

Re: [edk2] [PATCH edk2-platforms 12/39] Silicon/NXP : Add support of IfcLib

On Fri, Feb 16, 2018 at 02:20:08PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add support of IfcLib, it will be used to perform > any operation on IFC controller. Again, please describe what an IFC is. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH edk2-platforms 11/39] LS1043/BoardLib : Add support for LS1043 BoardLib.

ggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > --- > .../NXP/LS1043aRdbPkg/Include/IfcBoardSpecific.h | 109 > + > .../NXP/LS1043aRdbPkg/Library/BoardLib/BoardLib.c | 69 + > .../L

Re: [edk2] [PATCH edk2-platforms 10/39] IFC : Add Header file for IFC controller

On Fri, Feb 16, 2018 at 02:20:06PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > This header file contain IFC controller timing structure, > chip select enum and other IFC macros. Could you just add a comment as to what an IFC is? (I'm guessing it's some

Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

On Wed, Apr 18, 2018 at 04:38:22PM +, Meenakshi Aggarwal wrote: > > > + > > > +/* > > > + * Returns the bit mask for a bit index from 0 to 31 > > > + */ > > > +#define BIT(_BitIndex) (0x1u << (_BitIndex)) > > > > I don't see these being used for anything other than setting up BIT1 > >

Re: [edk2] [PATCH edk2-platforms 08/39] Compilation : Add the fdf, dsc and dec files.

On Fri, Feb 16, 2018 at 02:20:04PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > The firmware device, description and declaration files. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal

Re: [edk2] [PATCH edk2-platforms 07/39] Platform/NXP: Add support for ArmPlatformLib

On Fri, Feb 16, 2018 at 02:20:03PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm &

Re: [edk2] [PATCH edk2-platforms 06/39] Silicon/Maxim : Add support for DS1307 RTC library

b/Ds1307RtcLib.inf| 45 +++ This isn't part of the review, but in future can you try to follow Laszlo's guide when generating patches: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 ? For this patch: Reviewed-by: Leif

Re: [edk2] [PATCH edk2-platforms 04/39] Silicon/NXP : Add support for DUART library

On Fri, Feb 16, 2018 at 02:20:00PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> Reviewed-by: Leif Lindholm &

Re: [edk2] [PATCH edk2-platforms 03/39] SocLib : Add support for initialization of peripherals

On Fri, Feb 16, 2018 at 02:19:59PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > Add SocInit function that initializes peripherals > and print board and soc information. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi

Re: [edk2] [PATCH 1/2] Hisilicon/D0x: fix tftp command init failure

Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> As request

Re: [edk2] [PATCH edk2-platforms 00/39] NXP: Add support of LS1043, LS1046 and LS2088 SoCs

don't need copyright or attribution, it's just a more structured way to provide this particular bit of feedback.) / Leif >From 7da6ca87177153532811f8ecd9ad6847b480161e Mon Sep 17 00:00:00 2001 From: Leif Lindholm <leif.lindh...@linaro.org> Date: Tue, 17 Apr 2018 16:22:00 +0100 Subjec

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On Fri, Feb 16, 2018 at 02:20:01PM +0530, Meenakshi wrote: > From: Meenakshi Aggarwal > > I2C driver produces gEfiI2cMasterProtocolGuid which can be > used by other modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi

Re: [edk2] [PATCH edk2-platforms 16/39] Silicon/NXP : Add NOR driver.

(Responding somewhat out of sequence, as I'm going through to build this port and encountering issues.) This patch will require something similar to edk2-platforms 79c9dd55a32752b7ae11d5f1a50fa3ae27d6d126 in order to work with recent upstream edk2. (gVariableRuntimeDxeFileGuid has gone away with

[edk2] (spawning off more style discussion)

On Mon, Apr 16, 2018 at 09:32:44PM +0200, Laszlo Ersek wrote: > (4) Please consider adopting > > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-10 > >

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

On Mon, Apr 16, 2018 at 10:42:26PM +0200, Laszlo Ersek wrote: > On 04/16/18 16:34, Michael Brown wrote: > > On 16/04/18 15:10, Kinney, Michael D wrote: > >> I agree that the opposite use case is a BE CPU > >> needing a LE operation. > >> > >> I think we only need a single lib class and lib > >>

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

> > > On 3/20/2018 8:15 PM, Guo Heyi wrote: > > > >I've no idea about how to use Driver; let me spend some time to > > > >learn first > > > >:) > > > > > > Heyi, > > > you could use "load xxxDriver.efi" to load

Re: [edk2] [PATCH] ArmPkg/ArmMmuLib ARM: fix Mva to use idx instead of table base

ation depending on the base address value. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co <christopher...@microsoft.com> >

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

these static inline helper functions (even with the code duplication). / Leif > Mike > > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel- > > boun...@lists.01.org] On Behalf Of Leif Lindholm > > Sent: Friday, April 13, 2018 12:32 P

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

nd doing it this way lets me follow that rule. --- Clearly this is open for discussion, but the above is my opinion and the code intentionally reflects that. Regards, Leif > Mike > > > -----Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > &g

[edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

Cc: Andrew Fish <af...@apple.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> --- Maintainers.txt | 1 + 1 file chang

[edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

When performing MMIO to a destination of the opposite endianness to the executing processor, this library provides automatic byte order reversal on inputs and outputs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> --- Udit

[edk2] derailing into patch style discussion

Since you already have my r-b on the set, I'll pick up the style topic, partly because I'm not sure if I've ever explained my thinking publicly in words that anyone other than Ard understands. On Thu, Apr 12, 2018 at 07:45:19PM +0200, Laszlo Ersek wrote: > > Well, there are a couple of places

<    4   5   6   7   8   9   10   11   12   13   >