Re: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI

Just remove confusion. Thanks, Ray > 在 2016年9月30日，下午11:13，Carsey, Jaben 写道： > > I have no objection. > > Can you explain the benefit or just remove confusion? > > Reviewed-by: Jaben Carsey > >> -Original Message- >> From: edk2-devel

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

ellPkg and let it use the ShellParameter protocol. Regards, Ray From: Carsey, Jaben Sent: Friday, September 30, 2016 3:11 AM To: Ni, Ruiyu <ruiyu...@intel.com>; Yao, Jiewen <jiewen@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Jiewen, The way CapsuleApp extracts the ARGV assumes UEFI Shell encodes the parameters using a certain way. But the parameter encoding way is not described in the Shell spec. Maybe we can put the CapsuleApp in ShellPkg, then let it directly use ShellParameter protocol to get the ARGV. Copying

Re: [edk2] [PATCH 04/45] MdeModulePkg/Include: Add IniParsingLib header.

The function header of OpenDataFile doesn't match the actual prototype of this API. And since it's IniParsingLib, how about using OpenIniFile/CloseIniFile? Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen >Yao >Sent:

Re: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

I re-used the old cover letter:) Regards, Ray From: Gao, Liming Sent: Thursday, September 29, 2016 11:51 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib Your patch has updated. But, this covert

Re: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib

Yes! Thanks for the reminding. V2 will be posted. Regards, Ray From: Gao, Liming Sent: Thursday, September 29, 2016 10:49 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/3] Remove ImageDecoderLib and BmpImageDecoderLib Do you remove Include/L

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

I agree to use the same style of code as what the other functions do. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Kinney, Michael D >Sent: Thursday, September 29, 2016 8:38 AM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben <jaben.car.

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

if (EFI_ERROR (Status)) { //StatusBarSetStatusString (L"Read Disk Failed"); return Status; Regards, Ray From: Kinney, Michael D Sent: Thursday, September 29, 2016 10:12 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com&g

Re: [edk2] [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk

: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> >Subject: [Patch] ShellPkg/Hexedit: Fix FreePool() ASSERT() when writing disk > >The HDiskImageSave() function copies a device path using >DuplicateDevicePath() and passes that device path to >gBS-

Re: [edk2] [PATCH v3] MdeModulePkg/PciBusDxe: make OPROM BAR degradation configurable

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, September 26, 2016 2:27 PM > To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com>; Zeng, Star > <star.z...@

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: make BAR degradation dependent on OPROM presence

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Monday, September 12, 2016 9:49 PM >To: Ard Biesheuvel <ard.biesheu...@linaro.org>; Yao, Jiewen ><jiewen....@intel.com> >

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: make BAR degradation dependent on OPROM presence

You could use IncompatiblePciDevice protocol. If you have no clue I will give you more information my tomorrow. Thanks, Ray 在 2016年9月12日，下午9:16，Ard Biesheuvel > 写道： On 12 September 2016 at 14:15, Yao, Jiewen

Re: [edk2] [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib

...@ts.fujitsu.com] Sent: Tuesday, September 6, 2016 8:02 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [PATCH] ShellPkg: More fallbacks + error handling in UefiShellLib Dear edk2 developers, I've made a patch in the e

Re: [edk2] [PATCH] OptionRomPkg: .dsc fixes for ARM/AARCH64 and USB drivers

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Regards, Ray >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Sunday, September 4, 2016 9:16 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com>; Ard Biesheuvel

Re: [edk2] [PATCH 0/7] MdeModulePkg ArmVirtPkg: fixes for 64-bit PCI DMA

Ard, The patch to MdeModulePkg/PciHostBridgeDxe is good. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, September 6, 2016 3:48 PM &

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenuApp

Liming, Please use the term "BootManagerMenu" instead of "BootMenuApp", to avoid confusion when reading from future developers. BmIsBootMenuAppFilePath --> BmIsBootManagerMenuFilePath With the above change, Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

ch will be auto-created by EfiBootManagerGetBootManagerMenu(). BmIsBootMenuAppFilePath --> BmIsBootManagerMenuFilePath With the above two changes, Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Wednesday, August 31, 2016 4:19 PM > To: ed

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Wednesday, August 31, 2016 1:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com

Re: [edk2] [patch] ShellPkg: Add the check of parameter number in "DrvCfg" command

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 31, 2016 1:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: [patch]

Re: [edk2] [PATCH] MdeModulePkg VarCheck: #### in L"Boot####" are upper case hex

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, August 26, 2016 5:41 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Z

Re: [edk2] [Patch] Nt32Pkg PlatformBootManagerLib: Enable BootManagerMenuApp.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Dong, Eric >Sent: Wednesday, August 24, 2016 4:22 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com> >Subject: [Patch] Nt32Pkg PlatformBootManagerLib: Enable

Re: [edk2] [Patch] Nt32Pkg: Add Eric Dong as Nt32Pkg owner.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >Dong >Sent: Wednesday, August 24, 2016 4:22 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com> &g

Re: [edk2] [patch] ShellPkg: Fix the incorrect return status in function FindFiles()

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 24, 2016 11:13 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: [patch

Re: [edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

reset type to perform. Thanks/Ray > -Original Message- > From: Tian, Feng > Sent: Tuesday, August 23, 2016 11:22 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Chan, Amy <amy.c...@intel.com>; Tian, Feng <feng.t...@intel.com>

Re: [edk2] [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific

Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, August 11, 2016 1:33 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@i

Re: [edk2] [PATCH v2 1/6] ShellPkg: TAB logic incorrectly chops out fs0: when typing fs0:

@intel.com> > Subject: [edk2] [PATCH v2 1/6] ShellPkg: TAB logic incorrectly chops out fs0: > when typing fs0: > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jaben Carsey <jaben.car...@intel.com> > ---

Re: [edk2] [PATCH 15/17] SourceLevelDebugPkg DSC: Add build option to disable deprecated APIs

Since Jeff is happy on vocation, so Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming <liming..

Re: [edk2] [PATCH 01/17] FatPkg DSC: Add build option to disable deprecated APIs

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Wu, Hao A >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> >Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com

Re: [edk2] [PATCH 11/17] PcAtChipsetPkg DSC: Add build option to disable deprecated APIs

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> >Cc: Wu, Hao

Re: [edk2] [PATCH 14/17] ShellPkg DSC: Add build option to disable deprecated APIs

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Wu, Hao A >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com> >Cc: Wu, Hao A <hao.a...@intel.com>; Carsey, Jaben <jaben.c

Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in IndustryStandard/Smbios.h

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Thursday, July 28, 2016 11:04 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Dong, > Eric <e

Re: [edk2] [PATCH 1/3] IntelFrameworkModulePkg BdsDxe: Use definition in IndustryStandard/Smbios.h

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Thursday, July 28, 2016 11:04 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Dong, > Eric &l

Re: [edk2] [Patch 4/8] MdeModulePkg UefiBootManagerLib: Enhance EfiBootManagerFindLoadOption

el@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [Patch 4/8] MdeModulePkg UefiBootManagerLib: Enhance > EfiBootManagerFindLoadOption > > The same boot file may have two different device paths. One is its FV File > device path, another is LoadFile F

Re: [edk2] [PATCH 4/5] OvmfPkg/PciHostBridgeLib: silence IA32 VS2015x86 warnings

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks, Ray > 在 2016年7月15日，下午4:14，Laszlo Ersek <ler...@redhat.com> 写道： > > When compiling "OvmfPkg\Library\PciHostBridgeLib\XenSupport.c" for IA32, > the VS2015x86 compiler emits the following: > >> Xen

Re: [edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure

-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, >Jaben >Sent: Friday, July 15, 2016 5:06 AM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org >Cc: Carsey, Jaben <jaben.car...@intel.com> >Subject: Re: [edk2] [PATCH 00/27] ShellPkg: Handle me

Re: [edk2] [PATCH v2 0/4] PCI resource reservation changes for better hotpluggability

All of the serials, Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> I think it's now a PCIE world. The change #2/4 should be fine though it changes the PciBus behavior. #3/4 isn't conflict with the existing platform PciHotPlugInitDxe driver which still reports such PCIE port through GetRootH

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

> Sent: Thursday, July 7, 2016 10:42 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel-01 <edk2-de...@ml01.01.org>; Laszlo Ersek > <ler...@redhat.com>; Qiu, Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> > Subject: RE: [edk2

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: remove stale FvFile boot options

-- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 12, 2016 3:51 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Gary Lin <g...@suse.com>; > Justen, Jordan L <jordan.l.jus...@intel.com>;

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Thursday, July 7, 2016 10:47 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel-01 <edk2-devel@lists.01.org>; Gao,

Re: [edk2] [PATCH v2 04/14] Nt32Pkg: Fix typos in comments

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Friday, July 8, 2016 2:21 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [PATCH v2 04/14] Nt32Pkg: Fix typos in co

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

I vote for separate driver:) it's more clean and easy to maintain. Thanks, Ray > 在 2016年7月8日，上午1:59，Laszlo Ersek 写道： > >> On 07/07/16 19:36, Jordan Justen wrote: >>> On 2016-06-30 18:10:53, Laszlo Ersek wrote: >>> +EFI_STATUS >>> +EFIAPI >>> +DriverInitialize ( >>> + IN

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Jaben, CommandInit() API initializes gUnicodeCollation pointer. But ShellCommandLibConstructor() also initializes the gUnicodeCollation pointer. Can we just remove CommandInit() from this library? And update all callers? Thanks/Ray > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 04/16] Nt32Pkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [PATCH 04/16] Nt32Pkg:

Re: [edk2] [PATCH 08/16] OptionRomPkg: Series of patches to fix typos - EFI_OUT_OF_RESORUCES to EFI_OUT_OF_RESOURCES

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [PATCH 08/16] OptionRomPkg:

Re: [edk2] [PATCH 09/16] PcAtChipsetPkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [edk2] [PATCH 09/16] PcAtChipsetPkg:

Re: [edk2] [PATCH 2/2] Revert "ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'."

Jaben, Sorry for using a wrong email address of you. Thanks, Ray > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 7, 2016 12:37 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Jaben Carsey <jarben.car...@intel.com> &g

Re: [edk2] [PATCH 1/4] MdePkg/IndustryStandard: introduce EFI_PCI_CAPABILITY_ID_SHPC

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, July 1, 2016 9:11 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Johnson, Brian J. <bjohn...@sgi.com>; Alex William

Re: [edk2] [PATCH 3/4] MdeModulePkg/PciBusDxe: recognize hotplug-capable PCIe ports

nt: Friday, July 1, 2016 9:11 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com>; > Johnson, Brian J. <bjohn...@sgi.com>; Andrew Fish <af...@apple.com>; > Justen, Jordan L <jordan.l.

Re: [edk2] [PATCH v3] MdeModulePkg: Skip registering BootManagerMenu if its FFS is not found

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Sunny Wang [mailto:sunnyw...@hpe.com] > Sent: Friday, July 1, 2016 10:38 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Sunny Wang <sunnyw...@hpe.com> > Su

Re: [edk2] [PATCH v3 0/3] Add FrameBufferBltLib and GraphicsOutputDxe to MdeModulePkg

All, I forgot to mention the differences between last version and this version. This version doesn't remove the BltLib in OptionRomPkg so in all, it doesn't touch OptionRomPkg and OvmfPkg which depends on BltLib. This version also adopts Laszlo's suggestion to use opaque struct style to hide the

Re: [edk2] [PATCH 0/9] Add FrameBufferBltLib and generic GOP driver to MdeModulePkg.

Jordan, I misunderstood your option. I am fine to add a new library class FrameBufferBltLib and leave BltLib as is. Thanks, Ray -Original Message- From: Justen, Jordan L Sent: Thursday, June 30, 2016 4:42 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Subject: Re:

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Laszlo, Thank you for the sharing. Your patches really help to improve the EDKII code quality. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, June 29, 2016 7:50 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel-01 &

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Laszlo, Thanks for fixing such a big bug. I am curious how you detect such buggy code? By code review? Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Tuesday, June 28, 2016 9:26 PM >To: edk2-devel-01

Re: [edk2] [PATCH v2] MdeModulePkg: Skip registering BootManagerMenu if its FFS is not found

Sunny, I have 7 minor comments. Please check below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sunny >Wang >Sent: Tuesday, June 28, 2016 10:27 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu..

Re: [edk2] [PATCH v2] ShellPkg: Fix 'echo' cannot display the special characters correctly.

22, 2016 11:17 PM To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [PATCH v2] ShellPkg: Fix 'echo' cannot display the special characters correctly. Very nice. I like this much

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Fix for wrong data updated into MemoryTypeInformation variable

RamDiskSizeInPages. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> I will think about how to fix that corner case. Regards, Ray >-Original Message- >From: Sunny Wang [mailto:sunnyw...@hpe.com] >Sent: Monday, June 20, 2016 4:03 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Skip registering BootManagerMenu if its FFS is not found

pe.com] >Sent: Monday, June 20, 2016 5:44 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...@intel.com>; Sunny Wang ><sunnyw...@hpe.com> >Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Skip registering >BootManagerMenu if its FFS is not foun

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Keep HTTP boot mounted RAM disk

.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...@intel.com>; Sunny Wang ><sunnyw...@hpe.com> >Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Keep HTTP boot mounted RAM >disk > >There may be some use cases which need to keep HTTP boot mounted RAM disk >(downlo

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Fix for wrong data updated into MemoryTypeInformation variable

Sunny, Under what circumstance the memory usage statistics don't count the allocation? Regards, Ray >-Original Message- >From: Sunny Wang [mailto:sunnyw...@hpe.com] >Sent: Monday, June 20, 2016 4:03 PM >To: edk2-devel@lists.01.org >Cc: el...@hpe.com; Ni, Ruiyu <ruiyu...

Re: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path is partially displayed

Laszlo, Jaben, The dotdot style is copied from Shell spec V2.2 page 120 "dh" command output sample. Regards, Ray From: Carsey, Jaben Sent: Saturday, June 18, 2016 5:47 AM To: Laszlo Ersek <ler...@redhat.com>; Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org Cc: Ca

Re: [edk2] [PATCH v2] MdeModulePkg:Prevent the BmRepairAllControllers routine in an infinite loop

I am ok for the code logic. Reviewed-by: ruiyu...@intel.com Thanks, Ray > 在 2016年6月3日，下午3:23，Gary Li 写道： > > Prevent the BmRepairAllControllers routine in an infinite loop > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Li

Re: [edk2] [PATCH] Nt32Pkg/PlatformBootManagerLib: zero EFI_GRAPHICS_OUTPUT_BLT_PIXEL.Reserved

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, May 26, 2016 7:04 AM >To: edk2-devel-01 <edk2-de...@ml01.01.org> >Cc: Andrew Fish <af...@apple.com>; Justen, Jordan L >&l

Re: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

Laszlo, I am terribly sorry about that! For this patch serials, I didn't noticed your r-b. That's why I offline asked Jeff to send his r-b. I can add your tested by tag, there is no reason to ignore your review by! For the dependency patch, I forgot your review by mail after a weekend. I will

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeDxe: Add CpuArch protocol dependency

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Thursday, May 19, 2016 4:08 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org >Cc: Gao, Liming <liming@intel.com&g

Re: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM

I agree. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, May 19, 2016 3:38 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel-01 <edk2-de...@ml01.01.org> >Cc: Justen, Jo

Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

to:ler...@redhat.com] >Sent: Wednesday, May 18, 2016 8:12 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org >Cc: Anbazhagan Baraneedharan <anbazha...@hp.com>; Zeng, Star ><star.z...@intel.com> >Subject: Re: [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC

Re: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM

edk2-de...@ml01.01.org> >Cc: Ni, Ruiyu <ruiyu...@intel.com>; Justen, Jordan L ><jordan.l.jus...@intel.com> >Subject: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there >is no CSM > >According to edk2 commit > >

Re: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

I agree to put ecr number in commit message. Thanks, Ray > 在 2016年5月18日，下午7:35，Laszlo Ersek <ler...@redhat.com> 写道： > > On 05/18/16 10:16, Ni, Ruiyu wrote: >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>> Sent: Tuesd

Re: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

64F5B107-317A-4857-9D71-5C4165493076 Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, May 17, 2016 8:23 PM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-de...@ml01.01.org >Subject: Re: [edk2] [Patch 0/4

Re: [edk2] [PATCH] MdeModulePkg: Skip invalid bus number scanning in PciBusDxe driver

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice >Ma >Sent: Tuesday, May 17, 2016 5:26 AM >To: edk2-devel@lists.01.org >Cc: Tian, Feng <feng.t...@intel.com>; Z

Re: [edk2] PcRtcAcpiTableChangeCallback question

devel@lists.01.org ><edk2-de...@ml01.01.org>; Ni, Ruiyu ><ruiyu...@intel.com> >Subject: Re: [edk2] PcRtcAcpiTableChangeCallback question > >On 05/17/16 01:20, Anbazhagan, Baraneedharan wrote: > >> PcRtcAcpiTableChangeCallback doesn't seem to be called if >> g

Re: [edk2] [PATCH] OvmfPkg/PlatformBootManagerLib: Postpone the shell registration

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Wednesday, May 11, 2016 6:28 PM >To: Gary Lin <g...@suse.com>; edk2-de...@ml01.01.org >Cc: Justen, Jordan L <jordan.

Re: [edk2] [PATCH v2 0/7] PciHostBridgeDxe: Bug fix and OVMF above Xen support

github url: https://github.com/niruiyu/edk2/tree/XenOvmf2 Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Tuesday, May 10, 2016 1:53 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com> >Subject: [PATCH v2 0/7] PciHostBridgeDxe: Bug fix an

Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

tBus->MemAbove4G.Limit = 0; if (PcdGet64 (PcdPciMmio64Size) > 0) { Regards, Ray From: Gary Lin [mailto:g...@suse.com] Sent: Monday, May 9, 2016 4:32 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above X

Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

(especially the function ScanForBridges()) can also be used in Coreboot? So that Coreboot can directly use core PciHostBridgeDxe. Regards, Ray From: Ni, Ruiyu Sent: Monday, May 9, 2016 2:29 PM To: Gary Lin <g...@suse.com> Cc: edk2-devel@lists.01.org Subject: RE: [Patch 0/6] PciHostBridgeDx

Re: [edk2] [Patch 0/6] PciHostBridgeDxe: Bug fix and OVMF above Xen support

Gary, Can you please check whether the patch can fix the OVMF above Xen issue? Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Monday, May 9, 2016 2:26 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com> >Subject: [Patch 0/6] PciHostBri

Re: [edk2] [Patch 4/6] MdeModulePkg/PciHostBridgeLib: Add ResourceAssigned field

Re-forward to Laszlo using the correct mail address. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Monday, May 9, 2016 2:27 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@intel.com>; Fan, Jeff ><jeff.

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Gary, Can you kindly teach me how to run OVMF under Xen? I worked out a draft fix and need to verify whether everything is fine. Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, April 28, 2016 6:36 PM >To: Ni, Ruiyu <rui

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Thursday, May 5, 2016 8:07 AM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org >Cc: Fan, Jeff <jeff@intel.com>

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

Regards, Ray >-Original Message- >From: Daniil Egranov [mailto:daniil.egra...@arm.com] >Sent: Thursday, May 5, 2016 7:57 AM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org >Cc: Fan, Jeff <jeff@intel.com> >Subject: Re: [edk2] [PATCH v2 2/3]

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> >-Original Message- >From: Fu, Siyuan >Sent: Wednesday, May 4, 2016 1:58 PM >To: edk2-devel@lists.01.org >Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Ni, Ruiyu ><ruiyu...@intel.co

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

2 comments below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: [edk2] [PATCH v2 3/3]

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

3 comments below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: [edk2] [PATCH v2 2/3]

Re: [edk2] [PATCH v2 1/3] IntelFrameworkModulePkg/GenericBdsLib: Check for invalid device handle

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff <jeff

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

I encountered the same issue weeks ago. A quick but dirty fix is to change: UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c: CpuS3DataInitialize() // // Allocate a 4KB reserved page below 1MB // - AcpiCpuData->StartupVector = BASE_1MB - 1; + ApiCpuData->StartupVector = BASE_512KB - 1; Copying Jeff.

Re: [edk2] [Patch v4 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, May 2, 2016 6:25 PM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org >Cc: Justen, Jordan L <jordan.l.jus...@intel.com> >Subject: Re: [

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, May 3, 2016 1:19 AM >To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org >Subject: Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform > >

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

https://github.com/niruiyu/edk2/commits/Ovmf_Bds Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, April 29, 2016 7:21 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-de...@ml01.01.org Subject: Re: [edk2] [Patch v4 00/23] Use MdeMod

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

in the check: case ACPI_ADDRESS_SPACE_TYPE_MEM /* 0 */: if (Descriptor->AddrSpaceGranularity != 32 && Descriptor->AddrSpaceGranularity != 64) { return EFI_INVALID_PARAMETER; } I agree with your patch. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Regards, Ray >-Original Messag

Re: [edk2] [PATCH] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

>-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo >Sent: Saturday, April 23, 2016 4:54 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Heyi Guo >; Tian, Feng

Re: [edk2] [Patch v3 02/23] OvmfPkg/PlatformPei: Add memory above 4GB as tested

Regards, Ray >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, April 26, 2016 5:27 AM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-de...@ml01.01.org; Justen, Jordan L <jordan.l.jus...@intel.com> >Subject: Re: [edk2] [Patch

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Copying Mike. Regards, Ray >-Original Message- >From: Ni, Ruiyu >Sent: Wednesday, April 27, 2016 5:49 PM >To: 'Gary Lin' <g...@suse.com> >Cc: edk2-devel@lists.01.org; Xen Devel <xen-de...@lists.xen.org>; Laszlo Ersek ><ler...@redhat.com> >Su

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

se.com] >Sent: Wednesday, April 27, 2016 4:27 PM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-devel@lists.01.org; Xen Devel <xen-de...@lists.xen.org> >Subject: Re: [edk2] OVMF broken under Xen (in PCI initialisation) > >On Wed, Apr 27, 2016 at 07:18:

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Regards, Ray >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Wednesday, April 27, 2016 12:29 PM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-devel@lists.01.org; Xen Devel <xen-de...@lists.xen.org> >Subject: Re: [edk2] OVMF broken un

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

lready allocated. Maybe just depends on the PcdPciBusDisableEnumeration. still thinking. Regards, Ray >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Tuesday, April 26, 2016 4:40 PM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-devel@list

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Gary, Maybe the system boots to Shell well but the video isn't initialized properly. Can you build the firmware using "-D DEBUG_ON_SERIAL_PORT" switch and give me the boot log? Regards, Ray From: Gary Lin [mailto:g...@suse.com] Sent: Tuesday, April 26, 2016 3:35 PM To: Ni, Ru

Re: [edk2] A logic error in OvmfPkg\SataControllerDxe\SataController.c

Adding Laszlo & Jordan, It sounds like a trivial bug. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang >xiaofeng >Sent: Tuesday, April 26, 2016 3:02 PM >To: Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

>Sent: Tuesday, April 26, 2016 2:29 PM >To: Anthony PERARD <anthony.per...@citrix.com>; Ni, Ruiyu <ruiyu...@intel.com> >Cc: edk2-de...@ml01.01.org; Laszlo Ersek <ler...@redhat.com>; Xen Devel ><xen-de...@lists.xen.org> >Subject: Re: [edk2] OVMF broken under

Re: [edk2] OVMF broken under Xen (in PCI initialisation)

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Anthony >PERARD >Sent: Friday, April 22, 2016 10:48 PM >To: edk2-devel@lists.01.org >Cc: Xen Devel >Subject: [edk2] OVMF broken under Xen (in PCI

Re: [edk2] [Patch v3 21/23] OvmfPkg/PlatformBds: Add EnableQuietBoot and DisableQuietBoot

Got you. I will send the v4 to correct the OEMBadging.h issue, after collecting all comments for the v3 series. Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Thursday, April 21, 2016 4:42 PM To: Ni, Ruiyu <ruiyu...@intel.com> Cc:

<    4   5   6   7   8   9   10   11   >