Re: [edk2] [PATCH 1/2] ArmPlatformPkg: remove ArmVExpress-FVP-AArch64

2016-01-18 Thread Laszlo Ersek
On 01/18/16 15:29, Ryan Harkin wrote: > ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. > > Currently, FVP exists both in EDK2's ArmPlatformPkg and in > OpenPlatformPkg [2]. And they are starting to diverge, with > OpenPlatformPkg being the most up-to-date with current

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ryan Harkin
On 18 January 2016 at 14:39, Ard Biesheuvel wrote: > On 18 January 2016 at 15:29, Ryan Harkin wrote: >> ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. >> >> Currently, Juno and FVP exist both in EDK2's ArmPlatformPkg and in >>

[edk2] [PATCH 1/2] ArmPlatformPkg: remove ArmVExpress-FVP-AArch64

2016-01-18 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, FVP exists both in EDK2's ArmPlatformPkg and in OpenPlatformPkg [2]. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the

[edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, Juno and FVP exist both in EDK2's ArmPlatformPkg and in OpenPlatformPkg. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the

[edk2] [PATCH 2/2] ArmPlatformPkg: remove ArmJuno.dsc/fdf

2016-01-18 Thread Ryan Harkin
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. Currently, Juno exists both in EDK2's ArmPlatformPkg and in OpenPlatformPkg [2]. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ard Biesheuvel
On 18 January 2016 at 15:29, Ryan Harkin wrote: > ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. > > Currently, Juno and FVP exist both in EDK2's ArmPlatformPkg and in > OpenPlatformPkg. And they are starting to diverge, with > OpenPlatformPkg being the

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ryan Harkin
On 18 January 2016 at 15:11, Ard Biesheuvel wrote: > On 18 January 2016 at 16:08, Ryan Harkin wrote: >> On 18 January 2016 at 14:39, Ard Biesheuvel >> wrote: >>> On 18 January 2016 at 15:29, Ryan Harkin

Re: [edk2] [PATCH 1/2] ArmPlatformPkg: remove ArmVExpress-FVP-AArch64

2016-01-18 Thread Ryan Harkin
On 18 January 2016 at 14:55, Laszlo Ersek wrote: > On 01/18/16 15:29, Ryan Harkin wrote: >> ARM Ltd Platform support is migrating to use OpenPlatformPkg [1]. >> >> Currently, FVP exists both in EDK2's ArmPlatformPkg and in >> OpenPlatformPkg [2]. And they are starting to

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ard Biesheuvel
On 18 January 2016 at 16:28, Ryan Harkin wrote: > On 18 January 2016 at 15:11, Ard Biesheuvel wrote: >> On 18 January 2016 at 16:08, Ryan Harkin wrote: >>> On 18 January 2016 at 14:39, Ard Biesheuvel

Re: [edk2] [PATCH 0/2] ArmPlatformPkg: Remove FVP and Juno

2016-01-18 Thread Ryan Harkin
On 18 January 2016 at 15:38, Ard Biesheuvel wrote: > On 18 January 2016 at 16:28, Ryan Harkin wrote: >> On 18 January 2016 at 15:11, Ard Biesheuvel >> wrote: >>> On 18 January 2016 at 16:08, Ryan Harkin

Re: [edk2] [patch V2 3/3] MdeModulePkg: Add MorLock to variable driver.

2016-01-18 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Monday, January 18, 2016 2:52 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B; Zeng, Star Subject: [patch V2 3/3] MdeModulePkg: Add MorLock to

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Laszlo Ersek
On 01/16/16 15:46, Zeng, Star wrote: > On 2016/1/16 1:39, Laszlo Ersek wrote: >> On 01/15/16 18:33, Ryan Harkin wrote: >>> On 15 January 2016 at 17:05, Laszlo Ersek wrote: Hi, snipping context liberally... > Whilst simple text input seems to work

Re: [edk2] Transition to GitHub Update

2016-01-18 Thread Laszlo Ersek
On 01/16/16 15:25, Ard Biesheuvel wrote: > On 15 January 2016 at 22:14, Jarlstrom, Laurie > wrote: >> To: EDK II Community >> >> This message is an update on the transition from SourceForge to GitHub for >> EDK II development. The schedule is currently targeting the

Re: [edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

2016-01-18 Thread Laszlo Ersek
Hello Zhu Yonghong, On 01/18/16 08:36, Yonghong Zhu wrote: > By the BUILDRULEORDER feature to process files listed in INF [Sources] > sections in priority order, if a filename is listed with multiple > extensions, the tools will use only the file that matches the first > extension in the space

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Zeng, Star
[...] The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c: // // Set the timeout value of serial buffer for // keystroke response performance issue // In TerminalConIn.c: // //

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Laszlo Ersek
On 01/18/16 17:17, Brian J. Johnson wrote: > On 01/18/2016 05:55 AM, Laszlo Ersek wrote: >> On 01/18/16 12:41, Ryan Harkin wrote: >>> >On 18 January 2016 at 11:33, Laszlo Ersek wrote: >>On 01/18/16 11:24, Zeng, Star wrote: > >>>[...] > >>> >>> > >>>

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Laszlo Ersek
On 01/18/16 12:41, Ryan Harkin wrote: > On 18 January 2016 at 11:33, Laszlo Ersek wrote: >> On 01/18/16 11:24, Zeng, Star wrote: >>> [...] >>> > > The above analysis is very clear, thanks. I am a little concern about if > the code changes below follow the comments

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Laszlo Ersek
On 01/18/16 11:24, Zeng, Star wrote: > [...] > >>> >>> The above analysis is very clear, thanks. I am a little concern about if >>> the code changes below follow the comments in the code. >>> >>> In Terminal.c: >>> // >>> // Set the timeout value of serial buffer for >>> //

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Ryan Harkin
On 18 January 2016 at 11:33, Laszlo Ersek wrote: > On 01/18/16 11:24, Zeng, Star wrote: >> [...] >> The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c:

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Brian J. Johnson
On 01/18/2016 05:55 AM, Laszlo Ersek wrote: On 01/18/16 12:41, Ryan Harkin wrote: >On 18 January 2016 at 11:33, Laszlo Ersek wrote: >>On 01/18/16 11:24, Zeng, Star wrote: >>>[...] >>> > >The above analysis is very clear, thanks. I am a little concern about if

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

2016-01-18 Thread Laszlo Ersek
On 01/18/16 19:44, John Snow wrote: > > > On 01/18/2016 05:57 AM, Laszlo Ersek wrote: >> Hello Feng, John, >> >> On 11/03/15 02:48, Tian Feng wrote: >>> When executing ATAPI cmd at IDE mode, EFI_SUCCESS may be returned wrongly >>> with old logic but in fact DRQ is not ready and the transaction

[edk2] [PATCH 2/2] MdeModulePkg/.../IdeMode: report early finish of packet read as success

2016-01-18 Thread Laszlo Ersek
SVN r19611 (git commit 7cac240163), "MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI", changed the behavior of AtaPacketReadWrite(), when DRQReady2() reported an error. The previous logic had been to: (a) terminate the transfer loop, (b) check the status register with

[edk2] [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

2016-01-18 Thread Laszlo Ersek
The series [edk2] [patch 0/2] Fix a DVD device compatbility issue http://thread.gmane.org/gmane.comp.bios.edk2.devel/3681 fixed an IDE timeout masking (misreporting) bug in the AtaAtapiPassThru driver. (And, separately, it increased SCSI disk timeouts to 30s.) However, the IDE change that

[edk2] [PATCH 1/2] MdeModulePkg/.../IdeMode: actualize DRQReady*() comment blocks

2016-01-18 Thread Laszlo Ersek
The DRQReady() and DRQReady2() functions only differ in that they poll different status registers for BSY, ERR, and DRQ: the former looks at the Status Register (clearing interrupt status), while the latter looks at the Alternate Status Register (not clearing interrupt status). They both

[edk2] [Patch] edk2: Update the maintainer list.

2016-01-18 Thread Jiaxin Wu
This patch is used to update the CryptoPkg and NetworkPkg maintainer list. Cc: Long Qin Cc: Fu Siyuan Cc: Tian Hot Cc: Li Ruth Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu

Re: [edk2] [Patch] edk2: Update the maintainer list.

2016-01-18 Thread Fu, Siyuan
Jiaxin, It's ok with me. Reviewed-by: Siyuan Fu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Tuesday, January 19, 2016 9:40 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Tian, Hot

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

2016-01-18 Thread Laszlo Ersek
On 01/19/16 00:08, John Snow wrote: > > > On 01/18/2016 05:28 PM, Laszlo Ersek wrote: >> On 01/18/16 22:05, John Snow wrote: >>> >>> >>> On 01/18/2016 02:33 PM, Laszlo Ersek wrote: On 01/18/16 19:44, John Snow wrote: > > > On 01/18/2016 05:57 AM, Laszlo Ersek wrote: >> Hello

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-18 Thread Zeng, Star
On 2016/1/18 19:33, Laszlo Ersek wrote: On 01/18/16 11:24, Zeng, Star wrote: [...] The above analysis is very clear, thanks. I am a little concern about if the code changes below follow the comments in the code. In Terminal.c: // // Set the timeout value of serial buffer for

[edk2] [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg

2016-01-18 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index dc0891e..1095fe0 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -191,6 +191,7

[edk2] [Patch] Vlv2DeviceRefcodePkg:Add setup option to control _STA of LPE Audio

2016-01-18 Thread lushifex
Signed-off-by: lushifex --- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl | 3 ++- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/Pch.asl| 12 +--- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PchLpss.asl| 7 +-- Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg

2016-01-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Tuesday, January 19, 2016 11:44 AM To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Tian, Hot Cc: Wu, Hao A Subject: [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg

Re: [edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

2016-01-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, January 18, 2016 3:36 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: process the files by the priority in

Re: [edk2] [PATCH 0/2] MdeModulePkg/.../IdeMode: restore handling of "short reads"

2016-01-18 Thread Tian, Feng
Laszlo & John Thanks for your detail analysis. It's very helpful for me. Reviewed-by: Feng Tian I am thinking shall we update EFI_SCSI_INQUIRY_DATA/ATAPI_INQUIRY_DATA data structure as well to only contain the first 36 bytes? According to ATAPI SFF 8020i & SPC4 spec,

Re: [edk2] Transition to GitHub Update

2016-01-18 Thread Bjorge, Erik C
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Saturday, January 16, 2016 6:26 AM > To: Jarlstrom, Laurie > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] Transition to GitHub Update > > On 15 January 2016 at

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

2016-01-18 Thread Laszlo Ersek
On 01/18/16 22:05, John Snow wrote: > > > On 01/18/2016 02:33 PM, Laszlo Ersek wrote: >> On 01/18/16 19:44, John Snow wrote: >>> >>> >>> On 01/18/2016 05:57 AM, Laszlo Ersek wrote: Hello Feng, John, On 11/03/15 02:48, Tian Feng wrote: > When executing ATAPI cmd at IDE mode,

Re: [edk2] [patch 1/2] MdeModulePkg/Ide: return correct status when DRQ is not ready for ATAPI

2016-01-18 Thread Laszlo Ersek
On 01/18/16 20:33, Laszlo Ersek wrote: > On 01/18/16 19:44, John Snow wrote: >> >> >> On 01/18/2016 05:57 AM, Laszlo Ersek wrote: >>> Hello Feng, John, >>> >>> On 11/03/15 02:48, Tian Feng wrote: When executing ATAPI cmd at IDE mode, EFI_SUCCESS may be returned wrongly with old logic but