Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 09/01/16 21:52, Jordan Justen wrote: > On 2016-09-01 11:46:04, Laszlo Ersek wrote: >> On 09/01/16 20:03, Jordan Justen wrote: >> >>> I think there would be value to have a non-VGA device that could still >>> configure a simple framebuffer. VGA does bring a fair amount of other >>> baggage. >>

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

Series Reviewed-by: Jordan Justen On 2016-08-19 05:49:21, Laszlo Ersek wrote: > This series solves > . In particular, > it gives AARCH64 guests running on KVM a clean, uncorrupted graphical > console. > > Anatomy

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 08/19/16 14:49, Laszlo Ersek wrote: > - Also tested loading and launching Linux from GRUB. Here the results > differ of course: x86_64 Fedora 24 drives virtio-gpu-pci with its > native driver without problems, whereas AARCH64 Fedora 23 doesn't even > look for virtio-gpu-pci, apparently.

Re: [edk2] Crc32

Please read this, don't discard hastily, it might be intesting for the project. I have a suggestion about the implementation of Crc32 found in this place: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/RuntimeDxe/Crc32.c Figuring out why proper mathematical crc calculation

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

Points taken. Oh well. :\ On 2016-09-01 13:23:27, Ard Biesheuvel wrote: > On 1 September 2016 at 20:52, Jordan Justen wrote: > > On 2016-09-01 11:46:04, Laszlo Ersek wrote: > >> On 09/01/16 20:03, Jordan Justen wrote: > >> > >> > I think there would be value to have a

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 09/01/16 22:32, Jordan Justen wrote: > Series Reviewed-by: Jordan Justen Thank you! Series committed as b10d5ddc0385..3ef3209d3028. Cheers, Laszlo > On 2016-08-19 05:49:21, Laszlo Ersek wrote: >> This series solves >>

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 1 September 2016 at 21:23, Ard Biesheuvel wrote: > On 1 September 2016 at 20:52, Jordan Justen wrote: >> On 2016-09-01 11:46:04, Laszlo Ersek wrote: >>> On 09/01/16 20:03, Jordan Justen wrote: >>> >>> > I think there would be value to have

[edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu

Rename local function name BootMenuApp to BootManagerMenu to align to other public function name. In V2, use "BootManagerMenu" instead of "BootMenuApp". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Ruiyu Ni

[edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenu from LoadFile

BootManagerMenu boot option is handled by EfiBootManagerGetBootManagerMenu. Don't need to handle it again when parse LoadFile protocol. In V2, use "BootManagerMenu" instead of "BootMenuApp". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

Re: [edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenu from LoadFile

Looks good to me. Reviewed-by: Sunny Wang Regards, Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, September 01, 2016 2:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2]

Re: [edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu

Looks good to me. Reviewed-by: Sunny Wang Regards, Sunny Wang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, September 01, 2016 2:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2]

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 31 August 2016 at 21:43, Jordan Justen wrote: > On 2016-08-19 07:25:54, Laszlo Ersek wrote: >> On 08/19/16 15:06, Ard Biesheuvel wrote: >> > On 19 August 2016 at 14:49, Laszlo Ersek wrote: >> >> This series solves >> >>

Re: [edk2] [PATCH] SecurityPkg: TPM12CommandLib: Add Response returnCode Check

Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Wednesday, August 31, 2016 9:47 AM To: edk2-devel@lists.01.org Cc: Long, Qin ; Yao, Jiewen ; Zhang, Chao B

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 09/01/16 20:03, Jordan Justen wrote: > On 2016-09-01 09:29:28, Laszlo Ersek wrote: >> On 08/31/16 22:43, Jordan Justen wrote: >>> >>> If an OS can't load or find the native driver, the framebuffer also >>> provides a way to communicate with the user. >> >> I agree that exposing the framebuffer

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 1 September 2016 at 20:52, Jordan Justen wrote: > On 2016-09-01 11:46:04, Laszlo Ersek wrote: >> On 09/01/16 20:03, Jordan Justen wrote: >> >> > I think there would be value to have a non-VGA device that could still >> > configure a simple framebuffer. VGA does bring

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 2016-09-01 11:46:04, Laszlo Ersek wrote: > On 09/01/16 20:03, Jordan Justen wrote: > > > I think there would be value to have a non-VGA device that could still > > configure a simple framebuffer. VGA does bring a fair amount of other > > baggage. > > Ah, I see your point. You distinguish

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 09/01/16 03:11, Fan, Jeff wrote: > Laszlo, > > UefiCpuPkg/PiSmmCpuDxeSmm driver and > UefiCpuPkg/Library/SmmCpuFeatuersLib have no such requirement on > gEfiVariableArchProtocolGuid to access HII type PCD. In fact, our > platform SmmCpuFeaturesLib instance (linked by PiSmmCpuDxeSmm) is >

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 2016-09-01 09:29:28, Laszlo Ersek wrote: > On 08/31/16 22:43, Jordan Justen wrote: > > > > If an OS can't load or find the native driver, the framebuffer also > > provides a way to communicate with the user. > > I agree that exposing the framebuffer address through the GOP (at boot > time) so

[edk2] [Patch] BaseTools: Change source files to DOS format

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenFv/GenFvInternalLib.c| 12 +- BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py | 564 - 2 files

[edk2] UEFI Sample application for read/write serial IO

Hi all, I want to write UEFI application which reads/writes to serial IO. Is there a sample UEFI application code available which demonstrates Serial IO read/write? Thanks. With regards, Keshava ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] UEFI Sample application for read/write serial IO

Thanks, Michael and Andrew... On Thu, 1 Sep 2016 at 20:56 Andrew Fish wrote: > > > On Sep 1, 2016, at 4:48 AM, GN Keshava wrote: > > > > Thanks Michael, > > > > By sample I mean is there any code which uses Serial IO Protocol to > > read/write to UART in

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Hi Ankit Singh A reminder: We haven't seen you filing a Bugzilla yet. At same time, we reviewed UEFI spec and raised an open to USWG. (For your information only) Thank you Yao Jiewen From: Yao, Jiewen Sent: Wednesday, August 31, 2016 8:55 AM To: ankit_sin...@dell.com; edk2-devel@lists.01.org

Re: [edk2] [Patch] BaseTools: Change source files to DOS format

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, September 1, 2016 5:15 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch]

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

Laszlo, There is no changing request on Ovmf and UefiCpuPkg SmmCpuFeaturesLib instances. Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, September 02, 2016 1:47 AM To: Fan, Jeff; Zeng, Star; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Justen,

Re: [edk2] [PATCH] IntelSiliconPkg: Rename IGD structures to make it consistent

Reviewed by: jiewen@intel.com > -Original Message- > From: Mudusuru, Giri P > Sent: Wednesday, August 31, 2016 6:58 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] IntelSiliconPkg: Rename IGD structures to make it > consistent > >

Re: [edk2] UEFI Sample application for read/write serial IO

I can't give you sample code but if you're familiar with using UEFI protocols it's actually very easy. You just have to use the gEfiSerialIoProtocolGuid protocol which can be found in: MdePkg/Include/Protocol/SerialIo.h Thanks Michael On Thu, Sep 1, 2016 at 1:22 PM, GN Keshava

[edk2] [PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg

The commit "965268e SecurityPkg: Use IsZeroGuid API for zero GUID checking" breaks the ArmPkg build as below. edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:184: undefined reference to `IsZeroGuid' edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:5692: undefined reference to

Re: [edk2] [PATCH 1/3] ArmPkg/CompilerIntrinsicsLib: replace memcpy and memset with C code

On Thu, Aug 11, 2016 at 08:20:30PM +0200, Ard Biesheuvel wrote: > This replaces the various implementations of memset and memcpy, > including the ARM RTABI ones (__aeabi_mem[set|clr]_[|4|8]) with > a single C implementation for each. The ones we have are either not > very sophisticated (ARM), or

Re: [edk2] UEFI Sample application for read/write serial IO

Thanks Michael, By sample I mean is there any code which uses Serial IO Protocol to read/write to UART in edk2 package? or any open source code should be fine. This is just to get an idea how I can use the protocol. Thanks Keshava On Thu, 1 Sep 2016 at 17:09 Michael Zimmermann

Re: [edk2] [PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg

On 1 September 2016 at 13:11, Vikas C Sajjan wrote: > The commit "965268e SecurityPkg: Use IsZeroGuid API for zero GUID checking" > breaks the ArmPkg build as below. > > edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:184: undefined reference > to `IsZeroGuid' >

Re: [edk2] UEFI Sample application for read/write serial IO

AFAIK TerminalDxe is the only user of that protocol who actually writes to the SerialIo: MdeModulePkg/Universal/Console/TerminalDxe The code is rather complex because it does way more than just using the serial console but if you look at the right functions(e.g. TerminalConOutOutputString) it

Re: [edk2] [PATCH 1/3] ArmPkg: remove BaseMemoryLibVstm implementation of BaseMemoryLib

On Wed, Aug 31, 2016 at 10:07:31AM +0100, Ard Biesheuvel wrote: > The BaseMemoryLibVstm implementation of BaseMemoryLib is ARM only, uses > the NEON register file despite the fact that the UEFI spec does not allow > it, and is currently not used anywhere. So remove it. > > Contributed-under:

Re: [edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment

Laszlo, You are correct. No functional change. I think I was more concerned about source changes to the functions that were already well tested, and wanted to focus the source code changes on the functions that were being enabled for multiple segments. If we are all confident from the code

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Hi Jiewen, Already logged defect for Capsule Status Variable on bugzillar tracker (EDK II) on 31th August. https://tianocore.acgmultimedia.com/show_bug.cgi?id=108 Regards, Ankit Singh From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Friday, September 02, 2016 7:21 AM To: Singh3, Ankit

Re: [edk2] [EDK2] DxeCapsuleLib returns Status Issue

Thanks. We reviewed bug till 107 last time, unfortunately. That is why I did not find it. It will be reviewed next time. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of ankit_sin...@dell.com Sent: Friday, September 2, 2016 11:25 AM To: Yao, Jiewen

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 08/31/16 22:43, Jordan Justen wrote: > On 2016-08-19 07:25:54, Laszlo Ersek wrote: >> On 08/19/16 15:06, Ard Biesheuvel wrote: >>> On 19 August 2016 at 14:49, Laszlo Ersek wrote: This series solves . In

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 09/01/16 09:44, Ard Biesheuvel wrote: > On 31 August 2016 at 21:43, Jordan Justen wrote: >> On 2016-08-19 07:25:54, Laszlo Ersek wrote: >>> On 08/19/16 15:06, Ard Biesheuvel wrote: On 19 August 2016 at 14:49, Laszlo Ersek wrote: > This

Re: [edk2] UEFI Sample application for read/write serial IO

> On Sep 1, 2016, at 4:48 AM, GN Keshava wrote: > > Thanks Michael, > > By sample I mean is there any code which uses Serial IO Protocol to > read/write to UART in edk2 package? or any open source code should be fine. > > This is just to get an idea how I can use the