Re: [edk2] [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Jiewen, Please remove the QuarkCapsule.fdf file and merge those contents into Quark.fdf. In Quark.fdf, put the FMP and Capsules sections for recovery next to each other surrounded by !if $(RECOVERY_ENABLE). With the update to GenFds in BaseTools, the order of the sections is more flexible, so

Re: [edk2] [PATCH] ShellPkg/UefiShellTftpCommandLib: Update TFTP help text

Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: Thomas Palmer [mailto:thomas.pal...@hpe.com] > Sent: Wednesday, October 12, 2016 1:15 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben >

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

I agree. We should move the 3 protocols from the UEFI Shell Specification from ShellPkg to MdePkg. I think that this is a non-backwards-compatible-change and will require a new GUID in ShellPkg. -Jaben From: Yao, Jiewen Sent: Tuesday, October 11, 2016 7:45 AM To: Ni, Ruiyu

Re: [edk2] [PATCH 0/3] PL011 updates.

On 21 September 2016 at 21:33, wrote: > From: Evan Lloyd > > This patchset comprises two very minor fixes to the PL011 UART related > code, and some comment updates. > The FIFO fix amounts to a performance improvement in limited circumstaces, > where some

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver

On 12 October 2016 at 08:08, Laszlo Ersek wrote: > On 10/12/16 04:36, Ni, Ruiyu wrote: >> I agree with Ard. Building PciBusDxe driver as EBC ARCH is supported from >> tool perspective, but doesn't >> make much sense in real world. >> So the patch is just to resolve the build

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle

On 12 October 2016 at 09:37, Ryan Harkin wrote: > On 23 September 2016 at 08:58, Ard Biesheuvel > wrote: >> On 22 September 2016 at 23:33, Daniil Egranov wrote: >>> The fix handles the PCI Dual Address Cycle Attribute

Re: [edk2] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

Hi Ryan. No, this is dead. Ard's rebuttal was spot on, and unarguable. The problem needs fixing, but not in UEFI. Please disregard this patch. Regards, Evan >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: 11 October 2016 20:17 >To:

Re: [edk2] [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging

On 10/10/16 22:27, Bruce Cran wrote: > On 10/10/2016 4:29 PM, Laszlo Ersek wrote: > >> >> (maybe the subject can be rewritten as >> >>OvmfPkg: add NOOPT build target for source level debugging >> >> but I can do that later when I commit the patch.) > > Oh, good point! > Commit

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Add the missing EFIAPI for the function

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Sunday, October 9, 2016 10:36 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Cecil Sheng

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver

Seems nobody objects this path. reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, October 12, 2016 4:36 PM To: Laszlo Ersek Cc: Ni, Ruiyu

[edk2] [PATCH 4/5] OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer

This field is (re)allocated in QemuVideoGraphicsOutputSetMode(), released in QemuVideoGraphicsOutputDestructor(), and used for nothing else. Remove it. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek

[edk2] [PATCH 5/5] OvmfPkg/QemuVideoDxe: upgrade VERBOSE debug messages to INFO

In commit 5b2291f9567a ("OvmfPkg: QemuVideoDxe uses MdeModulePkg/FrameBufferLib"), QemuVideoDxe was rebased to FrameBufferBltLib. The FrameBufferBltLib instance added in commit b1ca386074bd ("MdeModulePkg: Add FrameBufferBltLib library instance") logs many messages on the VERBOSE level; for

[edk2] [PATCH 2/5] OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_CIRRUS_MODES.RefreshRate

Thanks to the previous patch, this field is also unnecessary now. Remove it. The patch is best reviewed with "git show --word-diff". Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH 0/5] OvmfPkg/QemuVideoDxe: cleanups and tweaks

Reviewing (part of) Ray's recent FrameBufferBltLib changes gave me the idea for this. The patches are really small. Public branch: . Cc: Jordan Justen Thanks Laszlo Laszlo Ersek (5): OvmfPkg/QemuVideoDxe: drop

[edk2] [PATCH 1/5] OvmfPkg/QemuVideoDxe: drop useless QEMU_VIDEO_MODE_DATA.RefreshRate

This field is never used beyond assignment and debug-logging. Remove it. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Qemu.h | 1 -

[edk2] [PATCH 3/5] OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.CurrentMode

This field is never used. Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Qemu.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[edk2] Format a volume in UEFI (or delete all files)

Hi all, I need to format fs1: (or delete all files and folders in root directory) from my UEFI application. I'm able to use file system APIs such as Open, Write or Delete too. But Delete API needs File (file path) as argument, but what I want is delete all files (irrespective of file name).

Re: [edk2] [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle

On 23 September 2016 at 08:58, Ard Biesheuvel wrote: > On 22 September 2016 at 23:33, Daniil Egranov wrote: >> The fix handles the PCI Dual Address Cycle Attribute case. It allows >> drivers using PCI DAC run on Juno. >> >> Contributed-under:

Re: [edk2] [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

On 7 October 2016 at 16:59, Leif Lindholm wrote: > Roy can now be found at Roy Franz (cc:d). > > On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: >> Roy, Ryan, >> >> On 10/07/16 16:53, Brian J. Johnson wrote: >> > This patch series

[edk2] [PATCH 41/52] BaseTools/GenCrc32: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenCrc32/GenCrc32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH 51/52] BaseTools/VfrCompile/Pccts: Add virtual destructor for class DLGInputStream

Class DLGInputStream defined in DLexerBase.h has a virtual method but no virtual destructor. This commit add an empty virtual destructor to avoid potential memory/resource leak when an object of a class derived from class DLGInputStream is deleted through a pointer to the DLGInputStream class.

[edk2] [PATCH 45/52] BaseTools/TianoCompress: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 15 --- 1 file changed, 12 insertions(+), 3

[edk2] [PATCH 52/52] BaseTools/VfrCompile/Pccts: Make assignment operator not returning void

The assignment operators for class ANTLRTokenPtr return void in current code. This commit makes them return the reference to the object just like primitive types do. Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi

[edk2] [PATCH 50/52] BaseTools/VolInfo: Use hard-coded format string for calls to sprintf()

For calls to API sprintf(), use hard-coded format string instead of a local variable. This helps to prevent the format string from being changed accidentally, which may lead to potential buffer overflows. Cc: Liming Gao Cc: Yonghong Zhu

[edk2] [PATCH 35/52] BaseTools/Split: Fix potential memory and resource leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/Split/Split.c | 41 +++- 1 file changed, 28 insertions(+),

[edk2] [PATCH 42/52] BaseTools/GenFv: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [edk2] Format a volume in UEFI (or delete all files)

On 10/12/16 12:48, GN Keshava wrote: > Hi all, > > I need to format fs1: (or delete all files and folders in root directory) > from my UEFI application. > > I'm able to use file system APIs such as Open, Write or Delete too. But > Delete API needs File (file path) as argument, but what I want is

[edk2] [PATCH 44/52] BaseTools/LzmaCompress: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/LzmaCompress/LzmaCompress.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[edk2] [PATCH 47/52] BaseTools/GenVtf: Fix potential buffer overflow in scanf functions

String width is not specified for '%s' specifier in the format string for scanf functions. This can result in buffer overflows. This commit now specifies the string length for '%s' in format strings according to the size of receiving buffers. Cc: Liming Gao Cc: Yonghong

[edk2] [PATCH 39/52] BaseTools/EfiRom: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/EfiRom/EfiRom.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[edk2] [PATCH 43/52] BaseTools/GenVtf: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenVtf/GenVtf.c | 13 + 1 file changed, 13 insertions(+) diff --git

[edk2] [PATCH 36/52] BaseTools/TianoCompress: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[edk2] [PATCH 46/52] BaseTools/VolInfo: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/VolInfo/VolInfo.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [PATCH 32/52] BaseTools/GenPage: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenPage/GenPage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2] [PATCH 27/52] BaseTools/VfrCompile: Avoid freeing freed memory in classes

For classes that contain dynamically allocated data members, copy constructor and assignment operator should be implemented or both operations should be prohibited to avoid freeing freed memory caused by shallow copy. This commit declares both copy constructor and assignment operator as 'private'

[edk2] [PATCH 28/52] BaseTools/VfrCompile: Remove unused local variables

Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 26/52] BaseTools/VfrCompile: Add assignment operator definition for some classes

For class that defines the copy constructor, it is better to add the assignment operator definition as well. This commit adds the definition for assignment operator for the classes with the copy constructor defined. Cc: Liming Gao Cc: Yonghong Zhu

[edk2] [PATCH 33/52] BaseTools/GenSec: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenSec/GenSec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH 23/52] BaseTools/TianoCompress: Fix potential access over array bounds

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[edk2] [PATCH 22/52] BaseTools/GenFv: Fix potential access over array bounds

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFv/GenFv.c| 9 +++-- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 55

[edk2] [PATCH 30/52] BaseTools/EfiRom: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/EfiRom/EfiRom.c | 70 +++--- 1 file changed, 51 insertions(+),

[edk2] [PATCH 37/52] BaseTools/VfrCompile: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 48/52] BaseTools/VolInfo: Fix potential buffer overflow in scanf functions

String width is not specified for '%s' specifier in the format string for scanf functions. This can result in buffer overflows. This commit now specifies the string length for '%s' in format strings according to the size of receiving buffers. Cc: Liming Gao Cc: Yonghong

[edk2] [PATCH 34/52] BaseTools/GenVtf: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenVtf/GenVtf.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH 49/52] BaseTools/VfrCompile: Explicitly state format string for DebugMsg()

For calls to API DebugMsg(), explicitly state format string as "%s" when the given variable list is a sting. Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore

[edk2] [PATCH 40/52] BaseTools/GenBootSector: Fix file handles not being closed

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenBootSector/GenBootSector.c | 35 1 file changed, 23 insertions(+),

[edk2] [PATCH 24/52] BaseTools/VfrCompile: Fix potential access over array bounds

Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 25/52] BaseTools/VfrCompile: Avoid freeing memory with mismatched functions

Memory allocated by operator new[] should be freed using delete[] to avoid possible memory leak. Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution

[edk2] [PATCH 31/52] BaseTools/GenFv: Fix potential memory leak

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-)

Re: [edk2] [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.

On 10/12/16 14:39, Eric Dong wrote: > In IsDevicePathValid API, code should validate the device path > buffer not exceed the input MaxSize before reference the path > info. This patched series add this check. > > Eric Dong (2): > MdePkg UefiDevicePathLib: Validate buffer length before use

[edk2] [Patch 0/2] MdePkg DevicePathLib: Check buffer length before use.

In IsDevicePathValid API, code should validate the device path buffer not exceed the input MaxSize before reference the path info. This patched series add this check. Eric Dong (2): MdePkg UefiDevicePathLib: Validate buffer length before use buffer. MdePkg UefiDevicePathLibDevicePathProtocol:

[edk2] [Patch 1/2] MdePkg UefiDevicePathLib: Validate buffer length before use buffer.

In IsDevicePathValid API, code should validate the device path buffer not exceed the input MaxSize before reference the path info. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Ruiyu Ni ---

Re: [edk2] ArmPlatformPkg: Allocate VRAM as RuntimeServicesData

On 12 October 2016 at 12:39, Evan Lloyd wrote: > Hi Ryan. > No, this is dead. > Ard's rebuttal was spot on, and unarguable. The problem needs fixing, but > not in UEFI. > Please disregard this patch. > Thanks, yes, it's ignored. > Regards, > Evan > > >>-Original

[edk2] [PATCH 13/52] BaseTools/VfrCompile: Initialize local variables before being used

Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 12/52] BaseTools/TianoCompress: Initialize local variables before being used

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[edk2] [PATCH 14/52] BaseTools/GenBootSector: Fix parameter format mismatch in printf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenBootSector/GenBootSector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[edk2] [PATCH 00/52] Resolve issues for C source codes in BaseTools

The patch series fixes the following types of issues for C source codes in BaseTools: 1. Avoid possible NULL pointer dereference 2. Initialize local variables before use 3. Remove unused local variables 4. Avoid accessing over array bounds 5. Resolve possible memory leak 6. Resolve file handles

[edk2] [PATCH 09/52] BaseTools/TianoCompress: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/TianoCompress/TianoCompress.c | 37 1 file changed, 25 insertions(+),

[edk2] [PATCH 05/52] BaseTools/GenFw: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFw/Elf32Convert.c | 8 BaseTools/Source/C/GenFw/Elf64Convert.c | 10 +-

[edk2] [PATCH 08/52] BaseTools/GenVtf: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenVtf/GenVtf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[edk2] [PATCH 10/52] BaseTools/VfrCompile: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 11/52] BaseTools/VolInfo: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/VolInfo/VolInfo.c | 46 1 file changed, 42 insertions(+),

[edk2] [PATCH 04/52] BaseTools/GenFv: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH 18/52] BaseTools/GenFw: Fix parameter format mismatch in scanf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFw/GenFw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 19/52] BaseTools/GenVtf: Fix parameter format mismatch in scanf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenVtf/GenVtf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH 15/52] BaseTools/VolInfo: Fix parameter format mismatch in printf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/VolInfo/VolInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 03/52] BaseTools/GenFfs: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFfs/GenFfs.c | 36 +++- 1 file changed, 19 insertions(+), 17

[edk2] [PATCH 06/52] BaseTools/GenPage: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenPage/GenPage.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH 16/52] BaseTools/C/Common: Fix parameter format mismatch in scanf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/Common/ParseInf.c | 24

[edk2] [PATCH 17/52] BaseTools/GenFv: Fix parameter format mismatch in scanf functions

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[edk2] [PATCH 20/52] BaseTools/C/Common: Fix potential access over array bounds

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/Common/CommonLib.c | 8 ++-- BaseTools/Source/C/Common/Decompress.c | 7 +-- 2 files

[edk2] [PATCH 21/52] BaseTools/EfiRom: Fix potential access over array bounds

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/EfiRom/EfiRom.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[edk2] [Patch 2/2] MdePkg UefiDevicePathLibDevicePathProtocol: Validate before use.

In IsDevicePathValid API, code should validate the device path buffer not exceed the input MaxSize before reference the path info. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Ruiyu Ni --- .../UefiDevicePathLib.c

[edk2] [PATCH 07/52] BaseTools/GenSec: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/GenSec/GenSec.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff

[edk2] [PATCH 02/52] BaseTools/EfiRom: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/EfiRom/EfiRom.c | 38 -- 1 file changed, 20 insertions(+),

[edk2] [PATCH 01/52] BaseTools/C/Common: Avoid possible NULL pointer dereference

Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseTools/Source/C/Common/BasePeCoff.c | 12 + BaseTools/Source/C/Common/EfiUtilityMsgs.c

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver

On 10/12/16 04:36, Ni, Ruiyu wrote: > I agree with Ard. Building PciBusDxe driver as EBC ARCH is supported from > tool perspective, but doesn't > make much sense in real world. > So the patch is just to resolve the build failure in EBC ARCH. If Ard is fine with the EBC default for

[edk2] [PATCH] Nt32Pkg/WinNtBusDriverDxe: Fix small memory overrun

When allocating memory for a string, the CHAR16 NUL character needs two bytes of space. Use StrSize to get accurate size Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer --- Nt32Pkg/WinNtBusDriverDxe/WinNtBusDriver.c | 4 ++-- 1 file

Re: [edk2] [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order

Zhu Yonghong, Thanks for the RB on the first patch in that series. Your patch: https://lists.01.org/pipermail/edk2-devel/2016-October/002507.html [Patch] BaseTools: Extend FMP to support FV statement and FD statement is a better solution to the OUTPUT_DIRECTORY issue, so I am dropping

Re: [edk2] Format a volume in UEFI (or delete all files)

Thanks Laszlo, I'll check it out. I think I need to combine the LS implementation and RM implementation, isn't it? So there is no "format this volume" function or command exists, right? Thanks again! Regards, Keshava On Wed 12 Oct, 2016 8:01 pm Laszlo Ersek, wrote: > On

Re: [edk2] Format a volume in UEFI (or delete all files)

On 10/12/2016 10:34 AM, GN Keshava wrote: > Thanks Laszlo, I'll check it out. > > I think I need to combine the LS implementation and RM implementation, > isn't it? So there is no "format this volume" function or command exists, > right? The commands do exist. But they're not in Tianocore, and

Re: [edk2] Format a volume in UEFI (or delete all files)

There is an effort to move these tools to EDK II. More news as it happens. Thanks ... br --- Brian Richardson, Senior Technical Marketing Engineer, Intel Software brian.richard...@intel.com -- http://evangelists.intel.com/bio/Brian_Richardson_ -Original Message- From: edk2-devel

Re: [edk2] Format a volume in UEFI (or delete all files)

depending on his use case it can be unnecessary to do a low level FS format though(he said that he just wants to delete all files). It can also become problematic if you consider that the original filesystem doesn't have to be FAT. Thanks Michael On Wed, Oct 12, 2016 at 7:46 PM, Richardson,

Re: [edk2] Format a volume in UEFI (or delete all files)

On 10/12/2016 07:31 AM, Laszlo Ersek wrote: > On 10/12/16 12:48, GN Keshava wrote: >> Hi all, >> >> I need to format fs1: (or delete all files and folders in root directory) >> from my UEFI application. >> >> I'm able to use file system APIs such as Open, Write or Delete too. But >> Delete API

Re: [edk2] [PATCH] ShellPkg:‘cd \’ command fails to go back to the root directory of a file system

Reviewed-by: Jaben Carsey And pushed. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, October 07, 2016 2:00 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > >

Re: [edk2] [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Yes. I will do that once BaseTool binary is updated. From: Kinney, Michael D Sent: Thursday, October 13, 2016 5:01 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Steele, Kelly ; Tian, Feng

Re: [edk2] [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Jiewen: The latest BaseTools Win32 Binary has supported it. Please try. From: Yao, Jiewen Sent: Thursday, October 13, 2016 8:39 AM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Steele, Kelly ; Tian, Feng ; Zeng,

Re: [edk2] Format a volume in UEFI (or delete all files)

Thanks Laszlo. Is it possible to run RM (or any shell command) from my C application code? Something like "System()" in Linux? Whether we can use LoadImage for this purpose? Thanks again. Regards, Keshava On Wed 12 Oct, 2016 11:10 pm Laszlo Ersek, wrote: > On 10/12/16

Re: [edk2] [PATCH V2 39/50] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Sounds great! From: Gao, Liming Sent: Thursday, October 13, 2016 8:44 AM To: Yao, Jiewen ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Steele, Kelly ; Tian, Feng ; Zeng, Star

Re: [edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: CryptoPkg/TlsLib: Fix FILE_GUID

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Thomas Palmer [mailto:thomas.pal...@hpe.com] > Sent: Thursday, October 13, 2016 4:43 AM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; joseph.shiffl...@hpe.com; Thomas >

[edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent

The current AsmGetFspInfoHeader function in FspHeader.nasm is position dependent code since it uses absolute address. Change to use relative address instead to make it position independent. Cc: Jiewen Yao Cc: Giri P Mudusuru Contributed-under:

Re: [edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

Sounds good! Thanks to confirm that. From: Carsey, Jaben Sent: Thursday, October 13, 2016 5:04 AM To: Yao, Jiewen ; Ni, Ruiyu ; Rothman, Michael A ; Kinney, Michael D ; 'edk2-devel@lists.01.org'

Re: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI

I actually off-line reviewed the 11 patches before sending them out. Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni >Sent: Friday, September 30, 2016 4:18 PM >To:

Re: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent

Thanks for fixing the bug Maurice. Please fix the typo funcitons in the title during checkin Reviewed-by: Giri P Mudusuru > -Original Message- > From: Ma, Maurice > Sent: Wednesday, October 12, 2016 6:03 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice

[edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

Adding Intel Firmware Version Info (FVI) related defines & structures. FVI enables reporting the Firmware Versions using SMBIOS OEM Type. Cc: Jiewen Yao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [Patch] Nt32Pkg SecMain: Update SecMain.inf to support VS2015x86 X64 Mode

From: chanuei Update SecMain.inf to support VS2015x86 X64 Mode Build. After this change, X64 Native Tools Command Prompt is not required to be trig. NT32 IA32 and X64 can be built in the same environment. It simplifies NT32 X64 build. New build command: edksetup.bat --nt32

[edk2] SmmCommunicationCommunicate question?

Whether TPL needs to be raised before setting CommunicationBuffer and BufferSize in gSmmCorePrivate to avoid a callback overwriting those values before triggering SW SMI? -Baranee ___ edk2-devel mailing list edk2-devel@lists.01.org