[edk2] [PATCH v4] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

From: Daniil Egranov The patch reads a valid MAC address form the Juno IOFPGA registers and pushes it into onboard Marvell Yukon NIC. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- Hi Leif, The

Re: [edk2] [RFC 1/6] MdeModulePkg: Add DxeBmDmaLib library

> On Jan 9, 2017, at 4:16 PM, Leo Duran wrote: > > This patch provides an abstraction layer for DMA operations implemented > by the PciHostBridgeDxe driver. The intent is to then allow override of > this library as may be required by specific hardware implementations, > such

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

On 2017-01-09 08:37:38, Duran, Leo wrote: > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Monday, January 09, 2017 9:14 AM > > > > On 01/09/17 15:22, Duran, Leo wrote: > > > > > >> -Original Message- > > >> From: Gao, Liming

[edk2] [RFC 4/6] MdeModulePkg: Modify .DSC files that include PciHostBridgeDxe driver

This patch adds the new DxeBmDmaLib (BmDmaLib class) library, which provides an abstraction layer for DMA operations implemented by the PciHostBridgeDxe driver. Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [RFC 6/6] MdeModulePkg: Modify PciHostBridgeDxe to use new BmDmaLib library.

Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- .../Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf | 1 + .../Bus/Pci/PciHostBridgeDxe/PciRootBridge.h | 13 +-

[edk2] [RFC 0/6] DxeBmDmaLib

This patch-set provides an abstraction layer for DMA operations implemented by the PciHostBridgeDxe driver. The intent is to then allow override of this library as may be required by specific hardware implementations, such as AMD's Secure Encrypted Virtualization (SEV). This new (BmDmaLib class)

[edk2] [RFC 3/6] CorebootPayloadPkg: Modify .DSC files that include PciHostBridgeDxe driver

This patch adds the new DxeBmDmaLib (BmDmaLib class) library, which provides an abstraction layer for DMA operations implemented by the PciHostBridgeDxe driver. Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement

[edk2] [RFC 5/6] OvmfPkg: Modify .DSC files that include PciHostBridgeDxe driver

This patch adds the new DxeBmDmaLib (BmDmaLib class) library, which provides an abstraction layer for DMA operations implemented by the PciHostBridgeDxe driver. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement

[edk2] [RFC 2/6] ArmVirtPkg: Modify .DSC files that include PciHostBridgeDxe driver

This patch adds the new DxeBmDmaLib (BmDmaLib class) library, which provides an abstraction layer for DMA operations implemented by the PciHostBridgeDxe driver. Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [Patch v3] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

On 01/09/17 20:33, Laszlo Ersek wrote: > On 01/09/17 19:02, Michael Kinney wrote: >> The Debug Agent in the SourceLevelDebugPkg can multiplex >> both source level debug messages and console messages on >> the same UART. When this is done, the Debug Agent owns >> the UART device and an additional

Re: [edk2] [Patch v3] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

On 01/09/17 19:02, Michael Kinney wrote: > The Debug Agent in the SourceLevelDebugPkg can multiplex > both source level debug messages and console messages on > the same UART. When this is done, the Debug Agent owns > the UART device and an additional device handle with a > Serial I/O Protocol is

Re: [edk2] [PATCH v2] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

On 01/09/17 19:40, Jordan Justen wrote: > Reviewed-by: Jordan Justen Thank you; commit 7ecfa0aa38a3. Cheers, Laszlo > On 2017-01-06 09:28:47, Laszlo Ersek wrote: >> EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to >> access in UEFI encoding,

Re: [edk2] [PATCH 4/5] ShellPkg/Dh: Fix coding style issues

DisplayDriverModelHandle() always return SUCCESS so we change the return type to VOID. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Monday, January 9, 2017 11:37 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chen, Chen A ;

Re: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter

Jaben, Yes we will add the API to convert string to GUID. After the library API is added, the local implementation will be removed. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Monday, January 9, 2017 11:41 PM > To: Ni, Ruiyu ;

Re: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Config: TPM2 ACPI Table Rev Option

Chao, Add minor comments at below, others are good to me. Reviewed-by: Star Zeng On 2017/1/10 10:24, Zhang, Chao B wrote: Add TPM2 ACPI Table Rev Option in Tcg2Config UI. Rev 4 is defined in TCG ACPI Specification 00.37 Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Config: TPM2 ACPI Table Rev Option

Hi Can we use the definition in Acpi table? I do not think we need redefine them here. +#define TPM2_ACPI_REVISION_3 3 +#define TPM2_ACPI_REVISION_4 4 Thank you Yao Jiewen > -Original Message- > From: Zhang, Chao B > Sent: Tuesday, January 10, 2017 10:25 AM > To:

[edk2] [PATCH 2/2] SecurityPkg: Tcg2Config: TPM2 ACPI Table Rev Option

Add TPM2 ACPI Table Rev Option in Tcg2Config UI. Rev 4 is defined in TCG ACPI Specification 00.37 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/SecurityPkg.dec | 7 ++

[edk2] [PATCH 1/2] MdePkg: Tpm2Acpi.h: Update TPM2 ACPI table version

Update TPM2 ACPI Table revision to 4. New version & data structure is defined in TCG ACPI Spec 00.37 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 --- 1 file changed, 4

[edk2] [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

Current CorebootPayloadPkgIa32X64.dsc contains "-flto" flag to request GCC link time optimization. However, this feature is only supported by newer GCC compiler, and it will break the debug build with GCC4.8. To fix it, the extra compiling flags are removed. It allows the default build flags set

Re: [edk2] [PATCH 1/1] CorebootPayloadPkg: Remove improper build flags in DSC file

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Maurice Ma >Sent: Tuesday, January 10, 2017 11:33 AM >To: edk2-devel@lists.01.org >Cc: Agyeman, Prince >Subject: [edk2]

Re: [edk2] [Patch] Nt32Pkg/WinNtSimpleFileSystemDxe: Fix ASSERT() parsing '\'

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Monday, January 9, 2017 11:42 PM > To: Kinney, Michael D ; edk2- > de...@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben

Re: [edk2] [RFC 3/6] CorebootPayloadPkg: Modify .DSC files that include PciHostBridgeDxe driver

Looks good to me. Reviewed-by: Maurice Ma Thanks, Maurice -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Monday, January 9, 2017 4:17 PM To: edk2-devel@lists.01.org Cc: brijesh.si...@amd.com; ler...@redhat.com; Justen, Jordan L

Re: [edk2] [PATCH 1/2] MdePkg: Tpm2Acpi.h: Update TPM2 ACPI table version

Hi Can we keep the old definition? -#define EFI_TPM2_ACPI_TABLE_REVISION 3 +#define EFI_TPM2_ACPI_TABLE_REVISION 4 E.g. #define EFI_TPM2_ACPI_TABLE_REVISION_3 3 #define EFI_TPM2_ACPI_TABLE_REVISION_4 4 #define EFI_TPM2_ACPI_TABLE_REVISIONEFI_TPM2_ACPI_TABLE_REVISION_4 So that it can be

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Hi Feng, The problem is failing to send scsi command without this patch. Without this patch, I’ll find there’s no response UPIU of command UPIU. Best Regards Haojian From: Tian, Feng Sent: 2017年1月9日 9:25 To: Haojian Zhuang; leif.lindh...@linaro.org; ard.biesheu...@linaro.org;

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Haojian It's weird, I ever tested it with real h/w. it worked well. As I have no UFS at hand, could you please test the old revision if EDKII UFS driver to see if it's regression? And just like I said before, your fix has problem if selected slot is not zero. Thanks Feng -Original

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

OK Liming, I think I understand now. Thanks, Leo > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Monday, January 09, 2017 11:34 PM > To: Duran, Leo ; Justen, Jordan L > ; 'Laszlo Ersek' ; edk2-

[edk2] [PATCH] ShellPkg: Update smbiosview command to display Type 3 values

The smbiosview command was not displaying SMBIOS Type 3 Height, NumberofPowerCords, or SKU Number. Added handling to display these values. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Phillips ---

Re: [edk2] [PATCH] SecurityPkg: Tcg2ConfigDxe/Tcg2Smm: Fix TPM2 HID issue

Reviewed-by: Star Zeng -Original Message- From: Zhang, Chao B Sent: Tuesday, January 10, 2017 2:54 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zeng, Star ; Zhang, Chao B Subject: [PATCH]

[edk2] [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number

Starting with SMBIOS spec version 2.7, Type 3 added SKU Number. SKU Number is at a variable offset (depends on count and length of Contained Elements), so cannot add SKU Number to the SMBIOS_TABLE_TYPE3 structure. Adding comments to explain how to get SKU Number. Contributed-under: TianoCore

[edk2] [PATCH] Nt32Pkg: Fix code to correctly set SMBIOS Type 2 Length

When running Nt32Pkg, SMBIOS Type 2 had the wrong Length. Fixed the code to use the correct structure in sizeof, and properly account for ContainedObjectHandles. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Phillips ---

[edk2] [PATCH] SecurityPkg: Tcg2ConfigDxe/Tcg2Smm: Fix TPM2 HID issue

Fix wrong TPM2 HID generation logic. Cc: Star Zeng Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 4 ++--

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

Leo: I suggest to add new IoFifo APIs into IoLib library class, not add IoFifoLib class. After add IoFifo APIs into IoLib library class, we have to update all IoLib library instances to include IoFifo API implementation. For IA32 and X64 arch, your proposed implementation will be used. For

Re: [edk2] [RFC 1/6] MdeModulePkg: Add DxeBmDmaLib library

> -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Monday, January 09, 2017 6:47 PM > To: Duran, Leo > Cc: edk2-devel ; Tian, Feng > ; Singh, Brijesh ; Ard > Biesheuvel

[edk2] [PATCH] Nt32Pkg: Fixes to correctly set SMBIOS Type 3

When running Nt32Pkg, SMBIOS Type 3 was missing Height, NumberofPowerCords, and SKU Number. Also, ContainedElements was not being handled correctly. Fixed code to add example data, correct some variable names (Assert -> Asset), and properly handle setting the Type 3 values. Contributed-under:

Re: [edk2] [PATCH] SecurityPkg: Tcg2ConfigDxe/Tcg2Smm: Fix TPM2 HID issue

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zhang, Chao B > Sent: Tuesday, January 10, 2017 2:54 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Zhang, Chao B > Subject: [PATCH]

Re: [edk2] [Patch] Nt32Pkg/WinNtSimpleFileSystemDxe: Fix ASSERT() parsing '\'

Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Saturday, January 7, 2017 11:19 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben ; > Kinney, Michael D

Re: [edk2] [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter

Looks good. Reviewed-by: Jaben Carsey I had one inline question. I would also propose that the String to GUID conversion be placed in a shared library. Maybe even baselib with the other string functions? Mike, do you have any thoughts on StringToGuid conversion? >

Re: [edk2] [Patch] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

On 01/09/17 06:31, Michael Kinney wrote: > The Debug Agent in the SourceLevelDebugPkg can multiplex > both source level debug messages and console messages on > the same UART. WHen this is done, the Debug Agent owns > the UART device and an additional device handle with a > Serial I/O Protocol is

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

BTW, I also you should have mentioned that the proposed IoFifoLib is intended to support just x86 (IA32 + X64)... Whereas IoLIb is universal. Leo. > -Original Message- > From: Duran, Leo > Sent: Monday, January 09, 2017 8:23 AM > To: 'Gao, Liming' ; Justen, Jordan L

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, January 09, 2017 9:14 AM > To: Duran, Leo ; 'Gao, Liming' > ; Justen, Jordan L ; > edk2-devel@lists.01.org >

Re: [edk2] [PATCH] MdeModulePkg/BootMaintenanceManagerUiLib: Support NT32 terminals

Send to correct mail address. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, January 9, 2017 10:19 AM > To: edk2-devel@lists.01.org > Cc: Dandan Bi ; Gao, Liming

[edk2] [PATCH 1/5] ShellPkg/HandleParsingLib: Rename global variables

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- .../UefiHandleParsingLib/UefiHandleParsingLib.c| 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[edk2] [PATCH 5/5] ShellPkg/dh: Support dump from GUID and "decode" parameter

To follow Shell spec 2.2, change "dh" to support dump from protocol GUID and support "decode" parameter to dump the GUID/name mapping. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Jaben Carsey Cc: Ruiyu Ni Signed-off-by: Chen A Chen

Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Hi Linson, On 2017/1/9 16:58, Linson Augustine wrote: Added defintions for the new SMBIOS Type 43 record. Typo "defintions" should be "definitions". I noticed that the new type 43 is added in new SMBIOS spec 3.1.0, but there are also other definitions and structure fields added in new

Re: [edk2] [PATCH v1 1/1] ShellPkg/PrintInfo.c: Add decoding of SMBIOS record type 43

Linson, Add some comments below. On 2017/1/9 17:14, Linson Augustine wrote: Added decoding of the new SMBIOS Type 43 record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Augustine Linson P ---

[edk2] [PATCH v1 1/1] ShellPkg/PrintInfo.c: Add decoding of SMBIOS record type 43

Added decoding of the new SMBIOS Type 43 record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Augustine Linson P --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 16 +++- 1 file changed, 15 insertions(+), 1

Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Thank you Star for the review. I will change the commit the message. I don't have plans for the other definitions. Regards, Linson -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, January 09, 2017 2:49 PM To: Augustine, Linson P ;

Re: [edk2] [PATCH v1 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43

Hi Star, Suggested changes for the commit message is done. Regards, Linson -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Augustine, Linson P Sent: Monday, January 09, 2017 3:00 PM To: Zeng, Star ; edk2-devel@lists.01.org

[edk2] [PATCH 4/5] ShellPkg/Dh: Fix coding style issues

From: Chen A Chen The change doesn't impact the functionality. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Jaben Carsey Cc: Ruiyu Ni Signed-off-by: Ruiyu Ni Signed-off-by: Chen A Chen

[edk2] [PATCH 3/5] ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids

From: Chen A Chen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Signed-off-by: Chen A Chen --- ShellPkg/Include/Library/HandleParsingLib.h| 21 -

[edk2] [PATCH 2/5] ShellPkg/HandleParsingLib: Return NULL name for unknown GUID

GetStringNameFromGuid() returns NULL for unknown GUID, instead of returning "UnknownDevice". The behavior change matches ShellProtocol.GetGuidName(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey ---

[edk2] [PATCH 0/5] Change "dh" to support dump from GUID and "decode" parameter

Change "dh" to support dump from GUID and "decode" parameter Chen A Chen (2): ShellPkg/HandleParsingLib: Add new API GetAllMappingGuids ShellPkg/Dh: Fix coding style issues Ruiyu Ni (3): ShellPkg/HandleParsingLib: Rename global variables ShellPkg/HandleParsingLib: Return NULL name for

[edk2] update capsule image on Quark SoC x1000 Gen2

Hello, I am trying to update Bios flash from UEFI shell. I get the following error. Kindly need help on this. Evaluate DXE DEPEX for FFS(378D7B65-8DA9-4773-B6E4-A47826A833E1) PUSH GUID(1E5668E2-8481-11D4-BCF1-0080C73C8881) = FALSE PUSH GUID(6441F818-6362-4E44-B IA32 Exception Type -

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

Please pardon the churn... It just occurred to me that perhaps renaming the library may justify its standalone existence... How about if I call it: X86IoFifoLib? (since the intended consumers are x86 packages) Leo. > -Original Message- > From: Duran, Leo > Sent: Monday, January 09,

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

> -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Sunday, January 08, 2017 9:11 PM > To: Duran, Leo ; Justen, Jordan L > ; 'Laszlo Ersek' ; edk2- > de...@lists.01.org > Cc: Singh, Brijesh

[edk2] [Patch v2] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

The Debug Agent in the SourceLevelDebugPkg can multiplex both source level debug messages and console messages on the same UART. When this is done, the Debug Agent owns the UART device and an additional device handle with a Serial I/O Protocol is produced with a VenHw device path node. In order

[edk2] [Patch v3] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

The Debug Agent in the SourceLevelDebugPkg can multiplex both source level debug messages and console messages on the same UART. When this is done, the Debug Agent owns the UART device and an additional device handle with a Serial I/O Protocol is produced with a VenHw device path node. In order

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

On 01/09/17 15:22, Duran, Leo wrote: > >> -Original Message- >> From: Gao, Liming [mailto:liming@intel.com] >> Sent: Sunday, January 08, 2017 9:11 PM >> To: Duran, Leo ; Justen, Jordan L >> ; 'Laszlo Ersek' ; edk2- >>

Re: [edk2] [Patch] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

Laszlo, Thanks for the feedback. I have send v2 and v3. Please ignore v2. I missed the STD_ERROR flag in v2 and fixed in v3. On a related topic, if you look at: QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformData.c You will see in the function InitializePlatformBootManagerLib()

Re: [edk2] [PATCH v2] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

Reviewed-by: Jordan Justen On 2017-01-06 09:28:47, Laszlo Ersek wrote: > EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to > access in UEFI encoding, not in edk2/PciLib encoding. > > Introduce the POWER_MGMT_REGISTER_Q35_EFI_PCI_ADDRESS() macro,

Re: [edk2] Improvement at Wiki (EFI_SHELL_INTERFACE)

Rafael, You may have been referring to the EFI_SHELL_INTERFACE that is the older protocol from the EFI Shell Interface protocol from EDK (1) shell (no Specification). If you are using older UEFI Firmware with the EDK 1 Shell not the EDK II Shell 2 then you can use this protocol. You can check

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Remove platform policy

Remove silicon platform policy which is not used by any silicon code. Signed-off-by: zwei4 Cc: Mike Wu Cc: Benjamin You Cc: Mang Guo Cc: Shifei Lu ---

[edk2] Serial port flush in UEFI

Hi, >From my UEFI application, I want to flush serial port (both TX and RX) similar to PurgeComm function in Windows . Can somebody suggest a way to do this on UEFI? Thanks! Regards, Keshava G N

Re: [edk2] [Patch] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

On 01/09/17 19:07, Kinney, Michael D wrote: > Laszlo, > > Thanks for the feedback. I have send v2 and v3. Please ignore v2. > I missed the STD_ERROR flag in v2 and fixed in v3. > > On a related topic, if you look at: > > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformData.c > >