Re: [edk2] [Patch] BaseTools: Fix Segmentation fault: 11 when build AppPkg with XCODE5

Liming, Your right I'm off by one. The signature is in the thing EFI_IMAGE_DEBUG_DIRECTORY_ENTRY points to. I do have a question. Why does the PE/COFF code have an extra step. The TE images are converted PE/COFF images so would not you need this code in both places? Is there some other

Re: [edk2] TianoCore-docs GitBook Documentation Process

On 07/10/17 18:43, Kinney, Michael D wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Saturday, July 8, 2017 2:36 PM >> To: Kinney, Michael D >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] TianoCore-docs GitBook

[edk2] Coding Style Line Length

Laszlo, Are there any special considerations for Print() statements with respect to the 80 character line length? If "No", what is the preferred format if one wants to print strings that are 80 or more characters such as: Print(L"123456789 123456789 123456789 123456789 123456789 123456789

[edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

The "one argument per line" style as the sole possibility takes up too much vertical space, wastes perfectly good horizontal space, and causes a constant jump-to-the-left eye movement for the reader. Now that we have limited the line length to 80 colums, the "condensed arguments" style cannot be

[edk2] [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related to line wrapping

We've discussed these ideas repeatedly over time; I'm now attempting to formalize them. Also test-driving the documentation contribution process. - Repo: https://github.com/lersek/edk2-CCodingStandardsSpecification.git - Branch: line_wrapping - Rendered views of the pages modified: -

Re: [edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

Hi Yonghong, The tab characters in the makefile are required. The makefile does not run in all environments if they are replaced with spaces. The makefiles generated by build also use tabs. Mike > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, August 10, 2017 10:41 PM >

[edk2] [edk2-staging/edk2-test Patch] TestFrameworkPkg: Replace POSTBUILD batch file with python script

Update the POSTBUILD step that creates the installer for the test framework to use a python script. This expands the OS compatibility to include Windows, Linux, and Mac OS X. Cc: Andrew Fish Cc: Supreeth Venkatesh Contributed-under: TianoCore

[edk2] [PATCH 0/2] DP: Init CustomCumulativeData.MinDur

Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur displayed for custom cumulative data will be always 0, but not the real shortest duration. Cc: Liming Gao Cc: Ruiyu Ni Cc: Cinnamon Shia Star Zeng (2):

[edk2] [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur

Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur displayed for custom cumulative data will be always 0, but not the real shortest duration. Cc: Liming Gao Cc: Ruiyu Ni Cc: Cinnamon Shia Contributed-under:

[edk2] [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur

Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur displayed for custom cumulative data will be always 0, but not the real shortest duration. Cc: Liming Gao Cc: Cinnamon Shia Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch v2] NetworkPkg/HttpDxe: Handle the HttpVersionUnsupported in the HttpConfigData

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Friday, August 11, 2017 9:13 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Jin, Eric ; Wu, Jiaxin Subject: [Patch v2] NetworkPkg/HttpDxe:

[edk2] What Bios data is sent to the Bootloader/OS ?

Hi everyone I have a question that probably some guys here can help. The scenario I have, is that I need to create a OS image that must be able to boot at a UEFI system (with no csm module), and at a legacy bios system. My fist thought is that this is not possible. The first thing I see that is

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

On 11 August 2017 at 01:34, Laszlo Ersek wrote: > Several users have recently reported boot failures with OVMF. The symptoms > are: blank screen and all VCPUs pegged at 100%. Alex Williamson has found > the commit (via bisection) that exposes the issue. In this patch I'll >

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

On 08/11/17 12:03, Ard Biesheuvel wrote: > On 11 August 2017 at 01:34, Laszlo Ersek wrote: >> (2) Unfortunately, the C-language assignment to >> "MP_CPU_EXCHANGE_INFO.InitializeFloatingPointUnitsAddress" is >> miscompiled under the following circumstances: >> >> -

Re: [edk2] OVMF compile error

On 08/11/17 04:46, Chen, Farrah wrote: > Hi, > > When I build ovmf with commit: 76c6f69ccadc7835c9616b077d9ff1b8e46fe49e, the > following error occurred: > > git clone https://github.com/tianocore/edk2.git > cd edk2 > OvmfPkg/build.sh -a X64 > >

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

Hi Steven, On 08/11/17 07:28, Shi, Steven wrote: > Hi Laszlo, > > I'm trying to reproduce your boot failure with OVMF in my Ubuntu > system, but not succeed. My GCC was built from GCC main trunk code > in 20170601, and my ld linker is version 2.28. Could you try the ld > 2.28 with your gcc-7.1

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

Laszlo, I actually prefer the one arg per line in the call to match the function prototype that requires one arg per line. Since most of the code follows this one arg per line convention today, I would not be in favor of a non-backwards compatible change to the coding style. Either leave it

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

On 2017-08-11 09:48:50, Laszlo Ersek wrote: > We currently say "stick with 80 if it's convenient, extend to 120 > otherwise". This is too lax; much new edk2 code ignores the 80 columns > recommendation, resulting in source files that are hard to read for some > contributors. Remove the 120 columns

Re: [edk2] Coding Style Line Length

Jim, C has some flexibility here. Multiple "" strings without commas are concatenated as if they were one string. Print( L"123456789 123456789 123456789 123456789 " L"123456789 123456789 123456789 123456789\n" ); Mike > -Original Message- > From: edk2-devel

Re: [edk2] What Bios data is sent to the Bootloader/OS ?

> On Aug 11, 2017, at 6:00 AM, Rafael Machado > wrote: > > Hi everyone > > I have a question that probably some guys here can help. > The scenario I have, is that I need to create a OS image that must be able > to boot at a UEFI system (with no csm module),

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

On Fri, 11 Aug 2017 02:34:26 +0200 Laszlo Ersek wrote: > Cc: Alex Williamson > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Liming Gao > Cc: Michael Kinney

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

On 08/09/2017 12:56 PM, Laszlo Ersek wrote: Sure, I will make the necessary changes in VirtioMmioDeviceLib and try do the build test but I don't have aarch64 platform to verify at the runtime. Actually, dependent on your GNU/Linux distribution, it is pretty easy to do on x86_64 too. It

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

> On Aug 11, 2017, at 1:45 PM, Jordan Justen wrote: > > On 2017-08-11 09:48:51, Laszlo Ersek wrote: >> The "one argument per line" style as the sole possibility takes up too >> much vertical space, wastes perfectly good horizontal space, and causes a >> constant

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

On 2017-08-11 09:48:51, Laszlo Ersek wrote: > The "one argument per line" style as the sole possibility takes up too > much vertical space, wastes perfectly good horizontal space, and causes a > constant jump-to-the-left eye movement for the reader. > > Now that we have limited the line length to

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / General Rules: limit line lengths to 80 columns

On 11 August 2017 at 17:48, Laszlo Ersek wrote: > We currently say "stick with 80 if it's convenient, extend to 120 > otherwise". It doesn't say that. It says you can make an exception for postfix comments, which is not unreasonable imo. This means most of the code in

Re: [edk2] search plugin for the TianoCore Bugzilla

Hi Laszlo, This was a good suggestion. The TianoCore Bugzilla server has been updated. Let us know if this works as expected now. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, July 24, 2017 5:52 AM > To: Kinney, Michael D

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments

On 2017-08-11 14:04:21, Kinney, Michael D wrote: > Laszlo, > > I actually prefer the one arg per line in the call > to match the function prototype that requires one > arg per line. One per line on prototypes seems reasonable. When it come to calling, there are potentially many calls per

Re: [edk2] What Bios data is sent to the Bootloader/OS ?

On Aug 11, 2017, at 6:00 AM, Rafael Machado wrote: >> >> Hi everyone >> >> I have a question that probably some guys here can help. >> The scenario I have, is that I need to create a OS image that must be able >> to boot at a UEFI system (with no csm module),

Re: [edk2] [PATCH 1/1] BaseTools/tools_def.template: revert to large code model for X64/GCC5/LTO

OK. I can reproduce the failure with -smp 4 and -m 5120 in my side. It looks a linker bug about assemble function support in PIC/PIE code. You know, if we only have C code, the compiler/linker will generate all the machine code and guarantee all the address reference are position independent

Re: [edk2] [RFC Patch 3/3] BaseTools/Scripts: Add sample makefile for use with RunMakefile.py

Got you. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Saturday, August 12, 2017 12:33 AM To: Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming

Re: [edk2] [Patch] BaseTools: Support TabSpace between section tag in DEC file

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, August 11, 2017 10:51 AM To: edk2-devel@lists.01.org Cc: Gao, Liming

[edk2] [PATCH V2 0/2] Improve IntelVTd performance.

=== V2 = I found CacheLineFlush() is already defined in CacheMaintenanceLib. Drop the CpuLib update, but use in CacheMaintenanceLib directly. === V1 = This series patch replace WBINVD with CLFlush in IntelVTdDxe driver, which improves boot performance.

[edk2] [PATCH V2 2/2] IntelSiliconPkg/IntelVTdDxe: Improve performance.

This patch is to improve IOMMU performance. All WBINVD is removed due to performance issue. CLFLUSH is used to to only flush the context table or second level page table if they are changed. This patch also removed some unused functions. Cc: Star Zeng Contributed-under:

[edk2] [PATCH V2 1/2] IntelSiliconPkg/dsc: Add CacheMaintenanceLib.

It will be used by IntelVTdDxe. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/IntelSiliconPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [PATCH 4/4] IntelSiliconPkg/IntelVTdDxe: Improve performance.

This patch is to improve IOMMU performance. All WBINVD is removed due to performance issue. CLFLUSH is used to to only flush the context table or second level page table if they are changed. This patch also removed some unused functions. Cc: Star Zeng Contributed-under:

[edk2] [PATCH 0/4] Improve IntelVTd performance.

This series patch replace WBINVD with CLFlush in IntelVTdDxe driver, which improves boot performance. This patch is validated on Intel Kabylake generation. Jiewen Yao (4): MdePkg/CpuLib.h: Add CacheLineFlush function. MdePkg/BaseCpuLib: Add CacheLineFlush function. IntelSiliconPkg/dsc: Add

[edk2] [PATCH 2/4] MdePkg/BaseCpuLib: Add CacheLineFlush function.

This function will be used by IntelVTd driver. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 5 ++-

[edk2] [PATCH 1/4] MdePkg/CpuLib.h: Add CacheLineFlush function.

This function will be used by IntelVTd driver. Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdePkg/Include/Library/CpuLib.h | 12 +++- 1 file changed,

[edk2] [PATCH 3/4] IntelSiliconPkg/dsc: Add CpuLib.

It will be used by IntelVTdDxe. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- IntelSiliconPkg/IntelSiliconPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [edk2] [PATCH 0/4] Improve IntelVTd performance.

Sorry for the confusing. I just sent V2 patch series. Please ignore this one. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen > Yao > Sent: Friday, August 11, 2017 10:10 PM > To: edk2-devel@lists.01.org > Subject: