Re: [edk2] [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming

Hi Ard, 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel : > Hi Marcin, > > On 7 December 2017 at 19:20, Marcin Wojtas wrote: >> 'PciEmulation' is not a proper naming for a driver, which >> uses NonDiscoverableDeviceRegistrationLib for handling >> the

[edk2] [PATCH] SecurityPkg:Tcg2Smm:Enabling TPM SIRQ interrupt support

1. Report TPM SIRQ interrupt resource through _CRS 2. Expose _SRS to update interrupt resource & FIFO/TIS interrupt related registers defined in TCG PC Client Platform TPM Profile (PTP) Specification spec

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: SMM profile and static paging mutual exclusion

Thanks and the RB to Laszlo and Eric. And I agree and will handle them when pushing the patch. :) Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, December 7, 2017 7:32 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc:

[edk2] [PATCH v4 2/2] MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden

Invoke the newly introduced SD/MMC override protocol to override the capabilities register after reading it from the device registers, and to call the pre/post host init and reset hooks at the appropriate times. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v4 1/2] MdeModulePkg: introduce SD/MMC override protocol

Many ARM based SoCs have integrated SDHCI controllers, and often, these implementations deviate in subtle ways from the pertinent specifications. On the one hand, these deviations are quite easy to work around, but on the other hand, having a collection of SoC specific workarounds in the generic

[edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

Many SDHCI implementations exist that are almost spec complicant, and could be driven by the generic SD/MMC host controller driver except for some minimal necessary init time tweaks. Adding such tweaks to the generic driver is undesirable. On the other hand, forking the driver for every platform

Re: [edk2] [PATCH v2 2/3] BaseTools/tools_def CLANG38: add -Wno-unused-const-variable

Thank you! Reviewed-by: Shi Steven Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 7, 2017 5:29 PM > To: edk2-devel@lists.01.org

Re: [edk2] [Patch V2] BaseTools: Fix GenSec can't found the depex file

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Friday, December 8, 2017 12:00 AM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX ; Gao, Liming > Subject: [Patch V2] BaseTools: Fix GenSec

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

On Fri, Dec 08, 2017 at 12:39:30AM +, Wu, Jiaxin wrote: > Hi Gary, > > Agree to generate a formal patch. You can attach the reviewed-by tag at the > same time. > > Can you help to file one Bugzilla for this issue? No Problem. > > BTW, Do you need us commit the patch or by yourself? Yes,

Re: [edk2] [PATCH] MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA when no media presents

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, December 07, 2017 5:55 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wu, Hao A > Subject: [PATCH] MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA when no > media

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

Hi Gary, Agree to generate a formal patch. You can attach the reviewed-by tag at the same time. Can you help to file one Bugzilla for this issue? BTW, Do you need us commit the patch or by yourself? Thanks, Jiaxin > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] >

Re: [edk2] [PATCH] SecurityPkg:Tcg2Smm:Enabling TPM SIRQ interrupt support

Thanks. Would you please also provide the information on what platform and TPM chip we have validated? Reviewed-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, > Chao B > Sent: Friday,

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

> Because when the hardware watchdog times out, it triggers a hard system reset, > without any software interaction. Little more complexity around this piece of h/w e.g once watchdog is started it cannot be stopped. Most caller seems to set timeout of 5 mins and later stopping watchdog. But

[edk2] [Patch] BaseTools: Update BrotliCompress script to handle the different input format

After this update, BrotliCompress can support below styles. BrotliCompress -e InputFile -o OutputFile BrotliCompress -e -o OutputFile InputFile Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao ---

Re: [edk2] [PATCH v2 0/6] Add ARM support for VS2017

Pete: I get your point. I suggest to add it in VS2017 tool chain comment. To build XIP firmware image, /FILEALIGN:4096 are required. Now, SEC, PEI_CORE and PEIM module require it. Thanks Liming >-Original Message- >From: Pete Batard [mailto:p...@akeo.ie] >Sent: Thursday, December 07,

Re: [edk2] [RFC] MdePkg/Spi : Modify SPI Protocol strctures to make it more generic

Hi Pankaj Bansal, Current SPI header files follow PI 1.6 Spec, if you find any issue in PI spec, current process is to raise them to PIWG for discussion firstly, then PIWG will discuss the issue and decide whether update the spec, at last update the code if needed. Thanks, Dandan

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

Hi Jiaxin, We are still having our QA to finally verify the patches (including the ICMP error listener bug fix), so I will post the formal patch after regression test completes. Regards, Gary (Heyi Guo) On Fri, Dec 08, 2017 at 10:04:20AM +0800, Guo Heyi wrote: > On Fri, Dec 08, 2017 at

[edk2] [PATCH] MdeModulePkg DxeIpl: Move ClearFirst4KPage/IsNullDetectionEnabled definition

Move ClearFirst4KPage/IsNullDetectionEnabled definition from DxeIpl.h to VirtualMemory.h as they are implemented in VirtualMemory.c and only used in IA32/X64 ARCH. Cc: Jian J Wang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng

Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Move ClearFirst4KPage/IsNullDetectionEnabled definition

Looks good to me. Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Friday, December 08, 2017 11:03 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J > Subject: [PATCH] MdeModulePkg

Re: [edk2] [PATCH] SecurityPkg:Tcg2Smm:Enabling TPM SIRQ interrupt support

Hi Jiewen & All: We verified Infineon(TIS + LPC, TIS +SPI) & Nuvoton(CRB+SPI, FIFO +LPC) TPM2.0 chip on Intel Kabylake Platform. TPM can work well both in boot & OS phase. -Original Message- From: Yao, Jiewen Sent: Friday, December 8, 2017 9:22 AM To: Zhang, Chao B

[edk2] [PATCH v3 3/3] BaseTool/tools_def GCC5: enable optimization for ARM/AARCH64 DEBUG builds

Enable optimization for DEBUG builds, to make it more usable in terms of performance, and to give more coverage to the LTO builds. Also, some diagnostics are only enabled when optimization is enabled. NOOPT builds can now also be created, which will retain the behavior DEBUG builds had previously.

[edk2] [PATCH v3 2/3] BaseTools/tools_def CLANG38: add -Wno-unused-const-variable

Commit 8b6366f87584 ("BaseTools/GCC: set -Wno-unused-const-variable on RELEASE builds") suppresses warnings about unused constant variables in RELEASE builds when building with GCC, given that they break the build under our warnings-as-errors policy. Do the same for CLANG38. Ref:

[edk2] [PATCH v3 0/3] BaseTools/tools_def: GCC5/CLANG38 toolchain updates

Some toolchain updates for CLANG38 and GCC5: - introduce CLANG38+LTO for ARM and AARCH64 - disable a warning on CLANG38 - enable optimization for GCC5 DEBUG builds Ard Biesheuvel (3): BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM BaseTools/tools_def CLANG38: add

[edk2] [PATCH v3 1/3] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM

Extend the CLANG38 toolchain definition so it can be used for ARM and AARCH64 as well. Note that this requires llvm-ar and the LLVMgold.so linker plugin. In preparation of doing the same for GCC5, this toolchain version also departs from the custom of using -O0 for DEBUG builds, which makes them

Re: [edk2] [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver.

On 7 December 2017 at 20:21, Evan Lloyd wrote: > Hi Ard. > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: 05 December 2017 21:28 >> To: Evan Lloyd >> Cc: edk2-devel@lists.01.org; Matteo Carlini

Re: [edk2] [Patch] SignedCapsulePkg: Update EdkiiSystemCapsuleLib to check PCD value

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Tuesday, November 28, 2017 11:27 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch] SignedCapsulePkg: Update EdkiiSystemCapsuleLib to check PCD > value > > If PCD

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

On 7 December 2017 at 07:48, Liming Gao wrote: > From: Michael Kinney > > https://bugzilla.tianocore.org/show_bug.cgi?id=573 > https://bugzilla.tianocore.org/show_bug.cgi?id=796 > > The same issue is reported again by GCC. Resend this patch

Re: [edk2] [PATCH v4 00/11] Implement stack guard feature

I missed that part. I'll add it. Thanks. Regards, Jian > -Original Message- > From: Yao, Jiewen > Sent: Thursday, December 07, 2017 4:17 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH v4 00/11] Implement stack guard feature > >

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, December 07, 2017 3:48 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Wu, Hao A; Laszlo

[edk2] [RFC] MdePkg/Spi : Modify SPI Protocol strctures to make it more generic

Issue_1: Currenty SPI IO and SPI HC protocol strcture is not equipped to handle all type of SPI commands e.g. QuadIo Read Command (0xEBh) in spansion flash S25FS512S will not work. Cause: Currenty SPI protocol describes a SPI transaction as combination of data and address and command, which would

Re: [edk2] [PATCH 0/2] Follow PI spec to update EFI_MM_COMMUNICATE

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, December 6, 2017 5:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Gao, > Liming ; Kinney, Michael D >

Re: [edk2] [PATCH v2 1/3] IntelFrameworkPkg/LegacyBios.h: Add a macro to guarantee page 0 access

Thanks for the comment. The {} will be added. Sincerely, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, December 07, 2017 3:00 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D >

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

Hi Jiaxin, Thanks for your reply. You say "IcmpErrorRcvToken is only used to get ICMP error from IP layer", does that mean only ICMP error packets will go to IcmpErrorListenHandler? If it is the case, how do we make it? I can only find a simple Ip4->Receive is called to receive IP4

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

Hi Siyuan and Jiaxin, Thanks for your review; shall I generate a formal patch and post it again, as well as making some commit message refinement? Regards, Gary (Heyi Guo) 在 12/7/2017 3:01 PM, Wu, Jiaxin 写道: It's is good to me. Reviewed-by: Jiaxin Wu Thanks,

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Yonghong, I do not have the DSC that was used to build it. The FDF is https://github.com/tianocore/edk2-platforms/blob/master/Platform/Hisilicon/D05/D05.fdf#L250 Jason (cc) may be able to provide more information on the binary. Best Regards, Leif On Thu, Dec 07, 2017 at 12:55:48PM +,

[edk2] [RFC] Update EDKII Performance infrastructure based on ACPI FPDT table

From: "Gao, Liming" Current EDKII performance implementation bases on performance protocol to log and dump performance entry. There is no way to get the performance data in OS. ACPI FPDT table allows to insert the firmware extension record. If so, the detail boot

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

On 7 December 2017 at 14:19, Gao, Liming wrote: > Ard and Ersek: > On VS, static may make debug become hard. And, STATIC + > GLOBAL_REMOVE_IF_UNREFERENCED may failure on old VS before VS supports /Gw > option. So, I don't add static here. > I would like to separate

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

CoreSetWatchdogTimer() allows the error status for watchdog service. > -Original Message- > From: Udit Kumar [mailto:udit.ku...@nxp.com] > Sent: Thursday, December 7, 2017 7:15 PM > To: Gao, Liming ; Leif Lindholm > > Cc: Kinney, Michael D

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

Hi, I've compiled current HdLcd.c code with different optimisation levels for DEBUG build using GCC 7.2.1, and the assembler code below was generated for: ASSERT_EFI_ERROR (Status); if (EFI_ERROR( Status )) { return EFI_DEVICE_ERROR; } 1. -O0 (default DEBUG option for AARCH64

Re: [edk2] [PATCH 1/2] MdePkg MmCommunication.h: Follow PI spec to update EFI_MM_COMMUNICATE

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, December 6, 2017 5:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Gao, Liming ; Kinney,

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Ard and Ersek: On VS, static may make debug become hard. And, STATIC + GLOBAL_REMOVE_IF_UNREFERENCED may failure on old VS before VS supports /Gw option. So, I don't add static here. I would like to separate static usage topic. We could discuss more and summary the rule on how to use

Re: [edk2] [RFC] MdePkg/Spi : Modify SPI Protocol strctures to make it more generic

Adding MdePkg maintainers: Mike and Liming. Please always cc package maintainers (listed in Maintainers.txt). / Leif On Thu, Dec 07, 2017 at 02:05:19PM +0530, Pankaj Bansal wrote: > Issue_1: Currenty SPI IO and SPI HC protocol strcture is not equipped > to handle all type of SPI commands >

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Leif: I don't review the whole patch serial. Could you point your usage case on watch dog timer protocol? Thanks Liming > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, December 7, 2017 7:04 PM > To: Gao, Liming > Cc:

Re: [edk2] [PATCH v2 0/3] Adding secure boot and HTTP image download features for Linux based platform

yes Ard, but this is not platform sepecfic only application code, leif has given comments on this application , addressed his comments and send the patch. On 7 December 2017 at 19:36, Ard Biesheuvel wrote: > On 7 December 2017 at 13:34, kalyan-nagabhirava >

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

On 7 December 2017 at 14:55, Alexei Fedorov wrote: > Hi, > > I've compiled current HdLcd.c code with different optimisation levels for > DEBUG build using GCC 7.2.1, and the assembler code below was generated for: > > ASSERT_EFI_ERROR (Status); > if (EFI_ERROR( Status

[edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

ASSERT_EFI_ERROR () is currently defined as #if !defined(MDEPKG_NDEBUG) #define ASSERT_EFI_ERROR(StatusParameter) \ do { \ if (DebugAssertEnabled ())

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

On 7 December 2017 at 15:12, Ard Biesheuvel wrote: > ASSERT_EFI_ERROR () is currently defined as > > #if !defined(MDEPKG_NDEBUG) > #define ASSERT_EFI_ERROR(StatusParameter) > \ > do {

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Liming, https://www.mail-archive.com/edk2-devel@lists.01.org/msg32761.html Search for WdogRegisterHandler. This topic is entirely unrelated to any _usage_ of watchdog timer protocol. The topic is only whether it is reasonable to _implement_ EFI_WATCHDOG_TIMER_ARCH_PROTOCOL for a hardware

[edk2] [Patch] MdeModulePkg/NetLib: Fix an error when AIP doesn't support network media state detection

AIP may not support detecting network media state, in this case, should call NetLibDetectMedia to get media state. This patch is to fix this issue. Cc: Fu Siyuan Cc: Ye Ting Cc: Jiaxin Wu Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 4/4 V3] BaseTools: Update Makefile to support FFS file generation

Hi Leif, Please help to check whether this patch " [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file" can fix it. thanks a lot. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Thursday, December 07, 2017 9:00 AM To: Leif Lindholm

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

On 12/07/17 09:46, Ard Biesheuvel wrote: > On 7 December 2017 at 07:48, Liming Gao wrote: >> From: Michael Kinney >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=573 >> https://bugzilla.tianocore.org/show_bug.cgi?id=796 >> >> The same issue

Re: [edk2] [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM

On 7 December 2017 at 11:09, Laszlo Ersek wrote: > On 12/07/17 03:05, Shi, Steven wrote: >> Hi Ard, >> I'm OK for the patch. >> BTW, would you mind to help add the "-Wno-unused-const-variable" in the >> CLANG38_WARNING_OVERRIDES? I happen to need add it in CLANG38 >>

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Yonghong, This patch resolves the issue for the hikey platform, but not for (edk2-platforms/Platform/Hisilicon/)D03/D05. They fail with --- Generating FVMAIN FV ## #Return Value = 2 GenSec: ERROR 0001: Error opening file

[edk2] [PATCH] MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA when no media presents

Current code always return EFI_MEDIA_CHANGED no matter the media is removed from CD/DVD drive or the media is changed. It doesn't strictly follow the UEFI Spec. Update code to return EFI_NO_MEDIA when media is removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

> You say "IcmpErrorRcvToken is only used to get ICMP error from IP > layer", does that mean only ICMP error packets will go to > IcmpErrorListenHandler? > If it is the case, how do we make it? I can only find a simple > Ip4->Receive is called to receive IP4 packets; how are other types of > IP4

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Hi Liming, On Thu, Dec 07, 2017 at 07:11:38AM +, Gao, Liming wrote: > Leif: > I don't see the core driver uses > WatchdogTimer->RegisterHandler(). When it returns unsupported, it > means the additional handler can't be registered. DxeCore uses > WatchdogTimer->SetTimerPeriod(). This

Re: [edk2] [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM

On 12/07/17 03:05, Shi, Steven wrote: > Hi Ard, > I'm OK for the patch. > BTW, would you mind to help add the "-Wno-unused-const-variable" in the > CLANG38_WARNING_OVERRIDES? I happen to need add it in CLANG38 > (https://bugzilla.tianocore.org/show_bug.cgi?id=790) and I see it seems a > shared

[edk2] [PATCH v4 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

> v4: > a. Fix a calculation error in pool page number during initialization > b. Change comments to remove constants in description > v3: >Remove the public definition of PAGE_TABLE_POOL_HEADER but keep similar >concept locally. CpuDxe has its own page table pool. > v2: >Introduce

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: SMM profile and static paging mutual exclusion

Hi Star, On 12/07/17 11:47, Star Zeng wrote: > SMM profile and static paging could not enabled at the same time, > this patch is add check and comments to make sure it. > > Similar comments are also added for the case of static paging and > heap guard for SMM. > > Cc: Jiewen Yao

[edk2] [PATCH v4 0/2] Enable page table write protection

> v4 changes: >MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 22 ++--- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 2 +- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 25 +++- > UefiCpuPkg/CpuDxe/CpuPageTable.h | 2 +- > 4

Re: [edk2] [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__

On Thu, Dec 07, 2017 at 03:09:17AM +, Gao, Liming wrote: > Reviewed-by: Liming Gao Thanks! Pushed as 5b8766bb92. > >-Original Message- > >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > >Sent: Thursday, December 07, 2017 1:08 AM > >To:

[edk2] [PATCH v2 0/3] BaseTools/tools_def: GCC5/CLANG38 toolchain updates

Some toolchain updates for CLANG38 and GCC5: - introduce CLANG38+LTO for ARM and AARCH64 - disable a warning on CLANG38 - enable optimization for GCC5 DEBUG builds Ard Biesheuvel (3): BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM BaseTools/tools_def CLANG38: add

[edk2] [PATCH v2 2/3] BaseTools/tools_def CLANG38: add -Wno-unused-const-variable

Commit 8b6366f87584 ("BaseTools/GCC: set -Wno-unused-const-variable on RELEASE builds") suppresses warnings about unused constant variables in RELEASE builds when building with GCC, given that they break the build under our warnings-as-errors policy. Do the same for CLANG38. Ref:

[edk2] [PATCH v2 3/3] BaseTool/tools_def GCC5: enable optimization for ARM/AARCH64 DEBUG builds

Enable optimization for DEBUG builds, to make it more usable in terms of performance, and to give more coverage to the LTO builds. Also, some diagnostics are only enabled when optimization is enabled. NOOPT builds can now also be created, which will retain the behavior DEBUG builds had previously.

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only DumpCpuContext in error case

On 12/07/17 02:49, Star Zeng wrote: > Only DumpCpuContext in error case, otherwise there will be too many > debug messages from DumpCpuContext() when SmmProfile feature is enabled > by setting PcdCpuSmmProfileEnable to TRUE. Those debug messages are not > needed for SmmProfile feature as it will

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

On 7 December 2017 at 11:18, Laszlo Ersek wrote: > On 12/07/17 09:46, Ard Biesheuvel wrote: >> On 7 December 2017 at 07:48, Liming Gao wrote: >>> From: Michael Kinney >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=573

[edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: SMM profile and static paging mutual exclusion

SMM profile and static paging could not enabled at the same time, this patch is add check and comments to make sure it. Similar comments are also added for the case of static paging and heap guard for SMM. Cc: Jiewen Yao Cc: Eric Dong Cc: Ruiyu Ni

Re: [edk2] [Patch] MdeModulePkg/NetLib: Fix an error when AIP doesn't support network media state detection

Reviewed-by: Jiaxin Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > fanwang2 > Sent: Thursday, December 7, 2017 5:51 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wang, Fan

Re: [edk2] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: SMM profile and static paging mutual exclusion

Star, Reviewed-by: Eric Dong Below typo you can change when you push the code. + # It could not be enabled at the same time with SMM profile feature (PcdCpuSmmStaticPageTable). " SMM profile feature " should be "Static page table feature"? Thanks, Eric -Original

Re: [edk2] [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver

Hi Liming, > DxeCore uses WatchdogTimer->SetTimerPeriod(). This service is implemented in > your driver. Callers of SetTimerPeriod are ignoring error reported. Is they assume this call will be perfect or they are ok in case some error on watchdog service. Regards Udit > -Original

Re: [edk2] [PATCH v2 3/3] BaseTool/tools_def GCC5: enable optimization for ARM/AARCH64 DEBUG builds

On 12/07/17 10:28, Ard Biesheuvel wrote: > Enable optimization for DEBUG builds, to make it more usable in terms of > performance, and to give more coverage to the LTO builds. Also, some > diagnostics are only enabled when optimization is enabled. > NOOPT builds can now also be created, which will

Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

在 12/7/2017 6:40 PM, Wu, Jiaxin 写道: You say "IcmpErrorRcvToken is only used to get ICMP error from IP layer", does that mean only ICMP error packets will go to IcmpErrorListenHandler? If it is the case, how do we make it? I can only find a simple Ip4->Receive is called to receive IP4 packets;

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Leif, May I know how this binary driver is described in DSC file and FDF file, and the [Rule.Common.DXE_DRIVER.BINARY] section ? I tried to add this driver into OvmfPkg, but failed to reproduce this failure. Thanks. Best Regards, Zhu Yonghong -Original Message- From: Leif Lindholm

[edk2] [PATCH v2 0/3] Adding secure boot and HTTP image download features for Linux based platform

Linaro and RDK are working on standardizing the boot process for RDK STB boxes using Uefi. Added applications are reference implementation of RDK STB boot process on Arm platforms kalyan-nagabhirava (3): [edk2 EmbeddedPkg]:Implementation of secure boot and HTTP Image download

[edk2] [PATCH v2 2/3] EmbeddedPkg: secureboot application using RdkBootManagerLib

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: kalyan-nagabhirava --- EmbeddedPkg/Application/SecureBoot/SecureBoot.inf | 57 EmbeddedPkg/Application/SecureBoot/SecureBoot.c | 30 +++ 2 files changed, 87

[edk2] [PATCH v2 3/3] EmbeddedPkg: Httpimage downlaod application

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: kalyan-nagabhirava --- EmbeddedPkg/Application/Dri/Dri.inf | 56 EmbeddedPkg/Application/Dri/Dri.c | 26 + 2 files changed, 82 insertions(+) diff --git

Re: [edk2] [PATCH edk2-platforms v2] Silicon/SynQuacer: enable coherent DMA for NETSEC and eMMC

On 1 December 2017 at 17:53, Ard Biesheuvel wrote: > On 1 December 2017 at 12:57, Leif Lindholm wrote: >> On Thu, Nov 30, 2017 at 06:53:55PM +, Ard Biesheuvel wrote: >>> As it turns out, it is surprisingly easy to configure both the NETSEC

Re: [edk2] [PATCH v2 0/3] Adding secure boot and HTTP image download features for Linux based platform

On 7 December 2017 at 13:34, kalyan-nagabhirava wrote: > Linaro and RDK are working on standardizing the boot process for RDK STB > boxes using Uefi. > Added applications are reference implementation of RDK STB boot process on > Arm platforms > Please

Re: [edk2] [PATCH] BaseTools: Fix GenSec can't found the depex file

Hi Leif, I just sent out V2 patch. thanks. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Thursday, December 07, 2017 10:42 PM To: 'Leif Lindholm' Cc: edk2-devel@lists.01.org; Feng, YunhuaX ; Gao, Liming

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

Ard, With link time optimization, the current order produces smaller code. Without link time optimization, your patch will produce smaller code, but not as small as link time optimized code. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On

[edk2] [Patch V2] BaseTools: Fix GenSec can't found the depex file

From: Yunhua Feng Filter the FileList when multiple genfds thread options is not enabled. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

Ard, The reason for the current ordering is for size optimization. The most common implementation of DebugAssertEnabled() uses a FixedAtBuild PCD to determine if these are enabled. The check of status can be optimized away if they are disabled. If you reverse them, then the status check is

Re: [edk2] [platforms: PATCH 0/5] Armada 7k/8k files reorganization

On 7 December 2017 at 16:31, Marcin Wojtas wrote: > Hi, > > I submit a long awaited file reorganization of Marvell Armada 7k/8k > SoC family support. Armada 70x0 DB files remained in > 'Platform/Marvell', SoC files, drivers, libraries, etc. were > shifted to 'Silicon/Marvell'.

Re: [edk2] [Patch V2] BaseTools: Fix GenSec can't found the depex file

Thanks - with this patch all of my platforms build again. On Thu, Dec 07, 2017 at 11:59:44PM +0800, Yonghong Zhu wrote: > From: Yunhua Feng > > Filter the FileList when multiple genfds thread options is not enabled. > > Cc: Liming Gao >

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

On 7 December 2017 at 17:01, Kinney, Michael D wrote: > Ard, > > The reason for the current ordering is for size optimization. > > The most common implementation of DebugAssertEnabled() uses > a FixedAtBuild PCD to determine if these are enabled. The > check of status

Re: [edk2] [PATCH v2 0/6] Add ARM support for VS2017

Hi Liming, On 2017.12.07 03:02, Gao, Liming wrote: This is the base step to enable VS2017 ARM tool chain. Then, user could use it and build ARM application first. Yes. Here, I have one question. VS2017 ARM requires 4096 alignment. So, why not add /FILEALIGN:4096 into tools_def.txt

[edk2] [platforms: PATCH 3/5] Marvell/Armada70x0Db: Rename fd file

Hitherto fd file name was pretty generic, so use one, which reflects actual board model. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [platforms: PATCH 4/5] Marvell/Drivers: Rename SPI master driver

Hitherto driver name was very generic. In order to be ready for adding new SPI master drivers, use the controller's traditional name (it's called SPI Orion in linux and U-Boot) for files and the entry point. Additionally, move the files to new 'Controllers' directory, which is paralel to existing

[edk2] [platforms: PATCH 2/5] Marvell/Armada7k8k: Use '7k8k' prefix in the SoC drivers/libraries

As a part of files reorganization, switch to using '7k8k' in all SoC-specific driver/library code instead of '70x0'/'7040', so that to ensure consistent naming for entire SoC family. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 0/5] Armada 7k/8k files reorganization

Hi, I submit a long awaited file reorganization of Marvell Armada 7k/8k SoC family support. Armada 70x0 DB files remained in 'Platform/Marvell', SoC files, drivers, libraries, etc. were shifted to 'Silicon/Marvell'. Although there are no functional changes, other most significant modifications

[edk2] [platforms: PATCH 5/5] Marvell/Drivers: Drop 'PciEmulation' naming

'PciEmulation' is not a proper naming for a driver, which uses NonDiscoverableDeviceRegistrationLib for handling the devices attached via internal bus of the SoC. Rename it to MvNonDiscoverableDxe and move under Silicon/Marvell/Drivers directory. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

Ard, If the variable was not prepended with GLOBAL_REMOVE_IF_UNREFERENCED, I would agree. GLOBAL_REMOVE_IF_UNREFERENCED for some compilers is not compatible with static. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Ard Biesheuvel

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

As expected with new ASSERT_EFI_ERROR () definition compiler generates 1 conditional branch at the start: // r:\edk2\ArmPlatformPkg\Drivers\LcdGraphicsOutputDxe\HdLcd.c:79: ASSERT_EFI_ERROR (Status); .loc 1 79 0 tbzx0, #63, .L4// Status,

[edk2] [PATCH v2] BaseTools: align ERROR/WARNING/RETURN macros with MdePkg versions

BaseTools' BaseTypes.h defined the ENCODE_ERROR macro as #define ENCODE_ERROR(a) ((RETURN_STATUS)(MAX_BIT | (a))) whereas MdePkg defines it as #define ENCODE_ERROR(StatusCode) ((RETURN_STATUS)(MAX_BIT | (StatusCode))) When building with GCC 6.3 (at least) the former triggers

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

On 7 December 2017 at 17:36, Kinney, Michael D wrote: > Ard, > > With link time optimization, the current order produces > smaller code. > I don't think it does. You are essentially saying that DebugAssertEnabled() may resolve to a link time constant FALSE under LTO.

Re: [edk2] [platforms: PATCH 0/5] Armada 7k/8k files reorganization

On 7 December 2017 at 19:06, Marcin Wojtas wrote: > Hi Ard, > > 2017-12-07 17:48 GMT+01:00 Ard Biesheuvel : >> On 7 December 2017 at 16:31, Marcin Wojtas wrote: >>> Hi, >>> >>> I submit a long awaited file reorganization of Marvell

Re: [edk2] [platforms: PATCH 0/5] Armada 7k/8k files reorganization

2017-12-07 20:07 GMT+01:00 Ard Biesheuvel : > On 7 December 2017 at 19:06, Marcin Wojtas wrote: >> Hi Ard, >> >> 2017-12-07 17:48 GMT+01:00 Ard Biesheuvel : >>> On 7 December 2017 at 16:31, Marcin Wojtas

Re: [edk2] [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming

Hi Marcin, On 7 December 2017 at 19:20, Marcin Wojtas wrote: > 'PciEmulation' is not a proper naming for a driver, which > uses NonDiscoverableDeviceRegistrationLib for handling > the devices attached via internal bus of the SoC. > Rename it to MvNonDiscoverableDxe and move

Re: [edk2] [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR

Ard, I do not disagree with your logic. The current algorithm is based on data from a long time ago using what are now very old tool chains. I will do some experiments on the currently supported toolchains to see if the optimization is the same either way. I think the change you are suggesting

Re: [edk2] [platforms: PATCH 0/5] Armada 7k/8k files reorganization

Hi Ard, 2017-12-07 17:48 GMT+01:00 Ard Biesheuvel : > On 7 December 2017 at 16:31, Marcin Wojtas wrote: >> Hi, >> >> I submit a long awaited file reorganization of Marvell Armada 7k/8k >> SoC family support. Armada 70x0 DB files remained in >>

  1   2   >