[edk2] [PATCH v2 2/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib

2018-06-04 Thread Ruiyu Ni
Current DxeResetSystemLib depends on UefiRuntimeLib because it calls EfiResetSystem() API exposed by UefiRuntimeLib. Due to the commit: "MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver" which reverts UefiRuntimeLib to only support DXE_RUNTIME_DRIVER, removing UefiRuntimeLib

[edk2] [PATCH v2 3/3] MdeModulePkg: Make sure ResetSystemRuntimeDxe uses ResetSystemLibNull

2018-06-04 Thread Ruiyu Ni
Because the DxeResetSystemLib calls gRT->ResetSystem(), make sure the gRT->ResetSystem() implementation doesn't call into DxeResetSystemLib to avoid chicken-egg issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Liming Gao ---

[edk2] [PATCH v2 1/3] MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver

2018-06-04 Thread Ruiyu Ni
When UefiRuntimeLib links to a DXE driver, its constructor still registers a Virtual Address Change event. The event callback will get called when RT.SetVirtualAddressMap() is called from OS. But when the driver is a DXE driver, the memory occupied by the callback function might be zeroed or used

[edk2] [PATCH v2 0/3] Fix bugs in core ResetSystem software stack

2018-06-04 Thread Ruiyu Ni
v2: Fix the comments in 2/3 to solve Laszlo's concern. Change DxeResetSystemLib to disallow to be linked by runtime/smm drivers. Ruiyu Ni (3): MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib

Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

2018-06-04 Thread Zeng, Star
With update, Reviewed-by: Star Zeng . -Original Message- From: Gao, Liming Sent: Monday, June 4, 2018 2:39 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol Good catch. I will

Re: [edk2] [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Ni, Ruiyu
Ok. I will update the comments. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, June 4, 2018 2:30 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol > definition > > I see below

Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

2018-06-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Gao, Liming > Sent: Tuesday, May 29, 2018 1:54 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [Patch] MdeModulePkg BootManagerMenuApp: Update usage info > for BootLogo protocol > > BootLogo protocol is not

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Wu, Hao A
Hi Ray, Some comments: 1. Please help to add the 'EFI_' prefix for the new definitions added in .h files. 2. Do we need to handle the case when AhciEnableDevSlp() returns with an error? 3. Please help to adjust the debug level for the below line within function AhciEnableDevSlp(): DEBUG

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Wu, Hao A
> -Original Message- > From: Ni, Ruiyu > Sent: Monday, June 04, 2018 2:37 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Chiu, Chasel > Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: > Enable/disable DEVSLP per policy > > Hao, > Thanks for the comments. > Reply in below. >

Re: [edk2] [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Zeng, Star
I see below definition for PuisEnable. + /// others: Since PUIS setting is non-volatile, platform can use other value than 0/1 to keep hardware PUIS setting. + /// + UINT8 PuisEnable; What will the code do for DeviceSleepEnable and AggressiveDeviceSleepEnable when their value is other

Re: [edk2] [PATCH v2 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, June 04, 2018 3:04 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [PATCH v2 4/4]

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Ni, Ruiyu
Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Monday, June 4, 2018 2:45 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel > Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: > Enable/disable DEVSLP per policy > > > -Original Message- > >

[edk2] [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Ruiyu Ni
The patch adds AtaAtapiPolicy protocol which is produced by platform and consumed by AtaAtapiPassThruDxe driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h | 59 ++

[edk2] [PATCH v2 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Chasel Chiu Cc: Hao A Wu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 214 +++ MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 23 ++- 2 files changed, 235 insertions(+), 2

[edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Chasel Chiu --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 48 ++ .../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c| 19 -

[edk2] [PATCH v2 1/4] MdeModulePkg/AtaAtapiPassThru: Spin up Power up in Standby devices

2018-06-04 Thread Ruiyu Ni
The patch adds support to certain devices that support PUIS (Power up in Standby). For those devices that supports SET_FEATURE spin up, SW needs to send SET_FEATURE subcommand to spin up the devices. For those devices that doesn't support SET_FEATURE spin up, SW needs to send read sectors command

[edk2] [PATCH v2 0/4] Support PUIS and DEVSLP feature

2018-06-04 Thread Ruiyu Ni
v2: Make sure whole code changes pass ECC check. 1/4: Remove unneeded comments. 2/4: Add comments to describe how to deal the value other than 0 and 1. 4/4: ECC fix. Change AhciEnableDevSlp() to return when "DeviceSleepEnable != 1" instead of "DeviceSleepEnable == 0". Ruiyu Ni (4):

Re: [edk2] [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: Enable/disable DEVSLP per policy

2018-06-04 Thread Ni, Ruiyu
Hao, Thanks for the comments. Reply in below. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Monday, June 4, 2018 2:21 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel > Subject: RE: [PATCH 4/4] MdeModulePkg/Ata/AtaAtapiPassThru: > Enable/disable DEVSLP per

Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

2018-06-04 Thread Zeng, Star
Liming, Should " If it is installed " be " If it is not installed " in the commit message? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, May 29, 2018 1:54 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update usage info for BootLogo protocol

2018-06-04 Thread Gao, Liming
Good catch. I will update the commit message. >-Original Message- >From: Zeng, Star >Sent: Monday, June 04, 2018 2:37 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Zeng, Star >Subject: RE: [edk2] [Patch] MdeModulePkg BootManagerMenuApp: Update >usage info for BootLogo

Re: [edk2] [PATCH v2] Formalize source files to follow DOS format

2018-06-04 Thread Gao, Liming
Dongao: I just meet with the case that is not expected to be modified, such as the third party openssl code in CryptoPkg. So, I suggest to add one option to describe the exception direction name or file name. Thanks Liming >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH edk2-platforms v1] Platform/ARM: Declare FVP Generic Timer Frame #1 as Non-secure

2018-06-04 Thread Thomas Abraham
On Fri, Jun 1, 2018 at 3:04 AM, Leif Lindholm wrote: > On Wed, May 23, 2018 at 02:51:34PM +0100, AlexeiFedorov wrote: >> From: Alexei Fedorov >> >> Programming Reference for Base FVPs describes 2 Generic Memory-mapped >> Timer frames with Non-secure access permitted to frame #1. >> However ACPI

Re: [edk2] [platforms PATCH v2 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
Hi Leif, 2018-06-04 12:08 GMT+02:00 Leif Lindholm : > > On Mon, Jun 04, 2018 at 07:29:35AM +0200, Marcin Wojtas wrote: > > All required components are in place, so we can now > > add all necessary dependencies to build and use capsule support > > for Armada7k8k platforms. It is conditionally

Re: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table

2018-06-04 Thread Ye, Ting
Hi Siva, Per design, the iSCSI multipath I/O will publish all configured attempts to IBFT, no matter the connection is success or fail currently. Did you enable the MPIO when you configure the attempts? I am not clear what do you mean "aborted attempt". Thanks, Ting -Original

[edk2] [PATCH 1/2] MdePkg UefiLib: Fix in EfiLocateProtocolBuffer()

2018-06-04 Thread Star Zeng
Free HandleBuffer for error path in EfiLocateProtocolBuffer(). Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdePkg/Library/UefiLib/UefiLib.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH 2/2] IntelFrameworkPkg FrameworkUefiLib: Fix in EfiLocateProtocolBuffer()

2018-06-04 Thread Star Zeng
Free HandleBuffer for error path in EfiLocateProtocolBuffer(). Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH v3] EmbeddedPkg/TimeBaseLib: Add function to get Week day.

2018-06-04 Thread Meenakshi Aggarwal
This patch add function EfiTimeToWday() which returns day of the week. It is needed by our upcoming patches in edk2-platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vabhav Sharma Signed-off-by: Meenakshi Aggarwal --- EmbeddedPkg/Include/Library/TimeBaseLib.h

Re: [edk2] [PATCH edk2-platforms 22/39] Platform/NXP: LS1046 RDB Board FPGA library

2018-06-04 Thread Leif Lindholm
On Mon, Jun 04, 2018 at 04:10:16AM +, Meenakshi Aggarwal wrote: > Hi Leif, > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Thursday, April 19, 2018 8:14 PM > > To: Meenakshi Aggarwal > > Cc: ard.biesheu...@linaro.org;

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
2018-06-04 19:46 GMT+02:00 Leif Lindholm : > On Mon, Jun 04, 2018 at 07:11:45PM +0200, Marcin Wojtas wrote: >> All required components are in place, so we can now >> add all necessary dependencies to build and use capsule support >> for Armada7k8k platforms. It is conditionally enabled >> with '-D

Re: [edk2] [Patch 1/5] Build Spec: Add !error statement support

2018-06-04 Thread Kinney, Michael D
Yonghong, I think it should be stated that the build tool also returns an error code. This allows scripts that invoke build to check the returned error code. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Yonghong Zhu > Sent:

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Ard Biesheuvel
On 4 June 2018 at 21:08, Leif Lindholm wrote: > On Mon, Jun 04, 2018 at 08:53:53PM +0200, Marcin Wojtas wrote: >> 2018-06-04 19:46 GMT+02:00 Leif Lindholm : >> >> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.fdf >> >> b/Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.fdf >> >> new file

Re: [edk2] [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances

2018-06-04 Thread Kinney, Michael D
Ard, There are a number of conditions that DisplayUpdateProgressLibGraphics will not display a Progress bar. * No GOP * No EDK II Boot Logo 2 Protocol * The EDK II Boot Logo 2 Protocol GetBootLogo() service does not return a logo If capsules are processed when only a text console is present,

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
2018-06-04 19:38 GMT+02:00 Leif Lindholm : > On Mon, Jun 04, 2018 at 06:58:25PM +0200, Marcin Wojtas wrote: >> Ard, >> >> 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : >> > On 4 June 2018 at 18:41, Marcin Wojtas wrote: >> >> All required components are in place, so we can now >> >> add all

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Leif Lindholm
On Mon, Jun 04, 2018 at 08:53:53PM +0200, Marcin Wojtas wrote: > 2018-06-04 19:46 GMT+02:00 Leif Lindholm : > >> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.fdf > >> b/Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.fdf > >> new file mode 100644 > >> index 000..3fe165f > >> ---

Re: [edk2] [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-06-04 Thread Supreeth Venkatesh
Liming, Thanks for the feedback. I have sent v3 of this patch. Sorry for the delay, I was waiting for feedback on other patches in the patch set. Thanks, Supreeth -Original Message- From: Gao, Liming Sent: Monday, May 7, 2018 10:11 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.org

[edk2] [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-06-04 Thread Supreeth Venkatesh
This patch corrects the Module Type Header file for Management Mode(MM) as specified in PI v1.6 Specification. Also, it updates parameter for auto generated template functions from EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [PATCH 0/2] UefiLib: Free HandleBuffer for error path in EfiLocateProtocolBuffer().

2018-06-04 Thread Kinney, Michael D
Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Zeng, Star > Sent: Monday, June 4, 2018 3:11 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Gao, Liming > > Subject: [PATCH 0/2] UefiLib: Free HandleBuffer for > error path in

[edk2] [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library.

2018-06-04 Thread Supreeth Venkatesh
The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms and is initialised during the SEC phase. ARM Trusted firmware in EL3 is responsible for initialising the architectural context for S-EL0 and loading the Standalone MM image. The memory allocated to this image is

[edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

2018-06-04 Thread Supreeth Venkatesh
*** This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2. The patches are [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file. [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library. [PATCH v3 17/17]

[edk2] [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.

2018-06-04 Thread Supreeth Venkatesh
This patch deletes "StandaloneMmPkg" which was created as a file intially. This patch enables creation of "StandaloneMmPkg" as a folder. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh Reviewed-by: Achin Gupta Reviewed-by: Jiewen Yao ---

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Fix invalid NV data issue.

2018-06-04 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Nickle Wang [mailto:nickle.w...@hpe.com] Sent: Tuesday, May 29, 2018 8:08 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B ; Yao, Jiewen ; Nickle Wang ; cinnamon shia Subject: [PATCH] SecurityPkg/SecureBootConfigDxe: Fix invalid NV data

[edk2] [PATCH v1 1/1] BaseTools: Refactoring to save time

2018-06-04 Thread Jaben Carsey
when not needed, change from our custom TemplateString class to a simple list of strings. this is the .Append->.append changes and "".join() changes. this parimary affects variables named AutoGenC and AutoGenH change GenMake dependency searching to not double search. remove unused sdict class

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Jim.Dailey
>Thanks/Ray > >> From: jim.dai...@dell.com >> >> I guess this is a question of UEFI spec interpretation. In the Console >> I/O Protocol description of Version 2.5 of the spec (page 456), it says: >> >> If the Scan Code is set to 0x00 then the Unicode character is >> valid and should

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Andrew Fish
Jim, The big picture difference is the original SimpleTextIn was the least common denominator with a serial terminal. The Ex version added more info about keyboards, so richer info on modifier keys. Thanks, Andrew Fish > On Jun 4, 2018, at 7:46 AM, jim.dai...@dell.com wrote: > > >>

[edk2] [PATCH] ArmVirtPkg/ArmVirtQemu ARM: work around KVM limitations in LTO build

2018-06-04 Thread Ard Biesheuvel
KVM on ARM refuses to decode load/store instructions used to perform I/O to emulated devices, and instead relies on the exception syndrome information to describe the operand register, access size, etc. This is only possible for instructions that have a single input/output register (as opposed to

Re: [edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-06-04 Thread Yao, Jiewen
Looks good. Can we add "Is" before the function - LowestSupportedVersionCheckRequired (), LockFmpDeviceAtLockEventGuidRequired () ? That is IsLowestSupportedVersionCheckRequired (), IsLockFmpDeviceAtLockEventGuidRequired (). Thank you Yao Jiewen > -Original Message- > From: Kinney,

Re: [edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-06-04 Thread Kinney, Michael D
Jiewen, Good suggestion. I will add then in next version. Mike > -Original Message- > From: Yao, Jiewen > Sent: Monday, June 4, 2018 4:09 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan > Subject: RE: [RFC v3 2/4] FmpDevicePkg: Add library > instances > >

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Ni, Ruiyu
The Set Feature cmd is used to enable/disable PUIS. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, June 5, 2018 11:35 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Zeng, Star > Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: >

[edk2] [Patch] BaseTools: Sort PCD by token space first then by PcdCName

2018-06-04 Thread Yonghong Zhu
From: Yunhua Feng Sort PCD by token space first, then by PcdCName in the build report. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/build/BuildReport.py | 330 ++- 1

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Ni, Ruiyu
I see your point. I prefer to use AhciPuisEnable(). The function name describe the purpose. The function body explains the details. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, June 5, 2018 1:17 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Chiu, Chasel ;

Re: [edk2] [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Zeng, Star
Ray, I could not find code to compare DeviceSleepEnable/AggressiveDeviceSleepEnable with value 0, is that expected? Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday, June 4, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH v2 2/4] MdeModulePkg: Add

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Zeng, Star
Reviewed-by: Star Zeng How about using function name AhciSetFeaturePuis instead of AhciPuisEnable as the function is not just to enable Puis? Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Monday, June 4, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Chiu, Chasel

Re: [edk2] [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Ni, Ruiyu Sent: Tuesday, June 5, 2018 11:09 AM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition Yes. That's intentional. DeviceSleep and Agreesive Device Sleep are

Re: [edk2] [PATCH v2 0/3] Fix bugs in core ResetSystem software stack

2018-06-04 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, June 4, 2018 2:10 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/3] Fix bugs in core ResetSystem software stack v2: Fix the comments in

Re: [edk2] [Patch] FDF spec: Correct the example with SET statement in [FD] section

2018-06-04 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, June 04, 2018 5:22 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zhu, Yonghong Subject: [Patch] FDF spec: Correct the example with SET statement in [FD] section Region base

Re: [edk2] [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.

2018-06-04 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Supreeth Venkatesh >Sent: Tuesday, June 05, 2018 6:14 AM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming >Subject: [edk2] [PATCH v3 17/17] BaseTools/AutoGen:

Re: [edk2] [PATCH v2 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition

2018-06-04 Thread Ni, Ruiyu
Yes. That's intentional. DeviceSleep and Agreesive Device Sleep are features that require enabling every time device is powered up. Default state is disabled. So the code only compares the policy value against 1 to enable the features. Thanks/Ray > -Original Message- > From: Zeng, Star

[edk2] [RFC PATCH v1 1/2] MdePkg/IndustryStandard/Ipmi: Update IPMI header files

2018-06-04 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=814 This commit updates the IPMI related header files according to the spec: Intelligent Platform Management Interface Specification Second Generation v2.0 Document Revision 1.1 (October 1, 2013). Cc: Younas Khan Cc: Michael Kinney Cc: Liming

[edk2] [RFC PATCH v1 0/2] Update and refine the IPMI header files

2018-06-04 Thread Hao Wu
This series will: a. Update the IPMI header files with the spec Intelligent Platform Management Interface Specification Second Generation v2.0 Document Revision 1.1 (October 1, 2013). b. Refine those header files to use 'union' types for bitmap fields within structure definitions, so that

[edk2] [RFC PATCH v1 2/2] MdePkg/IndustryStandard/Ipmi: Use union for bitmap fields

2018-06-04 Thread Hao Wu
This commit enhances the bitmap fields defined in the IPMI header files, union types will be used to provide the users with both the individual bitmap access and the whole byte/word access. Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Zeng, Star
Fine. I just had the thought from my first view to the code. When I saw the name AhciPuisEnable, I thought there should be AhciPuisDisable as well, but I did not find it. Then I must check the comments and function header to know the details. Thanks, Star -Original Message- From: Ni,

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/disable PUIS per policy

2018-06-04 Thread Zeng, Star
Yes, that is why I was saying to use AhciSetFeaturePuis as the function name. Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Tuesday, June 5, 2018 11:41 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Chiu, Chasel Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru:

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Ard Biesheuvel
On 4 June 2018 at 18:41, Marcin Wojtas wrote: > All required components are in place, so we can now > add all necessary dependencies to build and use capsule support > for Armada7k8k platforms. It is conditionally enabled > with '-D CAPSULE_ENABLE' flag added during build time. > > Because the

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
Ard, 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : > On 4 June 2018 at 18:41, Marcin Wojtas wrote: >> All required components are in place, so we can now >> add all necessary dependencies to build and use capsule support >> for Armada7k8k platforms. It is conditionally enabled >> with '-D

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Ard Biesheuvel
On 4 June 2018 at 18:58, Marcin Wojtas wrote: > Ard, > > 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : >> On 4 June 2018 at 18:41, Marcin Wojtas wrote: >>> All required components are in place, so we can now >>> add all necessary dependencies to build and use capsule support >>> for Armada7k8k

[edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
All required components are in place, so we can now add all necessary dependencies to build and use capsule support for Armada7k8k platforms. It is conditionally enabled with '-D CAPSULE_ENABLE' flag added during build time. Because the capsule generation must be sequential, due to boot

[edk2] [PATCH edk2-platforms] Platform/Comcast/RDKQemu: incorporating ArmVirtQemu changes

2018-06-04 Thread Moorthy Baskaravenkatraman
Incorporated ArmVirtQemu latest changes into RDK Qemu platform - DevicePathLib library class added in Dxe Core - NvVarStoreFormattedLib added in VariableRuntimeDxe - DevicePathLib and PcdLib library classes added in DevicePathExe Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH edk2-platforms] Platform/Comcast/RDKQemu: incorporating ArmVirtQemu changes

2018-06-04 Thread Moorthy Baskaravenkatraman
Incorporating ArmVirtQemu latest changes into RDK Qemu platform Moorthy Baskaravenkatraman (1): Platform/Comcast/RDKQemu: EDK2 dependencies resolved for RDK Qemu platform - DevicePathLib library class added in DxeMain - NvVarStoreFormattedLib added in VariableRuntimeDxe -

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Carsey, Jaben
Jim, I think I see what you mean. If scan code is 0, then don’t test the shift state and just use the character raw? Jaben Sent from my iPad > On Jun 4, 2018, at 9:02 AM, "jim.dai...@dell.com" wrote: > > Please disregard the stupid "Confidential" line that our email tool > adds but hides

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Jim.Dailey
Yes! Sorry if I was unclear. -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, June 4, 2018 11:22 AM To: Dailey, Jim Cc: af...@apple.com; Ni, Ruiyu; edk2-devel@lists.01.org; fel...@mail.ru; Rothman, Michael A Subject: Re: [edk2] How to Interpret

[edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Marcin Wojtas
All required components are in place, so we can now add all necessary dependencies to build and use capsule support for Armada7k8k platforms. It is conditionally enabled with '-D CAPSULE_ENABLE' flag added during build time. Because the capsule generation must be sequential, due to boot

[edk2] [platforms PATCH v3 2/5] Marvell/Aramda7k8k: Enable PEI booting stage

2018-06-04 Thread Marcin Wojtas
PEI phase will allow to use more robust platform initialization, with new features like the capsule support. Wire up all dependencies for that purpose. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm ---

[edk2] [platforms PATCH v3 0/5] Armada capsule support

2018-06-04 Thread Marcin Wojtas
Hi, This is a third version of the Marvell Armada SoCs capsule support. I spotted minor issue in 3/5, so I resend entire series instead of only 5/5. The last patch introduces significant change in the final capsule generation - copying file is not required, a path to it has to be passed with new

[edk2] [platforms PATCH v3 4/5] Marvell/Armada7k8k: Introduce capsule FW update implementation

2018-06-04 Thread Marcin Wojtas
From: David Sniatkiwicz This patch adds necessary code that allows to update firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule, i.e. * PlatformFlashAccessLib implementation to write data to SPI flash * SystemFirmwareDescriptor for FMP protocol * SystemFirmwareUpdateConfig

[edk2] [platforms PATCH v3 1/5] Marvell/Armada70x0Db: Shift main FV from 0x0 address

2018-06-04 Thread Marcin Wojtas
When using PEI phase, UEFI interprets 0x0 address of boot FV as an error. In order to avoid it, shift it to 0x1000 and put a hardcoded 'jump to 0x1000' at offset 0x0. This patch is a preparation for using PEI by Armada platforms. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [platforms PATCH v3 3/5] Marvell/Drivers: MvSpiFlashDxe: Add progress API

2018-06-04 Thread Marcin Wojtas
In order to support new API of the PlatformFlashAccessLib, which passes and optional Progress() function, introduce new callback for updating data in the SPI flash, that can utilize it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Leif

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu ARM: work around KVM limitations in LTO build

2018-06-04 Thread Laszlo Ersek
On 06/04/18 16:50, Ard Biesheuvel wrote: > KVM on ARM refuses to decode load/store instructions used to perform > I/O to emulated devices, and instead relies on the exception syndrome > information to describe the operand register, access size, etc. > This is only possible for instructions that

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu ARM: work around KVM limitations in LTO build

2018-06-04 Thread Ard Biesheuvel
On 4 June 2018 at 17:18, Laszlo Ersek wrote: > On 06/04/18 16:50, Ard Biesheuvel wrote: >> KVM on ARM refuses to decode load/store instructions used to perform >> I/O to emulated devices, and instead relies on the exception syndrome >> information to describe the operand register, access size,

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Jim.Dailey
Dell - Internal Use - Confidential > From: af...@apple.com [mailto:af...@apple.com] > > The big picture difference is the original SimpleTextIn was the least common > denominator with a serial terminal. The Ex version added more info about > keyboards, so richer info on modifier keys. I get

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirtQemu ARM: work around KVM limitations in LTO build

2018-06-04 Thread Laszlo Ersek
On 06/04/18 17:30, Ard Biesheuvel wrote: > On 4 June 2018 at 17:18, Laszlo Ersek wrote: >> On 06/04/18 16:50, Ard Biesheuvel wrote: >>> KVM on ARM refuses to decode load/store instructions used to perform >>> I/O to emulated devices, and instead relies on the exception syndrome >>> information to

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Jim.Dailey
Please disregard the stupid "Confidential" line that our email tool adds but hides from me when I send text. :-( -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dailey, Jim Sent: Monday, June 4, 2018 11:00 AM To: af...@apple.com Cc:

Re: [edk2] How to Interpret ReadKeyStrokeEX Data

2018-06-04 Thread Rothman, Michael A
Since I'm largely the person who might be to blame for the language and intent here and I’ll focus on the spec-related item. See my comments below. Thanks, Mike Rothman (迈克 罗斯曼 / माइकल रोथ्मेन् / Михаил Ротман / משה רוטמן) רועה עיקרי של חתולים -Original Message- From:

Re: [edk2] [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Leif Lindholm
On Mon, Jun 04, 2018 at 06:58:25PM +0200, Marcin Wojtas wrote: > Ard, > > 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel : > > On 4 June 2018 at 18:41, Marcin Wojtas wrote: > >> All required components are in place, so we can now > >> add all necessary dependencies to build and use capsule support >

Re: [edk2] [platforms PATCH v4 5/5] Marvell/Armada7k8k: Wire up capsule support

2018-06-04 Thread Leif Lindholm
On Mon, Jun 04, 2018 at 07:11:45PM +0200, Marcin Wojtas wrote: > All required components are in place, so we can now > add all necessary dependencies to build and use capsule support > for Armada7k8k platforms. It is conditionally enabled > with '-D CAPSULE_ENABLE' flag added during build time. >