Fix a bug because of b3497bad1221704a5dbc5da0b10f42625f1ad2ed.
Before the patch, when GenFds fail, the build continue and return success.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Derek Lin
---
BaseTools/Source/Python/build/build.py | 7 +--
1 file changed, 5
On Tue, Dec 18, 2018 at 05:20:59AM +, Udit Kumar wrote:
> Thanks for note Leif,
>
> I am trying to understand this behavior of specification.
>
> >"If no handler has been registered, or the registered handler
> >returns, then the system will be reset by calling the Runtime
> >Service
On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote:
>
> Include a prebuilt binary of OP-TEE OS built from commit
> a5d528c7e54fd7726230483bd4cd5c4786d7703f.
> (https://github.com/OP-TEE/optee_os.git master)
>
> Also update ARM-TF RELEASE build to commit 47577cbaaf4b.
>
> Cc: Ard Biesheuvel
>
On Tue, 18 Dec 2018 at 14:04, Sumit Garg wrote:
>
> On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel
> wrote:
> >
> > On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote:
> > >
> > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel
> > > wrote:
> > > >
> > > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg
> > > > Coming back to hardware, which does not have mask around wdt, how
> > > > to implement this feature.
> > >
> > > Simple - you can't.
> > >
> > > You can absolutely implement exactly the functionality you have
> > > today, with minimal changes to the protocol - it just should not be
> > >
On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel wrote:
>
> On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote:
> >
> > Include a prebuilt binary of OP-TEE OS built from commit
> > a5d528c7e54fd7726230483bd4cd5c4786d7703f.
> > (https://github.com/OP-TEE/optee_os.git master)
> >
> > Also update
On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote:
>
> On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel
> wrote:
> >
> > On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote:
> > >
> > > Include a prebuilt binary of OP-TEE OS built from commit
> > > a5d528c7e54fd7726230483bd4cd5c4786d7703f.
> > >
On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel wrote:
>
> On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote:
> >
> > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel
> > wrote:
> > >
> > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote:
> > > >
> > > > Include a prebuilt binary of OP-TEE OS built from
Hi Liming,
On Tue, Dec 18, 2018 at 10:07 AM Gao, Liming wrote:
>
> Jagadeesh:
> StandaloneMmServicesTableLib library class header file is added into
> MdePkg. Its library implementation is in MdePkg and StandaloneMmPkg. The one
> in MdePkg produces the dummy implementation, and the one in
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, December 18, 2018 2:56 PM
>
> On Tue, Dec 18, 2018 at 05:20:59AM +, Udit Kumar wrote:
> > Thanks for note Leif,
> >
> > I am trying to understand this behavior of specification.
> >
> > >"If no handler has been
On Tue, Dec 18, 2018 at 12:57:22PM +, Udit Kumar wrote:
> > Are you referring to
> > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf?
>
> Yes !!
:)
> > That is certainly what most of the platforms in edk2-platforms use.
> >
> > The EFI_WATCHDOG_TIMER_ARCH_PROTOCOL is used by
On Tue, 18 Dec 2018 at 13:17, Sumit Garg wrote:
>
> Hi Ard,
>
> On Wed, 12 Dec 2018 at 11:05, Sumit Garg wrote:
> >
> > On Tue, 11 Dec 2018 at 21:37, Ard Biesheuvel
> > wrote:
> > >
> > > On Tue, 11 Dec 2018 at 10:06, Ard Biesheuvel
> > > wrote:
> > > >
> > > > On Tue, 11 Dec 2018 at 10:04,
On 12/17/18 7:51 PM, Ard Biesheuvel wrote:
> Use an untyped PCD reference for PcdSerialRegisterBase, so that the
> library gets built without hardcoded values, permitting modules to
> override the default serial port. This allows SerialDxe to use a
> different serial port from the one used for
Could you help take a review to the patch? :)
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Friday, December 14, 2018 6:43 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Lu, Shifei A ;
Zhou, Bowen ; Oram, Isaac W
Subject: [edk2-platforms PATCH 2/2] PurleyOpenBoardPkg: Remove
Looks good.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, December 18, 2018 3:33 PM
> To: Fu, Siyuan ; edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Kubacki, Michael A
>
> Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg
>
On Wed, Nov 28, 2018 at 08:31:17PM +0530, Meenakshi Aggarwal wrote:
> Add SocInit function that initializes peripherals
> and print board and soc information.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
> ---
>
On Tue, Dec 18, 2018 at 12:30:34PM +, Udit Kumar wrote:
> > > >"If no handler has been registered, or the registered handler
> > > >returns, then the system will be reset by calling the Runtime Service
> > > >ResetSystem()."
> > > I believe, this handler needs to be called by wdt driver after
The SP805 watchdog driver doesn't implement the PI watchdog protocol
fully, but always simply resets the system if the watchdog time runs
out.
However, the hardware does support the intended usage model, as long
as the SP805 is wired up correctly. So let's implement interrupt based
mode involving
Clean up the code, by adding missing STATIC modifiers, drop
redundant casts, and get rid of the 'success handling' anti
pattern in the entry point code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Before fixing the SP805 driver, let's clean it up a bit. No
functional changes.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c | 97
++--
This series cleans up the code of the two watchdog drivers we have for
ARM systems, and brings them in compliance with the PI spec, which
specifies that the default action of the watchdog can be overridden
by registering a handler.
Note that the TC2 code in edk2-platforms will have to be brought
Even though UEFI does not appear to use it, let's implement the
complete PI watchdog protocol, including handler registration,
which will be invoked instead of the ResetSystem() runtime service
when the watchdog timer expires.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
On 12/17/18 7:53 PM, Ard Biesheuvel wrote:
> The FVP models expose several emulated serial ports, and always start with
> Xterm windows connected to at least two of them. So let's switch to the
> second one for DEBUG output, leaving the original one for console output
> via SerialDxe.
>
>
Yi,
Good question.
With the patch, the code can be compiled and the image can boot to setup.
The image could not find shell, but that is not related to the patch.
It is because
On Tue, Dec 18, 2018 at 02:10:11PM +0100, Ard Biesheuvel wrote:
> Before fixing the SP805 driver, let's clean it up a bit. No
> functional changes.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
On Tue, Dec 18, 2018 at 02:10:13PM +0100, Ard Biesheuvel wrote:
> Clean up the code, by adding missing STATIC modifiers, drop
> redundant casts, and get rid of the 'success handling' anti
> pattern in the entry point code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
On Tue, Dec 18, 2018 at 02:10:14PM +0100, Ard Biesheuvel wrote:
> Even though UEFI does not appear to use it, let's implement the
> complete PI watchdog protocol, including handler registration,
> which will be invoked instead of the ResetSystem() runtime service
> when the watchdog timer expires.
On Tue, Dec 18, 2018 at 04:19:20PM +0100, Ard Biesheuvel wrote:
> > > @@ -178,8 +186,8 @@ WatchdogSetTimerPeriod (
> > >
> > >// if TimerPeriod is 0, this is a request to stop the watchdog.
> > >if (TimerPeriod == 0) {
> > > -mNumTimerTicks = 0;
> > > -WatchdogDisable ();
> > > +
On Tue, 18 Dec 2018 at 14:43, Leif Lindholm wrote:
>
> On Tue, Dec 18, 2018 at 02:10:13PM +0100, Ard Biesheuvel wrote:
> > Clean up the code, by adding missing STATIC modifiers, drop
> > redundant casts, and get rid of the 'success handling' anti
> > pattern in the entry point code.
> >
> >
On Tue, Dec 18, 2018 at 02:10:12PM +0100, Ard Biesheuvel wrote:
> The SP805 watchdog driver doesn't implement the PI watchdog protocol
> fully, but always simply resets the system if the watchdog time runs
> out.
>
> However, the hardware does support the intended usage model, as long
> as the
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, December 18, 2018 6:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ; Thomas
> Panakamattam Abraham ; Meenakshi Aggarwal
> ; Udit Kumar ; Matteo
> Carlini ; Nariman Poushin
>
>
On Tue, 18 Dec 2018 at 16:58, Udit Kumar wrote:
>
>
>
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Tuesday, December 18, 2018 6:40 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ard Biesheuvel ; Leif Lindholm
> > ; Sami Mujawar ; Thomas
> > Panakamattam Abraham ; Meenakshi
On Tue, 18 Dec 2018 at 14:39, Leif Lindholm wrote:
>
> On Tue, Dec 18, 2018 at 02:10:12PM +0100, Ard Biesheuvel wrote:
> > The SP805 watchdog driver doesn't implement the PI watchdog protocol
> > fully, but always simply resets the system if the watchdog time runs
> > out.
> >
> > However, the
Reviewed-by: Michael Kubacki
-Original Message-
From: Yao, Jiewen
Sent: Tuesday, December 18, 2018 3:42 AM
To: Fu, Siyuan ; edk2-devel@lists.01.org
Cc: Kubacki, Michael A
Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP
with NetworkPkg Drivers.
Looks
Please add a commit message.
What does the platform driver _do_?
(No comments on the code.)
/
Leif
On Wed, Nov 28, 2018 at 08:31:22PM +0530, Meenakshi Aggarwal wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
> ---
>
On the FVP Foundation model, the SP805 watchdog appears to be 'wired'
incorrectly, resulting in a watchdog counter that decrements at the
APB clock rate of 24 MHz instead of the usual 32 kHz. Since the
timer start value is only 32-bits wide, this makes the watchdog
unusable in UEFI, since the
On Wed, Nov 28, 2018 at 08:31:19PM +0530, Meenakshi Aggarwal wrote:
> I2C driver produces gEfiI2cMasterProtocolGuid which can be
> used by other modules.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
Many thanks for the non-trivial rework.
A
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, December 18, 2018 6:40 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Sami Mujawar ; Thomas
> Panakamattam Abraham ; Meenakshi Aggarwal
> ; Udit Kumar ; Matteo
> Carlini ; Nariman Poushin
>
>
On Wed, Nov 28, 2018 at 08:31:25PM +0530, Meenakshi Aggarwal wrote:
> This header file contain IFC controller timing structure,
> chip select enum and other IFC macros.
Please expand the IFC acronym here (like is done in file header below).
>
> Contributed-under: TianoCore Contribution
The following Pcds
- gArmTokenSpaceGuid.PcdArmLinuxSpinTable
- gArmTokenSpaceGuid.PcdArmLinuxAtagMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
remained defined, without actual users.
So get rid of them.
One reference to be deleted separately
ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
so drop them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
On Wed, Nov 28, 2018 at 08:31:26PM +0530, Meenakshi Aggarwal wrote:
> BoardLib will contain functions specific for LS1043aRdb board.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal
> Reviewed-by: Leif Lindholm
Sorry, I do have a few more
On Wed, Nov 28, 2018 at 08:31:23PM +0530, Meenakshi Aggarwal wrote:
> The firmware device, description and declaration files.
>
I won't give a reviewed-by yet since there will be at least some
changes related to watchdog - but I have a couple of comments in
addition to that.
>
On Wed, Nov 28, 2018 at 08:31:24PM +0530, Meenakshi Aggarwal wrote:
> Readme.md to explain how to build NXP board packages.
>
Could you add a link to this file from top-level Readme.md (towards
the very end)?
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi
Hello Hao,
I have made all the changes as recommended and have submitted patch v7. I have
completed all verification as suggested by you and it all seems to be working.
I have also made changes for passing controller version through private
structure.
Thanks
Ashish
Add SDMA, ADMA2 and 26b data length support.
If V4 64 bit address mode is enabled in compatibility register,
program controller to enable V4 host mode and use appropriate
SDMA registers supporting 64 bit addresses.
If V4 64 bit address mode is enabled in compatibility register,
program
*Excpetion* should be *Exception*
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Mike Maslenkin
CC: Eric Dong
CC: Laszlo Ersek
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h | 2 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c|
This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe
drivers in MdeModulePkg. These drivers will not be maintained and can't
co-work with the dual-stack drivers in NetworkPkg.
In future, people should use below NetworkPkg drivers instead:
NetworkPkg/IScsiDxe/IScsiDxe.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1278
This patch is to remove the clarification about usage/difference between
those drivers in MdeModulePkg and NetworkPkg, since the MdeModulePkg ones
have been deleted now.
Cc: Jiaxin Wu
Cc: Ye Ting
Contributed-under: TianoCore Contribution
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1393
BZ#1089 (https://bugzilla.tianocore.org/show_bug.cgi?id=1089) requests
to upgrade the OpenSSL to the latest 1.1.1 release. Since OpenSSL-1.1.1
has many changes, more porting efforts and feature evaluation are needed.
This might lead to a
Reviewed-by: Chasel Chiu
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 18, 2018 2:08 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J ; Wu,
Hao A ; Gao, Liming ; Ni, Ruiyu
; Kinney, Michael D ; Desimone,
Nathaniel L ; Chiu, Chasel
Subject: [PATCH V2
Reviewed-by: Chasel Chiu
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 18, 2018 2:08 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J ; Wu,
Hao A ; Gao, Liming ; Ni, Ruiyu
; Kinney, Michael D ; Desimone,
Nathaniel L ; Chiu, Chasel
Subject: [PATCH V2
Hi,
Could you grant me some time for reviewing this patch?
I will try to give you the feedbacks before the end of WW01 2019. Sorry for the
potential delay.
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ashish
Yi, Zailiang and David,
So, is it ok to give RB to the patch from you? :)
Thanks,
Star
-Original Message-
From: Qian, Yi
Sent: Wednesday, December 19, 2018 9:21 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Sun, Zailiang ; Wei, David
Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg:
Hi Bob,
Please try attached patch. Based on today's master.
Thanks,
Derek
-Original Message-
From: Feng, Bob C [mailto:bob.c.f...@intel.com]
Sent: Wednesday, December 19, 2018 8:25 AM
To: Lin, Derek (HPS SW) ; edk2-devel@lists.01.org; Zhao,
ZhiqiangX
Subject: RE: [PATCH] BaseTools:
Thanks. This patch works.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Lin, Derek (HPS SW) [mailto:derek.l...@hpe.com]
Sent: Wednesday, December 19, 2018 9:55 AM
To: Feng, Bob C ; edk2-devel@lists.01.org; Zhao,
ZhiqiangX
Subject: RE: [PATCH] BaseTools: Fix GenFds
Hi Derek,
This patch looks good to me. But I failed to apply this patch on master. Could
you update this patch?
Thanks,
Bob
-Original Message-
From: Lin, Derek (HPS SW) [mailto:derek.l...@hpe.com]
Sent: Tuesday, December 18, 2018 4:52 PM
To: edk2-devel@lists.01.org; Feng, Bob C ;
Reviewed-by: Chasel Chiu
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 18, 2018 2:08 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J ; Wu,
Hao A ; Gao, Liming ; Ni, Ruiyu
; Kinney, Michael D ; Desimone,
Nathaniel L ; Chiu, Chasel
Subject: [PATCH V2
Reviewed-by: Chasel Chiu
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 18, 2018 2:08 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Wang, Jian J ; Wu,
Hao A ; Gao, Liming ; Ni, Ruiyu
; Kinney, Michael D ; Desimone,
Nathaniel L ; Chiu, Chasel
Subject: [PATCH V2
Reviewed-by: Gang Wei
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, December 19, 2018 11:03 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Wei, Gang
> Subject: [PATCH] Upgrade OpenSSL to 1.1.0j
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1393
>
> BZ#1089
60 matches
Mail list logo
