Reviewed-by: Eric Dong
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, November 24, 2015 3:22 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Dong, Eric
Subject: [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option
BDS puts a special GUID in boot option optional data
One minor comment below, with that, you can have:
Reviewed-by: Star Zeng
On 2015/11/24 16:50, Tian Feng wrote:
Phase Tag, SqTdbl/CqHdbl and SqBuffer/CqBuffer should be cleared in
NvmeControllerInit() to make HC functionality work when user invokes
NvmeBlockIoReset().
Contributed-under: TianoC
On 2015/11/24 16:50, Tian Feng wrote:
In EnumerateNvmeDevNamespace(), when Private->ControllerData->Sn and/or
Private->ControllerData->Mn are NOT null-terminated strings,
UnicodeSPrintAsciiFormat(…) may generate unexpected (garbage) output
string.
Contributed-under: TianoCore Contribution Agreem
On 2015/11/24 16:50, Tian Feng wrote:
Memory pointed to by Private->ControllerData has not been freed up
correctly at error handling path.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian
Cc: Simon (Xiang) Lian-SSI
Cc: Star Zeng
---
MdeModulePkg/Bus/Pci/NvmEx
On 11/25/15 00:47, Michael Kinney wrote:
[snip]
> +//
> +// Data structure that is required for ACPI S3 resume. This structure must
> be
> +// allocated below 4GB from memory of type EfiACPIMemoryNVS. The PCD
> +// PcdCpuS3DataAddress must be set to the physical address where this
> structure
On 24 November 2015 at 18:09, Cohen, Eugene wrote:
> As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function.
>
> Background: The ArmPkg variant of the PeiServicesTablePointerLib implements
> the standard PEI Services table retrieval mechanism as defined in the PI
> Specific
On 24 November 2015 at 18:16, Cohen, Eugene wrote:
> In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer
> library that uses the "global variable" creation. (I don't know what the
> purpose is of these "global variables" but they seem to be incompatible with
> the philosop
On 11/24/15 23:48, Kinney, Michael D wrote:
> Laszlo,
>
> Thanks for the detailed feedback. Comments included below. V2 patch to
> follow.
>
> Mike
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, November 24, 2015 11:57 AM
>> To: Kinney, Mich
In my memory, GenBiosId source code isn't open source code.
There is a spec for BIOSID. You can check that for format and organization .
Thx,
Amos
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce
Cran
Sent: Wednesday, November 25, 2015 11:3
On 11/25/15 02:33, Star Zeng wrote:
> The SerialIo->GetControl() function is not required to set the
> Control output parameter on error. Make sure we apply the
> EFI_SERIAL_INPUT_BUFFER_EMPTY optimization in
> TerminalConInTimerHandler() only if the SerialIo->GetControl()
> function call set that
Reviewed-by: Jeff Fan
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, November 25, 2015 12:51 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D
Subject: [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.
The previous IDT is not in page aligned
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Wednesday, November 25, 2015 12:43 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming; Dong, Eric
Subject: [patch] MdeModulePkg:Correct the file name in UiApp.inf
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Con
The previous IDT is not in page aligned memory.
We allocate and copy it in page aligned memory, so that
other program may use page level protection on that.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
UefiCpuP
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdeModulePkg/Application/UiApp/UiApp.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Application/UiApp/UiApp.inf
b/MdeModulePkg/Application/UiA
On 11/24/15 3:03 PM, Jordan Justen wrote:
I wonder why this binary exists in EDK II without source code.
I also notice that Vlv2TbltDevicePkg/GenBiosId is a 32-bit ELF
executable. What if someone wanted to build Vlv2TbltDevicePkg on X64
and they didn't have 32-bit userspace available?
I took
On 2015/11/24 21:00, jiewen yao wrote:
We had put communication buffer to Runtime memory,
so that SMI handler can know it is not used by OS.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Zeng, Star"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
Mde
Reviewed-by: Michael Kinney
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 4:42 PM
> To: edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Fan, Jeff ;
> Kinney, Michael D
> Subject: [patch] UefiCpuPkg/PiSmmCpu: Allocate Tile size based on Page.
>
> We had better s
On 2015/11/25 8:34, Yao, Jiewen wrote:
Thanks to catch that!
I will fix it when I check in.
With that:
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, November 25, 2015 8:34 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael
Star,
The series looks good to me, and the feedback I have provided has been
addressed.
Thanks,
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Tuesday, November 24, 2015 5:34 PM
> To: edk2-devel@lists.01.org
> Sub
Reviewed-by: Michael Kinney
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, November 24, 2015 5:34 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Tian, Feng
> Subject: [PATCH V4 05/13] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg
>
> This Seria
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, November 25, 2015 12:56 AM
> To: Cohen, Eugene; Leif Lindholm; Leif Lindholm
> Cc: David Woodhouse; Long, Qin; edk2-devel@lists.01.org
> Subject: Re: [edk2] CryptoPkg: OpenSSL build issue with
Reviewed-by: Michael Kinney
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, November 24, 2015 5:34 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Tian, Feng ; Laszlo
> Ersek
> Subject: [PATCH V4 01/13] MdeModulePkg: TerminalDxe: avoid checking
> un
Star,
One minor issue in this patch. It mixes global variables and function
prototypes.
All the typedefs and function prototypes should come first, then globals, and
then function implementation.
The rest of the V3 series addresses all my V2 feedback. Thanks!
Mike
> -Original Message--
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Liming Gao
Reviewed-by: Michael D Kinney
---
PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 287 +
1 file changed, 287 inse
It is also to add GetControl/SetControl/SetAttributes implementation
for DxeEmuSerialPortLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jordan Justen
Cc: Andrew Fish
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jordan Justen
---
EmulatorPkg/Emu
Yes, the GenBiosId is 32-bit ELF binary, because we need to support GCC build
on Linux 32bit system.
Best Regards,
Tim
-Original Message-
From: Justen, Jordan L
Sent: Wednesday, November 25, 2015 6:04 AM
To: Wei, David; He, Tim
Cc: edk2-devel@lists.01.org
Subject: Vlv2TbltDevicePkg/Gen
Eugene,
This patch looks a little complicated. I may need some times to evaluate it.
One big changes may be the TS support part. We use our self-owned TS interface
(leveraging the underlying ASN1 macro and PKCS7 routines) for UEFI timestamp
support, instead of OpenSSL TS functions which cannot
Beyond just changing the directly related lines in the FDF and DSC files,
we have to adapt the EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib
instances as well, in the same patch. This is because the EmbeddedPkg
driver expects the SerialPortSetAttributes(),
SerialPortSetControl() and SerialPo
It is also to remove the reference to TemplateSerialPortExtLib in
EmbeddedPkg.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Ard Biesheuvel
---
BeagleBoardPkg/BeagleBoard
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Ard Biesheuvel
---
EmbeddedPkg/EmbeddedPkg.dsc| 6 +-
EmbeddedPkg/Include/Library/SerialPortExtLib.
The SerialIo->GetControl() function is not required to set the
Control output parameter on error. Make sure we apply the
EFI_SERIAL_INPUT_BUFFER_EMPTY optimization in
TerminalConInTimerHandler() only if the SerialIo->GetControl()
function call set that bit in the Control variable.
Cc: Michael D Ki
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Liming Gao
Reviewed-by: Michael D Kinney
---
.../BaseSerialPortLib16550.c | 347 +
1 file changed, 347 ins
On 2015/11/25 9:07, Kinney, Michael D wrote:
Star,
One minor issue in this patch. It mixes global variables and function
prototypes.
All the typedefs and function prototypes should come first, then globals, and
then function implementation.
The rest of the V3 series addresses all my V2 feed
The extended interfaces GetControl/SetControl/SetAttributes are from
EmbeddedPkg/Include/Library/SerialPortExtLib.h.
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Liming Gao
Reviewed-by: Michael D Kinney
---
It is also to integrate PL011SerialPortExtLib to PL011SerialPortLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmJunoPkg/ArmJuno.ds
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Ard Biesheuvel
---
Omap35xxPkg/Library/SerialPortLib/SerialPortLib.c | 90 +++
1 file changed, 90 inserti
This Serial driver layers on top of a Serial Port Library instance
to produce serial IO protocol.
There is also another SerialDxe implementation in CorebootPayloadPkg,
but SerialDxe from EmbeddedPkg should be better that also consumes
the extended interfaces GetControl/SetControl/SetAttributes in
1. Update fdf and dsc to use SerialDxe in MdeModulePkg.
2. Separate the code that gets SerialRegBase and SerialRegAccessType
by CbParseLib from CorebootPayloadPkg/Library/SerialPortLib to
PlatformHookLib, and then leverage BaseSerialPortLib16550 in
MdeModulePkg.
3. Remove CorebootPayloadPk
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jordan Justen
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Laszlo Ersek
---
.../XenConsoleSerialPortLib.c | 95 ++
1 file changed, 95 insertions(
Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to
MdeModulePkg,
relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to
SerialPortLib.h in MdePkg.
For your easy review, the forked code is at g...@github.com:lzeng14/edk2.git
branch SerialDxeV4.
* Ne
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
.../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 39 ++
1 file changed, 39 insertions(+)
diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/Sm
SmmCpuFeaturesCompleteSmmReadyToLock() is a hook point to allow
CPU specific code to do more registers setting after
the gEfiSmmReadyToLockProtocolGuid notification is completely processed.
SmmCpuFeaturesAllocatePageTableMemory() is an API to allow
CPU to allocate a specific region for storing pag
All page table allocation will use AllocatePageTableMemory().
Add SmmCpuFeaturesCompleteSmmReadyToLock() to PerformRemainingTasks() and
PerformPreTasks().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
UefiCpuPk
On 2015/11/24 22:42, Laszlo Ersek wrote:
On 11/24/15 15:27, Zeng, Star wrote:
On 2015/11/24 21:17, Laszlo Ersek wrote:
On 11/24/15 02:01, Zeng, Star wrote:
On 2015/11/23 22:01, Laszlo Ersek wrote:
[snip]
(2) although I see that you unified the GetControl / SetControl /
SetAttributes implem
We had better separate code from data in tile in page level,
so that other program may use page level protection on that.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
Thanks to catch that!
I will fix it when I check in.
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, November 25, 2015 8:34 AM
To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D
Cc: Zeng, Star; Fan, Jeff
Subject: RE: [patch] MdeModulePkg/PiSmmCore: Install LoadedImage
Jiewen,
One typo in a comment noted below. With that fix:
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 12:21 AM
> To: edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Zeng, Star ;
> Fan, Jeff ; Kinney, Michael D
>
> Subject:
Reviewed-by: Michael Kinney
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 12:50 AM
> To: edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Fan, Jeff ;
> Kinney, Michael D
> Subject: [patch] UefiCpuPkg/PiSmmCpu: Move SmmDebug from ASM to C.
>
> SmmDebug feature i
Reviewed-by: Michael Kinney
> -Original Message-
> From: Fan, Jeff
> Sent: Tuesday, November 24, 2015 12:55 AM
> To: edk2-de...@ml01.01.org
> Cc: Tian, Feng ; Kinney, Michael D
>
> Subject: [Patch v2 2/2] UefiCpuPkg/CpuMpPei: Enable x2APIC mode on BSP/APs
>
> If x2APIC flag is set, ena
Reviewed-by: Michael Kinney
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff
> Fan
> Sent: Tuesday, November 24, 2015 12:55 AM
> To: edk2-de...@ml01.01.org
> Cc: Kinney, Michael D ; Tian, Feng
>
> Subject: [edk2] [Patch v2 1/2] UefiCpu
Reviewed-by: Michael Kinney
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 5:00 AM
> To: edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Zeng, Star ;
> Fan, Jeff ; Kinney, Michael D
>
> Subject: [patch] MdeModulePkg/PiSmmIpl: Move CommunicationBuffer from stack
Reviewed-by: Michael Kinney
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 12:36 AM
> To: edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Fan, Jeff ;
> Kinney, Michael D ; Laszlo
> Ersek
> Subject: [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3
>
Provide a more detailed description of each field of the
ACPI_CPU_DATA and CPU_REGISTER_TABLE structures.
Cc: Laszlo Ersek
Cc: "Yao, Jiewen"
Cc: "Fan, Jeff"
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/Include/AcpiCpuData.h | 115 +++
This module initializes the ACPI_CPU_DATA structure and registers the
address of this structure in the PcdCpuS3DataAddress PCD. This is a
generic/simple version of this module. It does not provide a machine
check handler or CPU register initialization tables for ACPI S3 resume.
It also only suppo
Provide a more detailed description of each field of the
ACPI_CPU_DATA and CPU_REGISTER_TABLE structures in AcpiCpuData.h.
Add module to initialize ACPI_CPU_DATA for ACPI S3 resume.
Cc: Laszlo Ersek
Cc: "Yao, Jiewen"
Cc: "Fan, Jeff"
Contributed-under: TianoCore Contribution Agreement 1.0
Signe
Laszlo,
Thanks for the detailed feedback. Comments included below. V2 patch to follow.
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, November 24, 2015 11:57 AM
> To: Kinney, Michael D ; edk2-de...@ml01.01.org
> Cc: Yao, Jiewen ; Fan, Jeff
>
David, Tim,
I wonder why this binary exists in EDK II without source code.
I also notice that Vlv2TbltDevicePkg/GenBiosId is a 32-bit ELF
executable. What if someone wanted to build Vlv2TbltDevicePkg on X64
and they didn't have 32-bit userspace available?
-Jordan
This is a port of 55e96f9c601781b8dc52c40747922f6ca3521f9e / r17902 to
EmulatorPkg:
commit 55e96f9c601781b8dc52c40747922f6ca3521f9e
Author: Ruiyu Ni
Date: Thu Jul 9 08:55:23 2015 +
OvmfPkg: Fix GCC49 build hang in PeiCore
Cc: Andrew Fish
Cc: Ruiyu Ni
Contributed-under: TianoCore Con
Laszlo,
My comment that I was getting an ASSERT() when AllocatedSize was zero may not
have been the root cause of the ASSERT().
I will investigate more and see if I can get AllocatedSize of 0 and TableSize
of 0 work and update comments and simplify implementation.
Mike
> -Original Message
Laszlo,
Thanks for the detailed feedback. Reponses below, and updated patch to follow.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, November 24, 2015 9:36 AM
> To: Kinney, Michael D ; edk2-de...@ml01.
On 11/24/15 07:24, Michael Kinney wrote:
> This module initializes the ACPI_CPU_DATA structure and registers the
> address of this structure in the PcdCpuS3DataAddress PCD. This is
> simplest version of this module. It does not provide a machine check
(1) "[the] simplest", I believe.
> handler
Building the latest shell on RVCT exposed this warning:
ShellPkg\Application\Shell\Shell.c(1090,69): error #191-D: type qualifier is
meaningless on cast type
The CONST in the cast was deemed meaningless. Removing the CONST fixed the
warning.
---
edk2/ShellPkg/Application/Shell/Shell.c | 2
'PcdNormalMemoryNonshareableOverride' - that's what I am using now but it's
still interesting to know what causes this effect. Thx for clearing this up.
Michael.
On Tue, Nov 24, 2015 at 5:59 PM, Ard Biesheuvel
wrote:
> On 24 November 2015 at 14:49, Michael Zimmermann
> wrote:
> > sry for the l
I've removed the --fpu switch and have so far not seen any issues (building).
I then encountered an issue of duplicate symbols between BaseCryptLib and
OpensslLib:
1>armlink : error L6200: Symbol TS_ACCURACY_it multiply defined (by
BaseCryptLib.lib and OpensslLib.lib).
1>armlink : error L6200:
Ting,
> Are you asking whether the new driver producing Ip4Config2 protocol can
> support the previous network setting configured by old driver producing
> Ip4Config protocol in NVRAM?
> If yes, I think the answer is no.
Yes, that is what I meant to ask - thank you for clarifying this! And I
Mike,
first of all, thanks a lot for doing this.
Some comments below:
On 11/24/15 07:24, Michael Kinney wrote:
> Provide a more detailed description of each field of the
> ACPI_CPU_DATA and CPU_REGISTER_TABLE structures.
>
> Cc: Laszlo Ersek
> Cc: "Yao, Jiewen"
> Cc: "Fan, Jeff"
> Contribute
On 11/24/2015 11:08 AM, Leif Lindholm wrote:
+// Memory device
>+STATIC CONST ARM_TYPE17 mArmDefaultType17 = {
>+ {
>+{ // SMBIOS_STRUCTURE Hdr
>+ EFI_SMBIOS_TYPE_MEMORY_DEVICE, // UINT8 Type
>+ sizeof (SMBIOS_TABLE_TYPE17), // UINT8 Length
>+ SMBIOS_HANDLE_DIMM,
>+},
>+
In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer
library that uses the "global variable" creation. (I don't know what the
purpose is of these "global variables" but they seem to be incompatible with
the philosophy of PI/edk2 which is all about decentralizing stuff - h
As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function.
Background: The ArmPkg variant of the PeiServicesTablePointerLib implements the
standard PEI Services table retrieval mechanism as defined in the PI
Specification Volume 1 section 5.4.4 using the PIDRURW registers. No
On Fri, Nov 20, 2015 at 04:18:53PM -0600, Jeremy Linton wrote:
> SMBIOS data is consumed by a wide range of enterprise applications.
>
> Fill in the basic requirements of the SMBIOS specification by hardcoding
> the minimum required structures and data using Juno information. With
> this change bo
On 24 November 2015 at 14:49, Michael Zimmermann
wrote:
> sry for the late answer.
>
> The value of this register is: 0x10211103
> I hope that helps.
>
Thanks.
This value decodes as;
InnerShr, bits [31:28] == 1, Implemented with hardware coherency support.
ShareLvl, bits [15:12] == 1, Two levels
On 24 November 2015 at 16:53, Cohen, Eugene wrote:
> Ard, thanks - as you can tell this is an issue in the original flags and not
> with the changes I've added. I agree that we should not redefine the fpu in
> this file but rather inherit from the build.
>
Looking at the repo history, it turns
Hi Daryl,
what I basically did to integrate it into the shell was to copy the original
shell (not the whole ShellPkg, just the shell application) and the original
UefiShellNetwork1CommandsLib, I modified the UefiShellNetwork1CommandsLib to
include my program and the shell application (or better
Hi Jeremy,
Thanks for this reworked version.
A few minor comment below.
On Fri, Nov 20, 2015 at 04:18:51PM -0600, Jeremy Linton wrote:
> The code to detect what juno revision we are running on
> is fairly small. Put it in a common header, where it may be
> shared by a couple modules.
>
> Contrib
Johannes,
In order for an application to use features from STDLIB, the application must
be explicitly linked with the appropriate libraries.
For applications that are built into the shell and are part of the same .efi
file the rules that apply to standalone applications
should work. The Shell
Ard, thanks - as you can tell this is an issue in the original flags and not
with the changes I've added. I agree that we should not redefine the fpu in
this file but rather inherit from the build.
David, good comments - I'm working on an updated patch. I'm running into some
issues related to
On 24 November 2015 at 15:47, David Woodhouse wrote:
> On Tue, 2015-11-24 at 14:19 +, Cohen, Eugene wrote:
>>
>> Here's a patch with this changes:
>>
>> ---
>> edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf| 2
>> +-
>> edk2/CryptoPkg/Library/OpensslLib/openssl-1.0.
Yes, I found only ApMachineCheckHandlerBase is copied back, because it is code.
CopyMem ((VOID *)(UINTN) mAcpiCpuData.ApMachineCheckHandlerBase,
mMachineCheckHandlerForAp, mAcpiCpuData.ApMachineCheckHandlerSize);
There is no need to copy other data back to original place because it just
reco
Got it. Agree.
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, November 24, 2015 10:47 PM
To: Yao, Jiewen; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Laszlo Ersek; Fan, Jeff
Subject: RE: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize
ACPI_CPU_DATA for S3
Ji
Jiewen,
ACPI NVS is required for SMM disabled case.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, November 24, 2015 6:14 AM
> To: Kinney, Michael D ; edk2-devel@lists.01.org
> Cc: Laszlo Ersek ; Fan, Jeff
> Subject: RE: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module t
On 11/24/15 15:13, Yao, Jiewen wrote:
> Hi Mike
> This patch is great.
> We can have a generic S3 support module now.
>
> After check the code, I am not sure if we have to allocate AcpiNvs for these
> data.
> Per my understanding, SMM CPU driver will always copy them into SMRAM, for
> security c
On Tue, 2015-11-24 at 14:19 +, Cohen, Eugene wrote:
>
> Here's a patch with this changes:
>
> ---
> edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf| 2
> +-
> edk2/CryptoPkg/Library/OpensslLib/openssl-1.0.2d/crypto/x509/x509_vfy.c | 1 +
> 2 files changed, 2 inserti
On 11/24/15 15:27, Zeng, Star wrote:
> On 2015/11/24 21:17, Laszlo Ersek wrote:
>> On 11/24/15 02:01, Zeng, Star wrote:
>>> On 2015/11/23 22:01, Laszlo Ersek wrote:
>>
>> [snip]
>>
(2) although I see that you unified the GetControl / SetControl /
SetAttributes implementations between
The Ifconfig command handler tries to return an EFI_STATUS when the return type
should be SHELL_STATUS. RVCT 4 is (correctly) flagging this as an error:
edk2\ShellPkg\Library\UefiShellNetwork1CommandsLib\Ifconfig.c(1387,10): error
#188-D: enumerated type mixed with another type
I haven't fou
On 2015/11/24 21:17, Laszlo Ersek wrote:
On 11/24/15 02:01, Zeng, Star wrote:
On 2015/11/23 22:01, Laszlo Ersek wrote:
[snip]
(2) although I see that you unified the GetControl / SetControl /
SetAttributes implementations between
- EarlyFdtPL011SerialPortLib and
- FdtPL011SerialPortLib,
the
Long,
Thanks, my RVCT is up to date at build 925 and I think the issue described only
applies to 'goto' and 'case' statements.
I updated the --diag_suppress as you suggested to ignore warning 128. Next
issue are these two warnings:
edk2\CryptoPkg\Library\OpensslLib\openssl-1.0.2d\cryp
Hi Mike
This patch is great.
We can have a generic S3 support module now.
After check the code, I am not sure if we have to allocate AcpiNvs for these
data.
Per my understanding, SMM CPU driver will always copy them into SMRAM, for
security consideration.
If so, do you think it is enough to allo
On 11/24/15 00:25, Andrew Fish wrote:
>
>> On Nov 23, 2015, at 2:03 PM, Narinder Dhillon wrote:
>>
>> Hi Andrew,
>>
>> I looked at the ArmVirtPkg and did the same before I sent the previous
>> email. I am missing some step that is causing the null package to be
>> picked up. Here are my changes,
It's the value of the register before EDK2 boots. If you want to know the
register's value at a specific UEFI stage, just tell me.
On Tue, Nov 24, 2015 at 2:49 PM, Michael Zimmermann <
sigmaepsilo...@gmail.com> wrote:
> sry for the late answer.
>
> The value of this register is: 0x10211103
> I ho
sry for the late answer.
The value of this register is: 0x10211103
I hope that helps.
On Wed, Nov 18, 2015 at 12:16 PM, Ard Biesheuvel
wrote:
> On 16 November 2015 at 16:03, Michael Zimmermann
> wrote:
> > Unfortunately I can't tell you much about how the L2 works or if it's
> > configurable b
Testing list destination rewrites; apologies for the noise.
--
dwmw2
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Testing list destination rewrites; apologies for the noise.
--
dwmw2
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Got it. I will remove the two leading space characters. Thanks!
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, November 24, 2015 6:21 PM
To: Yao, Jiewen; edk2-de...@ml01.01.org
Cc: Fan, Jeff; Kinney, Michael D
Subject: Re: [patch] UefiCpuPkg/PiSmmCpu: Move
On 11/24/15 02:01, Zeng, Star wrote:
> On 2015/11/23 22:01, Laszlo Ersek wrote:
[snip]
>> (2) although I see that you unified the GetControl / SetControl /
>> SetAttributes implementations between
>> - EarlyFdtPL011SerialPortLib and
>> - FdtPL011SerialPortLib,
>>
>> the actual implementations are
We had put communication buffer to Runtime memory,
so that SMI handler can know it is not used by OS.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Zeng, Star"
Cc: "Fan, Jeff"
Cc: "Kinney, Michael D"
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 26 +
On 11/24/15 08:06, Kinney, Michael D wrote:
> Laszlo,
>
> I other modules where we want to halt no matter what, the following 2
> statements are used together. ASSERT() could be removed by PCD
> settings, so dead loop catches that case. If ASSERT() is enabled,
> then the ASSERT() behavior of BP
On 11/24/15 09:36, jiewen yao wrote:
> In this way, we can centralize the silicon configuration in
> PerformRemainingTasks()/PerformPreTasks() function.
> If there are more features need to be configured, they can put in
> PerformRemainingTasks()/PerformPreTasks() only.
>
> Contributed-under: Ti
If x2APIC flag is set, enable x2APIC mode on all APs and BSP. Before we wakeup
APs to enable x2APIC mode, we should wait all APs have finished initialization.
Cc: Feng Tian
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/CpuMpPe
If there are any logical processor reporting an APIC ID of 255 or greater.
We should enable x2APIC mode.
v2 updating:
a. Drop v1 patch 1/3 and check if APIC ID is larger than 254 directly.
b. Move ApFuncEnableX2Apic() from 1/2 to 2/2.
Jeff Fan (2):
UefiCpuPkg/CpuMpPei: Set X2APIC flag if one x2
If there are any logical processor reporting an APIC ID of 255 or greater, set
X2ApicEnable flag.
GetInitialApicId() will return x2APIC ID if CPUID leaf B supported.
Cc: Feng Tian
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg
1 - 100 of 112 matches
Mail list logo
