[edk2] [Patch 0/2] Recycle TX buffer asynchronously in MNP driver.

2015-12-14 Thread Fu Siyuan
This patch updates the MNP driver to recycle TX buffer asynchronously, instead of using a while loop wait after each transmit command. And a bug fix in SNP GetStatus is needed for this change. Fu Siyuan (2): MdeModulePkg: update SNP.GetStatus to handle multiple recycled TX buffer. MdeModu

[edk2] [Patch 1/2] MdeModulePkg: update SNP.GetStatus to handle multiple recycled TX buffer.

2015-12-14 Thread Fu Siyuan
This patch fixes a bug in SNP.GetStatus() interface. The UNDI driver may return multiple transmitted buffers in a single GetStatus command, while SNP.GetStatus could only return one pointer each time, the rest of them are lost. This patch fixes this issue by store these recycled pointer in a tempor

[edk2] [Patch 2/2] MdeModulePkg: Update MNP driver to recycle TX buffer asynchronously.

2015-12-14 Thread Fu Siyuan
This patch updates the MNP driver to recycle TX buffer asynchronously, instead of using a while loop wait after each transmit command. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- MdeModulePkg/Universal/Network/MnpDxe/MnpConfig.c | 177 ++--

[edk2] [PATCH] ShellPkg: Fix the 'bcfg' command ASSERT when use some invalid parameters.

2015-12-14 Thread Qiu Shumin
'bcfg boot mv xx yy' command will ASSET when xx is larger than the count of boot options. This patch correct the order of ShellPrintHiiEx parameters to fix the bugs. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/UefiShel

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

2015-12-14 Thread Jordan Justen
On 2015-12-13 14:48:54, Kinney, Michael D wrote: > Jordan, > > I have updated to Quark_V3 that uses this concept along with a > proposed edk2-non-osi repository with a new QuarkSocBinPkg. It uses > PACKAGES_PATH to support the multiple repositories to do a build. > The content is posted for review

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 15 December 2015 at 04:16, M.V.R. Ravikanth wrote: > Thanks for the information Andrew! > > So,I have to re write the entire standard library code which is in line with > EFI environment such as AllocatePool?If yes,then it would a big task at > hand.If no,will the recompilation of standard libr

[edk2] [Patch 4/4] SourceLevelDebugPkg: Correct gEfiDebugAgentGuid usage in DxeDebugAgentLib

2015-12-14 Thread Liming Gao
DxeDebugAgentLib instance produces gEfiDebugAgentGuid system table. Its usage should be PRODUCES instead of SOMETIMES_PRODUCES. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- SourceLevelDebugPkg/Library/DebugAgent/DxeDebugAgentLib.inf | 2 +- 1 file changed

[edk2] [Patch 1/4] SecurityPkg: Correct Pcd Usage PcdTcg2HashAlgorithmBitmap

2015-12-14 Thread Liming Gao
HashLibBaseCryptoRouter sets PcdTcg2HashAlgorithmBitmap. Its usage should be both SOMETIMES_CONSUMES and SOMETIMES_PRODUCES. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf| 4 +++- .../L

[edk2] [Patch 3/4] MdeModulePkg: Correct usage gEfiIp4Config2ProtocolGuid in Ip4Dxe

2015-12-14 Thread Liming Gao
Ip4Dxe driver installs gEfiIp4Config2ProtocolGuid. Its usage should be BY_START. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg

[edk2] [Patch 0/4] Correct Pcd/Guid/Protocol Usage in module INF

2015-12-14 Thread Liming Gao
Liming Gao (4): SecurityPkg: Correct Pcd Usage PcdTcg2HashAlgorithmBitmap SecurityPkg: Correct Pcd Usage PcdTpm2HashMask in Tcg2Pei MdeModulePkg: Correct usage gEfiIp4Config2ProtocolGuid in Ip4Dxe SourceLevelDebugPkg: Correct gEfiDebugAgentGuid usage in DxeDebugAgentLib MdeModulePkg/U

[edk2] [Patch 2/4] SecurityPkg: Correct Pcd Usage PcdTpm2HashMask in Tcg2Pei

2015-12-14 Thread Liming Gao
Tcg2Pei sets PcdTpm2HashMask. Its usage should be both SOMETIMES_CONSUMES and SOMETIMES_PRODUCES. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Secur

Re: [edk2] [PATCH] MdeModulePkg UfsPassThru: ASSERT if params are NULL in SignalCallerEvent

2015-12-14 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, December 14, 2015 09:44 To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A; Qiu, Shumin Subject: [edk2] [PATCH] MdeModulePkg UfsPassThru: ASSERT if para

[edk2] [patch] NetworkPkg:Fix the issue Http boot hang when network failed.

2015-12-14 Thread Zhang Lubo
For both IPv4 and IPv6, when network transfer failed, such as disconnected cable or disable http server, HTTP boot should exit back to the menu UI rather than hang. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- Ne

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Thanks for the information Andrew! So,I have to re write the entire standard library code which is in line with EFI environment such as AllocatePool?If yes,then it would a big task at hand.If no,will the recompilation of standard libraries in EFI environment suffice here? Also,when I compiled m

Re: [edk2] [PATCH v2] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-14 Thread Dong, Eric
Reviewed-by: Eric Dong Checked in code at r19245. Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil Sheng Sent: Tuesday, December 15, 2015 10:37 AM To: edk2-devel@lists.01.org Cc: Cecil Sheng Subject: [edk2] [PATCH v2] MdeModul

[edk2] [PATCH v2] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-14 Thread Cecil Sheng
On a failed REF_OP callback, all changed fields in the Selection should be restored. Signed-off-by: Cecil Sheng --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentat

Re: [edk2] [Patch 2/2] FileExplorerLib: Remove the useless code.

2015-12-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, December 15, 2015 9:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 2/2] FileExplorerLib: Remove the useless code. The caller has initial th

[edk2] [Patch 2/2] FileExplorerLib: Remove the useless code.

2015-12-14 Thread Eric Dong
The caller has initial the input parameter before call this function, So this code is useless. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/MdeModuleP

[edk2] [Patch 1/2] BootManagerLib: Check the pointer to avoid use NULL pointer.

2015-12-14 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- MdeModulePkg/Library/BootManagerLib/BootManager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Library/BootManagerLib/BootManager.c b/MdeModulePkg/Library/BootManagerLib/BootManager.c index c

[edk2] [Patch 0/2] Refine the code to make them more safely.

2015-12-14 Thread Eric Dong
These patches refine the code to avoid use NULL pointer. Eric Dong (2): BootManagerLib: Check the pointer to avoid use NULL pointer. FileExplorerLib: Remove the useless code. MdeModulePkg/Library/BootManagerLib/BootManager.c | 1 + MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 2 --

Re: [edk2] [PATCH] MdePkg: Add missing SMBIOS definitions for SATA and SAS Ports

2015-12-14 Thread Zeng, Star
On 2015/12/15 7:57, Samer El-Haj-Mahmoud wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/SmBios.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/In

Re: [edk2] [PATCH] SecurityPkg: Add TCG physical presence definition for clear deactivate

2015-12-14 Thread Yao, Jiewen
HI Samer I checked TCG official web, the latest PPI spec at http://www.trustedcomputinggroup.org/resources/tcg_physical_presence_interface_specification Version 0.52, http://www.trustedcomputinggroup.org/files/resource_files/D6850418-1A4B-B294-D0427225D4301E82/Physical%20Presence%20Interface_1-30

Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread El-Haj-Mahmoud, Samer
Thanks Jiewen. I agree. I don't have permission to commit. Can you please fix the comment and commit it for me? -Original Message- From: Yao, Jiewen [jiewen@intel.com] Received: Monday, 14 Dec 2015, 6:51PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lis

Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread Yao, Jiewen
HI Samer The patch is good. The check in comment seems not match the file you changed. Should it be "The GicVersion field is defined in ACPI 5.1 and 6.0"? Reviewed-by: jiewen@intel.com, if you change the comment, when you check in. -Original Message- From: edk2-devel [mailto:edk2-d

[edk2] [patch 0/2] Fix two issues in PciSioSerialDxe

2015-12-14 Thread Tian Feng
There are two issues: 1. Add assertion to make sure there is no non-null pointer dereference 2. Make sure the operands of bitwise operation have same size Tian Feng (2): MdeModulePkg/PciSioSerialDxe:add non-null pointer dereference assertion MdeModulePkg/PciSioSerialDxe:bitwise operation h

[edk2] [patch 2/2] MdeModulePkg/PciSioSerialDxe:bitwise operation have same width operands

2015-12-14 Thread Tian Feng
Operands in a bitwise operation have different size. Update code to fix it. Cc: Qiu Shumin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/PciSioSerialDxe/Serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeMo

[edk2] [patch 1/2] MdeModulePkg/PciSioSerialDxe:add non-null pointer dereference assertion

2015-12-14 Thread Tian Feng
Add assertion to make sure there doesn't exist null pointer dereference. Cc: Qiu Shumin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/PciSioSerialDxe/Serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/

Re: [edk2] [PATCH] MdeModulePkg: Fix RegularExpressionDxe memcpy intrinsic

2015-12-14 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, December 15, 2015 8:41 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Qiu, Shumin; Samer El-Haj-Mahmoud; Samer El-Haj-Mahmoud Subject: [PATCH] MdeModulePkg: Fix Regu

[edk2] [PATCH] MdeModulePkg: Fix RegularExpressionDxe memcpy intrinsic

2015-12-14 Thread Samer El-Haj-Mahmoud
Use explicit CopyMem to resolve intrinsic memcpy errors on some compilers Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../Universal/RegularExpressionDxe/Oniguruma/regcomp.c | 14 -- .../Universal/RegularExpressionDxe/Oniguruma/r

[edk2] [PATCH] SecurityPkg: Add TCG physical presence definition for clear deactivate

2015-12-14 Thread Samer El-Haj-Mahmoud
Add PHYSICAL_PRESENCE_CLEAR_DEACTIVATE_DISABLE Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- SecurityPkg/Include/Guid/PhysicalPresenceData.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/SecurityPkg/Include/Guid/PhysicalPresenceData.h b

Re: [edk2] [PATCH] ShellPkg: Use %p for smbiosview SMBIOS table addresses

2015-12-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 14, 2015 4:28 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben ; > Samer El-Haj-Mahmoud ; Samer El-Haj- > Mahmoud > Subject: [PATCH]

Re: [edk2] [PATCH] ShellPkg: Fix a bug in smbiosview PowerSupply Characteristics

2015-12-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 14, 2015 4:24 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben ; > Samer El-Haj-Mahmoud ; Samer El-Haj- > Mahmoud > Subject: [PATCH]

[edk2] [PATCH] ShellPkg: Use %p for smbiosview SMBIOS table addresses

2015-12-14 Thread Samer El-Haj-Mahmoud
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/Smb

[edk2] [PATCH] ShellPkg: Fix a bug in smbiosview PowerSupply Characteristics

2015-12-14 Thread Samer El-Haj-Mahmoud
Fix bit shifting when isolating the Characteristics of Power Supply information Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[edk2] [PATCH] MdePkg: Add PcdPciDegradeIfOptionRomPresent PCD for PCI resource degradation policy

2015-12-14 Thread Samer El-Haj-Mahmoud
Define a new PCD PcdPciDegradeIfOptionRomPresent to enable or disable the policy of PCI BAR resource degradation from 64-bit to 32-bit based on the presence of a PCI OptionROM. Default is TRUE to keep backwards compatibility with existing code. Contributed-under: TianoCore Contribution Agreement 1

[edk2] [PATCH] MdePkg: Add missing SMBIOS definitions for SATA and SAS Ports

2015-12-14 Thread Samer El-Haj-Mahmoud
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/SmBios.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index 0959247..1ca9d

Re: [edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, December 15, 2015 12:31 AM To: edk2-devel@lists.01.org; Leif Lindholm; Zhu, Yonghong; Gao, Liming Cc: Ard Biesheuvel Subject: Re: [edk2] [PATCH

[edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

2015-12-14 Thread Samer El-Haj-Mahmoud
The GicVersion field is defined in ACPI 5.0 and 6.0 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/Acpi51.h | 12 +++- MdePkg/Include/IndustryStandard/Acpi60.h | 12 +++- 2 files changed, 22 insertio

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-14 Thread El-Haj-Mahmoud, Samer
Hello Patrick, We ran into the same issue of automatic demoation simply because of the presence of an OptionROM. We believe this is an overly aggressive policy. In fact, I have a patch that I am about to submit that adds a platform PCD to enable/disable this policy. Would like feedback on the

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Andrew Fish
> On Dec 14, 2015, at 10:44 AM, M.V.R. Ravikanth wrote: > > Oh Ok great!Thanks :) > Now I actually removed the --emit-relocs linker option and GenFw did not give > me any issues.Does this mean that my final EFI binary has issues but GenFw > did not report them The PE/COFF images that created

[edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

2015-12-14 Thread Mahan, Patrick
All, I am working on writing the UEFI driver for our LiquidIO line of NICs and have run into an issue with the PCI layer that may or may not be contributing. I am working with our AARCH64 platform, ThunderX and in the handling of the PCIe detection. The code that handles the PCI configuration

Re: [edk2] [PATCH] ShellPkg Ease MAN file Title Header syntax requirements

2015-12-14 Thread Carsey, Jaben
Looks good to me. Shumin, If it looks good to you, can you also commit? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Monday, December 14, 2015 11:44 AM > To: edk2-devel@lists.01.org

[edk2] [PATCH] ShellPkg Ease MAN file Title Header syntax requirements

2015-12-14 Thread Jim_Dailey
ShellPkg: Ease the shell's MAN file Title Header syntax requirements. Prior to this change, the shell would not use a MAN file if the Title Header line was not strictly formatted. For example, if the case of the command name in the file was not exactly the same as the case of the command name as

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

2015-12-14 Thread Carsey, Jaben
Looks good. Thanks! > -Original Message- > From: Kinney, Michael D > Sent: Monday, December 14, 2015 10:14 AM > To: Carsey, Jaben ; edk2-devel@lists.01.org; Kinney, > Michael D > Cc: Ni, Ruiyu > Subject: RE: [Patch] ShellPkg/Mm: Fix build warnings > Importance: High > > Jaben, > > Eri

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Oh Ok great!Thanks :) Now I actually removed the --emit-relocs linker option and GenFw did not give me any issues.Does this mean that my final EFI binary has issues but GenFw did not report them(this case is with standard libraries linked and my CPP program has reference to standard libraries)?

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 19:24, M.V.R. Ravikanth wrote: > Below are the detailed steps which I perform: > > 1.Compile CPP program with linaro GCC on windows. > 2.Linking >->If my code contains reference to standard C++ libraries,then I > include the libstdc++ and dependent libraries.In this

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Below are the detailed steps which I perform: 1.Compile CPP program with linaro GCC on windows.2.Linking ->If my code contains reference to standard C++ libraries,then I include the libstdc++ and dependent libraries.In this case,I see the GenFw relocation errors. ->If my code DOESN'T

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Thanks Andrew and Ard! So,Why am I receiving those relocation issues even when I set the memory model to large?Any issue with the compiler or I need to set any other flags apart from the below declared ones?I am really not sure on how to proceed further with these issues in place. Below is my to

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

2015-12-14 Thread Kinney, Michael D
Jaben, Eric Tian made the commit. Can you please verify that it was rebased correctly. Thanks, Mike > -Original Message- > From: Carsey, Jaben > Sent: Monday, December 14, 2015 8:12 AM > To: Kinney, Michael D ; edk2- > de...@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > > Subject: RE

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 18:47, Andrew Fish wrote: > >> On Dec 14, 2015, at 2:35 AM, M.V.R. Ravikanth wrote: >> >> Hi, >> I was able to build a EFI binary out of CPP programs with Visual Studio >> 2005/WinDDK as the compiler.But with ARM Cross compiler/ARM Native >> compiler,I am facing the below

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Andrew Fish
> On Dec 14, 2015, at 2:35 AM, M.V.R. Ravikanth wrote: > > Hi, > I was able to build a EFI binary out of CPP programs with Visual Studio > 2005/WinDDK as the compiler.But with ARM Cross compiler/ARM Native compiler,I > am facing the below said problems while compiling CPP programs.I am really

Re: [edk2] [PATCH 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 18:24, Leif Lindholm wrote: > On Mon, Dec 14, 2015 at 05:25:05PM +0100, Ard Biesheuvel wrote: >> The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not >> supported by CLANG. So restrict its use to GCC 4.6, which is the oldest >> version we support for ARM

Re: [edk2] Missing ConvertUni.py script

2015-12-14 Thread Jordan Justen
On 2015-12-14 08:11:55, El-Haj-Mahmoud, Samer wrote: > There has been several submissions to convert UNI files to UTF8 that > refereed to this script: > > $ python3 BaseTools/Scripts/ConvertUni.py > > But the script does not exist in EDK2 SVN trunk. Was it missed? Is > it going to be added? > It

Re: [edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 05:25:06PM +0100, Ard Biesheuvel wrote: > This extends the existing CLANG35 toolchain definition with support for > building for the ARM architecture. In order to be able to reuse the existing > ARM GCC definitions as much as possible, the following changes have been > made

Re: [edk2] [PATCH 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 05:25:05PM +0100, Ard Biesheuvel wrote: > The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not > supported by CLANG. So restrict its use to GCC 4.6, which is the oldest > version we support for ARM. Can you provide a reference to the discussion declarin

Re: [edk2] [PATCH 3/5] ArmPkg/ArmV7Lib: add CLANG alternative for FPEXC access

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 05:25:04PM +0100, Ard Biesheuvel wrote: > The open coded access to co-processor #10 to set FPEXC is not supported > by the CLANG assembler, but the architecturally correct VMSR instruction > is not supported by older binutils. So keep the former unless __clang__ > is defined

Re: [edk2] [PATCH 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 05:25:03PM +0100, Ard Biesheuvel wrote: > CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different > from the default memset() [arguments 2 and 3 are reversed] > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel >

Re: [edk2] [PATCH 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 17:40, Leif Lindholm wrote: > On Mon, Dec 14, 2015 at 05:25:02PM +0100, Ard Biesheuvel wrote: >> The CLANG assembler does not support the legacy, non-unified assembler >> syntax, >> i.e., it does not support the reordering of the condition suffixes with the >> increment/dec

Re: [edk2] [PATCH 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 05:25:02PM +0100, Ard Biesheuvel wrote: > The CLANG assembler does not support the legacy, non-unified assembler syntax, > i.e., it does not support the reordering of the condition suffixes with the > increment/decrement before/after or byte/word suffixes, and it does not >

[edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Ard Biesheuvel
This extends the existing CLANG35 toolchain definition with support for building for the ARM architecture. In order to be able to reuse the existing ARM GCC definitions as much as possible, the following changes have been made to the existing ARM GCC support: - the -mapcs option has been removed; i

Re: [edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Ard Biesheuvel
(adding Yonghong and Liming) On 14 December 2015 at 17:25, Ard Biesheuvel wrote: > This extends the existing CLANG35 toolchain definition with support for > building for the ARM architecture. In order to be able to reuse the existing > ARM GCC definitions as much as possible, the following change

[edk2] [PATCH 3/5] ArmPkg/ArmV7Lib: add CLANG alternative for FPEXC access

2015-12-14 Thread Ard Biesheuvel
The open coded access to co-processor #10 to set FPEXC is not supported by the CLANG assembler, but the architecturally correct VMSR instruction is not supported by older binutils. So keep the former unless __clang__ is defined. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by

[edk2] [PATCH 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

2015-12-14 Thread Ard Biesheuvel
CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different from the default memset() [arguments 2 and 3 are reversed] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/CompilerIntrinsicsLib/Arm/memset.S | 11 +-- 1 f

[edk2] [PATCH 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

2015-12-14 Thread Ard Biesheuvel
The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not supported by CLANG. So restrict its use to GCC 4.6, which is the oldest version we support for ARM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Library/ArmSoftFloatLib/A

[edk2] [PATCH 0/5] add CLANG support for ARM

2015-12-14 Thread Ard Biesheuvel
This series consists of 4 patches that tweak existing ARM code so it can be built with Clang, and a final patch against tools_def.template that introduces the defines so that '-a ARM' can be combined with '-t CLANG35' Ard Biesheuvel (5): ArmPkg: use unified asm syntax for CLANG ArmPkg/Compiler

[edk2] [PATCH 1/5] ArmPkg: use unified asm syntax for CLANG

2015-12-14 Thread Ard Biesheuvel
The CLANG assembler does not support the legacy, non-unified assembler syntax, i.e., it does not support the reordering of the condition suffixes with the increment/decrement before/after or byte/word suffixes, and it does not recognize the 'empty descending' (ED) suffix at all. So move to the unif

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

2015-12-14 Thread Carsey, Jaben
Mike, Your second patch needs to be rebased. This is changing some of the lines that were changed with the most recent patch to this file. -Jaben > -Original Message- > From: Kinney, Michael D > Sent: Saturday, December 12, 2015 1:50 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; C

Re: [edk2] [PATCH] ArmPlatformPkg/Sec: fix return_from_exception code and comment

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 10:04:57AM +0100, ard wrote: > The return_from_exception implementation in Sec/Helper.S (the GCC > version) deviates from the RVCT version, in a way that suggests that > both may have been broken at some point, and that they weren't fixed > in the same way nor at the same ti

[edk2] Missing ConvertUni.py script

2015-12-14 Thread El-Haj-Mahmoud, Samer
There has been several submissions to convert UNI files to UTF8 that refereed to this script: $ python3 BaseTools/Scripts/ConvertUni.py But the script does not exist in EDK2 SVN trunk. Was it missed? Is it going to be added? Thanks, --Samer ___ edk2-

Re: [edk2] [PATCH] ArmPlatformPkg/Sec: fix return_from_exception code and comment

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 17:04, Leif Lindholm wrote: > On Mon, Dec 14, 2015 at 10:04:57AM +0100, ard wrote: >> The return_from_exception implementation in Sec/Helper.S (the GCC >> version) deviates from the RVCT version, in a way that suggests that >> both may have been broken at some point, and tha

Re: [edk2] UEFI enable NETWORK STACK problem

2015-12-14 Thread Stephen Polkowski
Hi Laszlo, Thanks for the reply. I believe I understand what you are saying about NICs having different driver types UNDI, SMP, etc. However, my belief is that if a system offers an "Enable Network Stack" option it should also provide the driver such that "ifconfig -s eth0 dhcp" and "ping"

Re: [edk2] linux x86_64 build error

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 14:51, Gabriel L. Somlo wrote: > Ard, > > I recently updated my edk2 git repo, and ever since commit 214a3b7 > (BaseTools GCC: avoid the use of COMMON symbols), I get a build error: > Hi, You need to update your Conf/tools_def.txt. If you have no local changes, you can sim

[edk2] linux x86_64 build error

2015-12-14 Thread Gabriel L. Somlo
Ard, I recently updated my edk2 git repo, and ever since commit 214a3b7 (BaseTools GCC: avoid the use of COMMON symbols), I get a build error: $ build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc ... "ld" -o /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/IntelFrameworkModulePkg/Un

Re: [edk2] [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-14 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Sheng, Cecil (HPS SW) Sent: Sunday, December 13, 2015 11:38 PM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Sheng, Cecil (HPS SW) Subject: [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callbac

Re: [edk2] [PATCH 0/5] ArmPlatformPkg: fix gArmMpCoreInfoPpiGuid declaration

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 13:15, Leif Lindholm wrote: > On Mon, Dec 14, 2015 at 11:59:00AM +0100, Ard Biesheuvel wrote: >> This fixes five copy-pasted instances where the gArmMpCoreInfoPpiGuid PPI >> is redeclared in an open-coded fashion rather than simply declared in the >> module .inf. >> >> Ard B

Re: [edk2] [PATCH 0/5] ArmPlatformPkg: fix gArmMpCoreInfoPpiGuid declaration

2015-12-14 Thread Leif Lindholm
On Mon, Dec 14, 2015 at 11:59:00AM +0100, Ard Biesheuvel wrote: > This fixes five copy-pasted instances where the gArmMpCoreInfoPpiGuid PPI > is redeclared in an open-coded fashion rather than simply declared in the > module .inf. > > Ard Biesheuvel (5): > ArmPlatformPkg/ArmPlatformLibNull: use

[edk2] [PATCH 5/5] ArmPlatformPkg/RTSM: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpr

[edk2] [PATCH 3/5] ArmPlatformPkg/CTA15-A7: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExp

[edk2] [PATCH 1/5] ArmPlatformPkg/ArmPlatformLibNull: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Library/ArmPlatformLibNull/ArmP

[edk2] [PATCH 4/5] ArmPlatformPkg/CTA9x4: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpr

[edk2] [PATCH 2/5] ArmPlatformPkg/ArmJunoLib: use declared PPI rather than module local var

2015-12-14 Thread Ard Biesheuvel
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under [Ppis] in the library's .inf so there is no need to copy it into a module local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/A

[edk2] [PATCH 0/5] ArmPlatformPkg: fix gArmMpCoreInfoPpiGuid declaration

2015-12-14 Thread Ard Biesheuvel
This fixes five copy-pasted instances where the gArmMpCoreInfoPpiGuid PPI is redeclared in an open-coded fashion rather than simply declared in the module .inf. Ard Biesheuvel (5): ArmPlatformPkg/ArmPlatformLibNull: use declared PPI rather than module local var ArmPlatformPkg/ArmJunoLib: u

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Hi, I was able to build a EFI binary out of CPP programs with Visual Studio 2005/WinDDK as the compiler.But with ARM Cross compiler/ARM Native compiler,I am facing the below said problems while compiling CPP programs.I am really not sure why. ThanksRavi > Date: Mon, 14 Dec 2015 11:11:28 +0100 >

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread Ard Biesheuvel
On 14 December 2015 at 10:59, M.V.R. Ravikanth wrote: > Thanks Biesheuvel! > I cross checked the tool chain configuration and -mcmodel=large is > present.Also to add,I am facing this issue ONLY WHEN COMPILING CPP > programs.When I compile and C program,everything goes fine. > > I tried a simple He

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

2015-12-14 Thread M.V.R. Ravikanth
Thanks Biesheuvel!I cross checked the tool chain configuration and -mcmodel=large is present.Also to add,I am facing this issue ONLY WHEN COMPILING CPP programs.When I compile and C program,everything goes fine. I tried a simple HelloWorld program which comes with UDK14 and renamed the HelloWorl

Re: [edk2] [PATCH] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

2015-12-14 Thread Dong, Eric
Hi Cecil, Why not also use mCurrentFormSetGuid and mCurrentHiiHandle for the guid and HiiHandle info? Thanks, Eric -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil Sheng Sent: Monday, December 14, 2015 1:38 PM To: edk2-devel@lists.01.org Cc

[edk2] [PATCH] ArmPlatformPkg/Sec: fix return_from_exception code and comment

2015-12-14 Thread ard
The return_from_exception implementation in Sec/Helper.S (the GCC version) deviates from the RVCT version, in a way that suggests that both may have been broken at some point, and that they weren't fixed in the same way nor at the same time. So bring the GCC version in line with the RVCT version,

Re: [edk2] [Patch] NetworkPkg: Remove a CopyMem to speed up the HTTP boot download.

2015-12-14 Thread Zhang, Lubo
Looks good to me. Reviewed-by: Zhang Lubo -Original Message- From: Fu, Siyuan Sent: Friday, December 11, 2015 10:17 AM To: edk2-de...@ml01.01.org Cc: Zhang, Lubo; Wu, Jiaxin Subject: [Patch] NetworkPkg: Remove a CopyMem to speed up the HTTP boot download. This patch updates the HTTP