Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR

2016-02-17 Thread Laszlo Ersek
On 02/18/16 07:42, Ruiyu Ni wrote: > UEFI Spec 2.3.1.D Section 9.3.5.1 says Partitions are numbered > according to their entry in their respective partition table, > starting with 1. > Update the code for MBR partition to follow this rule. > > Contributed-under: TianoCore Contribution Agreement 1.

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread Subramanian, Sriram (EG Servers Platform SW)
The IP4_CONFIG2 and IP6_CONFIG protocols need to know the current policy to decide if they need to do something during their DBStart (such as initiating a DHCPv4/v6 if policy is set so). It is not necessary for the platform to have a per-NIC interface policy, or the platform may choose to set po

Re: [edk2] [Patch 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-17 Thread Ni, Ruiyu
Ben, I just had a look at your changes. Nice feeling that our codes are quite similar, except yours are in a separate function. I thought about separating it to a sub function but later didn't do that because this sub function is only called once and the logic after all is quite simple:) Can you

Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR

2016-02-17 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Thursday, February 18, 2016 14:43 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/Partition: Use proper partition number for MBR UEFI Spec 2.3.1.D Section 9.3.5.1 says Partitions are numb

[edk2] [Patch] MdeModulePkg/Partition: Use proper partition number for MBR

2016-02-17 Thread Ruiyu Ni
UEFI Spec 2.3.1.D Section 9.3.5.1 says Partitions are numbered according to their entry in their respective partition table, starting with 1. Update the code for MBR partition to follow this rule. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian ---

Re: [edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

2016-02-17 Thread Ye, Ting
Looks good to me. Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Thursday, February 18, 2016 12:33 AM To: edk2-devel@lists.01.org; Ye, Ting Subject: [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f OpenSSL has released version 1.0.2f with two security fix

[edk2] [PATCH] ShellPkg: Fix the last command in a script doesn't work.

2016-02-17 Thread Qiu Shumin
When the last line in a script file is not an empty line the Shell will not execute the command in the last line. The patch refine the logic in function 'ShellFileHandleReturnLine' and fix the issue. Cc: Qiu Shumin Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-o

Re: [edk2] [PATCH v2] BaseTools: LzmaCompress: fix gcc-6 warning "misleading-indentation"

2016-02-17 Thread Laszlo Ersek
On 02/18/16 02:22, Gao, Liming wrote: > Reviewed-by: Liming Gao Thanks guys; commit 6cc7ada465a7. Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 18, 2016 3:18 AM > To: edk2-devel-01 > Cc: Justen, Jordan L ; Cole Robinson > ; Gao

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Andrew Fish
> On Feb 17, 2016, at 6:50 PM, Dong, Eric wrote: > > Hi All, > > Thanks for your comments. I add my explanation below: > > Only hook ReadyToBoot event is not enough. Different drivers may hook this > event and some may update string package in their callback function. The > order to call the

Re: [edk2] [Patch 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-17 Thread Benjamin Herrenschmidt
On Thu, 2016-02-18 at 10:33 +0800, Ruiyu Ni wrote: > Some platform doesn't use CPU(HOST)/Device 1:1 mapping for PCI Bus. > But PCI IO doesn't have interface to tell caller (device driver) > whether the address returned by GetBarAttributes() is HOST address > or device address. > UEFI Spec 2.6 addre

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Tim Lewis
Star -- I think that would work. The copy would have to be by GUID/token number/SKU (for DynamicEx) and token number/SKU (for Dynamic) The downside would be that the PEI copy would have priority, even if the DXE copy were newer. Tim -Original Message- From: Zeng, Star [mailto:star.z..

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Dong, Eric
Correct one error in former mail, the extra data size cost is the runtime memory cost instead of bios flash data cost. Thanks, Eric > -Original Message- > From: Dong, Eric > Sent: Thursday, February 18, 2016 10:51 AM > To: El-Haj-Mahmoud, Samer; Andrew Fish; Brian J. Johnson > Cc: Bi, Da

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-02-17 Thread Dong, Eric
Hi All, Thanks for your comments. I add my explanation below: Only hook ReadyToBoot event is not enough. Different drivers may hook this event and some may update string package in their callback function. The order to call these callback functions is random, so only hook this event may miss s

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Zeng, Star
Could we let PEI PCD database includes all PCDs' information used in PEI phase and DXE PCD database includes all PCDs' information (include PCDs used by both PEI and DXE) used in DXE phase. DXE PCD driver is to sync the value of PCDs used by both PEI and DXE. Thanks, Star -Original Message--

[edk2] [Patch 2/2] MdeModuelPkg/PciBus: Return AddrTranslationOffset in GetBarAttributes

2016-02-17 Thread Ruiyu Ni
Some platform doesn't use CPU(HOST)/Device 1:1 mapping for PCI Bus. But PCI IO doesn't have interface to tell caller (device driver) whether the address returned by GetBarAttributes() is HOST address or device address. UEFI Spec 2.6 addresses this issue by clarifying the address returned is HOST ad

[edk2] [Patch 0/2] Return AddrTranslationOffset in GetBarAttributes

2016-02-17 Thread Ruiyu Ni
Some platform doesn't use CPU(HOST)/Device 1:1 mapping for PCI Bus. But PCI IO doesn't have interface to tell caller (device driver) whether the address returned by GetBarAttributes() is HOST address or device address. UEFI Spec 2.6 addresses this issue by clarifying the address returned is HOST ad

[edk2] [Patch 1/2] MdeModulePkg/PciBus: Refine to reduce code lines.

2016-02-17 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian Cc: Jeff Fan --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 70 -- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c

Re: [edk2] [Patch] BaseTools/VolInfo: add some generic options

2016-02-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, February 17, 2016 6:33 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools/VolInfo: add some generic options The Help information

Re: [edk2] [PATCH v2 1/2] ShellPkg/UefiDpLib: Refine the code of locating all handles in DpTrace.c.

2016-02-17 Thread Zeng, Star
On 2016/2/15 17:49, Zeng, Star wrote: On 2016/2/15 17:07, Cinnamon Shia wrote: Replace gBS->LocateHandle with gBS->LocateHandleBuffer Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- ShellPkg/Library/UefiDpLib/DpTrace.c | 40 ---

Re: [edk2] [PATCH v2 2/2] PerformancePkg/Dp_App: Refine the code of locating all handles in DpTrace.c.

2016-02-17 Thread Zeng, Star
On 2016/2/15 17:49, Zeng, Star wrote: On 2016/2/15 17:07, Cinnamon Shia wrote: Replace gBS->LocateHandle with gBS->LocateHandleBuffer Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- PerformancePkg/Dp_App/DpTrace.c | 40 +---

Re: [edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

2016-02-17 Thread Gao, Liming
Andrew: This is great information. I will take look LoadToolDefFile first, then check parsing logic in C #include file. Thanks Liming -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, February 18, 2016 12:03 AM To: Gao, Liming Cc: edk2-devel@lists.01.o

Re: [edk2] [PATCH v2] BaseTools: LzmaCompress: fix gcc-6 warning "misleading-indentation"

2016-02-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, February 18, 2016 3:18 AM To: edk2-devel-01 Cc: Justen, Jordan L ; Cole Robinson ; Gao, Liming ; Zhu, Yonghong Subject: [PATCH v2] BaseTools: LzmaCompress: fix gcc-6 warning "mis

[edk2] [PATCH 7/7] CryptoPkg: Abuse internal headers to make OpenSSL HEAD build work

2016-02-17 Thread David Woodhouse
More stuff got hidden. Some of this is tolerable. Other bits are horrid, but given that we expose *requires* that we know the size of the data structure, it's hard to see how we can avoid it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woodhouse ---  CryptoPkg/Lib

[edk2] [PATCH 2/7] CryptoPkg/OpensslLib: Include complete copy of opensslconf.h

2016-02-17 Thread David Woodhouse
This can be an auto-generated file, and it *isn't* in the OpenSSL git tree; it's only in the generated tarballs. So rather than including it in our OpenSSL patch, just have the user copy it into place. This makes it easier to manage changes, and is a step towards better integration. Contributed-u

[edk2] [PATCH 4/7] CryptoPkg/OpensslLib: Automatically configure OpenSSL and generate file list

2016-02-17 Thread David Woodhouse
With the patches which are going into upstream OpenSSL, we are able to run the standard Configure script and import the result into the EDK II source repository for others to build natively. The opensslconf.h file and the list of files in OpensslLib.inf don't need to be managed manually. Contribut

[edk2] [PATCH 1/7] CryptoPkg: Use OpenSSL include directory directly

2016-02-17 Thread David Woodhouse
In OpenSSL 1.1, all the public header files will reside directly in the include/openssl/ directory of the source tree, rather than being symbolic links. So we can just add that directory to our include path and not have to worry about copying files around. In fact, that *already* works on POSIX-co

[edk2] EDK2 vs. OpenSSL HEAD update

2016-02-17 Thread David Woodhouse
As of today, there are only two remaining fixes that still need to be merged into OpenSSL HEAD to allow building for EDK2 out of the box. These are RT4309, a trivial one-liner to provide a correct definition of the PRIu64 macro for the EDK2 environment, and RT4175 to fix the regression (also intro

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread Kinney, Michael D
Samer, A platform driver can be implemented to set the policy without defining PCDs in the MdeModulePkg or NetworkPkg. Instead, a platform package can choose to define PCDs and potentially use those PCD values to set policy in calls to the EFI_IP4_CONFIG2_POLICY or EFI_IP6_CONFIG_POLICY. Or it

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Yao, Jiewen
Thanks to catch typo. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, February 17, 2016 11:21 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Gao, Liming Subject: Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE On 02/17

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread El-Haj-Mahmoud, Samer
1) Yes you could... that is one implementation choice. There are cases where you need to start multiple adapters, just for inventory/other management tasks, and you do not want all of them to default to DHCP/automatic 2) Yes a platform driver can set the policy through the PCDs. I thought this

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Tim Lewis
I would point out that in systems where PEI FVs are updated independently of DXE FVs, we use 100% DynamicEx, because we try to make no assumptions. Basically, the PEIMs in the PEI FV are considered "binary builds" per Mike's classification. Tim -Original Message- From: Kinney, Michael

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread Kinney, Michael D
Hi Samer, 1) If there are a large number of adapters, can you choose to only start the ones needed to boot? 2) Can't a platform driver set the policy needed for each NIC that is required to boot? Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] O

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread El-Haj-Mahmoud, Samer
I believe the PCDs are just to let the core drivers select the default behavior (not full configuration) of automatic/DHCP vs. Static. Today, the core drivers hard-code the default behavior to DHCP/automatic, and that is not ideal in server platforms that may have a large number of adapters.

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

2016-02-17 Thread Leif Lindholm
On Tue, Feb 16, 2016 at 06:51:45PM +0100, Laszlo Ersek wrote: > On 02/16/16 17:36, Jeremy Linton wrote: > > |Not wishing to influence the discussion, just out of curiosity: Jeremy > > |mentions "numerous other BlockIo protocol providers in edk2 bounce IO > > |operations rather than simply allowing

Re: [edk2] [PATCH v2] BaseTools: LzmaCompress: fix gcc-6 warning "misleading-indentation"

2016-02-17 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-02-17 11:17:35, Laszlo Ersek wrote: > The way the first use of the "_maxMode" variable is commented out (i.e., > together with the enclosing "if" statement) in GetOptimum() triggers the > "misleading-indentation" warning that is new in gcc-6.0, for the block of

[edk2] [PATCH v2] BaseTools: LzmaCompress: fix gcc-6 warning "misleading-indentation"

2016-02-17 Thread Laszlo Ersek
The way the first use of the "_maxMode" variable is commented out (i.e., together with the enclosing "if" statement) in GetOptimum() triggers the "misleading-indentation" warning that is new in gcc-6.0, for the block of code that originally depended on the "if" statement. Gcc believes (mistakenly)

Re: [edk2] [PATCH v1 1/1] StdLib/BsdSocketLib: Fix minor memory leak.

2016-02-17 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daryl McDaniel > Sent: Tuesday, February 16, 2016 12:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Colin King > > Subject: [edk2] [PATCH v1 1/1] StdLib/Bs

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 18:40, Laszlo Ersek wrote: > On 02/17/16 18:23, Ard Biesheuvel wrote: >> On 17 February 2016 at 18:07, Graeme Gregory >> wrote: >>> >>> >>> On 17/02/2016 16:04, Laszlo Ersek wrote: On 02/17/16 16:34, Ard Biesheuvel wrote: > > On 17 February 2016 at 16:11,

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Laszlo Ersek
On 02/17/16 18:23, Ard Biesheuvel wrote: > On 17 February 2016 at 18:07, Graeme Gregory > wrote: >> >> >> On 17/02/2016 16:04, Laszlo Ersek wrote: >>> >>> On 02/17/16 16:34, Ard Biesheuvel wrote: On 17 February 2016 at 16:11, Laszlo Ersek wrote: > > On 02/17/16 15:48, Ard Biesh

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Laszlo Ersek
On 02/17/16 18:07, Graeme Gregory wrote: > > > On 17/02/2016 16:04, Laszlo Ersek wrote: >> On 02/17/16 16:34, Ard Biesheuvel wrote: >>> On 17 February 2016 at 16:11, Laszlo Ersek wrote: On 02/17/16 15:48, Ard Biesheuvel wrote: > AARCH64 systems never require compatibility with legacy AC

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

2016-02-17 Thread Kinney, Michael D
Jiaxin, If a platform module can set the policy for each network interface, then why do we need to add PCDs? Thanks, Mike From: Wu, Jiaxin Sent: Tuesday, February 16, 2016 6:30 PM To: Kinney, Michael D ; Subramanian, Sriram (EG Servers Platform SW) ; El-Haj-Mahmoud, Samer ; Hegde, Nagaraj P

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Kinney, Michael D
Bhupesh, Yes, this API internally does an allocation larger than requested to guarantee that a buffer of the requested size and alignment is guaranteed to be in the allocated buffer. It then frees the extra pages, so upon a successful allocation, the memory map only shows the actually aligned

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 18:07, Graeme Gregory wrote: > > > On 17/02/2016 16:04, Laszlo Ersek wrote: >> >> On 02/17/16 16:34, Ard Biesheuvel wrote: >>> >>> On 17 February 2016 at 16:11, Laszlo Ersek wrote: On 02/17/16 15:48, Ard Biesheuvel wrote: > > AARCH64 systems never require

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Kinney, Michael D
Star, I agree if PCDs are added to PEI Database that are also present in DXE Database, there could be a conflict. There are several cases we need to consider to support separate update of PEI and DXE databases: 1) Add one or more PCDs to PEI Database that are not used in DXE Phase 2) Add one o

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Kinney, Michael D
Liming, Adding error message/assert when PEI and DXE databases are not compatible is a good idea. But I also think we should do everything we can to prevent PEI and DXE databases from ever being incompatible. Especially if 100% of the PCDs used are accessed as DynamixEx. Thanks, Mike > ---

[edk2] [Patch] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2f

2016-02-17 Thread Qin Long
OpenSSL has released version 1.0.2f with two security fixes (http://www.openssl.org/news/secadv/20160128.txt) at 28-Jan-2016. Upgrade the supported OpenSSL version in CryptoPkg/OpensslLib to catch the latest release 1.0.2f. (NOTE: The patch file was just re-generated, and no new source chang

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

2016-02-17 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, February 15, 2016 6:07 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [edk2] [PATCH] ShellPkg: Do NULL poi

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Laszlo Ersek
On 02/17/16 16:34, Ard Biesheuvel wrote: > On 17 February 2016 at 16:11, Laszlo Ersek wrote: >> On 02/17/16 15:48, Ard Biesheuvel wrote: >>> AARCH64 systems never require compatibility with legacy ACPI OSes, and >>> may not have any 32-bit addressable system RAM. To support ACPI on these >>> syste

Re: [edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

2016-02-17 Thread Andrew Fish
> On Feb 17, 2016, at 6:34 AM, Gao, Liming wrote: > > Andrew: > Thanks for this report. Tottime is second or microsecond? If LoadToolDefFile > is called only once, how much performance can be saved? > Liming, Python cProfile produces data in the pstats format and time is in seconds. So it

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 16:11, Laszlo Ersek wrote: > On 02/17/16 15:48, Ard Biesheuvel wrote: >> AARCH64 systems never require compatibility with legacy ACPI OSes, and >> may not have any 32-bit addressable system RAM. To support ACPI on these >> systems, we need to be able to relax the 4 GB alloca

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Laszlo Ersek
On 02/17/16 13:38, Jiewen Yao wrote: > UEFI2.6 specification does not recommend to use BIT0 > attribute for PropertiesTable, so we change default > value to FALSE. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" > Cc: "Gao, Liming" > --- > MdeModulePkg

Re: [edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Laszlo Ersek
On 02/17/16 15:48, Ard Biesheuvel wrote: > AARCH64 systems never require compatibility with legacy ACPI OSes, and > may not have any 32-bit addressable system RAM. To support ACPI on these > systems, we need to be able to relax the 4 GB allocation restriction. > > So add a PCD PcdAcpiAllocateTable

Re: [edk2] PCD Local Token Numbers in PEI/DXE

2016-02-17 Thread Gao, Liming
Tim: I think we can enhance PCD driver and Build tool to do this check. If the mismatch happens, PcdDxe driver will report error message, and not install PCD protocol. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis Sen

[edk2] [RFC PATCH] MdeModulePkg: AcpiTableDxe: make 4 GB table allocation limit optional

2016-02-17 Thread Ard Biesheuvel
AARCH64 systems never require compatibility with legacy ACPI OSes, and may not have any 32-bit addressable system RAM. To support ACPI on these systems, we need to be able to relax the 4 GB allocation restriction. So add a PCD PcdAcpiAllocateTablesBelow4GB defaulting to TRUE, and wire it up to the

Re: [edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

2016-02-17 Thread Gao, Liming
Andrew: Thanks for this report. Tottime is second or microsecond? If LoadToolDefFile is called only once, how much performance can be saved? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Tuesday, February 16, 2

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Yao, Jiewen Sent: Wednesday, February 17, 2016 8:39 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen ; Gao, Liming Subject: [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE UEFI2.6 specification does not recommend to u

Re: [edk2] [Patch] BaseTools: report an error message when failed to start build command

2016-02-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, February 17, 2016 6:33 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: report an error message when failed to start build com

Re: [edk2] [Patch] BaseTools/GenFw: Fix a bug for GCC build

2016-02-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, February 17, 2016 6:33 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools/GenFw: Fix a bug for GCC build current GCC build report

Re: [edk2] [Patch] MdeModulePkg: Update PeiCore dispatcher to handle PEIM and PEI_CORE only

2016-02-17 Thread Cohen, Eugene
> When PcdShadowPeimOnBoot is FALSE, they are not copied to > memory and > execute from their original locations. Here, this policy should only > apply for PEIM and PEI_CORE, not for other file type, such as > DXE_CORE. Tested-by: Eugene Cohen Sorry for the delay in testing this - thanks for the

[edk2] [PATCH] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-02-17 Thread Cohen, Eugene
Instead of only handling SEC Core or PEI Core instances in the outer FV, the GenFv tool will now recurse into FV image FFS files to look for instances in encapsulated FVs so the vector area can be updated appropriately. Tested on ARM and AArch64 platforms. Contributed-under: TianoCore Contributio

Re: [edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 13:38, Jiewen Yao wrote: > UEFI2.6 specification does not recommend to use BIT0 > attribute for PropertiesTable, so we change default > value to FALSE. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" > Cc: "Gao, Liming" Reviewed-

[edk2] [patch] MdePkg: Change PcdPropertiesTableEnable default value to FALSE

2016-02-17 Thread Jiewen Yao
UEFI2.6 specification does not recommend to use BIT0 attribute for PropertiesTable, so we change default value to FALSE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Gao, Liming" --- MdeModulePkg/MdeModulePkg.dec | 4 +++- 1 file changed, 3 insertion

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-17 Thread Ard Biesheuvel
On 17 February 2016 at 13:22, Yao, Jiewen wrote: > I collected Intel internal feedback. > > 1) We observed the shipping production still using this Properties Table, and > UEFI 2.6 specification still keeps the text. So we want to keep code to give > production a way to enable this feature. > 2

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-17 Thread Yao, Jiewen
I collected Intel internal feedback. 1) We observed the shipping production still using this Properties Table, and UEFI 2.6 specification still keeps the text. So we want to keep code to give production a way to enable this feature. 2) Since UEFI specification marks this as "not recommended", w

[edk2] [Patch] BaseTools/Trim: Fix the bug for stripping when no line directive in file

2016-02-17 Thread Yonghong Zhu
when no line directive in file, the tool still need to strip the typedef statement (eg: typedef struct, typedef union ..). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Trim/Trim.py | 37 +--- 1 fil

[edk2] [Patch] BaseTools/VolInfo: add some generic options

2016-02-17 Thread Yonghong Zhu
The Help information provided by VolInfo does not follow the EDK II Tools Design doc, so this patch update the help text and add the generic options: -d, -v, -q, -s. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/VolInfo/VolInfo.c | 141

[edk2] [Patch] BaseTools: report an error message when failed to start build command

2016-02-17 Thread Yonghong Zhu
when build.py was failing to build packages but was not providing any error message except for “Failed to start command.” this patch provide the error message. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/build.py | 3 ++-

[edk2] [Patch] BaseTools/GenFw: Fix a bug for GCC build

2016-02-17 Thread Yonghong Zhu
current GCC build report error: 'for' loop initial declarations are only allowed in C99 or C11 mode, the patch fix this failure. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/GenFw/Elf32Convert.c | 3 ++- BaseTools/Source/C/GenFw/Elf64

[edk2] [patch] MdeModulePkg: Refine the code in BootMaintenanceManagerUiLib

2016-02-17 Thread Dandan Bi
Refine the code in function Var_UpdateDriverOption and Var_UpdateBootOption, use the existed API(EfiBootManagerInitializeLoadOption and EfiBootManagerAddLoadOptionVariable) supplied by UefiBootManagerLib to replace the same logic in the two functions. And remove the useless code. Cc: Liming Gao C

Re: [edk2] [patch 0/2] Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

2016-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, February 16, 2016 7:55 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subject: [edk2] [patch 0/2] Add new HII action type >

Re: [edk2] [PATCH] BaseTools: LzmaCompress: eliminate _maxMode and bogus indentation

2016-02-17 Thread Laszlo Ersek
On 02/16/16 21:47, Jordan Justen wrote: > On 2016-02-15 10:47:28, Laszlo Ersek wrote: >> The "_maxMode" variable doesn't exist in edk2's variant of LzmaCompress, >> but the way one of the old uses of the variable is commented out (i.e., >> together with the enclosing "if" statement) triggers the >>

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: Define a general function to create DNS QName

2016-02-17 Thread Ye, Ting
Reviewed-by: Ye Ting Thanks, Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, February 17, 2016 2:52 PM To: edk2-devel@lists.01.org Cc: Hegde Nagaraj P ; El-Haj-Mahmoud Samer ; Ye, Ting ; Fu, Siyuan Subject: [PATCH v3 1/2] MdeModulePkg: Define a general function to create DN

Re: [edk2] [Patch 3/3] BaseTools/GenFw: Correct datatypes in diagnostic messages and check for string termination

2016-02-17 Thread Zhu, Yonghong
Thanks for report. I will fix it soon. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, February 17, 2016 4:28 PM To: Gao, Liming Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 3/

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Andrew Fish
> On Feb 17, 2016, at 12:28 AM, Bhupesh Sharma wrote: > >> From: af...@apple.com [mailto:af...@apple.com] >> Sent: Wednesday, February 17, 2016 1:34 PM > >>> On Feb 16, 2016, at 11:52 PM, Bhupesh Sharma >> wrote: >>> >>> Hi Experts, >>> >>> We are using the 'AllocateAlignedPages' function (i

Re: [edk2] [Patch 3/3] BaseTools/GenFw: Correct datatypes in diagnostic messages and check for string termination

2016-02-17 Thread Ard Biesheuvel
On 1 February 2016 at 03:10, Liming Gao wrote: > From: Michael LeMay > > This patch revises multiple diagnostic messages to use correct > datatypes. It also checks that a symbol name that is about to be used > in a diagnostic message is terminated by a null character within the > contents of the

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Bhupesh Sharma
> From: af...@apple.com [mailto:af...@apple.com] > Sent: Wednesday, February 17, 2016 1:34 PM > > On Feb 16, 2016, at 11:52 PM, Bhupesh Sharma > wrote: > > > > Hi Experts, > > > > We are using the 'AllocateAlignedPages' function (inside > > 'MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocation

Re: [edk2] [PATCH] BaseTools/GenFw: skip relocation entry if there is an error

2016-02-17 Thread Ronny Chevalier
It is now obsolete with commit 621bb723a4e00cb93e8a94c6126de4976dde1d9e On Mon, Feb 15, 2016 at 10:25 AM, Gao, Liming wrote: > Reviewed-by: Liming Gao > > -Original Message- > From: Ronny Chevalier [mailto:chevalier.ro...@gmail.com] > Sent: Friday, February 12, 2016 10:26 PM > To: edk2-d

Re: [edk2] Allocating Aligned Pages

2016-02-17 Thread Andrew Fish
> On Feb 16, 2016, at 11:52 PM, Bhupesh Sharma wrote: > > Hi Experts, > > We are using the 'AllocateAlignedPages' function (inside > 'MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c') > to allocate 512MB aligned memory chunk in a DXE driver. > > However the memory chunk which get