[edk2] [Patch] Makefile: Enable arch X64 build

This patch is used to support arch X64 build. The ARCH can be either IA32 or X64. Adapt these two directives to your need. Cc: Fu Siyuan Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- Makefile | 25 ++--- 1 file changed,

[edk2] [PATCH v2] SecurityPkg: Fix TPM 1.2 SelfTest command bug.

Specify command response length. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- Changes in v2: Fix patch message. --- SecurityPkg/Library/Tpm12CommandLib/Tpm12SelfTest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SecurityPkg/Library/Tpm12Comman

Re: [edk2] Update UDK2014 to UDK2015 leads to setup page slow

HI Liming, Sorry, Set gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength to 0 with PcdsFixedAtBuild can also solve this issue, previous test result is wrong. At 2016-03-09 15:21:37, "wang xiaofeng" wrote: >Hi Liming, >Thanks for your helpful information! Set > gEfiMdePkgTokenSp

Re: [edk2] Update UDK2014 to UDK2015 leads to setup page slow

Hi Liming, Thanks for your helpful information! Set gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength to 0 cannot solve this issue, but I tried to use release mode and the issue disappears. This issue only occurs in debug mode. My plan is waiting your fix for the issue you found. Most prob

[edk2] [PATCH] SecurityPkg: Fix TPM 1.2 SelfTest command bug. Specify command response length.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- SecurityPkg/Library/Tpm12CommandLib/Tpm12SelfTest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SecurityPkg/Library/Tpm12CommandLib/Tpm12SelfTest.c b/SecurityPkg/Library/Tpm12CommandLib/Tpm12SelfTest.c

[edk2] [patch] NetworkPkg: Refine the code of shell app under networkPkg.

refine the code of ifconfig6 and ping6 application. Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 5 + NetworkPkg/Application/IfConfig6/IfConfig6.h | 5 - NetworkPkg/Appli

Re: [edk2] [Patch] BaseTools: Change source files to DOS format.

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, March 09, 2016 10:16 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Change so

Re: [edk2] EDK2 Setup & Configuration Issue

Looks like that did.Jim S. On Tuesday, March 8, 2016 4:43 PM, "Carsey, Jaben" wrote: #yiv2666485428 #yiv2666485428 -- _filtered #yiv2666485428 {font-family:Helvetica;panose-1:2 11 6 4 2 2 2 2 2 4;} _filtered #yiv2666485428 {panose-1:2 4 5 3 5 4 6 3 2 4;} _filtered #yiv2666485428 {fo

[edk2] [patch] SecurityPkg: Add Tpm2 prefix to lib to avoid conflict.

Tpm2Ptp.c is library, but it miss Tpm2 prefix for IsPtpPresence() and GetPtpInterface(). There might be risk as name symbol conflict. This patch adds Tpm2 prefix for them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" Tested-by: "Wu, Hao

Re: [edk2] [patch] MdeModulePkg: Add missing pcd description to MdeModulePkg.uni

Reviewed-by: Qiu Shumin -Original Message- From: Bi, Dandan Sent: Wednesday, March 09, 2016 12:37 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Dong, Eric Subject: [patch] MdeModulePkg: Add missing pcd description to MdeModulePkg.uni Since PcdHiiOsRuntimeSupport has added in the MdeMo

[edk2] [patch] MdeModulePkg: Add missing pcd description to MdeModulePkg.uni

Since PcdHiiOsRuntimeSupport has added in the MdeModulePkg.dec file, now add the usage information in the uni file. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/MdeModulePkg.uni | 8 1 file changed, 8 in

Re: [edk2] Update UDK2014 to UDK2015 leads to setup page slow

Xiaofeng: We find the similar issue in DEBUG tip when DEBUG log is enabled. AllocatePool() service will be slower than before. The updated memory allocation algorithm brings the long free pool list and cause AllocatePool() service slow. I am still investigating it. The temp solution is to disa

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check

Reviewed-by: Michael Kinney > -Original Message- > From: Fan, Jeff > Sent: Tuesday, March 8, 2016 6:17 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Kinney, Michael D > > Subject: [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check > > gMaximumBasicFunction is s

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Add check for gMaximumBasicFunction

Reviewed-by: Michael Kinney > -Original Message- > From: Fan, Jeff > Sent: Tuesday, March 8, 2016 6:17 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Kinney, Michael D > > Subject: [Patch] UefiCpuPkg/Application/Cpuid: Add check for > gMaximumBasicFunction > > Add check for gMax

[edk2] [Patch 21/21] UefiCpuPkg/Include: Add top level MSR include file

Add top level MSR include file that includes the Architecural MSR include file and all family specific MSR files from the Msr subdirectory Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR). Cc: Jeff Fan Cc: Jiewen

[edk2] [Patch 19/21] UefiCpuPkg/Include: Add P6 MSR include file

Add P6 MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-19. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiCpuPkg

[edk2] [Patch 20/21] UefiCpuPkg/Include: Add Pentium MSR include file

Add Pentium MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-20. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiC

[edk2] [Patch 03/21] UefiCpuPkg/Include: Add Atom MSR include file

Add Atom MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-3. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiCpuPk

[edk2] [Patch 13/21] UefiCpuPkg/Include: Add Xeon Processor D MSR include file

Add Xeon Processor D MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-13. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney -

[edk2] [Patch 06/21] UefiCpuPkg/Include: Add Xeon 5600 MSR include file

Add Xeon 5600 MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-6. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uefi

[edk2] [Patch 10/21] UefiCpuPkg/Include: Add Haswell MSR include file

Add Haswell MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-10. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiC

[edk2] [Patch 15/21] UefiCpuPkg/Include: Add Xeon Phi MSR include file

Add Xeon Phi MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-15. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uefi

[edk2] [Patch 08/21] UefiCpuPkg/Include: Add Sandy Bridge MSR include file

Add Sandy Bridge MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-8. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- U

[edk2] [Patch 12/21] UefiCpuPkg/Include: Add Broadwell MSR include file

Add Broadwell MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-12. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uef

[edk2] [Patch 14/21] UefiCpuPkg/Include: Add Skylake MSR include file

Add Skylake MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-14. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiC

[edk2] [Patch 16/21] UefiCpuPkg/Include: Add Pentium 4 MSR include file

Add Pentium 4 MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-16. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uef

[edk2] [Patch 09/21] UefiCpuPkg/Include: Add Ivy Bridge MSR include file

Add Ivy Bridge MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-9. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uef

[edk2] [Patch 18/21] UefiCpuPkg/Include: Add Pentium M MSR include file

Add Pentium M MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-18. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uef

[edk2] [Patch 17/21] UefiCpuPkg/Include: Add Core Solo/Duo MSR include file

Add Core Solo/Duo MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-17. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney ---

[edk2] [Patch 07/21] UefiCpuPkg/Include: Add Xeon E7 MSR include file

Add Xeon E7 MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-7. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiCp

[edk2] [Patch 02/21] UefiCpuPkg/Include: Add Core 2 MSR include file

Add Core 2 MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-2. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiCpu

[edk2] [Patch 00/21] UefiCpuPkg/Include: Add MSR include files

Add include files for Architectural MSRs and family specific MSRs described in section 35.1 to 35.20 of the Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR). These files can also be pulled and reviewd from: h

[edk2] [Patch 04/21] UefiCpuPkg/Include: Add Silvermont MSR include file

Add Silvermont MSRs from: Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3, December 2015, Chapter 35 Model-Specific-Registers (MSR), Section 35-4. Cc: Jeff Fan Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Uef

[edk2] Update UDK2014 to UDK2015 leads to setup page slow

Hi Edk2 developers, After upate to UDK2015 from UDk2014, the Uiapp setup shows very slow. the following is our issue and debug information. Anyone meet similar issue before? Issue symptom: 1, System draw the Front Page cost about 2 second. We can see the frame/ menu block/ help block draw

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check

Reviewed-by: Qiu Shumin -Original Message- From: Fan, Jeff Sent: Wednesday, March 09, 2016 10:17 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Kinney, Michael D Subject: [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check gMaximumBasicFunction is set to CPUID_SIGNATURE

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Add check for gMaximumBasicFunction

Reviewed-by: Qiu Shumin -Original Message- From: Fan, Jeff Sent: Wednesday, March 09, 2016 10:17 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Kinney, Michael D Subject: [Patch] UefiCpuPkg/Application/Cpuid: Add check for gMaximumBasicFunction Add check for gMaximumBasicFunction in C

[edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check

gMaximumBasicFunction is set to CPUID_SIGNATURE as below, so removed the compare code. UINT32 gMaximumBasicFunction = CPUID_SIGNATURE; Cc: Qiu Shumin Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Application/Cpuid/Cpuid.c |

[edk2] [Patch] UefiCpuPkg/Application/Cpuid: Add check for gMaximumBasicFunction

Add check for gMaximumBasicFunction in CpuidVersionInfo () back. Cc: Qiu Shumin Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Application/Cpuid/Cpuid.c | 4 1 file changed, 4 insertions(+) diff --git a/UefiCpuPkg/Applica

[edk2] [Patch] BaseTools: Change source files to DOS format.

From: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/C/BootSectImage/bootsectimage.c | 14 +++--- BaseTools/Source/C/EfiLdrImage/EfiLdrImage.c | 18 +- BaseTools/Source/C/Split/Split.c

Re: [edk2] [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, March 9, 2016 8:59 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Zhang, Lubo > Subject: [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue > > This issue is caused by the string token ID for

Re: [edk2] [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue

Reviewed-by: Zhang, Lubo -Original Message- From: Wu, Jiaxin Sent: Wednesday, March 09, 2016 8:59 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Zhang, Lubo Subject: [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue This issue is caused by the string token ID for help messag

Re: [edk2] [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, March 09, 2016 8:59 AM > To: edk2-devel@lists.01.org > Cc: Zhang, Lubo; Fu, Siyuan > Subject: [edk2] [Patch] NetworkPkg: Fix IpsecConfig GCC

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 9 March 2016 at 07:53, David Woodhouse wrote: > On Wed, 2016-03-09 at 07:49 +0700, Ard Biesheuvel wrote: >> >> I agree that they should be allowed, but i share the concern that >> merging puts the burden of fixing up conflicts on the maintainer >> rather than the contributor, who is arguably in

[edk2] [Patch] NetworkPkg: Fix IpsecConfig GCC build failure issue

This issue is caused by the string token ID for help message, which is defined in the internal head file. This head file is used for reference more than once. So, multiple definition for the string token ID error will be enrolled. Cc: Fu Siyuan Cc: Zhang Lubo Contributed-under: TianoCore Contrib

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Wed, 2016-03-09 at 07:49 +0700, Ard Biesheuvel wrote: > > I agree that they should be allowed, but i share the concern that > merging puts the burden of fixing up conflicts on the maintainer > rather than the contributor, who is arguably in a worse position to > assess any potential problems on

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 9 March 2016 at 01:17, Laszlo Ersek wrote: > On 03/08/16 19:09, David Woodhouse wrote: >> On Tue, 2016-03-08 at 19:00 +0100, Laszlo Ersek wrote: > >>> Or do you recommend that contributors be *allowed* to email pull >>> requests (alongside their patches), and if they do, their pull requests >>>

Re: [edk2] [PATCH v6] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Reviewed-by: Eric Dong Feng, Please help to check in this code. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cecil > Sheng > Sent: Tuesday, March 08, 2016 3:56 PM > To: edk2-devel@lists.01.org > Cc: Cecil Sheng > Subject:

Re: [edk2] EDK2 Setup & Configuration Issue

BaseTools and Conf should be one directory up I think. From: Jim Slaughter [mailto:jwslau...@yahoo.com] Sent: Tuesday, March 08, 2016 4:19 PM To: Carsey, Jaben ; Gao, Liming ; Tian, Feng ; edk2-devel@lists.01.org Subject: Re: [edk2] EDK2 Setup & Configuration Issue Importance: High Windows Envir

Re: [edk2] EDK2 Setup & Configuration Issue

Windows Environment: edketup: C:\edk2\BaseTools(Windows)>edksetup 'C:\edk2\BaseTools' is not recognized as an internal or external command, operable program or batch file.!!! WARNING !!! CYGWIN_HOME not found, gcc build may not be used !!!C:\edk2\BaseTools(Windows)> A dir of this: C:\edk2\BaseToo

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Wed, 2016-03-09 at 00:05 +0100, Laszlo Ersek wrote: > (1) The submitter is himself/herself responsible for picking up review > tags, and then for posting a final (fully reviewed) PULL that can be > merged without *any* kind of rebase by the pulling maintainer. > > Corollary: since the first sub

Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if necessary

> On Mar 6, 2016, at 11:55 PM, Gao, Liming wrote: > > Andrew: > Now, Build tool will report error message if Conf directory or build > configuration file is not found. It can detect the wrong setting when user > specifies Conf by mistake. > I guess we could add an argument that enable/disa

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 19:09, David Woodhouse wrote: > On Tue, 2016-03-08 at 19:00 +0100, Laszlo Ersek wrote: >> Or do you recommend that contributors be *allowed* to email pull >> requests (alongside their patches), and if they do, their pull requests >> be merged correctly? > > Exactly this. They should b

Re: [edk2] EDK2 Setup & Configuration Issue

Jim, You need to download or build the BaseTools that are used during the build. Have you done that? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jim > Slaughter > Sent: Tuesday, March 08, 2016 2:21 PM > To: Gao, Liming ; Tian, Fen

Re: [edk2] EDK2 Setup & Configuration Issue

Hello Liming: I am confused.I originally downloaded edk2-master and unzipped.This has one of the packages I am interested in building, embeddedpkg. This is where the directory is missing. I have since downloaded 2014 and 2015, all in separate directories, from sourceforge.The file structure look

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> -Original Message- > From: Justen, Jordan L > Sent: Tuesday, March 08, 2016 11:37 AM > To: Carsey, Jaben > Cc: edk2-devel@lists.01.org; Gao, Liming ; Bjorge, Erik > C > Subject: Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support > Python 3 > Importance: High > > On 2016-03-0

Re: [edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

On 03/08/16 21:03, Jordan Justen wrote: > On 2016-03-08 11:44:46, Laszlo Ersek wrote: >> On 03/08/16 20:31, Jordan Justen wrote: >>> On 2016-03-08 03:25:06, Laszlo Ersek wrote: On 03/08/16 04:15, Jordan Justen wrote: > Fixes: https://github.com/tianocore/edk2/issues/63 > Contributed-un

Re: [edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

On 2016-03-08 11:44:46, Laszlo Ersek wrote: > On 03/08/16 20:31, Jordan Justen wrote: > > On 2016-03-08 03:25:06, Laszlo Ersek wrote: > >> On 03/08/16 04:15, Jordan Justen wrote: > >>> Fixes: https://github.com/tianocore/edk2/issues/63 > >>> Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

On 03/08/16 20:31, Jordan Justen wrote: > On 2016-03-08 03:25:06, Laszlo Ersek wrote: >> On 03/08/16 04:15, Jordan Justen wrote: >>> Fixes: https://github.com/tianocore/edk2/issues/63 >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Jordan Justen >>> Cc: Yonghong Zhu

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

On 2016-03-08 06:22:28, Carsey, Jaben wrote: > > > > On Mar 7, 2016, at 7:16 PM, Jordan Justen wrote: > > > > The script is updated to support both python 2.7 and python 3. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jordan Justen > > Cc: Yonghong Zhu >

Re: [edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

On 2016-03-08 03:25:06, Laszlo Ersek wrote: > On 03/08/16 04:15, Jordan Justen wrote: > > Fixes: https://github.com/tianocore/edk2/issues/63 > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jordan Justen > > Cc: Yonghong Zhu > > Cc: Liming Gao > > Cc: Michael Kinney

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 19:09, David Woodhouse wrote: > On Tue, 2016-03-08 at 19:00 +0100, Laszlo Ersek wrote: >> Or do you recommend that contributors be *allowed* to email pull >> requests (alongside their patches), and if they do, their pull requests >> be merged correctly? > > Exactly this. They should b

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Tue, 2016-03-08 at 19:00 +0100, Laszlo Ersek wrote: > It is not about the branch that linus pulls from the subsystem > maintainer. > > It is about the patches that the subsystem maintainer picks up from > emails of individual contributors. > > Let me quote Linus's email back at you: The bette

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 18:30, Jordan Justen wrote: > At the subsystem level, I think even the kernel often relies on rebase > along with format-patch/am to bring in patches rather than merges. My point exactly. > I don't think anyone has ruled out considering using merges once > everyone is more comfortabl

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 18:34, David Woodhouse wrote: > On Tue, 2016-03-08 at 18:24 +0100, Laszlo Ersek wrote: >> Here again I can only point to people who I consider my betters -- are >> you suggesting that the QEMU workflow and the Linux workflow are utterly >> wrong? > > It is not "the Linux workflow". Lin

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Tue, 2016-03-08 at 09:30 -0800, Jordan Justen wrote: > It sounds like the issue was a lack or gap in testing after the > rebase. > > I don't see that possibility going away just because you instead used > merge. Especially if you consider resolving merge conflicts or other > subtle errors that

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Tue, 2016-03-08 at 18:24 +0100, Laszlo Ersek wrote: > Here again I can only point to people who I consider my betters -- are > you suggesting that the QEMU workflow and the Linux workflow are utterly > wrong? It is not "the Linux workflow". Linus will *eat* you if you rebase trees which you ask

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 2016-03-08 04:12:32, David Woodhouse wrote: > As of yesterday, *all* my patches had been merged into OpenSSL HEAD, in > preparation for the OpenSSL 1.1 Beta 1 release this week. > > There is only one more patch outstanding in my OpenSSL git tree. > > Do those statements seem self-contradictory

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 17:23, David Woodhouse wrote: > On Tue, 2016-03-08 at 14:44 +0100, Laszlo Ersek wrote: >> >> Using git is one thing, designing a workflow is another thing. Many >> workflows exist. Some of them are not exclusively merge based (QEMU, >> various subsystems of Linux), where sub-maintainers

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Tue, 2016-03-08 at 14:44 +0100, Laszlo Ersek wrote: > > Using git is one thing, designing a workflow is another thing. Many > workflows exist. Some of them are not exclusively merge based (QEMU, > various subsystems of Linux), where sub-maintainers rebase and > occasionally rework patches that

Re: [edk2] [PATCH v2 0/6] OvmfPkg: enable PCIe on Q35

On 03/08/16 16:26, Gabriel L. Somlo wrote: > On Tue, Mar 08, 2016 at 03:19:58PM +0100, Laszlo Ersek wrote: >> Version 2 of . >> >> News for v2: following Gerd's advice, I inserted a new patch (as #2), >> and reworked parts of patch #3. The ch

Re: [edk2] [PATCH v2 0/6] OvmfPkg: enable PCIe on Q35

On Tue, Mar 08, 2016 at 03:19:58PM +0100, Laszlo Ersek wrote: > Version 2 of . > > News for v2: following Gerd's advice, I inserted a new patch (as #2), > and reworked parts of patch #3. The changes are marked in detail on > those patches. >

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> On Mar 7, 2016, at 7:16 PM, Jordan Justen wrote: > > The script is updated to support both python 2.7 and python 3. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > Cc: Yonghong Zhu > Cc: Liming Gao > Cc: Erik Bjorge > --- > BaseTools/Scripts/C

[edk2] [PATCH v2 0/6] OvmfPkg: enable PCIe on Q35

Version 2 of . News for v2: following Gerd's advice, I inserted a new patch (as #2), and reworked parts of patch #3. The changes are marked in detail on those patches. Review & testing feedback: Jordan should please review patches #2 and #3

[edk2] [PATCH v2 6/6] OvmfPkg: PciHostBridgeLib: permit access to the full extended config space

By now OVMF makes MdeModulePkg/Bus/Pci/PciHostBridgeDxe go through MMCONFIG (when running on Q35). Enable the driver to address each B/D/F's config space up to and including offset 0xFFF. Cc: Gabriel Somlo Cc: Gerd Hoffmann Cc: Jordan Justen Cc: Marcel Apfelbaum Cc: Michał Zegan Contributed-u

[edk2] [PATCH v2 5/6] OvmfPkg: match PCI config access to machine type (if not USE_OLD_PCI_HOST)

If USE_OLD_PCI_HOST is FALSE, then we switch all executable module types supported by DxePciLibI440FxQ35 to the following library instance stack: BasePciSegmentLibPci [class: PciSegmentLib] DxePciLibI440FxQ35 [class: PciLib] BasePciCf8Lib [class: PciCf8Lib] BasePciExpressLi

[edk2] [PATCH v2 3/6] OvmfPkg: PlatformPei: enable PCIEXBAR (aka MMCONFIG / ECAM) on Q35

The comments in the code should speak for themselves; here we note only two facts: - The PCI config space writes (to the PCIEXBAR register) are performed using the 0xCF8 / 0xCFC IO ports, by virtue of PciLib being resolved to BasePciLibCf8. (This library resolution will permanently remain in p

[edk2] [PATCH v2 2/6] OvmfPkg: PlatformPei: lower the 32-bit PCI MMIO base to 2GB on Q35

Gerd has advised us that long term support Q35 machine types have no low RAM above 2GB, hence we should utilize the [2GB, 3GB) gap -- that we currently leave unused -- for MMIO. (Plus, later in this series, for the PCIEXBAR too.) Cc: Gabriel Somlo Cc: Gerd Hoffmann Cc: Jordan Justen Cc: Marcel

[edk2] [PATCH v2 4/6] OvmfPkg: add DxePciLibI440FxQ35

This library is a trivial unification of the following two PciLib instances (and the result is easily diffable against each): - MdePkg/Library/BasePciLibCf8 - MdePkg/Library/BasePciLibPciExpress The PCI config access method is determined in the constructor function, from the dynamic PCD "PcdOvmfHo

[edk2] [PATCH v2 1/6] OvmfPkg: IndustryStandard/Q35MchIch9.h: add PCIEXBAR macros

Section 5.1.16 ("PCIEXBAR -- PCI Express Register Range Base Address") in Intel document #316966-002 (already referenced near the top of this header file) describes the Q35 DRAM Controller register that configures the memory-mapped PCI config space (also known as MMCONFIG, and ECAM / Enhanced Confi

Re: [edk2] [PATCH] ShellPkg: Use DOS format end of line.

Fix Intel's copyright years in the modified files. If you do that, then good. Reviewed-By: Jaben Carsey -Jaben Sent from my iPad. > On Mar 8, 2016, at 4:57 AM, Qiu, Shumin wrote: > > Use DOS format end of line(CR, LF). > > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agree

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 14:25, David Woodhouse wrote: > On Tue, 2016-03-08 at 14:21 +0100, Laszlo Ersek wrote: >> As soon as Intel leadership signs off on a merge-oriented workflow, >> I'll seek to adopt it immediately. > > What is this "Intel leadership" of which you speak? The Intel leadership I speak of a

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On Tue, 2016-03-08 at 14:21 +0100, Laszlo Ersek wrote: > As soon as Intel leadership signs off on a merge-oriented workflow, > I'll seek to adopt it immediately. What is this "Intel leadership" of which you speak? I thought the direction from Intel was that we would move to git (at last). Nobody

Re: [edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

On 03/08/16 13:12, David Woodhouse wrote: > So please, DO NOT REBASE submissions onto the latest master. Use the > tools properly as they were designed to be used — put any non-trivial > work into a tree and send it as a pull request. Sure, send the patches > to the list for review *too*, but that

Re: [edk2] [PATCH v6] MdeModulePkg: Increase the maximum number of PEI performance log entries

patch committed at 7c50b3434377cbb49ce4514ee31339000a5cadc0. On 2016/3/8 14:32, Zeng, Star wrote: Reviewed-by: Star Zeng On 2016/3/8 14:00, Cinnamon Shia wrote: The maximum number of PEI performance log entries is 255. Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum n

[edk2] [PATCH] ShellPkg: Use DOS format end of line.

Use DOS format end of line(CR, LF). Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/ShellParametersProtocol.c | 12 ++-- ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c| 12 ++

[edk2] OpenSSL 1.1 status, and a worked example of why you should *NEVER* rebase

As of yesterday, *all* my patches had been merged into OpenSSL HEAD, in preparation for the OpenSSL 1.1 Beta 1 release this week. There is only one more patch outstanding in my OpenSSL git tree. Do those statements seem self-contradictory to you? Well, they're not quite. The patches *were* merged

Re: [edk2] [PATCH 1/3] BaseTools ConvertMasmToNasm: Set gitemail when git is not found

On 03/08/16 04:15, Jordan Justen wrote: > Fixes: https://github.com/tianocore/edk2/issues/63 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > Cc: Yonghong Zhu > Cc: Liming Gao > Cc: Michael Kinney > --- > BaseTools/Scripts/ConvertMasmToNasm.py | 4 +++-

Re: [edk2] [PATCH] OvmfPkg: Enable Network2 Commands for IPv6

On 03/08/16 10:50, Gary Lin wrote: > Enable the network2 commands when NETWORK_IP6_ENABLE is TRUE, so we > would have Ping6 and Ifconfig6. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Ching-Pang Lin > --- > OvmfPkg/OvmfPkgIa32.dsc| 3 +++ > OvmfPkg/OvmfPk

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

Series committed at 3e9de670ec3f18d0211a72d28fedb5dfce93442a and 196ccda08fc481dae4fc97db8f2938df87801edb. On 2016/3/7 15:09, Zeng, Star wrote: Series: Reviewed-by: Star Zeng On 2016/3/7 11:23, Cinnamon Shia wrote: Support UEFI shell execution break. Contributed-under: TianoCore Contributio

Re: [edk2] [PATCH 1/2] OvmfPkg PciHostBridgeDxe: Convert Ia32/IoFifo.asm to NASM

On 03/08/16 04:18, Jordan Justen wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > Ia32/IoFifo.asm to Ia32/IoFifo.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > Cc: Laszlo Ersek > --- > OvmfPkg/PciHostBridgeDxe/Ia

[edk2] [PATCH] OvmfPkg: Enable Network2 Commands for IPv6

Enable the network2 commands when NETWORK_IP6_ENABLE is TRUE, so we would have Ping6 and Ifconfig6. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Ching-Pang Lin --- OvmfPkg/OvmfPkgIa32.dsc| 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/OvmfPkgX64.dsc |

Re: [edk2] [PATCH 0/5] OvmfPkg: enable PCIe on Q35

Series Reviewed-by: Jordan Justen On 2016-03-04 06:46:29, Laszlo Ersek wrote: > The first two patches should fix > , based on Marcel's > analysis in that item. (Thanks a lot for that again!) These patches are > (and should be) independent of -D USE_OLD