Leo:
Could you let me know how to produce those compiler warning? I am curious,
like the warning message in VfrError.cpp for Error().
Pccts is from http://www.polhode.com/pccts133mr.zip. We make minimal change
to them.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:e
On 24 March 2016 at 23:00, Ard Biesheuvel wrote:
> On 24 March 2016 at 21:30, Leo Duran wrote:
>> From: Leendert van Doorn
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Leo Duran
>
> Reviewed-by: Ard Biesheuvel
>
I have committed the following patches
f0bbcd
On 25 March 2016 at 03:52, Ni, Ruiyu wrote:
> Heyi,
> I was not able to remove the blue bar in the beginning of every line if I
> embedded my reply.
> So I will directly write down here.
>
>
> 1. I would like to know in what circumstance the key loss happens.
> Because your UART hardware has
On 25 March 2016 at 00:19, Jordan Justen wrote:
> On 2016-03-24 03:37:24, Laszlo Ersek wrote:
>> From: Ard Biesheuvel
>>
>> This aligns the GCC definitions for 4.6 and up to align with the ARM and
>> AARCH64 definitions, which is to ignore unused but set variables only on
>> RELEASE builds. This
On 25 March 2016 at 01:48, Vladimir Olovyannikov
wrote:
> Hi Ard,
>
> Thank you for the hint.
> Here is the result of git bisection (first bad):
>
> Author: Cohen, Eugene 2016-03-07 07:16:35
> Committer: Ard Biesheuvel 2016-03-16 04:19:58
> Parent: d2bb61a2328d512c0aeb201ab8a5a6497f415afb (Arm
On Fri, Mar 25, 2016 at 02:50:31AM +, Zhang, Lubo wrote:
> Hi Lin
> The following configuration in dhcpd6.conf
> option dhcp6.vendor-class code 16 = string;
> option dhcp6.vendor-class “HTTPClient”;
>need to be changed as
>option dhcp6.vendor-class code 16 = {integer
Heyi,
I was not able to remove the blue bar in the beginning of every line if I
embedded my reply.
So I will directly write down here.
1. I would like to know in what circumstance the key loss happens.
Because your UART hardware has 32 FIFO buffer to receive the keys.
A typical escape keys
Hi Lin
The following configuration in dhcpd6.conf
option dhcp6.vendor-class code 16 = string;
option dhcp6.vendor-class “HTTPClient”;
need to be changed as
option dhcp6.vendor-class code 16 = {integer 32, integer 16, string};
option dhcp6.vendor-class 0 0 “HTTPClie
Sure, we will update the whitepaper.
Siyuan
From: Gary Lin [mailto:g...@suse.com]
Sent: Friday, March 25, 2016 10:27 AM
To: Zhang, Lubo
Cc: edk2-devel@lists.01.org; Ye, Ting ; Fu, Siyuan
; Wu, Jiaxin
Subject: Re: [edk2] [patch] NetworkPkg:Fix bug when parsing the dhcp6 option 16
On Thu, Mar 2
It is good to me.
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Fan, Jeff; Wu, Hao A
> Subject: [PATCH 30/35] SourceLevelDebugPkg: DebugAgentCommon:
> remove
On Thu, Mar 24, 2016 at 04:45:32PM +0800, Zhang Lubo wrote:
> when to parse the DHCP6 reply packet,there will be 6
> bytes offset before the option data according to
> RFC 3315.
>
Will someone update the whitepaper in the wiki(*) after this commit is
checked in? It's obvious that the following dh
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, March 24, 2016 6:37 PM
To: edk2-devel-01
Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen, Jordan L; Andrew
Fish; Gao, Liming; Wu, Jia
It is good to me.
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Fan, Jeff; Wu, Hao A
> Subject: [PATCH 31/35] SourceLevelDebugPkg: DebugCommunicationLibUsb:
Thanks Laszlo, it's good to me.
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 17/35] NetworkPkg: IpSecDxe: remove set but unused
>
Felix：
SyncEsrtFmp & LockEsrtRepository are called by Bds by design, as only Bds
has the knowledge whether Connect All happens and is
the right point to sync ESRT table with FMP instances. So there are generally 2
paths in BDS
1. Normal Boot--> LockEsrtRepository
2. Connect All Boot --> Ski
Good code clean-up.
For OptionRomPkg and DuetPkg, Reviewed-by: Ruiyu Ni
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
>Ersek
>Sent: Thursday, March 24, 2016 6:37 PM
>To: edk2-devel-01
>Cc: Ni, Ruiyu ; Tian, Feng ; Ard
>Biesheuvel ;
During real world testing I was getting an error with too many entries
in db: On my Secure boot laptop, I currently have seven certificates:
two Microsoft ones, Three Kernel ones from various distributions, my
own Secure Key and a temporary test key. That gives a total EFI
Signature List size of 8
On Thu, 2016-03-24 at 18:31 +0100, Laszlo Ersek wrote:
> On 03/24/16 17:30, James Bottomley wrote:
> > During real world testing I
> > was getting an error with too many entries
> > in db: On my Secure boot
> > laptop, I currently have seven certificates:
> > two Microsoft ones, Three
> > Kernel on
Reviewed-by: Jiaxin Wu
> -Original Message-
> From: Zhang, Lubo
> Sent: Thursday, March 24, 2016 4:46 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Ye, Ting ; Wu,
> Jiaxin
> Subject: [patch] NetworkPkg:Fix bug when parsing the dhcp6 option 16
>
> when to parse the DHCP6 reply pac
Reviewed-by: Eric Dong
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star
> Subject: [edk2] [PATCH 15/35] MdeModulePkg: BootMaint
Reviewed-by: Eric Dong
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Ni, Ruiyu; Tian, Feng; Zeng, Star
> Subject: [edk2] [PATCH 16/35] MdeModulePkg: DeviceMan
Hi,
Comments below, with that updated, you can have my R-b.
From now, low response as out of office today.
On 2016/3/25 1:31, Laszlo Ersek wrote:
On 03/24/16 17:30, James Bottomley wrote:
During real world testing I was getting an error with too many entries
in db: On my Secure boot laptop, I
Reviewed-by: Qiu Shumin
-Original Message-
From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
Sent: Thursday, March 10, 2016 3:19 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben; Qiu, Shumin; samer.el-haj-mahm...@hpe.com; Thomas Palmer
Subject: [PATCH] ShellPkg/UefiHandleParsingLib: Fix
Hi
On 2016/3/24 23:51, Laszlo Ersek wrote:
On 03/24/16 15:47, James Bottomley wrote:
During real world testing I was getting an error with too many entries
in db and dbx. This occurs because we don't set the maximum
authenticated variable size, so it inherits this from the maximum
variable siz
MdeModulePkg series reviewed-by: Feng Tian
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, March 24, 2016 6:37 PM
To: edk2-devel-01
Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen, Jordan L; Andrew
Fish;
Duran
Could you explain more about this fix?
1) What's the meaning of PCI emulation here?
2) What's the difference between normal case and this PCI emulation?
3) Why this PCI emulation case needs to update driver to directly use PCI
address for filling transfer descriptor content?
Thanks
Feng
Hi Ard,
Thank you for the hint.
Here is the result of git bisection (first bad):
Author: Cohen, Eugene 2016-03-07 07:16:35
Committer: Ard Biesheuvel 2016-03-16 04:19:58
Parent: d2bb61a2328d512c0aeb201ab8a5a6497f415afb (ArmPkg/ArmLib: add
ArmReadHcr to enable read-modify-write of HCR)
Child:
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, March 24, 2016 6:37 PM
> To: edk2-devel-01
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 17/35] NetworkPkg: IpSecDxe: remove set but unused
> variables
>
> Cc: Siyuan Fu
> C
On 2016-03-24 03:37:24, Laszlo Ersek wrote:
> From: Ard Biesheuvel
>
> This aligns the GCC definitions for 4.6 and up to align with the ARM and
> AARCH64 definitions, which is to ignore unused but set variables only on
> RELEASE builds. This allows us to find instances of unused variables that
>
On 24 March 2016 at 21:30, Leo Duran wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
> ---
> ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 --
> ArmPlatformPkg/PrePi/MainMPCore.c | 10 --
> 2 files changed, 16 insertions(+), 4 deleti
Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: Palmer, Thomas
Sent: Thursday, March 24, 2016 5:05 PM
To: edk2-devel@lists.01.org
Cc: jaben.car...@intel.com; shumin@intel.com; El-Haj-Mahmoud, Samer
; Ard Biesheuvel
Subject: RE: [PATCH] ShellPkg/UefiHandleParsingLib: Fix
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
As mentioned in response to the EmbeddedPkg patch that changes to
64-bit accessors for PcdCpuVectorBaseAddress, these patches need to be
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
This patch needs to be merged with the patch that changes the type of
the PCD, or we will potentially break bisect.
$ git grep -l -E 'Pc
I need a review on this patch.
Thomas
-Original Message-
From: Palmer, Thomas
Sent: Wednesday, March 9, 2016 1:19 PM
To: edk2-devel@lists.01.org
Cc: jaben.car...@intel.com; shumin@intel.com; El-Haj-Mahmoud, Samer
; Palmer, Thomas
Subject: [PATCH] ShellPkg/UefiHandleParsingLib: Fix
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
Reviewed-by: Ard Biesheuvel
> ---
> ArmPlatformPkg/ArmPlatformPkg.dec| 6 +++---
> ArmPlatformPkg/PrePeiCore/A
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
Reviewed-by: Ard Biesheuvel
> ---
> ArmPkg/Drivers/ArmCpuLib/ArmCortexA5xLib/ArmCortexA5xLib.c | 9 ++---
> 1 file changed, 6 inse
On 24 March 2016 at 21:30, Leo Duran wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
Reviewed-by: Ard Biesheuvel
> ---
> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a
On 03/24/16 22:16, Ard Biesheuvel wrote:
> (+ Yonghong, Liming)
>
> On 24 March 2016 at 21:30, Leo Duran wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Leo Duran
>> ---
>> BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 18
>> +-
>>
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, March 24, 2016 4:13 PM
To: Duran, Leo
Cc: edk2-devel@lists.01.org; Leif Lindholm; Leendert van Doorn
Subject: Re: [PATCH] ArmPkg: fixups for 64-bit pointers
On 24 March 2016 at 21:30, Leo Duran w
(+ Yonghong, Liming)
On 24 March 2016 at 21:30, Leo Duran wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
> ---
> BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 18 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/fset2.c |
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
The presence of this patch suggests that you are copying the vector
table rather than using it in place. May I ask what the reason is?
I
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
I already fixed this issue upstream. Please refer to
f9bbb8d9c3f0 MdeModulePkg: AcpiTableDxe: make 4 GB table allocation
limit optional
On 24 March 2016 at 21:30, Leo Duran wrote:
> From: Leendert van Doorn
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leo Duran
Hi Leo,
Thanks for the patches. I will respond to the patches individually
when appropriate, but I have some general comments as well.
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
ArmPkg/Drivers/ArmCpuLib/ArmCortexA5xLib/ArmCortexA5xLib.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/ArmPkg/Drivers/ArmCpuLib/ArmCortexA5xLib/ArmCorte
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 88 +-
.../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 1 +
MdeModulePkg/MdeModulePkg.dec
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
b/EmbeddedPkg/RealTimeClockRuntimeD
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
ArmPkg/ArmPkg.dec| 4 ++--
ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ArmP
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
MdeModulePkg/MdeModulePkg.dec | 6
.../Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | 3 +-
.../Acpi/AcpiTableDxe/AcpiTableProtocol.c | 41 +++
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
ArmPlatformPkg/ArmPlatformPkg.dec| 6 +++---
ArmPlatformPkg/PrePeiCore/AArch64/PrePeiCoreEntryPoint.S | 2 +-
ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 18 +-
BaseTools/Source/C/VfrCompile/Pccts/antlr/fset2.c | 2 +-
BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c | 6 +++---
Bas
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 --
ArmPlatformPkg/PrePi/MainMPCore.c | 10 --
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/ArmPlatformPkg/PrePeiCore/MainMPCore
From: Leendert van Doorn
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leo Duran
---
EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/EmbeddedPkg/Library/GdbDebugAgent/Arm/Processor.c
b/Embedd
On 03/24/16 17:30, James Bottomley wrote:
> During real world testing I was getting an error with too many entries
> in db: On my Secure boot laptop, I currently have seven certificates:
> two Microsoft ones, Three Kernel ones from various distributions, my
> own Secure Key and a temporary test key
(tangent)
On 03/24/16 17:25, James Bottomley wrote:
> Heh, I've seen too many cockups with git-send-email on the kernel
> mailing list ever to want to use it myself. If you use git show and
> your regular email tool, you always know what you're sending.
Perhaps unexpectedly, but this even appli
During real world testing I was getting an error with too many entries
in db: On my Secure boot laptop, I currently have seven certificates:
two Microsoft ones, Three Kernel ones from various distributions, my
own Secure Key and a temporary test key. That gives a total EFI
Signature List size of 8
On Thu, 2016-03-24 at 17:19 +0100, Laszlo Ersek wrote:
> On 03/24/16 17:03, James Bottomley wrote:
> > On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote:
>
> > > Either way, I think all flash sizes are finite in practice, so we
> > > shouldn't be trying to increase PcdMaxAuthVariableSize
> >
On 03/24/16 17:03, James Bottomley wrote:
> On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote:
>> Either way, I think all flash sizes are finite in practice, so we
>> shouldn't be trying to increase PcdMaxAuthVariableSize specifically
>> for dbx's sake. For enrolling whitelist-like stuff (has
On Thu, 2016-03-24 at 16:51 +0100, Laszlo Ersek wrote:
[...]
> Note that OVMF has ~56 KB for variable store (0xe000, see
> NV_VARIABLE_STORE in "OvmfPkg/VarStore.fdf.inc"). Do we really need
> to allow a single authenticated variable to grow as big as 32KB?
>
> I think I've discussed this earlier
On 03/24/16 15:47, James Bottomley wrote:
> During real world testing I was getting an error with too many entries
> in db and dbx. This occurs because we don't set the maximum
> authenticated variable size, so it inherits this from the maximum
> variable size, which is 8192. This allows for abou
Hi Ruiyu,
I had seen the other comments and I just needed more time to think about
them :)
Please see my comments below.
On 03/24/2016 03:26 PM, Ni, Ruiyu wrote:
Heyi,
I had 7 comments in previous mail. I guess you may miss the other
comments.
What Timer driver are you using? How many
During real world testing I was getting an error with too many entries
in db and dbx. This occurs because we don't set the maximum
authenticated variable size, so it inherits this from the maximum
variable size, which is 8192. This allows for about 6 reasonably
sized X509 keys. Increase to the M
Hi,
I use MinnowBoard Max board revision A2. On MinnowBoard Max we changed SMD
IC flash part ( Winbond W25Q64FW ). On that board we test firmware 0.90
version which we download from intel-web. Also we tested other version. On
that board work 0.78, 0.79, 0.80, 0.81 versions, but 0.82, 0.83, 0.84,
Laszlo:
Reviewed-by: Liming Gao for the patches in
EdkCompatibilityPkg.
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, March 24, 2016 6:37 PM
To: edk2-devel-01
Cc: Ni, Ruiyu ; Tian, Feng ; Ard
Bie
On 03/24/16 14:35, Ard Biesheuvel wrote:
> On 24 March 2016 at 11:36, Laszlo Ersek wrote:
>> Maintainers are invited to exert caution while reviewing the patches.
>> Namely, in a few cases, the silencing is almost certainly wrong, and
>> should be replaced with proper error checking. These are th
On 24 March 2016 at 11:36, Laszlo Ersek wrote:
> This series removes unused but set variables from edk2, so that the
> source builds after Ard's patch (the last one in this series) lets
> -Wunused-but-set-variables take effect for GCC DEBUG builds.
>
> I used the following method for locating thes
Pushed at a7b15909e8a6dd221944d87f51b689e633308199.
Thanks for the contribution.
Star
On 2016/3/24 8:48, Tian, Feng wrote:
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: Zeng, Star
Sent: Thursday, March 24, 2016 8:44 AM
To: Alcantara, Paulo ; edk2-devel@lists.01.org
Cc:
On 2016/3/24 18:36, Laszlo Ersek wrote:
This series removes unused but set variables from edk2, so that the
source builds after Ard's patch (the last one in this series) lets
-Wunused-but-set-variables take effect for GCC DEBUG builds.
I used the following method for locating these warnings:
* "
From: Ard Biesheuvel
This aligns the GCC definitions for 4.6 and up to align with the ARM and
AARCH64 definitions, which is to ignore unused but set variables only on
RELEASE builds. This allows us to find instances of unused variables that
are left behind after refactoring. It also allows us to
Cc: Jeff Fan
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 34 +++-
1 file changed, 11 insertions(+), 23 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c
b/Uef
Cc: Jeff Fan
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.c b/UefiCpuPkg/CpuMpPei/CpuMpPei.c
index 950d
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDriver.c
b/OptionRomPkg/Bus/Us
Cc: Feng Tian
Cc: Star Zeng
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c| 4
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 7 +--
2 files changed, 1 insertion(+), 10
The expression that was used to set it had no side effects.
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/MemoryInit/Pei/meminit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
This patch also eliminates a PCI config space access, but that should be
fine.
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/QNCInit/Dxe/QNCInit.c | 3 ---
1 file changed, 3 deletions(
Cc: Feng Tian
Cc: Star Zeng
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/MdeModulePkg/Application/BootManagerMenuApp/BootMa
Cc: Feng Tian
Cc: Star Zeng
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 6 --
MdeModulePkg/Library/BootMaintenanceManagerUiLib/UpdatePage.c | 2 --
2 files cha
Cc: Jeff Fan
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommunicationLibUsb.c
| 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git
a/SourceLevelDebugP
Cc: Jeff Fan
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Deb
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhcPeim.c | 10 --
QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Pei/OhciReg.c | 2 --
2 files changed, 12 deletions(-)
dif
From: Ard Biesheuvel
Remove variable TempQWord that is declared, assigned but never referenced.
This fixes a warning emitted by GCC when -Wunused-but-set-variable is in
effect.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
Reviewed-by: Liming Gao
Reviewe
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/Ohci.c| 9 -
QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciReg.c | 5 +
2 files changed, 1 insertion(+), 13 d
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Library/MtrrLib/MtrrLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/QuarkSocPkg/QuarkNorthCluster/Library/MtrrLib/MtrrLib.c
b/Q
Cc: Siyuan Fu
Cc: Jiaxin Wu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
NetworkPkg/IpSecDxe/Ikev2/Utility.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/NetworkPkg/IpSecDxe/Ikev2/Utility.c
b/NetworkPkg/IpSecDxe/Ikev2/Utility.c
index 16be09e14
This patch also removes a PcdGet16() call, but that should be harmless.
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.inf | 1 -
QuarkSocPkg/QuarkNorthClust
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmControlPei/SmmControlPei.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/QuarkSocPkg/QuarkNorthCluster
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Smm/Dxe/SmmControlDxe/SmmControlDriver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/QuarkSocPkg/QuarkNorthClus
This patch also removes a few PCI config space accesses, but that
shouldn't be a problem.
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Library/IntelQNCLib/PciExpress.c | 13
+
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDMediaDeviceDxe/CEATA.c | 3 ---
QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDMediaDeviceDxe/CEATABlockIo.c | 3 +--
QuarkSo
Cc: Michael D Kinney
Cc: Kelly Steele
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
QuarkSocPkg/QuarkNorthCluster/Spi/Common/SpiCommon.c | 23
1 file changed, 23 deletions(-)
diff --git a/QuarkSocPkg/QuarkNorthCluster/Spi/Common/Sp
Cc: Feng Tian
Cc: Star Zeng
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
From: Ard Biesheuvel
Remove variables that are declared, assigned but never referenced. This
fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
Reviewed-by: Liming Gao
Reviewed-by: La
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
IntelFspWrapperPkg/Library/PeiFspHobProcessLibSample/FspHobProcessLibSample.c
| 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/IntelFspWrapperPkg/Library/PeiFspHobProcess
Cc: Jordan Justen
Cc: Andrew Fish
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
EmulatorPkg/CpuRuntimeDxe/Cpu.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/EmulatorPkg/CpuRuntimeDxe/Cpu.c b/EmulatorPkg/CpuRuntimeDxe/Cpu.c
index fb8520afc
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/BiosVid
This patch also eliminates an AsmReadCr3() call in PageFaultHandler(), but
that should not be a problem.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c | 19
-
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
IntelFrameworkModulePkg/Library/DxeCapsuleLib/DxeCapsuleLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/IntelFrameworkModulePkg/Library/DxeCapsuleLib/DxeCapsuleLib.c
b/IntelFrameworkM
Cc: Maurice Ma
Cc: Prince Agyeman
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
CorebootPayloadPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/CorebootPayloadPkg/Library/PlatformBdsLib/BdsPlatform.c
b/Coreb
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 16
1 file changed, 16 deletions(-)
diff --git
a/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLi
This series removes unused but set variables from edk2, so that the
source builds after Ard's patch (the last one in this series) lets
-Wunused-but-set-variables take effect for GCC DEBUG builds.
I used the following method for locating these warnings:
* "-Werror" was temporarily removed;
* I roun
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
EdkCompatibilityPkg/Sample/Platform/Generic/RuntimeDxe/StatusCode/Lib/BsSerialStatusCode/BsSerialStatusCode.c
| 4
1 file changed, 4 deletions(-)
diff --git
a/EdkCompatibilityPkg/Sampl
1 - 100 of 119 matches
Mail list logo
