[edk2] [PATCH 1/3] IntelFrameworkModulePkg/GenericBdsLib: Check for invalid device handle

Added error control for invalid device handle when LocateDevicePath() fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c | 6 +- 1 file changed, 5 insertions(+), 1

[edk2] [PATCH 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

The PlatformBdsShowProgress() supports graphics mode only, which is not applicable for RS-232 serial console. Show the progress message as a console text message in case PlatformBdsShowProgress() fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov

[edk2] [PATCH 0/3] IntelFrameworkModulePkg: Fixes for Intel BDS

This set of patches fixes the following: Crash when BDS loads a device handle based onthe device path but the device driver has not been loaded. BDS boot timeout. Timeout progress message for RS-232 serial console. Thanks, Daniil Daniil Egranov (3): IntelFrameworkModulePkg/GenericBdsLib:

[edk2] [PATCH 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

The patch loads timeout value from the "Timeout" global variable and passes it to PlatformBdsEnterFrontPage(), which handles delay and key input. The PcdPlatformBootTimeOut is only used at the BDS entry point and updates the "Timeout" value. This will allow the modification of the timeout value

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

https://github.com/niruiyu/edk2/commits/Ovmf_Bds Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, April 29, 2016 7:21 PM To: Ni, Ruiyu ; edk2-de...@ml01.01.org Subject: Re: [edk2] [Patch v4 00/23] Use

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

I missed that the default was from the RFC. I agree with you. -Jaben > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, April 29, 2016 11:00 AM > To: Carsey, Jaben > Cc: Marcin Wojtas ; Fu, Siyuan

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Since the default is actually defined in the RFC, I would prefer this to not be PCD configurable. Having it as an option to the shell command makes a lot of sense, though. / Leif On Fri, Apr 29, 2016 at 05:44:50PM +, Carsey, Jaben wrote: > Maybe we should have a PCD control the default

Re: [edk2] [review]Please review changes to UNI file format document

Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Friday, April 29, 2016 10:53 AM To: edk2-devel@lists.01.org; Bjorge, Erik C ; Qiu, Shumin Cc: Carsey, Jaben Subject: [review]Please review changes

[edk2] [review]Please review changes to UNI file format document

Updated UNI spec to remove info specific to some consumers, not format. Updated UNI spec to allow non-ascii characters in strings. Cc: Qiu Shumin > Cc: Erik Bjorge Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Thursday, April 28, 2016 7:42 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Maybe we should have a PCD control the default value so that people who build it can set it as per their own best value. Adding a parameter seems like a great (but separate) solution. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [PATCH] ArmPlatformPkg/PrePi: allow unicore version to be used on MP hardware

On 28 April 2016 at 17:29, Leif Lindholm wrote: > On Thu, Apr 28, 2016 at 05:02:19PM +0200, Ard Biesheuvel wrote: >> On 19 April 2016 at 09:26, Ard Biesheuvel wrote: >> > When combining UEFI firmware built from Tianocore with ARM Trusted >> >

Re: [edk2] [PATCH 2/2] ArmPkg: implement CpuIo2 protocol driver specific for PCI

On Fri, Apr 29, 2016 at 05:41:20PM +0200, Ard Biesheuvel wrote: > The CpuIo2 protocol is required by the generic PciHostBridgeDxe driver, > which relies on it to back its own I/O and MMIO operations. > > Since ARM has no native I/O port equivalent, such accesses can only > originate from PCI

Re: [edk2] [PATCH 1/2] ArmPlatformPkg: move PCI related PCD definitions to ArmPkg

On Fri, Apr 29, 2016 at 05:41:19PM +0200, Ard Biesheuvel wrote: > The PCI related PCDs are not platform specific, and architectural > protocols such as CpuIo2 are based on PCI provided MMIO to IO > translation, so these PCDs belong in ArmPkg not ArmPlatformPkg. Very happy with this - but, could

[edk2] [PATCH 1/2] ArmPlatformPkg: move PCI related PCD definitions to ArmPkg

The PCI related PCDs are not platform specific, and architectural protocols such as CpuIo2 are based on PCI provided MMIO to IO translation, so these PCDs belong in ArmPkg not ArmPlatformPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 2/2] ArmPkg: implement CpuIo2 protocol driver specific for PCI

The CpuIo2 protocol is required by the generic PciHostBridgeDxe driver, which relies on it to back its own I/O and MMIO operations. Since ARM has no native I/O port equivalent, such accesses can only originate from PCI drivers, and the PCI I/O space is translated to MMIO in this case. So we can

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Derek Lin > Sent: Friday, April 29, 2016 7:09 PM > To: edk2-devel@lists.01.org > Cc: Derek Lin ; Yao, Jiewen ; >

Re: [edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

On 04/29/16 09:00, Ruiyu Ni wrote: > The patch serials creates a flag USE_OLD_BDS and by default the value > of the flag is FALSE so that the new MdeModulePkg/BDS is used. > User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg > /BDS. > > The v3 adopts comments for v1 and

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

On 04/29/16 13:09, Derek Lin wrote: > Reduce several DEBUG messages verbosity from INFO to VERBOSE, so that will > not see debug message around each driver loading when TPM 2.0 part present. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Derek Lin

[edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

Reduce several DEBUG messages verbosity from INFO to VERBOSE, so that will not see debug message around each driver loading when TPM 2.0 part present. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 13

Re: [edk2] [PATCH v4 2/2] OvmfPkg: Modify FDF/DSC files for RamDiskDxe's adding NFIT report feature

On 04/29/16 04:23, Hao Wu wrote: > The RamDiskDxe driver in MdeModulePkg now will use EFI_ACPI_TABLE_PROTOCOL > and EFI_ACPI_SDT_PROTOCOL during reporting RAM disks to NVDIMM Firmware > Interface Table (NFIT). > > A Pcd 'PcdInstallAcpiSdtProtocol' controls whether the > EFI_ACPI_SDT_PROTOCOL will

Re: [edk2] [PATCH 2/2] PerformancePkg/Dp_App: Fix the error message "Timer library instance error!"

Hi Star, Thanks for your review. "duration < StartTimeStamp" is for the case of the timer counting down. Below is the source code for your reference: if (TimerInfo.CountUp) { Duration = Measurement->EndTimeStamp - Measurement->StartTimeStamp; Error = (BOOLEAN)(Duration >

Re: [edk2] [PATCH] MdeModulePkg/DxeCore: set ImageContext Handle and ImageRead() fields

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, April 29, 2016 3:44 PM To: edk2-devel@lists.01.org; Tian, Feng ; Zeng, Star Cc:

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

Thanks. I agree, will send a patch soon. Derek -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Friday, April 29, 2016 6:29 PM To: Lin, Derek (HPS UEFI Dev) ; Zhang, Chao B ; El-Haj-Mahmoud, Samer

Re: [edk2] [PATCH] SecurityPkg: Reduce TPM debug verbosity

Reviewed by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, April 29, 2016 5:08 AM > To: edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud ; Zhang, Chao B >

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

Thanks. That makes sense now. Would you please update commit message? I agree to reduce debug message. I think below message is of much importance to show TPM capability and narrow BitLock failure, per my experience. I suggest we keep those as INFO. For others, I am OK to change to VERBOSE.

Re: [edk2] [PATCH] SecurityPkg: Reduce DEBUG verbosity in Tcg2Dxe

Hi Jiewen, It is test with TPM 2.0 part present. There is debug message around each driver loading, which we think should be verbose. The commit description is wrong. Thanks, Derek -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Friday, April 29, 2016 10:38 AM

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Hi Siyuan, Thanks a lot for thorough explanation. The default 512B won't be changed then - PCD and extending tftp command seem a good alternative. We will come back later with more proper solution. Best regards, Marcin 2016-04-29 10:40 GMT+02:00 Fu, Siyuan : > Hi, Marcin >

Re: [edk2] [RFC] MdeModulePkg, ShellPkg: increase TFTP block size

Hi, Marcin The RFC2348 has a detail discussion about the block size setting in tftp and give the answer: using value of MTU is not the best choice. You may find you still can gain more efficiency by increasing the block size over the path MTU, until the IP fragmentation gives more overhead

[edk2] [PATCH] MdeModulePkg/DxeCore: set ImageContext Handle and ImageRead() fields

Set the ImageContext.Handle and ImageContext.ImageRead() fields so that PeCoffLoaderRelocateImageExtraAction() can invoke PeCoffLoaderGetImageInfo or PeCoffLoaderGetPeHeader if desired to obtain additional metadata. We will use this to create a PeCoffLoaderRelocateImageExtraAction()

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

On 29 April 2016 at 09:19, Ni, Ruiyu wrote: > Ard, > At first glance of this patch, I immediately checked the PI spec > SubResources() description, > it says when a root bridge doesn't require any resource, "a zero-length > resource request > must explicitly be submitted." >

Re: [edk2] [PATCH] MdeModulePkg/PciBusDxe: don't create bogus descriptor if no resources needed

Ard, At first glance of this patch, I immediately checked the PI spec SubResources() description, it says when a root bridge doesn't require any resource, "a zero-length resource request must explicitly be submitted." "zero-length resource" can be interpreted in two ways: 1. only END descriptor

[edk2] [Patch v4 23/23] OvmfPkg/OvmfPkgIa32X64.dsc: Move PcdShellFile to [PcdsFixedAtBuild.X64]

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc

[edk2] [Patch v4 21/23] OvmfPkg/PlatformBootManagerLib: Remove unused C structures definitions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.h | 47 -- 1 file changed, 47 deletions(-) diff --git

[edk2] [Patch v4 15/23] OvmfPkg/PlatformBootManagerLib: Use EfiBootManagerRefreshAllBootOption()

The patch uses EfiBootManagerRefreshAllBootOption() to collect all boot options and uses SetBootOrderFromQemu exposed by QemuNewBootOrderLib to adjust the boot option order. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo

[edk2] [Patch v4 22/23] OvmfPkg: Use MdeModulePkg/BDS

By default the new MdeModulePkg/BDS is used. If USE_OLD_BDS is defined to TRUE, IntelFrameworkModulePkg/BDS is used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek

[edk2] [Patch v4 16/23] OvmfPkg/PlatformBootManagerLib: Remove PlatformBdsGetDriverOption()

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 30 -- .../Library/PlatformBootManagerLib/BdsPlatform.h | 6 - 2

[edk2] [Patch v4 20/23] OvmfPkg/PlatformBootManagerLib: Add EnableQuietBoot & DisableQuietBoot

EnableQuietBoot and DisableQuietBoot are copied from IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c. Because these two functions are not in UefiBootManagerLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen

[edk2] [Patch v4 18/23] OvmfPkg/PlatformBootManagerLib: Remove unnecessary memory test

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 60 +- .../Library/PlatformBootManagerLib/BdsPlatform.h | 5 -- 2

[edk2] [Patch v4 19/23] OvmfPkg/PlatformBootManagerLib: Remove unused vars and func prototypes

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.h | 42 --

[edk2] [Patch v4 17/23] OvmfPkg/PlatformBootManagerLib: Use GetBootModeHob() in HobLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[edk2] [Patch v4 10/23] OvmfPkg/PlatformBootManagerLib: Init console vars in *BeforeConsole()

The major difference between IntelFrameworkModulePkg/BDS and MdeModulePkg/BDS is the latter connects the consoles in core code while the former connects in platform code. The change initializes the console variables in PlatformBootManagerBeforeConsole() and removes the console connection code. It

[edk2] [Patch v4 05/23] OvmfPkg: Duplicate PlatformBdsLib to PlatformBootManagerLib

It will be changed to build with MdeModulePkg/BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek --- .../{PlatformBdsLib =>

[edk2] [Patch v4 12/23] OvmfPkg/PlatformBootManagerLib: Register boot options and hot keys

The patch registers "Enter" key as the continue key (hot key to skip the boot timeout wait), maps "F2" key to UI, and registers Shell boot option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc:

[edk2] [Patch v4 11/23] OvmfPkg/PlatformBootManagerLib: Do not launch Boot Manager Menu

MdeModulePkg/BDS doesn't launch UI (Boot Manager Menu) from platform side. The change removes the code which launches the UI but still set the boot timeout. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek

[edk2] [Patch v4 04/23] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

NOTE: SetBootOrderFromQemu() interface is not changed. But when the old IntelFrameworkModulePkg/BDS is no longer used in OVMF and ArmVirtPkg, additional patch will be submitted to change this interface to remove parameter BootOptionList. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch v4 03/23] OvmfPkg: Duplicate QemuBootOrderLib to QemuNewBootOrderLib

QemuNewBootOrderLib will be changed to work with MdeModulePkg/BDS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek --- .../{QemuBootOrderLib =>

[edk2] [Patch v4 14/23] OvmfPkg/PlatformBootManagerLib: port PlatformBdsConnectSequence to UefiBootManagerLib

The patch changes PlatformBdsConnectSequence() to use library API exposed from UefiBootManagerLib and removes the additional connect ALL action. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek ---

[edk2] [Patch v4 09/23] OvmfPkg/PlatformBootManagerLib: Use ConvertDevicePathToText()

The DevicePathToStr() function (in "IntelFrameworkModulePkg/Library/GenericBdsLib/DevicePath.c") is a simple wrapper around ConvertDevicePathToText(). DevicePathToStr() passes DisplayOnly=TRUE and AllowShortcuts=TRUE to ConvertDevicePathToText(), whereas in this patch, both parameters are flipped

[edk2] [Patch v4 06/23] OvmfPkg/PlatformBootManagerLib: Follow PlatformBootManagerLib interfaces

Change the function name to follow new library class PlatformBootManagerLib interfaces. NOTE: There is no progress bar during BDS timeout waiting. In order to show the progress bar, PlatformBootManagerWaitCallback () needs to change to draw it. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch v4 13/23] OvmfPkg/PlatformBootManagerLib: Remove unused local functions.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Reviewed-by: Laszlo Ersek --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 94 -- 1 file changed, 94

[edk2] [Patch v4 07/23] OvmfPkg/PlatformBootManagerLib: use EfiBootManagerUpdateConsoleVariable

Call EfiBootManagerUpdateConsoleVariable in UefiBootManagerLib instead of BdsLibUpdateConsoleVariable in GenericBdsLib. Still cannot pass build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek ---

[edk2] [Patch v4 01/23] MdeModulePkg/UefiBootManagerLib: Expose *GetLoadOptionBuffer() API

Expose EfiBootManagerGetLoadOptionBuffer() API. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Laszlo Ersek --- MdeModulePkg/Include/Library/UefiBootManagerLib.h | 23 +-

[edk2] [Patch v4 02/23] OvmfPkg/PlatformPei: Add memory above 4GB as tested

Since PlatformBootManagerLib do not run memory test to convert untested memory to tested. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Tested-by: Laszlo Ersek Reviewed-by: Laszlo Ersek ---

[edk2] [Patch v4 00/23] Use MdeModulePkg/BDS in OVMF platform

The patch serials creates a flag USE_OLD_BDS and by default the value of the flag is FALSE so that the new MdeModulePkg/BDS is used. User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg /BDS. The v3 adopts comments for v1 and v2 to split the big changes to small changes and

Re: [edk2] [PATCH] [BaseTools]/Build: Better DSC arch filtering

Xie xie, Thomas -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Friday, April 29, 2016 1:30 AM To: Palmer, Thomas ; edk2-devel@lists.01.org Cc: Gao, Liming ; El-Haj-Mahmoud, Samer ;

Re: [edk2] [PATCH] [BaseTools]/Build: Better DSC arch filtering

Reviewed-by: Yonghong Zhu I will push this patch to Git Repository. Best Regards, Zhu Yonghong -Original Message- From: Thomas Palmer [mailto:thomas.pal...@hpe.com] Sent: Thursday, April 28, 2016 6:32 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong

Re: [edk2] [Patch] BaseTools: fix the bug for FMP to support use Macro as path description

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, April 28, 2016 3:07 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: fix the bug for FMP to support use Macro as path >

[edk2] [Patch] SecurityPkg OpalPasswordDxe: Install menu without device dependency.

Change design to always install opal menu. Current implementation only install menu when device connect. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong ---