Reviewed-by: : Michael D Kinney
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, August 10, 2016 7:38 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
> ;
> Gao, Liming
On 2016/8/11 9:59, Andrew Fish wrote:
On Aug 10, 2016, at 6:53 PM, Zeng, Star wrote:
If a DXE_RUNTIME_DRIVER driver just wants to report status code at boot phase
and links to DxeReportStatusCodeLib, is it a bug?
How about just to add notes for DxeReportStatusCodeLib
Hi Eugene,
Actually this is exactly the problem Samer raised to the mailing list in Aug
2015. We ever fixed it with following patch:
SHA-1: 3d0a49ad47619c30c84bbee8a33f54b64dddbcec
* MdeModulePkg: Fix issue about current Ip4Dxe implementation for DHCP DORA
process
DHCP policy is applied as
Reviewed-by: Liming Gao
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, August 11, 2016 10:38 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
> ; Gao, Liming ;
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Thursday, August 11, 2016 1:33 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Tian, Feng ; Chan, Amy
Minimize the code overhead between the two TSC reads by adding
new internal API to calculate TSC Frequency instead of reusing
MicroSecondDelay ().
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Paul A Lohr
Contributed-under:
The RSDT is only used when the bios need to support ACPI 1.0
version. When change PcdAcpiExposedTableVersions to 0x3C, it
will not support ACPI 1.0. The default is 0x3E.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Eric Dong
The RSDT is only used when the bios need to support ACPI 1.0
version. When change PcdAcpiExposedTableVersions to 0x3C, it
will not support ACPI 1.0. The default is 0x3E.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
Cc: Eric Dong
Reviewed-by: David Wei
Thanks,
David Wei
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, August 10, 2016 1:56 PM
To: edk2-devel@lists.01.org
Cc: Wei, David
Subject: [PATCH 08/11]
> On Aug 10, 2016, at 6:53 PM, Zeng, Star wrote:
>
> If a DXE_RUNTIME_DRIVER driver just wants to report status code at boot phase
> and links to DxeReportStatusCodeLib, is it a bug?
>
> How about just to add notes for DxeReportStatusCodeLib like DxePcdLib.inf?
>
Star,
Hi, Shaveta
I saw the Tftp implemention of UefiShell splits the whole procedure to two
steps, read the file from tftp sever at first, then write the file to specified
destination.
Do you know which step gets the timeout error?
The 1st step is total irrelevant with HDD access. And I didn't see
If a DXE_RUNTIME_DRIVER driver just wants to report status code at boot phase
and links to DxeReportStatusCodeLib, is it a bug?
How about just to add notes for DxeReportStatusCodeLib like DxePcdLib.inf?
DxePcdLib.inf:
"
# Note: A driver of type DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER can only use
Hi,
I am trying to build this and seeing this error. I was able to build another
package without any errors using the same configuration.
Thanks much.
Vasudevan Kottilil
Build environment: Linux-4.0.4-301.fc22.x86_64-x86_64-with-fedora-22-Twenty_Two
Build start time: 15:21:44, Aug.10 2016
> My description was not very clear, and the point is academic if you are
> happy with the solution.
I think it's important that we're aligned on how the GIC works so thanks for
humoring me.
> However:
> The GIC spec has a state machine diagram (Figure 4.3), where:
> Transition D, pending to
Hi Eugene.
Some responses inline below.
>-Original Message-
>From: Cohen, Eugene [mailto:eug...@hp.com]
>Sent: 10 August 2016 20:34
>To: Evan Lloyd; Ard Biesheuvel; Heyi Guo
>Cc: Alexei Fedorov; edk2-devel@lists.01.org; Andrew Fish (af...@apple.com);
>Leif Lindholm
>Subject: RE: [edk2]
Evan,
> I'd like to re-think our GIC EIOR changes in the light of comments from
> Heyi Guo. (inserted before Eugene's e-mail below)
> Despite Eugene's cogent advocacy of the change, and the fact that
> Alexei's fix is now accepted, I have come to the conclusion that it is not
> the best thing to
> On Aug 10, 2016, at 11:02 AM, Kinney, Michael D
> wrote:
>
>
>
>> -Original Message-
>> From: af...@apple.com [mailto:af...@apple.com]
>> Sent: Wednesday, August 10, 2016 10:35 AM
>> To: Kinney, Michael D
>> Cc: Zeng, Star
On Wed, Aug 10, 2016 at 05:17:48PM +0200, Ard Biesheuvel wrote:
> Annotate functions with ASM_FUNC() so that they are emitted into
> separate sections.
Also changes ConstantToReg -> MOV32.
Add a note on this to commit message and:
Reviewed-by: Leif Lindholm
>
> > Why does this work? In my experimentation the C preprocessor
> would collapse the stuff onto a single line (the backslash being a
> continuation on the preprocessor input, but preprocessor output
> revealed the newlines being removed), thereby violating the assembly
> requirement that labels
On 10 August 2016 at 20:26, Cohen, Eugene wrote:
> Ard,
>
>> +#define _ASM_FUNC(Name, Section)\
>> + .global Name ; \
>> + .section #Section, "ax"; \
>> + .type Name, %function ; \
>> + Name:
>> +
>> +#define ASM_FUNC(Name)
Ard,
> +#define _ASM_FUNC(Name, Section)\
> + .global Name ; \
> + .section #Section, "ax"; \
> + .type Name, %function ; \
> + Name:
> +
> +#define ASM_FUNC(Name)_ASM_FUNC(ASM_PFX(Name),
> .text. ## Name)
Why does this work? In my
With this commit:
Revision: 1f6729ffe98095107ce82e67a4a0209674601a90
Author: jiaxinwu
Date: 7/7/2015 2:19:55 AM
Message:
MdeModulePkg: Update Ip4Dxe driver to support Ip4Config2 protocol,
a new behavior seemed to come in to the network stack that was not present
before: It
We have been running into an issue when trying to configure an interface as
DHCP where if the DHCP process is not yet complete (Ip4Mode.IsConfigured is
FALSE) the configure process will never succeed.
We have a case where we attempt to invoke the UDP4 Configure:
Status =
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Wednesday, August 10, 2016 10:35 AM
> To: Kinney, Michael D
> Cc: Zeng, Star ; edk2-devel
> Subject: Re: [edk2] [MdeModulePkg]
Hi.
(Note - this is not "top-posting", it is a discussion point, with references
appended.)
I'd like to re-think our GIC EIOR changes in the light of comments from Heyi
Guo. (inserted before Eugene's e-mail below)
Despite Eugene's cogent advocacy of the change, and the fact that Alexei's fix
> On Aug 10, 2016, at 10:22 AM, Kinney, Michael D
> wrote:
>
> Hi Andrew,
>
> I am staring at the code. Something is not right here, but I am
> concerned that there are use cases I am not considering yet. Here
> is my analysis so far.
>
> Here are the lib
On 2016-08-09 22:56:11, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Feng Tian
> Cc: Amy Chan
> ---
> MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 14
>
On 10 August 2016 at 18:56, Leif Lindholm wrote:
> On Wed, Aug 10, 2016 at 05:17:37PM +0200, Ard Biesheuvel wrote:
>> The function ArmReplaceLiveTranslationEntry() has been moved to
>> ArmMmuLib, so remove the old implementation from ArmLib.
>
> Could you add a statement
On 10 August 2016 at 19:04, Leif Lindholm wrote:
> On Wed, Aug 10, 2016 at 05:17:39PM +0200, Ard Biesheuvel wrote:
>> This removes the various Mmio ASM macros that are not used anywhere in
>> the code, and removes some variants of LoadConstant... () that are not
>> used
Hi Andrew,
I am staring at the code. Something is not right here, but I am
concerned that there are use cases I am not considering yet. Here
is my analysis so far.
Here are the lib instances I see:
(ignoring IntelFramework ones for the purposes of this discussion).
On Wed, Aug 10, 2016 at 05:17:39PM +0200, Ard Biesheuvel wrote:
> This removes the various Mmio ASM macros that are not used anywhere in
> the code, and removes some variants of LoadConstant... () that are not
> used anywhere either.
If you say something about how the Mmio* functions are
On Wed, Aug 10, 2016 at 05:17:37PM +0200, Ard Biesheuvel wrote:
> The function ArmReplaceLiveTranslationEntry() has been moved to
> ArmMmuLib, so remove the old implementation from ArmLib.
Could you add a statement to this commit message that you're also
fixing up the export attributes for the
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, August 9, 2016 10:56 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Steele, Kelly
>
> Subject: [PATCH 07/11]
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmSmcLib/AArch64/ArmSmc.S | 7 ++-
ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/BaseMemoryLibVstm/Arm/CopyMem.S | 8 +++-
This introduces the ASM_FUNC() macro to annotate function entry points
in assembler files. This allows us to add additional metadata that
marks a function entry point as a function, and allows us to emit
a .section directive for each function, which makes it possible for
the linker to drop
This updates all assembly source files under ArmVirtPkg to mark
exported functions as ASM_FUNC(), which puts them in a separate
section, allowing the linker to prune code that is left unused.
At the same time, clean up the code to get rid of LoadConstantToReg()
instances involving symbol
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibReplaceEntry.S | 4 +---
1 file changed, 1
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/BaseMemoryLibStm/Arm/CopyMem.S | 8 +++-
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S | 49 ++-
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Library/ArmPlatformStackLib/AArch64/ArmPlatformStackLib.S | 35
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/PrePeiCore/AArch64/Helper.S | 11 ++-
This module is not referenced anywhere, so remove it.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BeagleBoardPkg/Sec/Arm/ModuleEntryPoint.S | 85 --
BeagleBoardPkg/Sec/Arm/ModuleEntryPoint.asm | 89 --
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S | 67 ---
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7Helper.S
| 22
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S | 9 +++--
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/AArch64/ArmJunoHelper.S | 37
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc
b/BeagleBoardPkg/BeagleBoardPkg.dsc
index
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/Library/ArmPlatformLibNull/AArch64/ArmPlatformHelper.S | 28
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Library/SemihostLib/AArch64/GccSemihost.S | 7 ++-
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections. Note that in some cases, various entry points
refer to different parts of the same routine, so in those cases,
the files have been left untouched.
Contributed-under: TianoCore Contribution Agreement 1.0
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/ArmGic/GicV3/AArch64/ArmGicV3.S | 28 ++--
The C language is powerful enough to implement a function that does
absolutely nothing, so there is no need to resort to implementations
in assembler for various toolchains/architectures.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
The RVCT .asm files include AsmMacroIoLib.h only for the definition of
LoadConstantToReg (), which makes it tedious to make change to that file
without the risk of making the RVCT assembler unhappy. So simply replace
LoadConstantToReg() with mov32, which does the right thing in all cases.
Annotate functions with ASM_FUNC() so that they are emitted into
separate sections.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/ArmCpuLib/ArmCortexA5xLib/AArch64/ArmCortexA5xHelper.S | 9
++---
As requested by Eugene, this series introduces a new ASM_FUNC preprocessor
macro that emits functions into separate sections, allowing the linker to
get rid of the code that ends up unused in the module.
Note that using a native GNU as macro turned out to be problematic, due
to our use of Trim,
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
> Gao
> Sent: Wednesday, August 10, 2016 8:24 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
Hi, all
New UDK release UDK2017 is on plan. Its target will be at early Q1 of 2017.
Main features in this release are listed below. This patch requests to create
UDK2017 branch based on edk2 master.
1. UEFI2.6 Features: EMMC/SD Stack, RamDisk, MemoryAttributesTable, IPv6
Http Boot, URI
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, August 09, 2016 9:25 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Dong, Eric
> Subject: [PATCH v2 2/2] MdeModulePkg/Browser: Share
Add two name files IntrinsicLib Ia32 MathLShiftS64.nasm and MathRShiftU64.nasm
Cc: Qin Long
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../Library/IntrinsicLib/Ia32/MathLShiftS64.nasm | 48
Hi Feng,
PRD table entries are 16Byte aligned, as specified by AHCI spec also, it has 4
DWs.
I have tried two HDD, but issue is same, TIMEOUT issue.
I have also tried copying one file on SATA HDD to another file on same SATA
HDD(filesize > 4MB),
No issue occur in this scenario.
USB support is
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Tuesday, August 09, 2016 9:25 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Dong, Eric
> Subject: [PATCH v2 1/2] MdeModulePkg/HiiDB: Share
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, August 10, 2016 11:11 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Dong, Eric
> Subject: [patch] MdeModulePkg/DriverSample: Skip
The CLANG38 toolchain creates a PIE binary at link time. This is
necessary since the LTO code generation may otherwise result in
code that cannot execute correctly when loaded above 2 GB.
PIE executables contain a RELA section consisting of dynamic
relocation entries that are intended for
"EFI_IFR_RESET_BUTTON_OP" is a statement, not a question,
so remove it from function CheckQuestionOpCode.
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
65 matches
Mail list logo