Re: [edk2] [PATCH 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support

Many thanks, Jordan Leif, I am ok with that. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Justen, Jordan L Sent: Tuesday, August 23, 2016 12:33 PM To: Tian, Feng ; Leif Lindholm ;

Re: [edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

Feng, The spec says " If the platform does not recognize the EFI_GUID in ResetData the platform must pick a supported reset type to perform". For the NULL instance of ResetSystemLib, I treat it as an implementation for a Certain platform, then it's ok to let it pick a supported reset type to

Re: [edk2] [PATCH 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support

On 2016-08-18 20:12:16, Tian, Feng wrote: > Jordan, > > Any comments on this? Is it ok for you? > Since there is a Contributed-under and Signed-off-by, it appears to follow our current contribution process. It looks like Leif is confirming that we can use the code under the "TianoCore

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Star, PciLib uses smaller address and fewer params, so those functions can be simpler and smaller. We only want to use PciSegmentLib when we have to. Mike > -Original Message- > From: Zeng, Star > Sent: Monday, August 22, 2016 7:09 PM > To: Kinney, Michael D

Re: [edk2] [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific

Do you need directly assert in ResetPlatformSpecific() for this NULL instance? Other series look good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Wednesday, August 10, 2016 1:56 PM To: edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, August 19, 2016 1:23 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ; Wu

Re: [edk2] Do BSPs only have to be logical thread 0 ?

When system power on, one processor (usually, it is thread 0) will be selected to be BSP, it is descripted in IA32 Software Developer User Manual. On POST phase, PI MP PPI and Protocol service provide SwitchBSP() service to switch BSP to other enabled thread, it is descripted in PI

[edk2] [PATCH 3/3] Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib"

This reverts commit c0bcd3433f33876c519bf5567e0ab69261b57fe9. The above commit causes several regression of "echo" command: 1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes. 2. Output redirection is not working as expected. Text is

[edk2] [PATCH 0/3] Revert "ShellPkg: Fix echo to support displaying special characters"

This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96. The above commit causes several regression of "echo" command: 1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes. 2. Output redirection is not working as expected. Text is

[edk2] [PATCH 2/3] Revert "ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib"

This reverts commit 0fcf8d4df85d861b6e721bd1d8abb449f05e15ed. The above commit causes several regression of "echo" command: 1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes. 2. Output redirection is not working as expected. Text is

[edk2] [PATCH 1/3] Revert "ShellPkg: Fix echo to support displaying special characters"

This reverts commit 95fc5a877502a6e6324300eed0136243d359fa96. The above commit causes several regression of "echo" command: 1. Double quotes are not being stripped from the final text. UEFI Shell 2.2 section 3.4.5 chops out the quotes. 2. Output redirection is not working as expected. Text is

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Mike, That means PiDxeS3BootScriptLib will depend on both PciLib and PciSegmentLib. Is there any negative impact for PiDxeS3BootScriptLib to only depend on PciSegmentLib? Thanks, Star -Original Message- From: Kinney, Michael D Sent: Tuesday, August 23, 2016 9:59 AM To: Zeng, Star

[edk2] [PATCH] Maintainers.txt: Add IntelFsp2Pkg, IntelFsp2WrapperPkg and IntelSiliconPkg.

Cc: Giri P Mudusuru Cc: Satya Yarlagadda Cc: Amy Chan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Maintainers.txt | 12 1 file changed, 12

Re: [edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Star, I do not think all PCI opcodes should be updated to use the PciSegmentLib. Only the "2" versions of the PCI opcodes should use the PciSegmentLib. This means that functions like ScriptPciCfgRead() should not be modified at all and should still use the PciLib. You will need to add a new

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Friday, August 19, 2016 3:53 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin ; Hegde Nagaraj P

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Friday, August 19, 2016 3:53 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin ; Hegde Nagaraj P

Re: [edk2] [Patch] BaseTools GNU Makefile: Add the missing rules for cpp source file

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Sunday, August 21, 2016 11:29 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P ; Zhu, Yonghong > > Subject: [Patch]

Re: [edk2] [Patch] BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Gao, Liming > Sent: Sunday, August 21, 2016 11:32 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P ; Zhu, Yonghong > > Subject: [Patch]

Re: [edk2] [Patch] BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, August 22, 2016 2:32 PM To: edk2-devel@lists.01.org Cc: Mudusuru, Giri P ; Zhu, Yonghong Subject:

Re: [edk2] [Patch] BaseTools GNU Makefile: Add the missing rules for cpp source file

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, August 22, 2016 2:29 PM To: edk2-devel@lists.01.org Cc: Mudusuru, Giri P ; Zhu, Yonghong Subject:

Re: [edk2] [Patch] BaseTools: update BinaryFiles.txt file to add Pkcs7Sign Tool

Reviewed-by: Erik Bjorge > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, August 22, 2016 4:46 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Bjorge, Erik C >

[edk2] [Patch] BaseTools: update BinaryFiles.txt file to add Pkcs7Sign Tool

add Pkcs7Sign.exe and related pem file into BinaryFiles.txt for build server to automatically build the binary win32 files. Cc: Liming Gao Cc: Erik Bjorge Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

Ard: I have no comment. Reviewed-by: Liming Gao > Thanks Liming From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 22, 2016 7:33 PM To: Shi, Steven Cc: edk2-devel@lists.01.org; Gao, Liming

Re: [edk2] [PATCH 0/5] ArmVirtQemu: move to generic PciHostBridgeDxe

On 08/22/16 02:35, Ard Biesheuvel wrote: > Now that Laszlo's virtio-gpu-pci have removed the last remaining obstacle, > we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg, > and move to the generic one. This will allow us to perform DMA above 4GB > without bounce

Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

On 22 August 2016 at 13:28, Shi, Steven wrote: > Hi Ard, > I like you path, and it makes the code look more clear. But in fact, old code > should already ignore the dynamic RELA sections implicitly. > > Like below code, when the GenFw use .rela section info value, which is

Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

Hi Ard, I like you path, and it makes the code look more clear. But in fact, old code should already ignore the dynamic RELA sections implicitly. Like below code, when the GenFw use .rela section info value, which is 0, to get .rela target applying section address in SecShdr, it will point to

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

Hi Ard, -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 22, 2016 2:19 PM To: Sajjan, Vikas C Cc: Laszlo Ersek ; edk2-de...@ml01.01.org; leif.lindh...@linaro.org; Wei, Dong (Office of the CTO)

[edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

When building PIE (ET_DYN) executables, an additional RELA section is emitted (in addition to the per-section .rela.text and .rela.data sections) that is intended to be resolved at runtime by a ET_DYN compatible loader. At the moment, due to the fact that we don't support GOT based relocations,

[edk2] [PATCH] ArmVirtPkg: Fix build breakage of ArmVirtXen platform

Added missing dependency of FileExplorerLib, which was causing build error for ArmVirtXen, due to inclusion of ramdisk support. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Vikas C Sajjan --- ArmVirtPkg/ArmVirt.dsc.inc | 4 1 file

[edk2] [PATCH v4 2/2] ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms

Adds the RAMDisk support to ArmVirtPkg platforms. This patch actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Vikas C Sajjan ---

[edk2] [PATCH v4 0/2] Add Ramdisk support to ArmVirtPkg platforms

This series adds ramdisk driver support to ArmVirtPkg platforms. It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. changes since v3: - Added missing FileExplorerLib, which was causing build error for ArmVirtXen. changes since v2: - Made changes as suggested by Laszlo

[edk2] [PATCH v4 1/2] ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc

Since ArmVirt.dsc.inc is included in all the ArmVirt dsc files, move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Vikas C Sajjan ---

Re: [edk2] [PATCH] BaseTools/GccBase.lds: don't copy RELA section to PE/COFF

Ard, Your patch rock! Thank you let us know and contribute this optimization. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gao, Liming > Sent: Monday, August

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

On 22 August 2016 at 10:01, Sajjan, Vikas C wrote: > > Hi Ard, > > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, August 22, 2016 12:46 PM > To: Sajjan, Vikas C > Cc: Laszlo Ersek

Re: [edk2] [Patch] BaseTools: add capsule image header for auth FMP capsule file

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Monday, August 22, 2016 3:24 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: add capsule image header for auth FMP capsule > file > >

Re: [edk2] [PATCH] BaseTools/GccBase.lds: don't copy RELA section to PE/COFF

Ard: Thanks for the detail information. Your patch makes sense. Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Monday, August 22, 2016 3:26 PM > To: Gao, Liming

Re: [edk2] [PATCH] IntelFsp2Pkg: Add function to get FspInfoHeader before stack is ready

Reviewed-by: jiewen@intel.com > -Original Message- > From: Yarlagadda, Satya P > Sent: Thursday, August 18, 2016 1:21 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P >

Re: [edk2] [PATCH] IntelSiliconPkg: Fixed VBT size bug, typos and updated comments

Reviewed by: jiewen@intel.com > -Original Message- > From: Mudusuru, Giri P > Sent: Monday, August 22, 2016 1:19 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] IntelSiliconPkg: Fixed VBT size bug, typos and > updated comments > >

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

Hi Ard, -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 22, 2016 12:46 PM To: Sajjan, Vikas C Cc: Laszlo Ersek ; edk2-de...@ml01.01.org; leif.lindh...@linaro.org; Wei, Dong (Office of the CTO)

Re: [edk2] [Patch] BaseTools PeCoffLib: Fix the issue to get RelocationsStripped from TE image

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Monday, August 22, 2016 11:09 AM To: edk2-devel@lists.01.org Cc: Ard Biesheuvel ; Zhu, Yonghong Subject:

Re: [edk2] [Patch] BaseTools PeCoffLib: Fix the issue to get RelocationsStripped from TE image

On 22 August 2016 at 09:07, Gao, Liming wrote: > Ard: > This is done to convert PE/COFF image to TE image. TE image Relocation > VirtualAddress will be set to non-zero. You can find the following logic in > GenFw.c line 2515. Then, PeCoffLib can restore RELOCS_STRIPPED

Re: [edk2] [PATCH] BaseTools/GccBase.lds: don't copy RELA section to PE/COFF

On 22 August 2016 at 09:22, Gao, Liming wrote: > Ard: >Sorry. I miss this patch. GccBase.lds is used by GCC44~GCC5. GCC44~GCC49 > doesn't enable LTO, GCC5 enables LTO. That means RELA section is not used > with LTO or without LTO. Right? The allocatable RELA section

[edk2] [Patch] BaseTools: add capsule image header for auth FMP capsule file

in last commit 91ae29, it missed to add the EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER for the auth FMP capsule. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH] BaseTools/GccBase.lds: don't copy RELA section to PE/COFF

Ard: Sorry. I miss this patch. GccBase.lds is used by GCC44~GCC5. GCC44~GCC49 doesn't enable LTO, GCC5 enables LTO. That means RELA section is not used with LTO or without LTO. Right? Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

On 22 August 2016 at 09:07, Ard Biesheuvel wrote: > On 20 August 2016 at 05:01, Sajjan, Vikas C wrote: >> >> >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, August 19, 2016 6:58 PM >> To: Sajjan,

Re: [edk2] [PATCH] BaseTools/GccBase.lds: don't copy RELA section to PE/COFF

On 10 August 2016 at 10:55, Ard Biesheuvel wrote: > The CLANG38 toolchain creates a PIE binary at link time. This is > necessary since the LTO code generation may otherwise result in > code that cannot execute correctly when loaded above 2 GB. > > PIE executables

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

On 20 August 2016 at 05:01, Sajjan, Vikas C wrote: > > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, August 19, 2016 6:58 PM > To: Sajjan, Vikas C ; edk2-de...@ml01.01.org; >

Re: [edk2] [Patch] BaseTools PeCoffLib: Fix the issue to get RelocationsStripped from TE image

Ard: This is done to convert PE/COFF image to TE image. TE image Relocation VirtualAddress will be set to non-zero. You can find the following logic in GenFw.c line 2515. Then, PeCoffLib can restore RELOCS_STRIPPED flag from TE image. if (((PeHdr->Pe32.FileHeader.Characteristics &

Re: [edk2] [Patch] BaseTools PeCoffLib: Fix the issue to get RelocationsStripped from TE image

On 22 August 2016 at 05:09, Liming Gao wrote: > If PE image has no relocation section, and has not set RELOCS_STRIPPED, > after it is converted to TE image, GenFw will set its relocation section > VirtualAddress to non-zero address, and keep Size value as Zero. I cannot

Re: [edk2] [PATCH 3/6] Vlv2TbltDevicePkg: Declare PciSegmentLib in platform dsc

Reviewed-by: David Wei Thanks, David Wei -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Friday, August 19, 2016 3:35 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D

Re: [edk2] OVMF not booting when built with GCC5 toolset?

Hi Cran, OK. I can reproduce your build failure with GCC 6.1.0. We will take a look at it. Thank you report it. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: Friday, August 19,

[edk2] [PATCH 1/5] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property

Setting the linux,pci-probe-only was intended to align OSes booting via DT with OSes booting via ACPI in the way they honor the PCI configuration performed by the firmware. However, ACPI on arm64 does not currently honor the firmware's PCI configuration, and the linux,pci-probe-only completely

[edk2] [PATCH 4/5] ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support

If the pci-host-ecam-generic DT node describes a 64-bit MMIO region, account for it in the PCI_ROOT_BRIDGE description that we return to the generic PciHostBridgeDxe implementation, which will be able to allocate BARs from it without any further changes. Contributed-under: TianoCore Contribution

[edk2] [PATCH 2/5] ArmVirtPkg: implement FdtPciHostBridgeLib

Implement PciHostBridgeLib for DT platforms that expose a PCI root bridge via a pci-host-ecam-generic DT node. The DT parsing logic is copied from the PciHostBridgeDxe implementation in ArmVirtPkg, with the one notable difference that we don't set the various legacy PCI attributes for IDE and VGA

[edk2] [PATCH 0/5] ArmVirtQemu: move to generic PciHostBridgeDxe

Now that Laszlo's virtio-gpu-pci have removed the last remaining obstacle, we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg, and move to the generic one. This will allow us to perform DMA above 4GB without bounce buffering, and use 64-bit MMIO BARs. Patch #1 removes the

[edk2] [PATCH 3/5] ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe

Wire up the FdtPciHostBridgeLib introduced in the previous patch to the generic PciHostBridgeDxe implementation, and drop the special ArmVirtPkg version. The former's dependency on gEfiCpuIo2ProtocolGuid is satisfied by adding ArmPciCpuIo2Dxe.inf as well, and adding the PCD

[edk2] [Patch] BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix

To avoid the conflict with the default GCC flag name, BUILD_ prefix is added. Cc: Giri P Mudusuru Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

[edk2] [Patch] BaseTools GNU Makefile: Add the missing rules for cpp source file

Cc: Giri P Mudusuru Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/C/Makefiles/footer.makefile | 5 - 1 file changed, 4 insertions(+), 1

Re: [edk2] [PATCH v2 0/6] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Thursday, August 18, 2016 12:54 PM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Wu, Hao A