Re: [edk2] [PATCH 0/3] Display new stack base and size

Series Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Friday, November 4, 2016 10:19 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/3] Display new stack base and

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Do not wakeup AP if only one processor supported

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, November 4, 2016 4:18 PM To: edk2-de...@ml01.01.org Cc: Tian, Feng ; Gao, Liming ; Kinney, Michael D

[edk2] SNP Receive callback

Hi, I am implementing network driver for my arm based Soc which installs SNP protocol. As per explanation of EFI_SIMPLE_NETWORK.Receive() in UEFI spec 2.6, typedef EFI_STATUS (EFIAPI *EFI_SIMPLE_NETWORK_RECEIVE) ( IN EFI_SIMPLE_NETWORK_PROTOCOL *This OUT UINTN *HeaderSize OPTIONAL, IN OUT

Re: [edk2] [PATCH v2 9/9] Nt32Pkg/PlatformBds: Dispatch deferred images after EndOfDxe

Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 08, 2016 8:29 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH v2 9/9] Nt32Pkg/PlatformBds: Dispatch deferred images after > EndOfDxe > > Contributed-under:

Re: [edk2] [PATCH] IntelFsp2Pkg: Support to return error status from FSP API done

The debug message will be displayed only when FSP API returned error status, and when Boot Loader called the subsequent FSP API again. The idea here is to return the control back to Boot Loader if there is any error in the previous API Call, without proceeding further and not having a hang

Re: [edk2] [PATCH V2 0/6] Enable SMM page level protection.

Hi Laszlo I will fix DEBUG message issue in V3 patch. Below is rest issues: l Case 13: S3 fails randomly. A good news: I worked with Jeff Fan to root-cause the S3 resume issue. Here is detail. 1) We believe the dead CPU is AP. Not BSP. The reason is that: 1.1) The BSP already

Re: [edk2] [PATCH] BaseTools/PeCoffLib: Check 'RelocDir' before finding the relocation block

Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Wednesday, November 09, 2016 1:18 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming ; > Zhu, Yonghong > Subject:

[edk2] [PATCH] BaseTools/PeCoffLib: Check 'RelocDir' before finding the relocation block

To match the code logics in MdePkg/Library/BasePeCoffLib, add checks for 'RelocDir' before finding the relocation block. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

Re: [edk2] [Wiki] Draft of documentation for Signed Capsule Feature

HI Mike Thanks for drafting this WIKI page. I have some minor suggestion on https://github.com/mdkinney/edk2/wiki/Capsule-Based-Firmware-Update-and-Firmware-Recovery 1) *[UEFI] OsIndicationsSupported and OsIndications UEFI Variables ==> Current EDKII signed capsule solution does not support

Re: [edk2] [patch] ShellPkg: update ping6 to use timer service instead of timer arch protocol .

Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Tuesday, November 8, 2016 7:08 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Fu, > Siyuan > Subject: [patch]

Re: [edk2] [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if judgments

Bin: Why remove FreePool (Blt)? It is still used. Thanks Liming > -Original Message- > From: Song, BinX > Sent: Tuesday, November 08, 2016 11:01 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdeModulePkg/BootLogoLib: Remove invalid if

Re: [edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

On 9 November 2016 at 04:43, Leif Lindholm wrote: > On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote: >> Declare fields in ECSD structure. And drop the original 128 words >> arrary. > > Functionality-wise, I'm happy with this, if it is moved to directly >

Re: [edk2] [PATCH v4 00/11] enhance MMC

On 9 November 2016 at 01:32, Ryan Harkin wrote: > Hi Haojian, > > I've tested your v4 series. > > On 8 November 2016 at 15:21, Haojian Zhuang wrote: >> v4: >> * Fix PL180 hang in some cases. Since the proper variable length >> isn't set

Re: [edk2] [PATCH v4 09/11] MmcDxe: expand to support multiple blocks

On Tue, Nov 08, 2016 at 11:21:14PM +0800, Haojian Zhuang wrote: > Make use of DMA to transfer multiple blocks at one time. It could > improve the performance on MMC/SD driver. A few style comments inline. > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH v2 7/9] CorebootPayload/PlatformBds: Dispatch deferred images after EndOfDxe

Reviewed-by: Maurice Ma -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 08, 2016 4:29 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Agyeman, Prince Subject: [PATCH v2 7/9] CorebootPayload/PlatformBds:

[edk2] [PATCH] CorebootPayloadPkg: Fix GCC build issue on macro definition

The previous change to disable deprecated APIs in CorebootPayloadPkg used "/D" instead of "-D". It caused Linux GCC build error. Correct it to use "-D" instead. Cc: Prince Agyeman Cc: Rusty Coleman Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v4 07/11] MmcDxe: Fix uninitialized mediaid for SD

On Tue, Nov 08, 2016 at 11:21:12PM +0800, Haojian Zhuang wrote: > When SD card is used, mediaid is not initialized and used directly. So > fix it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang > --- >

[edk2] [Patch] BaseTools/Scripts: Add BinToPcd utility

Add a utility that converts a binary file into a VOID* PCD value or a full DSC file VOID* PCD statement with support for all the DSC supported PCD sections. usage: BinToPcd [-h] [--version] -i INPUTFILE [-o OUTPUTFILE] [-p PCDNAME] [-t {VPD,HII}] [-m MAXSIZE] [-f OFFSET] [-n

Re: [edk2] [PATCH] IntelFsp2Pkg: Support to return error status from FSP API done

Hi Richard, In the below snippet the debug message is based on the API status and will not be display if the switch stack already happened right? Also since it is in a do while loop "cannot proceed further" is not necessarily accurate. > - SetFspApiReturnStatus (EFI_SUCCESS); > - > -

[edk2] [PATCH] IntelSiliconPkg: Add FFS GUID for Graphics VBT

Added FFS GUID gIntelGraphicsVbtDataGuid to store Graphics Video BIOS Table (VBT) in the raw format. Cc: Jiewen Yao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru ---

Re: [edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

On Tue, Nov 08, 2016 at 11:21:10PM +0800, Haojian Zhuang wrote: > Declare fields in ECSD structure. And drop the original 128 words > arrary. Functionality-wise, I'm happy with this, if it is moved to directly after "add SPEC_VERS field in CSD structure". A few comments inline with regards to

Re: [edk2] [PATCH v4 03/11] MmcDxe: add SPEC_VERS field in CSD structure

On Tue, Nov 08, 2016 at 11:21:08PM +0800, Haojian Zhuang wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 3 ++- > 1

Re: [edk2] [PATCH v4 02/11] MmcDxe: move ECSD into CardInfo structure

On Tue, Nov 08, 2016 at 11:21:07PM +0800, Haojian Zhuang wrote: > Since ECSD also describes the information of card, move it into > structure CardInfo. I like the fact that you have split out the "move ECSD to CARD_INFO" and "declare ECSD structure", to keep the two logically separate

Re: [edk2] [PATCH v4 01/11] MmcDxe: wait OCR busy bit free

On Tue, Nov 08, 2016 at 11:21:06PM +0800, Haojian Zhuang wrote: > According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy > bit is '0', CMD1 should be sent and OCR should be fetched again. And add > a timeout counter on the repeated steps. > > Contributed-under: TianoCore

[edk2] [Wiki] Draft of documentation for Signed Capsule Feature

Hello, I have started a draft of Wiki pages that describe how to use and verify the Signed Capsule feature from Jiewen Yao. I have focused this first draft on the system firmware update use case for signed capsules.

Re: [edk2] [PATCH v4 00/11] enhance MMC

Hi Haojian, I've tested your v4 series. On 8 November 2016 at 15:21, Haojian Zhuang wrote: > v4: > * Fix PL180 hang in some cases. Since the proper variable length > isn't set for CMD6 & ACMD51. > > v3: > * Fix PL180 hang because of CMD6 & ACMD51 not

Re: [edk2] [PATCH v2 8/9] QuarkPlatformPkg/PlatformBds: Dispatch deferred images after EndOfDxe

Reviewed-by: Michael Kinney > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, November 8, 2016 4:29 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [PATCH v2 8/9]

[edk2] [PATCH v4 01/11] MmcDxe: wait OCR busy bit free

According to eMMC spec, OCR.PowerUp bit is also busy bit. If the busy bit is '0', CMD1 should be sent and OCR should be fetched again. And add a timeout counter on the repeated steps. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang

[edk2] [PATCH v4 02/11] MmcDxe: move ECSD into CardInfo structure

Since ECSD also describes the information of card, move it into structure CardInfo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 +

[edk2] [PATCH v4 10/11] PL180: update for indentifying SD

When CMD6 & ACMD51 are added into indentifying SD process, PL180 should also support CMD6 & ACMD51. Otherwise, it'll hang when system tries to read expected data. Signed-off-by: Haojian Zhuang --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 15 ++- 1

[edk2] [PATCH v4 08/11] MmcDxe: set iospeed and bus width in SD stack

Add more SD commands to support 4-bit bus width & iospeed. It's not formal code. And it needs to be updated later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Include/Protocol/MmcHost.h | 3 +

[edk2] [PATCH v4 11/11] PL180: set variable length for CMD6 and ACMD51

Since CMD6 & ACMD51 needs to read data size less than 512, proper variable length should be set. Signed-off-by: Haojian Zhuang Tested-by: Ryan Harkin --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 14 -- 1 file changed, 8

[edk2] [PATCH v4 06/11] MmcDxe: set io bus width before reading EXTCSD

Set io bus width on both MMC controller and EXTCSD. Otherwise, it may cause unmatched failure case. And support more timing mode, high speed, HS200 & HS400 mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang ---

[edk2] [PATCH v4 07/11] MmcDxe: Fix uninitialized mediaid for SD

When SD card is used, mediaid is not initialized and used directly. So fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 ++- 1 file changed, 6 insertions(+), 1

[edk2] [PATCH v4 04/11] MmcDxe: add interface to change io width and speed

By default, MMC is initialized with 1-bit mode and less than 400KHz bus clock. It causes MMC working inefficiently. Add the interface to change the bus width and speed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang ---

[edk2] [PATCH v4 05/11] MmcDxe: declare ECSD structure

Declare fields in ECSD structure. And drop the original 128 words arrary. Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 157 ++- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 4 +- 2 files changed, 158

[edk2] [PATCH v4 03/11] MmcDxe: add SPEC_VERS field in CSD structure

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe/Mmc.h

Re: [edk2] [PATCH] PL180: set variable length for CMD6 and ACMD51

On 8 November 2016 at 22:58, Leif Lindholm wrote: > On Tue, Nov 08, 2016 at 12:37:12PM +, Ryan Harkin wrote: >> Hi Haojian, >> >> On 7 November 2016 at 15:49, Haojian Zhuang >> wrote: >> > Since CMD6 & ACMD51 needs to read data size less

Re: [edk2] [PATCH] PL180: set variable length for CMD6 and ACMD51

On Tue, Nov 08, 2016 at 12:37:12PM +, Ryan Harkin wrote: > Hi Haojian, > > On 7 November 2016 at 15:49, Haojian Zhuang wrote: > > Since CMD6 & ACMD51 needs to read data size less than 512, proper > > variable length should be set. > > > > Yay! Thanks for working

Re: [edk2] [PATCH v2 2/9] MdeModulePkg/UefiBootManager: Add EfiBootManagerDispatchDeferredImages

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 08, 2016 8:29 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Zhang, Chao B Subject: [PATCH v2 2/9] MdeModulePkg/UefiBootManager: Add

Re: [edk2] [PATCH v2 3/9] MdeModulePkg/BdsDxe: Check deferred images before booting to OS

Reviewed-by : Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 08, 2016 8:29 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Zhang, Chao B Subject: [PATCH v2 3/9] MdeModulePkg/BdsDxe: Check deferred

Re: [edk2] [PATCH V2 0/6] Enable SMM page level protection.

Yes, it is a good idea to check "(mSmmMpSyncData->EffectiveSyncMode == SmmCpuSyncModeTradition)". I agree. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, November 8, 2016 9:23 PM To: Yao, Jiewen Cc: Tian, Feng ;

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Do not wakeup AP if only one processor supported

On 11/08/16 01:55, Fan, Jeff wrote: > Laszlo, > > Oh. Sorry for the question mark in my last sentence and confusing you. :-) it > should be point. It's my typo. > > MP PPI and the protocol DO exist even there is only one processor in the > system. > > Thanks! > Jeff Thanks. With that

Re: [edk2] [PATCH V2 0/6] Enable SMM page level protection.

On 11/08/16 13:59, Yao, Jiewen wrote: > HI Laszlo > > Thanks for the detail test result. > > > > Quick comment for the debug message: > > 1) For “ConvertPageEntryAttribute 0x7F92B067->0x7F92B065”, I agree > to change to DEBUG_VERBOSE, because it pure debug purpose. > > > > 2)

[edk2] [PATCH] ArmPkg/ArmDmaLib: add support for fixed host-to-device DMA offset

Some devices, such as the Raspberry Pi3, have a fixed offset between memory addresses as seen by the host and as seen by the other bus masters. So add a new PCD that allows this fixed offset to be recorded, and to be used when returning device addresses from the DmaLib mapping routines.

Re: [edk2] [PATCH v2 6/9] OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe

On 11/08/16 13:29, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 5 +

Re: [edk2] [PATCH V2 0/6] Enable SMM page level protection.

HI Laszlo Thanks for the detail test result. Quick comment for the debug message: 1) For "ConvertPageEntryAttribute 0x7F92B067->0x7F92B065", I agree to change to DEBUG_VERBOSE, because it pure debug purpose. 2) For "!mSmmMpSyncData->CpuData[1].Present", I think people has interest

Re: [edk2] [PATCH v2 5/9] ArmVirPkg/PlatformBds: Dispatch deferred images after EndOfDxe

On 11/08/16 13:29, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > --- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 5

Re: [edk2] [PATCH] PL180: set variable length for CMD6 and ACMD51

Hi Haojian, On 7 November 2016 at 15:49, Haojian Zhuang wrote: > Since CMD6 & ACMD51 needs to read data size less than 512, proper > variable length should be set. > Yay! Thanks for working out what the problem was with TC2. I've tested this patch on top of your v3

[edk2] [PATCH v2 9/9] Nt32Pkg/PlatformBds: Dispatch deferred images after EndOfDxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Eric Dong --- Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2] [PATCH v2 4/9] MdeModulePkg/SecurityStubDxe: Report failure if image is load earlier

The 3rd party image should be loaded after EndOfDxe event signal and DxeSmmReadyToLock protocol installation. But non-SMM platform doesn't published DxeSmmReadyToLock protocol. So the SecurityStubDxe can only depend on EndOfDxe event. This patch enhances the SecurityStubDxe to listen on

[edk2] [PATCH v2 6/9] OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jordan Justen Cc: Laszlo Ersek --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2] [PATCH v2 8/9] QuarkPlatformPkg/PlatformBds: Dispatch deferred images after EndOfDxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Michael D Kinney Cc: Kelly Steele --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 7 ++- 1 file changed, 6

[edk2] [PATCH v2 5/9] ArmVirPkg/PlatformBds: Dispatch deferred images after EndOfDxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 5 + 1 file changed, 5 insertions(+) diff

[edk2] [PATCH v2 7/9] CorebootPayload/PlatformBds: Dispatch deferred images after EndOfDxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Maurice Ma Cc: Prince Agyeman --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 5 + 1 file changed, 5

[edk2] [PATCH v2 3/9] MdeModulePkg/BdsDxe: Check deferred images before booting to OS

The patch adds check of deferred images before booting to OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao Cc: Chao B Zhang --- MdeModulePkg/Universal/BdsDxe/Bds.h | 4 +-

[edk2] [PATCH v2 1/9] MdeModulePkg/SecurityStubDxe: Defer 3rd party image before EndOfDxe

The images not from FV are treated as 3rd party images. They will be deferred to dispatch when they are dispatched before EndOfDxe event. It's a new feature in the BS.LoadImage() path which can disallow executing 3rd party images before EndOfDxe and re-execute them after EndOfDxe (through

[edk2] [PATCH v2 2/9] MdeModulePkg/UefiBootManager: Add EfiBootManagerDispatchDeferredImages

The API dispatches the deferred images that are returned from all DeferredImageLoad instances. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Liming Gao Cc: Chao B Zhang ---

[edk2] [PATCH v2 0/9] Defer 3rd party images loading to after EndOfDxe

The patches change the default image loading policy by deferring 3rd party images loading to after EndOfDxe and add a new BDS API to dispatch the deferred images. Platform needs to call the new BDS API EfiBootManagerDispatchDeferredImages after EndOfDxe to ensure that any deferred images are

[edk2] [patch] ShellPkg: update ping6 to use timer service instead of timer arch protocol .

This patch update the shell ping command to use timer service to calculate the RTT time, instead of using the timer arch protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Ni Ruiyu Cc: Ye Ting

Re: [edk2] [PATCH] MdeModulePkg/PciSioSerial: Fix a bug that wrongly produces 2 UARTs

Reviewed-by: Star Zeng -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 8, 2016 10:36 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH] MdeModulePkg/PciSioSerial: Fix a bug that wrongly