Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of Eric Dong
> Sent: Wednesday, July 25, 2018 3:50 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Laszlo Ersek
> Subject: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and
> volatile
Eric,
Please also include the state machine in comments for ENUM CPU_STATE definition.
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, July 25, 2018 7:15 PM
> To: Laszlo Ersek ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: RE: [edk2] [P
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 10 ++
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 +-
2 files changed, 7 insertions(
-N option is used to append a Capsule Header to an existing
FMP capsule image with its ImageTypeId supported by the system.
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Application/Capsul
Also adjust the help information to be not too long to be suitable
for different display resolutions.
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 13
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Application/CapsuleApp/Ca
The build failure is like below.
xxx\CapsuleApp.c(868) : error C2275: 'EFI_GUID' :
illegal use of this type as an expression
xxx/UefiBaseType.h(29) : see declaration of 'EFI_GUID'
xxx\CapsuleApp.c(868) : error C2146: syntax error :
missing ';' before identifier 'ImageTypeId'
xxx\Capsule
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Yonghong Zhu
Star Zeng (5):
MdeModulePkg CapsuleApp: Fix VS2012 build failure caused by 5410502
MdeModulePkg CapsuleApp: Fix -D failed to dump Nest FMP capsule
MdeModulePkg CapsuleApp: Refine -N option help information
MdeModulePkg CapsuleApp: Ind
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: David Wei
CC: Kelly Steele
CC: Mike Wu
CC: Mang Guo
---
.../SouthCluster/Include/Library/I2CLib.h | 4 +-
.../SouthCluster/Include/ScRegs/RegsI2c.h | 31 +-
.../SouthCluster/Library/I2CLib/I2CLib.c
From: Yunhua Feng
Fix build crash when fdf is empty file
Fix https://bugzilla.tianocore.org/show_bug.cgi?id=912
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 ++
1 file c
在 7/25/2018 6:51 PM, Ard Biesheuvel 写道:
> On 13 July 2018 at 10:15, Ming Huang wrote:
>> Fix the issue of onboard Nic not work kerenl with AMD GPU and
>> NVME SSD in board. The GPU don't support 64 MSI, so need to
>> allocate INTx, but the default interrupt number 255 is invalid,
>> so Change al
Some redundant libraray classes and guides have been removed in inf files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1017
https://bugzilla.tianocore.org/show_bug.cgi?id=1035
https://bugzilla.tianocore.org/show_bug.cgi?id=1033
https://bugzilla.tianocore.org/show_bug.cgi?id=1012
https://bugzilla
Good, the patch is not push, I can update it.
Best Regards,
Zhu Yonghong
-Original Message-
From: Carsey, Jaben
Sent: Thursday, July 26, 2018 9:24 AM
To: Zhu, Yonghong
Cc: edk2-devel@lists.01.org; Gao, Liming
Subject: Re: [edk2] [PATCH] BaseTools: Parse decimal format INF_VERSION
inc
Can we change the code to allocate fewer strings?
'0x' + '{0:04x}{1:04x}'.format(...)
Could be just:
'0x{0:04x}{1:04x}'.format(...
Jaben
> On Jul 25, 2018, at 5:41 PM, Zhu, Yonghong wrote:
>
> Reviewed-by: Yonghong Zhu
>
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
>
Allow the caller of the top-level makefile either to set EXTRA_OPTFLAGS in
the environment or to pass EXTRA_OPTFLAGS as a macro definition on the
command line. EXTRA_OPTFLAGS extends (and potentially overrides) default C
compilation flags set in the makefiles.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref
The option "-O2" is not a preprocessor flag, but a code generation
(compilation) flag. Move it from BUILD_CPPFLAGS to BUILD_CFLAGS and
BUILD_CXXFLAGS.
Because "VfrCompile/GNUmakefile" uses "-O2" through BUILD_CPPFLAGS, and
because it doesn't use BUILD_CXXFLAGS, we have to introduce BUILD_OPTFLAGS
Repo: https://github.com/lersek/edk2.git
Branch: extra_flags_rhbz1540244
In the Fedora distribution, we'd like to pass system-wide flags related
to optimization and linking when the C and C++ language base tools are
built. This series lets the outermost "make" command push the
EXTRA_OPTFLAGS and
Option "-c" is a mode selection flag (choosing between compiling and
linking); it should not be in BUILD_CFLAGS, which applies only to
compiling anyway. The compilation rule for C source files, in
"footer.makefile", already includes "-c" -- currently we have double "-c"
options.
This patch doesn't
Allow the caller of the top-level makefile either to set EXTRA_LDFLAGS in
the environment or to pass EXTRA_LDFLAGS as a macro definition on the
command line. EXTRA_LDFLAGS extends (and potentially overrides) default
link-editing flags set in the makefiles.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: ht
(1) "-I" and "-D" options are for the preprocessor; move them to
BUILD_CPPFLAGS. (This unifies BUILD_CPPFLAGS between both makefiles.)
(2) COTHER is never set, drop it from "antlr". (This unifies BUILD_CFLAGS
between both makefiles, as COPT.)
(3) For linking "antlr" and "dlg", both BUILD_
BUILD_CPPFLAGS should be expanded before BUILD_CFLAGS. (The rule for C++
source files already does this, with BUILD_CPPFLAGS and BUILD_CXXFLAGS.)
This patch doesn't change behavior.
Cc: Liming Gao
Cc: Yonghong Zhu
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1540244
Contributed-under: Tiano
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Wednesday, July 25, 2018 8:47 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [Patch] BaseTools: Fix bug ab
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Wednesday, July 25, 2018 11:41 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [edk2] [PATCH] BaseTools: Parse dec
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Monday, July 23, 2018 2:03 PM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng
Subject: [edk2] [PATCH] BaseTools/Ecc: Add som
Never mind most of that. I have to figure out how to configure gitk to show
.dsc changes. It's all good.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Wednesday, July 25, 2018 1:47 PM
> To: Alexei Fedorov ; Ni, Ruiy
Alexei,
I did it, but I just realized it looks like it didn't make a change. Shoot. I
think it was already pushed, but I am not sure.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Alexei Fedorov
> Sent: Wednesday, July 25, 2018
FvSimpleFileSystem on read always allocates a FileBuffer, and never frees
it. This causes memory leaks. It is especially bad for reading scripts
line-by-line. In some cases memory leak can exceed 1GB.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vladimir Olovyannikiov
--
Hello,
Is there anything else to be done to get this patch pushed?
Thanks.
Alexei
From: edk2-devel on behalf of Ni, Ruiyu
Sent: 18 July 2018 03:38:58
To: edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to
Note: I changed the subject as this is not about Laszlo's patch at this point.
Liming,
I agree. We definitely need to balance performance and features. I didn't say
we should add it; I assumed it was already there.
Was there any side effect of a misnamed library class? Could a module have
u
On 07/25/18 13:35, Dong, Eric wrote:
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, July 25, 2018 6:14 PM
>> To: Dong, Eric ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> On 07/25/18 05:50, Dong, Eric wrote:
>>> But some AP may wake up later and it failed to return from the
On 07/25/18 14:12, Laszlo Ersek wrote:
> On 07/25/18 09:50, Eric Dong wrote:
>> This patch series include changes:
>> 1. StartAllAPs should not use disabled APs, this is required by UEFI spec.
>> 2. Refine the code to remove the redundant definitions.
>>
>> V2 changes:
>> Use CpuStateReady to dis
On 07/25/18 14:09, Dong, Eric wrote:
> Hi Laszlo,
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, July 25, 2018 7:47 PM
>> To: Dong, Eric ; edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu
>> Subject: Re: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib:
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 2:44 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Zhang, Chao B
> Subject: [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro
>
> Add an example case for the usage of
> PERF
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan
> Bi
> Sent: Thursday, July 19, 2018 2:44 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Gao, Liming
> Subject: [edk2] [patch 1/2] MdeModulePkg/DxeLoadFunc:
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 25, 2018 8:12 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP
> when call StartAllAPs.
>
>
On 07/25/18 09:50, Eric Dong wrote:
> This patch series include changes:
> 1. StartAllAPs should not use disabled APs, this is required by UEFI spec.
> 2. Refine the code to remove the redundant definitions.
>
> V2 changes:
> Use CpuStateReady to distinguish the AP state from CpuStateIdle.
>
>
Hi Eric,
On 07/25/18 09:50, Eric Dong wrote:
> Base on UEFI spec requirement, StartAllAPs function should not
> use the APs which has been disabled before. This patch just
> change current code to follow this rule.
>
> V3 changes:
> Only called by StartUpAllAps, WakeUpAp will not wake up
> the di
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 25, 2018 7:47 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount
> and volatile definition.
>
>
Hi Eric,
On 07/25/18 09:50, Eric Dong wrote:
> The StartCount is duplicated with RunningCount, replace it with
> RunningCount. Also the volatile for RunningCount is not needed.
after staring at this patch for a long time, I think it is correct.
However, I suggest that we improve the commit messag
On 24 July 2018 at 08:32, Ming Huang wrote:
> The major features of this patchset include:
> 1 switching to generic PciHostBridge driver;
> 2 Change DEBUG log level;
>
> Code can also be found in github:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: pcihostbridge-v2
>
>
> Heyi Guo
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 25, 2018 6:14 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Remove redundant
> parameter.
>
> On 07/25/18 05:50,
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 25, 2018 6:55 PM
> To: Dong, Eric ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu
> Subject: Re: [edk2] [Patch v3 1/3] UefiCpuPkg/MpInitLib: Remove redundant
> CpuStateFinished State.
>
> H
On 4 July 2018 at 09:49, Ming Huang wrote:
> Code can also be found in github:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: edk2-non-osi-20180627-v1
>
> Ming Huang (1):
> Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug
>
Reviewed-by: Ard Biesheuvel
Pushed to edk2
On 13 July 2018 at 10:15, Ming Huang wrote:
> The major features of this patchset include:
> 1 Fix invoke SetMemorySpaceAttributes error bug
> 2 Correct ATU Cfg0/Cfg1 base address
> 3 Fix SetAtuConfig1RW bug
> 4 Add PlatformMiscDxe driver
> 5 optimize two pcie prots space
> 6 Correct smbios produc
Hi Eric,
On 07/25/18 09:50, Eric Dong wrote:
> Current CPU state definition include CpuStateIdle and CpuStateFinished.
> After investigation, current code can use CpuStateIdle to replace the
> CpuStateFinished. It will reduce the state number and easy for maintenance.
>
> Cc: Laszlo Ersek
> Cc: R
On 13 July 2018 at 10:15, Ming Huang wrote:
> Fix the issue of onboard Nic not work kerenl with AMD GPU and
> NVME SSD in board. The GPU don't support 64 MSI, so need to
> allocate INTx, but the default interrupt number 255 is invalid,
> so Change all the PCI Device interrupt number to 0.
>
> Cont
2018-07-25 12:01 GMT+02:00 Ard Biesheuvel :
> On 13 July 2018 at 16:09, Marcin Wojtas wrote:
>> From: Grzegorz Jaszczyk
>>
>> Replace the ComPhy initialization for PCIE with appropriate SMC call,
>> so the firmware will execute required serdes configuration.
>>
>
> 'the firmware' ?
Will change t
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index 091f950b95b2..f0
Add DISABLE_NEW_DEPRECATED_INTERFACES build options to make sure
no deprecated interface used in this package.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
FmpDevicePkg/FmpDevicePkg.dsc | 3 +++
1 file changed, 3 insertions(+)
diff -
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index f0e8b0da823a..69b6cb7d4c0d 100644
--- a/Fmp
On 07/25/18 05:50, Dong, Eric wrote:
> Hi Laszlo,
>
> I have root cause this issue, the AP hangs in the procedure when
> PiSmmCpuDxeSmm driver start up trigged this issue.
>
> When PiSmmCpuDxeSmm driver start up, it will call StartAllAps to set
> memory attribute. In StartAllAps function, after ca
On 23 July 2018 at 15:19, Sumit Garg wrote:
> OP-TEE is optional on Developerbox controlled via SCP firmware. To check
> if we need to delete OP-TEE DT node, we use DRAM1 region info as SCP
> firmware conditionally carves out Secure memory from DRAM1 region.
>
> Cc: Ard Biesheuvel
> Cc: Leif Lind
On 13 July 2018 at 16:09, Marcin Wojtas wrote:
> Hi,
>
> This patchset makes use of the feature present in newest,
> publicly available ARM-TF of the Armada7k8k SoCs
> (https://github.com/MarvellEmbeddedProcessors/atf-marvell/commits/atf-v1.4-armada-18.06)
> which is a common configuration of the
On 13 July 2018 at 16:09, Marcin Wojtas wrote:
> From: Grzegorz Jaszczyk
>
> Replace the ComPhy initialization for PCIE with appropriate SMC call,
> so the firmware will execute required serdes configuration.
>
'the firmware' ?
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-
2018-07-25 11:33 GMT+02:00 Ard Biesheuvel :
> On 13 July 2018 at 10:12, Marcin Wojtas wrote:
>> Hi,
>>
>> The second version of the ICU patchset brings all corrections
>> according to all review remarks. They were mostly style / naming
>> - detailed list can be found in the changelog below.
>>
>>
On 24 July 2018 at 06:51, Thomas Abraham wrote:
> Changes since v1:
> - Removed 'Change-Id' from the patch description
>
> This patch series includes few updates for Arm's SGI platform. The virtio
> block device representation in the ACPI table, setting default fifo size
> for the uart controller,
On 13 July 2018 at 10:12, Marcin Wojtas wrote:
> Hi,
>
> The second version of the ICU patchset brings all corrections
> according to all review remarks. They were mostly style / naming
> - detailed list can be found in the changelog below.
>
> The patches are available in the github:
> https://gi
Ting:
Please find the patch for reference.
Index: HttpProto.c
===
--- HttpProto.c
+++ HttpProto.c
@@ -622,12 +622,20 @@
Status = HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, Tcp4CfgData);
if (EFI_ERROR (Status)) {
D
From: xianhuix
Reduce fv size for gcc debug build
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: xianhuix
---
.../BroxtonPlatformPkg/PlatformDsc/Components.dsc | 30 +-
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/Platform/Broxton
Hi Siva,
I didn't receive your patch either. Thanks for reporting the issue, we will try
to reproduce it firstly.
Thanks,
Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Tuesday, July 24, 2018 8:43 PM
To: Sivaraman Naina
This patch series include changes:
1. StartAllAPs should not use disabled APs, this is required by UEFI spec.
2. Refine the code to remove the redundant definitions.
V2 changes:
Use CpuStateReady to distinguish the AP state from CpuStateIdle.
V3 Changes:
Only change 3/3 patch. Only not use di
The StartCount is duplicated with RunningCount, replace it with
RunningCount. Also the volatile for RunningCount is not needed.
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 +
Current CPU state definition include CpuStateIdle and CpuStateFinished.
After investigation, current code can use CpuStateIdle to replace the
CpuStateFinished. It will reduce the state number and easy for maintenance.
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreem
Base on UEFI spec requirement, StartAllAPs function should not
use the APs which has been disabled before. This patch just
change current code to follow this rule.
V3 changes:
Only called by StartUpAllAps, WakeUpAp will not wake up
the disabled APs, in other cases also need to include the
disabled
64 matches
Mail list logo
