Re: [edk2] [Patch 0/5] Support windowsize to benefit tftp/pxe download performance.

2018-09-20 Thread Wu, Jiaxin
Hi Laszlo, > > If that's the case, should we consider the three drivers under > "MdeModulePkg/Universal/Network/" deprecated, and should we abandon > them > completely? > I think the answer is NO (At least for now). In my opinion, the drivers in MdeModulePkg is also useful in some case, becau

[edk2] [Patch][edk2-staging/UEFIPayload] Add maintainers' info

2018-09-20 Thread Tang, Xiaohu
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Tang Xiaohu --- Maintainers.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 Maintainers.txt diff --git a/Maintainers.txt b/Maintainers.txt new file mode 100644 index 00..60b2158610 --- /dev/null

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs

2018-09-20 Thread Zeng, Star
Jian and Laszlo, There is also a superficial comment at below. On 2018/9/20 14:02, Jian J Wang wrote: v2 changes: a. remove macros no longer needed b. remove DEBUG and ASSERT in ToEnableExecuteDisableFeature() c. change ToEnableExecuteDisableFeature to EnableNonExec BZ#1116: https

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/MdeModulePkg.dec/.uni: clarify PCDs usage

2018-09-20 Thread Zeng, Star
Jian, The clarifications are very good. There is a very superficial comment at below. On 2018/9/20 14:02, Jian J Wang wrote: v2 changes: Newly added patch to clarify PCDs usage. BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116 The usage of following PCDs described in MdeModul

Re: [edk2] [PATCH v2] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function run the same position

2018-09-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Friday, September 21, 2018 8:56 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Dong, Eric ; > Yao, Jiewen > Subject: [PATCH v2] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry > function run the same posi

Re: [edk2] [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file.

2018-09-20 Thread Zeng, Star
As I remember, I raised comment about removing the PalLib in MdeModulePkg.dsc at https://lists.01.org/pipermail/edk2-devel/2018-June/026079.html. I'd like suggest updating the title and commit message a little. For title: How about "MdeModulePkg: Remove PalLib in dsc which was missed at de00522

Re: [edk2] [PATCH] MdeModulePkg CapsuleApp:Remove two redundant Guids

2018-09-20 Thread Zeng, Star
Reviewed-by: Star Zeng and pushed it at 8c06d18bc112c7b0547641e83a508c6784317f72. Thanks, Star -Original Message- From: Zhang, Shenglei Sent: Thursday, September 20, 2018 4:55 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric Subject: [PATCH] MdeModulePkg CapsuleApp:Remove two

Re: [edk2] [PATCH v4 0/3] SdMmc fixes

2018-09-20 Thread Wu, Hao A
The series is good to me. Reviewed-by: Hao Wu I will push the changes and update the relating Bugzilla trackers. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marcin Wojtas > Sent: Tuesday, September 18, 2018 4:59 P

Re: [edk2] [PATCH v1 1/5] MdePkg/BaseLib: Add new LoadFence API

2018-09-20 Thread Wu, Hao A
Hi Ard and Leif, This commit aims to add to a new BaseLib API to implement the serializing load operations functionality (for IA32/X64, called LFENCE). For the 1st version of this commit, this API is named as 'LoadFence'. The implementation only covers IA32/X64 arch, and does an empty implementat

Re: [edk2] [PATCH v1 1/5] MdePkg/BaseLib: Add new LoadFence API

2018-09-20 Thread Yao, Jiewen
Thanks Laszlo. That is very good feedback. For ARM, I think we need use *CSDB*. :-) Thank you Yao Jiewen > -Original Message- > From: Wu, Hao A > Sent: Friday, September 21, 2018 10:15 AM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Gao, Liming

Re: [edk2] [PATCH v1 1/5] MdePkg/BaseLib: Add new LoadFence API

2018-09-20 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, September 20, 2018 9:13 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Kinney, Michael D; Yao, Jiewen; Gao, Liming > Subject: Re: [edk2] [PATCH v1 1/5] MdePkg/Ba

Re: [edk2] [PATCH v1 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-20 Thread Wu, Hao A
Hi Mike, We found that this API needs to be inserted within file: MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c which is in module: MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf This module (INF file) is consumed by the AARCH64/ARM architectures as well. That is the r

Re: [edk2] [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC file.

2018-09-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Chen, Chen A > Sent: Friday, September 21, 2018 9:00 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Yao, Jiewen > ; Kinney, Michael D > Subject: [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC > file. >

[edk2] [PATCH 3/3] SignedCapsulePkg: Remove the missing PalLib in DSC file.

2018-09-20 Thread Chen A Chen
The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Jiewen Yao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- SignedCapsulePkg/SignedCapsulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/SignedCapsuleP

[edk2] [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file.

2018-09-20 Thread Chen A Chen
The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Star Zeng Cc: Eric Dong Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- MdeModulePkg/MdeModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModul

[edk2] [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file.

2018-09-20 Thread Chen A Chen
The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/

[edk2] [PATCH v2] UefiCpuPkg PiSmmCpuDxeSmm: Update SmiEntry function run the same position

2018-09-20 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1191 Before commit e21e355e2ca7fefb15b4df7078f995d3fb9c2b89, jmp _SmiHandler is commented. And below code, ASM_PFX(CpuSmmDebugEntry) is moved into rax, then call it. But, this code doesn't work in XCODE5 tool chain. Because XCODE5 doesn't generate

Re: [edk2] question about uefi shell-current working directory and shell-script

2018-09-20 Thread krishnaLee
Carsey, The shell may not have a file system assigned, yes but when it find the stript(startup.nsh) file,it has the default file system-->the startup.nsh's file system, so the default cwd should exist,I think it is strange that start doing script without a default cwd, currently, without a de

Re: [edk2] SPI Flash Corruption

2018-09-20 Thread Yao, Jiewen
thank you, Samah. Would you please file a tracker in edkii bugzilla ? The term VPD might lead confusion here. Ideally VPD region is independent with UEFI variable region. It is a special region to hold PCD with VPD type. I just look at the code. The open source minnowmax puts variable region i

Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin

2018-09-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Desimone, Nathaniel L Sent: Tuesday, September 18, 2018 11:04 PM To: Patrick Georgi ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo in Spli

[edk2] [PATCH v3 6/7] MdePkg/UefiBaseType.h: treat EBC as a non-native machine type

2018-09-20 Thread Ard Biesheuvel
Instead of classifying EBC as a supported machine type and have special handling in DXE core for loading EBC images, make it a foreign type and rely on the EDK2 PE/COFF image emulator protocol to claim the image when the DXE core finds that it cannot be supported natively. Contributed-under: Tiano

[edk2] [PATCH v3 3/7] MdeModulePkg/PciBusDxe: invoke PE/COFF emulator for foreign option ROMs

2018-09-20 Thread Ard Biesheuvel
When enumerating option ROM images, take into account whether an emulator exists that would allow dispatch of PE/COFF images built for foreign architectures. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h

[edk2] [PATCH v3 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol

2018-09-20 Thread Ard Biesheuvel
Implement the new EDK2 PE/COFF image emulator protocol so that we can remove the EBC specific handling in the DXE core and other places in the core code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/EbcDxe/EbcDxe.inf | 3 + Md

[edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2018-09-20 Thread Ard Biesheuvel
Introduce a protocol that can be invoked by the image loading services to execute foreign architecture PE/COFF images via an emulator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 102 +

[edk2] [PATCH v3 7/7] MdeModulePkg/DxeCore: remove explicit EBC handling

2018-09-20 Thread Ard Biesheuvel
Now that the EBC machine type is no longer classified as a natively supported machine type on the architectures that can support it via the EBC interpreter, the EBC specific handling in DXE core is no longer used and can be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-of

[edk2] [PATCH v3 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images

2018-09-20 Thread Ard Biesheuvel
Allow PE/COFF images that must execute under emulation for Driver options, by relaxing the machine type check to include support for machine types that is provided by an emulator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Library/U

[edk2] [PATCH v3 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2018-09-20 Thread Ard Biesheuvel
When encountering PE/COFF images that cannot be supported natively, attempt to locate an instance of the PE/COFF image emulator protocol, and if it supports the image, proceed with loading it and register it with the emulator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH v3 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2018-09-20 Thread Ard Biesheuvel
Add the basic plumbing to DXE core, the PCI bus driver and the boot manager to allow PE/COFF images to be dispatched that target an architecture that is not native for the platform, but which is supported by one of potentially several available emulators. One implementation of such an emulator can

Re: [edk2] Stack issue after warm UEFI reset and MMU enabling on an Armv8 platform

2018-09-20 Thread Vladimir Olovyannikov
On Wed, Sep 19, 2018 at 5:21 PM Bill Paul wrote: > > Of all the gin joints in all the towns in all the world, Vladimir > Olovyannikov > had to walk into mine at 16:58 on Wednesday 19 September 2018 and say: > > > >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > >Sent: Wednesday, Septem

Re: [edk2] [Question] Testing environment regarding SMM driver

2018-09-20 Thread Andrew Fish
> On Sep 20, 2018, at 7:30 AM, poxyran wrote: > > Hello, > > I have a specific question regarding SMM drivers. I'm trying to create a > mixed driver as mentioned here > http://blog.cr4.sh/2015/07/building-reliable-smm-backdoor-for-uefi.html > and my first try is to create a kind of 'Hello Wor

[edk2] UEFIPayload build issue

2018-09-20 Thread Wim Vervoorn
Hello, I am trying to build the new UEFIPayload from the staging repo. The build proceeds pretty well but then I got this message: Traceback (most recent call last): File "C:\Python27\lib\site-packages\cx_Freeze\initscripts\Console.py", line 27, in exec(code, m.__dict__) File "GenFds

[edk2] [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts

2018-09-20 Thread Steele, Kelly
>From 62aef5b6fdb4e85878bafed4ab9c41631689b69d Mon Sep 17 00:00:00 2001 From: Kelly Steele Date: Thu, 20 Sep 2018 10:47:06 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Clean up build scripts Went thru the build scripts and cleaned them up. There was a couple of "magic" nu

Re: [edk2] SPI Flash Corruption

2018-09-20 Thread Samah Mansour
Hi Laszlo, Thanks for your reply. Actually what I see is that VPD (Vital Product Area between addresses 44000->47DFF0 ) is completely wiped which causes the failure to boot! Without the VPD unit cannot boot. I will take a look at the white paper. It would be helpful to know what's the impact of di

[edk2] [Question] Testing environment regarding SMM driver

2018-09-20 Thread poxyran
Hello, I have a specific question regarding SMM drivers. I'm trying to create a mixed driver as mentioned here http://blog.cr4.sh/2015/07/building-reliable-smm-backdoor-for-uefi.html and my first try is to create a kind of 'Hello World'. My try is to install a SMI handler and call it from a user-m

Re: [edk2] question about uefi shell-current working directory and shell-script

2018-09-20 Thread Carsey, Jaben
When the shell starts, it the prompt "shell>" or something like "fs0:>"... The shell may not have a file system assigned yet so you cannot change directories until you pick a file system. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > kris

Re: [edk2] [PATCH v1 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-20 Thread Kinney, Michael D
Hao Wu, I see that implementations of this API are only provided for IA32 and X64. Should this be an IA32/X64 specific API in BaseLib? Also, since the API is providing a C callable function to execute a specific IA32/X64 instruction, should the API be prefixed with Asm to match the convention

Re: [edk2] [PATCH v2 3/3] SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

2018-09-20 Thread Zhang, Chao B
Hi Ard: I am good with this patch. I will help to push it. From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, September 20, 2018 5:47 AM To: Laszlo Ersek Cc: edk2-devel@lists.01.org; Zeng, Star ; Wang, Jian J ; Kinney, Michael D ; Gao, Liming ; Zhang, Chao B ; Yao, Jiewe

Re: [edk2] SPI Flash Corruption

2018-09-20 Thread Laszlo Ersek
On 09/19/18 16:26, Samah Mansour wrote: > Hello, > > > Our product uses a Baytrail with Minnowboard Max bios firmware ( version > 0.93). Every now and then we see SPI flash corruption due to power cuts > while the unit is booting which causes the unit not to boot anymore. After > investigation we

Re: [edk2] [PATCH v1 0/5] [CVE-2017-5753] Bounds Check Bypass issue in SMI handlers

2018-09-20 Thread Laszlo Ersek
On 09/20/18 08:40, Hao Wu wrote: > The series aims to mitigate the Bounds Check Bypass (CVE-2017-5753) issues > within SMI handlers. > > A more detailed explanation of the purpose of the series is under the > 'Bounds check bypass mitigation' section of the below link: > https://software.intel.com/

Re: [edk2] [PATCH v1 1/5] MdePkg/BaseLib: Add new LoadFence API

2018-09-20 Thread Laszlo Ersek
On 09/20/18 08:40, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1193 > > This commit will add a new BaseLib API LoadFence(). This API will perform > a serializing operation on all load-from-memory instructions that were > issued prior to the call of this function. > > The pu

Re: [edk2] [PATCH v2 0/2] clarify NXE enabling logic

2018-09-20 Thread Laszlo Ersek
On 09/20/18 08:02, Jian J Wang wrote: >> v2 changes: >>Incorporates review comments from Laszlo and Star. > > BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116 > > Test: > a. try all related PCDs combinations and check the page table attributes > b. boot to shell on real intel plat

Re: [edk2] [Patch 0/5] Support windowsize to benefit tftp/pxe download performance.

2018-09-20 Thread Laszlo Ersek
On 09/20/18 07:54, Wu, Jiaxin wrote: > Hi Laszlo, > > I agree there is no document to describe the detailed difference > against the overlapped network drivers the between NetworkPkg and > MdeModulePkg (except IPv4/IPv6 support ). We only declared that those > drivers should not be used at the same

[edk2] question about uefi shell-current working directory and shell-script

2018-09-20 Thread krishnaLee
Hi, I wonder if it is a bug: I have a usb Fat32-disk,installed with EDK2 shell2.6 or 2.7, the root directory has a startup.nsh,the startup.nsh has only one line:"cd \", I boot my cannolake machine with this usb disk, in the uefi shell,I got a message:"cd: current directory not specified".it means

Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma to 6.9.0

2018-09-20 Thread Shia, Cinnamon
Hi Liming and Dongao, Thank you for making this change. It looks good to me and verified it with VS2015. Reviewed-by: Cinnamon Shia -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Friday, September 7, 2018 10:13 PM To: edk2-de

[edk2] [PATCH] MdeModulePkg CapsuleApp:Remove two redundant Guids

2018-09-20 Thread shenglei
Remove two redundant Guids which are not used. They are gEfiCertTypeRsa2048Sha256Guid and gEfiCertPkcs7Guid.This is an improved version of https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shengle

Re: [edk2] [PATCH v2] UefiCpuPkg: Remove redundant library classes, Ppis and GUIDs

2018-09-20 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > shenglei > Sent: Wednesday, September 19, 2018 11:02 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [PATCH v2] UefiCpuPkg: Remove redundant library

Re: [edk2] [PATCH v2 0/9] BaseTools: refactor Workspace classes

2018-09-20 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Tuesday, September 11, 2018 6:18 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/9] BaseTools: refactor Workspace