[edk2] [PATCH] uefi-sct/SctPkg: Fix the BlueTooth Guid and Enable BLE test

2018-10-13 Thread Eric Jin
Correct the guid of EFI_GUID gEfiBlueToothIoProtocolGuid and gEfiBlueToothConfigProtocolGuid Add BlueToothLE support test in the EfiCompliant part Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin ---

[edk2] [PATCH] uefi-sct/SctPkg:Implement the iSCSI devicepath to text

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../DevicePathToTextBBTestCoverage.c | 43 ++- .../BlackBoxTest/DevicePathToTextBBTestMain.c | 26 +--

[edk2] [PATCH] uefi-sct/SctPkg:Enhance the SimpleNetwork Test

2018-10-13 Thread Eric Jin
Add the EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit in the Enable parameter Add one checkpoint to MCastFilterCount is zero Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../SimpleNetwork/BlackBoxTest/Guid.c | 4

[edk2] [PATCH] uefi-sct/SctPkg:Fix the incorrect buffer free in SctAPrint()

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- uefi-sct/SctPkg/Library/SctLib/Print.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/Library/SctLib/Print.c

[edk2] [PATCH] uefi-sct/SctPkg:Assign 0 to the tail of HwErrRecVariableName

2018-10-13 Thread Eric Jin
Ensure the HwErrRecVariable could be deleted before the test exit. Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/VariableServicesBBTestFunction.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [edk2] [PATCH v1 6/6] ArmVirtPkg: Support for kvmtool emulated platform

2018-10-13 Thread Laszlo Ersek
On 10/12/18 16:40, Sami Mujawar wrote: > Kvmtool is a virtual machine manager that enables hosting > KVM guests. Kvmtool emulates certain devices like serial > port, RTC, etc. essentially providing an emulated platform. > > This patch adds support for kvmtool emulated platform. > >

Re: [edk2] [PATCH v1 5/6] ArmVirtPkg: Add kvmtool platform driver

2018-10-13 Thread Laszlo Ersek
On 10/12/18 16:40, Sami Mujawar wrote: > The KvmtoolPlatformDxe performs the platform specific > initialization like: > - It parses the kvmtool DT for Non-Volatile memory > range to use for runtime variable storage and > initialises the PcdEmuVariableNvStoreReserved. > - It decides if

Re: [edk2] [PATCH 0/6] Add kvmtool emulated platform support for ARM

2018-10-13 Thread Laszlo Ersek
On 10/12/18 16:40, Sami Mujawar wrote: > Kvmtool is a virtual machine manager that enables hosting KVM > guests. ARM is working to enhance kvmtool support to enable > launching of KVM guest with UEFI support. Why is QEMU not good enough? (With or without KVM.) Another platform I've recently

Re: [edk2] [PATCH v1 4/6] ArmVirtPkg: Save DT base address from X0 in PCD

2018-10-13 Thread Laszlo Ersek
On 10/12/18 16:40, Sami Mujawar wrote: > Some virtual machine managers provide the base address of the DT > in memory in the X0 register. Save the DT Base address in the > PcdDeviceTreeInitialBaseAddress so that the firmware can use the > PCD to parse the DT and obtain the platform information

Re: [edk2] Does edk2 still support python 2?

2018-10-13 Thread Laszlo Ersek
On 10/13/18 15:17, Chen, Farrah wrote: > Hello, > > When we make edk2 "OvmfPkg/build.sh -a X64 -n 16", we met below error: > > [vmm@vmm-build edk2]$ OvmfPkg/build.sh -a X64 -n 16 > Initializing workspace > /home/fan/edk2/BaseTools > Loading previous configuration from

Re: [edk2] [PATCH v1 3/6] MdeModulePkg: Map persistent (NV) memory

2018-10-13 Thread Laszlo Ersek
(+Grant) On 10/12/18 16:40, Sami Mujawar wrote: > Some platforms are able to preserve a memory range across > system resets. This memory can be used for the Non-Volatile > variables storage. The PcdEmuVariableNvStoreReserved is > used to specify this option. This is the wrong approach, for two

[edk2] [PATCH v1] BaseTools: Remove sitecustomize module

2018-10-13 Thread Alex James
The sitecustomize module in BaseTools was used to set the default text encoding on macOS systems. Setting the default system encoding is unsupported in Python 3, so remove the sitecustomize module. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Leif Lindholm
Hi Yonghong, Please revert this patch. The broken state of the master branch must be undone, not hacked on until individual bits seem to work. Plese do no further work on the master branch until the contents of the tree is identical to what it was at 301402fa4797ac3a141e575329ca2ea91756414c. (I

Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 19:12, Gao, Liming wrote: > Ard: > So, could I add this version in the commit message? Python3.5.3 has been > tested. > Yes. > And, with this patch, your CI environment can work? Do you find any other > issue? > I can build locally on Debian Stretch so the CI

Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Gao, Liming
Ard: So, could I add this version in the commit message? Python3.5.3 has been tested. And, with this patch, your CI environment can work? Do you find any other issue? Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday,

Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 19:03, Gao, Liming wrote: > Ard: > Do you verify BaseTools with Python35 or Python36? > Python 3.5.3 (default, Sep 27 2018, 17:25:39) [GCC 6.3.0 20170516] on linux >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Gao, Liming
Ard: Do you verify BaseTools with Python35 or Python36? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Sunday, October 14, 2018 12:52 AM > To: Zhu, Yonghong ; Andrew Fish > Cc:

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Zhu, Yonghong
Hi Ard, Thanks. I pushed this patch since it is critical block issue. Version SHA-1: 678f85131238622e576705117e299d81cff755c9 Best Regards, Zhu Yonghong -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Sunday, October 14, 2018 12:44 AM To: Zhu, Yonghong

Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 18:39, Yonghong Zhu wrote: > Remove the logic that the Python3 version must larger than 3.6. > We verified Python3 migration patches on version 3.6 and 3.7. > for other version we not verified it. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Sunday, October 14, 2018 12:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 >

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 18:40, Yonghong Zhu wrote: > Cover the case use do make -C BaseTools before run the .edksetup.sh > file. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu Reviewed-by: Ard Biesheuvel

[edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Yonghong Zhu
Cover the case use do make -C BaseTools before run the .edksetup.sh file. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6

2018-10-13 Thread Yonghong Zhu
Remove the logic that the Python3 version must larger than 3.6. We verified Python3 migration patches on version 3.6 and 3.7. for other version we not verified it. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [PATCH] uefi-sct/SctPkg:The Lun display order issue in iSCSI device path text

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[edk2] [PATCH] uefi-sct/SctPkg: Fix the Possible numeric underflow

2018-10-13 Thread Eric Jin
Possible numeric underflow when calculating the starting LBA for ReadBlocks_Func test Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../Protocol/BlockIo/BlackBoxTest/BlockIoBBTestFunction.c | 6 +-

[edk2] [PATCH] uefi-sct/SctPkg:Add the checkpoint of Toggle state of ReadKeyStrokeEx

2018-10-13 Thread Eric Jin
UEFI Spec clarify the Toggle state Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../SimpleTextInputEx/BlackBoxTest/Guid.c | 7 +- .../SimpleTextInputEx/BlackBoxTest/Guid.h | 12 +-

[edk2] [PATCH] uefi-sct/SctPkg:Update the PKCS7Verify Test to add the VerifySignature() checkpoint

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../Protocol/PKCS7Verify/BlackBoxTest/Guid.c | 12 +- .../Protocol/PKCS7Verify/BlackBoxTest/Guid.h | 30 +- .../BlackBoxTest/Pkcs7BBTestConformance.c | 308 +++-

[edk2] [PATCH] uefi-sct/SctPkg:The original design for the 'EraseLengthGranularity' test need consider this case

2018-10-13 Thread Eric Jin
For the SD device, no same as the eMMC, the 'EraseLengthGranularity' is 1. Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/EraseBlockBBTestFunction.c | 154 +- 1 file changed, 78

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Gao, Liming
https://pythonclock.org/ say Python 2.7 will not be maintained past 2020. One BZ https://bugzilla.tianocore.org/show_bug.cgi?id=55 also requests this migration. So, we migrate BaseTools to support Python3. Because Python27 will not be maintained, we drop Python27 support when we do Python3

[edk2] [PATCH] uefi-sct/SctPkg:Fix the flaw in BBTestCreateEventEx_Func_Sub3 on certain situation. Besides AllocatePages(), CreateEventEx may cause the memorymap change itself. Enhance the test to fil

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- ...rTaskPriorityServicesBBTestCreateEventEx.c | 26 +++ .../BlackBoxTest/Support.c| 19 +- 2 files changed, 33 insertions(+),

[edk2] [PATCH] uefi-sct/SctPkg:One checkpoint in the ExtractConfigFunction need be removed

2018-10-13 Thread Eric Jin
The Results output from ExtractConfigFunction() may be different during two calls in some case. Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../HIIConfigRouting/BlackBoxTest/Guid.c | 4 +---

[edk2] [PATCH] uefi-sct/SctPkg:Add conformance test cases for deprecated EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS attribute.

2018-10-13 Thread Eric Jin
Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../AuthVariableServicesBBTestConformance.c | 143 ++ .../VariableServices/BlackBoxTest/Guid.c | 6 +- .../VariableServices/BlackBoxTest/Guid.h

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Andrew Fish
> On Oct 13, 2018, at 5:18 AM, Ard Biesheuvel wrote: > > On 13 October 2018 at 11:23, Gao, Liming wrote: >> Ard: >> I know the failure reason. . edksetup.sh must be called in edk2 before >> enter BaseTools with make. edksetup.sh is used to detect the python3 and set >> PYTHON3 env. This

[edk2] Does edk2 still support python 2?

2018-10-13 Thread Chen, Farrah
Hello, When we make edk2 "OvmfPkg/build.sh -a X64 -n 16", we met below error: [vmm@vmm-build edk2]$ OvmfPkg/build.sh -a X64 -n 16 Initializing workspace /home/fan/edk2/BaseTools Loading previous configuration from /home/fan/edk2/Conf/BuildEnv.sh WORKSPACE: /home/fan/edk2 EDK_TOOLS_PATH:

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 11:23, Gao, Liming wrote: > Ard: > I know the failure reason. . edksetup.sh must be called in edk2 before > enter BaseTools with make. edksetup.sh is used to detect the python3 and set > PYTHON3 env. This env is used in GNUmakefile. > > I don't aware this change

Re: [edk2] [PATCH v1 2/6] PcAtChipsetPkg: Add MMIO Support to RTC driver

2018-10-13 Thread Leif Lindholm
On Fri, Oct 12, 2018 at 03:40:05PM +0100, Sami Mujawar wrote: > Some virtual machine managers like kvmtool emulate the MC146818 > RTC controller in the MMIO space so that architectures that do > not support I/O Mapped I/O can use the RTC. This patch adds MMIO > support to the RTC controller

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Gao, Liming
Ard: I know the failure reason. . edksetup.sh must be called in edk2 before enter BaseTools with make. edksetup.sh is used to detect the python3 and set PYTHON3 env. This env is used in GNUmakefile. I don't aware this change before. Because we usually call edksetup.sh, then make BaseTools.

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Leif Lindholm
Liming, The fact that the set includes unreviewed patches[1] should be sufficient argument for reverting it immediately. [1] ea787b6b55499e8f931201f8f49daaaeb2e4409f But beyond that, a set this invasive should only ever be pushed in the days after a stable tag has been created - not 2/3 through

Re: [edk2] [PATCH v1 3/6] MdeModulePkg: Map persistent (NV) memory

2018-10-13 Thread Zeng, Star
Hi Sami, Thanks for the patch. I just checked this patch and roughly checked [PATCH v1 5/6] ArmVirtPkg: Add kvmtool platform driver. I would like to suggest that the code added in this patch to be moved into KvmtoolPlatformDxe which is added by [PATCH v1 5/6] as KvmtoolPlatformDxe is the

[edk2] PACKAGES_PATH in !include path in Dsc files

2018-10-13 Thread Pankaj Bansal
Hello All, I am trying to add this functionality that we can specify PACKAGES_PATH in !include path in Dsc files just like we can specify WORKSPACE. I did below changes for it: --- a/BaseTools/Source/Python/Workspace/MetaFileParser.py +++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py @@

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Gao, Liming
Ard: With Python3, do you still meet with the failure? On BaseTools Python3 migration, the first patch is sent https://lists.01.org/pipermail/edk2-devel/2018-September/030216.html. And, the check in plan is sent on https://lists.01.org/pipermail/edk2-devel/2018-October/030563.html. There

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 10:44, Gao, Liming wrote: > Ard: > I pull the latest edk2 code. I can find RunTests.py in BaseTools/Tests. The > below error message shows RunTests.py is not found. But, this file is in > BaseTools/Tests. I also run Make command in BaseTools directory. It can work > in

Re: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Gao, Liming
Ard: I pull the latest edk2 code. I can find RunTests.py in BaseTools/Tests. The below error message shows RunTests.py is not found. But, this file is in BaseTools/Tests. I also run Make command in BaseTools directory. It can work in my Ubuntu machine. I install Python37. Do you install

[edk2] BaseTools/ build broken due to unreviewed patch - PLEASE FIX

2018-10-13 Thread Ard Biesheuvel
Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f "BaseTools: update Test scripts support python3" [which has never been sent out for review to the mailing list, as far as I can tell] is breaking the BaseTools build make -C Tests make[1]: Entering directory