ged after the
move in the patch series?
We researched better move methods than "add then delete" after the move of
libraries from ShellPkg to MdeModulePkg. Another major benefit was continuity
of file history...
-Jaben
> >
> >
> >> In SerialReset(), the serial
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Tuesday, January 5, 2016 12:33 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, January 4, 2016 8:03 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
&g
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-
> Haj-Mahmoud, Samer
> Sent: Tuesday, January 05, 2016 10:55 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
I think we should change 0 to CHAR_NULL in the comparison.
Otherwise: Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, December 20, 2015 9:07 PM
> To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01
Is it possible that the NT32 file system driver is completely read only? I am
not sure myself...
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> LiHongcheng
> Sent: Monday, December 28, 2015 7:02 PM
> To: edk2-devel@lists.01.org
> Subject:
Content looks good. The format is harder to find the changes than the standard
output from git I think.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Daryl McDaniel [mailto:edk2-li...@mc2research.org]
> Sent: Sunday, December 2
What's the benefit of this change? It's not bad, but I don't know why its
important...
Jaben
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Monday
, December 21, 2015 4:29 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu,
Can you make this into a PCD?
That would be cleaner. I would like patchable be one option.
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, December 21, 2015 7:19 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, December 21, 2015 7:19 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>; Ni,
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, December 21, 2015 7:19 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>; Ni,
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Monday, December 21, 2015 4:22 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com
pe.com]
> Sent: Monday, December 21, 2015 5:30 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin@intel.com>; El-Haj-Mahmoud, Samer haj-mahm...@hpe.com>
> Subject: RE: [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.
I do not have experience with that platform and I normally test with UEFI Shell
(UEFI not EDK/EFI) and HelloWorld. I am sorry I cant be more helpful.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Daniel
> Sent: Thursd
I think that you need to debug your DriverBinding.Start() and
DriverBinding.Supported() APIs. Those are what gets called in your driver when
'connect' shell command it used.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
&
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 16, 2015 5:30 AM
> To: Alcantara, Paulo <paulo.alc.cavalca...@hp.com>
> Cc: edk2-devel@lists.01.or
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Monday, December 14, 2015 4:24 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Ja
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Monday, December 14, 2015 4:28 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Ja
Mike,
Your second patch needs to be rebased. This is changing some of the lines that
were changed with the most recent patch to this file.
-Jaben
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, December 12, 2015 1:50 PM
> To: edk2-devel@lists.01.org
>
Looks good. Thanks!
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, December 14, 2015 10:14 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org; Kinney,
> Michael D <michael.d.kin...@intel.com>
> Cc: Ni, Ruiyu <ruiyu...
Looks good to me.
Shumin,
If it looks good to you, can you also commit?
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim_dai...@dell.com
> Sent: Monday, December
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, December 11, 2015 1:24 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] Shel
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 12:14 PM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Daryl McDaniel li...@mc2research.org
Agreed. that works fine too...
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 2:14 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jabe
I am the author. Shumin did some final verification and fixed a bug and then
sent out for review.
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 4:11 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>;
Looks good to me. I think we should wait for Leekha for up to a few days to
confirm that this fixes the problem at their location.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
-Jaben
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, December 03, 2015 5:2
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, December 03, 2015 3:26 AM
> To: Qiu, Shumin <shumin@intel.com>; edk2-de...@ml01.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: Re: [edk2] [PATCH] Shell
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, December 03, 2015 9:16 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin
> <shumin@intel.com>; edk2-de...@ml01.01.org
> Subject: Re: [edk2] [PATCH] Shell
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 02, 2015 9:03 AM
> To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming
> <liming@intel.com>
I am pretty sure it’s there in a shell app also. What entry point lib are you
using to build your app?
-Jaben
From: Shubha Ramani [mailto:shubharam...@yahoo.com]
Sent: Wednesday, December 02, 2015 9:11 AM
To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
Subject: Re:
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Wednesday, December 02, 2015 12:54 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.
I propose to rev the version of the library + 0.1 in the INF file?
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, December 01, 2015 9:54 PM
>
For the series (I made a tiny comment on the INF in the other patch email)
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, December 01, 2015
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Wednesday, December 02, 2015 2:17 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jabe
Change seems fine to me. Note that I am not maintainer on this PKG.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Anbazhagan, Baraneedharan
> Sent: Tuesday, Decembe
Its passed as a parameter to the "main" function when your app starts.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shubha Ramani
> Sent: Tuesday, December 01, 2015 8:35 AM
> To: edk2-devel@lists.01.org
&g
Not sure how to RB this ... it's fine with me to commit it.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, November 23, 2015 5:22 AM
> To: Leif Lindholm <leif.lindh...@linaro.org>
> Cc: edk2-devel@lists.01.org; Car
Good catch.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cecil Sheng
> Sent: Tuesday, November 17, 2015 4:19 PM
> To: edk2-devel@lists.01.org
> Cc: Cecil Sh
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Monday, November 09, 2015 6:54 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] Perfor
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Daryl McDaniel
> Sent: Saturday, November 07, 2015 11:46 AM
> To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Friday, November 06, 2015 12:06 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
>
Shumin,
Can you review this please?
ShellBinPkg: Update INF with Protocols section
Add missing section for the binary shell INF file.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.car...@intel.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zeng, Star
> Sent: Tuesday, November 03, 2015 5:01 PM
> To: Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zeng, Star
> Sent: Tuesday, November 03, 2015 5:01 PM
> To: Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel
> -Original Message-
> From: Zeng, Star
> Sent: Monday, November 02, 2015 7:13 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; Cinnamon Shia
> <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 1/2] ShellPkg/UefiDpLib: Fi
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Zeng, Star
> Sent: Monday, November 02, 2015 8:02 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg UefiDpLib: Use corre
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Daryl McDaniel [mailto:edk2-li...@mc2research.org]
> Sent: Tuesday, November 03, 2015 10:37 AM
> To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>;
> Bjorge, Erik
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Bjorge, Erik C
> Sent: Tuesday, November 03, 2015 10:43 AM
> To: Daryl McDaniel <edk2-li...@mc2research.org>; edk2-devel@lists.01.org;
> Carsey, Jaben <jaben.car...@intel.com>;
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Monday, November 02, 2015 1:12 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 1/2]
Code looks good. I can't tell must about your UNI file change.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Cinnamon Shia
> Sent: Monday, November 02, 2015 1:12 A
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Samer El-Haj-Mahmoud
> Sent: Friday, October 30, 2015 4:08 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <fen
You need to clarify in the function header comment for ChooseFile API if the
caller needs to free the returned DevicePath (File parameter).
Also, ChooseFile API may fail to de-allocate memory upon some failure
conditions.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Tuesday, October 27, 2015 6:38 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
>
Is there a reason that you don't just set the version number in the INF file
for your application? There is an entry in the [DEFINES] section. I think
that one is retained.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Miller, Carl H
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
-Original Message-
From: Qiu, Shumin
Sent: Tuesday, October 27, 2015 6:38 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben <jaben.car...@intel.com>
Subject: [PATCH] She
18659
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hpe.com]
> Sent: Friday, October 23, 2015 1:07 PM
> To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>
> Cc: El-Haj-Mahmou
Code looks good. The format of the diff/patch seems quite different and harder
to decode than the usual.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Daryl McDaniel
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Qiu Shumin
> Sent: Tuesday, October 13, 2015 10:00 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car
There may be multiple text in protocols. How will you know which one to open?
ConIn may also be redirecting from a Unicode file, an asci file, or an
environment variable if you run under the shell.
Tl;dr No, don't do it.
> -Original Message-
> From: edk2-devel
Shumin,
Can you review this?
The update makes all the libs built when the package is built. (prevent future
issue like where TFPT lib wouldn't build)
ShellPkg: ShellPkg DSC update
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.car...@intel.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, September 24, 2015 2:30 PM
> To: edk2-devel-01 <edk2-de...@ml01.01.org>
> Cc: Carsey, Jaben <jaben.car...@intel.com>
That was an error on my part. I plan to revert the change and then apply the
correct one.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, September 24, 2015 1:21 PM
> To: Carsey, Jaben <jaben.car...@intel.com>
> Cc: edk2-devel@
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Tuesday, September 15, 2015 10:52 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>;
> Carsey,
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, September 15, 2015 11:10 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu...@
Thanks. I looked at the wrong thing somehow.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El-
> Haj-Mahmoud, Samer
> Sent: Wednesday, September 16, 2015 11:15 AM
&
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hp.com]
> Sent: Wednesday, September 16, 2015 11:10 AM
> To: edk2-devel@lists.01.org
> Cc: jaben.car...@intel.com --cc=shumin@in
, but simply goes past those requirements.
We do not want to execute a command other than the built in help command.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim_dai...@dell.com
> Sent: Tuesday, September 15, 2015 6:02 AM
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Friday, September 11, 2015 4:53 PM
> To: edk2-devel@lists.01.org
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@h
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Monday, September 14, 2015 1:28 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>
> S
if this second event is triggered between
printing each file/directory entry ... If the event was triggered, the command
or application can abort itself.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Andrew Fish
> Sent: Friday,
Why remove this from the expression? Is it redundant?
- } else if (NextCommandLine[0] != CHAR_NULL &&
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Thursday, September 10, 2015 8:16 PM
> To: edk2-devel@list
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, September 06, 2015 8:06 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Tuesday, September 08, 2015 12:05 AM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Qiu, Shumin
> Sent: Sunday, September 06, 2015 8:06 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
Reviewed-by: Jaben Carsey jaben.car...@intel.com
-Original Message-
From: Qiu, Shumin
Sent: Tuesday, August 25, 2015 7:46 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin shumin@intel.com; Carsey, Jaben
jaben.car...@intel.com
Subject: [PATCH] ShellPkg: Fix the ASSERT issue
Reviewed-by: Jaben Carsey jaben.car...@intel.com
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Tuesday, August 25, 2015 6:04 AM
To: edk2-devel@lists.01.org; Carsey, Jaben; Qiu, Shumin
Cc: Ard Biesheuvel
Subject: [PATCH] ShellPkg: use UEFI_APPLICATION
I like the comments. Thanks for updating them!
-Original Message-
From: Qiu, Shumin
Sent: Monday, August 24, 2015 11:39 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Carsey, Jaben; Gao, Liming
Subject: [PATCH v3 2/3] MdePkg/Library/UefiFileHandleLib: Make the
FileHandleGetFileName
What about other error return values in *TransferResult? Both places you check
for a specific set of errors, but the set is not exhaustive and if a different
error occurs, will the caller know?
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Reviewed-by: Jaben Carsey jaben.car...@intel.com
-Original Message-
From: Qiu, Shumin
Sent: Friday, August 21, 2015 1:03 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin shumin@intel.com; Carsey, Jaben
jaben.car...@intel.com; Gao, Liming liming@intel.com
Subject: [PATCH 1/3
Reviewed-by: Jaben Carsey jaben.car...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Ard Biesheuvel
Sent: Wednesday, August 19, 2015 2:48 AM
To: edk2-devel@lists.01.org; leif.lindh...@linaro.org
Cc: Carsey, Jaben jaben.car
Reviewed-by: Jaben Carsey jaben.car...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Leif Lindholm
Sent: Wednesday, August 19, 2015 8:53 AM
To: Ard Biesheuvel ard.biesheu...@linaro.org
Cc: edk2-devel@lists.01.org; ryan.har
The UEFI Shell 2.1 has been available for a long time. Any UDK release after
Aug last year should have it. I am not an expert on the UDK releases...
-Jaben
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Daniel Samuelraj
Sent: Monday
if that just generates an error). If
you call the API that does not exist, you will certainly have undefined
behavior.
-Jaben
From: u...@uefi.org [mailto:u...@uefi.org] On Behalf Of Daniel Samuelraj
Sent: Friday, August 14, 2015 9:40 AM
To: uswg u...@uefi.org; edk2-de...@lists.sourceforge.net
18032 was just a change to maintainers.txt by me replacing Daryl as the
maintainer of a few packages with myself. I can send it if necessary, but I'd
say it's pretty uninteresting really...
-Jaben
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
901 - 984 of 984 matches
Mail list logo
