Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-30 Thread Yao, Jiewen
, 2015 9:25 PM To: Yao, Jiewen; Paolo Bonzini; Fan, Jeff; edk2-de...@ml01.01.org Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block On 07/28/15 23:41, Yao, Jiewen wrote: > HI Laszlo > I like the diagram in

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-29 Thread Laszlo Ersek
om: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, July 29, 2015 3:31 AM > To: Paolo Bonzini; Fan, Jeff; edk2-de...@ml01.01.org > Cc: Chen Fan; Justen, Jordan L > Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: opt

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
-Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of > Paolo Bonzini > Sent: Tuesday, July 28, 2015 3:34 PM > To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Chen Fan; Justen, Jordan L > Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Yao, Jiewen
sday, July 29, 2015 3:31 AM To: Paolo Bonzini; Fan, Jeff; edk2-de...@ml01.01.org Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block On 07/28/15 08:51, Paolo Bonzini wrote: > > > On 28/07/2015 08:

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
nz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, July 28, 2015 3:34 PM > To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Chen Fan; Justen, Jordan L > Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR > settings to AcpiNVS memory

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 09:33, Paolo Bonzini wrote: > > > On 28/07/2015 09:09, Fan, Jeff wrote: >> I did not receive the patch 42. I have only gotten 38,39,40,41. >> >> OK, If this mtrr setting stored in ACPI NVS is for CpuS3DataDxe to >> store into SMRAM, that's fine. >> >> Then, another question, what's re

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, July 28, 2015 2:52 PM > To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Chen Fan; Justen, Jordan L > Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR > settings to AcpiNVS mem

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 08:51, Paolo Bonzini wrote: > > > On 28/07/2015 08:05, Fan, Jeff wrote: >> Ersek, >> >> I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. >> >> I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in >> AcpiNVS is OK for OvmfPkg. > > If I understand correctly

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Laszlo Ersek
On 07/28/15 08:05, Fan, Jeff wrote: > Ersek, > > I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. > > I knew OvmfPkg implemented LockBox based on ACPI NVS. That is true for OVMF at the moment, but this series is exactly the one changing it. Going forward, if you build OVMF with -D SMM_REQUIRE

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
2015 3:34 PM To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block On 28/07/2015 09:09, Fan, Jeff wrote: > I did not receive the patch 42. I have only gotte

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-28 Thread Fan, Jeff
on/off it? Jeff -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Tuesday, July 28, 2015 2:52 PM To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org Cc: Chen Fan; Justen, Jordan L Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe:

Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-27 Thread Fan, Jeff
Ersek, I have one comment for PCD PcdCpuSyncMtrrToAcpiNvs. I knew OvmfPkg implemented LockBox based on ACPI NVS. Saving MTRR setting in AcpiNVS is OK for OvmfPkg. But other platform may want to use more safe solution to save MTRR based on in SMM. I think that, for long term, saving MTRR setti

[edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally save MTRR settings to AcpiNVS memory block

2015-07-24 Thread Laszlo Ersek
The Quark_EDKII_v1.1.0/IA32FamilyCpuBasePkg/CpuArchDxe driver provides the following capability in its implementation of EFI_CPU_ARCH_PROTOCOL: whenever the SetMemoryAttributes() member is used (directly, or indirectly via gDS->SetMemorySpaceAttributes()) to change MTRR settings, the complete s