[edk2] [PATCH] MdeModulePkg: Fix memory leak issues

Fix memory leak issues Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sunny Wang --- MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[edk2] [UEFI2.5] HTTP Boot for IPv6

Hi NetworkStack owner, We notice HTTPBoot for IPv6 is not yet ready on EDKII trunk, do you have schedule/plan for this feature? Thank you. B.R. Ted ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [UEFI2.5] HTTP Boot for IPv6

Yes we are working on this now. Thanks, Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ted Chang (???) Sent: Tuesday, October 27, 2015 4:38 PM To: edk2-devel@lists.01.org Subject: [edk2] [UEFI2.5] HTTP Boot for IPv6 Hi NetworkStack

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix return value

Hi Haojian, On 27 October 2015 at 16:15, Haojian Zhuang wrote: > Fix the wrong return value of both InternalSyncIncrement() > and InternalSyncDecrement(). The return value shouldn't > be the address of input parameter. It should be the updated > value of input

[edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib Why we need this hook function : 1) According to UEFI 2.5 Section 3.4.3, the 3rd paragraph, It seems we need to have a hook function (PlatformBootManagerDefaultBootFail) for platform firmware to do

Re: [edk2] [patch] MdeModulePkg:Add HiiGetFormSetFromHiiHandle function into UefiHiiLib

Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Friday, October 23, 2015 4:05 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Add HiiGetFormSetFromHiiHandle function into UefiHiiLib This function is mainly

[edk2] [PATCH] MdeModulePkg Variable: Move CacheVariable->InDeletedTransitionPtr NULL pointer check

This change is triggered by R18654 "Enhance variable performance by reading from existed memory cache" that changed the code to use CacheVariable to improve performance. So the CacheVariable->InDeletedTransitionPtr NULL pointer check needs to be moved to the place before it is been used. Cc:

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix return value

On Tue, Oct 27, 2015 at 06:15:07PM +0900, Ard Biesheuvel wrote: > Hi Haojian, > > On 27 October 2015 at 16:15, Haojian Zhuang wrote: > > Fix the wrong return value of both InternalSyncIncrement() > > and InternalSyncDecrement(). The return value shouldn't > > be the

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ExitBootServices() callback in the presence of SMIs

On 10/27/15 07:48, Jordan Justen wrote: > What about adding this code to mStartupCodeTemplate and sending the > APs there using the MP services? That was the idea in Jeff's earlier series, but it comes with a number of complications. The main one is that the HLT loop is entered as a "normal"

Re: [edk2] [PATCH] ShellPkg: Refine code by initializing local variable and adding ASSERT statement.

Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, October 27, 2015 6:38 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: [PATCH] ShellPkg: Refine code

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerDefaultBootFail to PlatformBootManagerLib

Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Wang, Sunny (HPS SW) Sent: Tuesday, October 27, 2015 4:21 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Wang, Sunny (HPS SW) Subject: [PATCH]

[edk2] EFI pe version number

I am trying to set an image version number into my .efi application, using the /VERSION:x.y linker option. I am building using UDK2014 and visual studio 2013. I see that the version is being inserted into the appplication.dll file, but it gets stripped out in the application.efi file. is

Re: [edk2] [PATCH] MdeModulePkg: Add a BDS platform hook function PlatformBootManagerBeforeDefaultBoot to PlatformBootManagerLib

Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Wang, Sunny (HPS SW) Sent: Tuesday, October 27, 2015 4:38 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Wang, Sunny (HPS SW) Subject: [PATCH]

Re: [edk2] EFI pe version number

Is there a reason that you don't just set the version number in the INF file for your application? There is an entry in the [DEFINES] section. I think that one is retained. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Miller, Carl H >

Re: [edk2] [PATCH] UefiCpuPkg: SmmCpuFeaturesLib: Add MSR_SMM_FEATURE_CONTROL support

Looks good. Reviewed by: jiewen@intel.com Thank you Yao Jiewen -Original Message- From: Kinney, Michael D Sent: Wednesday, October 28, 2015 2:09 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Fan, Jeff Subject: [PATCH] UefiCpuPkg: SmmCpuFeaturesLib: Add MSR_SMM_FEATURE_CONTROL

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

On 28 October 2015 at 10:33, Star Zeng wrote: > This patch does below things. > 1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from > configuration table. > 2. Correct the return comments of entrypoint function. > 3. Add parameters' comments for

[edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

This patch does below things. 1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from configuration table. 2. Correct the return comments of entrypoint function. 3. Add parameters' comments for MeasureSmbiosTable(). 4. Remove the tailing space from SmbiosMeasurementDxe.c. 5.

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

On 28 October 2015 at 13:26, Zeng, Star wrote: > On 2015/10/28 9:44, Ard Biesheuvel wrote: >> >> On 28 October 2015 at 10:33, Star Zeng wrote: >>> >>> This patch does below things. >>> 1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got

[edk2] [PATCH 1/5] MdeModulePkg SmbiosMeasurementDxe: Use SMBIOS table and GUID correctly

1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from configuration table. 2. Use correct VendorGuid and VendorTable to measure. Cc:Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

[edk2] [PATCH 5/5] MdeModulePkg SmbiosMeasurementDxe: Correct the comments

1. Correct the return comments of entrypoint function. 2. Add parameters' comments for MeasureSmbiosTable(). 3. Correct the Protocols and Guids usage comments in SmbiosMeasurementDxe.inf. Cc:Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 4/5] MdeModulePkg SmbiosMeasurementDxe: Remove the tailing whitespace

Cc:Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao --- .../SmbiosMeasurementDxe/SmbiosMeasurementDxe.c| 26 +++---

[edk2] [PATCH 0/5] MdeModulePkg: Enhance SmbiosMeasurementDxe

This patch set do below things. 1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from configuration table. 2. Use correct VendorGuid and VendorTable to measure. 3. Add (VOID **) typecast in LocateProtocol call for GCC build failure. 4. Use EFI_D_VERBOSE instead of EFI_D_INFO in

[edk2] [PATCH 2/5] MdeModulePkg SmbiosMeasurementDxe: Add (VOID **) typecast for GCC build failure

Cc:Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao --- MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 2 +- 1 file changed, 1 insertion(+),

[edk2] [Patch] MdeModulePkg: Do not dump NULL padding resource descriptor

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [Patch] MdeModulePkg FileExplorerLib: Create file explorer library.

This library support select one file from the specified directory or from system root directory. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- MdeModulePkg/Include/Library/FileExplorerLib.h |

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

On 2015/10/28 9:44, Ard Biesheuvel wrote: On 28 October 2015 at 10:33, Star Zeng wrote: This patch does below things. 1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from configuration table. 2. Correct the return comments of entrypoint function. 3. Add

[edk2] [PATCH 1/1] EmbeddedPkg: Add EFIAPI to several Ebl functions

The EFIAPI function declaration is missing for several functions in the EmbeddedPkg/Ebl directory. A few function pointer struct members expect EFIAPI though and GCC46/X64 will fail to compile the directory without them. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

Thanks. Can we use CopyGuid() for below assignment? HandoffTables.TableEntry[0].VendorGuid = gEfiSmbiosTableGuid; Reviewed-by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, October 28, 2015 9:33

Re: [edk2] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Smbios3Table used as SmbiosTable wrongly

On 2015/10/28 10:58, Yao, Jiewen wrote: Thanks. Can we use CopyGuid() for below assignment? HandoffTables.TableEntry[0].VendorGuid = gEfiSmbiosTableGuid; Yes, have included this into PATCH 1/5 of the new split patch set and with your Reviewed-by. Thanks, Star Reviewed-by:

[edk2] [PATCH] ShellPkg: Refine code by initializing local variable and adding ASSERT statement.

Add ASSERT statement and initialize local variable to make code more readable. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/ShellProtocol.c | 2 ++

Re: [edk2] [PATCH] ShellPkg: Refine code by initializing local variable and adding ASSERT statement.

Reviewed-by: Jaben Carsey -Original Message- From: Qiu, Shumin Sent: Tuesday, October 27, 2015 6:38 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin ; Carsey, Jaben Subject: [PATCH] ShellPkg: Refine code by