Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move SmmDebug from ASM to C.

Reviewed-by: Michael Kinney > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 12:50 AM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Fan, Jeff ; > Kinney, Michael D

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 function to PerformPreTasks().

Reviewed-by: Michael Kinney > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 12:36 AM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Fan, Jeff ; > Kinney, Michael D

Re: [edk2] [Patch v2 1/2] UefiCpuPkg/CpuMpPei: Set X2APIC flag if one x2APIC ID larger than 254

Reviewed-by: Michael Kinney > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Fan > Sent: Tuesday, November 24, 2015 12:55 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D

Re: [edk2] [Patch v2 2/2] UefiCpuPkg/CpuMpPei: Enable x2APIC mode on BSP/APs

Reviewed-by: Michael Kinney > -Original Message- > From: Fan, Jeff > Sent: Tuesday, November 24, 2015 12:55 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng ; Kinney, Michael D > > Subject: [Patch v2 2/2]

Re: [edk2] [patch] MdeModulePkg/PiSmmIpl: Move CommunicationBuffer from stack to global variable.

Reviewed-by: Michael Kinney > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 5:00 AM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Fan, Jeff ; Kinney,

[edk2] [PATCH v2 1/2] UefiCpuPkg/Include: Expand description of AcpiCpuData.h structures

Provide a more detailed description of each field of the ACPI_CPU_DATA and CPU_REGISTER_TABLE structures. Cc: Laszlo Ersek Cc: "Yao, Jiewen" Cc: "Fan, Jeff" Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH v2 2/2] UefiCpuPkg/CpuS3DataDxe: Add module to initialize ACPI_CPU_DATA for S3

This module initializes the ACPI_CPU_DATA structure and registers the address of this structure in the PcdCpuS3DataAddress PCD. This is a generic/simple version of this module. It does not provide a machine check handler or CPU register initialization tables for ACPI S3 resume. It also only

[edk2] [PATCH v2 0/2] UefiCpuPkg: Add CpuS3DataDxe module

Provide a more detailed description of each field of the ACPI_CPU_DATA and CPU_REGISTER_TABLE structures in AcpiCpuData.h. Add module to initialize ACPI_CPU_DATA for ACPI S3 resume. Cc: Laszlo Ersek Cc: "Yao, Jiewen" Cc: "Fan, Jeff"

[edk2] Vlv2TbltDevicePkg/GenBiosId binary

David, Tim, I wonder why this binary exists in EDK II without source code. I also notice that Vlv2TbltDevicePkg/GenBiosId is a 32-bit ELF executable. What if someone wanted to build Vlv2TbltDevicePkg on X64 and they didn't have 32-bit userspace available? -Jordan

Re: [edk2] [patch 1/3] MdeModulePkg/NvmExpress: Fix mem leak in error handling of Start()

On 2015/11/24 16:50, Tian Feng wrote: Memory pointed to by Private->ControllerData has not been freed up correctly at error handling path. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Cc: Simon (Xiang) Lian-SSI

Re: [edk2] [patch 2/3] MdeModulePkg/NvmExpress: Fix bug of handling not null-terminated strings

On 2015/11/24 16:50, Tian Feng wrote: In EnumerateNvmeDevNamespace(), when Private->ControllerData->Sn and/or Private->ControllerData->Mn are NOT null-terminated strings, UnicodeSPrintAsciiFormat(…) may generate unexpected (garbage) output string. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option

Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Tuesday, November 24, 2015 3:22 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg/BDS: Do not pass unnecessary option to boot option BDS puts a special GUID in boot

Re: [edk2] [PATCH 3/3] ArmPlatformPkg/ArmJunoPkg: Create SMBIOS/DMI data for Juno

On 11/24/2015 11:08 AM, Leif Lindholm wrote: +// Memory device >+STATIC CONST ARM_TYPE17 mArmDefaultType17 = { >+ { >+{ // SMBIOS_STRUCTURE Hdr >+ EFI_SMBIOS_TYPE_MEMORY_DEVICE, // UINT8 Type >+ sizeof (SMBIOS_TABLE_TYPE17), // UINT8 Length >+ SMBIOS_HANDLE_DIMM, >+}, >+

Re: [edk2] [PATCH 1/2] UefiCpuPkg - Expand description of AcpuCpuData.h structures

Mike, first of all, thanks a lot for doing this. Some comments below: On 11/24/15 07:24, Michael Kinney wrote: > Provide a more detailed description of each field of the > ACPI_CPU_DATA and CPU_REGISTER_TABLE structures. > > Cc: Laszlo Ersek > Cc: "Yao, Jiewen"

Re: [edk2] Ip4Config to Ip4Config2 Transition

Ting, > Are you asking whether the new driver producing Ip4Config2 protocol can > support the previous network setting configured by old driver producing > Ip4Config protocol in NVRAM? > If yes, I think the answer is no. Yes, that is what I meant to ask - thank you for clarifying this! And I

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

On 24 November 2015 at 16:53, Cohen, Eugene wrote: > Ard, thanks - as you can tell this is an issue in the original flags and not > with the changes I've added. I agree that we should not redefine the fpu in > this file but rather inherit from the build. > Looking at the repo

Re: [edk2] [PATCH 1/3] Code to detect what juno revision we are running on.

Hi Jeremy, Thanks for this reworked version. A few minor comment below. On Fri, Nov 20, 2015 at 04:18:51PM -0600, Jeremy Linton wrote: > The code to detect what juno revision we are running on > is fairly small. Put it in a common header, where it may be > shared by a couple modules. > >

Re: [edk2] Integrate application into Shell

Hi Daryl, what I basically did to integrate it into the shell was to copy the original shell (not the whole ShellPkg, just the shell application) and the original UefiShellNetwork1CommandsLib, I modified the UefiShellNetwork1CommandsLib to include my program and the shell application (or

Re: [edk2] [PATCH 3/3] ArmPlatformPkg/ArmJunoPkg: Create SMBIOS/DMI data for Juno

On Fri, Nov 20, 2015 at 04:18:53PM -0600, Jeremy Linton wrote: > SMBIOS data is consumed by a wide range of enterprise applications. > > Fill in the basic requirements of the SMBIOS specification by hardcoding > the minimum required structures and data using Juno information. With > this change

[edk2] [PATCH] ArmPkg: add missing MigratePeiServicesTablePointer function required by update to the PeiServicesTablePointerLib in svn 15115

As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function. Background: The ArmPkg variant of the PeiServicesTablePointerLib implements the standard PEI Services table retrieval mechanism as defined in the PI Specification Volume 1 section 5.4.4 using the PIDRURW registers.

[edk2] ArmPlatformPkg: Non-compliant PeiServicesTablePointerLib implementation

In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer library that uses the "global variable" creation. (I don't know what the purpose is of these "global variables" but they seem to be incompatible with the philosophy of PI/edk2 which is all about decentralizing stuff -

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

On 24 November 2015 at 14:49, Michael Zimmermann wrote: > sry for the late answer. > > The value of this register is: 0x10211103 > I hope that helps. > Thanks. This value decodes as; InnerShr, bits [31:28] == 1, Implemented with hardware coherency support. ShareLvl,

[edk2] [PATCH] CryptoPkg: Fix ARM RVCT 4 build

I've removed the --fpu switch and have so far not seen any issues (building). I then encountered an issue of duplicate symbols between BaseCryptLib and OpensslLib: 1>armlink : error L6200: Symbol TS_ACCURACY_it multiply defined (by BaseCryptLib.lib and OpensslLib.lib). 1>armlink : error L6200:

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

'PcdNormalMemoryNonshareableOverride' - that's what I am using now but it's still interesting to know what causes this effect. Thx for clearing this up. Michael. On Tue, Nov 24, 2015 at 5:59 PM, Ard Biesheuvel wrote: > On 24 November 2015 at 14:49, Michael Zimmermann

[edk2] [PATCH] ShellPkg: fix RVCT warning due to CONST in typecast

Building the latest shell on RVCT exposed this warning: ShellPkg\Application\Shell\Shell.c(1090,69): error #191-D: type qualifier is meaningless on cast type The CONST in the cast was deemed meaningless. Removing the CONST fixed the warning. --- edk2/ShellPkg/Application/Shell/Shell.c | 2

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Laszlo, Thanks for the detailed feedback. Comments included below. V2 patch to follow. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 24, 2015 11:57 AM > To: Kinney, Michael D ; edk2-de...@ml01.01.org >

Re: [edk2] [patch] MdeModulePkg/PiSmmCore: Install LoadedImage protocol.

Jiewen, One typo in a comment noted below. With that fix: Reviewed-by: Michael Kinney Mike > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 12:21 AM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Zeng,

Re: [edk2] [patch] MdeModulePkg/PiSmmCore: Install LoadedImage protocol.

Thanks to catch that! I will fix it when I check in. -Original Message- From: Kinney, Michael D Sent: Wednesday, November 25, 2015 8:34 AM To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Zeng, Star; Fan, Jeff Subject: RE: [patch] MdeModulePkg/PiSmmCore: Install

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Allocate Tile size based on Page.

We had better separate code from data in tile in page level, so that other program may use page level protection on that. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D"

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2015/11/24 22:42, Laszlo Ersek wrote: On 11/24/15 15:27, Zeng, Star wrote: On 2015/11/24 21:17, Laszlo Ersek wrote: On 11/24/15 02:01, Zeng, Star wrote: On 2015/11/23 22:01, Laszlo Ersek wrote: [snip] (2) although I see that you unified the GetControl / SetControl / SetAttributes

[edk2] [patch 3/3] UefiCpuPkg/PiSmmCpu: Update function call for 2 new APIs in SmmCpuFeatureLib.

All page table allocation will use AllocatePageTableMemory(). Add SmmCpuFeaturesCompleteSmmReadyToLock() to PerformRemainingTasks() and PerformPreTasks(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff"

[edk2] [patch 1/3] UefiCpuPkg/PiSmmCpu: Add 2 APIs in SmmCpuFeaturesLib.

SmmCpuFeaturesCompleteSmmReadyToLock() is a hook point to allow CPU specific code to do more registers setting after the gEfiSmmReadyToLockProtocolGuid notification is completely processed. SmmCpuFeaturesAllocatePageTableMemory() is an API to allow CPU to allocate a specific region for storing

[edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D" --- .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 39 ++ 1 file changed,

Re: [edk2] [PATCH] CryptoPkg: Fix ARM RVCT 4 build

Eugene, This patch looks a little complicated. I may need some times to evaluate it. One big changes may be the TS support part. We use our self-owned TS interface (leveraging the underlying ASN1 macro and PKCS7 routines) for UEFI timestamp support, instead of OpenSSL TS functions which cannot

Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary

Yes, the GenBiosId is 32-bit ELF binary, because we need to support GCC build on Linux 32bit system. Best Regards, Tim -Original Message- From: Justen, Jordan L Sent: Wednesday, November 25, 2015 6:04 AM To: Wei, David; He, Tim Cc: edk2-devel@lists.01.org Subject:

[edk2] [PATCH V4 03/13] PcAtChipsetPkg SerialIoLib: Implement Get(Set)Control/SetAttributes

Cc: Michael D Kinney Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Liming Gao Reviewed-by: Michael D

[edk2] [PATCH V4 09/13] BeagleBoardPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

It is also to remove the reference to TemplateSerialPortExtLib in EmbeddedPkg. Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore

[edk2] [PATCH V4 04/13] MdeModulePkg BaseSerialPortLib16550:Implement Get(Set)Control/SetAttributes

Cc: Michael D Kinney Cc: Liming Gao Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Liming Gao Reviewed-by: Michael D

[edk2] [PATCH V4 08/13] Omap35xxPkg SerialPortLib: Implement Get(Set)Control/SetAttributes

Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by:

Re: [edk2] [PATCH V3 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

On 2015/11/25 9:07, Kinney, Michael D wrote: Star, One minor issue in this patch. It mixes global variables and function prototypes. All the typedefs and function prototypes should come first, then globals, and then function implementation. The rest of the V3 series addresses all my V2

[edk2] [PATCH V4 07/13] CorebootPayloadPkg: Use SerialDxe in MdeModulePkg

1. Update fdf and dsc to use SerialDxe in MdeModulePkg. 2. Separate the code that gets SerialRegBase and SerialRegAccessType by CbParseLib from CorebootPayloadPkg/Library/SerialPortLib to PlatformHookLib, and then leverage BaseSerialPortLib16550 in MdeModulePkg. 3. Remove

[edk2] [PATCH V4 11/13] OvmfPkg XenConsoleSerialPortLib: Implement Get(Set)Control/SetAttributes

Cc: Michael D Kinney Cc: Liming Gao Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Laszlo

[edk2] [PATCH V4 13/13] EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries

Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by:

[edk2] [PATCH V4 02/13] MdePkg SerialPortLib: Upstream Get(Set)Control/SetAttributes interfaces

The extended interfaces GetControl/SetControl/SetAttributes are from EmbeddedPkg/Include/Library/SerialPortExtLib.h. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

Re: [edk2] [PATCH V3 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

Star, One minor issue in this patch. It mixes global variables and function prototypes. All the typedefs and function prototypes should come first, then globals, and then function implementation. The rest of the V3 series addresses all my V2 feedback. Thanks! Mike > -Original

Re: [edk2] [PATCH V4 01/13] MdeModulePkg: TerminalDxe: avoid checking uninitialized variable

Reviewed-by: Michael Kinney > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 24, 2015 5:34 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Tian, Feng

Re: [edk2] [PATCH V4 05/13] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

Reviewed-by: Michael Kinney > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 24, 2015 5:34 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Tian, Feng

Re: [edk2] [PATCH V4 00/13] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

Star, The series looks good to me, and the feedback I have provided has been addressed. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 24, 2015 5:34 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [patch] MdeModulePkg/PiSmmCore: Install LoadedImage protocol.

On 2015/11/25 8:34, Yao, Jiewen wrote: Thanks to catch that! I will fix it when I check in. With that: Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Wednesday, November 25, 2015 8:34 AM To: Yao, Jiewen;

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Allocate Tile size based on Page.

Reviewed-by: Michael Kinney > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 4:42 PM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen ; Fan, Jeff ; > Kinney, Michael D

Re: [edk2] [patch] MdeModulePkg/PiSmmIpl: Move CommunicationBuffer from stack to global variable.

On 2015/11/24 21:00, jiewen yao wrote: We had put communication buffer to Runtime memory, so that SMI handler can know it is not used by OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc:

[edk2] [PATCH V4 06/13] EmulatorPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

It is also to add GetControl/SetControl/SetAttributes implementation for DxeEmuSerialPortLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Jordan Justen Cc: Andrew Fish Contributed-under: TianoCore

[edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

It is also to integrate PL011SerialPortExtLib to PL011SerialPortLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution

[edk2] [PATCH V4 00/13] Upstream SerialDxe from EmbeddedPkg to MdeModulePkg

Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to MdeModulePkg, relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to SerialPortLib.h in MdePkg. For your easy review, the forked code is at g...@github.com:lzeng14/edk2.git branch SerialDxeV4. *

Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary

On 11/24/15 3:03 PM, Jordan Justen wrote: I wonder why this binary exists in EDK II without source code. I also notice that Vlv2TbltDevicePkg/GenBiosId is a 32-bit ELF executable. What if someone wanted to build Vlv2TbltDevicePkg on X64 and they didn't have 32-bit userspace available? I took

[edk2] [patch] MdeModulePkg:Correct the file name in UiApp.inf

Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/UiApp.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

The previous IDT is not in page aligned memory. We allocate and copy it in page aligned memory, so that other program may use page level protection on that. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff"

Re: [edk2] [patch] MdeModulePkg:Correct the file name in UiApp.inf

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Wednesday, November 25, 2015 12:43 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Correct the file name in UiApp.inf Cc: Liming Gao Cc:

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.

Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Wednesday, November 25, 2015 12:51 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D Subject: [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory. The previous IDT is

Re: [edk2] [PATCH V4 01/13] MdeModulePkg: TerminalDxe: avoid checking uninitialized variable

On 11/25/15 02:33, Star Zeng wrote: > The SerialIo->GetControl() function is not required to set the > Control output parameter on error. Make sure we apply the > EFI_SERIAL_INPUT_BUFFER_EMPTY optimization in > TerminalConInTimerHandler() only if the SerialIo->GetControl() > function call set that

Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary

In my memory, GenBiosId source code isn't open source code. There is a spec for BIOSID. You can check that for format and organization . Thx, Amos -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce Cran Sent: Wednesday, November 25, 2015

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

On 11/24/15 23:48, Kinney, Michael D wrote: > Laszlo, > > Thanks for the detailed feedback. Comments included below. V2 patch to > follow. > > Mike > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tuesday, November 24, 2015 11:57 AM >> To: Kinney,

Re: [edk2] ArmPlatformPkg: Non-compliant PeiServicesTablePointerLib implementation

On 24 November 2015 at 18:16, Cohen, Eugene wrote: > In ArmPlatformPkg there is an implementation of the PeiServicesTablePointer > library that uses the "global variable" creation. (I don't know what the > purpose is of these "global variables" but they seem to be incompatible

Re: [edk2] [PATCH] ArmPkg: add missing MigratePeiServicesTablePointer function required by update to the PeiServicesTablePointerLib in svn 15115

On 24 November 2015 at 18:09, Cohen, Eugene wrote: > As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function. > > Background: The ArmPkg variant of the PeiServicesTablePointerLib implements > the standard PEI Services table retrieval mechanism as defined in

Re: [edk2] [PATCH v2 1/2] UefiCpuPkg/Include: Expand description of AcpiCpuData.h structures

On 11/25/15 00:47, Michael Kinney wrote: [snip] > +// > +// Data structure that is required for ACPI S3 resume. This structure must > be > +// allocated below 4GB from memory of type EfiACPIMemoryNVS. The PCD > +// PcdCpuS3DataAddress must be set to the physical address where this >

Re: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Get APIC ID from CPUID if x2APIC supported

Yes. I think so. If x2APIC is supported by CPUID.(EAX=00H).ECX.BIT21, CPUID leaf 0x0B should be supported because x2APIC ID could be gotten from CPUID.(EAX=0BH, ECX=0H):EDX. Otherwise, we cannot get x2APIC ID before we enabled x2APIC mode. Jeff -Original Message- From: Kinney, Michael D

Re: [edk2] [PATCH 1/6] BaseTools/GenFw ARM: allow R_ARM_REL32 relocations

(add BaseTools maintainers) On 23 November 2015 at 17:56, Ard Biesheuvel wrote: > R_ARM_REL32 are relative relocations, so we don't need to do anything > special when performing the ELF to PE/COFF conversion, since our memory > layout is identical between the two

Re: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Get APIC ID from CPUID if x2APIC supported

Mike, OK. I got your point. I just reviewed the GetInitialApicId(). It has already check CPUID leaf 0B to get x2APIC ID if leaf 0B supported. // // Get the max index of basic CPUID // AsmCpuid (CPUID_SIGNATURE, , NULL, NULL, NULL); // // If CPUID Leaf B is supported,

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 function to PerformPreTasks().

In this way, we can centralize the silicon configuration in PerformRemainingTasks()/PerformPreTasks() function. If there are more features need to be configured, they can put in PerformRemainingTasks()/PerformPreTasks() only. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [patch] UefiCpuPkg/PiSmmCpu: Move SmmDebug from ASM to C.

SmmDebug feature is implemented in ASM, which is not easy to maintain. SO we move it to C function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Fan, Jeff" Cc: "Kinney, Michael D"

[edk2] [patch 2/3] MdeModulePkg/NvmExpress: Fix bug of handling not null-terminated strings

In EnumerateNvmeDevNamespace(), when Private->ControllerData->Sn and/or Private->ControllerData->Mn are NOT null-terminated strings, UnicodeSPrintAsciiFormat(…) may generate unexpected (garbage) output string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian

[edk2] [patch 3/3] MdeModulePkg/NvmExpress: Clean Phase/CqHdbl/SqTdbl fields to restart HC

Phase Tag, SqTdbl/CqHdbl and SqBuffer/CqBuffer should be cleared in NvmeControllerInit() to make HC functionality work when user invokes NvmeBlockIoReset(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Cc: Simon (Xiang) Lian-SSI

[edk2] [patch 0/3] Fix bugs raised by Samsung in NvmExpressDxe

The bugs include: 1. Phase Tag/SqHdbl/CqHdbl/CqBuffer/SqBuffer doesn't get cleaned correctly. 2. Memory leak in error handling path of NvmExpressDriverBindingStart(). 3. unexpected (garbage) output string for Sn/Mn field of ControllerData. Tian Feng (3): MdeModulePkg/NvmExpress: Fix mem leak in

[edk2] [Patch v2 1/2] UefiCpuPkg/CpuMpPei: Set X2APIC flag if one x2APIC ID larger than 254

If there are any logical processor reporting an APIC ID of 255 or greater, set X2ApicEnable flag. GetInitialApicId() will return x2APIC ID if CPUID leaf B supported. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution

[edk2] [Patch v2 0/2] Enable x2APIC if one x2APIC ID is larger than 254

If there are any logical processor reporting an APIC ID of 255 or greater. We should enable x2APIC mode. v2 updating: a. Drop v1 patch 1/3 and check if APIC ID is larger than 254 directly. b. Move ApFuncEnableX2Apic() from 1/2 to 2/2. Jeff Fan (2): UefiCpuPkg/CpuMpPei: Set X2APIC flag if one

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 function to PerformPreTasks().

On 11/24/15 09:36, jiewen yao wrote: > In this way, we can centralize the silicon configuration in > PerformRemainingTasks()/PerformPreTasks() function. > If there are more features need to be configured, they can put in > PerformRemainingTasks()/PerformPreTasks() only. > > Contributed-under:

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Hi Mike This patch is great. We can have a generic S3 support module now. After check the code, I am not sure if we have to allocate AcpiNvs for these data. Per my understanding, SMM CPU driver will always copy them into SMRAM, for security consideration. If so, do you think it is enough to

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

Long, Thanks, my RVCT is up to date at build 925 and I think the issue described only applies to 'goto' and 'case' statements. I updated the --diag_suppress as you suggested to ignore warning 128. Next issue are these two warnings:

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 2015/11/24 21:17, Laszlo Ersek wrote: On 11/24/15 02:01, Zeng, Star wrote: On 2015/11/23 22:01, Laszlo Ersek wrote: [snip] (2) although I see that you unified the GetControl / SetControl / SetAttributes implementations between - EarlyFdtPL011SerialPortLib and - FdtPL011SerialPortLib,

[edk2] [PATCH] ShellPkg: Wrong return status for Ifconfig.c

The Ifconfig command handler tries to return an EFI_STATUS when the return type should be SHELL_STATUS. RVCT 4 is (correctly) flagging this as an error: edk2\ShellPkg\Library\UefiShellNetwork1CommandsLib\Ifconfig.c(1387,10): error #188-D: enumerated type mixed with another type I haven't

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 11/24/15 15:27, Zeng, Star wrote: > On 2015/11/24 21:17, Laszlo Ersek wrote: >> On 11/24/15 02:01, Zeng, Star wrote: >>> On 2015/11/23 22:01, Laszlo Ersek wrote: >> >> [snip] >> (2) although I see that you unified the GetControl / SetControl / SetAttributes implementations between

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Jiewen, ACPI NVS is required for SMM disabled case. Mike > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 6:14 AM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Fan, Jeff

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

On 11/24/15 15:13, Yao, Jiewen wrote: > Hi Mike > This patch is great. > We can have a generic S3 support module now. > > After check the code, I am not sure if we have to allocate AcpiNvs for these > data. > Per my understanding, SMM CPU driver will always copy them into SMRAM, for > security

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

On Tue, 2015-11-24 at 14:19 +, Cohen, Eugene wrote: > > Here's a patch with this changes: > > --- >  edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf| 2 > +- >  edk2/CryptoPkg/Library/OpensslLib/openssl-1.0.2d/crypto/x509/x509_vfy.c | 1 + >  2 files changed, 2

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Got it. Agree. -Original Message- From: Kinney, Michael D Sent: Tuesday, November 24, 2015 10:47 PM To: Yao, Jiewen; edk2-devel@lists.01.org; Kinney, Michael D Cc: Laszlo Ersek; Fan, Jeff Subject: RE: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Re: [edk2] [PATCH v4 09/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

On 11/24/15 08:06, Kinney, Michael D wrote: > Laszlo, > > I other modules where we want to halt no matter what, the following 2 > statements are used together. ASSERT() could be removed by PCD > settings, so dead loop catches that case. If ASSERT() is enabled, > then the ASSERT() behavior of BP

Re: [edk2] [PATCH V3 11/12] ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

On 11/24/15 02:01, Zeng, Star wrote: > On 2015/11/23 22:01, Laszlo Ersek wrote: [snip] >> (2) although I see that you unified the GetControl / SetControl / >> SetAttributes implementations between >> - EarlyFdtPL011SerialPortLib and >> - FdtPL011SerialPortLib, >> >> the actual implementations

[edk2] Test 1; please ignore

Testing list destination rewrites; apologies for the noise. -- dwmw2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

sry for the late answer. The value of this register is: 0x10211103 I hope that helps. On Wed, Nov 18, 2015 at 12:16 PM, Ard Biesheuvel wrote: > On 16 November 2015 at 16:03, Michael Zimmermann > wrote: > > Unfortunately I can't tell you

Re: [edk2] [PATCH] ArmPkg/ArmLib: mark all cached mappings as (inner) shareable

It's the value of the register before EDK2 boots. If you want to know the register's value at a specific UEFI stage, just tell me. On Tue, Nov 24, 2015 at 2:49 PM, Michael Zimmermann < sigmaepsilo...@gmail.com> wrote: > sry for the late answer. > > The value of this register is: 0x10211103 > I

[edk2] [patch] MdeModulePkg/PiSmmIpl: Move CommunicationBuffer from stack to global variable.

We had put communication buffer to Runtime memory, so that SMI handler can know it is not used by OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zeng, Star" Cc: "Fan, Jeff" Cc:

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpu: Move RestoreSmmConfigurationInS3 function to PerformPreTasks().

Got it. I will remove the two leading space characters. Thanks! -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, November 24, 2015 6:21 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Fan, Jeff; Kinney, Michael D Subject: Re: [patch] UefiCpuPkg/PiSmmCpu:

[edk2] Test 2; please ignore

Testing list destination rewrites; apologies for the noise. -- dwmw2 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Dynamic PCD Variable Storage in PEI Phase

On 11/24/15 00:25, Andrew Fish wrote: > >> On Nov 23, 2015, at 2:03 PM, Narinder Dhillon wrote: >> >> Hi Andrew, >> >> I looked at the ArmVirtPkg and did the same before I sent the previous >> email. I am missing some step that is causing the null package to be >> picked

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Yes, I found only ApMachineCheckHandlerBase is copied back, because it is code. CopyMem ((VOID *)(UINTN) mAcpiCpuData.ApMachineCheckHandlerBase, mMachineCheckHandlerForAp, mAcpiCpuData.ApMachineCheckHandlerSize); There is no need to copy other data back to original place because it just

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

On 24 November 2015 at 15:47, David Woodhouse wrote: > On Tue, 2015-11-24 at 14:19 +, Cohen, Eugene wrote: >> >> Here's a patch with this changes: >> >> --- >> edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf| 2 >> +- >>

Re: [edk2] CryptoPkg: OpenSSL build issue with RVCT

Ard, thanks - as you can tell this is an issue in the original flags and not with the changes I've added. I agree that we should not redefine the fpu in this file but rather inherit from the build. David, good comments - I'm working on an updated patch. I'm running into some issues related

Re: [edk2] Integrate application into Shell

Johannes, In order for an application to use features from STDLIB, the application must be explicitly linked with the appropriate libraries. For applications that are built into the shell and are part of the same .efi file the rules that apply to standalone applications should work. The Shell