Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

On 15 December 2015 at 11:28, Leif Lindholm wrote: > On Tue, Dec 15, 2015 at 11:10:49AM +0100, Ard Biesheuvel wrote: >> On 8 December 2015 at 16:11, Ard Biesheuvel >> wrote: >> > Commit SVN r18778 made all mappings of normal memory (inner)

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

Greetings Samer, I would like to see this patch implemented. Part of the issue I am wrestling with on our AARCH64 platform is how our PCIe's are supported. In our current architecture, we can have up to 6 PCIe's connected through two Switch Logic Interfaces (SLI) that must be programmed

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

Jordan, Reponses included below. 1) edk2: Maintainers.txt patch email sent. 2) Thank you very much for ack and detailed review/feedback in Quark*Pkgs 3) I have fixed all the items for the edk2-non-osi repository and pushed them to: https://github.com/mdkinney/edk2-non-osi.git Can you

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

On 2015-12-15 09:54:25, Kinney, Michael D wrote: > Jordan, > > Reponses included below. > > 1) edk2: Maintainers.txt patch email sent. > 2) Thank you very much for ack and detailed review/feedback in Quark*Pkgs > 3) I have fixed all the items for the edk2-non-osi repository and pushed them >

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

Ok.I understand! I did implement new and delete API's for EFi and they are working fine now.Now I am getting below linker errors which I am not sure how to resolve them.Do we have any specific compiler flags for disabling these errors or I have to define them in my code? Linker errors:

Re: [edk2] [PATCH] ArmPkg/CpuDxe: drop ARMv4 exception handling code

On Tue, Dec 15, 2015 at 10:47:56AM +0100, Ard Biesheuvel wrote: > Since we do not support anything below ARMv7, let's promote the ARMv6 > exception handling code in CpuDxe to the only version we provide for > ARM. This means we can drop the unused ARMv4 version. > > Contributed-under: TianoCore

Re: [edk2] [PATCH] ArmPkg/CpuDxe: drop ARMv4 exception handling code

On 15 December 2015 at 10:51, Leif Lindholm wrote: > On Tue, Dec 15, 2015 at 10:47:56AM +0100, Ard Biesheuvel wrote: >> Since we do not support anything below ARMv7, let's promote the ARMv6 >> exception handling code in CpuDxe to the only version we provide for >> ARM.

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

On 15 December 2015 at 11:06, M.V.R. Ravikanth wrote: > Yes.I am using -fno-rtti.So you want me to remove this flag? > No, you should keep it. As I said, things like exceptions and RTTI will make your job a lot more difficult. I was just curious whether you could get rid

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

On 15 December 2015 at 10:07, M.V.R. Ravikanth wrote: > Ok.I understand! > > I did implement new and delete API's for EFi and they are working fine > now.Now I am getting below linker errors which I am not sure how to resolve > them.Do we have any specific compiler flags

[edk2] [PATCH] ArmPkg/CpuDxe: drop ARMv4 exception handling code

Since we do not support anything below ARMv7, let's promote the ARMv6 exception handling code in CpuDxe to the only version we provide for ARM. This means we can drop the unused ARMv4 version. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

On 14 December 2015 at 18:11, Leif Lindholm wrote: > On Mon, Dec 14, 2015 at 05:25:03PM +0100, Ard Biesheuvel wrote: >> CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different >> from the default memset() [arguments 2 and 3 are reversed] >> >>

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

Yes.I am using -fno-rtti.So you want me to remove this flag? Regards,Ravi > Date: Tue, 15 Dec 2015 10:41:15 +0100 > Subject: Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors > From: ard.biesheu...@linaro.org > To: mvrravika...@live.com > CC: af...@apple.com; edk2-devel@lists.01.org;

Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

On 8 December 2015 at 16:11, Ard Biesheuvel wrote: > Commit SVN r18778 made all mappings of normal memory (inner) shareable, > even on hardware that implements shareability as uncached accesses. > The original concerns that prompted the change, regarding coherent DMA >

Re: [edk2] [PATCH 1/3] ArmPkg/ArmGic: fix bug in GICv3 distributor configuration

On Thu, Dec 03, 2015 at 02:58:36PM +0100, Ard Biesheuvel wrote: > In the function ArmGicEnableDistributor (), the Affinity Routing Enable > (ARE) bit, which essentially defines whether the GIC runs in v2 or v3 > mode, is inadvertently cleared when enabling the GIC distributor if it > is running in

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

For ELF EM_AARCH64 relocation 0x105,I am unable to find any .elf file from which I could read the re locations.All I have is a .map and a .dll.Is there any way to way make changes to Elf64Convert.c to support this relocation or else can I port the EDK2 trunk fix to current UDK? For

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

On 15 December 2015 at 12:04, M.V.R. Ravikanth wrote: > Ard, > I have now compiled and linked my CPP code without standard C++ > libraries.But still I am receiving below relocation errors. > > GenFw: ERROR 3000: Invalid > WriteSections64(): >

Re: [edk2] [PATCH v2] ArmPkg/ArmV7Mmu: prefer non shareable memory on non-coherent hardware

On Tue, Dec 15, 2015 at 11:10:49AM +0100, Ard Biesheuvel wrote: > On 8 December 2015 at 16:11, Ard Biesheuvel wrote: > > Commit SVN r18778 made all mappings of normal memory (inner) shareable, > > even on hardware that implements shareability as uncached accesses. > >

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

Oh ok.I have implemented the __cxa_pure_virtual() and its being executed.Will let you know the results :) Thanks a ton again! It really means a lot to me. Regards,Ravi> Date: Tue, 15 Dec 2015 11:08:22 +0100 > Subject: Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors > From:

Re: [edk2] GenFW Error 3000 Invalid WriteRelocations64() errors

Ard,I have now compiled and linked my CPP code without standard C++ libraries.But still I am receiving below relocation errors. GenFw: ERROR 3000: Invalid WriteSections64():

Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg packages

QuarkSocPkg committed as SVN r19286 QuarkPlatformPkg committed as SVN r19287 > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, December 15, 2015 11:30 AM > To: Kinney, Michael D ; edk2- > de...@lists.01.org (edk2-devel@lists.01.org)

[edk2] [PATCH] IntelFrameworkModulePkg : Allow ACPI tables to get installed above 4GB

Some ARM systems do not have available memory below 4GB, and still support ACPI. This patch allows the tables to get loaded above 4GB if the allocation below 4GB fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud ---

Re: [edk2] [PATCH] SecurityPkg: Add TCG physical presence definition for clear deactivate

Jiewen, Agreed. This is a mistake, and you can discard this patch. Thanks, --Samer -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Monday, December 14, 2015 6:58 PM To: El-Haj-Mahmoud, Samer ; edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

OK. I can help on that. Thanks to fix that. Thank you Yao Jiewen From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Tuesday, December 15, 2015 8:54 AM To: edk2-devel@lists.01.org; Yao, Jiewen Subject: RE: [edk2] [PATCH] MdePkg: Add GIC version to ACPI and 6 definitions

Re: [edk2] InsertImageRecord and Section Alignment

Baranee, What build flags are you using? Most platforms can add the following in their DSC file to get this to work form VS20xx tool chains. [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 Thanks, Mike > -Original Message- > From: edk2-devel

[edk2] [Patch] QuarkPlatformPkg/SpiFvbServices: Remove duplicate global variable

Remove declaration of gEfiFirmwareVolumeBlockProtocolGuid and gEfiSmmFirmwareVolumeBlockProtocolGuid that are generating build failures on GCC because these same variables are declared in AutoGen.c and assigned a GUID value from DEC file. Cc: Kelly Steele

Re: [edk2] [PATCH v2] MdePkg: Add missing SMBIOS definitions for SATA and SAS Ports

On 2015/12/16 4:44, Samer El-Haj-Mahmoud wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/SmBios.h | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Star Zeng

[edk2] [Patch] QuarkPlatformPkg/PlatformSecLib: Sync Flat32.S with Flat32.asm

Update Flat32.S to match Flat32.asm. A sync was missed, so Flat32.S is calling SecStartup instead of PlatformSecLibStartup which is causing a boot failures with GCC builds because the caches are not initialized correctly when the call to PlatformSecLibStartup is not performed. Cc: Kelly Steele

Re: [edk2] [PATCH] IntelFrameworkModulePkg : Allow ACPI tables to get installed above 4GB

I agree with 2). New function is better. Jeff -Original Message- From: Yao, Jiewen Sent: Wednesday, December 16, 2015 8:49 AM To: Samer El-Haj-Mahmoud; edk2-devel@lists.01.org Cc: Samer El-Haj-Mahmoud; Fan, Jeff Subject: RE: [edk2] [PATCH] IntelFrameworkModulePkg : Allow ACPI tables to

Re: [edk2] Regarding the demotion of 64-bit BARs when an option ROM is detected

Mike, The issue is that even with Legacy OptionROM, most adapters that advertise 64bit MMIO capability actually support it. We have seen instances of specific adapters/classes of adapters that don't work unless they get degeaded, but that is not usually following the generic pattern of the

Re: [edk2] InsertImageRecord and Section Alignment

Baranee, I see that error message if a PE/COFF image is stored in TE format or is XIP PE/COFF image. In general, modules of type DXE_RUNTIME_DRIVER are not expected to use TE or be XIP. Here is an example FDF file FFS rule for modules of type DXE_RUNTIME_DRIVER. It uses PE32 (not TE) and it

Re: [edk2] InsertImageRecord and Section Alignment

Normally, DXE Runtime driver will not be rebased unless you expect it to run as XIP. Is it your expectation? If not, you can configure FvForceRebase=FALSE to disable rebase in FV that includes runtime drivers. [FV.DXEFV] BlockSize = 0x1000 FvForceRebase = FALSE # add this line

Re: [edk2] [Patch] edk2: Add maintainers for Quark*Pkg

I kind of prefer using Maintainers.txt for the subject prefix, but edk2 seems okay as well: Maintainers.txt: Add maintainers for Quark*Pkg On 2015-12-15 09:26:16, Michael Kinney wrote: > Add maintaintainers for the QuarkSocPkg and QuarkPlatformPkg > > Contributed-under: TianoCore Contribution

[edk2] [Patch] MdeModulePkg: Update print error level for RuntimeDriver alignment check

In DxeCore, use warning message for Runtime driver that doesn't satisfy section alignment requirement. This check is required when PropertiesTable is installed. So, add error message if PropertiesTable can't be installed successfully. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch] MdeModulePkg: Update print error level for RuntimeDriver alignment check

Reviewed-by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 16, 2015 1:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] MdeModulePkg: Update print error level for RuntimeDriver

Re: [edk2] [PATCH 2/3] ArmVExpressPkg/ArmVExpress-FVP-AArch64: run GICv3 in v3 mode

On Thu, Dec 03, 2015 at 02:58:37PM +0100, Ard Biesheuvel wrote: > After fixing ArmGicEnableDistributor() in a previous patch, there is no > longer a reason to run the GICv3 in v2 mode, so remove the PCD override. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

On 15 December 2015 at 13:45, Leif Lindholm wrote: > > On Thu, Dec 03, 2015 at 02:58:38PM +0100, Ard Biesheuvel wrote: > > The need for a v2 legacy override to drive a GICv3 in v2 mode is no > > longer necessary, now that the code that enabled the GIC distributor no > >

Re: [edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

On Thu, Dec 03, 2015 at 02:58:38PM +0100, Ard Biesheuvel wrote: > The need for a v2 legacy override to drive a GICv3 in v2 mode is no > longer necessary, now that the code that enabled the GIC distributor no > longer inadvertently kicks a v2 capable GICv3 into v2 mode. So remove > the PCD and all

[edk2] [PATCH v2] MdePkg: Add missing SMBIOS definitions for SATA and SAS Ports

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/SmBios.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h

Re: [edk2] InsertImageRecord and Section Alignment

Am using the same rules. Similar error message is used in BaseTools\Source\C\GenFv\GenFvInternalLib.c - FfsRebase() as well and it checks for driver type. Both DXE driver and DXE_RUNTIME_DRIVER uses same driver type - 0x07 > -Original Message- > From: edk2-devel

Re: [edk2] [Patch v2] BootManagerLib: Check the pointer to avoid use NULL pointer.

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, December 16, 2015 11:01 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v2] BootManagerLib: Check the pointer to avoid

[edk2] [PATCH v2 1/5] ArmPkg: use unified asm syntax for CLANG

The CLANG assembler does not support the legacy, non-unified assembler syntax, i.e., it does not support the reordering of the condition suffixes with the increment/decrement before/after or byte/word suffixes, and it does not recognize the 'empty descending' (ED) suffix at all. So move to the

[edk2] [PATCH v2 2/5] ArmPkg/CompilerIntrinsicsLib: add GCC version of __aeabi_memset()

CLANG for ARM may emit calls to __aeabi_memset(), which is subtly different from the default memset() [arguments 2 and 3 are reversed] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 5/5] BaseTools ARM: add CLANG35 support

This extends the existing CLANG35 toolchain definition with support for building for the ARM architecture. In order to be able to reuse the existing ARM GCC definitions as much as possible, the following changes have been made to the existing ARM GCC support: - the -mapcs option has been removed;

[edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not supported by CLANG. So restrict its use to GCC 4.6, which is the oldest version we support for ARM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

On Tue, Dec 15, 2015 at 03:24:55PM +0100, Ard Biesheuvel wrote: > The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not > supported by CLANG. So restrict its use to GCC 4.6, which is the oldest > version we support for ARM. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 0/5] add CLANG support for ARM

On 15 December 2015 at 15:24, Ard Biesheuvel wrote: > This series consists of 4 patches that tweak existing ARM code so it can be > built with Clang, and a final patch against tools_def.template that introduces > the defines so that '-a ARM' can be combined with '-t

[edk2] [PATCH v2 0/5] add CLANG support for ARM

This series consists of 4 patches that tweak existing ARM code so it can be built with Clang, and a final patch against tools_def.template that introduces the defines so that '-a ARM' can be combined with '-t CLANG35' Changes since v1: - reshuffled code and added comment to patch #2 (Leif) -

Re: [edk2] [PATCH v2 4/5] ArmPkg/ArmSoftfloatLib: restrict -fno-tree-vrp option to GCC46

On Tue, Dec 15, 2015 at 03:50:43PM +0100, Ard Biesheuvel wrote: > On 15 December 2015 at 15:47, Leif Lindholm wrote: > > On Tue, Dec 15, 2015 at 03:24:55PM +0100, Ard Biesheuvel wrote: > >> The -fno-tree-vrp option is not required for GCC 4.7 or later, and is not > >>

Re: [edk2] [Patch 1/2] BootManagerLib: Check the pointer to avoid use NULL pointer.

Eric: Could you check its return status first, then check its return value? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, December 15, 2015 9:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 1/2]

Re: [edk2] [Patch] MdeModulePkg: Change file format which the existed folder has mixed file format

Reviewed-by: Liming Gao -Original Message- From: Dong, Eric Sent: Wednesday, December 16, 2015 8:55 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] MdeModulePkg: Change file format which the existed folder has mixed file format Convert the

[edk2] [patch] MdeModulePkg:Fix a bug HttpLib can't parse last chunked data well

When HttpLib parsing the last chunked data down, the Http NextMsg pointer in the HttpBodyParserCallback function should point to the character after '/n' flag. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore

[edk2] recommended ARM toolchain

Hi, when reading building guides etc u always find people using "arm-linux-gnueabihf-" for building UEFI. But does that actually make sense? I'd rather use sth. like Google's kernel toolchain "arm-eabi-". UEFI doesn't actually use standard libs so the eabi shouldn't matter. Also I don't think