Re: [edk2] Issues with HTTPS Boot

Naveen, I cannot see attachments on this email. What TLS versions and ciphers does your web server support? Depending on when you built the UEFI image, your server may need to have TLS v1.0 enabled and support one of the non-SHA256 ciphers listed at the top of

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Felix, We should only add the DEBUG_ defines for new bit values. We would like to retire the use of EFI_D_ defines and encourage use of DEBUG_ defines. The reason is that DEBUG() macros apply to all execution phases and module types. Also, what is the use case for DEBUG_CSM. I would image

Re: [edk2] edk2 compile error

Hi All, Thank you. I installed nasm-2.12.02 and it workd. We will upgrade to RHEL-7 soon. Thanks Fan Chen -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, September 19, 2016 7:00 PM To: Chen, Farrah ; 'edk2-de...@ml01.01.org'

[edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm. It cause ASSERT() reported at https://tianocore.acgmultimedia.com/show_bug.cgi?id=123 Jeff Fan (3): QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S UefiCpuPkg/SecCore: Fix comment typo

[edk2] [Patch 3/3] UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs

Currently, this is ASSERT() if neither SecPlatformInformation2 nor SecPlatformInformation PPIs are found. This is not correct. Per PI specification both of them are optional PPI. Platform may not install them. Cc: Michael Kinney Cc: Feng Tian

[edk2] [Patch 2/3] UefiCpuPkg/SecCore: Fix comment typo

Revert SecPlatformInformation2 and SecPlatformInformation in two comment blocks. And correct the words. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S

ESP should be set to top of eSRAM range that aligns with Flat32.asm. Because CPU BIST data will be located at top of STACK, this issue leads Platform Sec Lib cannot get the correct CPU BIST information. This fix is to address below issue: https://tianocore.acgmultimedia.com/show_bug.cgi?id=123

Re: [edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

There is typo in the title of patches, SecuriryPkg should be SecurityPkg and I have correct it at local, you may skip it when reviewing patches. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, September 20, 2016 6:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star

[edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

These patches move/extract Tpm2PcrAllocateBanks(), Tpm2GetCapabilitySupportedAndActivePcrs(), CopyDigestListToBuffer(), GetDigestListSize() and GetDigestFromDigestList() to Tpm2CommandLib. Cc: Chao B Zhang Cc: Jiewen Yao Jiewen Yao (5):

[edk2] [PATCH] SecurityPkg/TPM2: Sync PcrAllocations and PcrMask

From: Jiewen Yao Current TCG2 implementation will set Tpm2HashMask PCD value according to TPM2 PCR bank. However, there might be misconfiguration in BIOS build phase. The enhanced logic makes sure that the current PCR allocations, the TPM supported PCRs, and the

[edk2] [PATCH 6/6] SecuriryPkg/TPM2: Extract GetSupportedAndActivePcrs to Tpm2CommandLib

From: Jiewen Yao This patch extracts function Tpm2GetCapabilitySupportedAndActivePcrs() from drivers and also update Tcg2ExecutePhysicalPresence() to call Tpm2GetCapabilitySupportedAndActivePcrs() instead of Tcg2Protocol->GetCapability to query the TPM to determine which

[edk2] [PATCH 5/6] SecuriryPkg/TPM2: Move CopyDigestListToBuffer() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function CopyDigestListToBuffer() from drivers to library with HashAlgorithmMask parameter added to make the interface more applicable. The related function IsHashAlgSupportedInHashAlgorithmMask() is also moved from drivers to library

[edk2] [PATCH 2/6] SecuriryPkg/TPM2: Move GetDigestFromDigestList() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function Tpm2GetDigestFromDigestList() from drivers to library as GetDigestFromDigestList() and no functionality change. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 4/6] SecuriryPkg/TPM2: Move GetDigestListSize() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function GetDigestListSize() from drivers to library and no functionality change. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 13:02, Wu, Hao A wrote: >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, September 20, 2016 4:38 PM >> To: Wu, Hao A >> Cc: leif.lindh...@linaro.org;

[edk2] Issues with HTTPS Boot

Hello All, Since the HTTPS Boot came into picture, I was very enthusiastic to try it. I configured the server as-is explained in the white paper https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers But when I try to go for an HTTPS boot, it stops

[edk2] UEFI BitlockerUnlock failed with DHCPv4 only case.

Hello All, I have been facing a problem i.e., Network Unlock is failing when tried with DHCP4 only by disabling TCP/IPv6. My server configuration is as below: 1.WDS Server details I.P: 10.10.10.11 Net Mask: 255.255.255.0 2.DHCP Server details IP: 10.10.10.2 Scope:

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 13:16, Ard Biesheuvel wrote: > On 20 September 2016 at 13:02, Wu, Hao A wrote: >>> -Original Message- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >>> Biesheuvel >>> Sent: Tuesday,

Re: [edk2] Help Required legacy booting from an EFI

On Mon, Sep 19, 2016 at 10:49 PM, Laszlo Ersek wrote: > On 09/19/16 17:00, Saqib Khan wrote: > > Hello all, this is my first post to this list and i am very new to edk2 > > development. > > > > I started by building BootManagerMenuApp with following functionality > > > >-

Re: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

Jeff, These changes look good to me and I have verified Galileo boots with these changes. Series Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Fan > Sent: Tuesday,

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Mike and Liming, Thanks for reviewing the patch. I implemented all the requested modifications: - EFI_D_ definitions are removed - DEBUG_CSM is removed - Validation expression in MdePkg.dec is updated - MdePkg.uni is updated Here is the updated patch Contributed-under: TianoCore Contribution

Re: [edk2] Help Required legacy booting from an EFI

CC'ing Ray On 09/20/16 20:38, Saqib Khan wrote: > > > On Mon, Sep 19, 2016 at 10:49 PM, Laszlo Ersek > wrote: > > On 09/19/16 17:00, Saqib Khan wrote: > > Hello all, this is my first post to this list and i am very new to edk2 > >

[edk2] [EDK2][USB IF]Mismatch between EDK2 and a USB vendor

Hello, This is relating to my previous post "[edk2] Is this a right place to discuss EDK2's USB IF implementation?" We found a mismatch between EDK2 source code and our USB vendor's implementation. Could you give us your opinions? bInterfaceNumber , 9.6.5 Interface from Universal Serial Bus

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

Ard: Thanks! Other two patches are good. Reviewed-by: Liming Gao Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, September 20, 2016 8:41 PM To: Wu, Hao A Cc:

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Reviewed-by: Liming Gao > -Original Message- > From: Felix Poludov [mailto:fel...@ami.com] > Sent: Wednesday, September 21, 2016 3:29 AM > To: Kinney, Michael D ; Gao, Liming > ; edk2-devel@lists.01.org > Subject:

[edk2] [Patch 0/3] BaseTools: Add build support to generate HII image package

HII image package is defined in UEFI spec. But, EDK2 BaseTools doesn't support its generation. To fill this gap, new image description file (*.idf) is introduced to describe HII image resource. *.idf file syntax has been proposed into edk2 community. This patch updates BaseTools base on it to

Re: [edk2] [Patch 0/4] Add support for running python tools from source on Windows

Reviewed the series of 4 patches. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, September 13, 2016 12:03 AM To: edk2-devel@lists.01.org

Re: [edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

Reviewed-by: Eric Dong > -Original Message- > From: Gao, Liming > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Bi, Dandan > Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new > EFI_HII_IIBT_IMAGE_PNG type

Re: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan; Dong, Eric > Subject: [edk2] [Patch 1/3]

[edk2] [Patch] CryptoPkg: Clean up unreferenced symbol in Cryptest utility.

Remove "TSCounterSignature" from TSVerify.c, which is not being used by anyone. Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Application/Cryptest/TSVerify.c | 137 --

Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec

Boaz: This protocol is edk2 implement protocol. We have no plan to propose it to UEFI spec. Its EFI_ prefix is history reason. To avoid the incompatible change, we don't change its definition. But for any new introduced protocol, we will insist on this rule without EFI_ prefix. Thanks

Re: [edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

Reviewed-by: Dandan Bi -Original Message- From: Gao, Liming Sent: Wednesday, September 21, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Bi, Dandan Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new

Re: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Reviewed-by: Dandan Bi -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, September 21, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric

[edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

HiiImage protocol implementation doesn't support EFI_HII_IIBT_IMAGE_PNG. Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

[edk2] [Patch 3/3] BaseTools: support generating image package from BMP/JPEG/PNG files

From: Yonghong Zhu BaseTools add support to generating image package from BMP/JPEG/PNG files. 1) New file type *.idf Image definition file to describe HII image resource. It is the ASCII text file, and includes one or more "#image IMAGE_ID [TRANSPARENT] ImageFileName". 2)

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Felix: I have two comments. 1) Update @Expression 0x8002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel & 0x7F84AA00) == 0. 0x7F84AA00 should be updated to match the valid debug error level bit mask. 2) PCD help message in MdePkg.uni is also required to be updated. Thanks Liming

Re: [edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, September 20, 2016 6:51 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Zhang, Chao B > ; Yao, Jiewen > Subject: [PATCH 0/6]

Re: [edk2] SMM PciExpressLib Instance

Felix: This patch is good to me. Reviewed-by: Liming Gao Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Felix Poludov Sent: Thursday, September 15, 2016 8:55 PM To: Kinney, Michael D ;