[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Generate UUID.

2018-09-07 Thread Guo, Mang
Generate UUID for MinnowBoard Max. User can configure their UUID in setup UI. If user don't configure it in setup, MAC address will be used as UUID. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Vlv2TbltDevicePkg/Include/Guid/SetupVariable.h | 1 +

Re: [edk2] [PATCH 19/37] IntelSiliconPkg: Removing ipf which is no longer supported from edk2.

2018-09-07 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen, > Chen A > Sent: Wednesday, June 13, 2018 11:45 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > > Subject: [edk2] [PATCH 19/37]

Re: [edk2] [PATCH 32/37] SignedCapsulePkg: Removing ipf which is no longer supported from edk2.

2018-09-07 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen, > Chen A > Sent: Wednesday, June 13, 2018 11:46 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > > Subject: [edk2] [PATCH 32/37]

Re: [edk2] [PATCH 27/37] PcAtChipsetPkg: Removing ipf which is no longer supported from edk2.

2018-09-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of chenc2 > Sent: Wednesday, June 13, 2018 11:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > > Subject: [edk2] [PATCH 27/37] PcAtChipsetPkg: Removing ipf which is no > longer

[edk2] [Patch] INF spec: Correct some items in the Table 1 EDK II [Defines] Section

2018-09-07 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1162 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- 2_inf_overview/24_[defines]_section.md | 59

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-07 Thread Liran Alon
> On 7 Sep 2018, at 11:44, Laszlo Ersek wrote: > > (+Ard) > > On 09/06/18 21:08, Nikita Leshenko wrote: >> Hi, >> >> We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the >> flow >> of the bug: >> >> 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a

Re: [edk2] Performance enabling of Event handler

2018-09-07 Thread prabin ca
Hi Yes it is included in same module (both event handler and function handler), and I’m not perf_start and perf_end only two times (one is by event handler and one is by normal function handler). And I’m trying to print result using DP.efi, it shows entry for normal function. > On

[edk2] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma to 6.9.0

2018-09-07 Thread Liming Gao
From: Dongao Guo The change is in https://github.com/lgao4/edk2/tree/Oniguruma Update Oniguruma to the latest version v6.9.0. Oniguruma https://github.com/kkos/oniguruma Verify VS2017, GCC5 build. Verify RegularExpressionProtocol GetInfo() and Match() function. Contributed-under: TianoCore

Re: [edk2] [platforms: PATCH 1/7] Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride

2018-09-07 Thread Marcin Wojtas
Hi Ard, pt., 7 wrz 2018 o 13:29 Ard Biesheuvel napisał(a): > > On 6 September 2018 at 16:45, Ard Biesheuvel > wrote: > > On 6 September 2018 at 16:38, Marcin Wojtas wrote: > >> czw., 6 wrz 2018 o 16:31 Ard Biesheuvel > >> napisał(a): > >>> > >>> On 6 September 2018 at 16:26, Marcin Wojtas

[edk2] [edk2-platforms] Remove branches from edk2-platforms

2018-09-07 Thread Guo, Mang
Propose removing below branches from edk2-platforms since these branches will not be maintained. If you have any comments on this change, please reply to this email. https://github.com/tianocore/edk2-platforms/tree/devel-MinnowBoard3-UDK2017

Re: [edk2] [PATCH v2 3/3] SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

2018-09-07 Thread Laszlo Ersek
On 09/07/18 07:42, Ard Biesheuvel wrote: > Now that Itanium support has been dropped, we can remove the various > occurrences of the ELILO on Itanium PE/COFF header workaround. > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816 > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] PciBusDxe: PCI-Express bug with dynamic PcdPciExpressBaseAddress

2018-09-07 Thread Laszlo Ersek
(+Ard) On 09/06/18 21:08, Nikita Leshenko wrote: > Hi, > > We ran into a bug in EDK2 relating to PCI-Express in PciBusDxe. Here's the > flow > of the bug: > > 1. PciBusDxe/PciEnumeratorSupport.c: Function BarExisted probes a BAR. It > raises >TPL to TPL_HIGH_LEVEL to avoid timer

[edk2] [Patch] ShellPkg: Remove trailing white space

2018-09-07 Thread Fu Siyuan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1158 Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Fu Siyuan --- ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [Patch] BaseTool: Variable Merge.

2018-09-07 Thread BobCF
If Structure PCD and Normal Pcd refer to the same variable, do variable merge. Enhance error message. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 3 +-

[edk2] [Patch] Build spec: correct the Operator used in the expression for Table 12

2018-09-07 Thread Yonghong Zhu
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=598 Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- .../82_auto-generation_process.md | 34 +++--- README.md

[edk2] [Patch] SecurityPkg: HashLib: Change dos format

2018-09-07 Thread Zhang, Chao B
Change file format to DOS Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang Chao B Signed-off-by: Zhang, Chao B --- .../HashInstanceLibSha384/HashInstanceLibSha384.c | 310 ++--- .../HashInstanceLibSha384.inf | 90

[edk2] [PATCH v2 0/4] SdMmc fixes

2018-09-07 Thread Marcin Wojtas
Hi, Answering the review request, I extracted SdMmcPciHcDxe driver fixes from SdMmcOverride protocol modification. Comparing to v1, patches are rebased onto the newest master branch and also a macro is used instead of the raw value in SdMmcHcReset. Patches are available in the github:

[edk2] [PATCH v2 1/4] MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation

2018-09-07 Thread Marcin Wojtas
When switching to any of high speed modes (HS, HS200, HS400) there is need to set HS_ENABLE bit in Host Control 1 register which allow Host Controller to output CMD and DAT lines on both edges of clock. In Linux it is done after switching bus width in sdhci_set_ios(). Also according to

[edk2] [PATCH v2 2/4] MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence

2018-09-07 Thread Marcin Wojtas
According to JESD84-B50-1 chapter A.6 (documentation about eMMC4.5 standard) step "Changing the data bus width" (A.6.3) should be execute after step "Switching to high-speed mode" (A.6.2). This patch fixes the bus-width/clock-setting sequence in EmmcSwitchToHighSpeed (). Contributed-under:

[edk2] [PATCH v2 3/4] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits

2018-09-07 Thread Marcin Wojtas
From: Tomasz Michalec SdMmcHcReset used to set all bits of Software Reset Register to 1 including reserved ones. Now only first bit is set which means "Software Reset for All". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [PATCH v2 4/4] MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot

2018-09-07 Thread Marcin Wojtas
Some devices can be non removable (such as eMMC) and checking Present State Register on host controller may falsely return an information that device is not present. Execute this check conditionally on the SloType field value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue

2018-09-07 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c

Re: [edk2] [Patch] ShellPkg: Remove trailing white space

2018-09-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Fu, Siyuan > Sent: Friday, September 7, 2018 4:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [Patch] ShellPkg: Remove trailing white space > > REF:

Re: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue

2018-09-07 Thread Laszlo Ersek
On 09/07/18 12:13, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Dandan Bi > --- > UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [edk2] [PATCH 3/3] MdeModulePkg/NonDiscoverablePciDeviceDxe: add missing validation

2018-09-07 Thread Ard Biesheuvel
On 6 September 2018 at 20:55, Vladimir Olovyannikov wrote: > UEFI SCT crashed and failed in NonDiscoverablePciDeviceDxe becase > required checks were not performed. Perform parameters validation in > NonDiscoverablePciDeviceDxe. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 1/3] EmbeddedPkg/CoherentDmaLib: Fix typo in DmaAlignedBuffer

2018-09-07 Thread Ard Biesheuvel
On 6 September 2018 at 20:55, Vladimir Olovyannikov wrote: > The only valid memory types for DmaAlignedBuffer should be > EfiBootServicesData and EfiRuntimeServicesData. However due to the typo, > there is no way to allocate runtime pages, and INVALID_PARAMETER is > always returned. Fix the typo.

Re: [edk2] [PATCH] Maintainer.txt: Add Ray to be co-maintainer of EmulatorPkg

2018-09-07 Thread Andrew Fish
Reviewed-by: Andrew Fish mailto:jordan.l.jus...@intel.com>pple.com> > On Sep 6, 2018, at 6:27 AM, Ruiyu Ni wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jordan Justen > Cc: Andrew Fish > --- > Maintainers.txt | 1 + > 1 file changed, 1

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits

2018-09-07 Thread Ard Biesheuvel
On 7 September 2018 at 11:10, Marcin Wojtas wrote: > From: Tomasz Michalec > > SdMmcHcReset used to set all bits of Software Reset Register to 1 > including reserved ones. > > Now only first bit is set which means "Software Reset for All". > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v2 0/4] SdMmc fixes

2018-09-07 Thread Ard Biesheuvel
+Hao On 7 September 2018 at 11:10, Marcin Wojtas wrote: > Hi, > > Answering the review request, I extracted SdMmcPciHcDxe driver fixes > from SdMmcOverride protocol modification. Comparing to v1, > patches are rebased onto the newest master branch and also a macro > is used instead of the raw

Re: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable

2018-09-07 Thread Laszlo Ersek
On 09/07/18 06:39, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni Commit 98257f982072. Thanks Laszlo >> -Original Message- >> From: edk2-devel On Behalf Of shenglei >> Sent: Friday, September 7, 2018 9:52 AM >> To: edk2-devel@lists.01.org >> Cc: Carsey, Jaben ; Ni, Ruiyu >> Subject:

Re: [edk2] [platforms: PATCH 1/7] Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride

2018-09-07 Thread Ard Biesheuvel
On 6 September 2018 at 16:45, Ard Biesheuvel wrote: > On 6 September 2018 at 16:38, Marcin Wojtas wrote: >> czw., 6 wrz 2018 o 16:31 Ard Biesheuvel >> napisał(a): >>> >>> On 6 September 2018 at 16:26, Marcin Wojtas wrote: >>> > czw., 6 wrz 2018 o 16:04 Ard Biesheuvel >>> > napisał(a): >>>

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues

2018-09-07 Thread Wang, Jian J
Forgot to mention the BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=1160 Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Saturday, September 08, 2018 10:22 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan > Subject:

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation

2018-09-07 Thread Wang, Jian J
Forgot to mention BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=1095 Regards, Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > Sent: Saturday, September 08, 2018 10:48 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2]

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation

2018-09-07 Thread Wang, Jian J
And BZ#1164: https://bugzilla.tianocore.org/show_bug.cgi?id=1164 Regards, Jian From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] Sent: Saturday, September 08, 2018 11:25 AM To: edk2-devel ; edk2-devel@lists.01.org Cc: Wu, Hao A Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an

Re: [edk2] [Patch] SecurityPkg: HashLib: Change dos format

2018-09-07 Thread Bi, Dandan
Reviewed-by: Dandan Bi One minor comment that please remove the additional " Signed-off-by: Zhang, Chao B ", which can't pass the PatchCheck script. Thanks, Dandan -Original Message- From: Zhang, Chao B Sent: Friday, September 7, 2018 4:50 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan

Re: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue

2018-09-07 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Ni, Ruiyu Sent: Friday, September 7, 2018 6:13 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] Performance enabling of Event handler

2018-09-07 Thread Bi, Dandan
Hi, DP tool will filter some entries in which the time duration < 1ms by default. And you can use the" dp -t 0 "to dump all the Perf entries. Then to double check whether the entry you care exists or not. Thanks, Dandan -Original Message- From: prabin ca [mailto:prabinc...@gmail.com]

[edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues

2018-09-07 Thread Jian J Wang
There're two parameters which have different name in comment and prototype. Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/CpuDxe/CpuDxe.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation

2018-09-07 Thread Jian J Wang
The left operand is 64-bit but right operand could be 32-bit. A typecast is a must because of '~' op before it. Cc: Hao A Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/CpuDxe/CpuPageTable.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues

2018-09-07 Thread Bi, Dandan
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Jian J Sent: Saturday, September 8, 2018 11:24 AM To: edk2-devel ; edk2-devel@lists.01.org Cc: Bi, Dandan Subject: RE: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues Forgot to mention the BZ info: