Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

2018-11-26 Thread Laszlo Ersek
Hi Ard, On 11/23/18 13:14, Ard Biesheuvel wrote: > The ArmVirtQemu targets currently limit the size of the IPA space to > 40 bits because that is all what KVM supports. However, this is about > to change, and so we need to update the code if we want to ensure that > our UEFI firmware builds can

Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

2018-11-26 Thread Laszlo Ersek
On 11/23/18 13:14, Ard Biesheuvel wrote: > The ArmVirtQemu targets currently limit the size of the IPA space to > 40 bits because that is all what KVM supports. However, this is about > to change, and so we need to update the code if we want to ensure that > our UEFI firmware builds can keep

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Laszlo Ersek
On 11/26/18 10:42, Laszlo Ersek wrote: > On 11/23/18 13:14, Ard Biesheuvel wrote: >> + MaxAddress = (1UL << MaxAddressBits) - 1; > not 1 U;, which Sorry, typo: s/;/L/, clearly. (They are adjacent in my keyboard layout.) Laszlo ___ edk2-devel mailing

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Laszlo Ersek
On 11/26/18 10:42, Laszlo Ersek wrote: > On 11/23/18 13:14, Ard Biesheuvel wrote: >> In preparation of permitting the virt code to define a larger PA space >> size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the >> CPU actually supports, take the CPU's capabilities into account

Re: [edk2] [PATCH 4/5] ArmVirtPkg: disregard PcdPrePiCpuMemorySize PCD when sizing the GCD space

2018-11-26 Thread Laszlo Ersek
On 11/23/18 13:14, Ard Biesheuvel wrote: > Move the call to BuildCpuHob () into ArmVirtMemoryInitPeiLib (which is > shared between all the ArmVirtPkg targets), and drop the inclusion of > CpuPei.inf [which calls it on ArmVirtQemu] and the BuildCpuHob () call > from ArmVirtPrePiUniCoreRelocatable

Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 11:22, Laszlo Ersek wrote: > > On 11/23/18 13:14, Ard Biesheuvel wrote: > > The ArmVirtQemu targets currently limit the size of the IPA space to > > 40 bits because that is all what KVM supports. However, this is about > > to change, and so we need to update the code if we

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

2018-11-26 Thread Laszlo Ersek
Hi Liming, On 11/26/18 04:31, Gao, Liming wrote: > [...] Thanks, I think I understand your points better. That doesn't mean that I agree with all of your points. :) My suggestion/request is that this series please drop the OvmfPkg & ArmVirtPkg patches for now, as it's obvious that my

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Laszlo Ersek
On 11/23/18 13:14, Ard Biesheuvel wrote: > In preparation of permitting the virt code to define a larger PA space > size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the > CPU actually supports, take the CPU's capabilities into account when > setting up the page tables. This is

Re: [edk2] [PATCH 3/5] ArmVirtPkg: refactor reading of the physical address space size

2018-11-26 Thread Laszlo Ersek
On 11/23/18 13:14, Ard Biesheuvel wrote: > In preparation of dropping the hardcoded 40-bit limit on the physical > address space when running under virtualization, let's refactor the > code a bit so we read the hardware limit in a single place. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 5/5] ArmVirtPkg: revert PcdPrePiCpuMemorySize to is default value of 48

2018-11-26 Thread Laszlo Ersek
(1) s/is/its/ in $SUBJECT, please. On 11/23/18 13:14, Ard Biesheuvel wrote: > Drop the PcdPrePiCpuMemorySize definitions that limit it to 40 > bits on AArch64 targets. Indeed, after this series is applied, we still have [PcdsFixedAtBuild.ARM] gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 10:42, Laszlo Ersek wrote: > > On 11/23/18 13:14, Ard Biesheuvel wrote: > > In preparation of permitting the virt code to define a larger PA space > > size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the > > CPU actually supports, take the CPU's capabilities

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer & reviewer info for MdeModulePkg

2018-11-26 Thread Zeng, Star
Reviewed-by: Star Zeng Hao and Jian, thanks to spend effort as the maintainer. Star -Original Message- From: Wu, Hao A Sent: Tuesday, November 27, 2018 8:37 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star ; Wang, Jian J Subject: [PATCH] Maintainers.txt: Update maintainer &

[edk2] [PATCH] BaseTools: Remove GenVtf

2018-11-26 Thread Shenglei Zhang
GenVtf C tool is IPF specific. IPF support has been removed from edk2 trunk. This tool can be removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1349 v2:Remove GenVtf in Makefile and GNUmakefile. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-26 Thread Gary Lin
On Tue, Nov 20, 2018 at 02:37:44PM +, Gao, Liming wrote: > Reviewed-by: Liming Gao > Hi Liming, Would you mind to help to push to fix into the git repo? Thanks, Gary Lin > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Laszlo

Re: [edk2] Display Architecture and Bring Up in UEFI

2018-11-26 Thread Ni, Ruiyu
On 11/23/2018 5:19 PM, Laszlo Ersek wrote: On 11/23/18 07:27, prabin ca wrote: Hi Team, I’m new to UEFI and display interface in UEFI. I would like to have deep dive into how display is working in UEFI (display architecture) and how display is have been bring up (porting of display panel in

Re: [edk2] [PATCH] Maintainers.txt: Update maintainer & reviewer info for MdeModulePkg

2018-11-26 Thread Wang, Jian J
Thanks a lot to Star for his great works as MdeModulePkg maintainer. Reviewed-by: Jian J Wang > -Original Message- > From: Wu, Hao A > Sent: Tuesday, November 27, 2018 8:37 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Zeng, Star ; > Wang, Jian J > Subject: [PATCH]

[edk2] [PATCH v2 0/2] Remove DuetPkg and unused tools

2018-11-26 Thread Shenglei Zhang
DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was invented in the era when UEFI environment is hard to find. Since now UEFI is very popular in PC area, we could stop the official support of this package and remove it from the master. And moreover, the tools only used by DuetPkg

[edk2] [PATCH] Maintainers.txt: Update maintainer & reviewer info for MdeModulePkg

2018-11-26 Thread Hao Wu
Update Star as the reviewer of MdeModulePkg; Add Hao Wu as the 2nd maintainer of MdeModulePkg. Cc: Star Zeng Cc: Jian J Wang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- Maintainers.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-26 Thread Gao, Liming
Done at 385c0bf55a3e26dd1d3b5671f4ee69cd3f829baf. >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Tuesday, November 27, 2018 9:48 AM >To: Gao, Liming >Cc: Laszlo Ersek ; edk2-devel@lists.01.org; Kinney, >Michael D >Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the

[edk2] [PATCH v4 3/5] ArmPkg/Include: Fix the SPM version SVC ID

2018-11-26 Thread Sughosh Ganu
The MM_VERSION SMC call uses SMC32 calling convention. Fix the macro to reflect the correct value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH v4 4/5] ArmPkg/Include: Add MM interface SVC return codes.

2018-11-26 Thread Sughosh Ganu
From: Achin Gupta This patch adds the Management Mode(MM) - Secure Partition Manager(SPM) SVC return codes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 7 +++ 1 file changed, 7 insertions(+) diff

[edk2] [PATCH v4 5/5] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.

2018-11-26 Thread Sughosh Ganu
From: Achin Gupta The Standalone MM environment runs in S-EL0 in AArch64 on ARM Standard Platforms. Privileged firmware e.g. ARM Trusted Firmware sets up its architectural context including the initial translation tables for the S-EL1/EL0 translation regime. The MM environment will still request

[edk2] [PATCH v2 0/2] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-11-26 Thread Sughosh Ganu
Changes since v1: A new patch has been added to reflect the library class added for changing the MMU attributes in StandaloneMM image, based on review comments from Ard Biesheuvel. These patches needs to be applied on top of the following patch series - "ArmPkg related changes for StandaloneMM

[edk2] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid GUID value format

2018-11-26 Thread Eric Jin
Fix all GUID values defined in invalid format. Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../IHV/Protocol/SimpleNetwork/BlackBoxTest/Guid.h | 140 ++--- 1 file changed, 70 insertions(+), 70 deletions(-) diff

[edk2] [PATCH v4 0/5] ArmPkg related changes for StandaloneMM package

2018-11-26 Thread Sughosh Ganu
Changes since v3: Based on review comments from Ard, moved the MMU attribute changing functions for StandaloneMM image into a new library class. Moved the addition of memory space used as a MM_COMMUNICATE buffer to memory type 'EfiGcdMemoryTypeReserved' and removed the call to AllocatgePages.

[edk2] [PATCH v4 1/5] ArmPkg: Add PCDs needed for MM communication driver.

2018-11-26 Thread Sughosh Ganu
From: Achin Gupta This patch defines PCDs to describe the base address and size of communication buffer between normal world (uefi) and standalone MM environment in the secure world. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sughosh Ganu --- ArmPkg/ArmPkg.dec | 3

[edk2] [PATCH v4 2/5] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.

2018-11-26 Thread Sughosh Ganu
From: Achin Gupta PI v1.5 Specification Volume 4 defines Management Mode Core Interface and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a means of communicating between drivers outside of MM and MMI handlers inside of MM. This patch implements the EFI_MM_COMMUNICATION_PROTOCOL

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct Enable parameter in ReceiveFilters test

2018-11-26 Thread Eric Jin
The patch is applied to the EFI part. Fix bug - set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit in Enable parameter to make sure Multicast is enabled. Add one checkpoint when MCastFilterCount is zero Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric

[edk2] [PATCH v2 1/2] StandaloneMM: Include the newly added library class for MMU functions

2018-11-26 Thread Sughosh Ganu
The MMU functions needed for StandaloneMM image are now exported through a separate library class. Make the corresponding change in the core's entry point inf file so that it references the correct library class for modifying the MMU attributes. Contributed-under: TianoCore Contribution Agreement

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct Enable parameter in ReceiveFilters test

2018-11-26 Thread Eric Jin
The patch is applied to the IHV part. Fix bug - set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit in Enable parameter to make sure Multicast is enabled. Add one checkpoint when MCastFilterCount is zero Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric

[edk2] [PATCH v2 2/2] StandaloneMM: Update permissions for Standalone MM drivers memory area

2018-11-26 Thread Sughosh Ganu
The StandaloneMM image executes in S-EL0 on reference Arm platforms and is deployed by the trusted firmware as BL32 image. Memory for the Standalone MM drivers is marked as RW+XN initially, allowing the drivers to be loaded into the memory. Once loaded, the memory attributes need to be changed to

Re: [edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Ard Biesheuvel
On Fri, 23 Nov 2018 at 13:14, Ard Biesheuvel wrote: > > Add a helper function that returns the maximum physical address space > size as supported by the current CPU. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 4/5] ArmVirtPkg: disregard PcdPrePiCpuMemorySize PCD when sizing the GCD space

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 11:47, Laszlo Ersek wrote: > > On 11/23/18 13:14, Ard Biesheuvel wrote: > > Move the call to BuildCpuHob () into ArmVirtMemoryInitPeiLib (which is > > shared between all the ArmVirtPkg targets), and drop the inclusion of > > CpuPei.inf [which calls it on ArmVirtQemu] and

Re: [edk2] [Patch] Vlv2TbltDevicePkg: Add build instructions for Minnowboard Max.

2018-11-26 Thread Wei, David
Thanks Mike for the PACKAGE_PATH comment and the information of non-osi repo. I am also considering merging below three binary packages into one Vlv2BinaryPkg, post the ECP free Vlv2BinaryPkg on https://github.com/tianocore/edk2-non-osi/tree/master/Silicon/Intel/ , and protect it with the

Re: [edk2] [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information

2018-11-26 Thread Leif Lindholm
On Wed, Nov 21, 2018 at 02:26:23AM +0100, Marcin Wojtas wrote: > Hi Leif, > > śr., 14 lis 2018 o 18:33 Leif Lindholm napisał(a): > > > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > > I think all of my comments on this patch can be summarised as "what is > > > > an AP in

Re: [edk2] [PATCH 3/5] ArmVirtPkg: refactor reading of the physical address space size

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 11:00, Laszlo Ersek wrote: > > On 11/23/18 13:14, Ard Biesheuvel wrote: > > In preparation of dropping the hardcoded 40-bit limit on the physical > > address space when running under virtualization, let's refactor the > > code a bit so we read the hardware limit in a single

Re: [edk2] Newbie: Getting Ovmf built

2018-11-26 Thread Gao, Liming
Do you type ". edksetup.bat BaseTools" in Edk2 directory? What output of this command? This script will add edk2 BaseTools path into system PATH, then build can be used. And, you can use GCC5 as the default tool chain. It supports GCC 5.0 or the above version. > -Original Message- >

[edk2] [PATCH v2 2/2] Platform/ARM: Add Readme.md

2018-11-26 Thread Nariman Poushin
This covers the bulk of the information originally present in https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 regarding building and running the Foundation/Base FVP Platforms. The sections on fetching source have been delegated to the root Readme.md Signed-off-by:

[edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Nariman Poushin
Openssl is fetched as a git submodule, so make sure git clone --recursive is specified in the instructions to fetch a full source tree. Signed-off-by: Nariman Poushin --- Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Readme.md b/Readme.md index 6ad5953..bb53c6f

[edk2] [PATCH 2/2] Platform/ARM: Add Readme.md

2018-11-26 Thread Nariman Poushin
This covers the bulk of the information originally present in https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 regarding building and running the Foundation/Base FVP Platforms. The sections on fetching source have been delegated to the root Readme.md Signed-off-by:

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-26 Thread Leif Lindholm
On Fri, Nov 23, 2018 at 09:44:03AM +0100, Ard Biesheuvel wrote: > The deprecated BdsLib library class in ArmPkg is still depended upon, but > only a single implementation exists, which now resides in edk2-platforms. > > This implementation has some issues in how it deals with Device Paths, > so

Re: [edk2] [PATCH] ArmPkg: remove now unused BsdLib.h

2018-11-26 Thread Leif Lindholm
On Fri, Nov 23, 2018 at 07:54:59PM +0100, Ard Biesheuvel wrote: > The last remaining users of the BdsLib.h header reside in the > edk2-platforms tree, and so it has been copied there. This > allows us to remove the original from ArmPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH] Platform/Comcast: drop bogus BdsLib.h include

2018-11-26 Thread Leif Lindholm
On Fri, Nov 23, 2018 at 07:53:21PM +0100, Ard Biesheuvel wrote: > RdkBootManagerLib/RdkBootManagerLib.h includes BdsLib.h from ArmPkg > but does not actually depend on it. So drop the #include. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

2018-11-26 Thread Leif Lindholm
On Wed, Nov 21, 2018 at 01:01:42PM +0100, Ard Biesheuvel wrote: > Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank > NOR flash GUIDs. For the series: Reviewed-by: Leif Lindholm > Ard Biesheuvel (3): > Platform/ARM: replace hardcoded VenHW() device paths referring to

Re: [edk2] [PATCH] ArmPkg: remove now unused BsdLib.h

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 16:12, Leif Lindholm wrote: > > On Fri, Nov 23, 2018 at 07:54:59PM +0100, Ard Biesheuvel wrote: > > The last remaining users of the BdsLib.h header reside in the > > edk2-platforms tree, and so it has been copied there. This > > allows us to remove the original from ArmPkg.

Re: [edk2] [PATCH v2 edk2-platforms 0/3] Platform/ARM: fix DevicePath mishandling in BdsLib

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 16:06, Leif Lindholm wrote: > > On Fri, Nov 23, 2018 at 09:44:03AM +0100, Ard Biesheuvel wrote: > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This

Re: [edk2] [PATCH] ArmPkg: remove now unused BsdLib.h

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 17:50, Ard Biesheuvel wrote: > > On Mon, 26 Nov 2018 at 16:12, Leif Lindholm wrote: > > > > On Fri, Nov 23, 2018 at 07:54:59PM +0100, Ard Biesheuvel wrote: > > > The last remaining users of the BdsLib.h header reside in the > > > edk2-platforms tree, and so it has been

Re: [edk2] [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error

2018-11-26 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:50 AM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/UEFI: Fix invalid GUID value format error

Re: [edk2] [edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build

2018-11-26 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh -Original Message- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:51 AM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/build: Add support for GenBin tool build

Re: [edk2] [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool

2018-11-26 Thread Supreeth Venkatesh
With the latest edk2, I am getting this compilation error (even when this patch is applied). I will be looking at it tomorrow. Please check this out if you get a chance. GenBin

Re: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Nariman Poushin
Hi, Of course, I will resend both patches with the appropriate Contribution agreement. Thanks Nariman On Mon, 26 Nov 2018 at 14:11, Gao, Liming wrote: > Could you add [edk2-platform] in the title? So, I know this change is for > edk2-platform repo. > > And, please add Contributed-under:

[edk2] [edk2-platforms] [PATCH v3 2/2] Platform/ARM: Add Readme.md

2018-11-26 Thread Nariman Poushin
This covers the bulk of the information originally present in https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 regarding building and running the Foundation/Base FVP Platforms. The sections on fetching source have been delegated to the root Readme.md

Re: [edk2] [PATCH v2 2/2] Platform/ARM: Add Readme.md

2018-11-26 Thread Leif Lindholm
On Mon, Nov 26, 2018 at 01:17:48PM +, Nariman Poushin wrote: > This covers the bulk of the information originally present in > https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg-AArch64 > regarding building and running the Foundation/Base FVP Platforms. > > The sections on

Re: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Leif Lindholm
On Mon, Nov 26, 2018 at 01:10:53PM +, Nariman Poushin wrote: > Openssl is fetched as a git submodule, so make sure git clone --recursive > is specified in the instructions to fetch a full source tree. Can you add a Contributed-under: TianoCore Contribution Agreement 1.1 tag for all patches

Re: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Gao, Liming
Could you add [edk2-platform] in the title? So, I know this change is for edk2-platform repo. And, please add Contributed-under: TianoCore Contribution Agreement 1.1 before Signed-off-by. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

[edk2] [edk2-platforms] [PATCH v2 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Nariman Poushin
Openssl is fetched as a git submodule, so make sure git clone --recursive is specified in the instructions to fetch a full source tree. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Nariman Poushin --- Changes since v1: - Added Contribution Agreement tag

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB

2018-11-26 Thread Ard Biesheuvel
On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel wrote: > > This series fixes an issue reported by Hongbo and Philippe, where > ArmVirtQemuKernel will crash on an attempt to access flash bank #0, > which is secure-only when running QEMU with support for EL3. > > So let's switch to discovering the NOR

Re: [edk2] [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support

2018-11-26 Thread Ard Biesheuvel
On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > Branch: acpi_test_support > > The feature is described in the first patch. Build OvmfPkg and > ArmVirtPkg platforms with "--pcd PcdAcpiTestSupport=TRUE" to enable it. > > Cc: Anthony Perard > Cc:

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Leif Lindholm
On Fri, Nov 23, 2018 at 01:14:28PM +0100, Ard Biesheuvel wrote: > In preparation of permitting the virt code to define a larger PA space > size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the > CPU actually supports, take the CPU's capabilities into account when > setting up the

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 18:00, Ard Biesheuvel wrote: > > On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel > wrote: > > > > This series fixes an issue reported by Hongbo and Philippe, where > > ArmVirtQemuKernel will crash on an attempt to access flash bank #0, > > which is secure-only when running

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Leif Lindholm
On Mon, Nov 26, 2018 at 06:50:09PM +0100, Ard Biesheuvel wrote: > On Mon, 26 Nov 2018 at 18:46, Leif Lindholm wrote: > > > > On Fri, Nov 23, 2018 at 01:14:28PM +0100, Ard Biesheuvel wrote: > > > In preparation of permitting the virt code to define a larger PA space > > > size via

Re: [edk2] [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 16:15, Leif Lindholm wrote: > > On Wed, Nov 21, 2018 at 01:01:42PM +0100, Ard Biesheuvel wrote: > > Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank > > NOR flash GUIDs. > > For the series: > Reviewed-by: Leif Lindholm > Thanks Pushed as

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 18:46, Leif Lindholm wrote: > > On Fri, Nov 23, 2018 at 01:14:28PM +0100, Ard Biesheuvel wrote: > > In preparation of permitting the virt code to define a larger PA space > > size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the > > CPU actually supports,

Re: [edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 12:46, Ard Biesheuvel wrote: > On Fri, 23 Nov 2018 at 13:14, Ard Biesheuvel > wrote: >> >> Add a helper function that returns the maximum physical address space >> size as supported by the current CPU. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by:

Re: [edk2] [edk2-announce] Research Request

2018-11-26 Thread stephano
Excellent. Thank you for all your work here. I'll be compiling information regarding all our options on the wiki and we can further discuss them at our Community Meeting in December. I'll share the link to the wiki post once it is live on this mailing list. Cheers, Stephano On 11/26/2018

[edk2] [PATCH v2 07/13] BeagleBoardPkg/PrePi: base GCD memory space size on CPU's PA range

2018-11-26 Thread Ard Biesheuvel
Derive the size of the GCD memory space map directly from the CPU's information registers rather than from the PcdPrePiCpuMemorySize PCD, which will be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/PrePi/PeiUniCore.inf | 1 -

[edk2] [PATCH v2 03/13] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

2018-11-26 Thread Ard Biesheuvel
In preparation of dropping PcdPrePiCpuMemorySize entirely, base the maximum size of the identity map on the capabilities of the CPU. Since that may exceed what is architecturally permitted when using 4 KB pages, take ARM_MMU_IDMAP_RANGE into account as well. Contributed-under: TianoCore

[edk2] [PATCH v2 06/13] ArmVirtPkg/PrePi: base GCD memory space size on CPU's PA range

2018-11-26 Thread Ard Biesheuvel
Derive the size of the GCD memory space map directly from the CPU's information registers rather than from the PcdPrePiCpuMemorySize PCD, which will be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 02/13] ArmVirtPkg: refactor reading of the physical address space size

2018-11-26 Thread Ard Biesheuvel
In preparation of dropping the hardcoded 40-bit limit on the physical address space when running under virtualization, let's refactor the code a bit so we read the hardware limit in a single place. Note that the hardware capabilities may exceed what the architecture permits when using 4 KB pages,

[edk2] [PATCH v2 09/13] ArmPlatformPkg/PlatformPei: drop unused PCD references

2018-11-26 Thread Ard Biesheuvel
Drop some PCD references that are not actually referenced from the PlatformPei code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf | 3 --- ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 3 --- 2 files

[edk2] [PATCH v2 04/13] ArmPkg/CpuPei: base GCD memory space size on CPU's PA range

2018-11-26 Thread Ard Biesheuvel
Derive the size of the GCD memory space map directly from the CPU's information registers rather than from the PcdPrePiCpuMemorySize PCD, which will be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuPei/CpuPei.inf | 1 -

[edk2] [PATCH v2 08/13] EmbeddedPkg/PrePiHobLib: base GCD memory space size on CPU's PA range

2018-11-26 Thread Ard Biesheuvel
Derive the size of the GCD memory space map directly from the CPU's information registers rather than from the PcdPrePiCpuMemorySize PCD, which will be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 01/13] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Ard Biesheuvel
Add a helper function that returns the maximum physical address space size as supported by the current CPU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/ArmLib.h | 17 +

[edk2] [PATCH v2 00/13] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

2018-11-26 Thread Ard Biesheuvel
The ArmVirtQemu targets currently limit the size of the IPA space to 40 bits because that is all what KVM supports. However, this is about to change, and so we need to update the code if we want to ensure that our UEFI firmware builds can keep running on systems that set values other than 40

[edk2] [PATCH v2 05/13] ArmPlatformPkg/PrePi: base GCD memory space size on CPU's PA range

2018-11-26 Thread Ard Biesheuvel
Derive the size of the GCD memory space map directly from the CPU's information registers rather than from the PcdPrePiCpuMemorySize PCD, which will be removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 -

[edk2] [PATCH v2 13/13] EmbeddedPkg/EmbeddedPkg.dec: drop PcdPrePiCpuMemorySize declarations

2018-11-26 Thread Ard Biesheuvel
PcdPrePiCpuMemorySize is no longer used so drop the declarations from the package DEC file. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dec | 4 1 file changed, 4 deletions(-) diff --git a/EmbeddedPkg/EmbeddedPkg.dec

[edk2] [PATCH v2 11/13] ArmVirtPkg/QemuVirtMemInfoLib: ignore PcdPrePiCpuMemorySize

2018-11-26 Thread Ard Biesheuvel
Now that the size of the GCD memory map is based directly on the CPU's capabilities, we no longer have a need for PcdPrePiCpuMemorySize and so it will be removed. So drop it from QemuVirtMemInfoLib as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 12/13] ArmVirtPkg: drop PcdPrePiCpuMemorySize assignments from all platforms

2018-11-26 Thread Ard Biesheuvel
PcdPrePiCpuMemorySize is no longer used so drop the PCD overrides from all platform descriptions in ArmVirtPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirt.dsc.inc | 3 --- ArmVirtPkg/ArmVirtQemu.dsc | 4

[edk2] [PATCH v2 10/13] EmbeddedPkg/PrePiLib: drop unused PCD reference

2018-11-26 Thread Ard Biesheuvel
Drop the reference to gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize which is never used. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [edk2] [PATCH v2 01/13] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Philippe Mathieu-Daudé
On 26/11/18 23:37, Ard Biesheuvel wrote: > Add a helper function that returns the maximum physical address space > size as supported by the current CPU. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [edk2] [PATCH v2 01/13] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Philippe Mathieu-Daudé
On Mon, Nov 26, 2018 at 11:43 PM Philippe Mathieu-Daudé wrote: > > On 26/11/18 23:37, Ard Biesheuvel wrote: > > Add a helper function that returns the maximum physical address space > > size as supported by the current CPU. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > >

Re: [edk2] [PATCH v2 01/13] ArmPkg/ArmLib: add support for reading the max physical address space size

2018-11-26 Thread Ard Biesheuvel
On Tue, 27 Nov 2018 at 00:02, Philippe Mathieu-Daudé wrote: > > On Mon, Nov 26, 2018 at 11:43 PM Philippe Mathieu-Daudé > wrote: > > > > On 26/11/18 23:37, Ard Biesheuvel wrote: > > > Add a helper function that returns the maximum physical address space > > > size as supported by the current

Re: [edk2] [edk2-announce] Research Request

2018-11-26 Thread Jeremiah Cox via edk2-devel
Feedback on GitHub as follows… > 1. No Lock-In - What automated data export is available? > We want to be able to leave and take all our data with us. "Data" here > includes: review comments, pull requests / patches (including metadata), > old (rejected) pull requests and metadata, issue

Re: [edk2] [PATCH 1/4] OvmfPkg: introduce ACPI Test Support data structure and GUID

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 25/11/18 11:01, Laszlo Ersek wrote: > QEMU's test suite includes a set of cases called "BIOS tables test". Among > other things, it locates the RSD PTR ACPI table in guest RAM, and then > (chasing pointers to other ACPI tables) performs various sanity checks on > the QEMU-generated