[edk2] BlockIo2 Protocol test tool

2019-01-25 Thread Sajeesh Kk
Hello all, I have a prototype BlockIO2 protocol implementation. Are there any independent tools available to test this out ?. Please let me know. Thanks, Sajeesh. ___ edk2-devel mailing list edk2-devel@lists.01.org

[edk2] [PATCH] BaseTools:Define Macro in Inf file, the pcdvalue Can't convert

2019-01-25 Thread Fan, ZhijuX
Define Macro in Inf file, the pcdvalue Can't convert in dec: gUefiOvmfPkgGuid.test1|"ddd"|VOID*|0x3c in inf: DEFINE ABC=PATH gUefiOvmfPkgTokenSpaceGuid.test1|$(ABC) Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan ---

Re: [edk2] [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib

2019-01-25 Thread Ard Biesheuvel
On Fri, 25 Jan 2019 at 11:29, Jagadeesh Ujja wrote: > > hi Ard > > On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel > wrote: > > > > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja wrote: > > > > > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries > > > on > > > Sgi

[edk2] [Patch] BaseTools: Enable CODE format in DEC file

2019-01-25 Thread Feng, Bob C
Enable CODE format in DEC File. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 38 +++ .../Source/Python/Workspace/MetaFileParser.py | 99 ---

Re: [edk2] [Patch] BaseTools: Enable CODE format in DEC file

2019-01-25 Thread Feng, Bob C
Hi Laszlo, There is a BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1292. This patch is to implement the CODE format support in DEC file. I'll re-sent this patch with this link. Thanks, Bob -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, January 25,

Re: [edk2] Network Stack Budgeting

2019-01-25 Thread Wu, Jiaxin
Hi Tom, One thing I want to highlight is that our design of network stack is not only for the PXE/HTTP boot trigged in BootManager, but also to make sure it's workable once there is any MNP instance configured by upper drivers (ARP/IPv4/IPv6). Take ARP/IP as an example, once ARP/IP are

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-25 Thread Laszlo Ersek
Hi Bob, On 01/25/19 05:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55 > > This patch set is to enable python3 on BaseTools. Basetools code will be > compatible with both python3 and python2. > > We will have two envs PYTHON3_ENABLE and PYTHON_COMMAND. The

Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid.

2019-01-25 Thread Laszlo Ersek
On 01/25/19 00:18, Neo Hsueh wrote: > 1.Skip runtime relocation for PE images that provide invalid relocation > infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting > Windows. > 2.Add a magic number check for PE32+ image. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 1/3] MdeModulePkg/CapsuleApp: Refine code logic of parsing parameter.

2019-01-25 Thread Gao, Liming
Chao: CapsuleApp can base on gEfiShellProtocolGuid and gEfiShellParametersProtocolGuid to do it. Current CapsuleApp bases on these two protocols to parse the parameters. Thanks Liming From: Zhang, Chao B Sent: Friday, January 25, 2019 3:24 PM To: Yao, Jiewen ; edk2-devel@lists.01.org; Gao,

Re: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5

2019-01-25 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, January 25, 2019 4:12 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Bi, Dandan ; >Wang, Jian J ; Ard Biesheuvel > >Subject: [PATCH] MdeModulePkg/MdeModulePkg.dsc:

Re: [edk2] [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib

2019-01-25 Thread Ard Biesheuvel
On Fri, 25 Jan 2019 at 11:46, Ard Biesheuvel wrote: > > On Fri, 25 Jan 2019 at 11:29, Jagadeesh Ujja wrote: > > > > hi Ard > > > > On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel > > wrote: > > > > > > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja > > > wrote: > > > > > > > > Include the

Re: [edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support

2019-01-25 Thread Gao, Liming
Chen: I agree with Hao. For UEFI definition, please add EFI_ prefix. And, reuse the existing definition, not introduce new one. Thanks Liming >-Original Message- >From: Wu, Hao A >Sent: Friday, January 25, 2019 3:47 PM >To: Chen, Chen A ; Gao, Liming >; edk2-devel@lists.01.org >Cc:

Re: [edk2] [Patch] BaseTools: Enable CODE format in DEC file

2019-01-25 Thread Laszlo Ersek
Hi Bob, On 01/25/19 09:58, Feng, Bob C wrote: > Enable CODE format in DEC File. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > .../Source/Python/Workspace/DscBuildData.py | 38 +++ >

[edk2] [Patch V2] BaseTools: Enable CODE format in DEC file

2019-01-25 Thread Feng, Bob C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1292. Enable CODE format in DEC File. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- .../Source/Python/Workspace/DscBuildData.py | 38 +++ .../Source/Python/Workspace/MetaFileParser.py

[edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5

2019-01-25 Thread Ard Biesheuvel
The newly added standalone MM versions of the FTW and variable runtime drivers were included in MdeModulePkg.dsc to get test coverage when building the package from its own .dsc, but the resulting modules are non-functional since they incorporate some dummy libraries. Dandan reports that these

Re: [edk2] [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib

2019-01-25 Thread Ard Biesheuvel
On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja wrote: > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on > Sgi platforms. These will be consumed by MM_STANDALONE drivers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jagadeesh Ujja > ---

Re: [edk2] [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib

2019-01-25 Thread Jagadeesh Ujja
hi Ard On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel wrote: > > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja wrote: > > > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on > > Sgi platforms. These will be consumed by MM_STANDALONE drivers. > > > > Contributed-under:

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-25 Thread Feng, Bob C
Hi Laszlo, (1) Yes. There are some fixes. I think you performed the testing on Liming's repository https://github.com/lgao4/edk2/tree/Python3. I am not sure which specific version were you using but we did some fixes in recent days. The repository link(https://github.com/BobCF/edk2.git branch

Re: [edk2] Network Stack Budgeting

2019-01-25 Thread Tomas Pilar (tpilar)
Yeah, that makes sense I suppose. The end result is however that the network device is 'opened' as soon as ConnectController() is called rather than when someone wants to do networking. This seems wrong and directly leads to a DoS of a platform in case of heavy network load (unless we implement

Re: [edk2] [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Stefan Berger
I have to repost this since my email has changed. On 1/25/19 11:55 AM, Stefan Berger wrote: This patch adds the TCG2 Configuration menu to the Device Manager menu. We can reuse all the code in the SecurityPkg and need to only add it to the build and flash config files. The code is added to

[edk2] [Patch 1/2] SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI Specification 1.2 Revision 8" https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf Upgrade TCG PC Client Platform Physical Presence Interface Specification Version 1.3 Revision 0.52"

[edk2] [Patch 0/2] Update UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
Update UEFI supporting TCG spec info Zhang, Chao B (2): SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +-- SecurityPkg/SecurityPkg.dec| 2 +-

Re: [edk2] Text attachments

2019-01-25 Thread stephano
On 1/24/2019 3:38 AM, Tomas Pilar (tpilar) wrote: Hi, Does the mailing list support plaintext attachments? As Laszlo mentioned, sadly, no. Please know that we are working to address this issue. We are currently evaluating Groups.io which, so far, has proven a feature-rich replacement for

[edk2] [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Stefan Berger
This patch adds the TCG2 Configuration menu to the Device Manager menu. We can reuse all the code in the SecurityPkg and need to only add it to the build and flash config files. The code is added to Ovfm by building with -DTPM2_ENABLE and -DTPM2_CONFIG_ENABLE. Signed-off-by: Stefan Berger ---

[edk2] [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI Specification 1.2 Revision 8" https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yao Jiewen Signed-off-by: Zhang, Chao B

Re: [edk2] [PATCH 1/3] MdeModulePkg/CapsuleApp: Refine code logic of parsing parameter.

2019-01-25 Thread Carsey, Jaben
I think that if the application wants to depend on the libs, then we should discuss moving the application to the ShellPkg. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gao, Liming > Sent: Friday, January 25, 2019 1:25 AM > To:

Re: [edk2] [PATCH] ShellPkg/TftpDynamicCommand: Return proper status

2019-01-25 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And pushed with the BZ added to commit REF. > -Original Message- > From: Li, Songpeng > Sent: Thursday, January 24, 2019 9:08 PM > To: Vladimir Olovyannikov ; edk2- > de...@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2] [PATCH]

Re: [edk2] Do python3 supported in edk2 shell now?

2019-01-25 Thread Richardson, Brian
There is a MicroPython interpreter in edk2-staging which is being developed to address Python 3.x support. Please evaluate and report any issues you see as this code transitions out of the staging branch. https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework

Re: [edk2] [Patch 00/33] BaseTools python3 migration patch set

2019-01-25 Thread Laszlo Ersek
On 01/25/19 10:42, Feng, Bob C wrote: > [...] > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 25, 2019 4:57 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch 00/33] BaseTools python3 migration patch

Re: [edk2] [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Laszlo Ersek
Hi, (1) when posting a patch, please CC all people marked with "M" for the subject package in Maintainers.txt. And, if in doubt, please CC the "R" people too. Adding the others now. (2) In [a] [b], you mentioned a need to repost, due to your email address having changed. However, that posting,

[edk2] [Patch v2] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Stefan Berger
This patch adds the TCG2 Configuration menu to the Device Manager menu. We can apparently reuse the sample Tcg2ConfigDxe from SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The added TCG2 Configuration menu now shows details about the attached TPM 2.0 and lets one for example

Re: [edk2] Drop CSM support in OvmfPkg?

2019-01-25 Thread Brian J. Johnson
On 1/24/19 5:30 AM, Laszlo Ersek wrote: On 01/24/19 10:31, David Woodhouse wrote: On Thu, 2019-01-24 at 01:48 +, Ni, Ray wrote: David, I think we got an agreement here to move CSM components in OvmfPkg. I prefer we firstly clone the required CSM components in OvmfPkg right no. Finally I

Re: [edk2] [PATCH] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu

2019-01-25 Thread Stefan Berger
On 1/25/19 2:30 PM, Laszlo Ersek wrote: Hi, (1) when posting a patch, please CC all people marked with "M" for the subject package in Maintainers.txt. And, if in doubt, please CC the "R" people too. Adding the others now. (2) In [a] [b], you mentioned a need to repost, due to your email

Re: [edk2] [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info

2019-01-25 Thread Yao, Jiewen
Hi Chao Do you think we need provide a way to let a platform fill " PlatformSpecificParameters ", then the core driver can fill laml and lasl ? Thank you Yao Jiewen > -Original Message- > From: Zhang, Chao B > Sent: Friday, January 25, 2019 11:31 PM > To: edk2-devel@lists.01.org > Cc:

Re: [edk2] [PATCH 1/3] MdeModulePkg/CapsuleApp: Refine code logic of parsing parameter.

2019-01-25 Thread Yao, Jiewen
Exactly. Currently APP is using that to parse parameter. Would you please clarify why we cannot use the same way? Thank you Yao Jiewen From: Gao, Liming Sent: Friday, January 25, 2019 5:25 PM To: Zhang, Chao B ; Yao, Jiewen ; edk2-devel@lists.01.org Cc: Wu, Hao A ; Chen, Chen A ; Gao, Liming

Re: [edk2] [PATCH] IntelFsp2Pkg: FSP can utilize bootloader stack

2019-01-25 Thread Desimone, Nathaniel L
Hi Chasel, I agree with Star that we should just take "Bootloader stack" out of the diagram for scenario 1. It doesn't matter where in the memory map the bootloader stack is really. My only extra comment is the definition for AsmReadEsp() should be placed in SecMain.h instead of SecMain.c.

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 2/6] ClevoOpenBoardPkg/N1xxWU: Add headers

2019-01-25 Thread Michael Kubacki
Based on KabylakeOpenBoardPkg from the following branch: https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform Header files for the N1XXWU Clevo board instance. * PeiPchPolicyUpdate.h - Shared interfaces and includes used for Platform Controller Hub (PCH) initialization in

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 3/6] ClevoOpenBoardPkg: Add library instances

2019-01-25 Thread Michael Kubacki
Based on KabylakeOpenBoardPkg from the following branch: https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform Library instances shared across Clevo board instances. * BaseGpioExpanderLib - Support for the TCA6424 IO expander. * PeiI2cAccessLib - Provides I2C read and write

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 6/6] ClevoOpenBoardPkg/N1xxWU: Add DSC and build files

2019-01-25 Thread Michael Kubacki
Based on KabylakeOpenBoardPkg from the following branch: https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform Adds the DSC and build files necessary to build the N1xxWU Clevo board instance. The board follows the same build procedure as other OpenBoardPkg instances in

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 0/6] Add initial ClevoOpenBoardPkg

2019-01-25 Thread Michael Kubacki
This series adds a new board package in Platform/Intel for Clevo boards. This provides a board implementation for use with the MinPlatformPkg. Currently, this is largely a copy of KabylakeOpenBoardPkg with the name refactored. It is intended to serve as a base for future community development. A

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 1/6] ClevoOpenBoardPkg: Add package and headers

2019-01-25 Thread Michael Kubacki
Based on KabylakeOpenBoardPkg from the following branch: https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform Create the ClevoOpenBoardPkg to provide an initial board package for Clevo boards. The ClevoOpenBoardPkg is intended to contain a series of specific Clevo board instances